[PATCH net] net: phy: realtek: Replace phy functions with non-locked version in rtl8211e_config_init()

2019-05-12 Thread Kunihiko Hayashi
After calling phy_select_page() and until calling phy_restore_page(), the mutex 'mdio_lock' is already locked, so the driver should use non-locked version of phy functions. Or there will be a deadlock with 'mdio_lock'. This replaces phy functions called from rtl8211e_config_init() to avoid the dea

Re: [PATCH net] vhost_net: fix possible infinite loop

2019-05-12 Thread Jason Wang
On 2019/5/13 上午1:10, Michael S. Tsirkin wrote: On Sun, May 05, 2019 at 12:20:24PM +0800, Jason Wang wrote: On 2019/4/26 下午3:35, Jason Wang wrote: On 2019/4/26 上午1:52, Michael S. Tsirkin wrote: On Thu, Apr 25, 2019 at 03:33:19AM -0400, Jason Wang wrote: When the rx buffer is too small for a

Re: [PATCH v2 1/2] net: phy: realtek: Add rtl8211e rx/tx delays config

2019-05-12 Thread Guenter Roeck
Hi, On Sat, Apr 27, 2019 at 12:21:11AM +0300, Serge Semin wrote: > There are two chip pins named TXDLY and RXDLY which actually adds the 2ns > delays to TXC and RXC for TXD/RXD latching. Alas this is the only > documented info regarding the RGMII timing control configurations the PHY > provides. I

[PATCH net] vhost: don't use kmap() to log dirty pages

2019-05-12 Thread Jason Wang
Vhost log dirty pages directly to a userspace bitmap through GUP and kmap_atomic() since kernel doesn't have a set_bit_to_user() helper. This will cause issues for the arch that has virtually tagged caches. The way to fix is to keep using userspace virtual address. Fortunately, futex has arch_futex

Re: [RFC PATCH V2] vhost: don't use kmap() to log dirty pages

2019-05-12 Thread Jason Wang
On 2019/5/10 下午12:48, Jason Wang wrote: On 2019/5/10 上午10:59, Jason Wang wrote:     r = get_user_pages_fast(log, 1, 1, &page); OK so the trick is that page is pinned so you don't expect arch_futex_atomic_op_inuser below to fail. get_user_pages_fast guarantees page is not going away but

RE: [EXT] Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order

2019-05-12 Thread Andy Duan
From: Maxime Ripard Sent: Friday, May 10, 2019 7:32 PM > On Fri, May 10, 2019 at 01:28:22PM +0200, Petr Štetiar wrote: > > Andy Duan [2019-05-10 08:23:58]: > > > > Hi Andy, > > > > you've probably forget to Cc some maintainers and mailing lists, so > > I'm adding them now to the Cc loop. This pa

RE: [EXT] Re: [PATCH net 2/3] of_net: add property "nvmem-mac-address" for of_get_mac_addr()

2019-05-12 Thread Andy Duan
From: Andrew Lunn Sent: Saturday, May 11, 2019 2:18 AM > On Fri, May 10, 2019 at 08:24:03AM +, Andy Duan wrote: > > If MAC address read from nvmem cell and it is valid mac address, > > .of_get_mac_addr_nvmem() add new property "nvmem-mac-address" in > > ethernet node. Once user call .of_get_ma

Re: Annoying gcc / rdma / networking warnings

2019-05-12 Thread David Miller
From: Jason Gunthorpe Date: Mon, 13 May 2019 01:11:42 + > I think the specific sockaddr types should only ever be used if we > *know* the sa_family is that type. If the sa_family is not known then > it should be sockaddr or sockaddr_storage. Otherwise things get very > confusing. > > When us

RE: [EXT] Re: [PATCH net 1/3] net: ethernet: add property "nvmem_macaddr_swap" to swap macaddr bytes order

2019-05-12 Thread Andy Duan
From: Andrew Lunn Sent: Saturday, May 11, 2019 2:17 AM > On Fri, May 10, 2019 at 08:24:00AM +, Andy Duan wrote: > > ethernet controller driver call .of_get_mac_address() to get the mac > > address from devictree tree, if these properties are not present, then > > try to read from nvmem. > > >

RE: [EXT] Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order

2019-05-12 Thread Andy Duan
From: Petr Štetiar Sent: Friday, May 10, 2019 7:28 PM > Andy Duan [2019-05-10 08:23:58]: > > Hi Andy, > > you've probably forget to Cc some maintainers and mailing lists, so I'm adding > them now to the Cc loop. This patch series should be posted against net-next > tree as per netdev FAQ[0], bu

Re: pull-request: bpf 2019-05-13

2019-05-12 Thread David Miller
From: Daniel Borkmann Date: Mon, 13 May 2019 02:15:37 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix out of bounds backwards jumps due to a bug in dead code >removal, from Daniel. > > 2) Fix libbpf users by detecting unsupp

Re: [PATCH v2] samples: guard sub-directories with CONFIG options

2019-05-12 Thread Masahiro Yamada
On Thu, May 9, 2019 at 10:01 AM Masahiro Yamada wrote: > > Do not descend to sub-directories when unneeded. > > I used subdir-$(CONFIG_...) for hidraw, seccomp, and vfs because > they only contain host programs. > > While we are here, let's add SPDX License tag, and sort the directories > alphabet

[PATCH net-next] ipv4: Add support to disable icmp timestamp

2019-05-12 Thread Weilong Chen
The remote host answers to an ICMP timestamp request. This allows an attacker to know the time and date on your host. This path is an another way contrast to iptables rules: iptables -A input -p icmp --icmp-type timestamp-request -j DROP iptables -A output -p icmp --icmp-type timestamp-reply -j DR

Re: Annoying gcc / rdma / networking warnings

2019-05-12 Thread Jason Gunthorpe
On Sat, May 11, 2019 at 12:52:06PM -0400, Linus Torvalds wrote: > Jason and Davem, > with gcc-9, I'm now seeing a number of annoying warnings from the > rdma layer. I think it depends on the exact gcc version, because I'm > seeing them on my laptop but didn't see them on my desktop, probably > due

pull-request: bpf 2019-05-13

2019-05-12 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix out of bounds backwards jumps due to a bug in dead code removal, from Daniel. 2) Fix libbpf users by detecting unsupported BTF kernel features and sanitize them before load, from An

Re: [PATCH bpf v1] bpf: Fix undefined behavior in narrow load handling

2019-05-12 Thread Daniel Borkmann
On 05/10/2019 12:16 PM, Krzesimir Nowak wrote: > On Thu, May 9, 2019 at 11:30 PM Daniel Borkmann wrote: >> On 05/08/2019 06:08 PM, Krzesimir Nowak wrote: >>> Commit 31fd85816dbe ("bpf: permits narrower load from bpf program >>> context fields") made the verifier add AND instructions to clear the >

Re: [PATCH v3 bpf] libbpf: detect supported kernel BTF features and sanitize BTF

2019-05-12 Thread Daniel Borkmann
On 05/12/2019 03:09 AM, Stanislav Fomichev wrote: > On 05/11, Andrii Nakryiko wrote: >> On Fri, May 10, 2019 at 3:00 PM Stanislav Fomichev wrote: >>> On 05/10, Andrii Nakryiko wrote: On Fri, May 10, 2019 at 2:36 PM Stanislav Fomichev wrote: > On 05/10, Andrii Nakryiko wrote: >>

Re: [PATCH bpf 0/4] bpf: fix documentation for BPF helper functions

2019-05-12 Thread Daniel Borkmann
On 05/10/2019 04:51 PM, Quentin Monnet wrote: > Another round of fixes for the doc in the BPF UAPI header, which can be > turned into a manual page. First patch is the most important, as it fixes > parsing for the bpf_strtoul() helper doc. Following patches are formatting > fixes (nitpicks, mostly)

Re: [PATCH v2] selftests: bpf: Add files generated after build to .gitignore

2019-05-12 Thread Daniel Borkmann
On 05/12/2019 09:29 AM, Kelsey Skunberg wrote: > The following files are generated after building /selftests/bpf/ and > should be added to .gitignore: > > - libbpf.pc > - libbpf.so.* > > Signed-off-by: Kelsey Skunberg Applied, thanks.

[PATCH net] net: meson: fixup g12a glue ephy id

2019-05-12 Thread Jerome Brunet
The phy id chosen by Amlogic is incorrectly set in the mdio mux and does not match the phy driver. It was not detected before because DT forces the use the correct driver for the internal PHY. Fixes: 7090425104db ("net: phy: add amlogic g12a mdio mux support") Reported-by: Qi Duan Signed-off-by:

Re: [PATCH] net: dccp : proto: remove Unneeded variable "err"

2019-05-12 Thread David Miller
From: Hariprasad Kelam Date: Sun, 12 May 2019 16:09:49 +0530 > Fix below issue reported by coccicheck > > > net/dccp/proto.c:266:5-8: Unneeded variable: "err". Return "0" on line > 310 > > Signed-off-by: Hariprasad Kelam Applied.

Re: [PATCH net 0/3] Fix a bug and avoid dangerous usage patterns

2019-05-12 Thread David Miller
From: Vladimir Oltean Date: Sat, 11 May 2019 23:14:44 +0300 > Making DSA use the sk_buff control block was my idea during the > 'Traffic-support-for-SJA1105-DSA-driver' patchset, and I had also > introduced a series of macro helpers that turned out to not be so > helpful: > > 1. DSA_SKB_ZERO() z

Re: [PATCH net] vhost_net: fix possible infinite loop

2019-05-12 Thread Michael S. Tsirkin
On Sun, May 05, 2019 at 12:20:24PM +0800, Jason Wang wrote: > > On 2019/4/26 下午3:35, Jason Wang wrote: > > > > On 2019/4/26 上午1:52, Michael S. Tsirkin wrote: > > > On Thu, Apr 25, 2019 at 03:33:19AM -0400, Jason Wang wrote: > > > > When the rx buffer is too small for a packet, we will discard the

Re: [PATCH v2 1/8] vsock/virtio: limit the memory used per-socket

2019-05-12 Thread Michael S. Tsirkin
On Fri, May 10, 2019 at 02:58:36PM +0200, Stefano Garzarella wrote: > Since virtio-vsock was introduced, the buffers filled by the host > and pushed to the guest using the vring, are directly queued in > a per-socket list avoiding to copy it. > These buffers are preallocated by the guest with a fix

Your products and partnership

2019-05-12 Thread COSTCO WHOLESALE UK
Hi COSTCO WHOLESALE UK LIMITED are looking to buy your products and partner with your company, can you please send us your Catalog or your website to learn more about your products or prices list by email and if we can make some order with you and start a long-term partnership. Can your com

Re: NVMEM address DT post processing [Was: Re: [PATCH net 0/3] add property "nvmem_macaddr_swap" to swap macaddr bytes order]

2019-05-12 Thread Maxime Ripard
On Sat, May 11, 2019 at 04:44:44PM +0200, Petr Štetiar wrote: > So something like this? > > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.txt > b/Documentation/devicetree/bindings/nvmem/nvmem.txt > index fd06c09b822b..d781e47b049d 100644 > --- a/Documentation/devicetree/bindings/nvmem

[PATCH] net: dccp : proto: remove Unneeded variable "err"

2019-05-12 Thread Hariprasad Kelam
Fix below issue reported by coccicheck net/dccp/proto.c:266:5-8: Unneeded variable: "err". Return "0" on line 310 Signed-off-by: Hariprasad Kelam --- net/dccp/proto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/dccp/proto.c b/net/dccp/proto.c index 0e2f71a..5dd85e

Re: [PATCH] net/mlx5e: Allow matching only enc_key_id/enc_dst_port for decapsulation action

2019-05-12 Thread Roi Dayan
On 06/05/2019 21:28, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > In some case, we don't care the enc_src_ip and enc_dst_ip, and > if we don't match the field enc_src_ip and enc_dst_ip, we can use > fewer flows in hardware when revice the tunnel packets. For example, > the tunnel p

Re: [PATCH net-next RFC] Dump SW SQ context as part of tx reporter

2019-05-12 Thread Aya Levin
On 5/9/2019 11:23 AM, Jiri Pirko wrote: > Tue, May 07, 2019 at 02:58:32PM CEST, a...@mellanox.com wrote: >> >> >> On 5/7/2019 3:41 PM, Jiri Pirko wrote: >>> Mon, Apr 29, 2019 at 04:17:39PM CEST, a...@mellanox.com wrote: TX reporter reports an error on two scenarios: - TX timeout on a sp

Re: [PATCH] selftests: bpf: Add files generated when compiled to .gitignore

2019-05-12 Thread Kelsey Skunberg
On Sat, May 11, 2019 at 11:29:07PM -0700, Stanislav Fomichev wrote: > On 05/11, Kelsey Skunberg wrote: > > The following files are generated when /selftests/bpf/ is compiled and > > should be added to .gitignore: > > > > - libbpf.pc > > - libbpf.so.0 > > - libbpf.so.0.0.3 > > > > Sign

Re: [Regression] "net: phy: realtek: Add rtl8211e rx/tx delays config" breaks rk3328-roc-cc networking

2019-05-12 Thread Heiner Kallweit
On 12.05.2019 04:50, Peter Geis wrote: > On 5/11/2019 10:37 PM, Andrew Lunn wrote: >> On Sat, May 11, 2019 at 07:17:08PM -0400, Peter Geis wrote: >>> Good Evening, >>> >>> Commit f81dadbcf7fd067baf184b63c179fc392bdb226e "net: phy: realtek: Add >>> rtl8211e rx/tx delays config" breaks networking com

[PATCH v2] selftests: bpf: Add files generated after build to .gitignore

2019-05-12 Thread Kelsey Skunberg
The following files are generated after building /selftests/bpf/ and should be added to .gitignore: - libbpf.pc - libbpf.so.* Signed-off-by: Kelsey Skunberg --- Change since v1: - Add libbpf.so.* in replace of libbpf.so.0 and libbpf.so.0.0.3 - Update com