Re: selftests/bpf/test_tag takes ~30 minutes?

2019-05-06 Thread Michael Ellerman
Daniel Borkmann writes: > On 04/30/2019 03:21 PM, Michael Ellerman wrote: >> Hi Daniel, >> >> I'm running selftests/bpf/test_tag and it's taking roughly half an hour >> to complete, is that expected? >> >> I don't really grok what the test is doing TBH, but it does appear to be >> doing it 5 tim

Re: [PATCH net V2] tuntap: synchronize through tfiles array instead of tun->numqueues

2019-05-06 Thread Jason Wang
On 2019/5/7 下午12:54, Cong Wang wrote: On Mon, May 6, 2019 at 9:03 PM Jason Wang wrote: diff --git a/drivers/net/tun.c b/drivers/net/tun.c index e9ca1c0..32a0b23 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -700,6 +700,8 @@ static void __tun_detach(struct tun_file *tfile, bool cle

Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

2019-05-06 Thread Jiri Pirko
Mon, May 06, 2019 at 09:52:18PM CEST, sae...@mellanox.com wrote: >On Mon, 2019-05-06 at 13:38 +0200, Jiri Pirko wrote: >> Mon, May 06, 2019 at 12:45:44PM CEST, mo...@mellanox.com wrote: >> > >> > On 5/5/2019 6:42 PM, Jiri Pirko wrote: >> > > Sun, May 05, 2019 at 02:33:23AM CEST, sae...@mellanox.co

Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

2019-05-06 Thread Jiri Pirko
Mon, May 06, 2019 at 11:46:43PM CEST, alexei.starovoi...@gmail.com wrote: >On Mon, May 06, 2019 at 07:52:18PM +, Saeed Mahameed wrote: >> On Mon, 2019-05-06 at 13:38 +0200, Jiri Pirko wrote: >> > Mon, May 06, 2019 at 12:45:44PM CEST, mo...@mellanox.com wrote: >> > > >> > > On 5/5/2019 6:42 PM,

Re: [PATCH net V2] tuntap: synchronize through tfiles array instead of tun->numqueues

2019-05-06 Thread Cong Wang
On Mon, May 6, 2019 at 9:03 PM Jason Wang wrote: > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index e9ca1c0..32a0b23 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -700,6 +700,8 @@ static void __tun_detach(struct tun_file *tfile, bool > clean) >

Re: [PATCH v6 bpf-next 04/17] bpf: introduce new alu insn BPF_ZEXT for explicit zero extension

2019-05-06 Thread Alexei Starovoitov
On Tue, May 07, 2019 at 05:29:09AM +0100, Jiong Wang wrote: > > Jiong Wang writes: > > > Alexei Starovoitov writes: > > > >> On Fri, May 03, 2019 at 11:42:31AM +0100, Jiong Wang wrote: > >>> This patch introduce new alu32 insn BPF_ZEXT, and allocate the unused > >>> opcode 0xe0 to it. > >>> > >>

Re: [PATCH v6 bpf-next 04/17] bpf: introduce new alu insn BPF_ZEXT for explicit zero extension

2019-05-06 Thread Jiong Wang
Jiong Wang writes: > Alexei Starovoitov writes: > >> On Fri, May 03, 2019 at 11:42:31AM +0100, Jiong Wang wrote: >>> This patch introduce new alu32 insn BPF_ZEXT, and allocate the unused >>> opcode 0xe0 to it. >>> >>> Compared with the other alu32 insns, zero extension on low 32-bit is the >>>

[PATCH net V2] tuntap: synchronize through tfiles array instead of tun->numqueues

2019-05-06 Thread Jason Wang
When a queue(tfile) is detached through __tun_detach(), we move the last enabled tfile to the position where detached one sit but don't NULL out last position. We expect to synchronize the datapath through tun->numqueues. Unfortunately, this won't work since we're lacking sufficient mechanism to or

Re: [PATCH net] tuntap: synchronize through tfiles array instead of tun->numqueues

2019-05-06 Thread Jason Wang
On 2019/5/7 上午11:41, Eric Dumazet wrote: On 5/6/19 11:23 PM, Jason Wang wrote: When a queue(tfile) is detached through __tun_detach(), we move the last enabled tfile to the position where detached one sit but don't NULL out last position. We expect to synchronize the datapath through tun->num

Re: [PATCH net] tuntap: synchronize through tfiles array instead of tun->numqueues

2019-05-06 Thread Eric Dumazet
On 5/6/19 11:23 PM, Jason Wang wrote: > When a queue(tfile) is detached through __tun_detach(), we move the > last enabled tfile to the position where detached one sit but don't > NULL out last position. We expect to synchronize the datapath through > tun->numqueues. Unfortunately, this won't wo

[PATCH net] tuntap: synchronize through tfiles array instead of tun->numqueues

2019-05-06 Thread Jason Wang
When a queue(tfile) is detached through __tun_detach(), we move the last enabled tfile to the position where detached one sit but don't NULL out last position. We expect to synchronize the datapath through tun->numqueues. Unfortunately, this won't work since we're lacking sufficient mechanism to or

[PATCH net-next] net/sched: remove block pointer from common offload structure

2019-05-06 Thread Jakub Kicinski
From: Pieter Jansen van Vuuren Based on feedback from Jiri avoid carrying a pointer to the tcf_block structure in the tc_cls_common_offload structure. Instead store a flag in driver private data which indicates if offloads apply to a shared block at block binding time. Suggested-by: Jiri Pirko

Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

2019-05-06 Thread Jakub Kicinski
On Sun, 5 May 2019 00:33:23 +, Saeed Mahameed wrote: > From: Moshe Shemesh > > Create mlx5_devlink_health_reporter for FW reporter. The FW reporter > implements devlink_health_reporter diagnose callback. > > The fw reporter diagnose command can be triggered any time by the user > to check cu

Re: [PATCH net-next 1/2] net: Take common prefetch code structure into a function

2019-05-06 Thread Jakub Kicinski
On Sun, 5 May 2019 13:36:06 +0300, Tariq Toukan wrote: > Many device drivers use the same prefetch code structure to > deal with small L1 cacheline size. > Take this code into a function and call it from the drivers. > > Suggested-by: Jakub Kicinski > Signed-off-by: Tariq Toukan > Reviewed-by:

Re: [PATCH v6 bpf-next 04/17] bpf: introduce new alu insn BPF_ZEXT for explicit zero extension

2019-05-06 Thread Jiong Wang
Alexei Starovoitov writes: > On Fri, May 03, 2019 at 11:42:31AM +0100, Jiong Wang wrote: >> This patch introduce new alu32 insn BPF_ZEXT, and allocate the unused >> opcode 0xe0 to it. >> >> Compared with the other alu32 insns, zero extension on low 32-bit is the >> only semantics for this instr

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

2019-05-06 Thread Jiong Wang
Daniel Borkmann writes: > On 05/03/2019 12:42 PM, Jiong Wang wrote: >> BPF helper call transfers execution from eBPF insns to native functions >> while verifier insn walker only walks eBPF insns. So, verifier can only >> knows argument and return value types from explicit helper function >> prot

Re: [PATCH v6 bpf-next 02/17] bpf: verifier: mark verified-insn with sub-register zext flag

2019-05-06 Thread Jiong Wang
Daniel Borkmann writes: > On 05/03/2019 12:42 PM, Jiong Wang wrote: >> eBPF ISA specification requires high 32-bit cleared when low 32-bit >> sub-register is written. This applies to destination register of ALU32 etc. >> JIT back-ends must guarantee this semantic when doing code-gen. >> >> x86-

Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

2019-05-06 Thread Alexei Starovoitov
On Mon, May 06, 2019 at 07:52:18PM +, Saeed Mahameed wrote: > On Mon, 2019-05-06 at 13:38 +0200, Jiri Pirko wrote: > > Mon, May 06, 2019 at 12:45:44PM CEST, mo...@mellanox.com wrote: > > > > > > On 5/5/2019 6:42 PM, Jiri Pirko wrote: > > > > Sun, May 05, 2019 at 02:33:23AM CEST, sae...@mellano

[PATCH net-next v2 1/4] net: ethernet: support of_get_mac_address new ERR_PTR error

2019-05-06 Thread Petr Štetiar
There was NVMEM support added to of_get_mac_address, so it could now return ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. While at it, remove superfluous is_valid_ether_addr as the MAC address returned from of_get_mac_address is always

Re: [PATCH net] vrf: sit mtu should not be updated when vrf netdev is the link

2019-05-06 Thread David Ahern
On 5/6/19 2:28 PM, Stephen Suryaputra wrote: > On Mon, May 06, 2019 at 01:54:16PM -0600, David Ahern wrote: >> On 5/6/19 1:00 PM, Stephen Suryaputra wrote: >>> VRF netdev mtu isn't typically set and have an mtu of 65536. When the >>> link of a tunnel is set, the tunnel mtu is changed from 1480 to t

Re: [PATCH net] vrf: sit mtu should not be updated when vrf netdev is the link

2019-05-06 Thread Stephen Suryaputra
On Mon, May 06, 2019 at 01:54:16PM -0600, David Ahern wrote: > On 5/6/19 1:00 PM, Stephen Suryaputra wrote: > > VRF netdev mtu isn't typically set and have an mtu of 65536. When the > > link of a tunnel is set, the tunnel mtu is changed from 1480 to the link > > mtu minus tunnel header. In the case

Re: [PATCH net] vrf: sit mtu should not be updated when vrf netdev is the link

2019-05-06 Thread David Ahern
On 5/6/19 1:00 PM, Stephen Suryaputra wrote: > VRF netdev mtu isn't typically set and have an mtu of 65536. When the > link of a tunnel is set, the tunnel mtu is changed from 1480 to the link > mtu minus tunnel header. In the case of VRF netdev is the link, then the > tunnel mtu becomes 65516. So,

Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

2019-05-06 Thread Saeed Mahameed
On Mon, 2019-05-06 at 13:38 +0200, Jiri Pirko wrote: > Mon, May 06, 2019 at 12:45:44PM CEST, mo...@mellanox.com wrote: > > > > On 5/5/2019 6:42 PM, Jiri Pirko wrote: > > > Sun, May 05, 2019 at 02:33:23AM CEST, sae...@mellanox.com wrote: > > > > From: Moshe Shemesh > > > > > > > > Create mlx5_dev

[PATCH net] vrf: sit mtu should not be updated when vrf netdev is the link

2019-05-06 Thread Stephen Suryaputra
VRF netdev mtu isn't typically set and have an mtu of 65536. When the link of a tunnel is set, the tunnel mtu is changed from 1480 to the link mtu minus tunnel header. In the case of VRF netdev is the link, then the tunnel mtu becomes 65516. So, fix it by not setting the tunnel mtu in this case. S

Re: [PATCH net-next 10/13] net/sched: add block pointer to tc_cls_common_offload structure

2019-05-06 Thread Jakub Kicinski
On Mon, 6 May 2019 08:16:31 +0200, Jiri Pirko wrote: > Sun, May 05, 2019 at 07:34:32PM CEST, jakub.kicin...@netronome.com wrote: > >On Sat, 4 May 2019 15:16:54 +0200, Jiri Pirko wrote: > >> Sat, May 04, 2019 at 01:46:25PM CEST, jakub.kicin...@netronome.com wrote: > >> >From: Pieter Jansen van V

[iproute PATCH v2] ip-xfrm: Respect family in deleteall and list commands

2019-05-06 Thread Phil Sutter
Allow to limit 'ip xfrm {state|policy} list' output to a certain address family and to delete all states/policies by family. Although preferred_family was already set in filters, the filter function ignored it. To enable filtering despite the lack of other selectors, filter.use has to be set if fa

Re: [net-next][PATCH v2 1/2] rds: handle unsupported rdma request to fs dax memory

2019-05-06 Thread Santosh Shilimkar
On 5/4/2019 11:28 PM, Leon Romanovsky wrote: On Thu, May 02, 2019 at 10:52:23AM -0700, Santosh Shilimkar wrote: On 5/1/2019 11:21 PM, Leon Romanovsky wrote: On Wed, May 01, 2019 at 10:54:00AM -0700, Santosh Shilimkar wrote: On 5/1/2019 12:44 AM, Leon Romanovsky wrote: On Mon, Apr 29, 2019

Re: [net-next][PATCH v2 2/2] rds: add sysctl for rds support of On-Demand-Paging

2019-05-06 Thread Santosh Shilimkar
5/4/2019 11:22 PM, Leon Romanovsky wrote: On Thu, May 02, 2019 at 10:59:58AM -0700, Santosh Shilimkar wrote: On 5/1/2019 11:18 PM, Leon Romanovsky wrote: On Wed, May 01, 2019 at 10:54:50AM -0700, Santosh Shilimkar wrote: On 5/1/2019 12:45 AM, Leon Romanovsky wrote: On Mon, Apr 29, 2019 at 0

Re: [PATCH bpf-next v2 02/16] xsk: Add getsockopt XDP_OPTIONS

2019-05-06 Thread Alexei Starovoitov
On Mon, May 06, 2019 at 01:45:40PM +, Maxim Mikityanskiy wrote: > On 2019-05-04 20:25, Björn Töpel wrote: > > On Tue, 30 Apr 2019 at 20:12, Maxim Mikityanskiy > > wrote: > >> > >> Make it possible for the application to determine whether the AF_XDP > >> socket is running in zero-copy mode. To

Re: [RFC bpf-next 0/7] busy poll support for AF_XDP sockets

2019-05-06 Thread Alexei Starovoitov
On Thu, May 02, 2019 at 10:39:16AM +0200, Magnus Karlsson wrote: > This RFC proposes to add busy-poll support to AF_XDP sockets. With > busy-poll, the driver is executed in process context by calling the > poll() syscall. The main advantage with this is that all processing > occurs on a single core

Re: [iproute2 0/3] Adding json support for showing htb&tbf classes

2019-05-06 Thread Stephen Hemminger
On Mon, 6 May 2019 19:18:37 +0300 Nir Weiner wrote: > Adding a json support for running the command > tc -j class show dev > for the htb kind and the tbf kind > > Nir Weiner (3): > tc: jsonify htb qdisc parameters > tc: jsonify tbf qdisc parameters > tc: jsonify class core > > tc/q_h

[iproute2 3/3] tc: jsonify class core

2019-05-06 Thread Nir Weiner
Add json output to class core. Acked-by: John Haxby Reviewed-by: Liran Alon Signed-off-by: Nir Weiner --- tc/tc_class.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/tc/tc_class.c b/tc/tc_class.c index 7ac700d7ab31..68627f4fcc70 100644 ---

Re: [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address

2019-05-06 Thread Petr Štetiar
Maxime Chevallier [2019-05-06 16:41:32]: Hi Maxime, > On Mon, 6 May 2019 10:32:07 +0200 > Petr Štetiar wrote: > > >David Miller [2019-05-05 21:47:27]: > > > >Hi David, > > > >> Series applied, thank you. > > > >I did probably something terribly wrong, but patch "[PATCH v4 05/10] net: > >eth

[iproute2 2/3] tc: jsonify tbf qdisc parameters

2019-05-06 Thread Nir Weiner
Add json output to tbf qdisc parameters. Acked-by: John Haxby Signed-off-by: Nir Weiner Suggested-by: Liran Alon --- tc/q_tbf.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tc/q_tbf.c b/tc/q_tbf.c index b9465b20d2be..fd824e67e4f2 100644 --- a/tc/q_

[iproute2 0/3] Adding json support for showing htb&tbf classes

2019-05-06 Thread Nir Weiner
Adding a json support for running the command tc -j class show dev for the htb kind and the tbf kind Nir Weiner (3): tc: jsonify htb qdisc parameters tc: jsonify tbf qdisc parameters tc: jsonify class core tc/q_htb.c| 19 ++- tc/q_tbf.c| 20 ++--

[iproute2 1/3] tc: jsonify htb qdisc parameters

2019-05-06 Thread Nir Weiner
Add json output to htb qdisc parameters. Fixes: f354fa6aa5ff05dd214a595e5159ef93a6ab1934 Acked-by: John Haxby Reviewed-by: Liran Alon Signed-off-by: Nir Weiner --- tc/q_htb.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/tc/q_htb.c b/tc/q_htb.c index

[PATCH RESEND net-next 1/3] net: ethernet: support of_get_mac_address new ERR_PTR error

2019-05-06 Thread Petr Štetiar
There was NVMEM support added to of_get_mac_address, so it could now return ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. While at it, remove superfluous is_valid_ether_addr as the MAC address returned from of_get_mac_address is always

Re: [PATCH v6 bpf-next 04/17] bpf: introduce new alu insn BPF_ZEXT for explicit zero extension

2019-05-06 Thread Alexei Starovoitov
On Fri, May 03, 2019 at 11:42:31AM +0100, Jiong Wang wrote: > This patch introduce new alu32 insn BPF_ZEXT, and allocate the unused > opcode 0xe0 to it. > > Compared with the other alu32 insns, zero extension on low 32-bit is the > only semantics for this instruction. It also allows various JIT ba

Re: [PATCH iproute2 v3] ipnetns: use-after-free problem in get_netnsid_from_name func

2019-05-06 Thread Zhiqiang Liu
> On Sat, 4 May 2019 15:26:25 +0800 > Zhiqiang Liu wrote: > >> From: Zhiqiang Liu >> >> Follow the following steps: >> # ip netns add net1 >> # export MALLOC_MMAP_THRESHOLD_=0 >> # ip netns list >> then Segmentation fault (core dumped) will occur. >> >> In get_netnsid_from_name func, answer is f

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

2019-05-06 Thread Alexei Starovoitov
On Fri, May 03, 2019 at 11:42:28AM +0100, Jiong Wang wrote: > BPF helper call transfers execution from eBPF insns to native functions > while verifier insn walker only walks eBPF insns. So, verifier can only > knows argument and return value types from explicit helper function > prototype descripti

pull-request: bpf-next 2019-05-06

2019-05-06 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Two AF_XDP libbpf fixes for socket teardown; first one an invalid munmap and the other one an invalid skmap cleanup, both from Björn. 2) More graceful CONFIG_DEBUG_INFO_BTF handling w

Re: [PATCH iproute2-master] devlink: Fix monitor command

2019-05-06 Thread Stephen Hemminger
On Sun, 5 May 2019 17:12:43 +0300 Ido Schimmel wrote: > From: Ido Schimmel > > The command is supposed to allow users to filter events related to > certain objects, but returns an error when an object is specified: > > # devlink mon dev > Command "dev" not found > > Fix this by allowing the

Re: [PATCH iproute2 v3] ipnetns: use-after-free problem in get_netnsid_from_name func

2019-05-06 Thread Stephen Hemminger
On Sat, 4 May 2019 15:26:25 +0800 Zhiqiang Liu wrote: > From: Zhiqiang Liu > > Follow the following steps: > # ip netns add net1 > # export MALLOC_MMAP_THRESHOLD_=0 > # ip netns list > then Segmentation fault (core dumped) will occur. > > In get_netnsid_from_name func, answer is freed before

Re: [iproute PATCH] ip-xfrm: Respect family in deleteall and list commands

2019-05-06 Thread Stephen Hemminger
On Mon, 29 Apr 2019 14:24:24 +0200 Phil Sutter wrote: > Allow to limit 'ip xfrm {state|policy} list' output to a certain address > family and to delete all states/policies by family. > > Although preferred_family was already set in filters, the filter > function ignored it. To enable filtering d

Re: [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address

2019-05-06 Thread Maxime Chevallier
Hi Petr, On Mon, 6 May 2019 10:32:07 +0200 Petr Štetiar wrote: >David Miller [2019-05-05 21:47:27]: > >Hi David, > >> Series applied, thank you. > >I did probably something terribly wrong, but patch "[PATCH v4 05/10] net: >ethernet: support of_get_mac_address new ERR_PTR error" has not reache

Re: [PATCH v6 bpf-next 02/17] bpf: verifier: mark verified-insn with sub-register zext flag

2019-05-06 Thread Daniel Borkmann
On 05/06/2019 03:49 PM, Daniel Borkmann wrote: > On 05/03/2019 12:42 PM, Jiong Wang wrote: >> eBPF ISA specification requires high 32-bit cleared when low 32-bit >> sub-register is written. This applies to destination register of ALU32 etc. >> JIT back-ends must guarantee this semantic when doing c

Re: [PATCH bpf-next v2 04/16] xsk: Extend channels to support combined XSK/non-XSK traffic

2019-05-06 Thread Magnus Karlsson
On Mon, May 6, 2019 at 3:46 PM Maxim Mikityanskiy wrote: > > On 2019-05-04 20:26, Björn Töpel wrote: > > On Tue, 30 Apr 2019 at 20:12, Maxim Mikityanskiy > > wrote: > >> > >> Currently, the drivers that implement AF_XDP zero-copy support (e.g., > >> i40e) switch the channel into a different mode

Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

2019-05-06 Thread Richard Cochran
On Thu, Apr 25, 2019 at 09:40:06PM +0800, Hangbin Liu wrote: > Would you please help have a look at it and see which way we should use? > Drop SIOCSHWTSTAMP in container or add a filter on macvlan(maybe only in > container)? I vote for dropping SIOCSHWTSTAMP altogether. Why? Because the filter i

Re: [PATCH v6 bpf-next 01/17] bpf: verifier: offer more accurate helper function arg and return type

2019-05-06 Thread Daniel Borkmann
On 05/03/2019 12:42 PM, Jiong Wang wrote: > BPF helper call transfers execution from eBPF insns to native functions > while verifier insn walker only walks eBPF insns. So, verifier can only > knows argument and return value types from explicit helper function > prototype descriptions. > > For 32-b

Re: [PATCH v6 bpf-next 02/17] bpf: verifier: mark verified-insn with sub-register zext flag

2019-05-06 Thread Daniel Borkmann
On 05/03/2019 12:42 PM, Jiong Wang wrote: > eBPF ISA specification requires high 32-bit cleared when low 32-bit > sub-register is written. This applies to destination register of ALU32 etc. > JIT back-ends must guarantee this semantic when doing code-gen. > > x86-64 and arm64 ISA has the same sema

Re: [PATCH bpf-next v2 04/16] xsk: Extend channels to support combined XSK/non-XSK traffic

2019-05-06 Thread Maxim Mikityanskiy
On 2019-05-04 20:26, Björn Töpel wrote: > On Tue, 30 Apr 2019 at 20:12, Maxim Mikityanskiy wrote: >> >> Currently, the drivers that implement AF_XDP zero-copy support (e.g., >> i40e) switch the channel into a different mode when an XSK is opened. It >> causes some issues that have to be taken into

Re: [PATCH bpf-next v2 02/16] xsk: Add getsockopt XDP_OPTIONS

2019-05-06 Thread Maxim Mikityanskiy
On 2019-05-04 20:25, Björn Töpel wrote: > On Tue, 30 Apr 2019 at 20:12, Maxim Mikityanskiy wrote: >> >> Make it possible for the application to determine whether the AF_XDP >> socket is running in zero-copy mode. To achieve this, add a new >> getsockopt option XDP_OPTIONS that returns flags. The o

Re: Decoupling phy_device from net_device (was "Re: [PATCH] net: dsa: fixed-link interface is reporting SPEED_UNKNOWN")

2019-05-06 Thread Andrew Lunn
On Mon, May 06, 2019 at 01:00:49AM +0300, Vladimir Oltean wrote: > On 4/12/19 8:57 PM, Heiner Kallweit wrote: > >On 12.04.2019 01:01, Vladimir Oltean wrote: > >>With Heiner's recent patch "b6163f194c69 net: phy: improve > >>genphy_read_status", the phydev->speed is now initialized by default to > >

[PATCH] samples: bpf: fix style in bpf_load

2019-05-06 Thread Daniel T. Lee
This commit fixes style problem in samples/bpf/bpf_load.c Styles that have been changed are: - Magic string use of 'DEBUGFS' - Useless zero initialization of a global variable - Minor style fix with whitespace Signed-off-by: Daniel T. Lee --- samples/bpf/bpf_load.c | 11 +++ 1 file c

Re: [RFC PATCH net-next 2/3] flow_offload: restore ability to collect separate stats per action

2019-05-06 Thread Jamal Hadi Salim
On 2019-05-04 2:27 a.m., Jakub Kicinski wrote: On Fri, 3 May 2019 16:06:55 +0100, Edward Cree wrote: Introduce a new offload command TC_CLSFLOWER_STATS_BYINDEX, similar to the existing TC_CLSFLOWER_STATS but specifying an action_index (the tcfa_index of the action), which is called for each

Re: [PATCH iproute2-next v2] tc: add support for plug qdisc

2019-05-06 Thread Paolo Abeni
On Sat, 2019-05-04 at 10:14 -0600, David Ahern wrote: > On 4/30/19 10:53 AM, Paolo Abeni wrote: > > sch_plug can be used to perform functional qdisc unit tests > > controlling explicitly the queuing behaviour from user-space. > > Hi Paolo: > Do you have or are you planning to write unit tests? wh

Re: [net-next 14/15] net/mlx5: Add support for FW fatal reporter dump

2019-05-06 Thread Jiri Pirko
Mon, May 06, 2019 at 12:54:00PM CEST, mo...@mellanox.com wrote: > > >On 5/5/2019 6:52 PM, Jiri Pirko wrote: >> Sun, May 05, 2019 at 02:33:33AM CEST, sae...@mellanox.com wrote: >>> From: Moshe Shemesh >>> >>> Add support of dump callback for mlx5 FW fatal reporter. >>> The FW fatal dump use cr-dump

Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

2019-05-06 Thread Jiri Pirko
Mon, May 06, 2019 at 12:45:44PM CEST, mo...@mellanox.com wrote: > > >On 5/5/2019 6:42 PM, Jiri Pirko wrote: >> Sun, May 05, 2019 at 02:33:23AM CEST, sae...@mellanox.com wrote: >>> From: Moshe Shemesh >>> >>> Create mlx5_devlink_health_reporter for FW reporter. The FW reporter >>> implements devlin

Re: [net-next 11/15] net/mlx5: Add support for FW reporter dump

2019-05-06 Thread Jiri Pirko
Mon, May 06, 2019 at 12:51:24PM CEST, mo...@mellanox.com wrote: > > >On 5/5/2019 6:49 PM, Jiri Pirko wrote: >> Sun, May 05, 2019 at 02:33:27AM CEST, sae...@mellanox.com wrote: >>> From: Moshe Shemesh >>> >>> Add support of dump callback for mlx5 FW reporter. >>> Once we trigger FW dump, the FW wil

Re: [PATCH bpf-next 1/2] xsk: remove AF_XDP socket from map when the socket is released

2019-05-06 Thread Björn Töpel
On 2019-05-06 12:07, Daniel Borkmann wrote: On 05/06/2019 12:04 PM, Daniel Borkmann wrote: On 05/04/2019 06:06 PM, Björn Töpel wrote: From: Björn Töpel When an AF_XDP socket is released/closed the XSKMAP still holds a reference to the socket in a "released" state. The socket will still use th

Re: [net-next 14/15] net/mlx5: Add support for FW fatal reporter dump

2019-05-06 Thread Moshe Shemesh
On 5/5/2019 6:52 PM, Jiri Pirko wrote: > Sun, May 05, 2019 at 02:33:33AM CEST, sae...@mellanox.com wrote: >> From: Moshe Shemesh >> >> Add support of dump callback for mlx5 FW fatal reporter. >> The FW fatal dump use cr-dump functionality to gather cr-space data for >> debug. The cr-dump uses vs

Re: [net-next 09/15] net/mlx5: Create FW devlink health reporter

2019-05-06 Thread Moshe Shemesh
On 5/5/2019 6:42 PM, Jiri Pirko wrote: > Sun, May 05, 2019 at 02:33:23AM CEST, sae...@mellanox.com wrote: >> From: Moshe Shemesh >> >> Create mlx5_devlink_health_reporter for FW reporter. The FW reporter >> implements devlink_health_reporter diagnose callback. >> >> The fw reporter diagnose comm

linux-next: manual merge of the akpm-current tree with the net-next tree

2019-05-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: lib/Makefile between commit: 554aae35007e ("lib: Add support for generic packing operations") from the net-next tree and commit: 1a1e7f563bd5 ("lib: Move mathematic helpers to separate folder") from the akpm-c

Re: [net-next 11/15] net/mlx5: Add support for FW reporter dump

2019-05-06 Thread Moshe Shemesh
On 5/5/2019 6:49 PM, Jiri Pirko wrote: > Sun, May 05, 2019 at 02:33:27AM CEST, sae...@mellanox.com wrote: >> From: Moshe Shemesh >> >> Add support of dump callback for mlx5 FW reporter. >> Once we trigger FW dump, the FW will write the core dump to its raw data >> buffer. The tracer translates t

Re: [net-next 07/15] net/mlx5: Issue SW reset on FW assert

2019-05-06 Thread Moshe Shemesh
On 5/5/2019 6:38 PM, Jiri Pirko wrote: > Sun, May 05, 2019 at 02:33:18AM CEST, sae...@mellanox.com wrote: >> From: Feras Daoud >> >> If a FW assert is considered fatal, indicated by a new bit in the health >> buffer, reset the FW. After the reset go through the normal recovery >> flow. Only one

pull-request: bpf 2019-05-06

2019-05-06 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Two x32 JIT fixes: one which has buggy signed comparisons in 64 bit conditional jumps and another one for 64 bit negation, both from Wang. Please consider pulling these changes from:

bpf-next is CLOSED

2019-05-06 Thread Daniel Borkmann
Only bug fixes from this point forward given the merge window is open. PRs will go out to David in a bit. Thanks everyone, Daniel

Re: [PATCH bpf-next 1/2] xsk: remove AF_XDP socket from map when the socket is released

2019-05-06 Thread Daniel Borkmann
On 05/06/2019 12:04 PM, Daniel Borkmann wrote: > On 05/04/2019 06:06 PM, Björn Töpel wrote: >> From: Björn Töpel >> >> When an AF_XDP socket is released/closed the XSKMAP still holds a >> reference to the socket in a "released" state. The socket will still >> use the netdev queue resource, and blo

Re: [PATCH bpf-next 1/2] xsk: remove AF_XDP socket from map when the socket is released

2019-05-06 Thread Daniel Borkmann
On 05/04/2019 06:06 PM, Björn Töpel wrote: > From: Björn Töpel > > When an AF_XDP socket is released/closed the XSKMAP still holds a > reference to the socket in a "released" state. The socket will still > use the netdev queue resource, and block newly created sockets from > attaching to that que

Re: [PATCH bpf] libbpf: remove unnecessary cast-to-void

2019-05-06 Thread Daniel Borkmann
On 05/06/2019 11:24 AM, Björn Töpel wrote: > From: Björn Töpel > > The patches with fixes tags added a cast-to-void in the places when > the return value of a function was ignored. > > This is not common practice in the kernel, and is therefore removed in > this patch. > > Reported-by: Daniel B

Re: selftests/bpf/test_tag takes ~30 minutes?

2019-05-06 Thread Daniel Borkmann
On 04/30/2019 03:21 PM, Michael Ellerman wrote: > Hi Daniel, > > I'm running selftests/bpf/test_tag and it's taking roughly half an hour > to complete, is that expected? > > I don't really grok what the test is doing TBH, but it does appear to be > doing it 5 times :) > > for (i = 0; i < 5

[PATCH bpf] libbpf: remove unnecessary cast-to-void

2019-05-06 Thread Björn Töpel
From: Björn Töpel The patches with fixes tags added a cast-to-void in the places when the return value of a function was ignored. This is not common practice in the kernel, and is therefore removed in this patch. Reported-by: Daniel Borkmann Fixes: 5750902a6e9b ("libbpf: proper XSKMAP cleanup"

Re: [bpf-next PATCH v3 0/4] sockmap/ktls fixes

2019-05-06 Thread Daniel Borkmann
On 05/02/2019 10:05 PM, John Fastabend wrote: > On 4/30/19 7:06 PM, John Fastabend wrote: >> Series of fixes for sockmap and ktls, see patches for descriptions. >> >> v2: fix build issue for CONFIG_TLS_DEVICE and fixup couple comments >> from Jakub >> >> v3: fix issue where release could call u

Re: [PATCH bpf 1/2] libbpf: fix invalid munmap call

2019-05-06 Thread Daniel Borkmann
On 05/06/2019 10:40 AM, Björn Töpel wrote: > On Mon, 6 May 2019 at 10:26, Daniel Borkmann wrote: >> On 04/30/2019 02:45 PM, Björn Töpel wrote: >>> From: Björn Töpel >>> >>> When unmapping the AF_XDP memory regions used for the rings, an >>> invalid address was passed to the munmap() calls. Instea

Re: [net-next 01/12] i40e: replace switch-statement to speed-up retpoline-enabled builds

2019-05-06 Thread Daniel Borkmann
On 04/30/2019 12:42 PM, David Laight wrote: > From: Josh Elsasser >> Sent: 29 April 2019 21:02 >> On Apr 29, 2019, at 12:16 PM, Jeff Kirsher >> wrote: >> >>> From: Björn Töpel >>> >>> GCC will generate jump tables for switch-statements with more than 5 >>> case statements. An entry into the jump

Re: [PATCH bpf 1/2] libbpf: fix invalid munmap call

2019-05-06 Thread Björn Töpel
On Mon, 6 May 2019 at 10:26, Daniel Borkmann wrote: > > On 04/30/2019 02:45 PM, Björn Töpel wrote: > > From: Björn Töpel > > > > When unmapping the AF_XDP memory regions used for the rings, an > > invalid address was passed to the munmap() calls. Instead of passing > > the beginning of the memory

Re: [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address

2019-05-06 Thread Petr Štetiar
David Miller [2019-05-05 21:47:27]: Hi David, > Series applied, thank you. I did probably something terribly wrong, but patch "[PATCH v4 05/10] net: ethernet: support of_get_mac_address new ERR_PTR error" has not reached the patchwork, but I'm sure, that it was sent out as Hauke Mehrtens (maint

Re: [PATCH bpf 1/2] libbpf: fix invalid munmap call

2019-05-06 Thread Daniel Borkmann
On 04/30/2019 02:45 PM, Björn Töpel wrote: > From: Björn Töpel > > When unmapping the AF_XDP memory regions used for the rings, an > invalid address was passed to the munmap() calls. Instead of passing > the beginning of the memory region, the descriptor region was passed > to munmap. > > When t

Re: pull-request: wireless-drivers 2019-04-30

2019-05-06 Thread Kalle Valo
David Miller writes: > From: Kalle Valo > Date: Tue, 30 Apr 2019 19:55:45 +0300 > >> David Miller writes: >> >>> Thanks for the conflict resolution information, it is very helpful. >>> >>> However, can you put it into the merge commit text next time as well? >>> I cut and pasted it in there wh

Re: [PATCH bpf] kbuild: tolerate missing pahole when generating BTF

2019-05-06 Thread Daniel Borkmann
On 05/06/2019 02:10 AM, Andrii Nakryiko wrote: > When BTF generation is enabled through CONFIG_DEBUG_INFO_BTF, > scripts/link-vmlinux.sh detects if pahole version is too old and > gracefully continues build process, skipping BTF generation build step. > But if pahole is not available, build will st

Re: [PATCH net-next] macvlan: pass get_ts_info and SIOC[SG]HWTSTAMP ioctl to real device

2019-05-06 Thread Hangbin Liu
On Thu, Apr 25, 2019 at 09:40:06PM +0800, Hangbin Liu wrote: > On Tue, Apr 23, 2019 at 11:32:13AM +0200, Miroslav Lichvar wrote: > > If those values I described above were in an array called ts_map > > indexed by the RX filter enum, I think the check could just be: > > > > (ts_map[old_filter]