Fixes: d84aec42151b ("net: ll_temac: Fix support for 64-bit platforms")
Signed-off-by: Esben Haabendal
---
drivers/net/ethernet/xilinx/ll_temac_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c
b/drivers/net/ethernet/xilinx/ll
On Wed, May 01, 2019 at 10:54:00AM -0700, Santosh Shilimkar wrote:
> On 5/1/2019 12:44 AM, Leon Romanovsky wrote:
> > On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
> > > From: Hans Westgaard Ry
> > >
> > > RDS doesn't support RDMA on memory apertures that require On Demand
> >
On Wed, May 01, 2019 at 10:54:50AM -0700, Santosh Shilimkar wrote:
> On 5/1/2019 12:45 AM, Leon Romanovsky wrote:
> > On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
> > > RDS doesn't support RDMA on memory apertures that require On Demand
> > > Paging (ODP), such as FS DAX memor
Although devlink health report does a nice job on reporting TX
timeout and other NIC errors, unfortunately it requires drivers
to support it but currently only mlx5 has implemented it.
Before other drivers could catch up, it is useful to have a
generic tracepoint to monitor this kind of TX timeout.
From: Eric Dumazet
Date: Wed, 1 May 2019 18:56:28 -0700
> syzbot was able to crash host by sending UDP packets with a 0 payload.
>
> TCP does not have this issue since we do not aggregate packets without
> payload.
>
> Since dev_gro_receive() sets gso_size based on skb_gro_len(skb)
> it seems
syzbot was able to crash host by sending UDP packets with a 0 payload.
TCP does not have this issue since we do not aggregate packets without
payload.
Since dev_gro_receive() sets gso_size based on skb_gro_len(skb)
it seems not worth trying to cope with padded packets.
BUG: KASAN: slab-out-of-bo
From: David Ahern
Commit cd9ff4de0107 changed the key for IFF_POINTOPOINT devices to
INADDR_ANY but neigh_xmit which is used for MPLS encapsulations was not
updated to use the altered key. The result is that every packet Tx does
a lookup on the gateway address which does not find an entry, a new
From: David Ahern
Ian and Alan both reported seeing overflows after upgrades to 5.x kernels:
neighbour: arp_cache: neighbor table overflow!
Alan's mpls script helped get to the bottom of this bug. When a new entry
is created the gc_entries counter is bumped in neigh_alloc to check if a
new one
On Wed, May 1, 2019 at 6:11 AM Eran Ben Elisha wrote:
>
>
>
> On 4/30/2019 9:50 PM, Cong Wang wrote:
> > Although devlink health report does a nice job on reporting TX
> > timeout and other NIC errors, unfortunately it requires drivers
> > to support it but currently only mlx5 has implemented it.
From: Saeed Mahameed
Date: Wed, 1 May 2019 21:43:41 +
> Hi Dave, i will be sending V2 to include latest fix from mlx5-next
> branch.
Ok.
On 5/1/19 10:03 AM, Alan Maguire wrote:
> I'm seeing the following repeated error
>
> [ 130.821362] neighbour: arp_cache: neighbor table overflow!
>
> when using MPLSoverGRE or MPLSoverUDP tunnels on bits synced
> with bpf-next as of this morning. The test script below reliably
> reproduces the
On Wed, May 01, 2019 at 10:45:03PM +0200, Hauke Mehrtens wrote:
Hi Hauke
/* Add the LAN port into a bridge with the CPU port by
> + * default. This prevents automatic forwarding of
> + * packages between the LAN ports when no explicit
> + * bridge is configured.
> + */
> +static int gswip_add_sig
From: Bodong Wang
mlx5_query_nic_vport_vlans() is not used anymore. Hence remove it.
This patch doesn't change any functionality.
Signed-off-by: Bodong Wang
Reviewed-by: Parav Pandit
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/vport.c | 61 ---
inc
From: Bodong Wang
When the state of rep was introduced, it was also designed to prevent
duplicate unloading of the same rep. Considering the following two
flows when an eswitch manager is at switchdev mode with n VF reps loaded.
+--+---
From: Parav Pandit
Several functions need to access mlx5_vport and vport_num.
When these functions are called, caller already has mlx5_vport*
available.
Hence pass such mlx5_vport pointer.
This is preparation patch to add error checks to
mlx5_eswitch_get_vport() and to return error status.
By do
From: Maxim Mikityanskiy
The same code that returns XDP frames and releases pages is used both in
mlx5e_poll_xdpsq_cq and mlx5e_free_xdpsq_descs. Create a function that
cleans up an MPWQE.
Signed-off-by: Maxim Mikityanskiy
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/
From: Masahiro Yamada
CFLAGS_tracepoint.o specifies CFLAGS for compiling tracepoint.c but
it does not exist under drivers/net/ethernet/mellanox/mlx5/core/.
CFLAGS_tracepoint.o is unused.
Signed-off-by: Masahiro Yamada
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/
From: Parav Pandit
Currently mlx5_esw_for_each_vf_vport iterates over mlx5_vport entries in
eswitch.c
Same macro in eswitch_offloads.c iterates over vport number in
eswitch_offloads.c
Instead of duplicate macro names, to avoid confusion and to reuse the
same macro in both files, move it to eswit
From: Erez Alfasi
Add the support to read additional EEPROM information from high pages.
Information for modules such as SFF-8436 and SFF-8636:
1) Application select table
2) User writable EEPROM
3) Thresholds and alarms
Signed-off-by: Erez Alfasi
Signed-off-by: Saeed Mahameed
---
.../ethe
From: Eli Britstein
Current ConnectX HW is unable to perform VLAN pop in TX path and VLAN
push on RX path. As a workaround, untagged packets are tagged with
VID 0x000 allowing pop/push actions to be exchanged with VLAN rewrite
actions.
Use the ingress ACL table, preceding the FDB, to push VLAN 0x
From: Erez Alfasi
Added max EEPROM length defines for ethtool usage:
#define ETH_MODULE_SFF_8636_MAX_LEN 640
#define ETH_MODULE_SFF_8436_MAX_LEN 640
These definitions are used to determine the EEPROM
data length when reading high eeprom pages.
For example, SFF-8636 EEPROM data from pa
From: Eli Britstein
Current ConnectX HW is unable to perform VLAN pop in TX path and VLAN
push on RX path. To workaround that limitation untagged packets are
tagged with VLAN ID 0x000 (priority tag) and pop/push actions are
replaced by VLAN re-write actions (which are supported by the HW).
Replac
From: Tariq Toukan
Hardware requires that all TIRs that steer traffic to the same RQ
should share identical tunneled_offload_en value.
For that, the tunneled_offload_en bit should be set/unset (according to
the HW capability) for all TIRs', not only the ones dedicated for
tunneled (inner) traffic
From: Bodong Wang
The check of legal vport is to ensure the vport number falls between
0 and total number of vports. Along with the introduction of uplink
rep, enabled vports are not consecutive any more.
Therefore, rely on the eswitch vport getter function to check if it's
a valid vport.
As the
From: Bodong Wang
Some functions issue vport commands and access vport array using
vport_index/vport_num interchangeably which is OK for VFs vports.
However, this creates potential bug if those vports are not VFs
(E.g, uplink, sf) where their vport_index don't equal to vport_num.
Prepare code to
From: Vlad Buslov
With unlocked TC it is possible to have spurious deletes and inserts of
same filter. TC layer needs drivers to always return error when flow
insertion failed in order to correctly calculate "in_hw_count" for each
filter. Fix mlx5e_configure_flower() to return -EEXIST when TC tri
From: Tariq Toukan
Many TIR context settings are common to different TIR types,
take them into a common function.
Signed-off-by: Tariq Toukan
Reviewed-by: Aya Levin
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/en_main.c | 49 ---
1 file changed, 21 in
Hi Dave,
This series provides misc updates to mlx5 driver.
There is one patch of this series that is touching outside mlx5 driver:
ethtool.h: Add SFF-8436 and SFF-8636 max EEPROM length definitions
Added max EEPROM length defines for ethtool usage:
#define ETH_MODULE_SFF_8636_MAX_LEN 640
On Tue, 2019-04-30 at 20:39 +, Saeed Mahameed wrote:
> Hi Dave,
>
> This series provides misc updates to mlx5 driver.
> There is one patch of this series that is touching outside mlx5
> driver:
>
> ethtool.h: Add SFF-8436 and SFF-8636 max EEPROM length definitions
> Added max EEPROM length de
From: Martin KaFai Lau
Date: Tue, 30 Apr 2019 10:45:12 -0700
> It is a followup after the fix in
> commit 9c69a1320515 ("route: Avoid crash from dereferencing NULL rt->from")
>
> rt6_do_redirect():
> 1. NULL checking is needed on rt->from because a parallel
>fib6_info delete could happen tha
On 4/30/19 10:45 AM, Martin KaFai Lau wrote:
> It is a followup after the fix in
> commit 9c69a1320515 ("route: Avoid crash from dereferencing NULL rt->from")
>
> rt6_do_redirect():
> 1. NULL checking is needed on rt->from because a parallel
>fib6_info delete could happen that sets rt->from
On Wed, 2019-05-01 at 03:21 +, Saeed Mahameed wrote:
> The cited commit broke the offsets of hca cap struct, fix it.
> While at it, cleanup a white space introduced by the same commit.
>
> Fixes: b169e64a2444 ("net/mlx5: Geneve, Add flow table capabilities
> for Geneve decap with TLV options")
On Wed, 2019-05-01 at 13:11 +, Eran Ben Elisha wrote:
>
> On 4/30/2019 9:50 PM, Cong Wang wrote:
> > Although devlink health report does a nice job on reporting TX
> > timeout and other NIC errors, unfortunately it requires drivers
> > to support it but currently only mlx5 has implemented it.
This allows to offload bridges with DSA to the switch hardware and do
the packet forwarding in hardware.
This implements generic functions to access the switch hardware tables,
which are used to control many features of the switch.
This patch activates the MAC learning by removing the MAC address
Fast aging per port is not supported directly by the hardware, it is
only possible to configure a global aging time.
Do the fast aging by iterating over the MAC forwarding table and remove
all dynamic entries for a given port.
Signed-off-by: Hauke Mehrtens
---
drivers/net/dsa/lantiq_gswip.c | 3
This adds functions to add and remove static entries to and from the
forwarding database and dump the full forwarding database.
Signed-off-by: Hauke Mehrtens
---
drivers/net/dsa/lantiq_gswip.c | 98 ++
1 file changed, 98 insertions(+)
diff --git a/drivers/net/dsa
Allow the special tag in ingress only on the CPU port and not on all
ports. A packet with a special tag could circumvent the hardware
forwarding and should only be allowed on the CPU port where Linux
controls the port.
Signed-off-by: Hauke Mehrtens
---
drivers/net/dsa/lantiq_gswip.c | 6 --
The VLAN aware bridge offloading is similar to the VLAN unaware
offloading, this makes it possible to offload the VLAN bridge
functionalities.
The hardware supports up to 64 VLAN bridge entries, we already use one
entry for each LAN port to prevent forwarding of packets between the
ports when the
This adds bridge offloading for the Intel / Lantiq GSWIP 2.1 switch.
Hauke Mehrtens (5):
net: dsa: lantiq: Allow special tags only on CPU port
net: dsa: lantiq: Add VLAN unaware bridge offloading
net: dsa: lantiq: Add VLAN aware bridge offloading
net: dsa: lantiq: Add fast age function
n
On Wed, May 01, 2019 at 09:34:43PM +0200, Heiner Kallweit wrote:
> When probing the phy device we set sym and asym pause in the "supported"
> bitmap (unless the PHY tells us otherwise). However we don't know yet
> whether the MAC supports pause. Simply copying phy->supported to
> phy->advertising w
On Wed, May 01, 2019 at 10:14:21PM +0200, Heiner Kallweit wrote:
> I got an interesting report [0] that after resuming from hibernation
> the link has 100Mbps instead of 1Gbps. Reason is that another OS has
> been used whilst Linux was hibernated. And this OS speeds down the link
> due to WoL. Ther
Hi,
On 2019-05-01 00:04, Aurelien Jarno wrote:
> On 2019-04-30 10:12, Uwe Kleine-König wrote:
> > > > More precisely the board is a "Marvell Armada XP Development Board
> > > > DB-MV784MP-GP"
> > > >
> > > > > anymore. Using tcpdump on both the buildd and a remote host, it
> > > > > appears
> >
I got an interesting report [0] that after resuming from hibernation
the link has 100Mbps instead of 1Gbps. Reason is that another OS has
been used whilst Linux was hibernated. And this OS speeds down the link
due to WoL. Therefore, when resuming, we shouldn't expect that what
the PHY advertises is
When probing the phy device we set sym and asym pause in the "supported"
bitmap (unless the PHY tells us otherwise). However we don't know yet
whether the MAC supports pause. Simply copying phy->supported to
phy->advertising will trigger advertising pause, and that's not
what we want. Therefore add
We have valid scenarios where ETHTOOL_LINK_MODE_Pause_BIT doesn't
need to be supported. Therefore extend the first check to check
for rx_pause being set.
See also phy_set_asym_pause:
rx=0 and tx=1: advertise asym pause only
rx=0 and tx=0: stop advertising both pause modes
The fixed commit isn't w
On 30.04.2019 07:06, Heiner Kallweit wrote:
> On 29.04.2019 23:52, Andrew Lunn wrote:
>>> @@ -2078,6 +2089,11 @@ EXPORT_SYMBOL(phy_set_sym_pause);
>>> void phy_set_asym_pause(struct phy_device *phydev, bool rx, bool tx)
>>> {
>>> __ETHTOOL_DECLARE_LINK_MODE_MASK(oldadv);
>>> + bool asym_pau
From: Hangbin Liu
Date: Tue, 30 Apr 2019 10:46:10 +0800
> Fixes: 65b2b4939a64 ("selftests: net: initial fib rule tests")
> Signed-off-by: Hangbin Liu
Applied.
From: YueHaibing
Date: Tue, 30 Apr 2019 01:55:24 +
> Fix inconsistent IS_ERR and PTR_ERR in cpsw_probe,
> The proper pointer to use is clk instead of mode.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 83a8471ba255 ("net: ethernet: ti: cpsw: refactor probe to group com
On Wed, May 01, 2019 at 07:44:53AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)"
>
> In preparation for renaming skb_frag fields, use the fine accessors which
> already exist.
It turns out not all network drivers are under drivers/net. And others
aren't built on x86 by allyesco
On 5/1/2019 12:45 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supported.
Reviewe
On 5/1/2019 12:44 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform RDMA
From: Shmulik Ladkani
Date: Mon, 29 Apr 2019 16:39:30 +0300
> Previously, during fragmentation after forwarding, skb->skb_iif isn't
> preserved, i.e. 'ip_copy_metadata' does not copy skb_iif from given
> 'from' skb.
>
> As a result, ip_do_fragment's creates fragments with zero skb_iif,
> leading
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
> From: Hans Westgaard Ry
>
> RDS doesn't support RDMA on memory apertures that require On Demand
> Paging (ODP), such as FS DAX memory. User applications can try to use
> RDS to perform RDMA over such memories and since it doesn't
On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
> RDS doesn't support RDMA on memory apertures that require On Demand
> Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
> whether RDMA requiring ODP is supported.
>
> Reviewed-by: Håkon Bugge
> Reviewed-tested-by
Greeting, Did you received my message? please let me know.Thanks.Mr.Peter Sina.
I'm seeing the following repeated error
[ 130.821362] neighbour: arp_cache: neighbor table overflow!
when using MPLSoverGRE or MPLSoverUDP tunnels on bits synced
with bpf-next as of this morning. The test script below reliably
reproduces the problem, while working fine on a 4.14 (I haven't
bisec
From: Vinicius Costa Gomes
Date: Mon, 29 Apr 2019 15:48:29 -0700
> Overview
>
>
> This RFC has two objectives, it adds support for changing the running
> schedules during "runtime", explained in more detail later, and
> proposes an interface between taprio and the drivers for hardware
>
From: Yuchung Cheng
Date: Mon, 29 Apr 2019 15:46:12 -0700
> Linux TCP currently uses the initial congestion window of 1 packet
> if multiple SYN or SYNACK timeouts per RFC6298. However such
> timeouts are often spurious on wireless or cellular networks that
> experience high delay variances (e.g.
On 4/29/19 8:46 PM, Hangbin Liu wrote:
> Fixes: 65b2b4939a64 ("selftests: net: initial fib rule tests")
> Signed-off-by: Hangbin Liu
> ---
> tools/testing/selftests/net/fib_rule_tests.sh | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/net/fib_rule_tests.s
On 4/30/19 11:45 AM, Martin KaFai Lau wrote:
> It is a followup after the fix in
> commit 9c69a1320515 ("route: Avoid crash from dereferencing NULL rt->from")
>
> rt6_do_redirect():
> 1. NULL checking is needed on rt->from because a parallel
>fib6_info delete could happen that sets rt->from to
From: Jakub Kicinski
Date: Mon, 29 Apr 2019 12:19:12 -0700
> update_chksum() accesses nskb->sk before it has been set
> by complete_skb(), move the init up.
>
> Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Simon Horman
From: David Ahern
Date: Mon, 29 Apr 2019 10:30:09 -0700
> From: David Ahern
>
> A recent commit returns an error if icmp is used as the ip-proto for
> IPv6 fib rules. Update fib_rule_tests to send ipv6-icmp instead of icmp.
>
> Fixes: 5e1a99eae8499 ("ipv4: Add ICMPv6 support when parse route i
From: Willem de Bruijn
Date: Mon, 29 Apr 2019 11:53:18 -0400
> From: Willem de Bruijn
>
> Packet sockets in datagram mode take a destination address. Verify its
> length before passing to dev_hard_header.
>
> Prior to 2.6.14-rc3, the send code ignored sll_halen. This is
> established behavior.
From: Willem de Bruijn
Date: Mon, 29 Apr 2019 11:46:55 -0400
> From: Willem de Bruijn
>
> Packet send checks that msg_name is at least sizeof sockaddr_ll.
> Packet recv must return at least this length, so that its output
> can be passed unmodified to packet send.
>
> This ceased to be true si
> > if you can craft a test that shows patch_insn issue before your set,
> > then it's ok to hack bpf_fill_scale1 to use alu64.
>
> As described above, does the test_verifier 732 + jit blinding looks
> convincing?
>
> > I would also prefer to go with option 2 (new zext insn) for JITs.
>
> Got it.
From: "Matthew Wilcox (Oracle)"
One step closer to turning the skb_frag_t into a bio_vec.
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/skbuff.h | 12 +---
net/core/skbuff.c | 2 +-
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/include/linux/skbuff.h b
From: "Matthew Wilcox (Oracle)"
Match the layout of bio_vec.
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/skbuff.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 23f05c64aa31..9c6193a57241 100644
--- a/inclu
From: "Matthew Wilcox (Oracle)"
In preparation for renaming skb_frag_t members, use the fine accessors
which already exist.
Signed-off-by: Matthew Wilcox (Oracle)
---
net/core/skbuff.c| 22 +-
net/core/tso.c | 8
net/ipv4/tcp.c | 12 +++-
n
From: "Matthew Wilcox (Oracle)"
Improved compatibility with bvec
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/skbuff.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index a75e85226bea..df07b3144c77 100
libbpf doesn't allow passing "prog_flags" during bpf program load in a
couple of load related APIs, "bpf_load_program_xattr", "load_program" and
"bpf_prog_load_xattr".
It makes sense to allow passing "prog_flags" which is useful for
customizing program loading.
Reviewed-by: Jakub Kicinski
Signed
From: "Matthew Wilcox (Oracle)"
In preparation for renaming skb_frag fields, use the fine accessors which
already exist.
Signed-off-by: Matthew Wilcox (Oracle)
---
drivers/hsi/clients/ssi_protocol.c | 3 ++-
drivers/net/ethernet/3com/3c59x.c | 2 +-
drivers/net/eth
Patched insns do not go through generic verification, therefore doesn't has
zero extension information collected during insn walking.
We don't bother analyze them at the moment, for any sub-register def comes
from them, just conservatively mark it as needing zero extension.
Signed-off-by: Jiong W
From: "Matthew Wilcox (Oracle)"
To increase commonality between block and net, we are going to replace
the skb_frag_t with the bio_vec. This patch increases the size of
skb_frag_t on 32-bit machines from 8 bytes to 12 bytes. The size is
unchanged on 64-bit machines.
Signed-off-by: Matthew Wilc
From: "Matthew Wilcox (Oracle)"
The skb_frag_t and bio_vec are fundamentally the same (page, offset,
length) tuple. This patch series unifies the two, leaving the
skb_frag_t typedef in place. This has the immediate advantage that
we already have iov_iter support for bvecs and don't need to add
After previous patches, verifier has marked those instructions that really
need zero extension on dst_reg.
It is then for all back-ends to decide how to use such information to
eliminate unnecessary zero extension code-gen during JIT compilation.
One approach is:
1. Verifier insert explicit zer
x86_64 and AArch64 perhaps are two arches that running bpf testsuite
frequently, however the zero extension insertion pass is not enabled for
them because of their hardware support.
It is critical to guarantee the pass correction as it is supposed to be
enabled at default for a couple of other arc
BPF helper call transfers execution from eBPF insns to native functions
while verifier insn walker only walks eBPF insns. So, verifier can only
knows argument and return value types from explicit helper function
prototype descriptions.
For 32-bit optimization, it is important to know whether argum
From: "Matthew Wilcox (Oracle)"
There are a lot of users of frag->page_offset, and of struct
skb_frag_struct, so use a union and a compatibility define respectively
to avoid converting those users today.
Signed-off-by: Matthew Wilcox (Oracle)
---
include/linux/bvec.h | 5 -
include/linux
This patch introduce new alu32 insn BPF_ZEXT, and allocate the unused
opcode 0xe0 to it.
Compared with the other alu32 insns, zero extension on low 32-bit is the
only semantics for this instruction. It also allows various JIT back-ends
to do optimal zero extension code-gen.
BPF_ZEXT is supposed t
Acked-by: Björn Töpel
Signed-off-by: Jiong Wang
---
arch/riscv/net/bpf_jit_comp.c | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/arch/riscv/net/bpf_jit_comp.c b/arch/riscv/net/bpf_jit_comp.c
index 80b12aa..5075e70 100644
--- a/arch/risc
- bpf_fill_ld_abs_vlan_push_pop:
Prevent zext happens inside PUSH_CNT loop. This could happen because
of BPF_LD_ABS (32-bit def) + BPF_JMP (64-bit use), or BPF_LD_ABS +
EXIT (64-bit use of R0). So, change BPF_JMP to BPF_JMP32 and redefine
R0 at exit path to cut off the data-flow f
Cc: Martin Schwidefsky
Cc: Heiko Carstens
Signed-off-by: Jiong Wang
---
arch/s390/net/bpf_jit_comp.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/arch/s390/net/bpf_jit_comp.c b/arch/s390/net/bpf_jit_comp.c
index 51dd026..45ee379 100644
--- a/arch/s39
Cc: David S. Miller
Signed-off-by: Jiong Wang
---
arch/sparc/net/bpf_jit_comp_64.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/arch/sparc/net/bpf_jit_comp_64.c b/arch/sparc/net/bpf_jit_comp_64.c
index 65428e7..8318d3a 100644
--- a/arch/sparc/net/bpf_jit_comp_
The previous libbpf patch allows user to specify "prog_flags" to bpf
program load APIs. To enable high 32-bit randomization for a test, we need
to set BPF_F_TEST_RND_HI32 in "prog_flags".
To enable such randomization for all tests, we need to make sure all places
are passing BPF_F_TEST_RND_HI32. C
eBPF ISA specification requires high 32-bit cleared when low 32-bit
sub-register is written. This applies to destination register of ALU32 etc.
JIT back-ends must guarantee this semantic when doing code-gen.
x86-64 and arm64 ISA has the same semantic, so the corresponding JIT
back-end doesn't need
Cc: Naveen N. Rao
Cc: Sandipan Das
Signed-off-by: Jiong Wang
---
arch/powerpc/net/bpf_jit_comp64.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/net/bpf_jit_comp64.c
b/arch/powerpc/net/bpf_jit_comp64.c
index 21a1dcd..2266c7c 100644
--- a/arch/po
Cc: Wang YanQing
Signed-off-by: Jiong Wang
---
arch/x86/net/bpf_jit_comp32.c | 39 ---
1 file changed, 28 insertions(+), 11 deletions(-)
diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c
index 0d9cdff..8b2576e 100644
--- a/arch/x86/ne
Cc: Shubham Bansal
Signed-off-by: Jiong Wang
---
arch/arm/net/bpf_jit_32.c | 35 ++-
1 file changed, 26 insertions(+), 9 deletions(-)
diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c
index c8bfbbf..a9f5639 100644
--- a/arch/arm/net/bpf_jit_32.c
This patch eliminate zero extension code-gen for instructions including
both alu and load/store. The only exception is for ctx load, because
offload target doesn't go through host ctx convert logic so we do
customized load and ignores zext flag set by verifier.
Reviewed-by: Jakub Kicinski
Signed-
This patch randomizes high 32-bit of a definition when BPF_F_TEST_RND_HI32
is set.
It does this once the flag set no matter there is hardware zero extension
support or not. Because this is a test feature and we want to deliver the
most stressful test.
Suggested-by: Alexei Starovoitov
Signed-off-
v5:
- Adjusted several test_verifier helpers to make them works on hosts
w and w/o hardware zext. (Naveen)
- Make sure zext flag not set when verifier by-passed, for example,
libtest_bpf.ko. (Naveen)
- Conservatively mark bpf main return value as 64-bit. (Alexei)
- Make sure read fl
From: Sameeh Jubran
In some cases when a queue related allocation fails, successful past
allocations are freed but the pointer that pointed to them is not
set to NULL. This is a problem for 2 reasons:
1. This is generally a bad practice since this pointer might be
accidentally accessed in the fut
From: Sameeh Jubran
ena_up() calls ena_init_napi() but does not call ena_del_napi() in
case of failure. This causes a segmentation fault upon rmmod when
netif_napi_del() is called. Fix this bug by calling ena_del_napi()
before returning error from ena_up().
Fixes: 1738cd3ed342 ("net: ena: Add a
From: Sameeh Jubran
Adaptive interrupt moderation was erroneously enabled by default
in the driver.
In case the device supports adaptive interrupt moderation it will
be automatically used, which may potentially increase latency.
The adaptive moderation can be enabled from ethtool command in
cas
From: Sameeh Jubran
GCC 8 contains a number of new warnings as well as enhancements to existing
checkers. The warning - Wstringop-truncation - warns for calls to bounded
string manipulation functions such as strncat, strncpy, and stpncpy that
may either truncate the copied string or leave the des
From: Sameeh Jubran
ena_com_fill_hash_function() didn't configure the rss->hash_func.
Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network
Adapters (ENA)")
Signed-off-by: Netanel Belgazal
Signed-off-by: Sameeh Jubran
---
drivers/net/ethernet/amazon/ena/ena_com.c | 1 +
1
From: Sameeh Jubran
ena_com_set_hash_function() tests if a hash function is supported
by the device before setting it.
The test returns the opposite result than needed.
Reverse the condition to return the correct value.
Also use the BIT macro instead of inline shift.
Fixes: 1738cd3ed342 ("net: e
From: Sameeh Jubran
ena_com_config_llq_info() returns 0 even if ena_com_set_llq() fails.
Return the failure code of ena_com_set_llq() in case it fails.
fixes: 689b2bdaaa14 ("net: ena: add functions for handling Low Latency Queues
in ena_com")
Signed-off-by: Arthur Kiyanovski
Signed-off-by: Sa
From: Sameeh Jubran
second parameter should be the index of the table rather than the value.
Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network
Adapters (ENA)")
Signed-off-by: Saeed Bshara
Signed-off-by: Sameeh Jubran
---
drivers/net/ethernet/amazon/ena/ena_ethtool.c |
From: Sameeh Jubran
Sameeh Jubran (8):
net: ena: fix swapped parameters when calling
ena_com_indirect_table_fill_entry
net: ena: fix: set freed objects to NULL to avoid failing future
allocations
net: ena: fix: Free napi resources when ena_up() fails
net: ena: fix incorrect test o
1 - 100 of 106 matches
Mail list logo