Re: [PATCH v5 net-next 3/6] exthdrs: Registration of TLV handlers and parameters

2019-04-21 Thread kbuild test robot
Hi Tom, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/exthdrs-Make-ext-headers-options-useful-Part-I/20190421-023531 config: x86_64-randconfig-l1-201916 (attached as .config) compiler

BUG: KASAN: use-after-free Read in tun_net_xmit

2019-04-21 Thread YueHaibing
We get a KASAN report as below, but don't have any reproducer. Any comments are appreciated. == BUG: KASAN: use-after-free in tun_net_xmit+0x1670/0x1750 drivers/net/tun.c:1104 Read of size 8 at addr 88836cc26a70 by task swapper/3

Re: [PATCH v5 net-next 5/6] ip6tlvs: Add netlink interface

2019-04-21 Thread David Ahern
On 4/19/19 4:36 PM, Tom Herbert wrote: > Add a netlink interface to manage the TX TLV parameters. Managed > parameters include those for validating and sending TLVs being sent > such as alignment, TLV ordering, length limits, etc. > Why generic netlink for managing IPv6 extensions?

Re: [PATCH net-next] ipv6: Restore RTF_ADDRCONF check in rt6_qualify_for_ecmp

2019-04-21 Thread David Miller
From: David Ahern Date: Sun, 21 Apr 2019 17:39:18 -0700 > From: David Ahern > > The RTF_ADDRCONF flag filters out routes added by RA's in determining > which routes can be appended to an existing one to create a multipath > route. Restore the flag check and add a comment to document the RA piec

Re: [PATCH 4.19 stable 0/3] net: ip6 defrag: backport fixes

2019-04-21 Thread Sasha Levin
On Fri, Apr 19, 2019 at 11:55:11AM -0700, David Miller wrote: From: Sasha Levin Date: Wed, 17 Apr 2019 16:53:17 -0400 On Wed, Apr 17, 2019 at 11:51:27AM -0600, Captain Wiggum wrote: Hi All, We have built 4.19 with Peter's patch, and now all TAHI IPv6 tests pass, even another issue I reported

[PATCH net-next] ipv6: Restore RTF_ADDRCONF check in rt6_qualify_for_ecmp

2019-04-21 Thread David Ahern
From: David Ahern The RTF_ADDRCONF flag filters out routes added by RA's in determining which routes can be appended to an existing one to create a multipath route. Restore the flag check and add a comment to document the RA piece. Fixes: 4e54507ab1a9 ("ipv6: Simplify rt6_qualify_for_ecmp") Sign

Re: [PATCH net-next] ipv6: Simplify rt6_qualify_for_ecmp

2019-04-21 Thread David Miller
From: David Ahern Date: Sun, 21 Apr 2019 08:49:01 -0700 > From: David Ahern > > After commit c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use > ip6_route_info_create"), the gateway is no longer filled in for fib6_nh > structs in a prefix route. Accordingly, the RTF_ADDRCONF flag check can

Re: [PATCH net-next] ipv6: Simplify rt6_qualify_for_ecmp

2019-04-21 Thread Ido Schimmel
On Sun, Apr 21, 2019 at 08:49:01AM -0700, David Ahern wrote: > From: David Ahern > > After commit c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use > ip6_route_info_create"), the gateway is no longer filled in for fib6_nh > structs in a prefix route. Accordingly, the RTF_ADDRCONF flag check c

Re: [PATCH net-next 0/2] mlxsw: Small routing improvements

2019-04-21 Thread David Miller
From: Ido Schimmel Date: Sun, 21 Apr 2019 07:18:33 + > Patch #1 switches the driver to use a unique and stable ECMP/LAG seed. > This allows for consistent behavior across reboots and avoids hash > polarization at the same time. > > Patch #2 relaxes the FIB rule validation in the driver to al

[PATCH net-next] ipv6: Simplify rt6_qualify_for_ecmp

2019-04-21 Thread David Ahern
From: David Ahern After commit c7a1ce397ada ("ipv6: Change addrconf_f6i_alloc to use ip6_route_info_create"), the gateway is no longer filled in for fib6_nh structs in a prefix route. Accordingly, the RTF_ADDRCONF flag check can be dropped from the 'rt6_qualify_for_ecmp'. Further, RTF_DYNAMIC is

Re: [PATCH iproute2-next] iplink: bridge: add support for vlan_stats_per_port

2019-04-21 Thread David Ahern
On 4/16/19 7:19 AM, Nikolay Aleksandrov wrote: > Add support for manipulating and showing the vlan_stats_per_port bridge > option which can be toggled only when there are no port VLANs > configured. Also update the man page with the new option. > > Signed-off-by: Nikolay Aleksandrov > --- > ip/i

Re: [PATCH iproute2-next] ipneigh: Print neighbour offload indication

2019-04-21 Thread David Ahern
On 4/18/19 12:44 AM, Ido Schimmel wrote: > Print the offload indication in case it is set on the neighbour. > > Signed-off-by: Ido Schimmel > --- > ip/ipneigh.c | 3 +++ > 1 file changed, 3 insertions(+) > applied to iproute2-next. Thanks

[PATCH net-next 2/2] mlxsw: spectrum_router: Relax FIB rule validation

2019-04-21 Thread Ido Schimmel
Currently, mlxsw does not support policy-based routing (PBR) and therefore forbids the installation of non-default FIB rules except for the l3mdev rule which is used for VRFs. Relax the check to allow the installation of FIB rules that would never match packets received by the device. Specifically

[PATCH net-next 0/2] mlxsw: Small routing improvements

2019-04-21 Thread Ido Schimmel
Patch #1 switches the driver to use a unique and stable ECMP/LAG seed. This allows for consistent behavior across reboots and avoids hash polarization at the same time. Patch #2 relaxes the FIB rule validation in the driver to allow the installation of rules that direct locally generated traffic (

[PATCH net-next 1/2] mlxsw: spectrum: Use a stable ECMP/LAG seed

2019-04-21 Thread Ido Schimmel
In order to get a consistent behavior of traffic flows across reboots / module unload, we need to use the same ECMP/LAG seed. Calculate the seed by hashing the base MAC of the device. This results in a seed that is both unique (to avoid polarization) and consistent. Signed-off-by: Ido Schimmel A