Re: [PATCH bpf-next V2 2/4] net: core: introduce build_skb_around

2019-04-16 Thread Eric Dumazet
On Tue, Apr 16, 2019 at 8:01 PM Alexei Starovoitov wrote: > It looks good to me, but I'd like to see Eric's Ack before applying. This seems just fine, thanks ! Acked-by: Eric Dumazet

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Heiner Kallweit
On 16.04.2019 22:05, Petr Štetiar wrote: > From: John Crispin > > Many embedded devices have information such as MAC addresses stored > inside MTD devices. This patch allows us to add a property inside a node > describing a network interface. The new property points at a MTD > partition with an o

Re: [PATCH net] tcp: tcp_grow_window() needs to respect tcp_space()

2019-04-16 Thread David Miller
From: Eric Dumazet Date: Tue, 16 Apr 2019 10:55:20 -0700 > For some reason, tcp_grow_window() correctly tests if enough room > is present before attempting to increase tp->rcv_ssthresh, > but does not prevent it to grow past tcp_space() > > This is causing hard to debug issues, like failing > th

Re: [PATCH 0/4] dpaa2-eth: Add flow steering support without masking

2019-04-16 Thread David Miller
From: Ioana Ciocoi Radulescu Date: Tue, 16 Apr 2019 17:13:27 + > On DPAA2 platforms that lack a TCAM (like LS1088A), masking of > flow steering keys is not supported. Until now we didn't offer > flow steering capabilities at all on these platforms. > > Introduce a limited support for flow st

Re: [PATCH net 2/2] ocelot: Clean up stats update deferred work

2019-04-16 Thread David Miller
From: Claudiu Manoil Date: Tue, 16 Apr 2019 17:51:59 +0300 > This is preventive cleanup that may save troubles later. > No need to cancel repeateadly queued work if code is properly > refactored. > Don't let the ethtool -s process interfere with the stat workqueue > scheduling. > > Signed-off-by

Re: [PATCH net 1/2] ocelot: Don't sleep in atomic context (irqs_disabled())

2019-04-16 Thread David Miller
From: Claudiu Manoil Date: Tue, 16 Apr 2019 17:51:58 +0300 > Preemption disabled at: > [] dev_set_rx_mode+0x1c/0x38 > Call trace: > [] dump_backtrace+0x0/0x3d0 > [] show_stack+0x14/0x20 > [] dump_stack+0xac/0xe4 > [] ___might_sleep+0x164/0x238 > [] __might_sleep+0x50/0x88 > [] kmem_cache

Re: [PATCH net-next 1/1] nfp: flower: fix implicit fallthrough warning

2019-04-16 Thread David Miller
From: John Hurley Date: Tue, 16 Apr 2019 15:04:23 +0100 > The nfp_flower_copy_pre_actions function introduces a case statement with > an intentional fallthrough. However, this generates a warning if built > with the -Wimplicit-fallthrough flag. > > Remove the warning by adding a fall through com

Re: [PATCH net-next 0/2] bnx2x: Support for timestamping in P2P mode.

2019-04-16 Thread David Miller
From: Sudarsana Reddy Kalluru Date: Tue, 16 Apr 2019 01:46:11 -0700 > The patch series adds driver support for timestamping the ptp packets > in peer-delay (P2P) mode. > - Patch (1) performs the code cleanup. > - Patch (2) adds the required implementation. > > Please consider applying it 'net-

Re: [PATCH v3] net: Fix missing meta data in skb with vlan packet

2019-04-16 Thread David Miller
From: Yuya Kusakabe Date: Tue, 16 Apr 2019 10:22:28 +0900 > skb_reorder_vlan_header() should move XDP meta data with ethernet header > if XDP meta data exists. > > Fixes: de8f3a83b0a0 ("bpf: add meta pointer for direct access") > Signed-off-by: Yuya Kusakabe > Signed-off-by: Takeru Hayasaka >

Re: [PATCH v3 net-next 3/7] ipv6: Consolidate option cases in ip6_datagram_send_ctl

2019-04-16 Thread David Miller
From: Tom Herbert Date: Mon, 15 Apr 2019 10:52:16 -0700 > case IPV6_2292HOPOPTS: > case IPV6_HOPOPTS: > - if (opt->hopopt || cmsg->cmsg_len < > CMSG_LEN(sizeof(struct ipv6_opt_hdr))) { > - err = -EINVAL; > -

Re: [PATCH 1/1] net/core: work around section mismatch warning for ptp_classifier

2019-04-16 Thread David Miller
From: Gerald Schaefer Date: Mon, 15 Apr 2019 19:14:45 +0200 > From: Ard Biesheuvel > > The routine ptp_classifier_init() uses an initializer for an > automatic struct type variable which refers to an __initdata > symbol. This is perfectly legal, but may trigger a section > mismatch warning when

Re: [PATCH bpf v3 0/5] libbpf: remove two dependencies on Linux

2019-04-16 Thread Alexei Starovoitov
On Tue, Apr 16, 2019 at 5:58 AM Magnus Karlsson wrote: > > This patch set fixes one bug and removes two dependencies on Linux > kernel headers from the XDP socket code in libbpf. A number of people > have pointed out that these two dependencies make it hard to build the > XDP socket part of libbpf

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Frank Rowand
Hi Rob, On 4/16/19 5:29 PM, Florian Fainelli wrote: > > > On 16/04/2019 13:05, Petr Štetiar wrote: >> From: John Crispin >> >> Many embedded devices have information such as MAC addresses stored >> inside MTD devices. This patch allows us to add a property inside a node >> describing a network

Re: [PATCH bpf-next V2 2/4] net: core: introduce build_skb_around

2019-04-16 Thread Alexei Starovoitov
On Fri, Apr 12, 2019 at 8:07 AM Jesper Dangaard Brouer wrote: > > The function build_skb() also have the responsibility to allocate and clear > the SKB structure. Introduce a new function build_skb_around(), that moves > the responsibility of allocation and clearing to the caller. This allows > ca

Re: [PATCH v2] ethtool: Add bash-completion script

2019-04-16 Thread Kevin Locke
On Tue, 2019-04-16 at 14:37 -0400, John W. Linville wrote: > Overall, it looks good to me. But when I build with "make distcheck", > I get this output: > > [...] > > It looks like somewhere you are using "$(bashcompletiondir)" instead of > "$(DESTDIR)$(bashcompletiondir)", but I can't seem to fin

Re: [PATCH bpf-next v2 0/2] show btf id in bpftool map list

2019-04-16 Thread Alexei Starovoitov
On Tue, Apr 16, 2019 at 5:23 PM Prashant Bhole wrote: > > v2: Add btf_id before pinned filename in show_map_close_json() as > suggested by Quentin Applied. Thanks

Re: [PATCH bpf-next] bpftool: Support sysctl hook

2019-04-16 Thread Alexei Starovoitov
On Tue, Apr 16, 2019 at 1:13 PM Andrey Ignatov wrote: > > Add support for recently added BPF_PROG_TYPE_CGROUP_SYSCTL program type > and BPF_CGROUP_SYSCTL attach type. > > Example of bpftool output with sysctl program from selftests: > > # bpftool p load ./test_sysctl_prog.o /mnt/bpf/sysctl_prog

Re: [PATCH bpf-next] libbpf: fix printf formatter for ptrdiff_t argument

2019-04-16 Thread Alexei Starovoitov
On Tue, Apr 16, 2019 at 11:47 AM wrote: > > From: Andrii Nakryiko > > Using %ld for printing out value of ptrdiff_t type is not portable > between 32-bit and 64-bit archs. This is causing compilation errors for > libbpf on 32-bit platform (discovered as part of an effort to integrate > libbpf int

Re: [PATCH bpf-next] bpf: use BPF_CAST_CALL for casting bpf call

2019-04-16 Thread Alexei Starovoitov
On Tue, Apr 16, 2019 at 2:13 AM Prashant Bhole wrote: > > verifier.c uses BPF_CAST_CALL for casting bpf call except at one > place in jit_subprogs(). Let's use the macro for consistency. > > Signed-off-by: Prashant Bhole Applied. Thanks

Re: [PATCH bpf] bpf: allow clearing all sock_ops callback flags

2019-04-16 Thread Alexei Starovoitov
On Mon, Apr 15, 2019 at 2:55 AM Viet Hoang Tran wrote: > > The helper function bpf_sock_ops_cb_flags_set() can be used to both > set and clear the sock_ops callback flags. However, its current > behavior is not consistent. BPF program may clear a flag if more than > one were set, or replace a flag

Re: [PATCH bpf-next] selftests: bpf: add VRF test cases to lwt_ip_encap test.

2019-04-16 Thread Alexei Starovoitov
On Wed, Apr 3, 2019 at 8:43 AM Peter Oskolkov wrote: > > This patch adds tests validating that VRF and BPF-LWT > encap work together well, as requested by David Ahern. > > Signed-off-by: Peter Oskolkov Applied. Thanks

[PATCH net-next] net ipv6: Prevent neighbor add if protocol is disabled on device

2019-04-16 Thread David Ahern
From: David Ahern Disabling IPv6 on an interface removes existing entries but nothing prevents new entries from being manually added. To that end, add a new neigh_table operation, allow_add, that is called on RTM_NEWNEIGH to see if neighbor entries are allowed on a given device. If IPv6 is disabl

Re: [PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Florian Fainelli
On 16/04/2019 13:05, Petr Štetiar wrote: From: John Crispin Many embedded devices have information such as MAC addresses stored inside MTD devices. This patch allows us to add a property inside a node describing a network interface. The new property points at a MTD partition with an offset w

[PATCH bpf-next v2 2/2] tools/bpftool: show btf_id in map listing

2019-04-16 Thread Prashant Bhole
Let's print btf id of map similar to the way we are printing it for programs. Sample output: user@test# bpftool map -f 61: lpm_trie flags 0x1 key 20B value 8B max_entries 1 memlock 4096B 133: array name test_btf_id flags 0x0 key 4B value 4B max_entries 4 memlock 4096B

[PATCH bpf-next v2 1/2] tools/bpftool: re-organize newline printing for map listing

2019-04-16 Thread Prashant Bhole
Let's move the final newline printing in show_map_close_plain() at the end of the function because it looks correct and consistent with prog.c. Also let's do related changes for the line which prints pinned file name. Signed-off-by: Prashant Bhole Reviewed-by: Quentin Monnet Reviewed-by: Jakub K

[PATCH bpf-next v2 0/2] show btf id in bpftool map list

2019-04-16 Thread Prashant Bhole
v2: Add btf_id before pinned filename in show_map_close_json() as suggested by Quentin Patch 1: re-organizes newline character printing at the end of map information. Patch 2: prints btf id of map if it exists Prashant Bhole (2): tools/bpftool: re-organize newline printing for map

RE:

2019-04-16 Thread Carrigan E.
Hello, It's a pleasure writing you on this platform. I have a great Business proposal and I'd like to ask if you are interested because it is highly beneficial to both parties. Kindly indicate your interest for more details. Carrigan E.

Re: [PATCH bpf-next 2/2] tools/bpftool: show btf_id in map listing

2019-04-16 Thread Prashant Bhole
On 4/16/2019 6:22 PM, Quentin Monnet wrote: 2019-04-16 17:59 UTC+0900 ~ Prashant Bhole Let's print btf id of map similar to the way we are printing it for programs. Sample output: user@test# bpftool map -f 61: lpm_trie  flags 0x1 key 20B  value 8B  max_entries 1  memlock 4096B 133: arra

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-16 Thread Florian Fainelli
On 16/04/2019 15:34, Heiner Kallweit wrote: On 17.04.2019 00:25, Andrew Lunn wrote: @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = { .phy_id = PHY_ID_BCM8706, .phy_id_mask= 0x, .name = "Broadcom BCM8706", - .features

[net-next v2 05/12] i40e: Fix for 10G ports LED not blinking

2019-04-16 Thread Jeff Kirsher
From: Piotr Marczak On some hardware LEDs would not blink after command 'ethtool -p {eth-port}' in certain circumstances. Now, function does not care about the activity of the LED (though still preserves its state) but forcibly executes identification blinking and then restores the LED state. Si

[net-next v2 03/12] i40e: don't allow changes to HW VLAN stripping on active port VLANs

2019-04-16 Thread Jeff Kirsher
From: Nicholas Nunley Modifying the VLAN stripping options when a port VLAN is configured will break traffic for the VSI, and conceptually doesn't make sense, so don't allow this. Signed-off-by: Nicholas Nunley Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++

[net-next v2 04/12] i40e: save PTP time before a device reset

2019-04-16 Thread Jeff Kirsher
From: Jacob Keller In the case where PTP is running on the hardware clock, but the kernel system time is not being synced, a device reset can mess up the clock time. This occurs because we reset the clock time based on the kernel time every reset. This causes us to potentially completely reset t

[net-next v2 00/12][pull request] 40GbE Intel Wired LAN Driver Updates 2019-04-16

2019-04-16 Thread Jeff Kirsher
This series contains updates to i40e driver only. Adam fixes i40e so that queues can be restored to its original value if configuring queue channels fails. Bumped the maximum API version supported and added the API version to error messages to clarify supported firmware API versions. Fixed the p

[net-next v2 02/12] i40e: Implement DDP support in i40e driver

2019-04-16 Thread Jeff Kirsher
From: Aleksandr Loktionov This patch introduces DDP (Dynamic Device Personalization) which allows loading profiles that change the way internal parser interprets processed frames. To load DDP profiles it utilizes ethtool flash feature. The files with recipes must be located in /var/lib/firmware d

[net-next v2 09/12] i40e: The driver now prints the API version in error message

2019-04-16 Thread Jeff Kirsher
From: Adam Ludkiewicz Added the API version in the error message for clarity. Signed-off-by: Adam Ludkiewicz Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --

[net-next v2 06/12] i40e: Update i40e_init_dcb to return correct error

2019-04-16 Thread Jeff Kirsher
From: Chinh T Cao Modify the i40e_init_dcb to return the correct error when LLDP or DCBX is not in operational state. Signed-off-by: Chinh T Cao Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_dcb.c | 28 - drivers/net/ethern

[net-next v2 10/12] i40e: Report advertised link modes on 40GBASE_SR4

2019-04-16 Thread Jeff Kirsher
From: Adam Ludkiewicz Defined the advertised link mode field for 4baseSR4_Full for use with ethtool. Signed-off-by: Adam Ludkiewicz Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 7 ++- 1 file changed, 6 insertions(+), 1 dele

[net-next v2 12/12] i40e: Fix misleading error message

2019-04-16 Thread Jeff Kirsher
From: Carolyn Wyborny This patch changes an error code for an admin queue head overrun to use I40E_ERR_ADMIN_QUEUE_FULL instead of I40E_ERR_QUEUE_EMPTY. Signed-off-by: Carolyn Wyborny Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq.c | 2 +

[net-next v2 08/12] i40e: Changed maximum supported FW API version to 1.8

2019-04-16 Thread Jeff Kirsher
From: Adam Ludkiewicz A new FW has been released, which uses API version 1.8. Signed-off-by: Adam Ludkiewicz Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_adminq_cmd.h | 4 ++-- drivers/net/ethernet/intel/iavf/i40e_adminq_cmd.h | 2 +- 2 files

[net-next v2 11/12] i40e: Able to add up to 16 MAC filters on an untrusted VF

2019-04-16 Thread Jeff Kirsher
From: Adam Ludkiewicz This patch fixes the problem with the driver being able to add only 7 multicast MAC address filters instead of 16. The problem is fixed by changing the maximum number of MAC address filters to 16+1+1 (two extra are needed because the driver uses 1 for unicast MAC address and

[net-next v2 01/12] i40e: Queues are reserved despite "Invalid argument" error

2019-04-16 Thread Jeff Kirsher
From: Adam Ludkiewicz Added a new local variable in the i40e_setup_tc function named old_queue_pairs so num_queue_pairs can be restored to the correct value in case configuring queue channels fails. Additionally, moved the exit label in the i40e_setup_tc function so the if (need_reset) block can

[net-next v2 07/12] i40e: Remove misleading messages for untrusted VF

2019-04-16 Thread Jeff Kirsher
From: Grzegorz Siwik Removed misleading messages when untrusted VF tries to add more addresses than NIC limit Signed-off-by: Grzegorz Siwik Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 21 - 1 file changed, 16 inse

Re: [PATCH bpf-next] bpftool: Support sysctl hook

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 13:13:47 -0700, Andrey Ignatov wrote: > Add support for recently added BPF_PROG_TYPE_CGROUP_SYSCTL program type > and BPF_CGROUP_SYSCTL attach type. > > Example of bpftool output with sysctl program from selftests: > > # bpftool p load ./test_sysctl_prog.o /mnt/bpf/sysctl_pr

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-16 Thread Heiner Kallweit
On 17.04.2019 00:25, Andrew Lunn wrote: >> @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = { >> .phy_id = PHY_ID_BCM8706, >> .phy_id_mask= 0x, >> .name = "Broadcom BCM8706", >> -.features = PHY_10GBIT_FEC_FEATURES, >> +.get_

Re: [PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-16 Thread Andrew Lunn
> @@ -194,7 +191,7 @@ static struct phy_driver bcm87xx_driver[] = { > .phy_id = PHY_ID_BCM8706, > .phy_id_mask= 0x, > .name = "Broadcom BCM8706", > - .features = PHY_10GBIT_FEC_FEATURES, > + .get_features = bcm87xx_get_features, >

[PATCH net-next] net: phy: remove dead code from phy_sanitize_settings

2019-04-16 Thread Heiner Kallweit
phy_sanitize_settings() is called from phy_start_aneg() only, and only if phydev->autoneg isn't set. Therefore the removed code does nothing. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/ph

[PATCH net-next] net: phy: bcm87xx: improve feature configuration

2019-04-16 Thread Heiner Kallweit
This driver is the only user of PHY_10GBIT_FEC_FEATURES. So we may be able to remove this predefined feature constant later. Setting phydev->advertising to what is supported is done by phy_probe(), therefore we don't have to do it in the config_init callback. Resetting phydev->autoneg if autoneg is

[PATCH net-next] net: phy: don't set autoneg if it's not supported

2019-04-16 Thread Heiner Kallweit
In phy_device_create() we set phydev->autoneg = 1. This isn't changed even if the PHY doesn't support autoneg. This seems to affect very few PHY's, and they disable phydev->autoneg in their config_init callback. So it's more of an improvement, therefore net-next. The patch also wouldn't apply to ol

Re: [RFC PATCH net-next] net: sched: flower: refactor reoffload for concurrent access

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 17:20:47 +0300, Vlad Buslov wrote: > @@ -1551,6 +1558,10 @@ static int fl_change(struct net *net, struct sk_buff > *in_skb, > goto errout_mask; > > if (!tc_skip_hw(fnew->flags)) { > + spin_lock(&tp->lock); > + list_add(&fnew->hw_lis

Re: [PATCH bpf-next 2/2] tools/bpftool: show btf_id in map listing

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 10:22:15 +0100, Quentin Monnet wrote: > > diff --git a/tools/bpf/bpftool/map.c b/tools/bpf/bpftool/map.c > > index cda0f27fa895..de3e4cb32d21 100644 > > --- a/tools/bpf/bpftool/map.c > > +++ b/tools/bpf/bpftool/map.c > > @@ -550,6 +550,9 @@ static int show_map_close_json(int fd,

[PATCH v2 net-next 07/13] ipv6: Pass fib6_result to rt6_insert_exception

2019-04-16 Thread David Ahern
From: David Ahern Update rt6_insert_exception to take a fib6_result over a fib6_info. Change ort to f6i from the fib6_result and rename to better reflect what it references (a fib6_info). Since this function is already getting changed, update the comments to reference fib6_info variables rather

[PATCH v2 net-next 02/13] ipv6: Pass fib6_result to rt6_find_cached_rt

2019-04-16 Thread David Ahern
From: David Ahern Simplify rt6_find_cached_rt for the fast path cases and pass fib6_result to rt6_find_cached_rt. Rename the local return variable to ret to maintain consisting with fib6_result name. Update the comment in rt6_find_cached_rt to reference the new names in a fib6_info vs the old na

[PATCH v2 net-next 06/13] ipv6: Pass fib6_result to ip6_rt_get_dev_rcu and ip6_rt_copy_init

2019-04-16 Thread David Ahern
From: David Ahern Now that all callers are update to have a fib6_result, pass it down to ip6_rt_get_dev_rcu, ip6_rt_copy_init, and ip6_rt_init_dst. In the process, change ort to f6i in ip6_rt_copy_init to make it clear it is a reference to a fib6_info. Signed-off-by: David Ahern --- net/ipv6/

[PATCH v2 net-next 12/13] ipv6: Pass fib6_result to fib lookups

2019-04-16 Thread David Ahern
From: David Ahern Change fib6_lookup and fib6_table_lookup to take a fib6_result and set f6i and nh rather than returning a fib6_info. For now both always return 0. A later patch set can make these more like the IPv4 counterparts and return EINVAL, EACCESS, etc based on fib6_type. Signed-off-by

[PATCH v2 net-next 08/13] ipv6: Pass fib6_result to ip6_mtu_from_fib6 and fib6_mtu

2019-04-16 Thread David Ahern
From: David Ahern Change ip6_mtu_from_fib6 and fib6_mtu to take a fib6_result over a fib6_info. Update both to use the fib6_nh from fib6_result. Since the signature of ip6_mtu_from_fib6 is already changing, add const to daddr and saddr. Signed-off-by: David Ahern --- include/net/ip6_route.h

[PATCH v2 net-next 09/13] ipv6: Pass fib6_result to rt6_device_match

2019-04-16 Thread David Ahern
From: David Ahern Pass fib6_result to rt6_device_match with f6i set. rt6_device_match updates f6i in the result if it finds a better match and sets nh. Signed-off-by: David Ahern --- net/ipv6/route.c | 49 ++--- 1 file changed, 30 insertions(+), 19 d

[PATCH v2 net-next 00/13] ipv6: Use fib6_result for fib_lookups

2019-04-16 Thread David Ahern
From: David Ahern Add fib6_result as a single data structure to hold results from a fib lookup. IPv6 currently has everything in 1 data structure - a fib6_info, but with nexthop objects the fib6_nh can be in a nexthop or a nexthop can be a blackhole which affects the fib6_type and flags (REJECT).

[PATCH v2 net-next 03/13] ipv6: Pass fib6_result to ip6_rt_cache_alloc

2019-04-16 Thread David Ahern
From: David Ahern Change ip6_rt_cache_alloc to take a fib6_result over a fib6_info. Since ip6_rt_cache_alloc is only the caller, update the rt6_is_gw_or_nonexthop helper to take fib6_result. Signed-off-by: David Ahern --- net/ipv6/route.c | 46 +- 1

[PATCH v2 net-next 05/13] ipv6: Pass fib6_result to pcpu route functions

2019-04-16 Thread David Ahern
From: David Ahern Update ip6_rt_pcpu_alloc, rt6_get_pcpu_route and rt6_make_pcpu_route to a fib6_result over a fib6_info. Signed-off-by: David Ahern --- net/ipv6/route.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv

[PATCH v2 net-next 04/13] ipv6: Pass fib6_result to ip6_create_rt_rcu

2019-04-16 Thread David Ahern
From: David Ahern Change ip6_create_rt_rcu to take fib6_result over a fib6_info. Signed-off-by: David Ahern --- net/ipv6/route.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index f267b3060ac7..5

[PATCH v2 net-next 11/13] ipv6: Pass fib6_result to fib6_table_lookup tracepoint

2019-04-16 Thread David Ahern
From: David Ahern Change fib6_table_lookup tracepoint to take the fib6_result and use the fib6_info and fib6_nh from it. Signed-off-by: David Ahern --- include/trace/events/fib6.h | 16 net/ipv6/route.c| 6 +++--- 2 files changed, 11 insertions(+), 11 deletions(-)

[PATCH v2 net-next 01/13] ipv6: Rename fib6_multipath_select and pass fib6_result

2019-04-16 Thread David Ahern
From: David Ahern Add 'struct fib6_result' to hold the fib entry and fib6_nh from a fib lookup as separate entries, similar to what IPv4 now has with fib_result. Rename fib6_multipath_select to fib6_select_path, pass fib6_result to it, and set f6i and nh in the result once a path selection is do

[PATCH v2 net-next 13/13] ipv6: Add fib6_type and fib6_flags to fib6_result

2019-04-16 Thread David Ahern
From: David Ahern Add the fib6_flags and fib6_type to fib6_result. Update the lookup helpers to set them and update post fib lookup users to use the version from the result. This allows nexthop objects to have blackhole nexthop. Signed-off-by: David Ahern --- include/net/ip6_fib.h | 2

[PATCH v2 net-next 10/13] ipv6: Pass fib6_result to rt6_select and find_rr_leaf

2019-04-16 Thread David Ahern
From: David Ahern Pass fib6_result to rt6_select. Instead of returning the fib entry, it will set f6i and nh based on the lookup. find_rr_leaf is changed to remove the match option in favor of taking fib6_result and having __find_rr_leaf set f6i in the result. In the process, update fib6_info r

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 15:55:23 +0200, Jesper Dangaard Brouer wrote: > On Mon, 15 Apr 2019 15:49:32 -0700 > Jakub Kicinski wrote: > > > On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: > > > On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel > > > wrote: > > > > Hi, > > > > > >

Re: [PATCH bpf-next] libbpf: fix printf formatter for ptrdiff_t argument

2019-04-16 Thread Song Liu
On Tue, Apr 16, 2019 at 11:47 AM wrote: > > From: Andrii Nakryiko > > Using %ld for printing out value of ptrdiff_t type is not portable > between 32-bit and 64-bit archs. This is causing compilation errors for > libbpf on 32-bit platform (discovered as part of an effort to integrate > libbpf int

Re: [PATCH bpf v3 0/5] libbpf: remove two dependencies on Linux

2019-04-16 Thread Song Liu
On Tue, Apr 16, 2019 at 5:58 AM Magnus Karlsson wrote: > > This patch set fixes one bug and removes two dependencies on Linux > kernel headers from the XDP socket code in libbpf. A number of people > have pointed out that these two dependencies make it hard to build the > XDP socket part of libbpf

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 09:45:24 +0200, Björn Töpel wrote: > > > > If we'd like to slice a netdevice into multiple queues. Isn't macvlan > > > > or similar *virtual* netdevices a better path, instead of introducing > > > > yet another abstraction? > > > > Yes, the question of use cases is extremely i

Re: [PATCH bpf-next] bpftool: Support sysctl hook

2019-04-16 Thread Song Liu
> On Apr 16, 2019, at 1:13 PM, Andrey Ignatov wrote: > > Add support for recently added BPF_PROG_TYPE_CGROUP_SYSCTL program type > and BPF_CGROUP_SYSCTL attach type. > > Example of bpftool output with sysctl program from selftests: > > # bpftool p load ./test_sysctl_prog.o /mnt/bpf/sysctl_p

Re: [PATCH bpf-next 2/2] tools/bpftool: show btf_id in map listing

2019-04-16 Thread Song Liu
> On Apr 16, 2019, at 2:22 AM, Quentin Monnet > wrote: > > 2019-04-16 17:59 UTC+0900 ~ Prashant Bhole >> Let's print btf id of map similar to the way we are printing it >> for programs. >> Sample output: >> user@test# bpftool map -f >> 61: lpm_trie flags 0x1 >> key 20B value 8B max_e

Re: [PATCH bpf-next 1/2] tools/bpftool: re-organize newline printing for map listing

2019-04-16 Thread Song Liu
> On Apr 16, 2019, at 2:22 AM, Quentin Monnet > wrote: > > 2019-04-16 17:59 UTC+0900 ~ Prashant Bhole >> Let's move the final newline printing in show_map_close_plain() at >> the end of the function because it looks correct and consistent with >> prog.c. Also let's do related changes for the

[PATCH v3 17/26] compat_ioctl: move hci_sock handlers into driver

2019-04-16 Thread Arnd Bergmann
All these ioctl commands are compatible, so we can handle them with a trivial wrapper in hci_sock.c and remove the listing in fs/compat_ioctl.c. A few of the commands pass integer arguments instead of pointers, so for correctness skip the compat_ptr() conversion here. Signed-off-by: Arnd Bergmann

Re: [PATCH bpf-next] bpf: use BPF_CAST_CALL for casting bpf call

2019-04-16 Thread Song Liu
> On Apr 16, 2019, at 2:13 AM, Prashant Bhole > wrote: > > verifier.c uses BPF_CAST_CALL for casting bpf call except at one > place in jit_subprogs(). Let's use the macro for consistency. > > Signed-off-by: Prashant Bhole Acked-by: Song Liu > --- > kernel/bpf/verifier.c | 5 ++--- > 1 fil

Re: [PATCH v4 bpf-next 01/15] bpf: split read liveness into REG_LIVE_READ64 and REG_LIVE_READ32

2019-04-16 Thread Jiong Wang
Alexei Starovoitov writes: > On Tue, Apr 16, 2019 at 08:39:30AM +0100, Jiong Wang wrote: >> >> Alexei Starovoitov writes: >> >> > On Mon, Apr 15, 2019 at 06:26:11PM +0100, Jiong Wang wrote: >> >> Register liveness infrastructure doesn't track register read width at the >> >> moment, while the

[PATCH] of_net: add mtd-mac-address support to of_get_mac_address()

2019-04-16 Thread Petr Štetiar
From: John Crispin Many embedded devices have information such as MAC addresses stored inside MTD devices. This patch allows us to add a property inside a node describing a network interface. The new property points at a MTD partition with an offset where the MAC address can be found. This patch

[PATCH bpf-next] bpftool: Support sysctl hook

2019-04-16 Thread Andrey Ignatov
Add support for recently added BPF_PROG_TYPE_CGROUP_SYSCTL program type and BPF_CGROUP_SYSCTL attach type. Example of bpftool output with sysctl program from selftests: # bpftool p load ./test_sysctl_prog.o /mnt/bpf/sysctl_prog type cgroup/sysctl # bpftool p l 9: cgroup_sysctl name sysctl_

[PATCH bpf-next] libbpf: fix printf formatter for ptrdiff_t argument

2019-04-16 Thread andrii.nakryiko
From: Andrii Nakryiko Using %ld for printing out value of ptrdiff_t type is not portable between 32-bit and 64-bit archs. This is causing compilation errors for libbpf on 32-bit platform (discovered as part of an effort to integrate libbpf into systemd ([0])). Proper formatter is %td, which is us

Re: [PATCH v5 1/2] net: phy: mscc: add support for VSC8514 PHY.

2019-04-16 Thread Heiner Kallweit
On 16.04.2019 07:39, kavyasree.kotag...@microchip.com wrote: > The VSC8514 PHY is a 4-ports PHY that is 10/100/1000BASE-T, 100BASE-FX, > 1000BASE-X, can communicate with the MAC via QSGMII. > The MAC interface protocol for each port within QSGMII can > be either 1000BASE-X or SGMII, if the QSGMII M

Re: [PATCH v2] ethtool: Add bash-completion script

2019-04-16 Thread John W. Linville
On Thu, Apr 11, 2019 at 11:39:32AM -0600, Kevin Locke wrote: > To aid users constructing a valid ethtool invocation, create a > [bash-completion] script to provide [programmable completion] of ethtool > arguments. It supports all current command options. > > The script is named shell-completion/b

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Björn Töpel
On Tue, 16 Apr 2019 at 18:53, Jonathan Lemon wrote: > > On 16 Apr 2019, at 6:55, Jesper Dangaard Brouer wrote: > > > On Mon, 15 Apr 2019 15:49:32 -0700 > > Jakub Kicinski wrote: > > > >> On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: > >>> On Mon, 15 Apr 2019 13:59:03 +0200 Bjö

Re: [patch net-next rfc 00/15] netdevsim: impement proper device model

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 10:59:37 +0200, Jiri Pirko wrote: > >> 4) netdevsim instances are created by "ip link add" which is great for > >>soft devices with no hw backend. The rtnl core allocates netdev and > >>calls into driver holding rtnl mutex. For hw-backed devices, this > >>flow is wro

Re: [patch net-next rfc 00/15] netdevsim: impement proper device model

2019-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2019 10:53:12 +0200, Jiri Pirko wrote: > Mon, Apr 15, 2019 at 09:27:09PM CEST, jakub.kicin...@netronome.com wrote: > >On Sat, 13 Apr 2019 18:20:57 +0200, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> Currently the model of netdevsim is a bit odd in multiple ways. > >> 1) devl

[PATCH net] tcp: tcp_grow_window() needs to respect tcp_space()

2019-04-16 Thread Eric Dumazet
For some reason, tcp_grow_window() correctly tests if enough room is present before attempting to increase tp->rcv_ssthresh, but does not prevent it to grow past tcp_space() This is causing hard to debug issues, like failing the (__tcp_select_window(sk) >= tp->rcv_wnd) test in __tcp_ack_snd_check(

Лучшие рассылки по Украине

2019-04-16 Thread Рассылки
Приветствую Вас, Лучшие рассылки по Украине. Приятные цены. Быстрая и качественная доставка почтовых сообщений. Email: mail.2009@gmail.com Skype: abus.host Viber: +380993552733

[PATCH bpf-next] libbpf: fix printf formatter for ptrdiff_t argument

2019-04-16 Thread andrii.nakryiko
From: Andrii Nakryiko Using %ld for printing out value of ptrdiff_t type is not portable between 32-bit and 64-bit archs. This is causing compilation errors for libbpf on 32-bit platform. Proper formatter is %td, which is used in this patch. Cc: Daniel Borkmann Cc: Alexei Starovoitov Cc: Yongh

[PATCH net-next 2/4] dpaa2-eth: Add a couple of macros

2019-04-16 Thread Ioana Ciocoi Radulescu
Add two macros to simplify reading DPNI options. Signed-off-by: Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 +-- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 6 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale

[PATCH 0/4] dpaa2-eth: Add flow steering support without masking

2019-04-16 Thread Ioana Ciocoi Radulescu
On DPAA2 platforms that lack a TCAM (like LS1088A), masking of flow steering keys is not supported. Until now we didn't offer flow steering capabilities at all on these platforms. Introduce a limited support for flow steering, where we only allow ethtool rules that share a common key (i.e. have th

[PATCH net-next 4/4] dpaa2-eth: Add flow steering support without masking

2019-04-16 Thread Ioana Ciocoi Radulescu
On platforms that lack a TCAM (like LS1088A), masking of flow steering keys is not supported. Until now we didn't offer flow steering capabilities at all on these platforms, since our driver implementation configured a "comprehensive" FS key (containing all supported header fields), with masks used

[PATCH net-next 1/4] dpaa2-eth: Fix Rx classification status

2019-04-16 Thread Ioana Ciocoi Radulescu
Set the Rx flow classification enable flag only if key config operation is successful. Fixes 3f9b5c9 ("dpaa2-eth: Configure Rx flow classification key") Signed-off-by: Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-

[PATCH net-next 3/4] dpaa2-eth: Update hash key composition code

2019-04-16 Thread Ioana Ciocoi Radulescu
Introduce an internal id bitfield to uniquely identify header fields supported by the Rx distribution keys. For the hash key, add a conversion from the RXH_* bitmask provided by ethtool to the internal ids. Signed-off-by: Ioana Radulescu --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 19

Re: Per-queue XDP programs, thoughts

2019-04-16 Thread Jonathan Lemon
On 16 Apr 2019, at 6:55, Jesper Dangaard Brouer wrote: On Mon, 15 Apr 2019 15:49:32 -0700 Jakub Kicinski wrote: On Mon, 15 Apr 2019 18:32:58 +0200, Jesper Dangaard Brouer wrote: On Mon, 15 Apr 2019 13:59:03 +0200 Björn Töpel wrote: Hi, As you probably can derive from the amount of time th

Re: [PATCH v4 bpf-next 01/15] bpf: split read liveness into REG_LIVE_READ64 and REG_LIVE_READ32

2019-04-16 Thread Alexei Starovoitov
On Tue, Apr 16, 2019 at 08:39:30AM +0100, Jiong Wang wrote: > > Alexei Starovoitov writes: > > > On Mon, Apr 15, 2019 at 06:26:11PM +0100, Jiong Wang wrote: > >> Register liveness infrastructure doesn't track register read width at the > >> moment, while the width information will be needed for t

[PATCH iproute2 v2] bridge: vlan: fix standard stats output

2019-04-16 Thread Nikolay Aleksandrov
Each of the commits below broke the vlan stats output in a different way: - 45fca4ed9412 ("bridge: fix vlan show stats formatting") Added a second print of an interface name (e.g. eth4eth4) - c7c1a1ef51ae ("bridge: colorize output and use JSON print library") Broke normal vlan stats output by not

Re: [RFC net-next 1/1] tdc.py: Introduce required plugins

2019-04-16 Thread Lucas Bates
On Fri, Apr 12, 2019 at 7:37 PM Nicolas Dichtel wrote: > > Le 12/04/2019 à 18:07, Lucas Bates a écrit : > [snip] > > So something like this? Note the usage of the keyword "requires", > > > > { > > "id": "901f", > > "name": "Add fw filter with prio at 32-bit maxixum", > >

[PATCH iproute2] bridge: vlan: fix standard stats output

2019-04-16 Thread Nikolay Aleksandrov
Each of the commits below broke the vlan stats output in a different way: - 45fca4ed9412 ("bridge: fix vlan show stats formatting") Added a second print of an interface name (e.g. eth4eth4) - c7c1a1ef51ae ("bridge: colorize output and use JSON print library") Broke normal vlan stats output by not

Re: [PATCH net-next 12/13] ipv6: Pass fib6_result to fib lookups

2019-04-16 Thread David Ahern
On 4/15/19 6:56 PM, David Ahern wrote: > @@ -182,14 +178,10 @@ static int fib6_rule_action_alt(struct fib_rule *rule, > struct flowi *flp, > return -EAGAIN; > > oif = (int *)arg->lookup_data; > - f6i = fib6_table_lookup(net, table, *oif, flp6, flags); > - if (f6i != n

Re: Question re. skb_orphan for TPROXY

2019-04-16 Thread Florian Westphal
Lorenz Bauer wrote: > Apologies for contacting you out of the blue. I'm currently trying to > understand how TPROXY works under the hood. As part of this endeavour, > I've stumbled upon the commit attached to this email. > > From the commit message I infer that somewhere, TPROXY relies on a > che

[PATCH net 1/2] ocelot: Don't sleep in atomic context (irqs_disabled())

2019-04-16 Thread Claudiu Manoil
Preemption disabled at: [] dev_set_rx_mode+0x1c/0x38 Call trace: [] dump_backtrace+0x0/0x3d0 [] show_stack+0x14/0x20 [] dump_stack+0xac/0xe4 [] ___might_sleep+0x164/0x238 [] __might_sleep+0x50/0x88 [] kmem_cache_alloc+0x17c/0x1d0 [] ocelot_set_rx_mode+0x108/0x188 [mscc_ocelot_common] []

[PATCH net 2/2] ocelot: Clean up stats update deferred work

2019-04-16 Thread Claudiu Manoil
This is preventive cleanup that may save troubles later. No need to cancel repeateadly queued work if code is properly refactored. Don't let the ethtool -s process interfere with the stat workqueue scheduling. Signed-off-by: Claudiu Manoil --- drivers/net/ethernet/mscc/ocelot.c | 22

Question re. skb_orphan for TPROXY

2019-04-16 Thread Lorenz Bauer
Hello Herbert (and List), Apologies for contacting you out of the blue. I'm currently trying to understand how TPROXY works under the hood. As part of this endeavour, I've stumbled upon the commit attached to this email. >From the commit message I infer that somewhere, TPROXY relies on a check of

  1   2   >