On 05.04.2019 06:26, Toshiaki Makita wrote:
On 2019/04/05 5:22, Rafał Miłecki wrote:
On 04.04.2019 17:17, Toshiaki Makita wrote:
On 19/04/04 (木) 21:57:15, Rafał Miłecki wrote:
I'd like to report a regression that goes back to the 2015. I know
it's damn
late, but the good thing is, the regressi
On 2019/04/05 5:22, Rafał Miłecki wrote:
> On 04.04.2019 17:17, Toshiaki Makita wrote:
>> On 19/04/04 (木) 21:57:15, Rafał Miłecki wrote:
>>> I'd like to report a regression that goes back to the 2015. I know
>>> it's damn
>>> late, but the good thing is, the regression is still easy to
>>> reproduc
On Thu, Apr 04, 2019 at 06:18:30PM -0600, Captain Wiggum wrote:
> Hi Greg,
>
> A previous bad patch breaks 18 test cases for IPv6 fragment headers.
> This has already been un-done in upstream, but not in any of the LTS.
> However two upstream patches are first needed to cover a DoS vulnerability.
On Fri, Apr 5, 2019 at 1:38 AM David Miller wrote:
>
> From: Xin Long
> Date: Thu, 4 Apr 2019 17:45:07 +0800
>
> > We're thinking about adding some sctp tests into selftests,
> > but these ones are not good to be the first one, I think.
> > sysctl_sockets_memctl.sh is a multi-host test, even netn
On 2019-04-04 14:38, Johannes Berg wrote:
Hi,
The normal mode of operation of rmnet is using the rmnet netdevices
in an embedded device.
Sure. Can you say what driver this would typically live on top of? I'm
actually a bit surprised to find out this isn't really a driver :-)
This needs a p
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jkirsher-next-queue/dev-queue]
[also build test WARNING on v5.1-rc3 next-20190404]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
On 4/3/19 9:43 AM, Peter Oskolkov wrote:
> This patch adds tests validating that VRF and BPF-LWT
> encap work together well, as requested by David Ahern.
>
> Signed-off-by: Peter Oskolkov
> ---
> .../selftests/bpf/test_lwt_ip_encap.sh| 134 +++---
> 1 file changed, 86 inserti
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jkirsher-next-queue/dev-queue]
[also build test WARNING on v5.1-rc3 next-20190404]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
From: Thomas Falcon
Date: Thu, 4 Apr 2019 18:58:26 -0500
> Fix device initialization completion handling for vNIC adapters.
> Initialize the completion structure on probe and reinitialize when needed.
> This also fixes a race condition during kdump where the driver can attempt
> to access the co
From: Lorenzo Bianconi
Date: Thu, 4 Apr 2019 16:37:53 +0200
> ipip6 tunnels run iptunnel_pull_header on received skbs. This can
> determine the following use-after-free accessing iph pointer since
> the packet will be 'uncloned' running pskb_expand_head if it is a
> cloned gso skb (e.g if the pa
Hi Jeff,
Jeff Kirsher writes:
> A module parameter maybe fine for our out-of-tree driver, but not for the
> kernel driver.
>
> NACK on the basis that a new module parameter is being introduced for the
> driver. This is not acceptable by Dave Miller or myself. As of now, I do
> not have a alter
From: Heiner Kallweit
Date: Wed, 3 Apr 2019 23:13:18 +0200
> Meanwhile we have generic functions for reading the abilities of
> Clause 22 / 45 PHY's. This allows to use them as fallback in case
> callback get_features isn't set. Benefit is the reduction of
> boilerplate code in PHY drivers.
>
>
On Fri, Apr 5, 2019 at 2:20 AM David Miller wrote:
>
> From: Matteo Croce
> Date: Wed, 3 Apr 2019 01:11:36 +0200
>
> > The thunderx driver forbids to load an eBPF program if the MTU is
> > higher than 1500 bytes, but this can be circumvented by first
> > loading the eBPF, and then raising the MT
From: Heiner Kallweit
Date: Wed, 3 Apr 2019 19:54:12 +0200
> This reverts commit 6578229d4efb7ea6287861bfc2bd306140458e07.
> netif_receive_skb_list() doesn't support GRO, therefore we may have
> scenarios with decreased performance. See discussion here [0].
>
> [0] https://marc.info/?t=155403847
From: Jiri Pirko
Date: Wed, 3 Apr 2019 14:24:14 +0200
> From: Jiri Pirko
>
> Extend devlink port attrs to contain switch ID and change drivers that
> register devlink ports to use that.
Series applied, thanks Jiri.
From: Varun Prakash
Date: Wed, 3 Apr 2019 17:30:14 +0530
> BITS_TO_LONGS() uses DIV_ROUND_UP() because of
> this ppmax value can be greater than available
> per cpu page pods.
>
> This patch removes BITS_TO_LONGS() to fix this
> issue.
>
> Signed-off-by: Varun Prakash
Applied.
From: Yuval Shaia
Date: Wed, 3 Apr 2019 12:15:07 +0300
> This header is not in use - remove it.
>
> Signed-off-by: Yuval Shaia
Applied to net-next.
From: Florian Westphal
Date: Wed, 3 Apr 2019 08:28:35 +0200
> syzbot reports:
> BUG: using __this_cpu_read() in preemptible code:
> caller is dev_recursion_level include/linux/netdevice.h:3052 [inline]
> __this_cpu_preempt_check+0x246/0x270 lib/smp_processor_id.c:47
> dev_recursion_level inclu
From: Tom Herbert
Date: Tue, 2 Apr 2019 19:36:25 -0700
> This patch series is Part I. It reorganizes the extension header related
> files to make them easier to maintain and update. They are:
If we don't see the patches that add ipv4 support alongside this I'm
not going to apply patches that ju
From: Matteo Croce
Date: Wed, 3 Apr 2019 01:11:36 +0200
> The thunderx driver forbids to load an eBPF program if the MTU is higher
> than 1500 bytes, but this can be circumvented by first loading the eBPF,
> and then raising the MTU.
>
> XDP assumes that SKBs are linear and fit in a single page
From: John Hurley
Date: Tue, 2 Apr 2019 23:53:20 +0100
> Recent changes to TC flower remove the requirement for rtnl lock when
> accessing and modifying filters. Refcounts now ensure access and deletion
> do not happen concurrently. However, the reoffload function which cycles
> through all filt
From: Chris Leech
Date: Tue, 2 Apr 2019 15:06:12 -0700
> Way back in 3c9c36bcedd426f2be2826da43e5163de61735f7 the
> ndo_fcoe_get_wwn pointer was switched from depending on CONFIG_FCOE to
> CONFIG_LIBFCOE in order to allow building FCoE support into the bnx2x
> driver and used by bnx2fc without i
Hi Greg,
A previous bad patch breaks 18 test cases for IPv6 fragment headers.
This has already been un-done in upstream, but not in any of the LTS.
However two upstream patches are first needed to cover a DoS vulnerability.
For background, there are two mail threads in [netdev] on this subject:
1
From: Daniel Borkmann
Date: Thu, 4 Apr 2019 17:21:41 +0200
> The following pull-request contains BPF updates for your *net* tree.
>
> The main changes are:
>
> 1) Batch of fixes to the existing BPF flow dissector API to support
>calling BPF programs from the eth_get_headlen context (suppor
On Thu, 2019-04-04 at 14:56 -0700, Vinicius Costa Gomes wrote:
> We have seen some reports[1] of users complaining that they aren't
> able to use some queues when their machines have less than 4 cpus.
> This affects some TSN workloads, as different traffic classes are
> assigned different queues. T
Fix device initialization completion handling for vNIC adapters.
Initialize the completion structure on probe and reinitialize when needed.
This also fixes a race condition during kdump where the driver can attempt
to access the completion struct before it is initialized:
Unable to handle kernel p
> > Unfortunately I have to report that the crashing has resurfaced. I'm
> > currently using kernel 5.0 with Heiner's fix applied. In the last few
> > days I've had the crash occur 4 times now. I'm not sure how to further
> > investigate this but I'm guessing a patch that adds more debugging
> > ou
We have seen some reports[1] of users complaining that they aren't
able to use some queues when their machines have less than 4 cpus.
This affects some TSN workloads, as different traffic classes are
assigned different queues. The current behavior limits the number of
traffic classes that can be re
clang started to error on invalid asm clobber usage in x86 headers
and many bpf program samples failed to build with the message:
CLANG-bpf /data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.o
In file included from
/data/users/ast/bpf-next/samples/bpf/xdp_redirect_kern.c:14:
In file includ
On Thu, 2019-04-04 at 22:38 +0200, Johannes Berg wrote:
> > The bridge mode is used only for testing by sending frames
> > without de-muxing to some other driver such as a USB netdev so packets
> > can be parsed on a tethered PC.
>
> Yeah, I get it, it's just done in a strange way. You'd think ad
Hi,
> The normal mode of operation of rmnet is using the rmnet netdevices
> in an embedded device.
Sure. Can you say what driver this would typically live on top of? I'm
actually a bit surprised to find out this isn't really a driver :-)
In my view right now, I'd recommend splitting rmnet into t
From: David Ahern
Date: Thu, 4 Apr 2019 09:07:04 -0600
> On 4/3/19 10:50 PM, David Miller wrote:
>> From: David Ahern
>> Date: Tue, 2 Apr 2019 14:11:53 -0700
>>
>>> From: David Ahern
>>>
>>> Second set of three with the end goal of enabling IPv6 gateways with IPv4
>>> routes.
>>>
>>> This set
On 04.04.2019 17:17, Toshiaki Makita wrote:
On 19/04/04 (木) 21:57:15, Rafał Miłecki wrote:
I'd like to report a regression that goes back to the 2015. I know it's damn
late, but the good thing is, the regression is still easy to reproduce, verify &
revert.
Long story short, starting with the co
On 04.04.2019 16:28, VDR User wrote:
> Hi,
>
> Unfortunately I have to report that the crashing has resurfaced. I'm
> currently using kernel 5.0 with Heiner's fix applied. In the last few
> days I've had the crash occur 4 times now. I'm not sure how to further
> investigate this but I'm guessing a
On 2019-04-04 09:52, Dan Williams wrote:
On Thu, 2019-04-04 at 11:00 +0200, Johannes Berg wrote:
Hi,
> Thanks a lot for doing this! Being responsible for most of the
> issues
> you point out, I can only say that you have my full support if you
> want
> to change any of it.
:-)
> My pathetic
Simple test that sets cb to {1,2,3,4,5} and priority to 6, runs bpf
program that fails if cb is not what we expect and increments cb[i] and
priority. When the test finishes, we check that cb is now {2,3,4,5,6}
and priority is 7.
We also test the sanity checks:
* ctx_in is provided, but ctx_size_in
Support recently introduced input/output context for test runs.
We extend only bpf_prog_test_run_xattr. bpf_prog_test_run is
unextendable and left as is.
Signed-off-by: Stanislav Fomichev
---
tools/include/uapi/linux/bpf.h | 7 +++
tools/lib/bpf/bpf.c| 5 +
tools/lib/bpf/bpf.
Add new set of arguments to bpf_attr for BPF_PROG_TEST_RUN:
* ctx_in/ctx_size_in - input context
* ctx_out/ctx_size_out - output context
The intended use case is to pass some meta data to the test runs that
operate on skb (this has being brought up on recent LPC).
For programs that use bpf_prog_t
On Thu, Apr 04, 2019 at 08:47:02PM +0800, Hangbin Liu wrote:
> After adding a team interface to bridge, the team interface will enter
> promisc mode. Then if we add a new slave to team0, the slave will keep
> promisc off. Fix it by setting slave to promisc on if team master is
> already in promisc
From: David Ahern
Add support for an IPv6 gateway to fib_config. Since a gateway is either
IPv4 or IPv6, make it a union with fc_gw4 where fc_gw_family decides
which address is in use. Update current checks on family and gw4 to
handle ipv6 as well.
Signed-off-by: David Ahern
---
include/net/ip
From: linmiaohe
Date: Thu, 4 Apr 2019 20:01:13 +0800
> When the mtu of a vrf device is set to 0, it would cause ping
> failed.So I think we should limit dev->min_mtu to ETH_MIN_MTU
> to solve this problem. And if dev->max_mtu still be 0 can be
> confusing, so I limit dev->max_mtu to ETH_MAX_MTU.
From: Pablo Neira Ayuso
Date: Thu, 4 Apr 2019 13:56:38 +0200
> Simplify this code by updating bridge multicast stats from
> maybe_deliver().
>
> Note that commit 6db6f0eae605 ("bridge: multicast to unicast"), in case
> the port flag BR_MULTICAST_TO_UNICAST is set, never updates the previous
> p
From: David Ahern
Allow the gateway in a fib_nh_common to be from a different address
family than the outer fib{6}_nh. To that end, replace nhc_has_gw with
nhc_gw_family and update users of nhc_has_gw to check nhc_gw_family.
Now nhc_family is used to know if the nh_common is part of a fib_nh
or f
From: David Ahern
Last set of three with the end goal of enabling IPv6 gateways with IPv4
routes.
This set adds fib6_nh_init and release to the IPv6 stubs, and adds neighbor
helpers that IPv4 code invokes to resolve an IPv6 address. When using
an IPv6 neighbor entry the hh_cache is bypassed as i
From: David Ahern
fib_check_nh is currently huge covering multiple uses cases - device only,
device + gateway, and device + gateway with ONLINK. The next patch adds
validation checks for IPv6 which only further complicates it. So, break
fib_check_nh into 2 helpers - one for gateway validation and
From: David Ahern
Similar to rtable, fib_config needs to allow the gateway to be either an
IPv4 or an IPv6 address. To that end, rename fc_gw to fc_gw4 to mean an
IPv4 address and add fc_gw_family. Check on 'is a gateway set' are changed
to see if fc_gw_family is set. In the process prepare the c
From: Pablo Neira Ayuso
Date: Thu, 4 Apr 2019 13:54:20 +0200
> Just like 46cfd725c377 ("net: use kfree_skb_list() helper in more places").
>
> Signed-off-by: Pablo Neira Ayuso
> Acked-by: Florian Westphal
Applied.
From: David Ahern
Add ipv6 helpers to handle ndisc references via the stub. Update
bpf_ipv6_fib_lookup to use __ipv6_neigh_lookup_noref_stub instead of
the open code ___neigh_lookup_noref with the stub.
Signed-off-by: David Ahern
---
include/net/ndisc.h | 40 +++
From: David Ahern
Signed-off-by: David Ahern
---
include/net/ipv6_stubs.h | 6 ++
net/ipv6/addrconf_core.c | 9 +
net/ipv6/af_inet6.c | 2 ++
3 files changed, 17 insertions(+)
diff --git a/include/net/ipv6_stubs.h b/include/net/ipv6_stubs.h
index d8d9c0b0e8c0..453b55bf6723 100
From: David Ahern
Add support for an IPv6 gateway to rtable. Since a gateway is either
IPv4 or IPv6, make it a union with rt_gw4 where rt_gw_family decides
which address is in use.
When dumping the route data, encode an ipv6 nexthop using RTA_VIA.
Signed-off-by: David Ahern
---
.../net/ethern
From: David Ahern
Update bpf_ipv4_fib_lookup to handle an ipv6 gateway.
Signed-off-by: David Ahern
---
net/core/filter.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index eb07a02596c5..b706e9799dfe 100644
--- a/ne
From: David Ahern
A later patch allows an IPv6 gateway with an IPv4 route. The neighbor
entry will exist in the v6 ndisc table and the cached header will contain
the ipv6 protocol which is wrong for an IPv4 packet. For an IPv4 packet to
use the v6 neighbor entry, neigh_output needs to skip the ca
From: David Ahern
Add helper to validate nexthop spec with an IPv6 gateway.
Signed-off-by: David Ahern
---
net/ipv4/fib_semantics.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index b9f0388a2c70..acbdf0ed6
From: David Ahern
A common them in the output path is looking up a neigh entry for a
nexthop, either the gateway in an rtable or a fallback to the daddr
in the skb:
nexthop = (__force u32)rt_nexthop(rt, ip_hdr(skb)->daddr);
neigh = __ipv4_neigh_lookup_noref(dev, nexthop);
From: David Ahern
Update ipv4_confirm_neigh to handle an ipv6 gateway.
Signed-off-by: David Ahern
---
net/ipv4/route.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 32ecb4c1c7e3..efa6a36cbfff 100644
--- a/net/ipv4/route
From: David Ahern
Add tests for ipv6 gateway with ipv4 route. Tests include basic
single path with ping to verify connectivity and multipath.
Signed-off-by: David Ahern
---
tools/testing/selftests/net/fib_tests.sh | 70 +++-
1 file changed, 69 insertions(+), 1 delet
From: David Ahern
To allow the gateway to be either an IPv4 or IPv6 address, remove
rt_uses_gateway from rtable and replace with rt_gw_family. If
rt_gw_family is set it implies rt_uses_gateway. Rename rt_gateway
to rt_gw4 to represent the IPv4 version.
Signed-off-by: David Ahern
---
drivers/in
From: David Ahern
Update fib_good_nh to handle an ipv6 gateway.
Signed-off-by: David Ahern
---
net/ipv4/fib_semantics.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index f3f11f55e905..6b48a0b92eef 100644
---
From: David Ahern
Until support is added to the offload drivers, they need to be able to
reject routes with an IPv6 gateway. To that end add a flag to fib_info
that indicates if any fib_nh has a v6 gateway. The flag allows the drivers
to efficiently know the use of a v6 gateway without walking al
From: David Ahern
Update fib_detect_death to handle an ipv6 gateway.
Signed-off-by: David Ahern
---
net/ipv4/fib_semantics.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index acbdf0ed6ff8..f3f11f55e905 100644
From: David Ahern
Add support for RTA_VIA and allow an IPv6 nexthop for v4 routes:
$ ip ro add 172.16.1.0/24 via inet6 2001:db8::1 dev eth0
$ ip ro ls
...
172.16.1.0/24 via inet6 2001:db8::1 dev eth0
For convenience and simplicity, userspace can use RTA_VIA to specify
AF_INET or AF_I
From: Davide Caratti
Date: Thu, 4 Apr 2019 12:31:35 +0200
> the control path of 'sample' action does not validate the value of 'rate'
> provided by the user, but then it uses it as divisor in the traffic path.
> Validate it in tcf_sample_init(), and return -EINVAL with a proper extack
> message
On Thu, Apr 04, 2019 at 12:41:32AM +0200, Daniel Borkmann wrote:
> On 04/03/2019 07:30 PM, Alexei Starovoitov wrote:
> > On Wed, Apr 03, 2019 at 04:52:40PM +0100, Edward Cree wrote:
> >> On 02/04/2019 15:37, Daniel Borkmann wrote:
> >>> If we really want to have a kernel warn, then lets add a
> >>>
From: Lorenzo Bianconi
Date: Thu, 4 Apr 2019 12:16:27 +0200
> When a bpf program is uploaded, the driver computes the number of
> xdp tx queues resulting in the allocation of additional qsets.
> Starting from commit '2ecbe4f4a027 ("net: thunderx: replace global
> nicvf_rx_mode_wq work queue for
On Thu, Apr 04, 2019 at 10:02:21AM -0300, Jason Gunthorpe wrote:
> On Thu, Mar 28, 2019 at 03:27:30PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky
> >
> > >From Mark,
> >
> > Hi,
> >
> > This series starts from two refactoring patches performed in mlx5_core
> > and they are part of a la
From: Xin Long
Date: Thu, 4 Apr 2019 17:45:07 +0800
> We're thinking about adding some sctp tests into selftests,
> but these ones are not good to be the first one, I think.
> sysctl_sockets_memctl.sh is a multi-host test, even netns can't work for it.
You can't set per-netns memory controls app
On Thu, 4 Apr 2019 19:07:38 +0300
Eyal Birger wrote:
> The XFRMA_IF_ID attribute is set in policies/states for them to be
> associated with an XFRM interface (4.19+).
>
> Add support for setting / displaying this attribute.
>
> Note that 0 is a valid value therefore set XFRMA_IF_ID if any valu
Tested-by: Antony Antony
Question: is it easy to add "if_id" to "ip link show" output?
currently:
ip link show ipsec0
4: ipsec0@eth1: mtu 1500 qdisc noqueue state UNKNOWN mode
DEFAULT group default qlen 1000
link/none da:25:61:2e:0c:98 brd ff:ff:ff:ff:ff:ff
proposed:
4: ipsec0@eth1: mtu 1
The XFRMA_IF_ID attribute is set in policies/states for them to be
associated with an XFRM interface (4.19+).
Add support for setting / displaying this attribute.
Note that 0 is a valid value therefore set XFRMA_IF_ID if any value
was provided in command line.
Tested-by: Antony Antony
Signed-of
On Thu, 2019-04-04 at 11:00 +0200, Johannes Berg wrote:
> Hi,
>
> > Thanks a lot for doing this! Being responsible for most of the
> > issues
> > you point out, I can only say that you have my full support if you
> > want
> > to change any of it.
>
> :-)
>
> > My pathetic excuses below are just
On 4/4/19 6:16 AM, Stefano Brivio wrote:
>> diff --git a/tools/testing/selftests/net/pmtu.sh
>> b/tools/testing/selftests/net/pmtu.sh
>> index 912b2dc50be3..28e8c97b5c9e 100755
>> --- a/tools/testing/selftests/net/pmtu.sh
>> +++ b/tools/testing/selftests/net/pmtu.sh
>> @@ -116,6 +116,9 @@
>> # Ks
On 04/04/2019 12:17 AM, Daniel T. Lee wrote:
> Currently, ksym_search located at trace_helpers won't check symbols are
> existing or not.
>
> In ksym_search, when symbol is not found, it will return &syms[0](_stext).
> But when the kernel symbols are not loaded, it will return NULL, which is
> not
Hi David,
The following pull-request contains BPF updates for your *net* tree.
The main changes are:
1) Batch of fixes to the existing BPF flow dissector API to support
calling BPF programs from the eth_get_headlen context (support for
latter is planned to be added in bpf-next), from Stani
Hi Rafał,
On 19/04/04 (木) 21:57:15, Rafał Miłecki wrote:
Hello,
I'd like to report a regression that goes back to the 2015. I know it's
damn
late, but the good thing is, the regression is still easy to reproduce,
verify &
revert.
Long story short, starting with the commit 66e5133f19e9 ("vla
On 4/3/19 10:50 PM, David Miller wrote:
> From: David Ahern
> Date: Tue, 2 Apr 2019 14:11:53 -0700
>
>> From: David Ahern
>>
>> Second set of three with the end goal of enabling IPv6 gateways with IPv4
>> routes.
>>
>> This set moves:
>> - the ipv4 tracepoint to take a fib_nh_common and updates
On 4/3/19 11:09 PM, Martin Lau wrote:
> On Wed, Apr 03, 2019 at 08:43:38AM -0700, Peter Oskolkov wrote:
>> This patch adds tests validating that VRF and BPF-LWT
>> encap work together well, as requested by David Ahern.
> LGTM. David Ahern, please review also.
>
looked at it last night and hit so
On 4/3/19 11:09 PM, Martin Lau wrote:
> On Wed, Apr 03, 2019 at 08:43:38AM -0700, Peter Oskolkov wrote:
>> This patch adds tests validating that VRF and BPF-LWT
>> encap work together well, as requested by David Ahern.
> LGTM. David Ahern, please review also.
>
looking at it last night and hit s
ipip6 tunnels run iptunnel_pull_header on received skbs. This can
determine the following use-after-free accessing iph pointer since
the packet will be 'uncloned' running pskb_expand_head if it is a
cloned gso skb (e.g if the packet has been sent though a veth device)
[ 706.369655] BUG: KASAN: us
Hi,
We are not aware of this issue. Please collect the register dump i.e.,
"ethtool -d " output when this issue happens (before performing
link-flap) and share it for the analysis.
Thanks,
Sudarsana
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Ian Kumlien
Hi,
Unfortunately I have to report that the crashing has resurfaced. I'm
currently using kernel 5.0 with Heiner's fix applied. In the last few
days I've had the crash occur 4 times now. I'm not sure how to further
investigate this but I'm guessing a patch that adds more debugging
output will be ne
Interfaces take a 'if_id' which is an interface id which can be set on
an xfrm policy as its interface lookup key (XFRMA_IF_ID).
Signed-off-by: Matt Ellison
---
My apologies for taking so long to get v3 out:
v3 Changes:
* Only set IF_ID if set on command line.
ip/Makefile
On Thu, Apr 4, 2019 at 9:23 AM Paul Thomas wrote:
>
> > Could you please resend the patch addressing Dave's review comments
> > about subject line and Fixes tag?
> Yup, sorry about that. I'm not subscribed to netdev, but I thought
> replies would have me in the to:line, but I see the comments on t
On 04/03/2019 10:53 PM, Stanislav Fomichev wrote:
> Rename bpf_flow_dissector.txt to bpf_flow_dissector.rst and fix
> formatting. Also, link it from the Documentation/networking/index.rst.
>
> Tested with 'make htmldocs' to make sure it looks reasonable.
>
> Fixes: ae82899bbe92 ("flow_dissector:
> Could you please resend the patch addressing Dave's review comments
> about subject line and Fixes tag?
Yup, sorry about that. I'm not subscribed to netdev, but I thought
replies would have me in the to:line, but I see the comments on the
archive. I'll send this out shortly.
-Paul
Hi Paul,
On Thu, Apr 4, 2019 at 6:35 PM Paul Thomas wrote:
>
> On Tue, Mar 19, 2019 at 1:07 PM Paul Thomas wrote:
> >
> Hi All, just a reminder on this.
Could you please resend the patch addressing Dave's review comments
about subject line and Fixes tag?
Regards,
Harini
On Tue, Mar 19, 2019 at 1:07 PM Paul Thomas wrote:
>
> Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been
> enabled for this skb It does fix the issue where normal socks that
> aren't expecting a timestamp will not wake up on select. And when a
> user does want a SOF_TIMESTAMPI
On Thu, Mar 28, 2019 at 03:27:30PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> >From Mark,
>
> Hi,
>
> This series starts from two refactoring patches performed in mlx5_core
> and they are part of a larger series intended to expose the ability
> to insert FDB steering rules by the
Hello,
I'd like to report a regression that goes back to the 2015. I know it's damn
late, but the good thing is, the regression is still easy to reproduce, verify &
revert.
Long story short, starting with the commit 66e5133f19e9 ("vlan: Add GRO support
for non hardware accelerated vlan") - which
After adding a team interface to bridge, the team interface will enter
promisc mode. Then if we add a new slave to team0, the slave will keep
promisc off. Fix it by setting slave to promisc on if team master is
already in promisc mode, also do the same for allmulti.
Fixes: 3d249d4ca7d0 ("net: intr
Similarly to dad9b335c694 ("netdevice: Fix promiscuity and allmulti
overflow"), we should not decrease promiscuity if it is already 0.
An example is after adding a team interface to bridge, the team interface
will enter promisc mode. Then if we add a slave to team0, the slave will
keep promisc off
On Thu, Apr 4, 2019 at 12:16 PM Lorenzo Bianconi
wrote:
>
> When a bpf program is uploaded, the driver computes the number of
> xdp tx queues resulting in the allocation of additional qsets.
> Starting from commit '2ecbe4f4a027 ("net: thunderx: replace global
> nicvf_rx_mode_wq work queue for all
Hi David,
On Wed, 3 Apr 2019 18:18:24 -0700
David Ahern wrote:
> From: David Ahern
>
> pmtu.sh script runs a number of tests and dumps a summary of pass/fail.
> If a test fails, it is near impossible to debug why. For example:
>
> TEST: ipv6: PMTU exceptions [FAIL]
Just like 46cfd725c377 ("net: use kfree_skb_list() helper in more places").
Signed-off-by: Pablo Neira Ayuso
Acked-by: Florian Westphal
---
net/ipv4/ip_output.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
index c80188875
On 03-Apr-19 02:03, Saeed Mahameed wrote:
> From: Tariq Toukan
>
> Soften the memory barrier call of mb() by a sufficient wmb() in the
> consumer index update of the event queues.
>
> Signed-off-by: Tariq Toukan
> Signed-off-by: Saeed Mahameed
> ---
> drivers/net/ethernet/mellanox/mlx5/core/e
Hi Heiner,
Today i apply this patch, I test it on the RK3328 which has the phy,
it looks good, and link state switching between 10M/100M is correct.
在 2019/3/21 上午1:50, David Miller 写道:
From: Heiner Kallweit
Date: Tue, 19 Mar 2019 19:56:51 +0100
Currently the Phy driver's link_change_notify
On Wed, Apr 3, 2019 at 5:42 PM Vlad Buslov wrote:
>
>
> On Wed 03 Apr 2019 at 15:37, John Hurley wrote:
> > Recent refactoring of fl_change aims to use the classifier spinlock to
> > avoid the need for rtnl lock. In doing so, the fl_hw_replace_filer()
> > function was moved to before the lock is
On Thu, Apr 4, 2019 at 1:32 PM Davide Caratti wrote:
>
> the control path of 'sample' action does not validate the value of 'rate'
> provided by the user, but then it uses it as divisor in the traffic path.
> Validate it in tcf_sample_init(), and return -EINVAL with a proper extack
> message in ca
the control path of 'sample' action does not validate the value of 'rate'
provided by the user, but then it uses it as divisor in the traffic path.
Validate it in tcf_sample_init(), and return -EINVAL with a proper extack
message in case that value is zero, to fix a splat with the script below:
#
For a NETROM "ip link show dev nr0" will show
4: nr0: mtu 236 qdisc noqueue state UNKNOWN mode DEFAULT
group default qlen 1000
link/generic 88:98:6a:a4:84:40:0a brd 00:00:00:00:00:00:00
But rather link/netrom is expected to be displayed.
I have below patch to change ip such that link/netro
When a bpf program is uploaded, the driver computes the number of
xdp tx queues resulting in the allocation of additional qsets.
Starting from commit '2ecbe4f4a027 ("net: thunderx: replace global
nicvf_rx_mode_wq work queue for all VFs to private for each of them")'
the driver runs link state polli
1 - 100 of 106 matches
Mail list logo
