[PATCH] Documentation: devicetree: add a new optional property for port mac address

2019-03-10 Thread xiaofeis
Add documentation for a new optional property local-mac-address which is described in ethernet.txt. Signed-off-by: xiaofeis --- Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt b/Document

Re: Latitude 5495's tg3 hangs under heavy load

2019-03-10 Thread Kai-Heng Feng
[snipped] Hi again, Any update? Kai-Heng

Re: [PATCH v2] appletalk: Correctly check return value of register_snap_client

2019-03-10 Thread YueHaibing
Hi David, Is there something need do for this patch? Pls let me know. I saw the patchwork status labled to 'Not Applicable' https://patchwork.ozlabs.org/patch/1052624/ On 2019/3/7 10:22, Yue Haibing wrote: > From: YueHaibing > > register_snap_client may return NULL, all the callers > check

[PATCH bpf-next 0/2] Add fwd enum resolution for btf_dedup()

2019-03-10 Thread Andrii Nakryiko
This patchset adds ability to resolve forward-declared enums into their corresponding full enum definition types during type deduplication, eliminating one of the reasons for having duplicated graphs of types. Andrii Nakryiko (2): btf: resolve enum fwds in btf_dedup selftests/bpf: add fwd enum

[PATCH bpf-next 1/2] btf: resolve enum fwds in btf_dedup

2019-03-10 Thread Andrii Nakryiko
GCC and clang support enum forward declarations as an extension. Such forward-declared enums will be represented as normal BTF_KIND_ENUM types with vlen=0. This patch adds ability to resolve such enums to their corresponding fully defined enums. This helps to avoid duplicated BTF type graphs which

[PATCH bpf-next 2/2] selftests/bpf: add fwd enum resolution test for btf_dedup

2019-03-10 Thread Andrii Nakryiko
This patch adds test verifying new btf_dedup logic of resolving forward-declared enums. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/test_btf.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/tools/testing/selftests/bpf/test_btf.c b/tools/testin

Re: [PULL] virtio,vhost: cleanups and fixes

2019-03-10 Thread pr-tracker-bot
The pull request you sent on Sat, 9 Mar 2019 22:44:35 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/45ba8d5d061b13494c2a7a7652d51b9da3d9e77a Thank you! -- Deet-doot-dot, I am a bot.

Re: r8169 driver from kernel 5.0 crashing

2019-03-10 Thread Heiner Kallweit
On 10.03.2019 20:02, VDR User wrote: > Hi, after updating to kernel 5.0, the nic driver (r8169) has been > crashing whenever I start using heavy traffic on it (for example, > xferring large files to the box across my lan). The destination > harddrive may be sleeping and need to spin-up, or not, but

r8169 driver from kernel 5.0 crashing

2019-03-10 Thread VDR User
Hi, after updating to kernel 5.0, the nic driver (r8169) has been crashing whenever I start using heavy traffic on it (for example, xferring large files to the box across my lan). The destination harddrive may be sleeping and need to spin-up, or not, but the box itself does not suspend/hibernate. T

Re: r8169 only works in promisc mode

2019-03-10 Thread Stephen Hemminger
On Sun, 10 Mar 2019 15:26:16 +0100 Heiner Kallweit wrote: > On 10.03.2019 15:18, Stephen Hemminger wrote: > > On Sat, 9 Mar 2019 10:33:40 +0100 > > Heiner Kallweit wrote: > > > >> On 09.03.2019 03:16, Alex Xu (Hello71) wrote: > >>> After suspending, my r8169 (not actually 8169, just that dr

[GIT] Networking

2019-03-10 Thread David Miller
First batch of fixes in the new merge window: 1) Double dst_cache free in act_tunnel_key, from Wenxu. 2) Avoid NULL deref in IN_DEV_MFORWARD() by failing early in the ip_route_input_rcu() path, from Paolo Abeni. 3) Fix appletalk compile regression, from Arnd Bergmann. 4) If SLAB objects re

Re: [PATCH] net/ipv6: Skip policy check to improve compliance

2019-03-10 Thread David Miller
From: Andrew Boyer Date: Fri, 8 Mar 2019 14:01:11 -0500 > From: Farrell Woods > > The patch fixes an IPv6 conformance test failure (v6LC_1_2_03a in the > UNH INTACT suite) that occurs specifically when IPsec is in use. The > test iterates through the set of unassigned protocol numbers (curren

Re: [PATCH] staging: e1000: e1000_main.c: remove extern declarations in .c file.

2019-03-10 Thread Quentin Deslandes
On Sun, Mar 10, 2019 at 11:03:09AM -0700, David Miller wrote: > > "staging"? "staging" was an error, someone explained me after I sent the patch, sorry for the inconvenience.

Re: [PATCH net] gro_cells: make sure device is up in gro_cells_receive()

2019-03-10 Thread David Miller
From: Eric Dumazet Date: Sun, 10 Mar 2019 10:39:37 -0700 > We keep receiving syzbot reports [1] that show that tunnels do not play > the rcu/IFF_UP rules properly. > > At device dismantle phase, gro_cells_destroy() will be called > only after a full rcu grace period is observed after IFF_UP > ha

Re: [PATCH net] vxlan: test dev->flags & IFF_UP before calling gro_cells_receive()

2019-03-10 Thread David Miller
From: Eric Dumazet Date: Sun, 10 Mar 2019 10:36:40 -0700 > Same reasons than the ones explained in commit 4179cb5a4c92 > ("vxlan: test dev->flags & IFF_UP before calling netif_rx()") > > netif_rx() or gro_cells_receive() must be called under a strict contract. > > At device dismantle phase, cor

Re: [PATCH net] net/x25: fix use-after-free in x25_device_event()

2019-03-10 Thread David Miller
From: Eric Dumazet Date: Sun, 10 Mar 2019 09:07:14 -0700 > In case of failure x25_connect() does a x25_neigh_put(x25->neighbour) > but forgets to clear x25->neighbour pointer, thus triggering use-after-free. > > Since the socket is visible in x25_list, we need to hold x25_list_lock > to protect

Re: [PATCH] staging: e1000: e1000_main.c: remove extern declarations in .c file.

2019-03-10 Thread David Miller
"staging"?

Re: [PATCH] net: liquidio: fix a NULL pointer dereference

2019-03-10 Thread David Miller
From: Kangjie Lu Date: Sun, 10 Mar 2019 03:19:15 -0500 > + netif_info(lio, rx_err, lio->netdev, > + "Failed to allocate octeon_soft_command\n"); When a function call straddles mutliple lines, the second and subsequent lines containing argument must start p

Re: [PATCH] net: 8390: fix potential NULL pointer dereferences

2019-03-10 Thread David Miller
From: Kangjie Lu Date: Sun, 10 Mar 2019 03:14:53 -0500 > In case ioremap fails, the fix returns to avoid NULL pointer > dereferences. > > Signed-off-by: Kangjie Lu > --- > drivers/net/ethernet/8390/pcnet_cs.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/etherne

Re: [PATCH] net: lan9303: fix missing error handling

2019-03-10 Thread David Miller
From: Kangjie Lu Date: Sun, 10 Mar 2019 03:08:56 -0500 > Both lan9303_phy_write and regmap_write may fail. The fix adds > the error handling to print error messages upon failure. > > Signed-off-by: Kangjie Lu It's ignored elsewhere in this driver in places you haven't handled. I doubt this is

Re: [PATCH] isdn: mISDNinfineon: fix potential NULL pointer dereference

2019-03-10 Thread David Miller
From: Kangjie Lu Date: Fri, 8 Mar 2019 23:49:34 -0600 > In case ioremap fails, the fix returns -ENOMEM to avoid NULL > pointer dereference. > > Signed-off-by: Kangjie Lu Applied.

Re: [PATCH] isdn: hfcpci: fix potential NULL pointer dereference

2019-03-10 Thread David Miller
From: Kangjie Lu Date: Fri, 8 Mar 2019 23:46:04 -0600 > In case ioremap fails, the fix reports an error and returns. > > Signed-off-by: Kangjie Lu First, you shouldn't print the information log message if this fails. Second you are leaking hc->hw.fifos, you have to clean up any resources all

[PATCH net] gro_cells: make sure device is up in gro_cells_receive()

2019-03-10 Thread Eric Dumazet
We keep receiving syzbot reports [1] that show that tunnels do not play the rcu/IFF_UP rules properly. At device dismantle phase, gro_cells_destroy() will be called only after a full rcu grace period is observed after IFF_UP has been cleared. This means that IFF_UP needs to be tested before queue

[PATCH net] vxlan: test dev->flags & IFF_UP before calling gro_cells_receive()

2019-03-10 Thread Eric Dumazet
Same reasons than the ones explained in commit 4179cb5a4c92 ("vxlan: test dev->flags & IFF_UP before calling netif_rx()") netif_rx() or gro_cells_receive() must be called under a strict contract. At device dismantle phase, core networking clears IFF_UP and flush_all_backlogs() is called after rcu

Re: [PATCH] net: can: Increase tx queue length

2019-03-10 Thread Oliver Hartkopp
Hi all, On 3/10/19 6:07 AM, Dave Taht wrote: Toke Høiland-Jørgensen writes: Appana Durga Kedareswara Rao writes: Hi Andre, On 3/9/19 3:07 PM, Appana Durga Kedareswara rao wrote: While stress testing the CAN interface on xilinx axi can in loopback mode getting message "write: no buffer

Re: PROBLEM: kernel build fails with CONFIG_BPFILTER_UMH=y

2019-03-10 Thread Randy Dunlap
[add other mailing lists] On 3/10/19 9:47 AM, rwar...@gmx.de wrote: > hallo > > care to look into this: > > https://bugzilla.kernel.org/show_bug.cgi?id=202681 > > -- ~Randy

[PATCH net] net/x25: fix use-after-free in x25_device_event()

2019-03-10 Thread Eric Dumazet
In case of failure x25_connect() does a x25_neigh_put(x25->neighbour) but forgets to clear x25->neighbour pointer, thus triggering use-after-free. Since the socket is visible in x25_list, we need to hold x25_list_lock to protect the operation. syzbot report : BUG: KASAN: use-after-free in x25_ki

Re: KASAN: use-after-free Read in x25_device_event

2019-03-10 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:d9862cfb Merge tag 'mips_5.1' of git://git.kernel.org/pub/.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1531cf2320 kernel config: https://syzkaller.appspot.com/x/.config?x=73d88a

Re: r8169 only works in promisc mode

2019-03-10 Thread Heiner Kallweit
On 10.03.2019 15:18, Stephen Hemminger wrote: > On Sat, 9 Mar 2019 10:33:40 +0100 > Heiner Kallweit wrote: > >> On 09.03.2019 03:16, Alex Xu (Hello71) wrote: >>> After suspending, my r8169 (not actually 8169, just that driver) only >>> receives packets when in promiscuous mode. I have tried disa

Re: r8169 only works in promisc mode

2019-03-10 Thread Stephen Hemminger
On Sat, 9 Mar 2019 10:33:40 +0100 Heiner Kallweit wrote: > On 09.03.2019 03:16, Alex Xu (Hello71) wrote: > > After suspending, my r8169 (not actually 8169, just that driver) only > > receives packets when in promiscuous mode. I have tried disabling all > > offload features except highdma [fixed

Re: [PATCH] net: can: Increase tx queue length

2019-03-10 Thread Martin Jerabek
On 09. 03. 19 15:40, Appana Durga Kedareswara Rao wrote: > Hi Andre, > > >> >> On 3/9/19 3:07 PM, Appana Durga Kedareswara rao wrote: >>> While stress testing the CAN interface on xilinx axi can in loopback >>> mode getting message "write: no buffer space available" >>> Increasing device tx queu

[PATCH] staging: e1000: e1000_main.c: remove extern declarations in .c file.

2019-03-10 Thread Quentin Deslandes
This patch fixes the checkpatch.pl warning: WARNING: externs should be avoided in .c files Some of the driver's function declared in e1000.h were declared a second time in e1000_main.c, triggering checkpatch.pl warnings. Signed-off-by: Quentin Deslandes --- drivers/net/ethernet/intel/e1000/e10

[PATCH] net: liquidio: fix a NULL pointer dereference

2019-03-10 Thread Kangjie Lu
In case octeon_alloc_soft_command fails, the fix reports the error and returns to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c

[PATCH] net: 8390: fix potential NULL pointer dereferences

2019-03-10 Thread Kangjie Lu
In case ioremap fails, the fix returns to avoid NULL pointer dereferences. Signed-off-by: Kangjie Lu --- drivers/net/ethernet/8390/pcnet_cs.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/8390/pcnet_cs.c b/drivers/net/ethernet/8390/pcnet_cs.c index 61e43802b9a

[PATCH] net: lan9303: fix missing error handling

2019-03-10 Thread Kangjie Lu
Both lan9303_phy_write and regmap_write may fail. The fix adds the error handling to print error messages upon failure. Signed-off-by: Kangjie Lu --- drivers/net/dsa/lan9303-core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-