Re: [patch net-next RFC 5/8] mlxsw: Remove ndo_get_port_parent_id implementation

2019-03-01 Thread Jiri Pirko
Sat, Mar 02, 2019 at 03:57:07AM CET, f.faine...@gmail.com wrote: > > >On 3/1/2019 8:05 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Remove implementation of get_port_parent_id ndo and rely on core calling >> into devlink for the information directly. >> >> Signed-off-by: Jiri Pirko > >Don't

Re: [patch net-next RFC 2/8] net: devlink: extend port attrs for switch ID

2019-03-01 Thread Jiri Pirko
Sat, Mar 02, 2019 at 03:53:47AM CET, f.faine...@gmail.com wrote: > > >On 3/1/2019 8:05 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Extend devlink_port_attrs_set() to pass switch ID for ports which are >> part of switch and store it in port attrs. For other ports, this is >> NULL. During dump

Re: [PATCH net-next v2 00/15] net: mvpp2: fixes and improvements

2019-03-01 Thread David Miller
From: Antoine Tenart Date: Fri, 1 Mar 2019 11:52:02 +0100 > This series aims to improve the Marvell PPv2 driver and to fix various > issues we encountered while testing the ports in many different > configurations. The series is based on top of Russell PPv2 phylink > rework and improvement. ...

Re: [PATCH net-next] cxgb4vf: Call netif_carrier_off properly in pci_probe

2019-03-01 Thread David Miller
From: Arjun Vynipadath Date: Fri, 1 Mar 2019 16:07:01 +0530 > netif_carrier_off() should be called only after register_netdev(). > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Vishal Kulkarni Applied.

Re: [PATCH net-next v2 0/2]cxgb4/cxgb4vf: VF link state support

2019-03-01 Thread David Miller
From: Arjun Vynipadath Date: Fri, 1 Mar 2019 15:44:46 +0530 > This series of patches adds support for ndo_set_vf_link_state in > cxgb4 driver. > > Patch 1 implements ndo_set_vf_link_state > Patch 2 reverts the existing force_link_up behaviour for cxgb4vf driver. > > v2: > - Using reverse chris

Re: [PATCH net-next] cxgb4vf: Prefix adapter flags with CXGB4VF

2019-03-01 Thread David Miller
From: Arjun Vynipadath Date: Fri, 1 Mar 2019 15:42:39 +0530 > Some of these macros were conflicting with global namespace, > hence prefixing them with CXGB4VF. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Vishal Kulkarni Applied.

Re: [PATCH net-next] cxgb4: Prefix adapter flags with CXGB4

2019-03-01 Thread David Miller
From: Arjun Vynipadath Date: Fri, 1 Mar 2019 15:40:24 +0530 > - FULL_INIT_DONE = (1 << 0), ... > + CXGB4_FULL_INIT_DONE= (1 << 0), Looks like you missed some of this conversion. Oh wait, you make changes to cxgb* and don't enable all the related drivers that use these

Re: [PATCH net-next 0/2] net: 64bit support for SO_MAX_PACING_RATE

2019-03-01 Thread David Miller
From: Eric Dumazet Date: Thu, 28 Feb 2019 15:17:26 -0800 > 64bit kernels adopted 64bit type for sk_max_pacing_rate in linux-4.20 > > We can change how we implement SO_MAX_PACING_RATE socket option > to support 64bit values to/from user space as well. Series applied, thanks Eric.

Re: [PATCH net-next] tc-testing: Allow test cases to be skipped

2019-03-01 Thread David Miller
From: Lucas Bates Date: Thu, 28 Feb 2019 17:38:40 -0500 > By adding a check for an optional key/value pair to the test case > data, individual test cases may be skipped to prevent tdc from > aborting a test run due to setup or teardown failure. > > If a test case is skipped, it will still appear

Re: [PATCH] net: e1000e: add MAC address kernel cmd line parameter

2019-03-01 Thread David Miller
From: Flavio Suligoi Date: Thu, 28 Feb 2019 10:20:35 +0100 > Sometimes, in some embedded systems boards (i.e. ARM boards), > the NVM eeprom is not mounted, to save cost and space. > > In this case it is necessary to bypass the NVM management > and directly force the MAC address using a kernel co

Re: [PATCH net] net: sched: put back q.qlen into a single location

2019-03-01 Thread David Miller
From: Eric Dumazet Date: Thu, 28 Feb 2019 12:55:43 -0800 > In the series fc8b81a5981f ("Merge branch 'lockless-qdisc-series'") > John made the assumption that the data path had no need to read > the qdisc qlen (number of packets in the qdisc). > > It is true when pfifo_fast is used as the root q

WARNING in lockdep_register_key

2019-03-01 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:c63e9e91a254 Add linux-next specific files for 20190301 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=160f18ecc0 kernel config: https://syzkaller.appspot.com/x/.config?x=f5875f9dc6e009b2

BUG: spinlock bad magic in flush_workqueue_prep_pwqs

2019-03-01 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7d762d69145a afs: Fix manually set volume location server .. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13044284c0 kernel config: https://syzkaller.appspot.com/x/.config?x=b76ec970784287c das

Re: [PATCH net] geneve: correctly handle ipv6.disable module parameter

2019-03-01 Thread David Miller
From: Jiri Benc Date: Thu, 28 Feb 2019 14:56:04 +0100 > When IPv6 is compiled but disabled at runtime, geneve_sock_add returns > -EAFNOSUPPORT. For metadata based tunnels, this causes failure of the whole > operation of bringing up the tunnel. > > Ignore failure of IPv6 socket creation for metad

Re: [PATCH v1 1/7] enc28j60: Use device_get_mac_address()

2019-03-01 Thread Joe Perches
On Fri, 2019-03-01 at 21:46 -0800, David Miller wrote: > From: Andy Shevchenko > Date: Thu, 28 Feb 2019 23:34:29 +0300 > > > @@ -1554,7 +1554,7 @@ static int enc28j60_probe(struct spi_device *spi) > > { > > struct net_device *dev; > > struct enc28j60_net *priv; > > - const void *

Re: pull-request: bpf 2019-03-01

2019-03-01 Thread David Miller
From: Alexei Starovoitov Date: Fri, 1 Mar 2019 21:35:38 -0800 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) fix sanitation rewrite, from Daniel. > > 2) fix error path on map_new_fd, from Peng. > > 3) fix icache flush address, from Paul

Re: [PATCH v1 1/7] enc28j60: Use device_get_mac_address()

2019-03-01 Thread David Miller
From: Andy Shevchenko Date: Thu, 28 Feb 2019 23:34:29 +0300 > @@ -1554,7 +1554,7 @@ static int enc28j60_probe(struct spi_device *spi) > { > struct net_device *dev; > struct enc28j60_net *priv; > - const void *macaddr; > + unsigned char macaddr[ETH_ALEN]; > int ret = 0;

Re: [PATCH net-next 00/14] mlxsw: spectrum_acl: Split rehash work into chunks

2019-03-01 Thread David Miller
From: Ido Schimmel Date: Thu, 28 Feb 2019 06:59:15 + > Jiri says: > > When rehash happens on a vregion with many rules and they are being > migrated, it might take significant time to finish the job. During that > time vregion->lock is taken which prevents rules from being > added/deleted fr

Re: [PATCH v2 net] net: dsa: mv88e6xxx: prevent interrupt storm caused by mv88e6390x_port_set_cmode

2019-03-01 Thread David Miller
From: Heiner Kallweit Date: Thu, 28 Feb 2019 07:39:15 +0100 > When debugging another issue I faced an interrupt storm in this > driver (88E6390, port 9 in SGMII mode), consisting of alternating > link-up / link-down interrupts. Analysis showed that the driver > wanted to set a cmode that was set

Re: [PATCH net-next] switchdev: Remove unused transaction item queue

2019-03-01 Thread David Miller
From: Florian Fainelli Date: Wed, 27 Feb 2019 16:29:16 -0800 > There are no more in tree users of the > switchdev_trans_item_{dequeue,enqueue} or switchdev_trans_item structure > in the kernel since commit 00fc0c51e35b ("rocker: Change world_ops API > and implementation to be switchdev independan

pull-request: bpf 2019-03-01

2019-03-01 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) fix sanitation rewrite, from Daniel. 2) fix error path on map_new_fd, from Peng. 3) fix icache flush address, from Paul. Please consider pulling these changes from: git://git.kernel.org/

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Alexei Starovoitov
On Fri, Mar 01, 2019 at 10:05:29PM +0100, Daniel Borkmann wrote: > Marek reported that he saw an issue with the below snippet in that > timing measurements where off when loaded as unpriv while results > were reasonable when loaded as privileged: > > [...] > uint64_t a = bpf_ktime_get_ns()

Re: Realtek r8822be kernel module does not negotiate 802.11ac connection

2019-03-01 Thread David R. Bergstein
Larry, Sorry about all these extra replies.  Shortly after I sent my last message my access point started recognizing the connection as 802.11ac with PHY Rate / Modulation Rate of 866.6 Mbps.  What is somewhat misleading is the information reported by iwconfig (see bit rate below). $ iwconfig wlo

[PATCH bpf-next v3 5/7] selftests: bpf: break up test_progs - tracepoint

2019-03-01 Thread Stanislav Fomichev
Move tracepoint prog tests into separate files. Signed-off-by: Stanislav Fomichev --- .../bpf/prog_tests/get_stack_raw_tp.c | 139 ++ .../bpf/prog_tests/task_fd_query_rawtp.c | 78 .../bpf/prog_tests/task_fd_query_tp.c | 82 .../bpf/prog_tests/tp_attach_query

[PATCH bpf-next v3 6/7] selftests: bpf: break up test_progs - spinlock

2019-03-01 Thread Stanislav Fomichev
Move spinlock prog tests into separate files. Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/map_lock.c | 75 + .../selftests/bpf/prog_tests/spinlock.c | 29 + tools/testing/selftests/bpf/test_progs.c | 104 +- tools/testing/

[PATCH bpf-next v3 2/7] selftests: bpf: break up test_progs - pkt access

2019-03-01 Thread Stanislav Fomichev
Move pkt access prog tests into separate files. Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/pkt_access.c | 29 +++ .../selftests/bpf/prog_tests/pkt_md_access.c | 24 + tools/testing/selftests/bpf/test_progs.c | 51 --- 3 files chan

[PATCH bpf-next v3 7/7] selftests: bpf: break up test_progs - misc

2019-03-01 Thread Stanislav Fomichev
Move the rest of prog tests into separate files. Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/bpf_obj_id.c | 249 ++ .../selftests/bpf/prog_tests/flow_dissector.c | 72 ++ .../selftests/bpf/prog_tests/l4lb_all.c | 90 +++ .../selftests/bpf/prog_tests/obj_nam

[PATCH bpf-next v3 1/7] selftests: bpf: break up test_progs - preparations

2019-03-01 Thread Stanislav Fomichev
Add new prog_tests directory where tests are supposed to land. Each prog_tests/.c is expected to have a global function with signature 'void test_(void)'. Makefile automatically generates prog_tests/tests.h file with entry for each prog_tests file: #ifdef DECLARE extern void test_(

[PATCH bpf-next v3 4/7] selftests: bpf: break up test_progs - stackmap

2019-03-01 Thread Stanislav Fomichev
Move stackmap prog tests into separate files. Signed-off-by: Stanislav Fomichev --- .../bpf/prog_tests/stacktrace_build_id.c | 165 ++ .../bpf/prog_tests/stacktrace_build_id_nmi.c | 150 ++ .../selftests/bpf/prog_tests/stacktrace_map.c | 103 .../bpf/prog_tests/stacktrace_map_

[PATCH bpf-next v3 3/7] selftests: bpf: break up test_progs - xdp

2019-03-01 Thread Stanislav Fomichev
Move xdp prog tests into separate files. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/prog_tests/xdp.c | 46 + .../bpf/prog_tests/xdp_adjust_tail.c | 31 .../selftests/bpf/prog_tests/xdp_noinline.c | 82 + tools/testing/selftests/bpf/test_prog

[PATCH bpf-next v3 0/7] selftests: bpf: break up test_progs

2019-03-01 Thread Stanislav Fomichev
Recently we had linux-next bpf/bpf-next conflict when we added new functionality to the test_progs.c at the same location. Let's split test_progs.c the same way we recently split test_verifier.c. I follow the same patten we did in commit 2dfb40121ee8 ("selftests: bpf: prepare for break up of verif

Re: [PATCH bpf-next v2 0/7] selftests: bpf: break up test_progs

2019-03-01 Thread Stanislav Fomichev
On Fri, Mar 1, 2019 at 7:40 PM Stanislav Fomichev wrote: > > Recently we had linux-next bpf/bpf-next conflict when we added new > functionality to the test_progs.c at the same location. Let's split > test_progs.c the same way we recently split test_verifier.c. > > I follow the same patten we did i

[PATCH bpf-next v2 0/7] selftests: bpf: break up test_progs

2019-03-01 Thread Stanislav Fomichev
Recently we had linux-next bpf/bpf-next conflict when we added new functionality to the test_progs.c at the same location. Let's split test_progs.c the same way we recently split test_verifier.c. I follow the same patten we did in commit 2dfb40121ee8 ("selftests: bpf: prepare for break up of verif

Re: [PATCH net-next 4/6] ethernet: eth: add default vid len for all ehternet kind devices

2019-03-01 Thread Florian Fainelli
On 3/1/2019 5:11 AM, Ivan Khoronzhuk wrote: > On Wed, Feb 27, 2019 at 08:29:20PM -0800, Florian Fainelli wrote: >> >> >> On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote: >>> IVDF - individual virtual device filtering. Allows to set per vlan >>> l2 address filters on end real network device (for uni

Re: [PATCH net-next 3/6] net: 8021q: vlan_dev: add vid tag for vlan device own address

2019-03-01 Thread Florian Fainelli
On 3/1/2019 4:28 AM, Ivan Khoronzhuk wrote: > On Wed, Feb 27, 2019 at 08:13:34PM -0800, Florian Fainelli wrote: >> >> >> On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote: >>> The vlan device address is held separately from uc/mc lists and >>> handled differently. The vlan dev address is bound with r

Re: [PATCH net-next 2/6] net: 8021q: vlan_dev: add vid tag to addresses of uc and mc lists

2019-03-01 Thread Florian Fainelli
On 3/1/2019 4:24 AM, Ivan Khoronzhuk wrote: > On Wed, Feb 27, 2019 at 08:09:44PM -0800, Florian Fainelli wrote: >> >> >> On 2/26/2019 10:45 AM, Ivan Khoronzhuk wrote: >>> Update vlan mc and uc addresses with VID tag while propagating >>> addresses to lower devices, do this only if address is not

Re: Realtek r8822be kernel module does not negotiate 802.11ac connection

2019-03-01 Thread David R. Bergstein
Larry, Please disregard my last message.  The firmware is now installed and the rtw88 module is working with my wireless router.  The next hurdle appears to be setting the speed to 802.11ac as it is currently connecting as an 802.11n client. Sincerely, David R. Bergstein On 3/1/19 9:55 PM, Davi

Re: [PATCH net 1/2] net: phy: Use C45 Helpers in phy_read_status()

2019-03-01 Thread Florian Fainelli
On 3/1/2019 2:54 AM, Jose Abreu wrote: > Currently phy_read_status() considers that either the PHY driver has the > read_status() callback or uses the generic callback. > > For C45 PHYs we need to use the gen10g_read_status() callback. Right, so we could expect your C45 PHY driver to assign th

Re: [PATCH net-next v2 3/3] net: phy: marvell10g: set the PHY in low power by default

2019-03-01 Thread Florian Fainelli
On 3/1/2019 7:07 AM, Antoine Tenart wrote: > Hi Andrew, > > On Fri, Mar 01, 2019 at 03:19:53PM +0100, Andrew Lunn wrote: >> On Fri, Mar 01, 2019 at 12:00:47PM +0100, Antoine Tenart wrote: >>> When the Marvell 10G PHYs are set out of reset, the LPOWER bit is set >>> depending on an hardware conf

Re: [patch net-next RFC 8/8] nfp: remove ndo_get_port_parent_id implementation

2019-03-01 Thread Florian Fainelli
On 3/1/2019 8:05 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Remove implementation of get_port_parent_id ndo and rely on core calling > into devlink for the information directly. Likewise, this probably needs a depends/select DEVLINK now to make sure the offload_fwd_mark is correctly calcula

Re: [patch net-next RFC 0/8] net: expose switch ID via devlink

2019-03-01 Thread Florian Fainelli
On 3/1/2019 8:05 AM, Jiri Pirko wrote: > From: Jiri Pirko > > To provide visibility of the ports, as discussed this week, this > patchset exposes switch ID for devlink ports, which are part of a > switch. The rest of the ports if any (in case of sr-iov for example) > do not set switch ID. > >

Re: [patch net-next RFC 5/8] mlxsw: Remove ndo_get_port_parent_id implementation

2019-03-01 Thread Florian Fainelli
On 3/1/2019 8:05 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Remove implementation of get_port_parent_id ndo and rely on core calling > into devlink for the information directly. > > Signed-off-by: Jiri Pirko Don't you need a select/depends on DEVLINK for MLXSW_SWITCHX2 and MLXSW_SPECTRUM

Re: Realtek r8822be kernel module does not negotiate 802.11ac connection

2019-03-01 Thread David R. Bergstein
Larry, Following up to your last reply, I blacklisted the r8822be module, rebooted and was unable to bring up the wireless interface via rtw88.  Below are some errors recorded in my system log:   [  267.509818] rtw_pci :3d:00.0: Direct firmware load for rtw88/rtw8822b_fw.bin failed with error

Re: [patch net-next RFC 2/8] net: devlink: extend port attrs for switch ID

2019-03-01 Thread Florian Fainelli
On 3/1/2019 8:05 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Extend devlink_port_attrs_set() to pass switch ID for ports which are > part of switch and store it in port attrs. For other ports, this is > NULL. During dump to userspace only valid switch ID is filled up. > Note that this allows

Re: [patch net-next RFC 1/8] net: devlink: convert devlink_port_attrs bools to bits

2019-03-01 Thread Florian Fainelli
On 3/1/2019 8:05 AM, Jiri Pirko wrote: > From: Jiri Pirko > > In order to save space in the struct, convert bools to bits. > > Signed-off-by: Jiri Pirko Reviewed-by: Florian Fainelli -- Florian

[PATCH] net-sysfs: Fix mem leak in netdev_register_kobject

2019-03-01 Thread Yue Haibing
From: YueHaibing syzkaller report this: BUG: memory leak unreferenced object 0x88837a71a500 (size 256): comm "syz-executor.2", pid 9770, jiffies 4297825125 (age 17.843s) hex dump (first 32 bytes): 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .N.. ff ff ff ff ff ff

Re: [PATCH bpf-next] bpf: fix memory leak in bpf_lwt_xmit_reroute

2019-03-01 Thread David Ahern
On 2/28/19 10:57 AM, Peter Oskolkov wrote: > David: I'm not sure how to test GSO (I assume we are talking about GSO > here) in > the selftest: the encapping code sets SKB_GSO_DODGY flag, and veth does > not support > dodginess: "tx-gso-robust: off [fixed]". > > If the "dodgy" flag is not set, then

Re: [patch net-next 1/5] net: replace ndo_get_devlink for ndo_get_devlink_port

2019-03-01 Thread Florian Fainelli
On 3/1/2019 12:13 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Follow-up patch is going to need a devlink port instance according to > a netdev. Devlink port instance should be always available when devlink > is used. So change the recently introduced ndo_get_devlink to > ndo_get_devlink_port.

Re: [PATCH net-next v3 2/3] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-03-01 Thread Jakub Kicinski
On Fri, 01 Mar 2019 15:12:30 +0100, Toke Høiland-Jørgensen wrote: > An XDP program can redirect packets between interfaces using either the > xdp_redirect() helper or the xdp_redirect_map() helper. Apart from the > flexibility of updating maps from userspace, the redirect_map() helper also > uses t

Re: Realtek r8822be kernel module does not negotiate 802.11ac connection

2019-03-01 Thread Larry Finger
On 3/1/19 4:26 PM, David R. Bergstein wrote: Larry, Thanks for the response and detailed instructions, which allowed me to build and install the rtw88 kernel module.  I cannot however seem to get my system to actually use the module.  Just to recap this is an HP Omen laptop with secure boot disa

Re: [PATCH net-next] net: sched: set dedicated tcf_walker flag when tp is empty

2019-03-01 Thread Cong Wang
On Thu, Feb 28, 2019 at 7:49 AM Vlad Buslov wrote: > > However, if we revert NULL fixes dump will print general tp information > for same tp twice (once correctly before dumping all filters on the tp, and > second time when called for bogus NULL filter), like this: > > filter protocol ip pref 1 fl

Re: [PATCH v2 bpf-next 1/3] bpf: add bpf_progenyof helper

2019-03-01 Thread Javier Honduvilla Coto
On Sat, Mar 02, 2019 at 12:12:57AM +, Martin Lau wrote: > On Fri, Mar 01, 2019 at 10:06:12AM -0800, Javier Honduvilla Coto wrote: > > From: Javier Honduvilla Coto > > > > This patch adds the bpf_progenyof helper which receives a PID and returns > > 1 if the process currently being executed is

Re: [PATCH net-next v3 1/3] xdp: Refactor devmap code in preparation for subsequent additions

2019-03-01 Thread Jakub Kicinski
On Fri, 01 Mar 2019 15:12:30 +0100, Toke Høiland-Jørgensen wrote: > The subsequent commits introducing default maps and a hash-based ifindex > devmap require a bit of refactoring of the devmap code. Perform this first > so the subsequent commits become easier to read. > > Signed-off-by: Toke Høila

Re: [PATCH bpf-next 1/3] bpf: add bpf_progenyof helper

2019-03-01 Thread Javier Honduvilla Coto
On Sat, Mar 02, 2019 at 12:01:14AM +, Martin Lau wrote: > On Fri, Mar 01, 2019 at 09:28:39AM -0800, Javier Honduvilla Coto wrote: > > On Wed, Feb 27, 2019 at 06:26:41AM +, Martin Lau wrote: > > > On Tue, Feb 26, 2019 at 02:36:49PM -0800, Javier Honduvilla Coto wrote: > > > > This patch adds

Re: [PATCH 0/2] doc: net: ieee802154: move from plain text to rst

2019-03-01 Thread David Miller
From: Stefan Schmidt Date: Wed, 27 Feb 2019 20:59:12 +0100 > The ieee802154 subsystem doc was still in plain text. With the networking book > taking shape I thought it was time to do the first step and move it over to > rst. > This really is only the minimal conversion. I need to take some time

Re: [PATCH 0/2] doc: net: ieee802154: move from plain text to rst

2019-03-01 Thread David Miller
From: Stefan Schmidt Date: Wed, 27 Feb 2019 22:20:58 +0100 > Hello Jon. > > On 27.02.19 21:18, Jonathan Corbet wrote: >> On Wed, 27 Feb 2019 20:59:12 +0100 >> Stefan Schmidt wrote: >> >>> The patches are based on net-next, but they only touch the networking book >>> so I >>> would not expect

Re: [PATCH net-next RESEND] devlink: fix kdoc

2019-03-01 Thread David Miller
From: Jakub Kicinski Date: Wed, 27 Feb 2019 11:36:36 -0800 > devlink suffers from a few kdoc warnings: > > net/core/devlink.c:5292: warning: Function parameter or member 'dev' not > described in 'devlink_register' > net/core/devlink.c:5351: warning: Function parameter or member 'port_index' >

Re: [PATCH bpf-next v2 0/7] selftests: bpf: break up test_progs

2019-03-01 Thread Stanislav Fomichev
On Fri, Mar 1, 2019 at 4:00 PM Daniel Borkmann wrote: > > On 03/01/2019 12:24 AM, Stanislav Fomichev wrote: > > Recently we had linux-next bpf/bpf-next conflict when we added new > > functionality to the test_progs.c at the same location. Let's split > > test_progs.c the same way we recently split

Re: [PATCH v2 net 0/4] tls: Fix issues in tls_device

2019-03-01 Thread David Miller
From: Boris Pismenny Date: Wed, 27 Feb 2019 17:38:02 +0200 > This series fixes issues encountered in tls_device code paths, > which were introduced recently. > > Additionally, this series includes a fix for tls software only receive flow, > which causes corruption of payload received by user spa

Re: [PATCH net-next 01/12] net: sched: flower: don't check for rtnl on head dereference

2019-03-01 Thread Cong Wang
On Thu, Feb 28, 2019 at 10:35 AM Vlad Buslov wrote: > > > On Thu 28 Feb 2019 at 00:49, Cong Wang wrote: > > On Tue, Feb 26, 2019 at 6:57 AM Vlad Buslov wrote: > >> > >> > >> On Mon 25 Feb 2019 at 22:39, Cong Wang wrote: > >> > On Mon, Feb 25, 2019 at 8:11 AM Vlad Buslov wrote: > >> >> > >> >>

Re: [PATCH v2 bpf-next 2/2] bpf: Test ref release issue in bpf_tcp_sock and bpf_sk_fullsock.

2019-03-01 Thread Song Liu
> On Mar 1, 2019, at 11:49 AM, Martin KaFai Lau wrote: > > Adding verifier tests to ensure the ptr returned from > bpf_tcp_sock() and bpf_sk_fullsock() cannot be accessed > after bpf_sk_release() is called. It is derived from a > reproducer test from Lorenz Bauer. > > Cc: Lorenz Bauer > Sig

Re: [PATCH v2 bpf-next 1/2] bpf: Fix bpf_tcp_sock and bpf_sk_fullsock issue related to bpf_sk_release

2019-03-01 Thread Song Liu
> On Mar 1, 2019, at 11:49 AM, Martin KaFai Lau wrote: > > Lorenz Bauer [thanks!] reported that a ptr returned by bpf_tcp_sock(sk) > can still be accessed after bpf_sk_release(sk). > Both bpf_tcp_sock() and bpf_sk_fullsock() have the same issue. > This patch addresses them together. > > A sim

Re: [PATCH v2 net-next 0/6] net: aquantia: minor bug fixes after static analysis

2019-03-01 Thread David Miller
From: Igor Russkikh Date: Wed, 27 Feb 2019 12:10:01 + > This patchset fixes minor errors and warnings found by smatch and kasan. > > Extra patch is to replace AQ_HW_WAIT_FOR with readx_poll_timeout > to improve readability. > > V2: > use readx_poll > resubmitted to net-next since the change

Re: [PATCH v2 net] ipv4: Add ICMPv6 support when parse route ipproto

2019-03-01 Thread David Miller
From: Hangbin Liu Date: Wed, 27 Feb 2019 16:15:29 +0800 > For ip rules, we need to use 'ipproto ipv6-icmp' to match ICMPv6 headers. > But for ip -6 route, currently we only support tcp, udp and icmp. > > Add ICMPv6 support so we can match ipv6-icmp rules for route lookup. > > v2: As David Ahern

[PATCH] fsl/fman: Use vsprintf extension %pM

2019-03-01 Thread Joe Perches
Make logging of an ethernet address more consistent with the rest of the kernel. Miscellanea: The %02hx use also did not quite match the u8 definition of addr though that did not actually matter given normal integer promotion rules. Signed-off-by: Joe Perches --- drivers/net/ethernet/freescale

Re: [PATCH net-next] cxgb4: Prefix adapter flags with CXGB4

2019-03-01 Thread kbuild test robot
Hi Arjun, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Arjun-Vynipadath/cxgb4-Prefix-adapter-flags-with-CXGB4/20190302-015236 config: i386-randconfig-a1-03010829 (attached as .config) compiler: gcc

Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework)

2019-03-01 Thread Siwei Liu
On Thu, Feb 28, 2019 at 5:05 PM Jakub Kicinski wrote: > > On Thu, 28 Feb 2019 16:20:28 -0800, Siwei Liu wrote: > > On Thu, Feb 28, 2019 at 11:56 AM Jakub Kicinski wrote: > > > On Thu, 28 Feb 2019 14:36:56 -0500, Michael S. Tsirkin wrote: > > > > > It is a bit of a the chicken or the egg situation

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Daniel Borkmann
On 03/02/2019 01:23 AM, Yonghong Song wrote: > On 2/28/19 4:19 PM, Daniel Borkmann wrote: >> On 03/01/2019 12:41 AM, Stanislav Fomichev wrote: >>> On 03/01, Daniel Borkmann wrote: This work adds BPF loader support for global data sections to libbpf. This allows to write BPF programs in mo

Re: [PATCH v3 bpf-next 2/5] bpf: sync bpf.h to tools and update bpf_helpers.h

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 12:39 PM brakmo wrote: > > This patch syncs the uapi bpf.h to tools/ and also updates > bpf_herlpers.h in tools/ > > Signed-off-by: Lawrence Brakmo Acked-by: Song Liu > --- > tools/include/uapi/linux/bpf.h| 10 +- > tools/testing/selftests/bpf/bpf_he

Re: [PATCH v3 bpf-next 1/5] bpf: add bpf helper bpf_skb_ecn_set_ce

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 12:39 PM brakmo wrote: > > This patch adds a new bpf helper BPF_FUNC_skb_ecn_set_ce > "int bpf_skb_ecn_set_ce(struct sk_buff *skb)". It is added to > BPF_PROG_TYPE_CGROUP_SKB typed bpf_prog which currently can > be attached to the ingress and egress path. The helper is neede

Re: [PATCH bpf-next v2 5/7] bpf, libbpf: support global data/bss/rodata sections

2019-03-01 Thread Yonghong Song
On 2/28/19 4:19 PM, Daniel Borkmann wrote: > On 03/01/2019 12:41 AM, Stanislav Fomichev wrote: >> On 03/01, Daniel Borkmann wrote: >>> This work adds BPF loader support for global data sections >>> to libbpf. This allows to write BPF programs in more natural >>> C-like way by being able to define

Re: [PATCH v2 bpf-next 1/3] bpf: add bpf_progenyof helper

2019-03-01 Thread Martin Lau
On Fri, Mar 01, 2019 at 10:06:12AM -0800, Javier Honduvilla Coto wrote: > From: Javier Honduvilla Coto > > This patch adds the bpf_progenyof helper which receives a PID and returns > 1 if the process currently being executed is in the process hierarchy > including itself or 0 if not. > > This is

Re: [PATCH bpf-next] samples/bpf: silence compiler warning for xdpsock_user.c

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 07:19 AM, Yonghong Song wrote: > Compiling xdpsock_user.c with 4.8.5, I hit the following > compilation warning: > HOSTCC samples/bpf/xdpsock_user.o > /data/users/yhs/work/net-next/samples/bpf/xdpsock_user.c: In function > ‘main’: > /data/users/yhs/work/net-next/samples/bpf/

Re: [PATCH bpf-next] selftests/bpf: set unlimited RLIMIT_MEMLOCK for test_sock_fields

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 07:18 AM, Yonghong Song wrote: > This is to avoid permission denied error. A lot of systems > may have a much lower number, e.g., 64KB, for RLIMIT_MEMLOCK, > which may not be sufficient for the test to run successfully. > > Fixes: e0b27b3f97b8 ("bpf: Add test_sock_fields for skb->sk

Re: [PATCH bpf-next] bpf: add test cases for non-pointer sanitiation logic

2019-03-01 Thread Daniel Borkmann
On 03/02/2019 01:04 AM, Song Liu wrote: > On Fri, Mar 1, 2019 at 3:27 PM Daniel Borkmann wrote: >> On 03/02/2019 12:22 AM, Song Liu wrote: >>> On Fri, Mar 1, 2019 at 1:10 PM Daniel Borkmann wrote: [...] > > I see, so the *2 comes from > > BPF_ALU64_REG(BPF_ADD, BPF_REG_8, BPF_REG_7) Yes, exact

Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains

2019-03-01 Thread Cong Wang
On Thu, Feb 28, 2019 at 6:53 AM Vlad Buslov wrote: > > > On Wed 27 Feb 2019 at 23:03, Cong Wang wrote: > > On Tue, Feb 26, 2019 at 8:10 AM Vlad Buslov wrote: > >> > >> > >> On Tue 26 Feb 2019 at 00:15, Cong Wang wrote: > >> > On Mon, Feb 25, 2019 at 7:45 AM Vlad Buslov wrote: > >> >> > >> >> F

Re: [PATCH bpf-next] bpf: add test cases for non-pointer sanitiation logic

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 3:27 PM Daniel Borkmann wrote: > > On 03/02/2019 12:22 AM, Song Liu wrote: > > On Fri, Mar 1, 2019 at 1:10 PM Daniel Borkmann wrote: > >> > >> Add two additional tests for further asserting the > >> BPF_ALU_NON_POINTER logic with cases that were missed > >> previously. > >>

Re: [PATCH net 03/16] net/sched: act_csum: validate the control action inside init()

2019-03-01 Thread Cong Wang
On Fri, Mar 1, 2019 at 10:02 AM Davide Caratti wrote: > > On Wed, 2019-02-27 at 17:50 -0800, Cong Wang wrote: > > > + if (oldchain) > > > + tcf_chain_put_by_act(oldchain); > > > > Do we need to respect RCU grace period here? > > if I well understand the question, you are worrie

Re: [PATCH bpf-next 1/3] bpf: add bpf_progenyof helper

2019-03-01 Thread Martin Lau
On Fri, Mar 01, 2019 at 09:28:39AM -0800, Javier Honduvilla Coto wrote: > On Wed, Feb 27, 2019 at 06:26:41AM +, Martin Lau wrote: > > On Tue, Feb 26, 2019 at 02:36:49PM -0800, Javier Honduvilla Coto wrote: > > > This patch adds the bpf_progenyof helper which receives a PID and returns > > What

Re: [PATCH bpf-next v2 0/7] selftests: bpf: break up test_progs

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 12:24 AM, Stanislav Fomichev wrote: > Recently we had linux-next bpf/bpf-next conflict when we added new > functionality to the test_progs.c at the same location. Let's split > test_progs.c the same way we recently split test_verifier.c. > > I follow the same patten we did in commit

Re: [PATCH net-next v2 04/12] net: sched: flower: track filter deletion with flag

2019-03-01 Thread Stefano Brivio
Hi Vlad, On Wed, 27 Feb 2019 12:12:18 +0200 Vlad Buslov wrote: > -static bool __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, > - struct netlink_ext_ack *extack) > +static int __fl_delete(struct tcf_proto *tp, struct cls_fl_filter *f, > +bool *l

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 3:23 PM Daniel Borkmann wrote: > > On 03/02/2019 12:18 AM, Song Liu wrote: > > On Fri, Mar 1, 2019 at 1:06 PM Daniel Borkmann wrote: > >> > >> Marek reported that he saw an issue with the below snippet in that > >> timing measurements where off when loaded as unpriv while r

Re: [PATCH v2 bpf-next 0/3] bpf docs typo, wording and formatting fixes

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 02:12 AM, Andrii Nakryiko wrote: > A bunch of BPF-related docs typo, wording and formatting fixes. > > v1->v2: > - split off non-documentation changes into separate patchset > > Andrii Nakryiko (3): > docs/btf: fix typos, improve wording > docs/btf: reflow text to fill up to 78

Re: [PATCH net] bpf: fix u64_stats_init() usage in bpf_prog_alloc()

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 11:33 PM, Eric Dumazet wrote: > We need to iterate through all possible cpus. > > Fixes: 492ecee892c2 ("bpf: enable program stats") > Signed-off-by: Eric Dumazet > Reported-by: Guenter Roeck > Tested-by: Guenter Roeck Applied, thanks! Issue is only in bpf-next, not net, therefore

RE: [PATCH v3 3/6] ethtool: introduce new ioctl for per-queue settings

2019-03-01 Thread Nunley, Nicholas D
> -Original Message- > From: Michal Kubecek [mailto:mkube...@suse.cz] > Sent: Friday, March 1, 2019 6:18 AM > To: Kirsher, Jeffrey T > Cc: linvi...@tuxdriver.com; Nunley, Nicholas D > ; netdev@vger.kernel.org > Subject: Re: [PATCH v3 3/6] ethtool: introduce new ioctl for per-queue > settin

Re: [PATCH net] bpf: fix u64_stats_init() usage in bpf_prog_alloc()

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 2:34 PM Eric Dumazet wrote: > > We need to iterate through all possible cpus. > > Fixes: 492ecee892c2 ("bpf: enable program stats") > Signed-off-by: Eric Dumazet > Reported-by: Guenter Roeck > Tested-by: Guenter Roeck Acked-by: Song Liu > --- > kernel/bpf/core.c | 8 +

[PATCH] net: ipv6: add socket option IPV6_ROUTER_ALERT_ISOLATE

2019-03-01 Thread Francesco Ruggeri
By default IPv6 socket with IPV6_ROUTER_ALERT socket option set will receive all IPv6 RA packets from all namespaces. IPV6_ROUTER_ALERT_ISOLATE socket option restricts packets received by the socket to be only from the socket's namespace. Signed-off-by: Maxim Martynov Signed-off-by: Francesco Rug

Re: [PATCH bpf-next] bpf: add test cases for non-pointer sanitiation logic

2019-03-01 Thread Daniel Borkmann
On 03/02/2019 12:22 AM, Song Liu wrote: > On Fri, Mar 1, 2019 at 1:10 PM Daniel Borkmann wrote: >> >> Add two additional tests for further asserting the >> BPF_ALU_NON_POINTER logic with cases that were missed >> previously. >> >> Signed-off-by: Daniel Borkmann >> Cc: Marek Majkowski >> Cc: Arth

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Daniel Borkmann
On 03/02/2019 12:18 AM, Song Liu wrote: > On Fri, Mar 1, 2019 at 1:06 PM Daniel Borkmann wrote: >> >> Marek reported that he saw an issue with the below snippet in that >> timing measurements where off when loaded as unpriv while results >> were reasonable when loaded as privileged: >> >> [...

Re: [PATCH bpf-next] bpf: add test cases for non-pointer sanitiation logic

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 1:10 PM Daniel Borkmann wrote: > > Add two additional tests for further asserting the > BPF_ALU_NON_POINTER logic with cases that were missed > previously. > > Signed-off-by: Daniel Borkmann > Cc: Marek Majkowski > Cc: Arthur Fabre > --- > .../selftests/bpf/verifier/valu

Re: [PATCH bpf] bpf: fix sanitation rewrite in case of non-pointers

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 1:06 PM Daniel Borkmann wrote: > > Marek reported that he saw an issue with the below snippet in that > timing measurements where off when loaded as unpriv while results > were reasonable when loaded as privileged: > > [...] > uint64_t a = bpf_ktime_get_ns(); > u

Re: [PATCH bpf-next] samples/bpf: silence compiler warning for xdpsock_user.c

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 11:10 AM Jonathan Lemon wrote: > > On 28 Feb 2019, at 22:19, Yonghong Song wrote: > > > Compiling xdpsock_user.c with 4.8.5, I hit the following > > compilation warning: > > HOSTCC samples/bpf/xdpsock_user.o > > /data/users/yhs/work/net-next/samples/bpf/xdpsock_user.c

Re: [PATCH bpf-next] selftests/bpf: set unlimited RLIMIT_MEMLOCK for test_sock_fields

2019-03-01 Thread Song Liu
On Thu, Feb 28, 2019 at 10:20 PM Yonghong Song wrote: > > This is to avoid permission denied error. A lot of systems > may have a much lower number, e.g., 64KB, for RLIMIT_MEMLOCK, > which may not be sufficient for the test to run successfully. > > Fixes: e0b27b3f97b8 ("bpf: Add test_sock_fields f

Re: [PATCH] MIPS: eBPF: Fix icache flush end address

2019-03-01 Thread Daniel Borkmann
On 03/01/2019 11:58 PM, Paul Burton wrote: > The MIPS eBPF JIT calls flush_icache_range() in order to ensure the > icache observes the code that we just wrote. Unfortunately it gets the > end address calculation wrong due to some bad pointer arithmetic. > > The struct jit_ctx target field is of ty

Re: [PATCH bpf-next v2 1/7] bpf: implement lookup-free direct value access

2019-03-01 Thread Yonghong Song
On 3/1/19 11:51 AM, Daniel Borkmann wrote: > On 03/01/2019 06:18 PM, Yonghong Song wrote: >> On 2/28/19 3:18 PM, Daniel Borkmann wrote: >>> This generic extension to BPF maps allows for directly loading an >>> address residing inside a BPF map value as a single BPF ldimm64 >>> instruction. >>> >>

[PATCH] MIPS: eBPF: Fix icache flush end address

2019-03-01 Thread Paul Burton
The MIPS eBPF JIT calls flush_icache_range() in order to ensure the icache observes the code that we just wrote. Unfortunately it gets the end address calculation wrong due to some bad pointer arithmetic. The struct jit_ctx target field is of type pointer to u32, and as such adding one to it will

[PATCH 1/3] mac80211_hwsim: Replace hrtimer tasklet with softirq hrtimer

2019-03-01 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner Switch the timer to HRTIMER_MODE_REL_SOFT, which executed the timer callback in softirq context and remove the hrtimer_tasklet. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Reviewed-by: Johannes Berg Cc: linux-wirel...@vger.kernel.org Cc: Johannes Be

[PATCH 2/3] xfrm: Replace hrtimer tasklet with softirq hrtimer

2019-03-01 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner Switch the timer to HRTIMER_MODE_SOFT, which executed the timer callback in softirq context and remove the hrtimer_tasklet. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Cc: Steffen Klassert Cc: netdev@vger.kernel.org Cc: Herbert Xu Cc: "David S. Mil

Remove tasklet_hrtimer

2019-03-01 Thread Sebastian Andrzej Siewior
I just noticed that we still have the tasklet_hrtimer infastructure in tree. A while ago we tried to remove it. I digged the old patches up and it seems they did not apply and nobody followed up. So here they are again. Last two user. Sebastian

[PATCH 3/3] softirq: Remove tasklet_hrtimer

2019-03-01 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner There are no more tasklet_hrtimer users of this interface. Remove it. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Signed-off-by: Sebastian Andrzej Siewior --- include/linux/interrupt.h | 25 --- kernel/softirq.c | 51 --

  1   2   3   4   >