Re: Possible bug into DSA2 code.

2019-02-19 Thread Rodolfo Giometti
On 19/02/2019 01:03, Andrew Lunn wrote: diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 54a5b660640a..bb46ebbb2bb8 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2399,7 +2399,7 @@ static int mv88e6xxx_setup(struct ds

Re: [RFC v1 15/19] RDMA/irdma: Add miscellaneous utility definitions

2019-02-19 Thread Leon Romanovsky
On Fri, Feb 15, 2019 at 10:47:14AM -0700, Jason Gunthorpe wrote: > On Fri, Feb 15, 2019 at 11:11:02AM -0600, Shiraz Saleem wrote: > > From: Mustafa Ismail > > > > Add miscellaneous utility functions and headers. > > > > Signed-off-by: Mustafa Ismail > > Signed-off-by: Shiraz Saleem > > drivers/

[PATCH iproute2-next v1 02/19] rdma: Remove duplicated print code

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky There is no need to keep same print functions for uint32_t and uint64_t, unify them into one function. Signed-off-by: Leon Romanovsky --- rdma/res.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/rdma/res.c b/rdma/res.c index 6

[PATCH iproute2-next v1 12/19] rdma: Simplify CM_ID print code

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Refactor our the CM_ID print code. Signed-off-by: Leon Romanovsky --- rdma/res-cmid.c | 246 1 file changed, 124 insertions(+), 122 deletions(-) diff --git a/rdma/res-cmid.c b/rdma/res-cmid.c index 5eea7a6b..12d1acee 10064

[PATCH iproute2-next v1 16/19] rdma: Move QP code to separate function

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/res-qp.c | 253 +- 1 file changed, 127 insertions(+), 126 deletions(-) diff --git a/rdma/res-qp.c b/rdma/res-qp.c index ecd2cbd6..e74c8b01 100644 --- a/rdma/res-qp.c +++ b/rdma/res-qp.

[PATCH iproute2-next v1 15/19] rdma: Separate PD code

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/res-pd.c | 170 ++ 1 file changed, 89 insertions(+), 81 deletions(-) diff --git a/rdma/res-pd.c b/rdma/res-pd.c index 24ac7f1b..3c9ffa4e 100644 --- a/rdma/res-pd.c +++ b/rdma/res-pd.c

[PATCH iproute2-next v1 18/19] rdma: Perform single .doit call to query specific objects

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky If user provides specific index, we can speedup query by using .doit callback and save full dump and filtering after that. Signed-off-by: Leon Romanovsky --- rdma/rdma.h | 10 +- rdma/res-cmid.c | 33 +-- rdma/res-cq.c | 34 ++--

[PATCH iproute2-next v1 17/19] rdma: Unify netlink attribute checks prior to prints

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Place check if netlink attribute available in general place, instead of doing the same check in many paces. Signed-off-by: Leon Romanovsky --- rdma/res-cmid.c | 9 - rdma/res-cq.c | 22 +++--- rdma/res-mr.c | 21 +++-- rdma/res

[PATCH iproute2-next v1 01/19] rdma: update uapi headers

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Update rdma_netlink,h file upto kernel commit f2a0e45f36b0 RDMA/nldev: Don't expose number of not-visible entries Signed-off-by: Leon Romanovsky --- rdma/include/uapi/rdma/rdma_netlink.h | 64 +-- 1 file changed, 50 insertions(+), 14 deletions(-)

[PATCH iproute2-next v1 00/19] Export object IDs to users

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v0->v1: * Rebased to latest iproute2-next * Added latest rdma_netlink.h and updated commit message to point to kernel SHA commit. This series adds ability to present and query all known to rdmatool object by their respective, unique IDs (e.g. pdn. mrn, cqn e

[PATCH iproute2-next v1 05/19] rdma: Move resource PD logic to separate file

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource PD logic to separate file, in order to make PD specific logic self-contained. Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/res-pd.c | 110 rdma/res.c| 154 +++--

[PATCH iproute2-next v1 19/19] rdma: Provide and reuse filter functions

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Globally replace all filter function in safer variants of those is_filterred functions, which take into account the availability/lack of netlink attributes. Such conversion allowed to fix a number of places in the code, where the previous implementation didn't honor filter

[PATCH iproute2-next v1 07/19] rdma: Move out resource CQ logic to separate file

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource CQ logic to separate file, in order to make CQ specific logic self-contained. Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/res-cq.c | 143 rdma/res.c| 147 -

[PATCH iproute2-next v1 11/19] rdma: Simplify code to reuse existing functions

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Remove duplicated functions in favour general res_print_uint() call. Signed-off-by: Leon Romanovsky --- rdma/res-cmid.c | 4 ++-- rdma/res-cq.c | 14 +++--- rdma/res-mr.c | 2 +- rdma/res-pd.c | 4 ++-- rdma/res-qp.c | 14 +++--- rdma/res.c

[PATCH iproute2-next v1 09/19] rdma: Move resource PD logic to separate file

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource PD logic to separate file, in order to make PD specific logic self-contained. Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/res-qp.c | 234 + rdma/res.c| 236

[PATCH iproute2-next v1 06/19] rdma: Refactor out resource MR logic to separate file

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource MR logic to separate file, in order to make MR specific logic self-contained. Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/res-mr.c | 117 +++ rdma/res.c| 122 --

[PATCH iproute2-next v1 10/19] rdma: Properly mark RDMAtool license

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky RDMA subsystem is dual-licensed with "GPL-2.0 OR Linux-OpenIB" proper license and Mellanox submission are supposed to have this type of license. Signed-off-by: Leon Romanovsky --- rdma/Makefile | 2 +- rdma/dev.c| 7 +-- rdma/link.c | 7 +-- rdma/rdma.c |

[PATCH iproute2-next v1 08/19] rdma: Move out resource CM-ID logic to separate file

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Logically separate resource CM-ID logic to separate file, in order to make CM-ID specific logic self-contained. Signed-off-by: Leon Romanovsky --- rdma/Makefile | 3 +- rdma/res-cmid.c | 252 rdma/res.c | 271 +

[PATCH iproute2-next v1 14/19] rdma: Separate MR code

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/res-mr.c | 178 +- 1 file changed, 90 insertions(+), 88 deletions(-) diff --git a/rdma/res-mr.c b/rdma/res-mr.c index e373035a..36993b5e 100644 --- a/rdma/res-mr.c +++ b/rdma/res-mr.c

[PATCH iproute2-next v1 13/19] rdma: Refactor CQ prints

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/res-cq.c | 177 ++ 1 file changed, 91 insertions(+), 86 deletions(-) diff --git a/rdma/res-cq.c b/rdma/res-cq.c index 93c18251..e50d76ce 100644 --- a/rdma/res-cq.c +++ b/rdma/res-cq.c

[PATCH iproute2-next v1 04/19] rdma: Provide parent context index for all objects except CM_ID

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Allow users to correlate allocated object with relevant parent [leonro@server ~]$ rdma res show pd dev mlx5_0 users 5 pid 0 comm [ib_core] pdn 1 dev mlx5_0 users 7 pid 0 comm [ib_ipoib] pdn 2 dev mlx5_0 users 0 pid 0 comm [mlx5_ib] pdn 3 dev mlx5_0 users 2 pid 548 comm ibv_

[PATCH iproute2-next v1 03/19] rdma: Provide unique indexes for all visible objects

2019-02-19 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/res.c | 83 +- 1 file changed, 63 insertions(+), 20 deletions(-) diff --git a/rdma/res.c b/rdma/res.c index 87865ec8..f941de5c 100644 --- a/rdma/res.c +++ b/rdma/res.c @@ -549,6 +5

Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-19 Thread Michal Simek
Hi, On 19. 02. 19 18:25, Andrew Lunn wrote: >> Thanks for the suggestion! So I had a closer look at that driver to try >> and see what could go wrong and it looks like I found a few things >> there. > > Hi Paul > > Yes, this driver has issues. If i remember correctly, it got merged > while i was

Re: linux-next: Fixes tag needs some work in the net-next tree

2019-02-19 Thread David Miller
From: Vinod Koul Date: Wed, 20 Feb 2019 10:10:55 +0530 > On 20-02-19, 09:31, Stephen Rothwell wrote: >> Hi all, >> >> In commit >> >> a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode") >> >> Fixes tag >> >> Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode"

[PATCH net-next] net: phy: aquantia: Use get_features for the PHYs abilities

2019-02-19 Thread Heiner Kallweit
From: Andrew Lunn Use the new PHY driver call to get the PHYs supported features. Signed-off-by: Andrew Lunn [hkallwe...@gmail.com: removed new config_init callback from patch] Signed-off-by: Heiner Kallweit --- drivers/net/phy/aquantia.c | 14 +++--- 1 file changed, 7 insertions(+), 7

mlx5 stable backport help

2019-02-19 Thread David Miller
Saeed and Or, I need help backporting two changes for -stable. Namely: 6707f74be8621ae067d2cf1c4485900e2742c20f ("net/mlx5e: Update hw flows when encap source mac changed") 218d05ce326f9e1b40a56085431fa1068b43d5d9 ("net/mlx5e: Don't overwrite pedit action when multiple pedit used") For exam

[PATCH net-next] tls: Return type of non-data records retrieved using MSG_PEEK in recvmsg

2019-02-19 Thread Vakul Garg
The patch enables returning 'type' in msghdr for records that are retrieved with MSG_PEEK in recvmsg. Further it prevents records peeked from socket from getting clubbed with any other record of different type when records are subsequently dequeued from strparser. For each record, we now retain it

[PATCH] r8152: Fix an error on RTL8153-BD MAC Address Passthrough support

2019-02-19 Thread David Chen
From: David Chen RTL8153-BD is used in Dell DA300 type-C dongle. Added RTL8153-BD support to activate MAC address pass through on DA300. Apply correction on previously submitted patch in net.git tree. Signed-off-by: David Chen --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(+),

Re: linux-next: Fixes tag needs some work in the net-next tree

2019-02-19 Thread Stephen Rothwell
Hi Vinod, On Wed, 20 Feb 2019 10:10:55 +0530 Vinod Koul wrote: > > Dave would you like to drop this and me sending updated patch or > something else.. Dave doesn't rebase/reset net-next, so we will just have to use this as a learning experience :-) -- Cheers, Stephen Rothwell pgpK0cIvDY0ot.p

[RESEND PATCH 2/7] mm/gup: Change write parameter to flags in fast walk

2019-02-19 Thread ira . weiny
From: Ira Weiny In order to support more options in the GUP fast walk, change the write parameter to flags throughout the call stack. This patch does not change functionality and passes FOLL_WRITE where write was previously used. Signed-off-by: Ira Weiny --- mm/gup.c | 52

[RESEND PATCH 6/7] IB/qib: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-19 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qib/qib_user_sdma.c

[RESEND PATCH 1/7] mm/gup: Replace get_user_pages_longterm() with FOLL_LONGTERM

2019-02-19 Thread ira . weiny
From: Ira Weiny Rather than have a separate get_user_pages_longterm() call, introduce FOLL_LONGTERM and change the longterm callers to use it. This patch does not change any functionality. FOLL_LONGTERM can only be supported with get_user_pages() as it requires vmas to determine if DAX is in us

[RESEND PATCH 7/7] IB/mthca: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-19 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/mthca/mthca_memfree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mthca/mthca_memf

[RESEND PATCH 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast

2019-02-19 Thread ira . weiny
From: Ira Weiny DAX pages were previously unprotected from longterm pins when users called get_user_pages_fast(). Use the new FOLL_LONGTERM flag to check for DEVMAP pages and fall back to regular GUP processing if a DEVMAP page is encountered. Signed-off-by: Ira Weiny --- mm/gup.c | 24 ++

[RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it

2019-02-19 Thread ira . weiny
From: Ira Weiny Resending these as I had only 1 minor comment which I believe we have covered in this series. I was anticipating these going through the mm tree as they depend on a cleanup patch there and the IB changes are very minor. But they could just as well go through the IB tree. NOTE:

[RESEND PATCH 5/7] IB/hfi1: Use the new FOLL_LONGTERM flag to get_user_pages_fast()

2019-02-19 Thread ira . weiny
From: Ira Weiny Use the new FOLL_LONGTERM to get_user_pages_fast() to protect against FS DAX pages being mapped. Signed-off-by: Ira Weiny --- drivers/infiniband/hw/hfi1/user_pages.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/user_pages.

[RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-19 Thread ira . weiny
From: Ira Weiny To facilitate additional options to get_user_pages_fast() change the singular write parameter to be gup_flags. This patch does not change any functionality. New functionality will follow in subsequent patches. Some of the get_user_pages_fast() call sites were unchanged because

Re: [PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs

2019-02-19 Thread Stanislav Fomichev
On 02/19, Jakub Kicinski wrote: > On Mon, 18 Feb 2019 21:38:36 -0800, brakmo wrote: > > +#include "bpf_load.h" > > nit: please use libbpf My suggestion was to just use bpftool, no need for another helper in the samples/ directory. WDYT?

Re: linux-next: Fixes tag needs some work in the net-next tree

2019-02-19 Thread Vinod Koul
On 20-02-19, 09:31, Stephen Rothwell wrote: > Hi all, > > In commit > > a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode") > > Fixes tag > > Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode") > > has these problem(s): > > - Target SHA1 does not exist >

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-19 Thread Dominique Martinet
Dominique Martinet wrote on Fri, Feb 15, 2019: > With all that said I guess my patch should work correctly then, I'll try > to find some time to check the error does come back up the tcp socket in > my reproducer but I have no reason to believe it doesn't. Ok, so I can confirm this part - the 'cso

Re: [Outreachy kernel] [PATCH] net: dsa: add missing of_node_put

2019-02-19 Thread Vaishali Thakkar
On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote: > Hi Himadri, Thanks for the patch! For the scope of Outreachy, we prefer that you send patches in staging directory as Greg makes sure to pick them during the application period. Of course, you're very much encouraged to contribute to other

[PATCH] net: dsa: add missing of_node_put

2019-02-19 Thread Himadri Pandya
Decrement the reference count on port while returning out of the loop. Signed-off-by: Himadri Pandya --- net/dsa/dsa2.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c index a1917025e155..396e7433dd8f 100644 --- a/net/dsa/dsa2.c

Re: linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Stanislav Fomichev
On Tue, Feb 19, 2019 at 5:07 PM Daniel Borkmann wrote: > > On 02/20/2019 01:41 AM, Alexei Starovoitov wrote: > > On Tue, Feb 19, 2019 at 4:37 PM Stephen Rothwell > > wrote: > >> > >> Hi all, > >> > >> Today's linux-next merge of the net-next tree got a conflict in: > >> > >> tools/testing/self

Re: [RFC PATCH net-next v3 13/21] ethtool: provide timestamping information in GET_INFO request

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:22:29 +0100 (CET), Michal Kubecek wrote: > Add timestamping information as provided by ETHTOOL_GET_TS_INFO ioctl > command in GET_INFO reply if ETH_INFO_IM_TSINFO flag is set in the request. > > Add constants for counts of HWTSTAMP_TX_* and HWTSTAM_FILTER_* constants > and p

Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth

2019-02-19 Thread Chen-Yu Tsai
On Wed, Feb 20, 2019 at 5:09 AM David Summers wrote: > > On 19/02/2019 14:17, Rob Herring wrote: > > On Mon, Feb 18, 2019 at 4:28 PM Vasily Khoruzhick > > wrote: > >> On Mon, Feb 18, 2019 at 2:08 PM Stefan Wahren > >> wrote: > >>> Hi Vasily, > >> Hi Stefan, > >> > Vasily Khoruzhick hat a

Re: [RFC PATCH net-next v3 10/21] ethtool: provide string sets with GET_STRSET request

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:22:14 +0100 (CET), Michal Kubecek wrote: > Requests a contents of one or more string sets, i.e. indexed arrays of > strings; this information is provided by ETHTOOL_GSSET_INFO and > ETHTOOL_GSTRINGS commands of ioctl interface. There are three types of > requests: > > - no

Re: [RFC PATCH net-next v3 08/21] ethtool: generic handlers for GET requests

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:22:04 +0100 (CET), Michal Kubecek wrote: > +static struct common_req_info *alloc_get_data(const struct get_request_ops > *ops) nit: IMHO prefixing all structures and functions with a common phrase (ethnl) makes the code easier to navigate. > +{ > + struct common_r

[Patch net-next 12/12] net: hns3: clear command queue's registers when unloading VF driver

2019-02-19 Thread Huazhong Tan
According to the hardware's description, the driver should clear the command queue's registers when uloading VF driver. Otherwise, these existing value may lead the IMP get into a wrong state. Fixes: fedd0c15d288 ("net: hns3: Add HNS3 VF IMP(Integrated Management Proc) cmd interface") Signed-off-

[Patch net-next 09/12] net: hns3: Record VF unicast and multicast tables

2019-02-19 Thread Huazhong Tan
From: liuzhongzhu Record the unicast and multicast tables that the VF sends to the chip. After the VF exception, the PF actively clears the VF to chip config. Signed-off-by: liuzhongzhu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h

[Patch net-next 11/12] net: hns3: uninitialize command queue while unloading PF driver

2019-02-19 Thread Huazhong Tan
According to the hardware's description, the driver should clear the command queue's registers when uloading driver. Otherwise, these existing value may lead the IMP get into a wrong state. Also this patch adds hclge_cmd_uninit() to do the command queue uninitialization which includes clearing reg

[Patch net-next 06/12] net: hns3: some bugfix of ppu(rcb) ras errors

2019-02-19 Thread Huazhong Tan
From: Weihang Li The 3rd and 4th of PPU(RCB) PF Abnormal is RAS errors instead of MSI-X like other bits. This patch adds process of handling and logging this two bits. Otherwise, this patch modifies print message of 28th and 29th bit of PPU MPF Abnormal errors, which keep same with other errors n

[Patch net-next 02/12] net: hns3: Check variable is valid before assigning it to another

2019-02-19 Thread Huazhong Tan
From: Yonglong Liu In hnae3_register_ae_dev(), ae_algo->ops is assigned to ae_dev->ops before check that ae_algo->ops is valid. And in hnae3_register_ae_algo(), missing check for ae_algo->ops. This patch fixes them. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong T

[Patch net-next 01/12] net: hns3: add pointer checking at the beginning of the exported functions.

2019-02-19 Thread Huazhong Tan
From: Yonglong Liu These functions are exported, add pointer checking at the beginning can make them more safe. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 21 + 1 file changed, 21 insert

[Patch net-next 10/12] net: hns3: Record VF vlan tables

2019-02-19 Thread Huazhong Tan
From: liuzhongzhu Record the vlan tables that the VF sends to the chip. After the VF exception, the PF actively clears the VF to chip config. Signed-off-by: liuzhongzhu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 80

[Patch net-next 05/12] net: hns3: modify print message of ssu common ecc errors

2019-02-19 Thread Huazhong Tan
From: Weihang Li This patch add information of specific bit in log to be consistent with other type of errors, so that we can know which memory of ssu has occurred a ecc ras errors. Signed-off-by: Weihang Li Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../net/ethernet/hisilicon/hn

[Patch net-next 03/12] net: hns3: convert mac advertize and supported from u32 to link mode

2019-02-19 Thread Huazhong Tan
From: Jian Shen The link mode with bits has been up to more than 31 for some MAC and phy. Convert to using a linkmode bitmap, which can support all link modes. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c|

[Patch net-next 00/12] code optimizations & bugfixes for HNS3 driver

2019-02-19 Thread Huazhong Tan
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver. Huazhong Tan (2): net: hns3: uninitialize command queue while unloading PF driver net: hns3: clear command queue's registers when unloading VF driver Jian Shen (2): net: hns3: convert mac adverti

[Patch net-next 04/12] net: hns3: fix port info query issue for copper port

2019-02-19 Thread Huazhong Tan
From: Jian Shen In original codes, for copper port which doesn't connect to phy, it always returns -EOPNOTSUPP when query port information. This patch fixes it by return the port information of MAC. Fixes: 5f373b158523 ("net: hns3: Fix speed/duplex information loss problem when executing ethtoo

[Patch net-next 07/12] net: hns3: enable 8~11th bit of mac common msi-x error

2019-02-19 Thread Huazhong Tan
From: Weihang Li These bits are enabled now and have been test. Signed-off-by: Weihang Li Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 6 ++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.h | 4 ++-- 2 files changed

[Patch net-next 08/12] net: hns3: fix 6th bit of ppp mpf abnormal errors

2019-02-19 Thread Huazhong Tan
From: Weihang Li This patch modify print message of 6th bit of ppp mpf abnormal errors, there is a extra letter e in it. Signed-off-by: Weihang Li Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 2 +- 1 file changed, 1 insertion

Re: [RFC PATCH net-next v3 05/21] ethtool: netlink bitset handling

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 19:21:49 +0100 (CET), Michal Kubecek wrote: > + else if (is_u32) > + bitmap_from_arr32(val, bitmap, nbits); > + else > + bitmap_copy(val, bitmap, nbits); > + nla_for_each_nested(bit_attr, tb[ETHA_BITSET_

Re: [PATCH bpf-next 6/9] bpf: Sample program to load cg skb BPF programs

2019-02-19 Thread Jakub Kicinski
On Mon, 18 Feb 2019 21:38:36 -0800, brakmo wrote: > +#include "bpf_load.h" nit: please use libbpf

Questions about porting stmmac to a HI3535 SoC

2019-02-19 Thread Ed Martin
Hi,     So I hope this is the right place to be asking this, this is my first time doing real kernel development for something useful, and this is long winded, I've spent a lot of time on it. Anyways, I am attempting to make the stmmac driver work on a HiSilicon HI3535 SoC (this is a SoC targeted

Re: linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Daniel Borkmann
On 02/20/2019 01:41 AM, Alexei Starovoitov wrote: > On Tue, Feb 19, 2019 at 4:37 PM Stephen Rothwell > wrote: >> >> Hi all, >> >> Today's linux-next merge of the net-next tree got a conflict in: >> >> tools/testing/selftests/bpf/test_progs.c >> >> between commit: >> >> f6be4d16039b ("selftest

Re: linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Stephen Rothwell
Hi Stanislav, On Tue, 19 Feb 2019 16:45:46 -0800 Stanislav Fomichev wrote: > > OTOH, I don't understand why is there a conflict? bpf and bpf-next > adding tests in the same place/file? Those can be trivially resolved > when bpf and bpf-next are merged in the next window. Yes, and yes :-) -- Ch

Re: [PATCH net-next 3/3] nfp: devlink: allow flashing the device via devlink

2019-02-19 Thread Jakub Kicinski
On Tue, 19 Feb 2019 10:19:42 +0100, Jiri Pirko wrote: > Fri, Feb 15, 2019 at 04:44:29PM CET, jakub.kicin...@netronome.com wrote: > >On Fri, 15 Feb 2019 11:15:14 +0100, Jiri Pirko wrote: > >> > static const struct ethtool_ops nfp_net_ethtool_ops = { > >> > >> Why don't you use the compat fall

Re: linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Stanislav Fomichev
On Tue, Feb 19, 2019 at 4:41 PM Alexei Starovoitov wrote: > > On Tue, Feb 19, 2019 at 4:37 PM Stephen Rothwell > wrote: > > > > Hi all, > > > > Today's linux-next merge of the net-next tree got a conflict in: > > > > tools/testing/selftests/bpf/test_progs.c > > > > between commit: > > > > f6

Re: linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Alexei Starovoitov
On Tue, Feb 19, 2019 at 4:37 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > tools/testing/selftests/bpf/test_progs.c > > between commit: > > f6be4d16039b ("selftests/bpf: make sure signal interrupts > BPF_PROG_TEST_RUN") Ouch.

linux-next: manual merge of the net-next tree with the bpf tree

2019-02-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: tools/testing/selftests/bpf/test_progs.c between commit: f6be4d16039b ("selftests/bpf: make sure signal interrupts BPF_PROG_TEST_RUN") from the bpf tree and commits: bf0f0fd93945 ("selftests/bpf: add simple BPF_PRO

Re: [GIT] Networking

2019-02-19 Thread pr-tracker-bot
The pull request you sent on Tue, 19 Feb 2019 14:33:26 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/40e196a906d969fd10d885c692d2674b3d657006 Thank you! -- Deet-doot-dot, I

Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags

2019-02-19 Thread Russell King - ARM Linux admin
On Tue, Feb 19, 2019 at 03:53:50PM -0800, Florian Fainelli wrote: > On 2/19/19 3:34 PM, Russell King - ARM Linux admin wrote: > > On Tue, Feb 19, 2019 at 05:00:59PM +, Russell King - ARM Linux admin > > wrote: > >> I've just changed my last patch to set these modes from > >> dsa_port_bridge_jo

Re: [PATCH iproute2] bridge: make mcast_flood description consistent

2019-02-19 Thread Russell King - ARM Linux admin
On Tue, Feb 19, 2019 at 06:47:38PM -0500, Vivien Didelot wrote: > This patch simply changes the description of the mcast_flood flag > with "flood" instead of "be flooded with" to avoid confusion, and be > consistent with the description of the flooding flag, which "Controls > whether a given port w

[PATCH v2 net-next 2/4] net: dsa: microchip: add MIB counter reading support

2019-02-19 Thread Tristram.Ha
From: Tristram Ha Add background MIB counter reading support. Port MIB counters should only be read when there is link. Otherwise it is a waste of time as hardware never increases those counters. There are exceptions as some switches keep track of dropped counts no matter waht. Signed-off-by:

[PATCH v2 net-next 3/4] net: dsa: microchip: get port link status

2019-02-19 Thread Tristram.Ha
From: Tristram Ha Get port link status to know whether to read MIB counters when the link is going down. Add port_cleanup function to read MIB counters the last time as after the port is disabled the PHY is also powered down. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz9477.c

[PATCH v2 net-next 1/4] net: dsa: microchip: prepare PHY for proper advertisement

2019-02-19 Thread Tristram.Ha
From: Tristram Ha Prepare PHY for proper advertisement as sometimes the PHY in the switch has its own problems even though it may share the PHY id from regular PHY but the fixes in the PHY driver do not apply. Signed-off-by: Tristram Ha --- drivers/net/dsa/microchip/ksz9477.c| 13 +

[PATCH v2 net-next 4/4] net: dsa: microchip: remove unnecessary include headers

2019-02-19 Thread Tristram.Ha
From: Tristram Ha Remove unnecessary header include. Signed-off-by: Tristram Ha Reviewed-by: Andrew Lunn --- drivers/net/dsa/microchip/ksz9477.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 6ad28e2..a94

[PATCH v2 net-next 0/4] net: dsa: microchip: add MIB counters support

2019-02-19 Thread Tristram.Ha
From: Tristram Ha This series of patches is to modify the KSZ9477 DSA driver to read MIB counters periodically to avoid overflow. The MIB counters should be read only when there is link. Otherwise it is a waste of time as hardware never increases the counters. Functions are added to check the

Re: [PATCH bpf-next 3/9] bpf: add bpf helper bpf_skb_set_ecn

2019-02-19 Thread Lawrence Brakmo
On 2/19/19, 2:52 AM, "netdev-ow...@vger.kernel.org on behalf of Daniel Borkmann" wrote: On 02/19/2019 06:38 AM, brakmo wrote: > This patch adds a new bpf helper BPF_FUNC_skb_set_ecn > "int bpf_skb_set_Ecn(struct sk_buff *skb)". It is added to > BPF_PROG_TYPE_CGROUP_SKB typed b

Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags

2019-02-19 Thread Florian Fainelli
On 2/19/19 3:34 PM, Russell King - ARM Linux admin wrote: > On Tue, Feb 19, 2019 at 05:00:59PM +, Russell King - ARM Linux admin > wrote: >> I've just changed my last patch to set these modes from >> dsa_port_bridge_join() and dsa_port_bridge_leave(), and while testing, >> I notice this on the

[PATCH iproute2] bridge: make mcast_flood description consistent

2019-02-19 Thread Vivien Didelot
This patch simply changes the description of the mcast_flood flag with "flood" instead of "be flooded with" to avoid confusion, and be consistent with the description of the flooding flag, which "Controls whether a given port will *flood* unicast traffic for which there is no FDB entry." Signed-of

[PATCH net] ipvlan: disallow userns cap_net_admin to change global mode/flags

2019-02-19 Thread Daniel Borkmann
When running Docker with userns isolation e.g. --userns-remap="default" and spawning up some containers with CAP_NET_ADMIN under this realm, I noticed that link changes on ipvlan slave device inside that container can affect all devices from this ipvlan group which are in other net namespaces where

Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags

2019-02-19 Thread Russell King - ARM Linux admin
On Tue, Feb 19, 2019 at 05:00:59PM +, Russell King - ARM Linux admin wrote: > I've just changed my last patch to set these modes from > dsa_port_bridge_join() and dsa_port_bridge_leave(), and while testing, > I notice this on the ZII rev B board: > > At boot (without anything connected to any

Re: [RFC iproute2] devlink: add support for updating device flash

2019-02-19 Thread Stephen Hemminger
On Sun, 10 Feb 2019 22:59:23 -0800 Jakub Kicinski wrote: > Add new command for updating flash of devices via devlink API. > Example: > > $ cp flash-boot.bin /lib/firmware/ > $ devlink dev flash pci/:05:00.0 file flash-boot.bin > > Signed-off-by: Jakub Kicinski This is targeted at iproute2

Re: [RFC iproute2 v2] ip route: get: allow zero-length subnet mask

2019-02-19 Thread Stephen Hemminger
On Thu, 14 Feb 2019 23:29:18 + Luca Boccassi wrote: > A /0 subnet mask is theoretically valid, but ip route get doesn't allow > it: > > $ ip route get 1.0.0.0/0 > need at least a destination address > > Change the check and remember whether we found an address or not, since > according to t

Re: [PATCH iproute2, v2] ip-rule: fix json key "to_tbl" for unspecific rule action

2019-02-19 Thread Stephen Hemminger
On Tue, 19 Feb 2019 21:50:19 +0100 Thomas Haller wrote: > The key should not be called "to_tbl" because it is exactly > not a FR_ACT_TO_TBL action. Change it to "action". > > # ip rule add blackhole > # ip -j rule | python -m json.tool > ... > { > "priority": 0, >

Re: [PATCH bpf-next 1/9] bpf: Add bpf helper bpf_tcp_enter_cwr

2019-02-19 Thread Lawrence Brakmo
On 2/19/19, 2:24 AM, "Daniel Borkmann" wrote: On 02/19/2019 06:38 AM, brakmo wrote: > This patch adds a new bpf helper BPF_FUNC_tcp_enter_cwr > "int bpf_tcp_enter_cwr(struct bpf_tcp_sock *tp)". > It is added to BPF_PROG_TYPE_CGROUP_SKB typed bpf_prog > which currently can be

Re: [PATCH net-next v2 2/3] net: dsa: mv88e6xxx: add support for bridge flags

2019-02-19 Thread Russell King - ARM Linux admin
On Tue, Feb 19, 2019 at 02:56:27PM -0500, Vivien Didelot wrote: > Hi Russell, > > On Tue, 19 Feb 2019 19:10:16 +, Russell King - ARM Linux admin > wrote: > > > True, let's stick with ops->port_egress_flood(ds, port, bool uc, bool mc). > > > I do not think that it is necessary to add support

[GIT] Networking

2019-02-19 Thread David Miller
1) Fix suspend and resume in mt76x0u USB driver, from Stanislaw Gruszka. 2) Missing memory barriers in xsk, from Magnus Karlsson. 3) rhashtable fixes in mac80211 from Herbert Xu. 4) 32-bit MIPS eBPF JIT fixes from Paul Burton. 5) Fix for_each_netdev_feature() on big endian, from Hauke Mehrten

linux-next: Fixes tag needs some work in the net-next tree

2019-02-19 Thread Stephen Rothwell
Hi all, In commit a968b5e9d587 ("net: dsa: qca8k: Enable delay for RGMII_ID mode") Fixes tag Fixes: 40269aa9f40a ("net: dsa: qca8k: disable delay for RGMII mode") has these problem(s): - Target SHA1 does not exist Did you mean: Fixes: 5ecdd77c61c8 ("net: dsa: qca8k: disable delay fo

Re: [PATCH bpf-next 7/9] bpf: Sample NRM BPF program to limit egress bw

2019-02-19 Thread Lawrence Brakmo
On 2/19/19, 10:29 AM, "netdev-ow...@vger.kernel.org on behalf of Eric Dumazet" wrote: On 02/18/2019 09:38 PM, brakmo wrote: > + > +static __always_inline void get_nrm_pkt_info(struct bpf_sock *sk, > + struct nrm_pkt_info *pkti)

[net-next 11/11] net/mlx5: E-Switch, Disable esw manager vport correctly

2019-02-19 Thread Saeed Mahameed
From: Bodong Wang When disabling vport, relevant vport configurations will be cleaned up. These cleanups should be done to the vports which had these configs applied at vport enablement. As esw manager vport didn't have such vport config applied, cleanup should not touch it. Fixes: de9e6a8136c5

[net-next 06/11] net/mlx5e: Remove 'parse_attr' argument in mlx5e_tc_add_fdb_flow()

2019-02-19 Thread Saeed Mahameed
From: Tonghao Zhang This patch is a little improvement. Simplify the mlx5e_tc_add_fdb_flow(). Signed-off-by: Tonghao Zhang Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/et

[net-next 07/11] net/mlx5e: Add missing static function annotation

2019-02-19 Thread Saeed Mahameed
From: Leon Romanovsky Compilation with W=1 produces following warning: drivers/net/ethernet/mellanox/mlx5/core/en/monitor_stats.c:69:6: warning: no previous prototype for _mlx5e_monitor_counter_start_ [-Wmissing-prototypes] void mlx5e_monitor_counter_start(struct mlx5e_priv *priv) ^~

[net-next 02/11] net/mlx5: ethtool, Add ethtool support for 50Gbps per lane link modes

2019-02-19 Thread Saeed Mahameed
From: Aya Levin In previous patch, driver added new speed modes: 50Gbps per lane support for 50G/100G/200G. This patch modifies mlx5e_get_link_ksettings and mlx5e_set_link_ksettings to set and get these link modes via ethtool. In order to do so, added mapping of new HW bits to ethtool bitmap and

[net-next 10/11] net/mlx5: E-Switch, Fix the warning on vport index out of range

2019-02-19 Thread Saeed Mahameed
From: Bodong Wang When eswitch gets vport data structure, the index should not be out of the range of the vport array. Driver mistakenly used vport number to check the range. Fixes: 22b8ddc86bf4 ("net/mlx5: E-Switch, Assign a different position for uplink rep and vport") Signed-off-by: Bodong W

[net-next 08/11] net/mlx5: Delete unused FPGA QPN variable

2019-02-19 Thread Saeed Mahameed
From: Leon Romanovsky fpga_qpn was assigned but never used and compilation with W=1 produced the following warning: drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c: In function _mlx5_fpga_event_: drivers/net/ethernet/mellanox/mlx5/core/fpga/core.c:320:6: warning: variable _fpga_qpn_ set but

[net-next 04/11] net/mlx5e: Remove wrong and superfluous tc pedit header type check

2019-02-19 Thread Saeed Mahameed
From: Vlad Buslov With recent introduction of flow_rule infrastructure drivers no longer directly include action headers, so it is no longer possible to use constants defined in them. Instead, one of flow_rule patches substituted pedit action header constant with hardcoded value '2' in mlx5 set_p

[net-next 09/11] net/mlx5e: Remove unused variable ‘esw’

2019-02-19 Thread Saeed Mahameed
Fix the following compiler warning: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:2770: warning: unused variable ‘esw’ [-Wunused-variable] Fixes: 1cd3ab86b713 ("net/mlx5e: Introduce mlx5e_flow_esw_attr_init() helper") Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/e

[net-next 03/11] net/mlx5e: Wrap the open and apply of channels in one fail-safe function

2019-02-19 Thread Saeed Mahameed
From: Tariq Toukan Take into a function the common code structure of opening a side set of channels followed by a call to apply them. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 6 +-- .../ethernet/mellanox/mlx5/core/en_dcbnl.

[net-next 05/11] net/mlx5e: Introduce mlx5e_flow_esw_attr_init() helper

2019-02-19 Thread Saeed Mahameed
From: Tonghao Zhang Introduce the mlx5e_flow_esw_attr_init() helper for simplifying codes. Signed-off-by: Tonghao Zhang Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_tc.c | 41 +-- 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/dri

  1   2   3   >