[PATCH net] vhost: correctly check the return value of translate_desc() in log_used()

2019-02-14 Thread Jason Wang
When fail, translate_desc() returns negative value, otherwise the number of iovs. So we should fail when the return value is negative instead of a blindly check against zero. Reported-by: Stephen Hemminger Fixes: cc5e71075947 ("vhost: log dirty page correctly") Signed-off-by: Jason Wang --- dri

Re: [PATCH 5/9] perf, bpf: save bpf_prog_info in a rbtree in perf_env

2019-02-14 Thread Jiri Olsa
On Thu, Feb 14, 2019 at 05:03:03PM +, Song Liu wrote: > > > > On Feb 14, 2019, at 4:33 AM, Jiri Olsa wrote: > > > > On Fri, Feb 08, 2019 at 05:17:01PM -0800, Song Liu wrote: > >> bpf_prog_info contains information necessary to annotate bpf programs. > >> This patch saves bpf_prog_info for b

Re: [PATCH bpf-next 2/4] libbpf: Support 32-bit static data loads

2019-02-14 Thread Joe Stringer
On Thu, 14 Feb 2019 at 21:39, Y Song wrote: > > On Mon, Feb 11, 2019 at 4:48 PM Joe Stringer wrote: > > > > Support loads of static 32-bit data when BPF writers make use of > > convenience macros for accessing static global data variables. A later > > patch in this series will demonstrate its usa

Re: general protection fault in prepare_to_wait

2019-02-14 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:23e93c9b2cde Revert "gfs2: read journal in large chunks to.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14e94014c0 kernel config: https://syzkaller.appspot.com/x/.config?x=ee4345

Re: [PATCH bpf-next 2/4] libbpf: Support 32-bit static data loads

2019-02-14 Thread Y Song
On Mon, Feb 11, 2019 at 4:48 PM Joe Stringer wrote: > > Support loads of static 32-bit data when BPF writers make use of > convenience macros for accessing static global data variables. A later > patch in this series will demonstrate its usage in a selftest. > > As of LLVM-7, this technique only w

Re: KASAN: use-after-free Read in lock_sock_nested

2019-02-14 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:b3418f8bddf4 Add linux-next specific files for 20190214 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=14f6304740 kernel config: https://syzkaller.appspot.com/x/.config?x

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-14 Thread Dominique Martinet
Tom Herbert wrote on Thu, Feb 14, 2019: > On Thu, Feb 14, 2019 at 7:31 PM Dominique Martinet > wrote: > > Yes, the parser fails with -ENOMEM ; that is not handled gracefully at > > all: from a user point of view, the connection just hangs (recvmsg never > > returns), without so much as a message i

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-14 Thread Tom Herbert
On Thu, Feb 14, 2019 at 7:31 PM Dominique Martinet wrote: > > Tom Herbert wrote on Thu, Feb 14, 2019: > > > This second patch[2] (the current thread) now does an extra clone if > > > there is an offset, but the problem really isn't in the clone but the > > > pull itself that can fail and return NU

Re: dead code in vhost.c

2019-02-14 Thread Jason Wang
On 2019/2/15 上午12:03, Stephen Hemminger wrote: Coverity found this obvious bug *** CID 1442593: Control flow issues (DEADCODE) /drivers/vhost/vhost.c: 1795 in log_used() 1789r

Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-02-14 Thread Joel Fernandes
On Thu, Feb 14, 2019 at 07:19:29PM -0800, Alexei Starovoitov wrote: > On Mon, Feb 11, 2019 at 09:35:59AM -0500, Joel Fernandes (Google) wrote: > > Introduce in-kernel headers and other artifacts which are made available > > as an archive through proc (/proc/kheaders.txz file). This archive makes >

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-14 Thread Dominique Martinet
Tom Herbert wrote on Thu, Feb 14, 2019: > > This second patch[2] (the current thread) now does an extra clone if > > there is an offset, but the problem really isn't in the clone but the > > pull itself that can fail and return NULL when there is memory pressure. > > For some reason I hadn't been a

Re: [PATCH v2 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-02-14 Thread Alexei Starovoitov
On Mon, Feb 11, 2019 at 09:35:59AM -0500, Joel Fernandes (Google) wrote: > Introduce in-kernel headers and other artifacts which are made available > as an archive through proc (/proc/kheaders.txz file). This archive makes > it possible to build kernel modules, run eBPF programs, and other > tracin

Re: bpf: test_tunnel.sh: BUG: unable to handle kernel NULL pointer dereference

2019-02-14 Thread Alexei Starovoitov
On Mon, Feb 11, 2019 at 04:39:50PM +, Alan Maguire wrote: > On Fri, 1 Feb 2019, Naresh Kamboju wrote: > > > Kernel panic while running bpf: test_tunnel.sh on linux -next > > 5.0.0-rc4-next-20190129. > > > > selftests: bpf: test_tunnel.sh > > [ 273.997647] IPv6: ADDRCONF(NETDEV_CHANGE): veth1

Re: Question on ptr_ring linux header

2019-02-14 Thread fei phung
Hi Michael, > If I had to guess I'd say the way you play with indices is probably racy > so you are producing an invalid index. You are probably right. I am suspecting item_recv_push_index and item_send_push_index in https://gist.github.com/promach/7716ee8addcaa33fda140d74d1ad94d6#file-riffa_dri

Re: r8169 Driver - Poor Network Performance Since Kernel 4.19

2019-02-14 Thread David Chang
Hi Heiner, On Feb 14, 2019 at 07:17:44 +0100, Heiner Kallweit wrote: > Hi David, > > On 14.02.2019 03:45, David Chang wrote: > > Hi Heiner, > > > > On Feb 05, 2019 at 19:50:30 +0100, Heiner Kallweit wrote: > >> Hi David, > >> > >> meanwhile there's the following bug report matching what reported

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-14 Thread Tom Herbert
On Thu, Feb 14, 2019 at 5:57 PM Dominique Martinet wrote: > > Tom Herbert wrote on Thu, Feb 14, 2019: > > > The best alternative I see is adding a proper helper to get > > > "kcm_rx_msg(skb)->offset" from bpf and document it so users aren't as > > > lost as I have been; I'm not quite sure how/wher

[PATCH AUTOSEL 4.20 36/77] mac80211: fix miscounting of ttl-dropped frames

2019-02-14 Thread Sasha Levin
From: Bob Copeland [ Upstream commit a0dc02039a2ee54fb4ae400e0b755ed30e73e58c ] In ieee80211_rx_h_mesh_fwding, we increment the 'dropped_frames_ttl' counter when we decrement the ttl to zero. For unicast frames destined for other hosts, we stop processing the frame at that point. For multicast

[PATCH AUTOSEL 4.20 41/77] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive()

2019-02-14 Thread Sasha Levin
From: Ilya Dryomov [ Upstream commit 4aac9228d16458cedcfd90c7fb37211cf3653ac3 ] con_fault() can transition the connection into STANDBY right after ceph_con_keepalive() clears STANDBY in clear_standby(): libceph user thread ceph-msgr worker ceph_con_keepalive() mutex_lock(&c

[PATCH AUTOSEL 4.20 55/77] hv_netvsc: Fix ethtool change hash key error

2019-02-14 Thread Sasha Levin
From: Haiyang Zhang [ Upstream commit b4a10c750424e01b5e37372fef0a574ebf7b56c3 ] Hyper-V hosts require us to disable RSS before changing RSS key, otherwise the changing request will fail. This patch fixes the coding error. Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") R

[PATCH AUTOSEL 4.20 57/77] hv_netvsc: Fix hash key value reset after other ops

2019-02-14 Thread Sasha Levin
From: Haiyang Zhang [ Upstream commit 17d91256898402daf4425cc541ac9cbf64574d9a ] Changing mtu, channels, or buffer sizes ops call to netvsc_attach(), rndis_set_subchannel(), which always reset the hash key to default value. That will override hash key changed previously. This patch fixes the pro

[PATCH AUTOSEL 4.20 54/77] net: altera_tse: fix connect_local_phy error path

2019-02-14 Thread Sasha Levin
From: Atsushi Nemoto [ Upstream commit 17b42a20d7ca59377788c6a2409e77569570cc10 ] The connect_local_phy should return NULL (not negative errno) on error, since its caller expects it. Signed-off-by: Atsushi Nemoto Acked-by: Thor Thayer Signed-off-by: David S. Miller Signed-off-by: Sasha Levin

[PATCH AUTOSEL 4.20 56/77] hv_netvsc: Refactor assignments of struct netvsc_device_info

2019-02-14 Thread Sasha Levin
From: Haiyang Zhang [ Upstream commit 7c9f335a3ff20557a92584199f3d35c7e992bbe5 ] These assignments occur in multiple places. The patch refactor them to a function for simplicity. It also puts the struct to heap area for future expension. Signed-off-by: Haiyang Zhang Reviewed-by: Michael Kelley

[PATCH AUTOSEL 4.20 58/77] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe

2019-02-14 Thread Sasha Levin
From: Edward Cree [ Upstream commit 3366463513f544c12c6b88c13da4462ee9e7a1a1 ] Use a bitmap to keep track of which partition types we've already seen; for duplicates, return -EEXIST from efx_ef10_mtd_probe_partition() and thus skip adding that partition. Duplicate partitions occur because of t

[PATCH AUTOSEL 4.20 67/77] net: usb: asix: ax88772_bind return error when hw_reset fail

2019-02-14 Thread Sasha Levin
From: Zhang Run [ Upstream commit 6eea3527e68acc22483f4763c8682f223eb90029 ] The ax88772_bind() should return error code immediately when the PHY was not reset properly through ax88772a_hw_reset(). Otherwise, The asix_get_phyid() will block when get the PHY Identifier from the PHYSID1 MII regist

[PATCH AUTOSEL 4.20 69/77] ibmveth: Do not process frames after calling napi_reschedule

2019-02-14 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instea

[PATCH AUTOSEL 4.20 68/77] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

2019-02-14 Thread Sasha Levin
From: Maciej Żenczykowski [ Upstream commit 3b707c3008cad04604c1f50e39f456621821c414 ] __bpf_redirect() and act_mirred checks this boolean to determine whether to prefix an ethernet header. Signed-off-by: Maciej Żenczykowski Acked-by: Daniel Borkmann Signed-off-by: David S. Miller Signed-off

[PATCH AUTOSEL 4.20 70/77] mac80211: don't initiate TDLS connection if station is not associated to AP

2019-02-14 Thread Sasha Levin
From: Balaji Pothunoori [ Upstream commit 7ed5285396c257fd4070b1e29e7b2341aae2a1ce ] Following call trace is observed while adding TDLS peer entry in driver during TDLS setup. Call Trace: [] dump_stack+0x47/0x61 [] __warn+0xe2/0x100 [] ? sta_apply_parameters+0x49f/0x550 [mac80211] [] warn_slowp

[PATCH AUTOSEL 4.20 71/77] mac80211: Add attribute aligned(2) to struct 'action'

2019-02-14 Thread Sasha Levin
From: Mathieu Malaterre [ Upstream commit 7c53eb5d87bc21464da4268c3c0c47457b6d9c9b ] During refactor in commit 9e478066eae4 ("mac80211: fix MU-MIMO follow-MAC mode") a new struct 'action' was declared with packed attribute as: struct { struct ieee80211_hdr_3addr hdr; u8 ca

[PATCH AUTOSEL 4.20 72/77] cfg80211: extend range deviation for DMG

2019-02-14 Thread Sasha Levin
From: Chaitanya Tata [ Upstream commit 93183bdbe73bbdd03e9566c8dc37c9d06b0d0db6 ] Recently, DMG frequency bands have been extended till 71GHz, so extend the range check till 20GHz (45-71GHZ), else some channels will be marked as disabled. Signed-off-by: Chaitanya Tata Signed-off-by: Johannes B

[PATCH AUTOSEL 4.19 29/65] mac80211: fix miscounting of ttl-dropped frames

2019-02-14 Thread Sasha Levin
From: Bob Copeland [ Upstream commit a0dc02039a2ee54fb4ae400e0b755ed30e73e58c ] In ieee80211_rx_h_mesh_fwding, we increment the 'dropped_frames_ttl' counter when we decrement the ttl to zero. For unicast frames destined for other hosts, we stop processing the frame at that point. For multicast

[PATCH AUTOSEL 4.19 34/65] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive()

2019-02-14 Thread Sasha Levin
From: Ilya Dryomov [ Upstream commit 4aac9228d16458cedcfd90c7fb37211cf3653ac3 ] con_fault() can transition the connection into STANDBY right after ceph_con_keepalive() clears STANDBY in clear_standby(): libceph user thread ceph-msgr worker ceph_con_keepalive() mutex_lock(&c

[PATCH AUTOSEL 4.19 46/65] net: altera_tse: fix connect_local_phy error path

2019-02-14 Thread Sasha Levin
From: Atsushi Nemoto [ Upstream commit 17b42a20d7ca59377788c6a2409e77569570cc10 ] The connect_local_phy should return NULL (not negative errno) on error, since its caller expects it. Signed-off-by: Atsushi Nemoto Acked-by: Thor Thayer Signed-off-by: David S. Miller Signed-off-by: Sasha Levin

[PATCH AUTOSEL 4.19 49/65] hv_netvsc: Fix hash key value reset after other ops

2019-02-14 Thread Sasha Levin
From: Haiyang Zhang [ Upstream commit 17d91256898402daf4425cc541ac9cbf64574d9a ] Changing mtu, channels, or buffer sizes ops call to netvsc_attach(), rndis_set_subchannel(), which always reset the hash key to default value. That will override hash key changed previously. This patch fixes the pro

[PATCH AUTOSEL 4.19 48/65] hv_netvsc: Refactor assignments of struct netvsc_device_info

2019-02-14 Thread Sasha Levin
From: Haiyang Zhang [ Upstream commit 7c9f335a3ff20557a92584199f3d35c7e992bbe5 ] These assignments occur in multiple places. The patch refactor them to a function for simplicity. It also puts the struct to heap area for future expension. Signed-off-by: Haiyang Zhang Reviewed-by: Michael Kelley

[PATCH AUTOSEL 4.19 50/65] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe

2019-02-14 Thread Sasha Levin
From: Edward Cree [ Upstream commit 3366463513f544c12c6b88c13da4462ee9e7a1a1 ] Use a bitmap to keep track of which partition types we've already seen; for duplicates, return -EEXIST from efx_ef10_mtd_probe_partition() and thus skip adding that partition. Duplicate partitions occur because of t

[PATCH AUTOSEL 4.19 47/65] hv_netvsc: Fix ethtool change hash key error

2019-02-14 Thread Sasha Levin
From: Haiyang Zhang [ Upstream commit b4a10c750424e01b5e37372fef0a574ebf7b56c3 ] Hyper-V hosts require us to disable RSS before changing RSS key, otherwise the changing request will fail. This patch fixes the coding error. Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") R

[PATCH AUTOSEL 4.19 58/65] ibmveth: Do not process frames after calling napi_reschedule

2019-02-14 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instea

[PATCH AUTOSEL 4.19 57/65] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

2019-02-14 Thread Sasha Levin
From: Maciej Żenczykowski [ Upstream commit 3b707c3008cad04604c1f50e39f456621821c414 ] __bpf_redirect() and act_mirred checks this boolean to determine whether to prefix an ethernet header. Signed-off-by: Maciej Żenczykowski Acked-by: Daniel Borkmann Signed-off-by: David S. Miller Signed-off

[PATCH RFC net-next] 6lowpan: use rbtree for IP frag queue

2019-02-14 Thread Peter Oskolkov
This patch aligns IP defragmenation logic in 6lowpan with that of IPv4 and IPv6: see commit d4289fcc9b16 ("net: IP6 defrag: use rbtrees for IPv6 defrag") Modifying ip_defrag selftest seemed like an overkill, as I suspect most kernel test setups do not have 6lowpan hwsim enabled. So I ran the follo

[PATCH AUTOSEL 4.19 59/65] mac80211: don't initiate TDLS connection if station is not associated to AP

2019-02-14 Thread Sasha Levin
From: Balaji Pothunoori [ Upstream commit 7ed5285396c257fd4070b1e29e7b2341aae2a1ce ] Following call trace is observed while adding TDLS peer entry in driver during TDLS setup. Call Trace: [] dump_stack+0x47/0x61 [] __warn+0xe2/0x100 [] ? sta_apply_parameters+0x49f/0x550 [mac80211] [] warn_slowp

[PATCH AUTOSEL 4.19 51/65] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[PATCH AUTOSEL 4.19 56/65] net: usb: asix: ax88772_bind return error when hw_reset fail

2019-02-14 Thread Sasha Levin
From: Zhang Run [ Upstream commit 6eea3527e68acc22483f4763c8682f223eb90029 ] The ax88772_bind() should return error code immediately when the PHY was not reset properly through ax88772a_hw_reset(). Otherwise, The asix_get_phyid() will block when get the PHY Identifier from the PHYSID1 MII regist

[PATCH AUTOSEL 4.19 60/65] mac80211: Add attribute aligned(2) to struct 'action'

2019-02-14 Thread Sasha Levin
From: Mathieu Malaterre [ Upstream commit 7c53eb5d87bc21464da4268c3c0c47457b6d9c9b ] During refactor in commit 9e478066eae4 ("mac80211: fix MU-MIMO follow-MAC mode") a new struct 'action' was declared with packed attribute as: struct { struct ieee80211_hdr_3addr hdr; u8 ca

[PATCH AUTOSEL 4.14 22/40] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive()

2019-02-14 Thread Sasha Levin
From: Ilya Dryomov [ Upstream commit 4aac9228d16458cedcfd90c7fb37211cf3653ac3 ] con_fault() can transition the connection into STANDBY right after ceph_con_keepalive() clears STANDBY in clear_standby(): libceph user thread ceph-msgr worker ceph_con_keepalive() mutex_lock(&c

Re: [PATCH net-next] net: dsa: bcm_sf2: Remove set but not used variables 'v6_spec, v6_m_spec'

2019-02-14 Thread YueHaibing
+CC davem On 2019/2/15 10:36, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/dsa/bcm_sf2_cfp.c: In function 'bcm_sf2_cfp_ipv6_rule_set': > drivers/net/dsa/bcm_sf2_cfp.c:606:40: warning: > variable 'v6_m_spec' set but not used [-Wunused-but-set-variable] > driv

[PATCH AUTOSEL 4.14 34/40] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP

2019-02-14 Thread Sasha Levin
From: Maciej Żenczykowski [ Upstream commit 3b707c3008cad04604c1f50e39f456621821c414 ] __bpf_redirect() and act_mirred checks this boolean to determine whether to prefix an ethernet header. Signed-off-by: Maciej Żenczykowski Acked-by: Daniel Borkmann Signed-off-by: David S. Miller Signed-off

[PATCH AUTOSEL 4.14 32/40] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[PATCH AUTOSEL 4.14 31/40] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe

2019-02-14 Thread Sasha Levin
From: Edward Cree [ Upstream commit 3366463513f544c12c6b88c13da4462ee9e7a1a1 ] Use a bitmap to keep track of which partition types we've already seen; for duplicates, return -EEXIST from efx_ef10_mtd_probe_partition() and thus skip adding that partition. Duplicate partitions occur because of t

[PATCH AUTOSEL 4.14 29/40] net: altera_tse: fix connect_local_phy error path

2019-02-14 Thread Sasha Levin
From: Atsushi Nemoto [ Upstream commit 17b42a20d7ca59377788c6a2409e77569570cc10 ] The connect_local_phy should return NULL (not negative errno) on error, since its caller expects it. Signed-off-by: Atsushi Nemoto Acked-by: Thor Thayer Signed-off-by: David S. Miller Signed-off-by: Sasha Levin

[PATCH AUTOSEL 4.14 35/40] ibmveth: Do not process frames after calling napi_reschedule

2019-02-14 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instea

[PATCH AUTOSEL 4.14 38/40] cfg80211: extend range deviation for DMG

2019-02-14 Thread Sasha Levin
From: Chaitanya Tata [ Upstream commit 93183bdbe73bbdd03e9566c8dc37c9d06b0d0db6 ] Recently, DMG frequency bands have been extended till 71GHz, so extend the range check till 20GHz (45-71GHZ), else some channels will be marked as disabled. Signed-off-by: Chaitanya Tata Signed-off-by: Johannes B

[PATCH AUTOSEL 4.14 37/40] mac80211: Add attribute aligned(2) to struct 'action'

2019-02-14 Thread Sasha Levin
From: Mathieu Malaterre [ Upstream commit 7c53eb5d87bc21464da4268c3c0c47457b6d9c9b ] During refactor in commit 9e478066eae4 ("mac80211: fix MU-MIMO follow-MAC mode") a new struct 'action' was declared with packed attribute as: struct { struct ieee80211_hdr_3addr hdr; u8 ca

[PATCH net-next] net: dsa: bcm_sf2: Remove set but not used variables 'v6_spec, v6_m_spec'

2019-02-14 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/dsa/bcm_sf2_cfp.c: In function 'bcm_sf2_cfp_ipv6_rule_set': drivers/net/dsa/bcm_sf2_cfp.c:606:40: warning: variable 'v6_m_spec' set but not used [-Wunused-but-set-variable] drivers/net/dsa/bcm_sf2_cfp.c:606:30: warning: variable 'v6_spec

[PATCH AUTOSEL 4.9 19/27] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe

2019-02-14 Thread Sasha Levin
From: Edward Cree [ Upstream commit 3366463513f544c12c6b88c13da4462ee9e7a1a1 ] Use a bitmap to keep track of which partition types we've already seen; for duplicates, return -EEXIST from efx_ef10_mtd_probe_partition() and thus skip adding that partition. Duplicate partitions occur because of t

[PATCH AUTOSEL 4.9 14/27] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive()

2019-02-14 Thread Sasha Levin
From: Ilya Dryomov [ Upstream commit 4aac9228d16458cedcfd90c7fb37211cf3653ac3 ] con_fault() can transition the connection into STANDBY right after ceph_con_keepalive() clears STANDBY in clear_standby(): libceph user thread ceph-msgr worker ceph_con_keepalive() mutex_lock(&c

[PATCH AUTOSEL 4.9 12/27] mac80211: fix miscounting of ttl-dropped frames

2019-02-14 Thread Sasha Levin
From: Bob Copeland [ Upstream commit a0dc02039a2ee54fb4ae400e0b755ed30e73e58c ] In ieee80211_rx_h_mesh_fwding, we increment the 'dropped_frames_ttl' counter when we decrement the ttl to zero. For unicast frames destined for other hosts, we stop processing the frame at that point. For multicast

[PATCH AUTOSEL 4.9 18/27] net: altera_tse: fix connect_local_phy error path

2019-02-14 Thread Sasha Levin
From: Atsushi Nemoto [ Upstream commit 17b42a20d7ca59377788c6a2409e77569570cc10 ] The connect_local_phy should return NULL (not negative errno) on error, since its caller expects it. Signed-off-by: Atsushi Nemoto Acked-by: Thor Thayer Signed-off-by: David S. Miller Signed-off-by: Sasha Levin

[PATCH AUTOSEL 4.9 25/27] cfg80211: extend range deviation for DMG

2019-02-14 Thread Sasha Levin
From: Chaitanya Tata [ Upstream commit 93183bdbe73bbdd03e9566c8dc37c9d06b0d0db6 ] Recently, DMG frequency bands have been extended till 71GHz, so extend the range check till 20GHz (45-71GHZ), else some channels will be marked as disabled. Signed-off-by: Chaitanya Tata Signed-off-by: Johannes B

[PATCH AUTOSEL 4.9 20/27] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[PATCH AUTOSEL 4.9 23/27] mac80211: don't initiate TDLS connection if station is not associated to AP

2019-02-14 Thread Sasha Levin
From: Balaji Pothunoori [ Upstream commit 7ed5285396c257fd4070b1e29e7b2341aae2a1ce ] Following call trace is observed while adding TDLS peer entry in driver during TDLS setup. Call Trace: [] dump_stack+0x47/0x61 [] __warn+0xe2/0x100 [] ? sta_apply_parameters+0x49f/0x550 [mac80211] [] warn_slowp

[PATCH AUTOSEL 4.9 24/27] mac80211: Add attribute aligned(2) to struct 'action'

2019-02-14 Thread Sasha Levin
From: Mathieu Malaterre [ Upstream commit 7c53eb5d87bc21464da4268c3c0c47457b6d9c9b ] During refactor in commit 9e478066eae4 ("mac80211: fix MU-MIMO follow-MAC mode") a new struct 'action' was declared with packed attribute as: struct { struct ieee80211_hdr_3addr hdr; u8 ca

[PATCH AUTOSEL 4.9 22/27] ibmveth: Do not process frames after calling napi_reschedule

2019-02-14 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instea

linux-next: manual merge of the tip tree with the net-next tree

2019-02-14 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tip tree got a conflict in: include/uapi/linux/time.h between commits: bcb3fc3247e5 ("arch: sparc: Override struct __kernel_old_timeval") ca5e9aba753e ("time: Add time_types.h") from the net-next tree and commit: c70a772fda11 ("y2038: remove str

[PATCH AUTOSEL 4.4 14/20] net: altera_tse: fix connect_local_phy error path

2019-02-14 Thread Sasha Levin
From: Atsushi Nemoto [ Upstream commit 17b42a20d7ca59377788c6a2409e77569570cc10 ] The connect_local_phy should return NULL (not negative errno) on error, since its caller expects it. Signed-off-by: Atsushi Nemoto Acked-by: Thor Thayer Signed-off-by: David S. Miller Signed-off-by: Sasha Levin

[PATCH AUTOSEL 4.4 15/20] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe

2019-02-14 Thread Sasha Levin
From: Edward Cree [ Upstream commit 3366463513f544c12c6b88c13da4462ee9e7a1a1 ] Use a bitmap to keep track of which partition types we've already seen; for duplicates, return -EEXIST from efx_ef10_mtd_probe_partition() and thus skip adding that partition. Duplicate partitions occur because of t

[PATCH AUTOSEL 4.4 11/20] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive()

2019-02-14 Thread Sasha Levin
From: Ilya Dryomov [ Upstream commit 4aac9228d16458cedcfd90c7fb37211cf3653ac3 ] con_fault() can transition the connection into STANDBY right after ceph_con_keepalive() clears STANDBY in clear_standby(): libceph user thread ceph-msgr worker ceph_con_keepalive() mutex_lock(&c

[PATCH AUTOSEL 4.4 16/20] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[PATCH AUTOSEL 4.4 10/20] mac80211: fix miscounting of ttl-dropped frames

2019-02-14 Thread Sasha Levin
From: Bob Copeland [ Upstream commit a0dc02039a2ee54fb4ae400e0b755ed30e73e58c ] In ieee80211_rx_h_mesh_fwding, we increment the 'dropped_frames_ttl' counter when we decrement the ttl to zero. For unicast frames destined for other hosts, we stop processing the frame at that point. For multicast

[PATCH AUTOSEL 4.4 17/20] ibmveth: Do not process frames after calling napi_reschedule

2019-02-14 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instea

[PATCH AUTOSEL 4.4 18/20] mac80211: don't initiate TDLS connection if station is not associated to AP

2019-02-14 Thread Sasha Levin
From: Balaji Pothunoori [ Upstream commit 7ed5285396c257fd4070b1e29e7b2341aae2a1ce ] Following call trace is observed while adding TDLS peer entry in driver during TDLS setup. Call Trace: [] dump_stack+0x47/0x61 [] __warn+0xe2/0x100 [] ? sta_apply_parameters+0x49f/0x550 [mac80211] [] warn_slowp

[PATCH AUTOSEL 4.4 19/20] cfg80211: extend range deviation for DMG

2019-02-14 Thread Sasha Levin
From: Chaitanya Tata [ Upstream commit 93183bdbe73bbdd03e9566c8dc37c9d06b0d0db6 ] Recently, DMG frequency bands have been extended till 71GHz, so extend the range check till 20GHz (45-71GHZ), else some channels will be marked as disabled. Signed-off-by: Chaitanya Tata Signed-off-by: Johannes B

[PATCH AUTOSEL 3.18 07/16] mac80211: fix miscounting of ttl-dropped frames

2019-02-14 Thread Sasha Levin
From: Bob Copeland [ Upstream commit a0dc02039a2ee54fb4ae400e0b755ed30e73e58c ] In ieee80211_rx_h_mesh_fwding, we increment the 'dropped_frames_ttl' counter when we decrement the ttl to zero. For unicast frames destined for other hosts, we stop processing the frame at that point. For multicast

[PATCH AUTOSEL 3.18 11/16] net: altera_tse: fix connect_local_phy error path

2019-02-14 Thread Sasha Levin
From: Atsushi Nemoto [ Upstream commit 17b42a20d7ca59377788c6a2409e77569570cc10 ] The connect_local_phy should return NULL (not negative errno) on error, since its caller expects it. Signed-off-by: Atsushi Nemoto Acked-by: Thor Thayer Signed-off-by: David S. Miller Signed-off-by: Sasha Levin

[PATCH AUTOSEL 3.18 08/16] libceph: avoid KEEPALIVE_PENDING races in ceph_con_keepalive()

2019-02-14 Thread Sasha Levin
From: Ilya Dryomov [ Upstream commit 4aac9228d16458cedcfd90c7fb37211cf3653ac3 ] con_fault() can transition the connection into STANDBY right after ceph_con_keepalive() clears STANDBY in clear_standby(): libceph user thread ceph-msgr worker ceph_con_keepalive() mutex_lock(&c

[PATCH AUTOSEL 3.18 12/16] sfc: suppress duplicate nvmem partition types in efx_ef10_mtd_probe

2019-02-14 Thread Sasha Levin
From: Edward Cree [ Upstream commit 3366463513f544c12c6b88c13da4462ee9e7a1a1 ] Use a bitmap to keep track of which partition types we've already seen; for duplicates, return -EEXIST from efx_ef10_mtd_probe_partition() and thus skip adding that partition. Duplicate partitions occur because of t

[PATCH AUTOSEL 3.18 13/16] ibmveth: Do not process frames after calling napi_reschedule

2019-02-14 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ] The IBM virtual ethernet driver's polling function continues to process frames after rescheduling NAPI, resulting in a warning if it exhausted its budget. Do not restart polling after calling napi_reschedule. Instea

[PATCH AUTOSEL 3.18 14/16] mac80211: don't initiate TDLS connection if station is not associated to AP

2019-02-14 Thread Sasha Levin
From: Balaji Pothunoori [ Upstream commit 7ed5285396c257fd4070b1e29e7b2341aae2a1ce ] Following call trace is observed while adding TDLS peer entry in driver during TDLS setup. Call Trace: [] dump_stack+0x47/0x61 [] __warn+0xe2/0x100 [] ? sta_apply_parameters+0x49f/0x550 [mac80211] [] warn_slowp

[PATCH AUTOSEL 3.18 15/16] cfg80211: extend range deviation for DMG

2019-02-14 Thread Sasha Levin
From: Chaitanya Tata [ Upstream commit 93183bdbe73bbdd03e9566c8dc37c9d06b0d0db6 ] Recently, DMG frequency bands have been extended till 71GHz, so extend the range check till 20GHz (45-71GHZ), else some channels will be marked as disabled. Signed-off-by: Chaitanya Tata Signed-off-by: Johannes B

[PATCH AUTOSEL 4.9 21/27] net: usb: asix: ax88772_bind return error when hw_reset fail

2019-02-14 Thread Sasha Levin
From: Zhang Run [ Upstream commit 6eea3527e68acc22483f4763c8682f223eb90029 ] The ax88772_bind() should return error code immediately when the PHY was not reset properly through ax88772a_hw_reset(). Otherwise, The asix_get_phyid() will block when get the PHY Identifier from the PHYSID1 MII regist

[PATCH AUTOSEL 4.14 33/40] net: usb: asix: ax88772_bind return error when hw_reset fail

2019-02-14 Thread Sasha Levin
From: Zhang Run [ Upstream commit 6eea3527e68acc22483f4763c8682f223eb90029 ] The ax88772_bind() should return error code immediately when the PHY was not reset properly through ax88772a_hw_reset(). Otherwise, The asix_get_phyid() will block when get the PHY Identifier from the PHYSID1 MII regist

[PATCH AUTOSEL 4.14 30/40] hv_netvsc: Fix ethtool change hash key error

2019-02-14 Thread Sasha Levin
From: Haiyang Zhang [ Upstream commit b4a10c750424e01b5e37372fef0a574ebf7b56c3 ] Hyper-V hosts require us to disable RSS before changing RSS key, otherwise the changing request will fail. This patch fixes the coding error. Fixes: ff4a44199012 ("netvsc: allow get/set of RSS indirection table") R

[PATCH AUTOSEL 4.14 36/40] mac80211: don't initiate TDLS connection if station is not associated to AP

2019-02-14 Thread Sasha Levin
From: Balaji Pothunoori [ Upstream commit 7ed5285396c257fd4070b1e29e7b2341aae2a1ce ] Following call trace is observed while adding TDLS peer entry in driver during TDLS setup. Call Trace: [] dump_stack+0x47/0x61 [] __warn+0xe2/0x100 [] ? sta_apply_parameters+0x49f/0x550 [mac80211] [] warn_slowp

[PATCH AUTOSEL 4.14 18/40] mac80211: fix miscounting of ttl-dropped frames

2019-02-14 Thread Sasha Levin
From: Bob Copeland [ Upstream commit a0dc02039a2ee54fb4ae400e0b755ed30e73e58c ] In ieee80211_rx_h_mesh_fwding, we increment the 'dropped_frames_ttl' counter when we decrement the ttl to zero. For unicast frames destined for other hosts, we stop processing the frame at that point. For multicast

[PATCH AUTOSEL 4.19 61/65] cfg80211: extend range deviation for DMG

2019-02-14 Thread Sasha Levin
From: Chaitanya Tata [ Upstream commit 93183bdbe73bbdd03e9566c8dc37c9d06b0d0db6 ] Recently, DMG frequency bands have been extended till 71GHz, so extend the range check till 20GHz (45-71GHZ), else some channels will be marked as disabled. Signed-off-by: Chaitanya Tata Signed-off-by: Johannes B

[PATCH AUTOSEL 4.20 59/77] ax25: fix possible use-after-free

2019-02-14 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 63530aba7826a0f8e129874df9c4d264f9db3f9e ] syzbot found that ax25 routes where not properly protected against concurrent use [1]. In this particular report the bug happened while copying ax25->digipeat. Fix this problem by making sure we call ax25_get_route

[GIT] Networking

2019-02-14 Thread David Miller
1) Fix MAC address setting in mac80211 pmsr code, from Johannes Berg. 2) Probe SFP modules after being attached, from Russell King. 3) Byte ordering bug in SMC rx_curs_confirmed code, from Ursula Braun. 4) Revert some r8169 changes that are causing regressions, from Heiner Kallweit. 5) Fix

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-14 Thread Dominique Martinet
Tom Herbert wrote on Thu, Feb 14, 2019: > > The best alternative I see is adding a proper helper to get > > "kcm_rx_msg(skb)->offset" from bpf and document it so users aren't as > > lost as I have been; I'm not quite sure how/where to add such a helper > > though as I've barely looked at the bpf co

Re: [PATCH bpf-next 2/2] libbpf: Introduce bpf_object__btf

2019-02-14 Thread Yonghong Song
On 2/14/19 3:01 PM, Andrey Ignatov wrote: > Add new accessor for bpf_object to get opaque struct btf * from it. > > struct btf * is needed for all operations with BTF and it's present in > bpf_object. The only thing missing is a way to get it. > > Example use-case is to get BTF key_type_id an v

Re: [PATCH net-next v2] bonding: check slave set command firstly

2019-02-14 Thread David Miller
From: Tonghao Zhang Date: Fri, 15 Feb 2019 09:44:58 +0800 > OK, I format the patch a few days ago, but send it yesterday. Just FYI, you can use various options to git such that it composes the email using the current time rather than the date in the commit itself.

Re: [PATCH bpf-next 1/2] libbpf: Introduce bpf_map__resize

2019-02-14 Thread Yonghong Song
On 2/14/19 3:01 PM, Andrey Ignatov wrote: > Add bpf_map__resize() to change max_entries for a map. > > Quite often necessary map size is unknown at compile time and can be > calculated only at run time. > > Currently the following approach is used to do so: > * bpf_object__open_buffer() to open

Re: [PATCH net-next v2] bonding: check slave set command firstly

2019-02-14 Thread Tonghao Zhang
On Fri, Feb 15, 2019 at 12:36 AM David Miller wrote: > > From: xiangxia.m@gmail.com > Date: Mon, 11 Feb 2019 10:49:48 -0800 > > > From: Tonghao Zhang > > > > This patch is a little improvement. If user use the > > command shown as below, we should print the info [1] > > instead of [2]. The et

Re: (2) (2) [Bug reporting] kernel panic during handle the dst unreach icmp msg.

2019-02-14 Thread Eric Dumazet
On 02/14/2019 05:37 PM, 배석진 wrote: >> The current code checks if icsk->icsk_backoff is not zero, so it looks like >> we have to move >> some code like this. >> >> It looks a silly bug to have no packet in write/rtx queues, and a non zero >> icsk_backoff. >> >> >> >> diff --git a/net/ip

RE:(2) (2) [Bug reporting] kernel panic during handle the dst unreach icmp msg.

2019-02-14 Thread 배석진
> The current code checks if icsk->icsk_backoff is not zero, so it looks like > we have to move > some code like this. > > It looks a silly bug to have no packet in write/rtx queues, and a non zero > icsk_backoff. > > > > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index > 2079145a3b7

RE:(2) (2) [Bug reporting] kernel panic during handle the dst unreach icmp msg.

2019-02-14 Thread 배석진
> > <4>[60392.948306] I[1:ksoftirqd/1: 19] [ cut here > > ] > > <0>[60392.948334] I[1:ksoftirqd/1: 19] kernel BUG at > > net/ipv4/tcp_ipv4.c:519! > > What the code looks like at line 519 of net/ipv4/tcp_ipv4.c ? > > This is not a pristine kernel, anything c

Re: (2) [Bug reporting] kernel panic during handle the dst unreach icmp msg.

2019-02-14 Thread Eric Dumazet
On 02/14/2019 05:08 PM, Eric Dumazet wrote: > > > On 02/14/2019 03:54 PM, 배석진 wrote: >>> I do not believe this patch is needed. >>> >>> You probably hit another more serious bug, but since you do not post the >>> full stack trace >>> it is hard to help. >>> >>> Are you using vti tunnel ?

Re: [PATCH] net: phy: mdio_bus: add missing device_del() in mdiobus_register() error handling

2019-02-14 Thread Andrew Lunn
On Mon, Feb 11, 2019 at 03:31:59PM +0100, Thomas Petazzoni wrote: > Even if DaveM already merged my simple fix, I had a further look at > whether we should be using device_unregister(), and in fact we should > not, but not really for a good reason: because the mdio API is not very > symmetrical. >

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-14 Thread Tom Herbert
On Thu, Feb 14, 2019 at 5:00 PM Dominique Martinet wrote: > > Dominique Martinet wrote on Wed, Oct 31, 2018: > > Anyway, that probably explains I have no problem with bigger VM > > (uselessly more memory available) or without KASAN (I guess there's > > overhead?), but I'm sending at most 300k of d

Re: (2) [Bug reporting] kernel panic during handle the dst unreach icmp msg.

2019-02-14 Thread Eric Dumazet
On 02/14/2019 03:54 PM, 배석진 wrote: >> I do not believe this patch is needed. >> >> You probably hit another more serious bug, but since you do not post the >> full stack trace >> it is hard to help. >> >> Are you using vti tunnel ? > > there's no working logs of vpn/vti/tun on platform or

Re: [PATCH net] net: stmmac: Fix NAPI poll in TX path when in multi-queue

2019-02-14 Thread Florian Fainelli
On 2/14/19 9:01 AM, David Miller wrote: > From: Jose Abreu > Date: Wed, 13 Feb 2019 18:00:43 +0100 > >> Commit 8fce33317023 introduced the concept of NAPI per-channel and >> independent cleaning of TX path. >> >> This is currently breaking performance in some cases. The scenario >> happens when a

Re: [PATCH v2] kcm: remove any offset before parsing messages

2019-02-14 Thread Dominique Martinet
Dominique Martinet wrote on Wed, Oct 31, 2018: > Anyway, that probably explains I have no problem with bigger VM > (uselessly more memory available) or without KASAN (I guess there's > overhead?), but I'm sending at most 300k of data and the VM has a 1.5GB > of ram, so if there's an allocation fail

  1   2   3   4   >