On 1/14/2019 15:29, Konstantin Khlebnikov wrote:
I'm seeing series of e1000e resets (sometimes endless) at system boot
if something generates tx traffic at this time. In my case this is
netconsole who sends message "e1000e :02:00.0: Some CPU C-states
have been disabled in order to enable jumb
On Tue, Jan 15, 2019 at 03:11:28PM +0900, Toshiaki Makita wrote:
> On 2019/01/13 22:59, Zahari Doychev wrote:
> > Use the skb->mac_len instead of using the ETH_HLEN when pushing the skb
> > data pointer. This fixes sending incorrect packets when more than one
> > vlan tags are pushed by tc-vlan and
> commit: b8154ef682a9a745880ecbb2ee26b16297c9bfd0 ("[PATCH net] net:
> phy: phy driver features are mandatory")
> > url:
> > https://github.com/0day-ci/linux/commits/Camelia-Groza/net-phy-phy-driver-features-are-mandatory/20190116-004308
> >
> >
> > in te
Remove duplicated include.
Signed-off-by: YueHaibing
---
include/linux/qed/qed_if.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
index 91c536a..5f818fd 100644
--- a/include/linux/qed/qed_if.h
+++ b/include/linux/qed/qed_if.h
@@ -38,7
From: Tonghao Zhang
Allow default ip_proto to offload, so icmp, tcp, and udp
will match the flow as show below, otherwise we must type the
ip_proto for icmp, tcp and udp respectively.
$ tc filter add dev netdev01_rep parent : protocol ip prio 1 \
flower skip_sw dst_ip 3.3.3.3 \
Remove duplicated include.
Signed-off-by: YueHaibing
---
drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
b/drivers/net/wireless/intel/iwlwifi/mvm/ops.c
index 30c5127..2e5621c 100644
--- a/drivers/net/wi
Kindly Ping...
Best Regards,
Joakim Zhang
> -Original Message-
> From: Joakim Zhang
> Sent: 2018年12月19日 16:39
> To: m...@pengutronix.de; linux-...@vger.kernel.org
> Cc: w...@grandegger.com; netdev@vger.kernel.org;
> linux-ker...@vger.kernel.org; dl-linux-imx ; Joakim
> Zhang
> Subject:
Kindly Ping...
Best Regards,
Joakim Zhang
> -Original Message-
> From: Joakim Zhang
> Sent: 2018年12月12日 14:47
> To: m...@pengutronix.de; linux-...@vger.kernel.org
> Cc: w...@grandegger.com; netdev@vger.kernel.org;
> linux-ker...@vger.kernel.org; dl-linux-imx ; Joakim
> Zhang
> Subject:
Kindly Ping...
Best Regards,
Joakim Zhang
> -Original Message-
> From: Joakim Zhang
> Sent: 2018年11月30日 16:53
> To: m...@pengutronix.de; linux-...@vger.kernel.org
> Cc: w...@grandegger.com; netdev@vger.kernel.org;
> linux-ker...@vger.kernel.org; dl-linux-imx ; Aisheng
> DONG ; Joakim Zha
On 16.01.2019 22:48, Andrew Lunn wrote:
> On Wed, Jan 16, 2019 at 09:25:15PM +0100, Heiner Kallweit wrote:
>> Every driver should have called phy_stop() before calling
>> phy_disconnect(). Let's check for this and ensure PHY is stopped
>> when starting with the actual work in phy_disconnect().
>
>
On 16.01.2019 22:59, Andrew Lunn wrote:
> On Wed, Jan 16, 2019 at 09:25:54PM +0100, Heiner Kallweit wrote:
>> The call to the phylib state machine in phy_stop() just ensures that
>> the state machine isn't re-triggered, but a state machine call may
>> be scheduled already. So lets's call phy_stop_m
Hi Willy/Florian/Lukas,
Thanks for your help around this concern, sorry for the delayed response. I
will test this out and get back to you.
-Roobesh G M
-Original Message-
From: Willy Tarreau
Sent: Sunday, January 13, 2019 12:04 AM
To: Lukas Tribus
Cc: Mohandass, Roobesh ; Florian We
Hi Andrew,
On 17/1/19 2:12 am, Andrew Lunn wrote:
On Wed, Jan 16, 2019 at 11:14:30PM +1000, Greg Ungerer wrote:
Hi Andrew,
On 15/1/19 11:18 pm, Andrew Lunn wrote:
[snip]
As i said, it is a bit messy. I would probably have a section:
Required properties
which lists all common required proper
From: Florian Fainelli
Date: Tue, 15 Jan 2019 14:43:04 -0800
> There is not currently way to infer the port number through sysfs that
> is being used as the CPU port number. Overlay a ndo_get_phys_port_name()
> operation onto the DSA master network device in order to retrieve that
> information.
From: "Gustavo A. R. Silva"
Date: Tue, 15 Jan 2019 15:44:52 -0600
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
>
> struct fo
From: "Gustavo A. R. Silva"
Date: Tue, 15 Jan 2019 15:19:17 -0600
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
>
> struct fo
From: Florian Fainelli
Date: Tue, 15 Jan 2019 14:35:02 -0800
> Since 83c0afaec7b7 ("net: dsa: Add new binding implementation"), DSA is
> no longer a platform device exclusively and can support registering DSA
> switches from other bus drivers (PCI, USB, I2C, etc.).
>
> Signed-off-by: Florian Fai
From: Heiner Kallweit
Date: Tue, 15 Jan 2019 21:40:51 +0100
> There's no need to and one shouldn't include asm/irq.h directly.
>
> Signed-off-by: Heiner Kallweit
Applied.
From: Heiner Kallweit
Date: Tue, 15 Jan 2019 21:50:25 +0100
> Some time ago phydev_info() and friends have been added. They allow to
> improve and simplify logging.
>
> Signed-off-by: Heiner Kallweit
Applied.
From: Heiner Kallweit
Date: Tue, 15 Jan 2019 21:11:14 +0100
> This workaround attempt helped for some but not all affected users.
> With commit 11287b693d03 ("r8169: load Realtek PHY driver module
> before r8169") we have a better workaround now, so we an remove
> the first attempt.
>
> Signed-o
On 15-01-19, 15:03, Rob Herring wrote:
> On Tue, Jan 08, 2019 at 09:59:22PM +0530, Vinod Koul wrote:
> > Add support for Qualcomm ethqos found in some SoCs like QCS404.
> >
> > Signed-off-by: Vinod Koul
> > ---
> > .../devicetree/bindings/net/qcom,dwmac.txt| 129 ++
> > 1 fil
Hi,
I am having data race from threadsanitizer report.
Could you see if there is still data race in the following code using
ptr_ring API ?
/*
* Filename: circ_ring.c
* Version: 1.0
* Description: A circular buffer using API from
* https://github.com/torvalds/linux/blob/master/include/linu
From: Tonghao Zhang
In some case, we may use multiple pedit actions to modify packets.
The command shown as below: the last pedit action is effective.
$ tc filter add dev netdev_rep parent : protocol ip prio 1 \
flower skip_sw ip_proto icmp dst_ip 3.3.3.3 \
Ttttabcd writes:
> IPv6 is rapidly deploying globally. NDP replaces the role of ARP in IPv6 and
> provides mapping from IP address to MAC address.
>
> However, the NDP protocol is as insecure as the ARP protocol, and can be
> easily spoofed, and then the attacker can conduct man-in-the-middle a
From: Tristram Ha
Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are
used together to generate the I2C driver.
Signed-off-by: Tristram Ha
---
drivers/net/dsa/microchip/Kconfig | 7 ++
drivers/net/dsa/microchip/Makefile | 1 +
drivers/net/dsa/microchip/ksz94
From: Tristram Ha
This patch adds KSZ9477 I2C driver support using regmap mechanism.
Previous patches converting KSZ9477 SPI driver to regmap have to be
applied first.
v1
- Regmap mechanism is used to simplify access code.
Tristram Ha (1):
net: dsa: microchip: add KSZ9477 I2C driver
drivers
From: Tristram Ha
Convert KSZ9477 SPI driver to use regmap mechanism so that an I2C
driver can be easily added.
Original regmap implementation was submitted by Marek Vasut. Modified
and verified the implementation on real hardware.
Tristram Ha (4):
net: dsa: microchip: convert KSZ9477 SPI dr
From: Tristram Ha
Convert KSZ9477 SPI driver to use regmap mechanism so that an I2C driver
can be easily added.
KSZ9477 SPI driver uses a 32-bit SPI command containing a 24-bit address
to access registers in 8-bit. The address is automatically increased to
next register. In theory all register
From: Tristram Ha
Use regmap_update_bits function for bit manipulation in 32-bit access.
Signed-off-by: Tristram Ha
---
drivers/net/dsa/microchip/ksz9477.c | 23 +++
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git a/drivers/net/dsa/microchip/ksz9477.c
b/driver
From: Tristram Ha
Remove ksz9477_get_port_addr as it is considered too slow and the macro
PORT_CTRL_ADDR can be used directly.
Signed-off-by: Tristram Ha
---
drivers/net/dsa/microchip/ksz9477.c | 11 +--
drivers/net/dsa/microchip/ksz_priv.h | 1 -
2 files changed, 1 insertion(+), 11
From: Tristram Ha
Remove ksz_spi.h as it is not used anymore.
Signed-off-by: Tristram Ha
---
drivers/net/dsa/microchip/ksz_spi.h | 69 -
1 file changed, 69 deletions(-)
delete mode 100644 drivers/net/dsa/microchip/ksz_spi.h
diff --git a/drivers/net/dsa/mic
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop':
drivers/net/wireless/virt_wifi.c:432:31: warning:
variable 'w_priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
v2: fix prefix to 'virt_wifi:'
Remove duplicated include.
Signed-off-by: YueHaibing
---
v2: fix prefix to 'virt_wifi:'
---
drivers/net/wireless/virt_wifi.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index 64b2186..245d4d0 100644
--- a/drivers/net
在 2019/1/15 17:08, Wang, Dongsheng 写道:
> On 2019/1/15 14:41, shenjian (K) wrote:
>>
>> 在 2019/1/15 11:39, Andrew Lunn 写道:
>>> On Tue, Jan 15, 2019 at 11:07:17AM +0800, shenjian (K) wrote:
Hi, all
We encounted a problem when using the marvel 88e151x phy driver, the
link(LED[0])/
在 2019/1/17 0:04, Andrew Lunn 写道:
>> Thanks, Andrew.
>>
>> But we are using acpi mode, is there any ohter way to poke values into
>> registers ?
>
> You can register a PHY fixup.
>
> phy_register_fixup_for_uid(), mach-orion5x/dns323-setup.c
>
> Andrew
>
> .
>
Thanks Andrew!
I have t
On 2019/1/17 0:09, Kalle Valo wrote:
> YueHaibing writes:
>
>> ping...
>>
>> On 2018/12/20 10:51, YueHaibing wrote:
>>> Remove duplicated include.
>>>
>>> Signed-off-by: YueHaibing
>>> ---
>>> drivers/net/wireless/virt_wifi.c | 5 -
>>> 1 file changed, 5 deletions(-)
>
> BTW, the prefix
On Mon, Jan 14, 2019 at 01:34:44PM +0200, Samu Nuutamo wrote:
> Hi,
>
> We have an imx6q-b450v3 board that has one of the switch ports configured as a
> fixed link. After upgrading the kernel to version 4.18 the link has
> experienced
> a small amount of packet loss, around 0.15%.
>
> The issue
This patch-set is to add external trigger stamp fifo support by a new
binding "fsl,extts-fifo", and to add fiper pulse loopback support which
is very useful for validating trigger without external hardware.
Also fixed issues in interrupt enabling/handling.
"fsl,extts-fifo" is required to be added
The external trigger stamp FIFO was introduced as a new feature
for QorIQ 1588 timer IP block. This patch is to support it by
adding a new dts property "fsl,extts-fifo". Any QorIQ 1588 timer
supporting this feature is required to add this property in its
dts node.
In addition, the FIFO should be c
This patch is to add external trigger stamp fifo support
for 1588 timer.
Signed-off-by: Yangbo Lu
---
Changes for v2:
- None.
---
arch/arm/boot/dts/ls1021a.dtsi |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1
The tmr_tevent register would update event bits
no matter tmr_temask bits were set or not. So we
should get interrupts by tmr_tevent & tmr_temask,
and clean up interrupts in tmr_tevent before
enabling them.
Signed-off-by: Yangbo Lu
---
Changes for v2:
- Remove useless lock/register operat
Documented "fsl,extts-fifo" property.
Signed-off-by: Yangbo Lu
---
Changes for v2:
- Modified binding description.
---
.../devicetree/bindings/ptp/ptp-qoriq.txt |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/ptp/ptp-qor
This patch is to add Kconfig options to support fiper
pulse loopback mode. This is very useful for validating
hardware and driver without external hardware.
Signed-off-by: Yangbo Lu
---
Changes for v2:
- None.
---
drivers/ptp/Kconfig | 18 ++
drivers/ptp/ptp_qoriq.c
From: Yunjian Wang
The skb header should be set to ethernet header before using
is_skb_forwardable. Because the ethernet header length has been
considered in is_skb_forwardable(including dev->hard_header_len
length).
To reproduce the issue:
1, add 2 ports on linux bridge br using following comma
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Thursday, January 17, 2019 1:33 AM
> To: wangyunjian
> Cc: netdev@vger.kernel.org; xudingke ;
> bri...@lists.linux-foundation.org; Nkolay Aleksandrov
> ; Roopa Prabhu
>
> Subject: Re: [PATCH net v3]
Hi all,
Today's linux-next merge of the net-next tree got a conflict in:
Documentation/networking/snmp_counter.rst
between commit:
a6c7c7aac2de ("net: add document for several snmp counters")
from the net tree and commit:
ae5220c67218 ("networking: Documentation: fix snmp_counters.rst S
On Wed, Jan 16, 2019 at 03:50:44PM -0800, Florian Fainelli wrote:
> On 1/16/19 3:06 PM, Florian Fainelli wrote:
> > On 1/16/19 2:29 PM, Andrew Lunn wrote:
> >>> diff --git a/include/net/dsa.h b/include/net/dsa.h
> >>> index b3eefe8e18fd..6178b648d08a 100644
> >>> --- a/include/net/dsa.h
> >>> +++ b
On Thu, Jan 17, 2019 at 01:21:32AM +0100, Daniel Borkmann wrote:
> On 01/17/2019 12:30 AM, Alexei Starovoitov wrote:
> > On Thu, Jan 17, 2019 at 12:16:44AM +0100, Daniel Borkmann wrote:
> >> On 01/16/2019 11:48 PM, Daniel Borkmann wrote:
> >>> On 01/16/2019 06:08 AM, Alexei Starovoitov wrote:
> >>
On Tue, Jan 15, 2019 at 03:06:10PM -0800, Florian Fainelli wrote:
> Hi all,
>
> This patch series decouples the DSA platform data structures from
> net/dsa.h which was getting used for all sorts of DSA related
> structures.
>
> It would probably make sense for this series to go via David's net-ne
On Wed, 16 Jan 2019 11:09:58 -0800, Stanislav Fomichev wrote:
> This patch series add support for queue/stack manipulations.
>
> It goes like this:
>
> #1 and #2 add support for queue/stack in existing 'update' and 'lookup'
> commands by permitting empty keys.
> #3 make sure we don't print empty
Since we have a dedicated netlink attributes for xdp setup on a
particular interface, it is now possible to retrieve the program id that
is currently attached to the interface. The use case is targeted for
sample xdp programs, which will store the program id just after loading
bpf program onto ifac
Some of XDP samples that are attaching the bpf program to the interface
via libbpf's bpf_set_link_xdp_fd are still using the bpf_load.c for
loading and manipulating the ebpf program and maps. Convert them to do
this through libbpf usage and remove bpf_load from the picture.
While at it remove what
XDP samples are mostly cooperating with eBPF maps through their file
descriptors. In case of a eBPF program that contains multiple maps it
might be tiresome to iterate through them and call bpf_map__fd for each
one. Add a helper mostly based on bpf_object__find_map_by_name, but
instead of returning
Check the program id within the signal handler on polling xdp samples
that were previously converted to libbpf usage. Avoid the situation of
unloading the program that was not attached by sample that is exiting.
Signed-off-by: Maciej Fijalkowski
Reviewed-by: Jakub Kicinski
---
samples/bpf/xdp1_
Make xdp samples consistent with iproute2 behavior and set the
XDP_FLAGS_UPDATE_IF_NOEXIST by default when setting the xdp program on
interface. Provide an option for user to force the program loading,
which as a result will not include the mentioned flag in
bpf_set_link_xdp_fd call.
Signed-off-by
There is a common problem with xdp samples that happens when user wants
to run a particular sample and some bpf program is already loaded. The
default 64kb RLIMIT_MEMLOCK resource limit will cause a following error
(assuming that xdp sample that is failing was converted to libbpf
usage):
libbpf: E
On Thu, Jan 17, 2019 at 12:16:18AM +, Martin Lau wrote:
> On Tue, Jan 15, 2019 at 09:08:22PM -0800, Alexei Starovoitov wrote:
> [ ... ]
>
> > +/* copy everything but bpf_spin_lock */
> > +static inline void copy_map_value(struct bpf_map *map, void *dst, void
> > *src)
> > +{
> > + if (unlik
Hi!
This patchset tries to address the situation where:
* user loads a particular xdp sample application that does stats polling
* user loads another sample application on the same interface
* then, user sends SIGINT/SIGTERM to the app that was attached as a first one
* second application ends up w
From: Tonghao Zhang
The devconf setting on the init_net will affect other
namespace when them created. For example:
$ cat /proc/sys/net/ipv4/conf/all/rp_filter
0
$ echo 2 > /proc/sys/net/ipv4/conf/all/rp_filter
$ cat /proc/sys/net/ipv4/conf/all/rp_filter
2
$ ip netns add ns100
$ ip netns exec n
On Wed, 16 Jan 2019 16:55:13 -0800, Jakub Kicinski wrote:
> On Wed, 16 Jan 2019 14:21:10 +, Quentin Monnet wrote:
> > tools/bpf/bpftool/feature.c | 764 ++
>
> should we perhaps git mv feature.c probe.c ? (if you create a commit
> with just a move right aft
On Wed, 16 Jan 2019 14:21:10 +, Quentin Monnet wrote:
> tools/bpf/bpftool/feature.c | 764 ++
should we perhaps git mv feature.c probe.c ? (if you create a commit
with just a move right after the first commit which adds the file git
will figure out its a rena
On Wed, 16 Jan 2019 14:21:14 +, Quentin Monnet wrote:
> diff --git a/tools/lib/bpf/libbpf.map b/tools/lib/bpf/libbpf.map
> index cd02cd4e2cc3..6355e4c80a86 100644
> --- a/tools/lib/bpf/libbpf.map
> +++ b/tools/lib/bpf/libbpf.map
> @@ -56,6 +56,7 @@ LIBBPF_0.0.1 {
> bpf_object__unp
From: Colin Ian King
There is an if statement and a return statement that are incorrectly
indented. Fix these. Also replace the assignment-in-if statements
to assignment followed by an if to keep to the coding style.
Signed-off-by: Colin Ian King
---
V2: also clean up the assignment-in-if sta
On Wed, Jan 16, 2019 at 10:09 AM Martin Lau wrote:
> > In sock_setsockopt() (net/core/sock.h), when SO_MARK option is used
> > to change sk_mark, sk_dst_reset(sk) is called. The same should be done
> > in bpf_setsockopt.
> >
> > Reported-by: Maciej Żenczykowski
> > Signed-off-by: Peter Oskolkov
From: Colin Ian King
There is an if statement and a return statement that are incorrectly
indented. Fix these. Also replace the assignment-in-if statements
to assignment followed by an if to keep to the coding style.
Signed-off-by: Colin Ian King
---
V2: also clean up the assignment-in-if sta
On Wed, 16 Jan 2019 14:21:13 +, Quentin Monnet wrote:
> +static void probe_kernel_image_config(void)
> +{
> + const char * const options[] = {
nit: static
> + /* Enable BPF */
> + "CONFIG_BPF",
> + /* Enable bpf() syscall */
> + "CONFIG_BPF_
Bah, forgot to fix up the subject line properly. V3. Coming.
On 17/01/2019 00:33, Colin King wrote:
> From: Colin Ian King
>
> There is an if statement and a return statement that are incorrectly
> indented. Fix these. Also replace the assignment-in-if statements
> to assignment followed by an
On Wed, 16 Jan 2019 14:21:11 +, Quentin Monnet wrote:
> +---
> +tool for inspection of eBPF-related parameters for Linux kernel or net device
> +--
The test_insert_dup() function from lib/test_rhashtable.c passes a
pointer to a stack object to rhltable_init(). Allocate the hash table
dynamically to avoid that the following is reported with object
debugging enabled:
ODEBUG: object (ptrval) is on stack (ptrval), but NOT annotated.
WARNING: CPU:
On 01/17/2019 12:30 AM, Alexei Starovoitov wrote:
> On Thu, Jan 17, 2019 at 12:16:44AM +0100, Daniel Borkmann wrote:
>> On 01/16/2019 11:48 PM, Daniel Borkmann wrote:
>>> On 01/16/2019 06:08 AM, Alexei Starovoitov wrote:
>> [...]
@@ -6096,6 +6226,11 @@ static int do_check(struct bpf_verifier_e
On Thu, 2019-01-17 at 00:13 +, Colin King wrote:
> From: Colin Ian King
>
> There is an if statement and a return statement that are incorrectly
> indented. Fix these.
[]
> diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
[]
> @@ -540,12 +540,12 @@ sb1000_activate(const int ioaddr[],
On Tue, Jan 15, 2019 at 09:08:22PM -0800, Alexei Starovoitov wrote:
[ ... ]
> +/* copy everything but bpf_spin_lock */
> +static inline void copy_map_value(struct bpf_map *map, void *dst, void *src)
> +{
> + if (unlikely(map_value_has_spin_lock(map))) {
> + u32 off = map->spin_lock
From: Colin Ian King
There is an if statement and a return statement that are incorrectly
indented. Fix these.
Signed-off-by: Colin Ian King
---
drivers/net/sb1000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
index 7820fc
From: Colin Ian King
There are two lines that have indentation issues, fix these. Also remove
an empty line.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/jme.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/j
Mein Name ist Friedrich Mayrhofer, meine Frau und ich haben im Dezember 2015
eine Jackpot-Lotterie in Höhe von 50 Millionen Dollar gewonnen. Wir spenden die
Summe von 2.800.000 Millionen Euro an 5 glückliche Personen, von denen Sie
einer der Begünstigten sind. und wir spenden 2.800.000,00 an
From: Colin Ian King
There is a goto statement that indented too deeply, fix it.
Signed-off-by: Colin Ian King
---
drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c
b/drivers/net/et
On 1/16/19 3:06 PM, Florian Fainelli wrote:
> On 1/16/19 2:29 PM, Andrew Lunn wrote:
>>> diff --git a/include/net/dsa.h b/include/net/dsa.h
>>> index b3eefe8e18fd..6178b648d08a 100644
>>> --- a/include/net/dsa.h
>>> +++ b/include/net/dsa.h
>>> @@ -21,6 +21,7 @@
>>> #include
>>> #include
>>> #i
From: Willem de Bruijn
Date: Tue, 15 Jan 2019 11:40:02 -0500
> From: Willem de Bruijn
>
> Failure __ip_append_data triggers udp_flush_pending_frames, but these
> tests happen later. The skb must be freed directly.
>
> Fixes: bec1f6f697362 ("udp: generate gso with UDP_SEGMENT")
> Reported-by: E
From: Taehee Yoo
Date: Wed, 16 Jan 2019 01:35:22 +0900
> The section of bpfilter UMH blob is the ".bpfilter_umh". but this is not
> an explicit section. so linking warning occurred at compile time for the
> powerpc.
> So, this patch makes use of the ".rodata" instead of the ".bpfilter_umh".
>
>
From: Andrew Lunn
Date: Tue, 15 Jan 2019 16:55:30 +0100
> The bcm87xx and micrel driver has PHYs which are missing the .features
> value. Add them. The bcm87xx is a 10G FEC only PHY. Add the needed
> features definition of this PHY.
>
> Fixes: 719655a14971 ("net: phy: Replace phy driver features
From: "Michael S. Tsirkin"
Date: Mon, 14 Jan 2019 20:34:26 -0500
> Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is
> safe to call in a non-napi context as long as the napi_budget flag is
> correct.
>
> Signed-off-by: Michael S. Tsirkin
> ---
>
> My perf testing setup is
On Thu, Jan 17, 2019 at 12:16:44AM +0100, Daniel Borkmann wrote:
> On 01/16/2019 11:48 PM, Daniel Borkmann wrote:
> > On 01/16/2019 06:08 AM, Alexei Starovoitov wrote:
> [...]
> >> @@ -6096,6 +6226,11 @@ static int do_check(struct bpf_verifier_env *env)
> >>retur
On Wed, Jan 16, 2019 at 11:48:15PM +0100, Daniel Borkmann wrote:
>
> I think if I'm not mistaken there should still be a possibility for causing a
> deadlock, namely if in the middle of the critical section I'm using an LD_ABS
> or LD_IND instruction with oob index such that I cause an implicit re
On 01/16/2019 11:48 PM, Daniel Borkmann wrote:
> On 01/16/2019 06:08 AM, Alexei Starovoitov wrote:
[...]
>> @@ -6096,6 +6226,11 @@ static int do_check(struct bpf_verifier_env *env)
>> return -EINVAL;
>> }
>>
>> +
From: lepton
Date: Wed, 16 Jan 2019 14:27:45 -0800
> I sent another version with signed off serveral days ago:
>
> https://www.spinics.net/lists/netdev/msg543829.html
>
> So for some reason it got missed?
I didn't see it before I applied the initial patch because I was
heavily backlogged, I sa
On Tue, Jan 15, 2019 at 04:49:16PM -0500, Chuck Lever wrote:
>
>
> On Jan 15, 2019, at 4:11 PM, Gustavo A. R. Silva
> wrote:
>
> > One of the more common cases of allocation size calculations is finding
> > the size of a structure that has a zero-sized array at the end, along
> > with memory f
In order to make it easier to implement rollbacks after FDB update
vetoing, separate the FDB update code to two parts: one that deals with
updates of existing FDB entries, and one that creates new entries.
Signed-off-by: Petr Machata
---
drivers/net/vxlan.c | 158
mlxsw doesn't implement offloading of all types of FDB entries that the
VXLAN driver supports. Test that such FDB entries are rejected. That
makes sure that the decision made by the existing validation code in
mlxsw propagates up the stack. It also exercises rollback functionality
in VXLAN, and tes
Annotate the rejections in mlxsw_sp_switchdev_vxlan_work_prepare() with
textual reasons.
Because this code ends up being invoked for FDB replay as well, drop the
default message from there, so that the more accurate error message is
not overwritten.
Signed-off-by: Petr Machata
---
drivers/net/e
On 1/16/19 2:29 PM, Andrew Lunn wrote:
>> diff --git a/include/net/dsa.h b/include/net/dsa.h
>> index b3eefe8e18fd..6178b648d08a 100644
>> --- a/include/net/dsa.h
>> +++ b/include/net/dsa.h
>> @@ -21,6 +21,7 @@
>> #include
>> #include
>> #include
>> +#include
>> #include
>> #include
>
>
mlxsw does not implement handling of the more advanced types of VXLAN
FDB entries. In order to provide visibility to users, it is important to
be able to reject such FDB entries, ideally with an explanation passed
in extended ack. This patch set implements this.
In patches #1-#4, vxlan is graduall
These functions will be needed for rollbacks of vetoed FDB entries. Move
them up so that they are visible at their intended point of use.
Signed-off-by: Petr Machata
---
drivers/net/vxlan.c | 59 ++---
1 file changed, 29 insertions(+), 30 deletions
A follow-up patch will enable vetoing of FDB entries. Make it possible
to communicate details of why an FDB entry is not acceptable back to the
user.
Signed-off-by: Petr Machata
---
Documentation/networking/switchdev.txt | 2 +-
drivers/net/ethernet/mellanox/mlxsw/spectrum_rou
There are four sources of VXLAN switchdev notifier calls:
- the changelink() link operation, which already supports extack,
- ndo_fdb_add() which got extack support in a previous patch,
- FDB updates due to packet forwarding,
- and vxlan_fdb_replay().
Extend vxlan_fdb_switchdev_call_notifiers() t
A follow-up patch will extend vxlan_fdb_replay() with an extack
argument. Extend the fdb_replay callback in mlxsw likewise so that the
argument is ready for the vxlan conversion.
Signed-off-by: Petr Machata
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_nve.c | 2 +-
drivers/net/ethernet
The changelink operation may cause change in remote address, and
therefore an FDB update, which can be vetoed. To properly handle
vetoing, vxlan_changelink() needs to be gradually updated.
In this patch simply replace vxlan_dev_configure() with the two
constituent calls.
Signed-off-by: Petr Macha
Change vxlan_fdb_switchdev_call_notifiers() to return the result from
calling switchdev notifiers. Propagate the error number up the stack.
In vxlan_fdb_update_existing() and vxlan_fdb_update_create() add
rollbacks to clean up the work that was done before the veto.
Signed-off-by: Petr Machata
-
Drivers may not be able to support certain FDB entries, and an error
code is insufficient to give clear hints as to the reasons of rejection.
In order to make it possible to communicate the rejection reason, extend
ndo_fdb_add() with an extack argument. Adapt the existing
implementations of ndo_fd
When an FDB entry is vetoed, it is necessary to unroll the changes that
have already been done. To avoid having to unroll vxlan_config_apply(),
postpone the call after the point where the vetoing takes place. Since
the call can't fail, it doesn't necessitate any cleanups in the
preceding FDB update
To enable rollbacks after vetoed FDB updates, extend vxlan_fdb_replace()
to take an additional argument where it should store the original values
of a modified rdst. Update the sole caller.
The following patch will make use of the saved value.
Signed-off-by: Petr Machata
---
drivers/net/vxlan.c
1 - 100 of 345 matches
Mail list logo
