Re: linux-next: Signed-off-by missing for commit in the net tree

2019-01-10 Thread Frank Wunderlich
Should i make v3 with all tags or me as author? Regards Frank

Re: linux-next: Signed-off-by missing for commit in the net tree

2019-01-10 Thread Heiner Kallweit
On 11.01.2019 04:48, Stephen Rothwell wrote: > Hi all, > > Commit > > b19bce0335e2 ("net: ethernet: mediatek: fix warning in phy_start_aneg") > > is missing a Signed-off-by from its author. > I suggested the changes and Frank prepared the patch with me as author. Therefore: Suggested-by: Hei

[PATCH v2] vrf: Fix conntrack-dnat conflict in vrf-device PREROUTING hook

2019-01-10 Thread wenxu
From: wenxu In the ip_rcv the skb go through the PREROUTING hook first, Then jump in vrf device go through the same hook again. When conntrack dnat work with vrf, there will be some conflict for rules. Because the package go through the hook twice with different nf status ip link add user1 type

Re: [PATCH 1/2] Bluetooth: check message types in l2cap_get_conf_opt

2019-01-10 Thread Greg Kroah-Hartman
On Thu, Jan 10, 2019 at 01:02:09PM -0800, Joe Perches wrote: > On Thu, 2019-01-10 at 07:28 +0100, Greg Kroah-Hartman wrote: > > l2cap_get_conf_opt can handle a "default" message type, but it needs to > > be verified that it really is the correct type (CONF_EFS or CONF_RFC) > > before passing it bac

Potential memory leak in htab_map_update_elem?

2019-01-10 Thread Kris Van Hees
Maybe I am missing something trivial here, but it looks to me that there is a leak of htab elements in htab_map_update_elem when you are updating an existing element. After the new element is linked into the bucket list, the following code snippet is found: if (l_old) { hl

Re: [RFT][PATCH V2 09/10] net: dsa: microchip: Factor out regmap config generation into common header

2019-01-10 Thread Marek Vasut
On 1/11/19 5:04 AM, tristram...@microchip.com wrote: >> On 1/10/19 3:10 AM, tristram...@microchip.com wrote: > I just looked at your regmap code and you use 3 regmap pointers for specific 8-bit, 16-bit, and 32-bit accesses. The switch access is always 8-bit. >> It has automatic

Re: [PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-10 Thread Konstantin Khlebnikov
On Thu, Jan 10, 2019 at 11:45 PM Cong Wang wrote: > > On Tue, Jan 8, 2019 at 1:30 AM Konstantin Khlebnikov > wrote: > > @@ -443,12 +444,14 @@ static struct neigh_hash_table > > *neigh_hash_alloc(unsigned int shift) > > ret = kmalloc(sizeof(*ret), GFP_ATOMIC); > > if (!ret) > >

Re: [PATCH v1 1/1] veth: Do not drop packets larger then the mtu set on the receiving side

2019-01-10 Thread Toshiaki Makita
On 2019/01/10 22:26, Fredrik Gustavsson wrote: > commit affede4a779420bd8510ab937251a3796d3228df > Author: Fredrik Gustavsson > Date: Tue Jan 8 11:21:39 2019 +0100 > > veth: Do not drop packets larger then the mtu set on the receiving side > > Currently veth drops all packets larger then the m

Re: [PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-10 Thread Jason Wang
On 2019/1/8 下午4:07, Zha Bin wrote: The vsock core only supports 32bit CID, but the Virtio-vsock spec define CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as zero. This inconsistency causes one bug in vhost vsock driver. The scenarios is: 0. A hash table (vhost_vsock_hash

RE: [RFT][PATCH V2 09/10] net: dsa: microchip: Factor out regmap config generation into common header

2019-01-10 Thread Tristram.Ha
> On 1/10/19 3:10 AM, tristram...@microchip.com wrote: > >>> I just looked at your regmap code and you use 3 regmap pointers for > >> specific 8-bit, 16-bit, and 32-bit accesses. The switch access is always > >> 8-bit. > It > >> has automatic register increment so that you can access arbitrary le

[PATCH net V3] vhost: log dirty page correctly

2019-01-10 Thread Jason Wang
Vhost dirty page logging API is designed to sync through GPA. But we try to log GIOVA when device IOTLB is enabled. This is wrong and may lead to missing data after migration. To solve this issue, when logging with device IOTLB enabled, we will: 1) reuse the device IOTLB translation result of GIO

Re: [PATCH net V2] vhost: log dirty page correctly

2019-01-10 Thread Jason Wang
On 2019/1/10 下午10:07, Michael S. Tsirkin wrote: On Thu, Jan 10, 2019 at 08:37:17PM +0800, Jason Wang wrote: On 2019/1/9 下午10:25, Michael S. Tsirkin wrote: On Wed, Jan 09, 2019 at 03:29:47PM +0800, Jason Wang wrote: Vhost dirty page logging API is designed to sync through GPA. But we try to l

linux-next: Signed-off-by missing for commit in the net tree

2019-01-10 Thread Stephen Rothwell
Hi all, Commit b19bce0335e2 ("net: ethernet: mediatek: fix warning in phy_start_aneg") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgpbAmGprqq_j.pgp Description: OpenPGP digital signature

Re: [PATCH v2] netfilter: x_tables: add xt_tunnel match

2019-01-10 Thread wenxu
On 1/11/2019 2:15 AM, Pablo Neira Ayuso wrote: > On Thu, Jan 10, 2019 at 01:16:08PM +0800, we...@ucloud.cn wrote: > [...] >> +static struct xt_match tunnel_mt_reg __read_mostly = { >> +.name = "tunnel", >> +.revision = 0, >> +.family = NFPROTO_UNSPEC, >> +.

[PATCH v3] netfilter: nft_flow_offload: fix interaction with vrf slave device

2019-01-10 Thread wenxu
From: wenxu In the forward chain the iif is changed from slave device to master vrf device. It will lead the offload not match on lower slave device. This patch the flow table iif and oif based on route cache dst->dev, not the skb->iif This patch make the flollowing example can work correct i

[BUG] net: huawei: hinic: a possible sleep-in-atomic-context bug in msg_to_mgmt_async

2019-01-10 Thread Jia-Ju Bai
The driver may sleep in an interrupt handler. The function call path (from bottom to top) in the directory "drivers/net/ethernet/huawei/hinic/" in Linux-4.17 is: [FUNC] down hinic_hw_mgmt.c, 324: down in msg_to_mgmt_async hinic_hw_mgmt.c, 408: msg_to_mgmt_async in mgmt_recv_msg_handler hinic_hw

[BUG] net: huawei: hinic: a possible sleep-in-atomic-context bug in hinic_get_stats64

2019-01-10 Thread Jia-Ju Bai
The driver may sleep while holding a RCU lock. The function call path (from bottom to top) in Linux-4.17 is: [FUNC] down drivers/net/.../hinic/hinic_main.c, 775: down in hinic_get_stats64 net/core/dev.c, 8278: [FUNC_PTR]hinic_get_stats64 in dev_get_stats net/core/net-sysfs.c, 568: dev_get_stats i

[BUG] net: huawei: hinic: a possible sleep-in-atomic-context bug in hinic_get_stats64

2019-01-10 Thread Jia-Ju Bai
The driver may sleep while holding a RCU lock. The function call path (from bottom to top) in Linux-4.17 is: [FUNC] down drivers/net/.../hinic/hinic_main.c, 775: down in hinic_get_stats64 net/core/dev.c, 8278: [FUNC_PTR]hinic_get_stats64 in dev_get_stats net/core/net-sysfs.c, 568: dev_get_stats i

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread David Ahern
On 1/10/19 12:45 PM, Song Liu wrote: > Could you please share your feedback on PERF_RECORD_BPF_EVENT for auditing > use cases? Google shows Daniel was the one looking at audit use cases: https://www.mail-archive.com/netdev@vger.kernel.org/msg250728.html My comment was that using a PERF_RECORD_BP

Re: tc flower IP address keys

2019-01-10 Thread Cong Wang
On Thu, Jan 10, 2019 at 5:42 AM Edward Cree wrote: > > I think there is a bug in net/sched/cls_flower.c:fl_init_dissector(), > where it reads > > FL_KEY_SET_IF_MASKED(mask, keys, cnt, > FLOW_DISSECTOR_KEY_IPV4_ADDRS, ipv4); > FL_KEY_SET_IF_MASKED(mask, keys, cnt, >

Re: [Patch net-next 2/2] net: dump whole skb data in netdev_rx_csum_fault()

2019-01-10 Thread Willem de Bruijn
On Wed, Dec 5, 2018 at 12:33 PM Peter Oskolkov wrote: > > FWIW, I find the patch really useful - I applied it to my local dev > repo (with minor changes) and use skb_dump() a lot now. It would be > great if it makes its way into net-next in some form. +1 very informative. skb_warn_bad_offload wo

[PATCH v7 perf, bpf-next 2/8] sync tools/include/uapi/linux/perf_event.h

2019-01-10 Thread Song Liu
sync changes for PERF_RECORD_KSYMBOL Signed-off-by: Song Liu --- tools/include/uapi/linux/perf_event.h | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h index 9de8780ac8d9.

[PATCH v7 perf, bpf-next 5/8] perf, bpf: emit PERF_RECORD_KSYMBOL for BPF program load/unload

2019-01-10 Thread Song Liu
This patch enables emitting PERF_RECORD_KSYMBOL for BPF program load and unload. A PERF_RECORD_KSYMBOL is issued for each BPF sub program. Signed-off-by: Song Liu --- kernel/events/core.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/kernel/events/core.c

[PATCH v7 perf, bpf-next 3/8] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2019-01-10 Thread Song Liu
For better performance analysis of BPF programs, this patch introduces PERF_RECORD_BPF_EVENT, a new perf_event_type that exposes BPF program load/unload information to user space. Each BPF program may contain up to BPF_MAX_SUBPROGS (256) sub programs. The following example shows kernel symbols for

[PATCH v7 perf, bpf-next 0/8] reveal invisible bpf programs

2019-01-10 Thread Song Liu
This set catches symbol for all bpf programs loaded/unloaded before/during/after perf-record run PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT. PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT includes key information of a bpf program load and unload. They are sent through perf ringbuffer, and stored

[PATCH v7 perf, bpf-next 4/8] sync tools/include/uapi/linux/perf_event.h

2019-01-10 Thread Song Liu
sync for PERF_RECORD_BPF_EVENT Signed-off-by: Song Liu --- tools/include/uapi/linux/perf_event.h | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h index 68c4da0227c5..8bd7

[PATCH v7 perf, bpf-next 8/8] perf tools: synthesize PERF_RECORD_* for loaded BPF programs

2019-01-10 Thread Song Liu
This patch synthesize PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT for BPF programs loaded before perf-record. This is achieved by gathering information about all BPF programs via sys_bpf. Signed-off-by: Song Liu --- tools/perf/builtin-record.c | 6 ++ tools/perf/util/bpf-event.c | 205 ++

[PATCH v7 perf, bpf-next 7/8] perf util: handle PERF_RECORD_BPF_EVENT

2019-01-10 Thread Song Liu
This patch adds basic handling of PERF_RECORD_BPF_EVENT. Tracking of PERF_RECORD_BPF_EVENT is OFF by default. Option --bpf-event is added to turn it on. Signed-off-by: Song Liu --- tools/perf/builtin-record.c | 1 + tools/perf/perf.h | 1 + tools/perf/util/Build | 2 ++ tools/

[PATCH v7 perf, bpf-next 1/8] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Song Liu
For better performance analysis of dynamically JITed and loaded kernel functions, such as BPF programs, this patch introduces PERF_RECORD_KSYMBOL, a new perf_event_type that exposes kernel symbol register/unregister information to user space. The following data structure is used for PERF_RECORD_KS

[PATCH v7 perf, bpf-next 6/8] perf util: handle PERF_RECORD_KSYMBOL

2019-01-10 Thread Song Liu
This patch handles PERF_RECORD_KSYMBOL in perf record/report. Specifically, map and symbol are created for ksymbol register, and removed for ksymbol unregister. This patch also set perf_event_attr.ksymbol properly. The flag is ON by default. Signed-off-by: Song Liu --- tools/perf/util/event.c

[PATCH v4] coding-style: Clarify the expectations around bool

2019-01-10 Thread Jason Gunthorpe
There has been some confusion since checkpatch started warning about bool use in structures, and people have been avoiding using it. Many people feel there is still a legitimate place for bool in structures, so provide some guidance on bool usage derived from the entire thread that spawned the che

Re: [PATCH v2] nft_flow_offload: Make flow offload work with vrf slave device correct

2019-01-10 Thread Pablo Neira Ayuso
On Thu, Jan 10, 2019 at 02:51:35PM +0800, we...@ucloud.cn wrote: > From: wenxu > > In the forward chain the iif is changed from slave device to master vrf > device. It will lead the offload not match on lower slave device. > > This patch the flow table iif and oif based on route cache dst->dev, n

[PATCH net] net: phy: marvell: Fix deadlock from wrong locking

2019-01-10 Thread Andrew Lunn
m88e1318_set_wol() takes the lock as part of phy_select_page(). Don't take the lock again with phy_read(), use the unlocked __phy_read(). Fixes: 424ca4c55121 ("net: phy: marvell: fix paged access races") Reported-by: Åke Rehnman Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 2 +- 1

Re: [PATCH net 1/2] bpf: Fix bpf_redirect to an ipip/ip6tnl dev

2019-01-10 Thread Willem de Bruijn
On Thu, Jan 10, 2019 at 5:22 PM Daniel Borkmann wrote: > > On 01/10/2019 09:41 PM, Willem de Bruijn wrote: > > On Wed, Nov 9, 2016 at 6:57 PM Martin KaFai Lau wrote: > >> > >> If the bpf program calls bpf_redirect(dev, 0) and dev is > >> an ipip/ip6tnl, it currently includes the mac header. > >>

Re: [PATCH v3 23/30] ipv6: defrag: drop non-last frags smaller than min mtu

2019-01-10 Thread Florian Westphal
Tom Herbert wrote: > I couldn't find any mention of the advisory in the commit logs or > netdev discussion, and apparently there's no protocol requirement that > intermediate fragements need to be at least minimal MTU. Maybe this > patch should be reverted? Currently ipv6 reasm doesn't use rbtree

Re: [PATCH net 1/2] bpf: Fix bpf_redirect to an ipip/ip6tnl dev

2019-01-10 Thread Daniel Borkmann
On 01/10/2019 09:41 PM, Willem de Bruijn wrote: > On Wed, Nov 9, 2016 at 6:57 PM Martin KaFai Lau wrote: >> >> If the bpf program calls bpf_redirect(dev, 0) and dev is >> an ipip/ip6tnl, it currently includes the mac header. >> e.g. If dev is ipip, the end result is IP-EthHdr-IP instead >> of IP-I

Re: [PATCH v1 net] net: dsa: mv88x6xxx: mv88e6390 errata

2019-01-10 Thread David Miller
From: Andrew Lunn Date: Thu, 10 Jan 2019 23:00:13 +0100 > Ah, sorry, i marked it for net, but did not add a fixes tag. Yes, > please add it to -stable. Ok, done. > I'm not sure there is a good fixed-tag, since this is an errata. I think you did the right thing by not adding a fixes tag.

Re: [PATCH v1 net] net: dsa: mv88x6xxx: mv88e6390 errata

2019-01-10 Thread Andrew Lunn
On Thu, Jan 10, 2019 at 01:54:16PM -0800, David Miller wrote: > From: Andrew Lunn > Date: Wed, 9 Jan 2019 00:24:03 +0100 > > > The 6390 copper ports have an errata which require poking magic values > > into undocumented magic registers and then performing a software > > reset. > > > > Signed-of

Re: [PATCH v2] net: ethernet: mediatek: fix warning in phy_start_aneg

2019-01-10 Thread David Miller
From: Frank Wunderlich Date: Wed, 9 Jan 2019 08:20:28 +0100 > From: Heiner Kallweit > > linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup: ... > maybe other boards using this generic driver are affected > > v2: > optimization: ... > Signed-off-by: Frank Wunderlich Applied, tha

Re: [PATCH net] tcp: change txhash on SYN-data timeout

2019-01-10 Thread David Miller
From: Yuchung Cheng Date: Tue, 8 Jan 2019 18:14:28 -0800 > Previously upon SYN timeouts the sender recomputes the txhash to > try a different path. However this does not apply on the initial > timeout of SYN-data (active Fast Open). Therefore an active IPv6 > Fast Open connection may incur one s

Re: [PATCH v1 net] net: dsa: mv88x6xxx: mv88e6390 errata

2019-01-10 Thread David Miller
From: Andrew Lunn Date: Wed, 9 Jan 2019 00:24:03 +0100 > The 6390 copper ports have an errata which require poking magic values > into undocumented magic registers and then performing a software > reset. > > Signed-off-by: Andrew Lunn Applied, thanks Andrew. Would you like me to queue this u

Re: [PATCH net] bonding: update nest level on unlink

2019-01-10 Thread David Miller
From: Willem de Bruijn Date: Tue, 8 Jan 2019 12:32:42 -0500 > From: Willem de Bruijn > > A network device stack with multiple layers of bonding devices can > trigger a false positive lockdep warning. Adding lockdep nest levels > fixes this. Update the level on both enslave and unlink, to avoid

Re: [PATCH net-next v4] Documentation: networking: Clarify switchdev devices behavior

2019-01-10 Thread Randy Dunlap
On 1/10/19 11:32 AM, Florian Fainelli wrote: > This patch provides details on the expected behavior of switchdev > enabled network devices when operating in a "stand alone" mode, as well > as when being bridge members. This clarifies a number of things that > recently came up during a bug fixing se

[PATCH net] net: phy: marvell: Errata for mv88e6390 internal PHYs

2019-01-10 Thread Andrew Lunn
The VOD can be out of spec, unless some magic value is poked into an undocumented register in an undocumented page. Fixes: e4cf8a38fc0d ("net: phy: Marvell: Add mv88e6390 internal PHY") Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 35 ++- 1 file chan

Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031

2019-01-10 Thread Tony Lindgren
* Tony Lindgren [190110 13:27]: > * Heiner Kallweit [190110 19:41]: > > On 10.01.2019 20:24, Florian Fainelli wrote: > > > On 1/10/19 11:22 AM, Heiner Kallweit wrote: > > >> So far genphy_soft_reset was used automatically if the PHY driver > > >> didn't implement the soft_reset callback. This cha

Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031

2019-01-10 Thread Tony Lindgren
* Heiner Kallweit [190110 19:41]: > On 10.01.2019 20:24, Florian Fainelli wrote: > > On 1/10/19 11:22 AM, Heiner Kallweit wrote: > >> So far genphy_soft_reset was used automatically if the PHY driver > >> didn't implement the soft_reset callback. This changed with the > >> mentioned commit and bro

Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031

2019-01-10 Thread Tony Lindgren
* Heiner Kallweit [190110 19:22]: > So far genphy_soft_reset was used automatically if the PHY driver > didn't implement the soft_reset callback. This changed with the > mentioned commit and broke KSZ9031. To fix this configure the > KSZ9031 PHY driver to use genphy_soft_reset. > > Fixes: 6e2d85e

[PATCH 2/3] can: gw: use struct canfd_frame as internal data structure

2019-01-10 Thread Oliver Hartkopp
To prepare the CAN FD support this patch splits the first adaptions to CAN FD without changing the current functionality. Additionally some code is moved or indented to simplify the review of the next step. Signed-off-by: Oliver Hartkopp --- include/uapi/linux/can/gw.h | 5 +- net/can/gw.c

[PATCH 3/3] can: gw: add support for CAN FD frames

2019-01-10 Thread Oliver Hartkopp
Introduce CAN FD support which needs an extension of the netlink API to pass CAN FD type content to the kernel which has a different size to Classic CAN. Additionally the struct canfd_frame has a new 'flags' element that can now be modified with can-gw. The new CGW_FLAGS_CAN_FD option flag defines

[PATCH 0/3] RFC/RFT: CAN FD support for can-gw

2019-01-10 Thread Oliver Hartkopp
As a follow-up to the discussion about CVE-2019-3701 I walked through the can-gw code to add the support for handling CAN FD frames. Patch 1/3 is still the CVE fix and can be omitted when a recent Linux tree is used that is already patched. Patch 2/3 and 3/3 introduce the CAN FD support. The upd

[PATCH 1/3] can: gw: ensure DLC boundaries after CAN frame modification

2019-01-10 Thread Oliver Hartkopp
Muyu Yu provided a POC where user root with CAP_NET_ADMIN can create a CAN frame modification rule that makes the data length code a higher value than the available CAN frame data size. In combination with a configured checksum calculation where the result is stored relatively to the end of the dat

Re: [PATCH 1/2] Bluetooth: check message types in l2cap_get_conf_opt

2019-01-10 Thread Joe Perches
On Thu, 2019-01-10 at 07:28 +0100, Greg Kroah-Hartman wrote: > l2cap_get_conf_opt can handle a "default" message type, but it needs to > be verified that it really is the correct type (CONF_EFS or CONF_RFC) > before passing it back to the caller. To do this we need to check the > return value of t

Re: [PATCH 07/11] y2038: syscalls: rename y2038 compat syscalls

2019-01-10 Thread Heiko Carstens
On Thu, Jan 10, 2019 at 06:22:12PM +0100, Arnd Bergmann wrote: > diff --git a/arch/s390/kernel/syscalls/syscall.tbl > b/arch/s390/kernel/syscalls/syscall.tbl > index f84ea364a302..b3199a744731 100644 > --- a/arch/s390/kernel/syscalls/syscall.tbl > +++ b/arch/s390/kernel/syscalls/syscall.tbl > @@ -

Re: [PATCH net 1/2] bpf: Fix bpf_redirect to an ipip/ip6tnl dev

2019-01-10 Thread Willem de Bruijn
On Wed, Nov 9, 2016 at 6:57 PM Martin KaFai Lau wrote: > > If the bpf program calls bpf_redirect(dev, 0) and dev is > an ipip/ip6tnl, it currently includes the mac header. > e.g. If dev is ipip, the end result is IP-EthHdr-IP instead > of IP-IP. > > The fix is to pull the mac header. At ingress,

[PATCH] IN_BADCLASS: fix macro to actually work

2019-01-10 Thread Greg Kroah-Hartman
Commit 65cab850f0ee ("net: Allow class-e address assignment via ifconfig ioctl") modified the IN_BADCLASS macro a bit, but unfortunatly one too many '(' characters were added to the line, making any code that used it, not build properly. Also, the macro now compares an unsigned with a signed value

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 10, 2019 at 07:30:22PM +, Song Liu escreveu: > > > > On Jan 10, 2019, at 10:55 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Thu, Jan 10, 2019 at 06:40:37PM +, Song Liu escreveu: > >> > >> > >>> On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo > >>> wrote: >

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Song Liu
> On Jan 10, 2019, at 11:30 AM, Song Liu wrote: > > > >> On Jan 10, 2019, at 10:55 AM, Arnaldo Carvalho de Melo >> wrote: >> >> Em Thu, Jan 10, 2019 at 06:40:37PM +, Song Liu escreveu: >>> >>> On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo wrote: Em We

Re: [PATCH net] tcp: allow MSG_ZEROCOPY transmission also in CLOSE_WAIT state

2019-01-10 Thread Soheil Hassas Yeganeh
On Thu, Jan 10, 2019 at 2:40 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > TCP transmission with MSG_ZEROCOPY fails if the peer closes its end of > the connection and so transitions this socket to CLOSE_WAIT state. > > Transmission in close wait state is acceptable. Other similar test

Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031

2019-01-10 Thread Heiner Kallweit
On 10.01.2019 20:24, Florian Fainelli wrote: > On 1/10/19 11:22 AM, Heiner Kallweit wrote: >> So far genphy_soft_reset was used automatically if the PHY driver >> didn't implement the soft_reset callback. This changed with the >> mentioned commit and broke KSZ9031. To fix this configure the >> KSZ9

[PATCH net] tcp: allow MSG_ZEROCOPY transmission also in CLOSE_WAIT state

2019-01-10 Thread Willem de Bruijn
From: Willem de Bruijn TCP transmission with MSG_ZEROCOPY fails if the peer closes its end of the connection and so transitions this socket to CLOSE_WAIT state. Transmission in close wait state is acceptable. Other similar tests in the stack (e.g., in FastOpen) accept both states. Relax this tes

[PATCH net-next v4] Documentation: networking: Clarify switchdev devices behavior

2019-01-10 Thread Florian Fainelli
This patch provides details on the expected behavior of switchdev enabled network devices when operating in a "stand alone" mode, as well as when being bridge members. This clarifies a number of things that recently came up during a bug fixing session on the b53 DSA switch driver. Signed-off-by: F

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Song Liu
> On Jan 10, 2019, at 10:55 AM, Arnaldo Carvalho de Melo > wrote: > > Em Thu, Jan 10, 2019 at 06:40:37PM +, Song Liu escreveu: >> >> >>> On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo >>> wrote: >>> >>> Em Wed, Jan 09, 2019 at 11:21:05AM -0800, Song Liu escreveu: For bet

Re: [PATCH v3 23/30] ipv6: defrag: drop non-last frags smaller than min mtu

2019-01-10 Thread Tom Herbert
Hi, This patch popped on 6man IETF list as possibly causing interoperability problems. Here's the description from Timothy Winters: "We have encountered a potential Interoperability issue at the UNH-IOL while running some testing. The issue is around fragments. The Linux Kernel updated based on

Re: [PATCH v3] netfilter: xt_connlimit: fix race in connection counting

2019-01-10 Thread Alakesh Haloi
On Thu, Jan 10, 2019 at 08:19:09PM +0100, Greg KH wrote: > On Thu, Jan 03, 2019 at 12:28:46AM +, Alakesh Haloi wrote: > > commit b36e4523d4d5 ("netfilter: nf_conncount: fix garbage collection > > confirm > > race") > > > > An iptable rule like the following on a multicore systems will

Re: [PATCH v3] netfilter: xt_connlimit: fix race in connection counting

2019-01-10 Thread Greg KH
On Thu, Jan 03, 2019 at 12:28:46AM +, Alakesh Haloi wrote: > commit b36e4523d4d5 ("netfilter: nf_conncount: fix garbage collection confirm > race") > > An iptable rule like the following on a multicore systems will result in > accepting more connections than set in the rule. > > iptab

Re: [PATCHv4 bpf-next 07/13] bpf: Add reference tracking to verifier

2019-01-10 Thread Joe Stringer
[resend as apparently I untoggled the "plain text" option in gmail...] On Tue, 8 Jan 2019 at 23:42, Alexei Starovoitov wrote: > > On Tue, Oct 02, 2018 at 01:35:35PM -0700, Joe Stringer wrote: > > Allow helper functions to acquire a reference and return it into a > > register. Specific pointer typ

Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031

2019-01-10 Thread Florian Fainelli
On 1/10/19 11:22 AM, Heiner Kallweit wrote: > So far genphy_soft_reset was used automatically if the PHY driver > didn't implement the soft_reset callback. This changed with the > mentioned commit and broke KSZ9031. To fix this configure the > KSZ9031 PHY driver to use genphy_soft_reset. > > Fixes

[PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031

2019-01-10 Thread Heiner Kallweit
So far genphy_soft_reset was used automatically if the PHY driver didn't implement the soft_reset callback. This changed with the mentioned commit and broke KSZ9031. To fix this configure the KSZ9031 PHY driver to use genphy_soft_reset. Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft rese

[PATCH net] net/sched: act_tunnel_key: fix memory leak in case of action replace

2019-01-10 Thread Davide Caratti
running the following TDC test cases: 7afc - Replace tunnel_key set action with all parameters 364d - Replace tunnel_key set action with all parameters and cookie it's possible to trigger kmemleak warnings like: unreferenced object 0x94797127ab40 (size 192): comm "tc", pid 3248, jiffie

Re: [PATCH] include/linux: Remove duplicate header

2019-01-10 Thread Michael S. Tsirkin
On Thu, Jan 10, 2019 at 09:31:14PM +0530, Brajeswar Ghosh wrote: > Remove duplicate headers which are included more than once > > Signed-off-by: Brajeswar Ghosh > --- > include/linux/perf_event.h | 1 - > include/linux/ptr_ring.h | 1 - > include/linux/qed/qed_if.h | 1 - > include/linux/secur

[PATCH bpf 2/3] tools/bpf: test btf bitfield with >=256 struct member offset

2019-01-10 Thread Yonghong Song
This patch modified test_btf pretty print test to cover the bitfield with struct member equal to or greater 256. Without the previous kernel patch fix, the modified test will fail: $ test_btf -p .. BTF pretty print array(#1)..unexpected pprint output expected: 0: {0,0,0,0x3,0x0,0x

[PATCH bpf 3/3] tools/bpf: fix bpftool map dump with bitfields

2019-01-10 Thread Yonghong Song
Commit 8772c8bc093b ("tools: bpftool: support pretty print with kind_flag set") added bpftool map dump with kind_flag support. When bitfield_size can be retrieved directly from btf_member, function btf_dumper_bitfield() is called to dump the bitfield. The implementation passed the wrong parameter "

[PATCH bpf 1/3] bpf: fix bpffs bitfield pretty print

2019-01-10 Thread Yonghong Song
Commit 9d5f9f701b18 ("bpf: btf: fix struct/union/fwd types with kind_flag") introduced kind_flag and used bitfield_size in the btf_member to directly pretty print member values. The commit contained a bug where the incorrect parameters could be passed to function btf_bitfield_seq_show(). The bits_

[PATCH bpf 0/3] bpf: fix bpffs/bpftool bitfield value printing

2019-01-10 Thread Yonghong Song
The previous BTF kind_flag support patch set introduced a bug for kernel bpffs pretty printing and another bug for bpftool map pretty printing. If a bitfield struct member offset is greater than 256 bits, printed value for that struct member will be incorrect. Patch #1 fixed the bug in kernel bpff

Re: [PATCH] iavf: Use printf instead of gnu_printf for iavf_debug_d

2019-01-10 Thread Nathan Chancellor
On Thu, Jan 10, 2019 at 10:54:46AM -0800, Nick Desaulniers wrote: > On Wed, Jan 9, 2019 at 8:22 PM Nathan Chancellor > wrote: > > > > Clang warns: > > > > In file included from drivers/net/ethernet/intel/iavf/iavf_main.c:4: > > In file included from drivers/net/ethernet/intel/iavf/iavf.h:37: > > I

Re: [PATCH v2] isdn: avm: Fix string plus integer warning from Clang

2019-01-10 Thread Nick Desaulniers
On Wed, Jan 9, 2019 at 9:42 PM Nathan Chancellor wrote: > > A recent commit in Clang expanded the -Wstring-plus-int warning, showing > some odd behavior in this file. > > drivers/isdn/hardware/avm/b1.c:426:30: warning: adding 'int' to a string does > not append to the string [-Wstring-plus-int] >

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 10, 2019 at 06:40:37PM +, Song Liu escreveu: > > > > On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Wed, Jan 09, 2019 at 11:21:05AM -0800, Song Liu escreveu: > >> For better performance analysis of dynamically JITed and loaded kernel > >> functions

Re: [PATCH] iavf: Use printf instead of gnu_printf for iavf_debug_d

2019-01-10 Thread Nick Desaulniers
On Wed, Jan 9, 2019 at 8:22 PM Nathan Chancellor wrote: > > Clang warns: > > In file included from drivers/net/ethernet/intel/iavf/iavf_main.c:4: > In file included from drivers/net/ethernet/intel/iavf/iavf.h:37: > In file included from drivers/net/ethernet/intel/iavf/iavf_type.h:8: > drivers/net/

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Song Liu
> On Jan 10, 2019, at 10:24 AM, Arnaldo Carvalho de Melo > wrote: > > Em Wed, Jan 09, 2019 at 11:21:05AM -0800, Song Liu escreveu: >> For better performance analysis of dynamically JITed and loaded kernel >> functions, such as BPF programs, this patch introduces >> PERF_RECORD_KSYMBOL, a new

[PATCH v2] Fix ERROR:do not initialise statics to 0 in af_vsock.c

2019-01-10 Thread Lepton Wu
Found by scripts/checkpatch.pl Signed-off-by: Lepton Wu --- net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 43a1dec08825..a60df252d3cc 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/

Re: [PATCH v6 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2019-01-10 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 09, 2019 at 11:21:05AM -0800, Song Liu escreveu: > For better performance analysis of dynamically JITed and loaded kernel > functions, such as BPF programs, this patch introduces > PERF_RECORD_KSYMBOL, a new perf_event_type that exposes kernel symbol > register/unregister information to

Re: [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue

2019-01-10 Thread Cong Wang
On Wed, Jan 9, 2019 at 12:14 AM Toke Høiland-Jørgensen wrote: > > Cong Wang writes: > > > On Mon, Jan 7, 2019 at 11:50 AM Toke Høiland-Jørgensen wrote: > >> @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct > >> Qdisc *sch, > >> if (cl->qdisc->q.qlen != 1) { > >>

Re: [PATCH v2] netfilter: x_tables: add xt_tunnel match

2019-01-10 Thread Pablo Neira Ayuso
On Thu, Jan 10, 2019 at 01:16:08PM +0800, we...@ucloud.cn wrote: [...] > +static struct xt_match tunnel_mt_reg __read_mostly = { > + .name = "tunnel", > + .revision = 0, > + .family = NFPROTO_UNSPEC, > + .match = tunnel_mt, > + .matchsize =

Re: [PATCH] net/core/neighbour: tell kmemleak about hash tables

2019-01-10 Thread Cong Wang
On Tue, Jan 8, 2019 at 1:30 AM Konstantin Khlebnikov wrote: > @@ -443,12 +444,14 @@ static struct neigh_hash_table > *neigh_hash_alloc(unsigned int shift) > ret = kmalloc(sizeof(*ret), GFP_ATOMIC); > if (!ret) > return NULL; > - if (size <= PAGE_SIZE) > +

general protection fault in gro_cells_destroy

2019-01-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14314bab40 kernel config: https://syzkaller.appspot.com/x/.config?x=b03c5892bb940c76 da

general protection fault in rose_send_frame

2019-01-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=13a9acf740 kernel config: https://syzkaller.appspot.com/x/.config?x=b03c5892bb940c76 da

Re: Time based packet transmission - status ?

2019-01-10 Thread Vinicius Costa Gomes
Hi, Jose Abreu writes: > Seems Jesus email no longer exists ... Anyone from netdev working > on TBS ? TBS got renamed to ETF and was merged in time for 4.19 (I think). I am still working on it. > > On 1/10/2019 10:00 AM, Jose Abreu wrote: >> Hi Jesus, >> >> I wonder whats the status of your s

[PATCH 09/11] y2038: remove struct definition redirects

2019-01-10 Thread Arnd Bergmann
We now use 64-bit time_t on all architectures, so the __kernel_timex, __kernel_timeval and __kernel_timespec redirects can be removed after having served their purpose. This makes it all much less confusing, as the __kernel_* types now always refer to the same layout based on 64-bit time_t across

[PATCH 11/11] y2038: add 64-bit time_t syscalls to all 32-bit architectures

2019-01-10 Thread Arnd Bergmann
This adds 21 new system calls on each ABI that has 32-bit time_t today. All of these have the exact same semantics as their existing counterparts, and the new ones all have macro names that end in 'time64' for clarification. This gets us to the point of being able to safely use a C library that ha

[PATCH 10/11] y2038: rename old time and utime syscalls

2019-01-10 Thread Arnd Bergmann
The time, stime, utime, utimes, and futimesat system calls are only used on older architectures, and we do not provide y2038 safe variants of them, as they are replaced by clock_gettime64, clock_settime64, and utimensat_time64. However, for consistency it seems better to have the 32-bit architectu

[PATCH 00/11] y2038: add time64 syscalls

2019-01-10 Thread Arnd Bergmann
This series finally gets us to the point of having system calls with 64-bit time_t on all architectures, after a long time of incremental preparation patches. There was actually one conversion that I missed during the summer, i.e. Deepa's timex series, which I now updated based the 5.0-rc1 changes

[PATCH 06/11] timex: change syscalls to use struct __kernel_timex

2019-01-10 Thread Arnd Bergmann
From: Deepa Dinamani struct timex is not y2038 safe. Switch all the syscall apis to use y2038 safe __kernel_timex. Note that sys_adjtimex() does not have a y2038 safe solution. C libraries can implement it by calling clock_adjtime(CLOCK_REALTIME, ...). Signed-off-by: Deepa Dinamani Signed-off

[PATCH 08/11] y2038: use time32 syscall names on 32-bit

2019-01-10 Thread Arnd Bergmann
This is the big flip, where all 32-bit architectures set COMPAT_32BIT_TIME abd use the _time32 system calls from the former compat layer instead of the system calls that take __kernel_timespec and similar arguments. The temporary redirects for __kernel_timespec, __kernel_itimerspec and __kernel_ti

[PATCH 07/11] y2038: syscalls: rename y2038 compat syscalls

2019-01-10 Thread Arnd Bergmann
A lot of system calls that pass a time_t somewhere have an implementation using a COMPAT_SYSCALL_DEFINEx() on 64-bit architectures, and have been reworked so that this implementation can now be used on 32-bit architectures as well. The missing step is to redefine them using the regular SYSCALL_DEF

[PATCH 03/11] time: fix sys_timer_settime prototype

2019-01-10 Thread Arnd Bergmann
A small typo has crept into the y2038 conversion of the timer_settime system call. So far this was completely harmless, but once we start using the new version, this has to be fixed. Fixes: 6ff847350702 ("time: Change types to new y2038 safe __kernel_itimerspec") Signed-off-by: Arnd Bergmann ---

[PATCH 04/11] sparc64: add custom adjtimex/clock_adjtime functions

2019-01-10 Thread Arnd Bergmann
sparc64 is the only architecture on Linux that has a 'timeval' definition with a 32-bit tv_usec but a 64-bit tv_sec. This causes problems for sparc32 compat mode when we convert it to use the new __kernel_timex type that has the same layout as all other 64-bit architectures. To avoid adding sparc6

[PATCH 05/11] timex: use __kernel_timex internally

2019-01-10 Thread Arnd Bergmann
From: Deepa Dinamani struct timex is not y2038 safe. Replace all uses of timex with y2038 safe __kernel_timex. Note that struct __kernel_timex is an ABI interface definition. We could define a new structure based on __kernel_timex that is only available internally instead. Right now, there isn't

[PATCH 01/11] time: make adjtime compat handling available for 32 bit

2019-01-10 Thread Arnd Bergmann
We want to reuse the compat_timex handling on 32-bit architectures the same way we are using the compat handling for timespec when moving to 64-bit time_t. Move all definitions related to compat_timex out of the compat code into the normal timekeeping code, along with a rename to old_timex32, corr

[PATCH 02/11] time: Add struct __kernel_timex

2019-01-10 Thread Arnd Bergmann
From: Deepa Dinamani struct timex uses struct timeval internally. struct timeval is not y2038 safe. Introduce a new UAPI type struct __kernel_timex that is y2038 safe. struct __kernel_timex uses a timeval type that is similar to struct __kernel_timespec which preserves the same structure size ac

Re: [PATCH net-next] vrf: Add VRF_F_BYPASS_RCV_NF flag to vrf device

2019-01-10 Thread David Ahern
On 1/10/19 8:21 AM, wenxu wrote: > > How about the status of this patch? Should I resubmit it? > I do not like the need for a flag when the VRF is created. If something changes with the firewall rules, it means a user has to delete and re-create the VRF which is really expensive. It would be be

  1   2   >