Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-08 Thread Benjamin Herrenschmidt
On Wed, 2019-01-09 at 15:53 +1100, Alexey Kardashevskiy wrote: > "A PCI completion timeout occurred for an outstanding PCI-E transaction" > it is. > > This is how I bind the device to vfio: > > echo vfio-pci > '/sys/bus/pci/devices/:01:00.0/driver_override' > echo vfio-pci > '/sys/bus/pci/dev

[PATCH net V2] vhost: log dirty page correctly

2019-01-08 Thread Jason Wang
Vhost dirty page logging API is designed to sync through GPA. But we try to log GIOVA when device IOTLB is enabled. This is wrong and may lead to missing data after migration. To solve this issue, when logging with device IOTLB enabled, we will: 1) reuse the device IOTLB translation result of GIO

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-08 Thread Benjamin Herrenschmidt
On Wed, 2019-01-09 at 17:32 +1100, Alexey Kardashevskiy wrote: > I have just moved the "Mellanox Technologies MT27700 Family > [ConnectX-4]" from garrison to firestone machine and there it does not > produce an EEH, with the same kernel and skiboot (both upstream + my > debug). Hm. I cannot really

[PATCH v2] net: ethernet: mediatek: fix warning in phy_start_aneg

2019-01-08 Thread Frank Wunderlich
From: Heiner Kallweit linux 5.0-rc1 shows following warning on bpi-r2/mt7623 bootup: [ 5.170597] WARNING: CPU: 3 PID: 1 at drivers/net/phy/phy.c:548 phy_start_aneg+0x110/0x144 [ 5.178826] called from state READY [ 5.264111] [] (phy_start_aneg) from [] (mtk_init+0x414/0x47c) [ 5.271630] r7

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-08 Thread Alexey Kardashevskiy
On 09/01/2019 16:30, David Gibson wrote: > On Wed, Jan 09, 2019 at 04:09:02PM +1100, Benjamin Herrenschmidt wrote: >> On Mon, 2019-01-07 at 21:01 -0700, Jason Gunthorpe wrote: >>> In a very cryptic way that requires manual parsing using non-public docs sadly but yes. From the look of i

[PATCH] intel-ethernet: warn when fatal read failure happens

2019-01-08 Thread Feng Tang
Failed in read the HW register is very serious for igb/igc driver, as its hw_addr will be set to NULL and cause the adapter be seen as "REMOVED". We saw the error only a few times in the MTBF test for suspend/resume, but can hardly get any useful info to debug. Adding WARN() so that we can get th

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-08 Thread Benjamin Herrenschmidt
On Mon, 2019-01-07 at 21:01 -0700, Jason Gunthorpe wrote: > > > In a very cryptic way that requires manual parsing using non-public > > docs sadly but yes. From the look of it, it's a completion timeout. > > > > Looks to me like we don't get a response to a config space access > > during the chan

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-08 Thread David Gibson
On Wed, Jan 09, 2019 at 04:09:02PM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2019-01-07 at 21:01 -0700, Jason Gunthorpe wrote: > > > > > In a very cryptic way that requires manual parsing using non-public > > > docs sadly but yes. From the look of it, it's a completion timeout. > > > > > > L

Re: Latitude 5495's tg3 hangs under heavy load

2019-01-08 Thread Kai Heng Feng
> On Jan 7, 2019, at 5:12 PM, Siva Reddy Kallam > wrote: > > On Mon, Jan 7, 2019 at 11:34 AM Kai Heng Feng > wrote: >> >> Hi tg3 folks, >> >> Any idea how to solve the bug? >> >> Kai-Heng > Hi, > Can you share Register dump(ethtool -d)? `ethtool -d` before freeze: https://pastebin.com/MS

Re: [PATCHv4 bpf-next 07/13] bpf: Add reference tracking to verifier

2019-01-08 Thread Alexei Starovoitov
On Tue, Oct 02, 2018 at 01:35:35PM -0700, Joe Stringer wrote: > Allow helper functions to acquire a reference and return it into a > register. Specific pointer types such as the PTR_TO_SOCKET will > implicitly represent such a reference. The verifier must ensure that > these references are released

Re: __get_user slower than get_user (was Re: [RFC PATCH V3 0/5] Hi:)

2019-01-08 Thread Linus Torvalds
On Tue, Jan 8, 2019 at 8:31 PM Michael S. Tsirkin wrote: > > Linus, given that you just changed all users of access_ok anyway, do > you still think that the access_ok() conversion to return a speculation > sanitized pointer or NULL is too big a conversion? I didn't actually change a single access

Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]

2019-01-08 Thread Alexey Kardashevskiy
On 06/01/2019 09:43, Benjamin Herrenschmidt wrote: > On Sat, 2019-01-05 at 10:51 -0700, Jason Gunthorpe wrote: >> >>> Interesting. I've investigated this further, though I don't have as >>> many new clues as I'd like. The problem occurs reliably, at least on >>> one particular type of machine

Re: [PATCH v2 5/5] net: dsa: qca8k: disable delay for RGMII mode

2019-01-08 Thread Vinod Koul
Hi Florian, On 08-01-19, 10:00, Florian Fainelli wrote: > On 1/8/19 8:29 AM, Vinod Koul wrote: > > In RGMII mode we should not have any delay in phy, so disable > > the delay. > > This seems to apply to the port's MAC itself, so the commit message > should be mentioning the port's MAC not the PHY

Re: [PATCH net-next v2] Documentation: networking: Clarify switchdev devices behavior

2019-01-08 Thread Florian Fainelli
Le 1/4/19 à 5:58 AM, Ido Schimmel a écrit : > On Thu, Jan 03, 2019 at 02:47:02PM -0800, Florian Fainelli wrote: >> +A switchdev driver can also refuse to support dynamic toggling of the VLAN >> +filtering knob at runtime and require a destruction of the bridge device(s) >> and >> +a creation of ne

[PATCH net-next v3] Documentation: networking: Clarify switchdev devices behavior

2019-01-08 Thread Florian Fainelli
This patch provides details on the expected behavior of switchdev enabled network devices when operating in a "stand alone" mode, as well as when being bridge members. This clarifies a number of things that recently came up during a bug fixing session on the b53 DSA switch driver. Signed-off-by: F

Re: [PATCH v2 4/5] net: phy: at803x: Disable phy delay for RGMII mode

2019-01-08 Thread Vinod Koul
Hi Florian, Thanks for a quick review, On 08-01-19, 09:59, Florian Fainelli wrote: > On 1/8/19 8:29 AM, Vinod Koul wrote: > > + if (phydev->interface == PHY_INTERFACE_MODE_RGMII) { > > + ret = at803x_disable_rx_delay(phydev); > > + if (ret < 0) > > + retur

__get_user slower than get_user (was Re: [RFC PATCH V3 0/5] Hi:)

2019-01-08 Thread Michael S. Tsirkin
On Mon, Jan 07, 2019 at 02:44:24PM -0800, Dan Williams wrote: > On Mon, Jan 7, 2019 at 2:25 PM Michael S. Tsirkin wrote: > > > > On Mon, Jan 07, 2019 at 01:39:15PM -0800, Dan Williams wrote: > > > On Mon, Jan 7, 2019 at 6:11 AM Michael S. Tsirkin wrote: > > > > > > > > On Sun, Jan 06, 2019 at 11:

Re: [PATCH net] bonding: update nest level on unlink

2019-01-08 Thread David Miller
Willem, this was an empty reply to your own patch. Were you trying to say something that I should know?

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Jia-Ju Bai
On 2019/1/9 11:24, Yanjun Zhu wrote: If you have forcedeth NIC, you can make tests with it.:-) Ah, I would like to, but I do not have the hardware... Best wishes, Jia-Ju Bai

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Yanjun Zhu
On 2019/1/9 11:20, Jia-Ju Bai wrote: On 2019/1/9 10:35, Yanjun Zhu wrote: On 2019/1/9 10:03, Jia-Ju Bai wrote: On 2019/1/9 9:24, Yanjun Zhu wrote: On 2019/1/8 20:57, Jia-Ju Bai wrote: On 2019/1/8 20:54, Zhu Yanjun wrote: 在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet/nv

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Jia-Ju Bai
On 2019/1/9 10:35, Yanjun Zhu wrote: On 2019/1/9 10:03, Jia-Ju Bai wrote: On 2019/1/9 9:24, Yanjun Zhu wrote: On 2019/1/8 20:57, Jia-Ju Bai wrote: On 2019/1/8 20:54, Zhu Yanjun wrote: 在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet/nvidia/forcedeth.c, the functions nv_star

Re: [PATCH] packet: Do not leak dev refcounts on error exit

2019-01-08 Thread David Miller
From: Jason Gunthorpe Date: Tue, 8 Jan 2019 23:27:06 + > 'dev' is non NULL when the addr_len check triggers so it must goto a label > that does the dev_put otherwise dev will have a leaked refcount. > > This bug causes the ib_ipoib module to become unloadable when using > systemd-network as

Re: [PATCH] nft_flow_offload: Make flow offload work with vrf slave device correct

2019-01-08 Thread wenxu
Hi pablo, How about the status for this patch?   On 12/29/2018 6:10 PM, we...@ucloud.cn wrote: > From: wenxu > > In the forward chain the iif is changed from slave device to master vrf > device. It will lead the offload not match on lower slave device. > > This patch make the flollowing example

Re: [PATCH] netfilter: x_tables: add xt_tunnel match

2019-01-08 Thread wenxu
Hi pablo, How about the state for this patch? On 12/21/2018 6:12 PM, we...@ucloud.cn wrote: > From: wenxu > > This patch allows us to match on the tunnel metadata that is available > of the packet. We can use this to validate if the packet comes from/goes > to tunnel and the corresponding tunne

[PATCH RESEND] nft_flow_offload: Fix the peer route get from wrong daddr

2019-01-08 Thread wenxu
From: wenxu For nat example: client 1.1.1.7 ---> 2.2.2.7 which dnat to 10.0.0.7 server When syn_rcv pkt from server it get the peer(client->server) route through daddr = ct->tuplehash[!dir].tuple.dst.u3.ip, the value 2.2.2.7 is not correct in this situation. it should be 10.0.0.7 ct->tuplehash[d

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Yanjun Zhu
On 2019/1/9 10:03, Jia-Ju Bai wrote: On 2019/1/9 9:24, Yanjun Zhu wrote: On 2019/1/8 20:57, Jia-Ju Bai wrote: On 2019/1/8 20:54, Zhu Yanjun wrote: 在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet/nvidia/forcedeth.c, the functions nv_start_xmit() and nv_start_xmit_optimized() c

[PATCH net] tcp: change txhash on SYN-data timeout

2019-01-08 Thread Yuchung Cheng
Previously upon SYN timeouts the sender recomputes the txhash to try a different path. However this does not apply on the initial timeout of SYN-data (active Fast Open). Therefore an active IPv6 Fast Open connection may incur one second RTO penalty to take on a new path after the second SYN retrans

[PATCH bpf] bpf: correctly set initial window on active Fast Open sender

2019-01-08 Thread Yuchung Cheng
The existing BPF TCP initial congestion window (TCP_BPF_IW) does not to work on (active) Fast Open sender. This is because it changes the (initial) window only if data_segs_out is zero -- but data_segs_out is also incremented on SYN-data. This patch fixes the issue by proerly accounting for SYN-da

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Jia-Ju Bai
On 2019/1/9 9:24, Yanjun Zhu wrote: On 2019/1/8 20:57, Jia-Ju Bai wrote: On 2019/1/8 20:54, Zhu Yanjun wrote: 在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet/nvidia/forcedeth.c, the functions nv_start_xmit() and nv_start_xmit_optimized() can be concurrently executed with nv_pol

Re: [PATCH net 1/5] net: stmmac: Fix PCI module removal leak

2019-01-08 Thread kbuild test robot
Hi Jose, I love your patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Jose-Abreu/net-stmmac-Misc-fixes/20190109-071238 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce:

Re: [PATCH 1/4] sched: Avoid dereferencing skb pointer after child enqueue

2019-01-08 Thread Cong Wang
On Mon, Jan 7, 2019 at 11:50 AM Toke Høiland-Jørgensen wrote: > @@ -1254,7 +1256,7 @@ static int qfq_enqueue(struct sk_buff *skb, struct > Qdisc *sch, > if (cl->qdisc->q.qlen != 1) { > if (unlikely(skb == cl->qdisc->ops->peek(cl->qdisc)) && Isn't this comparison problema

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-08 Thread Yanjun Zhu
On 2019/1/8 20:57, Jia-Ju Bai wrote: On 2019/1/8 20:54, Zhu Yanjun wrote: 在 2019/1/8 20:45, Jia-Ju Bai 写道: In drivers/net/ethernet/nvidia/forcedeth.c, the functions nv_start_xmit() and nv_start_xmit_optimized() can be concurrently executed with nv_poll_controller(). nv_start_xmit    line

Re: [PATCH v4 0/4] rtlwifi: Fix issues with rtl8723ae

2019-01-08 Thread Larry Finger
On 1/8/19 4:49 PM, Bernd Edlinger wrote: Currently the rtl8723ae driver is broken (since v4.7). Connection to AP is lost very often, especially when the signal level is not very good. The main issue is the power save mode is basically not working, and seems to trigger a firmware bug. So I had t

Re: [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi

2019-01-08 Thread João Paulo Rechi Vita
Hello Marcel, On Wed, Dec 5, 2018 at 11:27 AM João Paulo Rechi Vita wrote: > > Hello Marcel, > > On Fri, Nov 9, 2018 at 4:36 PM João Paulo Rechi Vita > wrote: > > > > Hello Marcel, > > > > On Thu, Nov 8, 2018 at 11:49 PM Marcel Holtmann wrote: > > > > > > our hardware teams from the Bluetooth

[PATCH bpf] selftests/bpf: add missing executables to .gitignore

2019-01-08 Thread Stanislav Fomichev
We build test_libbpf with CXX to make sure linking against C++ works. $ make -s -C tools/lib/bpf $ git status -sb ? tools/lib/bpf/test_libbpf $ make -s -C tools/testing/selftests/bpf $ git status -sb ? tools/lib/bpf/test_libbpf ? tools/testing/selftests/bpf/test_libbpf Fixes: 8c4905b995c6 ("libbp

Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2019-01-08 Thread Song Liu
> On Jan 8, 2019, at 11:43 AM, Peter Zijlstra wrote: > > On Tue, Jan 08, 2019 at 07:10:20PM +, Song Liu wrote: >>> On Jan 8, 2019, at 10:41 AM, Peter Zijlstra wrote: >>> On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote: @@ -986,9 +987,35 @@ enum perf_event_type { */

Re: [PATCH] packet: Do not leak dev refcounts on error exit

2019-01-08 Thread Willem de Bruijn
On Tue, Jan 8, 2019 at 6:41 PM Jason Gunthorpe wrote: > > 'dev' is non NULL when the addr_len check triggers so it must goto a label > that does the dev_put otherwise dev will have a leaked refcount. > > This bug causes the ib_ipoib module to become unloadable when using > systemd-network as it tr

Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2019-01-08 Thread Song Liu
> On Jan 8, 2019, at 12:16 PM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 08, 2019 at 07:10:20PM +, Song Liu escreveu: >>> On Jan 8, 2019, at 10:41 AM, Peter Zijlstra wrote: >>> On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote: @@ -986,9 +987,35 @@ enum perf_event_type {

[PATCH] packet: Do not leak dev refcounts on error exit

2019-01-08 Thread Jason Gunthorpe
'dev' is non NULL when the addr_len check triggers so it must goto a label that does the dev_put otherwise dev will have a leaked refcount. This bug causes the ib_ipoib module to become unloadable when using systemd-network as it triggers this check on InfiniBand links. Fixes: 99137b7888f4 ("pack

[PATCH v1 net] net: dsa: mv88x6xxx: mv88e6390 errata

2019-01-08 Thread Andrew Lunn
The 6390 copper ports have an errata which require poking magic values into undocumented magic registers and then performing a software reset. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 113 +++ drivers/net/dsa/mv88e6xxx/chip.h | 5 ++ drivers

Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-08 Thread Florian Fainelli
On 1/8/19 3:00 PM, Ian Kumlien wrote: > On Tue, Jan 8, 2019 at 11:51 PM Stephen Hemminger > wrote: >> On Tue, 8 Jan 2019 23:10:04 +0100 >> Ian Kumlien wrote: >>> On Sun, Jan 6, 2019 at 11:21 PM Ian Kumlien wrote: [Sorry for the repost, screwed up the netdev address...] Hi, >>

Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-08 Thread Ian Kumlien
On Tue, Jan 8, 2019 at 11:51 PM Stephen Hemminger wrote: > On Tue, 8 Jan 2019 23:10:04 +0100 > Ian Kumlien wrote: > > On Sun, Jan 6, 2019 at 11:21 PM Ian Kumlien wrote: > > > > > > [Sorry for the repost, screwed up the netdev address...] > > > > > > Hi, > > > > > > Switching from 4.19.x -> 4.20

Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-08 Thread Stephen Hemminger
On Tue, 8 Jan 2019 23:10:04 +0100 Ian Kumlien wrote: > On Sun, Jan 6, 2019 at 11:21 PM Ian Kumlien wrote: > > > > [Sorry for the repost, screwed up the netdev address...] > > > > Hi, > > > > Switching from 4.19.x -> 4.20 resulted in DHCP not working for my VM:s. > > > > My firewall (which also r

[PATCH v4 3/4] rtl8723ae: Re-introduce the adaptive rate control

2019-01-08 Thread Bernd Edlinger
This re-introduces the function rtl8723e_dm_refresh_rate_adaptive_mask. This function was present in a previous version of the code base, it works just fine for me -- as long as it is not using stale data. Unlike the original version of this function it avoids using dm.undec_sm_pwdb when no beaco

[PATCH v4 4/4] rtlwifi: Don't clear num_rx_inperiod too early

2019-01-08 Thread Bernd Edlinger
This patch moves the clearing of rtlpriv->link_info.num_rx_inperiod in rtl_watchdog_wq_callback a few lines down. This is necessary since it is still used in the "AP off" detection code block. Moved clearing of rtlpriv->link_info.num_rx_inperiod as well for consistency. Signed-off-by: Bernd Edlin

[PATCH v4 2/4] rtl8723ae: Dont use old data for input gain control

2019-01-08 Thread Bernd Edlinger
When no beacon was received, the value in dm.undec_sm_pwdb is most likely out of date and should not be used to adjust the input path. Assume instead that the signal level is low. Fix the state machine in rtl8723e_dm_cck_packet_detection_thresh which did not clear pre_cck_fa_state when changing cu

[PATCH v4 1/4] rtl8723ae: Take the FW LPS mode handling out

2019-01-08 Thread Bernd Edlinger
This appears to trigger a firmware bug and causes severe problems with rtl8723ae PCI devices. When the power save mode is activated for longer periods of time the firmware stops to receive any packets. This problem was exposed by commit 873ffe154ae0 ("rtlwifi: Fix logic error in enter/exit power-

[PATCH v4 0/4] rtlwifi: Fix issues with rtl8723ae

2019-01-08 Thread Bernd Edlinger
Currently the rtl8723ae driver is broken (since v4.7). Connection to AP is lost very often, especially when the signal level is not very good. The main issue is the power save mode is basically not working, and seems to trigger a firmware bug. So I had to take out the FW LPS mode handling. While

Re: [PATCH bpf] bpf: fix panic in stack_map_get_build_id() on i386 and arm32

2019-01-08 Thread Song Liu
> On Jan 8, 2019, at 2:20 PM, Song Liu wrote: > > As Naresh reported, test_stacktrace_build_id() causes panic on i386 and > arm32 systems. This is caused by page_address() returns NULL in certain > cases. > > This patch fixes this error by using kmap_atomic/kunmap_atomic instead > of page_add

[PATCH bpf] bpf: fix panic in stack_map_get_build_id() on i386 and arm32

2019-01-08 Thread Song Liu
As Naresh reported, test_stacktrace_build_id() causes panic on i386 and arm32 systems. This is caused by page_address() returns NULL in certain cases. This patch fixes this error by using kmap_atomic/kunmap_atomic instead of page_address. Fixes: 615755a77b24 (" bpf: extend stackmap to save binary

Re: [PATCH v3 1/4] rtl8723ae: Take the FW LPS mode handling out

2019-01-08 Thread Bernd Edlinger
On 1/8/19 6:27 PM, Kalle Valo wrote: > Bernd Edlinger writes: > >> This appears to trigger a firmware bug and causes severe >> problems with rtl8723ae PCI devices. >> >> When the power save mode is activated for longer periods >> of time the firmware stops to receive any packets. >> >> This probl

Re: [BUG] v4.20 - bridge not getting DHCP responses? (works in 4.19.13)

2019-01-08 Thread Ian Kumlien
On Sun, Jan 6, 2019 at 11:21 PM Ian Kumlien wrote: > > [Sorry for the repost, screwed up the netdev address...] > > Hi, > > Switching from 4.19.x -> 4.20 resulted in DHCP not working for my VM:s. > > My firewall (which also runs the dhcpd) runs VM:s and it does this by > having physical > interfac

Re: [PATCH net 00/11] mlxsw: Various fixes

2019-01-08 Thread David Miller
From: Ido Schimmel Date: Tue, 8 Jan 2019 16:48:02 + > Patches #1-#2 from Nir fix two bugs in recent ACL work. First patch adds > a missing cleanup in error path, while second patch removes an easily > triggerable false warning. > > Patch #3 from Jiri adds a missing cleanup when unlinking a p

Re: [PATCH v3 0/8] net: y2038-safe socket timestamps

2019-01-08 Thread David Miller
From: Deepa Dinamani Date: Mon, 7 Jan 2019 19:26:49 -0800 > The series introduces new socket timestamps that are > y2038 safe. Great discussion, but this is definitely net-next material and the net-next tree is not open at this time.

[PATCH] mISDN: hfcsusb: Use struct_size() in kzalloc()

2019-01-08 Thread Gustavo A. R. Silva
One of the more common cases of allocation size calculations is finding the size of a structure that has a zero-sized array at the end, along with memory for some number of elements for that array. For example: struct foo { int stuff; void *entry[]; }; instance = kzalloc(sizeof(struct foo

Re: [PATCH net] r8169: load Realtek PHY driver module before r8169

2019-01-08 Thread David Miller
From: Heiner Kallweit Date: Mon, 7 Jan 2019 21:49:09 +0100 > This soft dependency works around an issue where sometimes the genphy > driver is used instead of the dedicated PHY driver. The root cause of > the issue isn't clear yet. People reported the unloading/re-loading > module r8169 helps, an

Re: [PATCH 0/4] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc

2019-01-08 Thread David Miller
From: Toke Høiland-Jørgensen Date: Mon, 7 Jan 2019 20:47:29 +0100 > This series fixes a couple of issues exposed by running sch_cake as a > leaf qdisc in an HFSC tree, which were discovered and reported by Pete > Heist. The interaction between CAKE's GSO splitting and the parent > qdisc's notion

Re: [PATCH] socket: move compat timeout handling into sock.c

2019-01-08 Thread Deepa Dinamani
On Tue, Jan 8, 2019 at 12:10 PM Arnd Bergmann wrote: > > This is a cleanup to prepare for the addition of 64-bit time_t > in O_SNDTIMEO/O_RCVTIMEO. The existing compat handler seems > unnecessarily complex and error-prone, moving it all into the > main setsockopt()/getsockopt() implementation requ

Re: [PATCH v1 net] lan743x: Remove phy_read from link status change function

2019-01-08 Thread David Miller
From: Bryan Whitehead Date: Mon, 7 Jan 2019 14:00:09 -0500 > It has been noticed that some phys do not have the registers > required by the previous implementation. > > To fix this, instead of using phy_read, the required information > is extracted from the phy_device structure. > > fixes: 23f0

Re: [PATCH 2/3] socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes

2019-01-08 Thread Deepa Dinamani
On Tue, Jan 8, 2019 at 12:04 PM Arnd Bergmann wrote: > > On Tue, Jan 8, 2019 at 6:24 AM Deepa Dinamani wrote: > > > > SO_RCVTIMEO and SO_SNDTIMEO socket options use struct timeval > > as the time format. struct timeval is not y2038 safe. > > The subsequent patches in the series add support for ne

[PATCH ipsec 0/1] xfrm: set-mark default behavior changes

2019-01-08 Thread Benedict Wong
A behavior change introduced in 9b42c1f179a6 (“xfrm: Extend the output_mark to support input direction and masking”) results in a change in: 1. Default outbound behavior with regards to route lookup marks, and 2. Inbound behavior for SAs used to decapsulate packets when the output mark (as sp

[PATCH ipsec 1/1] xfrm: Make set-mark default behavior backward compatible

2019-01-08 Thread Benedict Wong
Fixes 9b42c1f179a6, which changed the default route lookup behavior for tunnel mode SAs in the outbound direction to use the skb mark, whereas previously mark=0 was used if the output mark was unspecified. In mark-based routing schemes such as Android’s, this change in default behavior causes routi

Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2019-01-08 Thread Alexei Starovoitov
On 1/8/19 10:41 AM, Peter Zijlstra wrote: > On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote: >> @@ -986,9 +987,35 @@ enum perf_event_type { >> */ >> PERF_RECORD_KSYMBOL = 17, >> >> +/* >> + * Record bpf events: >> + * enum perf_bpf_event_type

Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2019-01-08 Thread Alexei Starovoitov
On 1/8/19 12:29 PM, Peter Zijlstra wrote: > On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote: >> The following example shows kernel symbols for a BPF program with 7 >> sub programs: >> >> a0257cf9 t bpf_prog_b07ccb89267cf242_F >> a02592e1 t bpf_prog_2dcecc18072623f

RE: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-08 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Eugene Syromiatnikov > Sent: Tuesday, January 08, 2019 6:38 AM > To: Richard Cochran > Cc: David Miller ; mlich...@redhat.com; > netdev@vger.kernel.org; Keller, Jacob E ; > mtosa.

Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2019-01-08 Thread Peter Zijlstra
On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote: > The following example shows kernel symbols for a BPF program with 7 > sub programs: > > a0257cf9 t bpf_prog_b07ccb89267cf242_F > a02592e1 t bpf_prog_2dcecc18072623fc_F > a025b0e9 t bpf_prog_bb7a405ebaec

Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2019-01-08 Thread Arnaldo Carvalho de Melo
Em Tue, Jan 08, 2019 at 07:10:20PM +, Song Liu escreveu: > > On Jan 8, 2019, at 10:41 AM, Peter Zijlstra wrote: > > On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote: > >> @@ -986,9 +987,35 @@ enum perf_event_type { > >> */ > >>PERF_RECORD_KSYMBOL = 17, > >>

[PATCH AUTOSEL 4.20 001/117] netfilter: ipset: Allow matching on destination MAC address for mac and ipmac sets

2019-01-08 Thread Sasha Levin
From: Stefano Brivio [ Upstream commit 8cc4ccf58379935f3ad456cc34e61c4e4c921d0e ] There doesn't seem to be any reason to restrict MAC address matching to source MAC addresses in set types bitmap:ipmac, hash:ipmac and hash:mac. With this patch, and this setup: ip netns add A ip link add veth

[PATCH AUTOSEL 4.20 006/117] qtnfmac: fix error handling in control path

2019-01-08 Thread Sasha Levin
From: Sergey Matyukevich [ Upstream commit 1066bd193d681bda0fbacda9df351241a5ee04d9 ] This patch fixes the following warnings: - smatch drivers/net/wireless/quantenna/qtnfmac/commands.c:132 qtnf_cmd_send_with_reply() warn: variable dereferenced before check 'resp' (see line 117) drivers/net/w

[PATCH AUTOSEL 4.20 007/117] ixgbe: allow IPsec Tx offload in VEPA mode

2019-01-08 Thread Sasha Levin
From: Shannon Nelson [ Upstream commit 7fa57ca443cffe81ce8416b57966bfb0370678a1 ] When it's possible that the PF might end up trying to send a packet to one of its own VFs, we have to forbid IPsec offload because the device drops the packets into a black hole. See commit 47b6f50077e6 ("ixgbe: di

[PATCH] socket: move compat timeout handling into sock.c

2019-01-08 Thread Arnd Bergmann
This is a cleanup to prepare for the addition of 64-bit time_t in O_SNDTIMEO/O_RCVTIMEO. The existing compat handler seems unnecessarily complex and error-prone, moving it all into the main setsockopt()/getsockopt() implementation requires half as much code and is easier to extend. 32-bit user spa

[PATCH AUTOSEL 4.20 009/117] e1000e: allow non-monotonic SYSTIM readings

2019-01-08 Thread Sasha Levin
From: Miroslav Lichvar [ Upstream commit e1f65b0d70e9e5c80e15105cd96fa00174d7c436 ] It seems with some NICs supported by the e1000e driver a SYSTIM reading may occasionally be few microseconds before the previous reading and if enabled also pass e1000e_sanitize_systim() without reaching the maxi

[PATCH AUTOSEL 4.20 015/117] bpf: Allow narrow loads with offset > 0

2019-01-08 Thread Sasha Levin
From: Andrey Ignatov [ Upstream commit 46f53a65d2de3e1591636c22b626b09d8684fd71 ] Currently BPF verifier allows narrow loads for a context field only with offset zero. E.g. if there is a __u32 field then only the following loads are permitted: * off=0, size=1 (narrow); * off=0, size=2 (narro

[PATCH AUTOSEL 4.20 011/117] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2019-01-08 Thread Sasha Levin
From: Quentin Monnet [ Upstream commit f96afa767baffba7645f5e10998f5178948bb9aa ] libbpf is now able to load successfully test_l4lb_noinline.o and samples/bpf/tracex3_kern.o. For the test_l4lb_noinline, uncomment related tests from test_libbpf.c and remove the associated "TODO". For tracex3_ke

Re: [PATCH] [v2] netfilter: ipset: fix a missing check of nla_parse

2019-01-08 Thread Kadlecsik József
Hi, On Sat, 5 Jan 2019, Aditya Pakki wrote: > When nla_parse fails, we should not use the results (the first > argument). The fix checks if it fails, and if so, returns its error code > upstream. Patch is applied in the ipset git tree, thanks! Best regards, Jozsef > Signed-off-by: Aditya Pakki

[PATCH AUTOSEL 4.20 029/117] samples: bpf: fix: error handling regarding kprobe_events

2019-01-08 Thread Sasha Levin
From: "Daniel T. Lee" [ Upstream commit 5a863813216ce79e16a8c1503b2543c528b778b6 ] Currently, kprobe_events failure won't be handled properly. Due to calling system() indirectly to write to kprobe_events, it can't be identified whether an error is derived from kprobe or system. // buf = "ec

[PATCH AUTOSEL 4.20 038/117] net: ethernet: ave: Set initial wol state to disabled

2019-01-08 Thread Sasha Levin
From: Kunihiko Hayashi [ Upstream commit 7200f2e3c9e267d29e2bfa075794339032e0b98e ] If wol state of phy hardware is enabled after reset, phy_ethtool_get_wol() returns that wol.wolopts is true. However, since net_device.wol_enabled is zero and this doesn't apply wol state until calling ethtool_s

[PATCH AUTOSEL 4.20 057/117] net: call sk_dst_reset when set SO_DONTROUTE

2019-01-08 Thread Sasha Levin
From: yupeng [ Upstream commit 0fbe82e628c817e292ff588cd5847fc935e025f2 ] after set SO_DONTROUTE to 1, the IP layer should not route packets if the dest IP address is not in link scope. But if the socket has cached the dst_entry, such packets would be routed until the sk_dst_cache expires. So we

[PATCH AUTOSEL 4.20 064/117] bpf: relax verifier restriction on BPF_MOV | BPF_ALU

2019-01-08 Thread Sasha Levin
From: Jiong Wang [ Upstream commit e434b8cdf788568ba65a0a0fd9f3cb41f3ca1803 ] Currently, the destination register is marked as unknown for 32-bit sub-register move (BPF_MOV | BPF_ALU) whenever the source register type is SCALAR_VALUE. This is too conservative that some valid cases will be rejec

Re: [PATCH 2/3] socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes

2019-01-08 Thread Arnd Bergmann
On Tue, Jan 8, 2019 at 6:24 AM Deepa Dinamani wrote: > > SO_RCVTIMEO and SO_SNDTIMEO socket options use struct timeval > as the time format. struct timeval is not y2038 safe. > The subsequent patches in the series add support for new socket > timeout options with _NEW suffix that are y2038 safe. >

[PATCH AUTOSEL 4.20 084/117] netfilter: ipt_CLUSTERIP: check MAC address when duplicate config is set

2019-01-08 Thread Sasha Levin
From: Taehee Yoo [ Upstream commit 06aa151ad1fc74a49b45336672515774a678d78d ] If same destination IP address config is already existing, that config is just used. MAC address also should be same. However, there is no MAC address checking routine. So that MAC address checking routine is added. t

[PATCH AUTOSEL 4.20 085/117] netfilter: ipt_CLUSTERIP: remove wrong WARN_ON_ONCE in netns exit routine

2019-01-08 Thread Sasha Levin
From: Taehee Yoo [ Upstream commit b12f7bad5ad3724d19754390a3e80928525c0769 ] When network namespace is destroyed, both clusterip_tg_destroy() and clusterip_net_exit() are called. and clusterip_net_exit() is called before clusterip_tg_destroy(). Hence cleanup check code in clusterip_net_exit() d

[PATCH AUTOSEL 4.20 086/117] netfilter: ipt_CLUSTERIP: fix deadlock in netns exit routine

2019-01-08 Thread Sasha Levin
From: Taehee Yoo [ Upstream commit 5a86d68bcf02f2d1e9a5897dd482079fd5f75e7f ] When network namespace is destroyed, cleanup_net() is called. cleanup_net() holds pernet_ops_rwsem then calls each ->exit callback. So that clusterip_tg_destroy() is called by cleanup_net(). And clusterip_tg_destroy()

Re: [PATCH v5 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2019-01-08 Thread Peter Zijlstra
On Thu, Dec 20, 2018 at 10:29:00AM -0800, Song Liu wrote: > +static void perf_event_bpf_emit_ksymbols(struct bpf_prog *prog, > + enum perf_bpf_event_type type) > +{ > + bool unregister = type == PERF_BPF_EVENT_PROG_UNLOAD; > + int i; > + > + if (prog

[PATCH AUTOSEL 4.20 105/117] ath10k: fix peer stats null pointer dereference

2019-01-08 Thread Sasha Levin
From: Zhi Chen [ Upstream commit 2d3b55853b123c177037cf534c5aaa2650310094 ] There was a race condition in SMP that an ath10k_peer was created but its member sta was null. Following are procedures of ath10k_peer creation and member sta access in peer statistics path. 1. Peer creation:

[PATCH AUTOSEL 4.20 111/117] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2019-01-08 Thread Sasha Levin
From: Ivan Mironov [ Upstream commit 38355a5f9a22bfa5bd5b1bb79805aca39fa53729 ] This happened when I tried to boot normal Fedora 29 system with latest available kernel (from fedora rawhide, plus some unrelated custom patches): BUG: unable to handle kernel NULL pointer dereference at 00

[PATCH AUTOSEL 4.19 01/97] netfilter: ipset: Allow matching on destination MAC address for mac and ipmac sets

2019-01-08 Thread Sasha Levin
From: Stefano Brivio [ Upstream commit 8cc4ccf58379935f3ad456cc34e61c4e4c921d0e ] There doesn't seem to be any reason to restrict MAC address matching to source MAC addresses in set types bitmap:ipmac, hash:ipmac and hash:mac. With this patch, and this setup: ip netns add A ip link add veth

[PATCH AUTOSEL 4.19 05/97] ixgbe: allow IPsec Tx offload in VEPA mode

2019-01-08 Thread Sasha Levin
From: Shannon Nelson [ Upstream commit 7fa57ca443cffe81ce8416b57966bfb0370678a1 ] When it's possible that the PF might end up trying to send a packet to one of its own VFs, we have to forbid IPsec offload because the device drops the packets into a black hole. See commit 47b6f50077e6 ("ixgbe: di

[PATCH AUTOSEL 4.19 07/97] e1000e: allow non-monotonic SYSTIM readings

2019-01-08 Thread Sasha Levin
From: Miroslav Lichvar [ Upstream commit e1f65b0d70e9e5c80e15105cd96fa00174d7c436 ] It seems with some NICs supported by the e1000e driver a SYSTIM reading may occasionally be few microseconds before the previous reading and if enabled also pass e1000e_sanitize_systim() without reaching the maxi

[PATCH AUTOSEL 4.19 09/97] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2019-01-08 Thread Sasha Levin
From: Quentin Monnet [ Upstream commit f96afa767baffba7645f5e10998f5178948bb9aa ] libbpf is now able to load successfully test_l4lb_noinline.o and samples/bpf/tracex3_kern.o. For the test_l4lb_noinline, uncomment related tests from test_libbpf.c and remove the associated "TODO". For tracex3_ke

[PATCH AUTOSEL 4.19 13/97] bpf: Allow narrow loads with offset > 0

2019-01-08 Thread Sasha Levin
From: Andrey Ignatov [ Upstream commit 46f53a65d2de3e1591636c22b626b09d8684fd71 ] Currently BPF verifier allows narrow loads for a context field only with offset zero. E.g. if there is a __u32 field then only the following loads are permitted: * off=0, size=1 (narrow); * off=0, size=2 (narro

[PATCH AUTOSEL 4.19 22/97] samples: bpf: fix: error handling regarding kprobe_events

2019-01-08 Thread Sasha Levin
From: "Daniel T. Lee" [ Upstream commit 5a863813216ce79e16a8c1503b2543c528b778b6 ] Currently, kprobe_events failure won't be handled properly. Due to calling system() indirectly to write to kprobe_events, it can't be identified whether an error is derived from kprobe or system. // buf = "ec

[PATCH AUTOSEL 4.19 45/97] net: call sk_dst_reset when set SO_DONTROUTE

2019-01-08 Thread Sasha Levin
From: yupeng [ Upstream commit 0fbe82e628c817e292ff588cd5847fc935e025f2 ] after set SO_DONTROUTE to 1, the IP layer should not route packets if the dest IP address is not in link scope. But if the socket has cached the dst_entry, such packets would be routed until the sk_dst_cache expires. So we

[PATCH AUTOSEL 4.19 52/97] bpf: relax verifier restriction on BPF_MOV | BPF_ALU

2019-01-08 Thread Sasha Levin
From: Jiong Wang [ Upstream commit e434b8cdf788568ba65a0a0fd9f3cb41f3ca1803 ] Currently, the destination register is marked as unknown for 32-bit sub-register move (BPF_MOV | BPF_ALU) whenever the source register type is SCALAR_VALUE. This is too conservative that some valid cases will be rejec

[PATCH AUTOSEL 4.19 69/97] netfilter: ipt_CLUSTERIP: remove wrong WARN_ON_ONCE in netns exit routine

2019-01-08 Thread Sasha Levin
From: Taehee Yoo [ Upstream commit b12f7bad5ad3724d19754390a3e80928525c0769 ] When network namespace is destroyed, both clusterip_tg_destroy() and clusterip_net_exit() are called. and clusterip_net_exit() is called before clusterip_tg_destroy(). Hence cleanup check code in clusterip_net_exit() d

[PATCH AUTOSEL 4.19 68/97] netfilter: ipt_CLUSTERIP: check MAC address when duplicate config is set

2019-01-08 Thread Sasha Levin
From: Taehee Yoo [ Upstream commit 06aa151ad1fc74a49b45336672515774a678d78d ] If same destination IP address config is already existing, that config is just used. MAC address also should be same. However, there is no MAC address checking routine. So that MAC address checking routine is added. t

[PATCH AUTOSEL 4.19 70/97] netfilter: ipt_CLUSTERIP: fix deadlock in netns exit routine

2019-01-08 Thread Sasha Levin
From: Taehee Yoo [ Upstream commit 5a86d68bcf02f2d1e9a5897dd482079fd5f75e7f ] When network namespace is destroyed, cleanup_net() is called. cleanup_net() holds pernet_ops_rwsem then calls each ->exit callback. So that clusterip_tg_destroy() is called by cleanup_net(). And clusterip_tg_destroy()

[PATCH AUTOSEL 4.19 89/97] ath10k: fix peer stats null pointer dereference

2019-01-08 Thread Sasha Levin
From: Zhi Chen [ Upstream commit 2d3b55853b123c177037cf534c5aaa2650310094 ] There was a race condition in SMP that an ath10k_peer was created but its member sta was null. Following are procedures of ath10k_peer creation and member sta access in peer statistics path. 1. Peer creation:

[PATCH AUTOSEL 4.14 03/53] e1000e: allow non-monotonic SYSTIM readings

2019-01-08 Thread Sasha Levin
From: Miroslav Lichvar [ Upstream commit e1f65b0d70e9e5c80e15105cd96fa00174d7c436 ] It seems with some NICs supported by the e1000e driver a SYSTIM reading may occasionally be few microseconds before the previous reading and if enabled also pass e1000e_sanitize_systim() without reaching the maxi

[PATCH AUTOSEL 4.14 24/53] net: call sk_dst_reset when set SO_DONTROUTE

2019-01-08 Thread Sasha Levin
From: yupeng [ Upstream commit 0fbe82e628c817e292ff588cd5847fc935e025f2 ] after set SO_DONTROUTE to 1, the IP layer should not route packets if the dest IP address is not in link scope. But if the socket has cached the dst_entry, such packets would be routed until the sk_dst_cache expires. So we

  1   2   3   >