There are two new Realtek Ethernet devices which are re-branded r8168h.
Add the IDs to to support them.
Signed-off-by: Kai-Heng Feng
---
drivers/net/ethernet/realtek/r8169.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/realtek/r8169.c
b/drivers/net/ethernet/realtek
On 02.01.2019 00:36, Andrew Lunn wrote:
>>> Is there a .ndo_change_mtu callback, which does not assign a new mtu itself?
>>>
>> So far all drivers have to do it themselves. But IMO this is more a
>> workaround
>> for the core not doing it. It's something the core should do.
>> Now we can remove th
On 12/31/18 5:37 PM, Jakub Kicinski wrote:
> Instead of overwriting dead code with jmp -1 instructions
> remove it completely for root. Adjust verifier state and
> line info appropriately.
>
> v2:
> - adjust func_info (Alexei);
> - make sure first instruction retains line info (Alexei).
> v
syzbot has found a reproducer for the following crash on:
HEAD commit:28e8c4bc8eb4 Merge tag 'rtc-4.21' of git://git.kernel.org/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1745f5bf40
kernel config: https://syzkaller.appspot.com/x/.config?x=c2ab97
From: wenxu
ip l add dev tun type gretap external
ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap
For gretap example when the command set the id but don't set the
TUNNEL_KEY flags. There is no key field in the send packet
User can set flags with key, csum, seq
ip r a 10.0.0.1 en
Small pull request this time around with only two commits; some missing
prototype warning fix and a syzkaller fix when a 9p server advertises a
too small msize.
The commit date is close-ish because I reworded a commit message to
add a Cc to stable for the msize fix recently, but the patchs themsel
If there is no shutdown callback, our board will report pcie UNF errors
after restarting. This patch add shutdown callback for hinic.
Signed-off-by: Xue Chaojing
---
drivers/net/ethernet/huawei/hinic/hinic_main.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/huaw
On 2018/12/31 下午5:51, Jesper Dangaard Brouer wrote:
Hi MST and Jason,
Could you please take a look at this? This bug is caused by a thread
resizing the tun-queue (via tun_queue_resize -> ptr_ring_resize_multiple).
And error happens in tun_net_xmit -> ptr_ring_produce. My guess is bug
happens
On 2018/12/31 上午2:48, Michael S. Tsirkin wrote:
On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote:
On 2018/12/26 下午11:22, Michael S. Tsirkin wrote:
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
On 2018/12/6 上午6:54, Michael S. Tsirkin wrote:
When use_napi is set, let's
On 2018/12/31 上午2:45, Michael S. Tsirkin wrote:
On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote:
On 2018/12/26 下午11:19, Michael S. Tsirkin wrote:
On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
On 2018/12/6 上午6:54, Michael S. Tsirkin wrote:
When use_napi is set, let's
On 2018/12/31 上午2:40, Michael S. Tsirkin wrote:
On Thu, Dec 27, 2018 at 05:55:52PM +0800, Jason Wang wrote:
On 2018/12/26 下午11:06, Michael S. Tsirkin wrote:
On Wed, Dec 26, 2018 at 12:03:50PM +0800, Jason Wang wrote:
On 2018/12/26 上午12:41, Michael S. Tsirkin wrote:
Hi!
I was just wondering:
On 12/31/18 12:27 AM, Tariq Toukan wrote:
>
>
> On 1/27/2018 2:41 PM, jianchao.wang wrote:
>> Hi Tariq
>>
>> Thanks for your kindly response.
>> That's really appreciated.
>>
>> On 01/25/2018 05:54 PM, Tariq Toukan wrote:
>>>
>>>
>>> On 25/01/2018 8:25 AM, jianchao.wang wrote:
Hi Eric
>>>
I have created multiple namespaces:
sharpd@robot /v/l/frr> ip netns list
two (id: 2)
one (id: 1)
EVA (id: 0)
And am running a process in namespace two that creates a named socket
`/var/log/frr/run/zserv.api`:
sharpd@robot ~/frr> sudo ip netns exec two /usr/lib/frr/zebra -N two
--daemon -A 127.0.
Am 31.12.18 um 23:56 schrieb Andreas Färber:
> Am 31.12.18 um 18:50 schrieb Mark Brown:
>> On Sun, Dec 30, 2018 at 11:55:46AM +0100, Andreas Färber wrote:
>>> Given that observed symptoms were CPU stalls, workqueue hangs and RCU
>>> problems, requiring a power-cycle to recover, I wonder whether we
> > Is there a .ndo_change_mtu callback, which does not assign a new mtu itself?
> >
> So far all drivers have to do it themselves. But IMO this is more a workaround
> for the core not doing it. It's something the core should do.
> Now we can remove this from drivers.
Hi Heiner
I think somebody
On Tue, Jan 01, 2019 at 03:18:51PM +0530, Murali Krishna Policharla wrote:
> Hi Andrew,
>Currently net/dsa/slave.c does not have
> ndo_change_mtu function. But shortly I will be submitting a separate
> patch outside this fix that has ndo_change_mtu function support adde
Jann reported that the original commit back in b2157399cc98
("bpf: prevent out-of-bounds speculation") was not sufficient
to stop CPU from speculating out of bounds memory access:
While b2157399cc98 only focussed on masking array map access
for unprivileged users for tail calls and data access such
Right now we are using BPF ax register in JIT for constant blinding as
well as in interpreter as temporary variable. Verifier will not be able
to use it simply because its use will get overridden from the former in
bpf_jit_blind_insn(). However, it can be made to work in that blinding
will be skipp
This change moves the on-stack 64 bit tmp variable in ___bpf_prog_run()
into the hidden ax register. The latter is currently only used in JITs
for constant blinding as a temporary scratch register, meaning the BPF
interpreter will never see the use of ax. Therefore it is safe to use
it for the case
Restrict map value pointer arithmetic for unprivileged users in that
arithmetic itself must not go out of bounds as opposed to the actual
access later on. Therefore after each adjust_ptr_min_max_vals() with a
map value pointer as a destination it will simulate a check_map_access()
of 1 byte on the
For unknown scalars of mixed signed bounds, meaning their smin_value is
negative and their smax_value is positive, we need to reject arithmetic
with pointer to map value. For unprivileged the goal is to mask every
map pointer arithmetic and this cannot reliably be done when it is
unknown at verific
In check_map_access() we probe actual bounds through __check_map_access()
with offset of reg->smin_value + off for lower bound and offset of
reg->umax_value + off for the upper bound. However, even though the
reg->smin_value could have a negative value, the final result of the
sum with off could be
Add various map value pointer related test cases to test_verifier
kselftest to reflect recent changes and improve test coverage. The
tests include basic masking functionality, unprivileged behavior
on pointer arithmetic which goes oob, mixed bounds tests, negative
unknown scalar but resulting posit
Move prev_insn_idx and insn_idx from the do_check() function into
the verifier environment, so they can be read inside the various
helper functions for handling the instructions. It's easier to put
this into the environment rather than changing all call-sites only
to pass it along. insn_idx is usef
Restrict stack pointer arithmetic for unprivileged users in that
arithmetic itself must not go out of bounds as opposed to the actual
access later on. Therefore after each adjust_ptr_min_max_vals() with
a stack pointer as a destination we simulate a check_stack_access()
of 1 byte on the destination
This set fixes an out of bounds case under speculative execution
by implementing masking of pointer alu into the verifier. For
details please see the individual patches.
Thanks!
v1 -> v2:
- Typo fixes in commit msg and a comment, thanks David!
Daniel Borkmann (9):
bpf: move {prev_,}insn_idx
On 01/01/2019 10:20 PM, David Miller wrote:
> From: Daniel Borkmann
> Date: Tue, 1 Jan 2019 21:49:21 +0100
>
>> Restrict stack pointer arithmetic for unpriviledged users in that
>> arithmetic itself must not go out of bounds as opposed to the actual
>> access later on. Therefore after each adjus
From: Mark Boldyrev
Date: Tue, 1 Jan 2019 16:52:02 +0200
> From 24d036bfca48c4893d3e675ddc8ff1c394d66757 Mon Sep 17 00:00:00 2001
> From: Mark Boldyrev
> Date: Tue, 1 Jan 2019 16:08:53 +0200
> Subject: [PATCH] atl1c: fix typo driection -> direction
>
> The code of the atl1c driver contains a ty
From: Murali Krishna Policharla
Date: Tue, 1 Jan 2019 12:12:14 +0530
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
>
> Fixes: 2315dc91a5 ("net: make dev_set_mtu() honor notification return code")
> Signed-off-by: Murali Krishna
Hi Woojung,
> woojung@microchip.com hat am 30. Dezember 2018 um 04:25 geschrieben:
>
>
> HI Marc & Stephen,
>
> Most of engineers are out until New Year's Day.
thanks. I didn't expect a reply that fast.
>
> LAN78xx driver uses irq_domain for phy interrupt, but smsc95xx uses polling.
> N
From: Daniel Borkmann
Date: Tue, 1 Jan 2019 21:49:21 +0100
> Restrict stack pointer arithmetic for unpriviledged users in that
> arithmetic itself must not go out of bounds as opposed to the actual
> access later on. Therefore after each adjust_ptr_min_max_vals() with
> a stack pointer as a dest
From: Daniel Borkmann
Date: Tue, 1 Jan 2019 21:49:19 +0100
> diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
> index a34312a..4e6f29a 100644
> --- a/kernel/bpf/core.c
> +++ b/kernel/bpf/core.c
> @@ -858,6 +858,26 @@ static int bpf_jit_blind_insn(const struct bpf_insn
> *from,
> BUILD_B
Add various map value pointer related test cases to test_verifier
kselftest to reflect recent changes and improve test coverage. The
tests include basic masking functionality, unprivileged behavior
on pointer arithmetic which goes oob, mixed bounds tests, negative
unknown scalar but resulting posit
Move prev_insn_idx and insn_idx from the do_check() function into
the verifier environment, so they can be read inside the various
helper functions for handling the instructions. It's easier to put
this into the environment rather than changing all call-sites only
to pass it along. insn_idx is usef
Restrict map value pointer arithmetic for unpriviledged users in that
arithmetic itself must not go out of bounds as opposed to the actual
access later on. Therefore after each adjust_ptr_min_max_vals() with a
map value pointer as a destination it will simulate a check_map_access()
of 1 byte on the
Right now we are using BPF ax register in JIT for constant blinding as
well as in interpeter as temporary variable. Verifier will not be able
to use it simply because its use will get overridden from the former in
bpf_jit_blind_insn(). However, it can be made to work in that blinding
will be skippe
This change moves the on-stack 64 bit tmp variable in ___bpf_prog_run()
into the hidden ax register. The latter is currently only used in JITs
for constant blinding as a temporary scratch register, meaning the BPF
interpreter will never see the use of ax. Therefore it is safe to use
it for the case
In check_map_access() we probe actual bounds through __check_map_access()
with offset of reg->smin_value + off for lower bound and offset of
reg->umax_value + off for the upper bound. However, even though the
reg->smin_value could have a negative value, the final result of the
sum with off could be
Jann reported that the original commit back in b2157399cc98
("bpf: prevent out-of-bounds speculation") was not sufficient
to stop CPU from speculating out of bounds memory access:
While b2157399cc98 only focussed on masking array map access
for unprivileged users for tail calls and data access such
This set fixes an out of bounds case under speculative execution
by implementing masking of pointer alu into the verifier. For
details please see the individual patches.
Thanks!
Daniel Borkmann (9):
bpf: move {prev_,}insn_idx into verifier env
bpf: move tmp variable into ax register in interp
Restrict stack pointer arithmetic for unpriviledged users in that
arithmetic itself must not go out of bounds as opposed to the actual
access later on. Therefore after each adjust_ptr_min_max_vals() with
a stack pointer as a destination we simulate a check_stack_access()
of 1 byte on the destinatio
For unknown scalars of mixed signed bounds, meaning their smin_value is
negative and their smax_value is positive, we need to reject arithmetic
with pointer to map value. For unpriviledged the goal is to mask every
map pointer arithmetic and this cannot reliably be done when it is
unknown at verifi
From: Huazhong Tan
Date: Mon, 31 Dec 2018 10:58:29 +0800
> For HNAE3_DOWN_CLIENT calling hns3_nic_net_stop(), HNAE3_UP_CLIENT
> should call hns3_nic_net_open(), since if the number of queue or
> the map of TC has is changed before HHAE3_UP_CLIENT is called,
> it will cause problem.
>
> Also the
From: Willem de Bruijn
Date: Sun, 30 Dec 2018 17:24:36 -0500
> From: Willem de Bruijn
>
> KMSAN detected read beyond end of buffer in vti and sit devices when
> passing truncated packets with PF_PACKET. The issue affects additional
> ip tunnel devices.
>
> Extend commit 76c0ddd8c3a6 ("ip6_tunn
From: Willem de Bruijn
Date: Sun, 30 Dec 2018 17:21:05 -0500
> From: Willem de Bruijn
>
> The BPF flow dissector expects either skb->sk or skb->dev set on
> all skbs. Delay flow dissection until after skb->dev is set.
>
> This requires calling from within an rcu read-side critical section.
> T
From: Cong Wang
Date: Sun, 30 Dec 2018 12:43:42 -0800
> __ptr_ring_swap_queue() tries to move pointers from the old
> ring to the new one, but it forgets to check if ->producer
> is beyond the new size at the end of the operation. This leads
> to an out-of-bound access in __ptr_ring_produce() as
Hi
Yes it did work since I remember (like around 2.4.x) and it changed
since I moved from Debian 8 to 9. I would appreciate fixing that in the
future beacuse it is essential for queueing traffic on the routers, but
the question is why these filters don`t work in that case:
tc filter add d
On Mon, Dec 31, 2018 at 10:13 AM Bartek Kois wrote:
>
> Hi,
> I tested 4.20 and the problem remains (it is not possible to classify
> tagged packets if the root filter is on physical interface).
Hmm, I guess it is because the offset used by u32 filter is no
longer accurate when vlan tag is insert
On Sun, Dec 30, 2018 at 4:52 PM Michael S. Tsirkin wrote:
> So when we allocated one extra entry it was fine, thus maybe we should rather
> list:
>
> Fixes: 9fb582b67072 ("Revert "net: ptr_ring: otherwise safe empty checks can
> overrun array bounds"")
>
>
Good point, I totally forgot we once a
From: Zhu Yanjun
Date: Sun, 30 Dec 2018 23:24:11 +0800
> In kfree, the NULL check is done.
>
> Signed-off-by: Zhu Yanjun
Applied.
From: Radu Rendec
Date: Sat, 29 Dec 2018 13:26:34 -0500
> I'm working on some application-specific NIC driver. On the TX path, it
> must remove a custom tag that sits between the Ethernet type field and
> the actual Ethernet payload; then it must add a different tag in front
> of the Ethernet hea
From: yupeng
Date: Sat, 29 Dec 2018 21:46:38 -0800
> add document and examples for below counters:
> TcpExtTCPOFOQueue
> TcpExtTCPOFODrop
> TcpExtTCPOFOMerge
> TcpExtPAWSActive
> TcpExtPAWSEstab
> TcpExtTCPACKSkippedSynRecv
> TcpExtTCPACKSkippedPAWS
> TcpExtTCPACKSkippedSeq
> TcpExtTCPACKSkippedF
From: Deepa Dinamani
Date: Thu, 27 Dec 2018 18:55:09 -0800
> Al Viro mentioned (Message-ID
> <20170626041334.gz10...@zeniv.linux.org.uk>)
> that there is probably a race condition
> lurking in accesses of sk_stamp on 32-bit machines.
>
> sock->sk_stamp is of type ktime_t which is always an s64.
Support for new (4.19+) xfrm virtual interfaces.
Interfaces take a 'if_id' which is an interface id which can be set on
an xfrm policy as its interface lookup key (XFRMA_IF_ID).
Signed-off-by: Matt Ellison
---
ip/Makefile | 2 +-
ip/iplink.c
On Tue, 1 Jan 2019 21:27:15 +0800
we...@ucloud.cn wrote:
> + if (flags & TUNNEL_KEY)
> + print_string(PRINT_ANY, "key", "%s ", "key");
> + if (flags & TUNNEL_CSUM)
> + print_string(PRINT_ANY, "csum", "%s ", "csum");
> + i
Hi,
> I see the problem. The check on the address bind is not considering the
> L3 domain - or even the device at all. That's why binding to an address
> in the default VRF works, but bind to an address in a VRF fails
> (requires an l3mdev match). Not sure how this has fallen through the
> cracks
On 1/1/19 7:58 AM, Ralf Jung wrote:
> If instead, in the last line, I use the IPv6 address of eth0 (which is not
> inside this VRF), the `bind` call succeeds. On the other hand, when I try
> using
> the eth0 IPv4 address in the first block, `bind` fails as expected because the
> address is not in
Commit 377a09902a57 (lines 72 through 76) included a minor code cleanup
to configure, this caused the following error when running ./configure:
grep: grep: No such file or directory
grep: TC_CONFIG_XT: No such file or directory
This patch fixes the error shown above caused by commit 377a09902a57.
Signed-off-by: Firas Khalil Khana
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index b85eb58b..45fcffb6 100755
--- a/configure
+++ b/configure
@@ -115,7 +115,7 @@ EOF
check_xt_old_internal_h()
{
# bail if previous XT checks has alr
Hi all,
I am experiencing trouble with using Bird over IPv6 inside a VRF, and reduced
this down to a problem with IPv6 `bind`.
I have a VRF called "vrf_freifunk", with some GRE tunnel devices in it:
> 3: vrf_freifunk: mtu 65536 qdisc noqueue state UP
> group default qlen 1000
> link/ether
>From 24d036bfca48c4893d3e675ddc8ff1c394d66757 Mon Sep 17 00:00:00 2001
From: Mark Boldyrev
Date: Tue, 1 Jan 2019 16:08:53 +0200
Subject: [PATCH] atl1c: fix typo driection -> direction
The code of the atl1c driver contains a typo which is fixed in this patch.
Signed-off-by: Mark Boldyrev
---
On 01.01.2019 12:13, firas...@gmail.com wrote:
> From: Firas Khalil Khana
>
> Fixes: 377a09902a57 ("configure: Minor code cleanup")
>
I think the patch should be annotated iproute2 to make clear
it's not about the kernel. And it's missing a description
which issue was fixed.
> Signed-off-by: Fi
Hi, William. Nice work.
I have some feedback and questions.
On 18/12/27 (木) 5:27:49, William Tu wrote:
The patch adds support for AF_XDP async xmit. Users can use
AF_XDP on both sides of the veth and get better performance, with
the cost of ksoftirqd doing the xmit. The veth_xsk_async_xmit
sim
From: wenxu
ip l add dev tun type gretap external
ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap
For gretap example when the command set the id but don't set the
TUNNEL_KEY flags. There is no key field in the send packet
User can set flags with key, csum, seq
ip r a 10.0.0.1 en
On 12/21/2018 10:35 AM, Xiaozhou Liu wrote:
> As a simple fix, just print the correct map type.
>
> Signed-off-by: Xiaozhou Liu
Applied to bpf, thanks!
From: Firas Khalil Khana
Fixes: 377a09902a57 ("configure: Minor code cleanup")
Signed-off-by: Firas Khalil Khana
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index b85eb58b..45fcffb6 100755
--- a/configure
+++ b/configure
@@ -115,7 +11
Ok, I will check.
On Tue, Jan 1, 2019 at 8:00 AM Stephen Hemminger
wrote:
>
> On Thu, 27 Dec 2018 15:18:51 +0200
> Firas Khalil Khana wrote:
>
> I want to take this patch, but it is missing the Signed-Off-by: required
> for this project.
>
> Also please add:
>
> Fixes: 377a09902a57 ("configure:
On 1/1/2019 3:47 AM, Jakub Kicinski wrote:
> On Mon, 31 Dec 2018 16:32:13 +0200, Eran Ben Elisha wrote:
>> +Once an error is reported, devlink health will do the following actions:
>> + * A log is being send to the kernel trace events buffer
>> + * Health status and statistics are being updated
On 1/1/2019 3:47 AM, Jakub Kicinski wrote:
> On Mon, 31 Dec 2018 16:31:54 +0200, Eran Ben Elisha wrote:
>> The health mechanism is targeted for Real Time Alerting, in order to know
>> when
>> something bad had happened to a PCI device
>> - Provide alert debug information
>> - Self healing
>> - I
Hi Andrew,
Currently net/dsa/slave.c does not have
ndo_change_mtu function. But shortly I will be submitting a separate
patch outside this fix that has ndo_change_mtu function support added to
DSA switch. As part of testing the newly added ndo_change_mtu function
for DS
On 01.01.2019 08:54, Kirill Tkhai wrote:
> On 01.01.2019 09:42, Murali Krishna Policharla wrote:
>> Store newly configured mtu settings in the netdevice after mtu
>> configuration is successful to the dsa switch.
>>
>> Fixes: 2315dc91a5 ("net: make dev_set_mtu() honor notification return code")
>>
On 01.01.2019 07:42, Murali Krishna Policharla wrote:
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
>
At first: good that this is fixed, so far each network driver
had to do the "dev->mtu = new_mtu" in its ndo_change_mtu
callback
On Tue, Jan 01, 2019 at 12:12:14PM +0530, Murali Krishna Policharla wrote:
> Store newly configured mtu settings in the netdevice after mtu
> configuration is successful to the dsa switch.
Hi Murali
Please could you give more details. net/dsa/slave.c does not have a
ndo_change_mtu function, so i
73 matches
Mail list logo
