On Mon, Dec 31, 2018 at 8:42 AM syzbot
wrote:
>
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit:ef4ab8447aa2 selftests: bpf: install script with_addr.sh
> git tree: bpf-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=14a28b6e40
> kernel config: htt
Hello,
syzbot found the following crash on:
HEAD commit:ef4ab8447aa2 selftests: bpf: install script with_addr.sh
git tree: bpf-next
console output: https://syzkaller.appspot.com/x/log.txt?x=14a28b6e40
kernel config: https://syzkaller.appspot.com/x/.config?x=7e7e2279c0020d5f
dashbo
(email is bouncing due to URL in the body of the message, so using hash
instead).
Hi Netdev,
Issue: getsockopt(fd, SOL_IP, SO_ORIGINAL_DST, sa, &salen) is in fact sometimes
returning the source IP instead the destination IP
Using below version of,
~# lsb_release -rd
Description: Ubuntu 18.04.1
Hello,
syzbot found the following crash on:
HEAD commit:903b77c63167 Merge tag 'linux-kselftest-4.21-rc1' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=168acbdd40
kernel config: https://syzkaller.appspot.com/x/.config?x=53a2f2aa0b1f7606
da
From: Heiner Kallweit
Date: Sun, 30 Dec 2018 13:16:12 +0100
> In rtl8169_runtime_resume() we configure WoL but don't set the device
> to wakeup-enabled. This prevents PME generation once the cable is
> re-plugged. Fix this by moving the call to device_set_wakeup_enable()
> to __rtl8169_set_wol().
From: Cong Wang
Date: Sat, 29 Dec 2018 13:56:38 -0800
> nr_find_socket(), nr_find_peer() and nr_find_listener() lock the
> sock after finding it in the global list. However, the call path
> requires BH disabled for the sock lock consistently.
>
> Actually the locking is unnecessary at this point
From: Cong Wang
Date: Sat, 29 Dec 2018 13:56:37 -0800
> When x25_asy_open() fails, it already cleans up by itself,
> so its caller doesn't need to free the memory again.
>
> It seems we still have to call x25_asy_free() to clear the SLF_INUSE
> bit, so just set these pointers to NULL after kfree
From: Peng Hao
Date: Sat, 29 Dec 2018 16:47:32 +0800
> +static struct resource *ucc_get_resource_by_nodename(char *name)
> +{
> + struct device_node *np;
> + struct platform_device *pdev;
> +
> + np = of_find_compatible_node(NULL, NULL, name);
> + if (!np)
> + return E
Hello,
syzbot found the following crash on:
HEAD commit:eed9688f8513 Merge branch 'ras-core-for-linus' of git://gi..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10785d5740
kernel config: https://syzkaller.appspot.com/x/.config?x=fa5c63e12fd85b25
da
Hello,
syzbot found the following crash on:
HEAD commit:eed9688f8513 Merge branch 'ras-core-for-linus' of git://gi..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=103bffaf40
kernel config: https://syzkaller.appspot.com/x/.config?x=fa5c63e12fd85b25
da
Hello,
syzbot found the following crash on:
HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1270bbdd40
kernel config: https://syzkaller.appspot.com/x/.config?x=fbee5876573727cd
da
Hello,
syzbot found the following crash on:
HEAD commit:f7d18ef6a95f Merge git://git.kernel.org/pub/scm/linux/kern..
git tree: net
console output: https://syzkaller.appspot.com/x/log.txt?x=152cb86f40
kernel config: https://syzkaller.appspot.com/x/.config?x=4b137b8ba637eb77
dashboa
Hi Aditya,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
head: c433570458e49bccea5c551df628d058b3526289
commit: f0fb9b288d0a7e9cc324ae362e2dfd2cc2217ded [2/22] ipv6/route: Add a
missing check on proc_dointvec
config: ia64-a
For HNAE3_DOWN_CLIENT calling hns3_nic_net_stop(), HNAE3_UP_CLIENT
should call hns3_nic_net_open(), since if the number of queue or
the map of TC has is changed before HHAE3_UP_CLIENT is called,
it will cause problem.
Also the HNS3_NIC_STATE_RESETTING flag needs to be cleared before
hns3_nic_net_o
From: Arthur Gautier
This commit fixes a regression in AF_INET/RTM_GETADDR and
AF_INET6/RTM_GETADDR.
Before this commit, the kernel would stop dumping addresses once the first
skb was full and end the stream with NLMSG_DONE(-EMSGSIZE). The error
shouldn't be sent back to netlink_dump so the call
On 12/30/18 11:15 AM, ba...@gandi.net wrote:
> From: Arthur Gautier
>
> This commit fixes a regression in AF_INET/RTM_GETADDR and
> AF_INET6/RTM_GETADDR. The AF_UNSPEC/RTM_GETADDR was not affected by this as
> rtnl_dump_all would just hide the errno.
>
> Before this commit, the kernel would stop
On 12/30/18 10:14 AM, Ido Schimmel wrote:
> Since commit aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on
> socket") iproute2 uses strict checking on kernels that support it. This
> causes FDB dumping to fail [1], as iproute2 uses 'struct ifinfomsg'
> whereas the kernel expects 'struct ndmsg
On Sun, Dec 30, 2018 at 12:43:42PM -0800, Cong Wang wrote:
> __ptr_ring_swap_queue() tries to move pointers from the old
> ring to the new one, but it forgets to check if ->producer
> is beyond the new size at the end of the operation. This leads
> to an out-of-bound access in __ptr_ring_produce()
Hi Ben,
Am 19.12.18 um 16:56 schrieb Ben Whitten:
> Information such as spreading factor, coding rate and power are on a per
> transmission basis so it makes sence to include this in a header much
"sense" (even in British English! :))
> like CAN frames do.
Any pointer for that? My understanding
On Sun, Dec 30, 2018 at 02:35:32PM -0800, Florian Fainelli wrote:
> Le 12/30/18 à 1:51 AM, Andrew Lunn a écrit :
> > On Sun, Dec 30, 2018 at 09:25:53AM +0100, Klaus Kudielka wrote:
> >> Hello,
> >
> > Hi Klaus
> >
> > Thanks for reposting on the correct list.
> >
> >> Apart from the 88E1514 PHY
Le 12/30/18 à 1:51 AM, Andrew Lunn a écrit :
> On Sun, Dec 30, 2018 at 09:25:53AM +0100, Klaus Kudielka wrote:
>> Hello,
>
> Hi Klaus
>
> Thanks for reposting on the correct list.
>
>> Apart from the 88E1514 PHY specified for eth2, the device also
>> features an SFP cage, which uses the same SGM
From: Willem de Bruijn
KMSAN detected read beyond end of buffer in vti and sit devices when
passing truncated packets with PF_PACKET. The issue affects additional
ip tunnel devices.
Extend commit 76c0ddd8c3a6 ("ip6_tunnel: be careful when accessing the
inner header") and commit ccfec9e5cb2d ("ip
From: Willem de Bruijn
The BPF flow dissector expects either skb->sk or skb->dev set on
all skbs. Delay flow dissection until after skb->dev is set.
This requires calling from within an rcu read-side critical section.
That is fine, see also the call from tun_xdp_one.
Fixes: d0e13a1488ad ("flow_
From: Cong Wang
Date: Sat, 29 Dec 2018 13:56:36 -0800
> There are multiple issues here:
>
> 1. After freeing dev->ax25_ptr, we need to set it to NULL otherwise
>we may use a dangling pointer.
>
> 2. There is a race between ax25_setsockopt() and device notifier as
>reported by syzbot. Cl
On 12/28/18 7:09 PM, Jakub Kicinski wrote:
> Instead of overwriting dead code with jmp -1 instructions
> remove it completely for root. Adjust verifier state and
> line info appropriately.
>
> v2:
> - adjust func_info (Alexei);
> - make sure first instruction retains line info (Alexei).
>
Hi
I haven`t tested any newer kernels cause I thought that something
related to packet classification has been changed permanently and I have
to figure out what. Which one should I test?
Best regards
Bartek Kois
W dniu 30.12.2018 o 19:53, Cong Wang pisze:
Hello,
On Sat, Dec 29, 2018 at 11:5
From: Su Yanjun
Date: Sat, 29 Dec 2018 14:07:55 -0500
> Signed-off-by: Su Yanjun
Applied.
From: YueHaibing
Date: Sat, 29 Dec 2018 14:45:23 +0800
> gcc warn this:
> net/ipv4/fib_rules.c:203 fib_empty_table() warn:
> always true condition '(id <= 4294967295) => (0-u32max <= u32max)'
>
> 'id' is u32, which always not greater than RT_TABLE_MAX
> (0x), So add a check to break whi
__ptr_ring_swap_queue() tries to move pointers from the old
ring to the new one, but it forgets to check if ->producer
is beyond the new size at the end of the operation. This leads
to an out-of-bound access in __ptr_ring_produce() as reported
by syzbot.
Reported-by: syzbot+8993c0fa96d57c399...@sy
From: Christophe JAILLET
Date: Fri, 28 Dec 2018 23:28:21 +0100
> 'ipv6_find_idev()' returns NULL on error, not an error pointer.
> Update the test accordingly and return -ENOBUFS, as already done in
> 'addrconf_add_dev()', if NULL is returned.
>
> Fixes: ("ipv6: allow userspace to add IFA_F_OPTI
From: Nikolay Aleksandrov
Date: Sun, 30 Dec 2018 14:33:20 +0200
> We must have an address to lookup otherwise we'll derefence a null
> pointer in the ndo_fdb_get callbacks.
>
> CC: Roopa Prabhu
> CC: David Ahern
> Reported-by: syzbot+017b1f61c82a1c3e7...@syzkaller.appspotmail.com
> Fixes: 5b2f
Am 19.12.18 um 16:56 schrieb Ben Whitten:
> diff --git a/drivers/net/lora/sx1301.c b/drivers/net/lora/sx1301.c
> index 0c7b6d0b31af..9bcbb967f307 100644
> --- a/drivers/net/lora/sx1301.c
> +++ b/drivers/net/lora/sx1301.c
> @@ -24,6 +24,44 @@
>
> #include "sx1301.h"
>
> +struct sx1301_tx_header
On 12/30/2018 08:24 PM, Sergei Shtylyov wrote:
>> Finally, add support for the DT probing of the R-Car V3H (AKA R8A77980) --
>> it's the only R-Car gen3 SoC having the GEther controller -- others have
>> only EtherAVB...
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Sign
Use devm_ variant to have the clock provider deleted again.
Signed-off-by: Andreas Färber
---
drivers/net/lora/sx125x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/lora/sx125x.c b/drivers/net/lora/sx125x.c
index 2c48301a12ab..68d8afed48ba 100644
--- a/drivers/
We can't get the clk32m during probe because the radio is not yet probed then.
When doing it during netdev open we also need to undo that during netdev stop.
Revamp the error handling for open and tidy our debug output while at it.
Signed-off-by: Andreas Färber
---
drivers/net/lora/sx1301.c | 37
From: Ben Whitten
Split off from style changes.
Signed-off-by: Ben Whitten
Signed-off-by: Andreas Färber
---
drivers/net/lora/sx125x.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/lora/sx125x.c b/drivers/net/lora/sx125x.c
index b7ca782b9386..2c48301a
On Sun, Dec 30, 2018 at 4:33 AM Nikolay Aleksandrov
wrote:
>
> We must have an address to lookup otherwise we'll derefence a null
> pointer in the ndo_fdb_get callbacks.
>
> CC: Roopa Prabhu
> CC: David Ahern
> Reported-by: syzbot+017b1f61c82a1c3e7...@syzkaller.appspotmail.com
> Fixes: 5b2f94b27
Hello,
On Sat, Dec 29, 2018 at 11:54 AM Bartek Kois wrote:
>
>
> Hi,
> I`ve got problem while queuing with HFSC vlan tagged packets after
> migrating my tc scripts from Debian 8.2 (3.16.0-4-amd64) to Debian 9.5
> (4.9.0-6-amd64). tc filters added to eth1 do not classify correctly src
> and dst ip
On Thu, Dec 27, 2018 at 06:04:53PM +0800, Jason Wang wrote:
>
> On 2018/12/26 下午11:22, Michael S. Tsirkin wrote:
> > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
> > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote:
> > > > When use_napi is set, let's enable BQLs. Note: some of the
On Thu, Dec 27, 2018 at 06:00:36PM +0800, Jason Wang wrote:
>
> On 2018/12/26 下午11:19, Michael S. Tsirkin wrote:
> > On Thu, Dec 06, 2018 at 04:17:36PM +0800, Jason Wang wrote:
> > > On 2018/12/6 上午6:54, Michael S. Tsirkin wrote:
> > > > When use_napi is set, let's enable BQLs. Note: some of the
On Thu, Dec 27, 2018 at 05:55:52PM +0800, Jason Wang wrote:
>
> On 2018/12/26 下午11:06, Michael S. Tsirkin wrote:
> > On Wed, Dec 26, 2018 at 12:03:50PM +0800, Jason Wang wrote:
> > > On 2018/12/26 上午12:41, Michael S. Tsirkin wrote:
> > > > Hi!
> > > > I was just wondering: packed ring batches thin
On Thu, Dec 27, 2018 at 05:39:21PM +0800, Jason Wang wrote:
>
> On 2018/12/26 下午11:02, Michael S. Tsirkin wrote:
> > On Wed, Dec 26, 2018 at 11:57:32AM +0800, Jason Wang wrote:
> > > On 2018/12/25 下午8:50, Michael S. Tsirkin wrote:
> > > > On Tue, Dec 25, 2018 at 06:05:25PM +0800, Jason Wang wrote:
From: Arthur Gautier
This commit fixes a regression in AF_INET/RTM_GETADDR and
AF_INET6/RTM_GETADDR. The AF_UNSPEC/RTM_GETADDR was not affected by this as
rtnl_dump_all would just hide the errno.
Before this commit, the kernel would stop dumping addresses once the first
skb was full and end the
syzbot has found a reproducer for the following crash on:
HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1449435340
kernel config: https://syzkaller.appspot.com/x/.config?x=4b137b
On 05/18/2018 09:32 PM, Sergei Shtylyov wrote:
> Finally, add support for the DT probing of the R-Car V3H (AKA R8A77980) --
> it's the only R-Car gen3 SoC having the GEther controller -- others have
> only EtherAVB...
>
> Based on the original (and large) patch by Vladimir Barinov.
>
> Signed-of
Since commit aea41afcfd6d ("ip bridge: Set NETLINK_GET_STRICT_CHK on
socket") iproute2 uses strict checking on kernels that support it. This
causes FDB dumping to fail [1], as iproute2 uses 'struct ifinfomsg'
whereas the kernel expects 'struct ndmsg'.
Note that with this change iproute2 continues
Now, UMH process is killed, do_exit() calls the umh_info->cleanup callback
to release members of the umh_info.
This patch makes bpfilter_umh's cleanup routine to use the
umh_info->cleanup callback.
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 11 ---
net/bpfilter/bpfilter
The bpfilter_umh will be stopped via __stop_umh() when the bpfilter
error occurred.
The bpfilter_umh() couldn't start again because there is no restart
routine.
The section of the bpfilter_umh_{start/end} is no longer .init.rodata
because these area should be reused in the restart routine. hence
t
The bpfilter.ko module can be removed while functions of the bpfilter.ko
are executing. so panic can occurred. in order to protect that, locks can
be used. a bpfilter_lock protects routines in the
__bpfilter_process_sockopt() but it's not enough because __exit routine
can be executed concurrently.
Convert spaces to tabs to get correct alignment.
Found with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/net/ethernet/intel/i40e/i40e_main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
b/drivers/net/ethe
This patches fix two bugs in the bpfilter_umh which are related in
iptables command.
The first patch adds an exit code for UMH process.
This provides an opportunity to cleanup members of the umh_info
to modules which use the UMH.
The second patch makes the bpfilter_umh use UMH cleanup callback.
These patches fix cases where a subsequent statement is aligned
with the right hand side of an assignment rather than the left
hand side. This was done using the following semantic match
(http://coccinelle.lip6.fr/). It has a lot of false positives,
because Coccinelle doesn't record the differenc
Delete tab aligning a statement with the right hand side of a
preceding assignment rather than the left hand side.
Found with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/net/ethernet/amazon/ena/ena_eth_com.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
A UMH process which is created by the fork_usermode_blob() such as
bpfilter needs to release members of the umh_info when process is
terminated.
But the do_exit() does not release members of the umh_info. hence module
which uses UMH needs own code to detect whether UMH process is
terminated or not.
In kfree, the NULL check is done.
Signed-off-by: Zhu Yanjun
---
net/rds/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/tcp.c b/net/rds/tcp.c
index b9bbcf3d6c63..c16f0a362c32 100644
--- a/net/rds/tcp.c
+++ b/net/rds/tcp.c
@@ -623,7 +623,7 @@ static void __net_ex
> On Dec 30, 2018, at 9:17 AM, Ido Schimmel wrote:
>
>> On Wed, Dec 19, 2018 at 07:54:15PM -0800, David Ahern wrote:
>> From: David Ahern
>>
>> Refactorings and updates to use the new strict checking in the kernel
>> along with the new kernel side filtering.
>
> David,
>
> Since this was a
On Wed, Dec 19, 2018 at 07:54:15PM -0800, David Ahern wrote:
> From: David Ahern
>
> Refactorings and updates to use the new strict checking in the kernel
> along with the new kernel side filtering.
David,
Since this was applied to iproute2-next I get:
bash-4.4# bridge/bridge fdb show
From: Leon Romanovsky
mnl_attr_type_valid() receives maximum attribute type, which means that
we were supposed to supply the latest valid netlink attribute and not
the number of attributes. Such coding mistake caused to failures while
NLA attributes were extended.
Fixes: 74bd75c2b68d ("rdma: Add
From: Colin Ian King
Don't populate the const array 'data' on the stack but instead
make it static. Makes the object code smaller by 78 bytes:
Before:
textdata bss dec hex filename
54381080 065181976 mediatek/mt76/mt76x2/usb_mcu.o
After:
textdata
We must have an address to lookup otherwise we'll derefence a null
pointer in the ndo_fdb_get callbacks.
CC: Roopa Prabhu
CC: David Ahern
Reported-by: syzbot+017b1f61c82a1c3e7...@syzkaller.appspotmail.com
Fixes: 5b2f94b27622 ("net: rtnetlink: support for fdb get")
Signed-off-by: Nikolay Aleksand
In rtl8169_runtime_resume() we configure WoL but don't set the device
to wakeup-enabled. This prevents PME generation once the cable is
re-plugged. Fix this by moving the call to device_set_wakeup_enable()
to __rtl8169_set_wol().
Fixes: 433f9d0ddcc6 ("r8169: improve saved_wolopts handling")
Signed
On 30/12/2018 06:01, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: 90cadbbf341d Merge git://git.kernel.org/pub/scm/linux/kern..
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=1745c69b40
> kernel config: https://syz
On Sun, Dec 30, 2018 at 12:00 PM Sven Eckelmann wrote:
>
> On Sunday, 30 December 2018 11.41.03 CET syzbot wrote:
> [...]
> > HEAD commit:d8924c0d76aa Merge tag 'devprop-4.21-rc1' of git://git.ker..
> > git tree: upstream
> > console output: https://syzkaller.appspot.com/x/log.txt?x=122a
On Sunday, 30 December 2018 11.41.03 CET syzbot wrote:
[...]
> HEAD commit:d8924c0d76aa Merge tag 'devprop-4.21-rc1' of git://git.ker..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=122a373f40
> kernel config: https://syzkaller.appspot.com/x/.config
+ linux-spi, LAKML
Am 29.12.18 um 21:16 schrieb Andreas Färber:
> Am 29.12.18 um 20:25 schrieb Andreas Färber:
>> Am 12.10.18 um 18:26 schrieb Ben Whitten:
>>> +static int sx125x_register_clock_provider(struct sx125x_priv *priv)
>>> +{
>>> + struct device *dev = priv->dev;
>>> + struct clk_ini
Hello,
syzbot found the following crash on:
HEAD commit:d8924c0d76aa Merge tag 'devprop-4.21-rc1' of git://git.ker..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=122a373f40
kernel config: https://syzkaller.appspot.com/x/.config?x=91a256823ef17263
da
On Sun, Dec 30, 2018 at 09:25:53AM +0100, Klaus Kudielka wrote:
> Hello,
Hi Klaus
Thanks for reposting on the correct list.
> Apart from the 88E1514 PHY specified for eth2, the device also
> features an SFP cage, which uses the same SGMII of the Armada
> 385 SoC (a 2:1 multiplexer is driven by t
Hello,
I own a Turris Omnia, which has basic support included in the
Linux kernel (armada-385-turris-omnia.dts).
Apart from the 88E1514 PHY specified for eth2, the device also
features an SFP cage, which uses the same SGMII of the Armada
385 SoC (a 2:1 multiplexer is driven by the MOD_DEF0 signa
68 matches
Mail list logo
