Re: [PATCH net-next] neighbor: Use nda_policy for validating attributes in adds and dump requests

2018-12-19 Thread David Miller
From: David Ahern Date: Wed, 19 Dec 2018 20:02:36 -0800 > From: David Ahern > > Add NDA_PROTOCOL to nda_policy and use the policy for attribute parsing and > validation for adding neighbors and in dump requests. Remove the now duplicate > checks on nla_len. > > Signed-off-by: David Ahern App

[PATCH net-next v5 RFC 3/8] devlink: Add port param set command

2018-12-19 Thread Vasundhara Volam
Add port param set command to set the value for a parameter. Value can be set to any of the supported configuration modes. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/uapi/linux/devlink.h | 1 + net/core/devlink.c | 37 - 2 files cha

[PATCH net-next v5 RFC 2/8] devlink: Add port param get command

2018-12-19 Thread Vasundhara Volam
Add port param get command which gets data per parameter. It also has option to dump the parameters data per port. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/uapi/linux/devlink.h | 2 + net/core/devlink.c | 102 --- 2 files cha

[PATCH net-next v5 RFC 0/8] devlink: Add configuration parameters support for devlink_port

2018-12-19 Thread Vasundhara Volam
This patchset adds support for configuration parameters setting through devlink_port. Each device registers supported configuration parameters table. The user can retrieve data on these parameters by "devlink port param show" command and can set new value to a parameter by "devlink port param set

[PATCH net-next v5 RFC 1/8] devlink: Add devlink_param for port register and unregister

2018-12-19 Thread Vasundhara Volam
Add functions to register and unregister for the driver supported configuration parameters table per port. v2->v3: - Add a helper __devlink_params_register() with common code used by both devlink_params_register() and devlink_port_params_register(). Cc: Jiri Pirko Signed-off-by: Vasundhara Vol

Re: [PATCH net-next 0/9] net: hns3: code optimizations & bugfixes for HNS3 driver

2018-12-19 Thread David Miller
From: Peng Li Date: Thu, 20 Dec 2018 11:51:57 +0800 > This patchset includes bugfixes and code optimizations for the HNS3 > ethernet controller driver Series applied, thanks.

4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-19 Thread Christian Borntraeger
Folks, I got this warning today. I cant tell when and why this happened, so I do not know yet how to reproduce. Maybe someone has a quick idea. [85109.572032] WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect+0x1f0/0x1318 [85109.572036] Modules linked in: vhost_ne

Re: [PATCH] wil6210: remove set but not used variable 'wdev'

2018-12-19 Thread Kalle Valo
YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/wireless/ath/wil6210/main.c: In function '_wil6210_disconnect': > drivers/net/wireless/ath/wil6210/main.c:407:23: warning: > variable 'wdev' set but not used [-Wunused-but-set-variable] > > It never used since c

Re: [PATCH] wireless/wil6210: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-19 Thread Kalle Valo
Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 986b83488464 wil6210: convert to DEFINE_SHOW_ATTRIBUTE -- https://patchwork.kernel.org/patch/10709547/ h

update on llvm BTF support

2018-12-19 Thread Yonghong Song
Hi, This is an update of llvm BTF support. The patches corresponding to https://reviews.llvm.org/{D55755,D55756,D55752} have been accepted and merged. The llvm BTF support will be in llvm 8.0 whose release time is around next March. So with latest llvm/clang trunk, add -g to your compilation

Re: [PATCH 1/3] ath6kl: Only use match sets when firmware supports it

2018-12-19 Thread Kalle Valo
Kyle Roeschley wrote: > Commit dd45b7598f1c ("ath6kl: Include match ssid list in scheduled scan") > merged the probed and matched SSID lists before sending them to the > firmware. In the process, it assumed match set support is always available > in ath6kl_set_probed_ssids, which breaks scans for

Re: [PATCH bpf-next 07/19] bpf: verifier: remove dead code

2018-12-19 Thread Yonghong Song
On 12/19/18 4:45 PM, Alexei Starovoitov wrote: > On Wed, Dec 19, 2018 at 10:29:18AM -0800, Jakub Kicinski wrote: >> Instead of overwriting dead code with jmp -1 instructions >> remove it completely for root. Adjust verifier state and >> line info appropriately. >> >> Signed-off-by: Jakub Kicinsk

Re: [PATCH net-next v4 RFC 0/8] devlink: Add configuration parameters support for devlink_port

2018-12-19 Thread Michael Chan
On Tue, Dec 18, 2018 at 9:02 PM Jakub Kicinski wrote: > > On Wed, 19 Dec 2018 08:57:21 +0530, Vasundhara Volam wrote: > > This patchset adds support for configuration parameters setting through > > devlink_port. Each device registers supported configuration parameters > > table. > > Since you're

Re: [PATCH] net: mvneta: add basic XDP_DROP support

2018-12-19 Thread kbuild test robot
Hi Domagoj, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v4.20-rc7 next-20181219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: linux-next: manual merge of the net-next tree with the net tree

2018-12-19 Thread Or Gerlitz
On Thu, Dec 20, 2018 at 4:47 AM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > between commit: > > 8956f0014ea5 ("net/mlx5e: Fix default amount of channels for VF > representors"

Re: [PATCH] ipw2x00: cleanup dead code

2018-12-19 Thread Kalle Valo
YueHaibing wrote: > Fix smatch warning: > > drivers/net/wireless/intel/ipw2x00/ipw2100.c:5606 > shim__set_security() warn: always true condition '(sec->active_key <= 3) => > (0-3 <= 3)' > drivers/net/wireless/intel/ipw2x00/ipw2200.c:10725 > shim__set_security() warn: always true condition '(s

Re: [PATCH] cw1200: Fix concurrency use-after-free bugs in cw1200_hw_scan()

2018-12-19 Thread Kalle Valo
Jia-Ju Bai wrote: > The function cw1200_bss_info_changed() and cw1200_hw_scan() can be > concurrently executed. > The two functions both access a possible shared variable "frame.skb". > > This shared variable is freed by dev_kfree_skb() in cw1200_upload_beacon(), > which is called by cw1200_bss

Re: [PATCH] brcmfmac: Fix access point mode

2018-12-19 Thread Kalle Valo
Stefan Wahren wrote: > Since commit 1204aa17f3b4 ("brcmfmac: set WIPHY_FLAG_HAVE_AP_SME flag") > the Raspberry Pi 3 A+ (BCM43455) isn't able to operate in AP mode with > hostapd (device_ap_sme=1 use_monitor=0): > > brcmfmac: brcmf_cfg80211_stop_ap: setting AP mode failed -52 > > So add the miss

Re: [PATH bpf-next 09/13] s390: bpf: implement jitting of JMP32

2018-12-19 Thread Martin Schwidefsky
On Wed, 19 Dec 2018 17:44:16 -0500 Jiong Wang wrote: > This patch implements code-gen for new JMP32 instructions on s390. > > Cc: Martin Schwidefsky > Cc: Heiko Carstens > Signed-off-by: Jiong Wang > --- > arch/s390/net/bpf_jit_comp.c | 12 > 1 file changed, 8 insertions(+), 4 d

Re: [PATCH] cw1200: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-19 Thread Kalle Valo
Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li Patch applied to wireless-drivers-next.git, thanks. cc4dc97ffc69 cw1200: convert to DEFINE_SHOW_ATTRIBUTE -- https://patchwork.kernel.org/patch/10709559/ https://wireless.wiki.kernel.org

Re: [PATCH] rtlwifi: Fix non-working BSS STA mode

2018-12-19 Thread Kalle Valo
Kai-Heng Feng wrote: > Once BSS STA mode gets started, it can be scanned by other clients but > cannot entablish a connection. > > Turns out the set_bcn_reg() and its *_set_beacon_related_registers() > callbacks never get called so it has problem beaconing. > > Enable the function in rtl_op_bss

Re: linux-next: manual merge of the char-misc tree with the net-next tree

2018-12-19 Thread Greg KH
On Thu, Dec 20, 2018 at 05:02:53PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the char-misc tree got a conflict in: > > drivers/ptp/ptp_clock.c > > between commit: > > aea0a897af9e ("ptp: Fix pass zero to ERR_PTR() in ptp_clock_register") > > from the net-next

Re: [PATCH bpf-next 1/3] bpf: sockmap, metadata support for reporting size of msg

2018-12-19 Thread John Fastabend
On 12/19/18 6:49 PM, Alexei Starovoitov wrote: > On Sun, Dec 16, 2018 at 03:47:04PM -0800, John Fastabend wrote: >> This adds metadata to sk_msg_md for BPF programs to read the sk_msg >> size. >> >> When the SK_MSG program is running under an application that is using >> sendfile the data is not co

Re: [PATCH mlx5-next] IB/mlx5: Prevent allocating UMEM and UCTX as some general object

2018-12-19 Thread Leon Romanovsky
On Wed, Dec 19, 2018 at 07:14:12PM +, Jason Gunthorpe wrote: > On Wed, Dec 19, 2018 at 04:28:15PM +0200, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > The driver needs to prevent a user space application to create a > > UMEM and UCTX via the general object command. > > > > The UMEM mus

[PATCH bpf-next v2 2/7] bpf: verifier: teach the verifier to reason about the BPF_JSET instruction

2018-12-19 Thread Jakub Kicinski
Some JITs (nfp) try to optimize code on their own. It could make sense in case of BPF_JSET instruction which is currently not interpreted by the verifier, meaning for instance that dead could would not be detected if it was under BPF_JSET branch. Teach the verifier basics of BPF_JSET, JIT optimiz

[PATCH bpf-next v2 4/7] bpf: verifier: reorder stack size check with dead code sanitization

2018-12-19 Thread Jakub Kicinski
Reorder the calls to check_max_stack_depth() and sanitize_dead_code() to separate functions which can rewrite instructions from pure checks. No functional changes. Signed-off-by: Jakub Kicinski Reviewed-by: Jiong Wang --- kernel/bpf/verifier.c | 5 +++-- 1 file changed, 3 insertions(+), 2 dele

[PATCH bpf-next v2 5/7] nfp: bpf: remove the trivial JSET optimization

2018-12-19 Thread Jakub Kicinski
The verifier will now understand the JSET instruction, so don't mark the dead branch in the JIT as noop. We won't generate any code, anyway. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 5 - 1 file changed, 5 deletions(-) dif

[PATCH bpf-next v2 6/7] nfp: bpf: optimize codegen for JSET with a constant

2018-12-19 Thread Jakub Kicinski
The top word of the constant can only have bits set if sign extension set it to all-1, therefore we don't really have to mask the top half of the register. We can just OR it into the result as is. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/

[PATCH bpf-next v2 7/7] selftests: bpf: add missing executables to .gitignore

2018-12-19 Thread Jakub Kicinski
commit 435f90a338ae ("selftests/bpf: add a test case for sock_ops perf-event notification") missed adding new test to gitignore. Signed-off-by: Jakub Kicinski --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/

[PATCH bpf-next v2 0/7] bpf: teach the verifier about JSET and add tests

2018-12-19 Thread Jakub Kicinski
Hi! This is a v2 of the patch set to teach the verifier about BPF_JSET instruction. There is also a number of tests include for both basic functioning of the instruction and the verifier logic. The NFP JIT handling of JSET is tweaked. Last patch adds missing file to gitignore. Reposting part of

[PATCH bpf-next v2 3/7] selftests: bpf: verifier: add tests for JSET interpretation

2018-12-19 Thread Jakub Kicinski
Validate that the verifier reasons correctly about the bounds and removes dead code based on results of JSET instruction. Signed-off-by: Jakub Kicinski --- tools/testing/selftests/bpf/test_verifier.c | 96 + 1 file changed, 96 insertions(+) diff --git a/tools/testing/selftes

[PATCH bpf-next v2 1/7] selftests: bpf: add trivial JSET tests

2018-12-19 Thread Jakub Kicinski
We seem to have no JSET instruction test, and LLVM does not generate it at all, so let's add a simple hand-coded test to make sure JIT implementations are correct. v2: - extend test_verifier to handle multiple inputs and add the sample there (Daniel) - add a sign extension case Signed-off-by

Re: [PATCH rdma-next 0/2] Fix to mlx5 devx interface

2018-12-19 Thread Leon Romanovsky
On Wed, Dec 19, 2018 at 07:14:38PM +, Jason Gunthorpe wrote: > On Wed, Dec 19, 2018 at 04:28:09PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi, > > > > This small fix to mlx5 devx interface is separated to two, so we can > > apply first patch to mlx5-next. > > > > Thanks

linux-next: manual merge of the char-misc tree with the net-next tree

2018-12-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the char-misc tree got a conflict in: drivers/ptp/ptp_clock.c between commit: aea0a897af9e ("ptp: Fix pass zero to ERR_PTR() in ptp_clock_register") from the net-next tree and commit: b9d93594c767 ("ptp: fix an IS_ERR() vs NULL check") from the char-

Re: [next] bonding: pass link-local packets to bonding master also.

2018-12-19 Thread Vincent Bernat
❦ 19 décembre 2018 23:57 +01, Michal Soltys : >>> Commit b89f04c61efe ("bonding: deliver link-local packets with >>> skb->dev set to link that packets arrived on") changed the behavior >>> of how link-local-multicast packets are processed. The change in >>> the behavior broke some legacy use case

[GIT] Networking

2018-12-19 Thread David Miller
This should be the last networking pull request before the next merge window. 1) Off by one in netlink parsing of mac802154_hwsim, from Alexander Aring. 2) nf_tables RCU usage fix from Taehee Yoo. 3) Flow dissector needs nhoff and thoff clamping, from Stanislav Fomichev. 4) Missing sin6_

[PATCH net-next] neighbor: Use nda_policy for validating attributes in adds and dump requests

2018-12-19 Thread David Ahern
From: David Ahern Add NDA_PROTOCOL to nda_policy and use the policy for attribute parsing and validation for adding neighbors and in dump requests. Remove the now duplicate checks on nla_len. Signed-off-by: David Ahern --- net/core/neighbour.c | 22 +- 1 file changed, 5 ins

[PATCH] brcm80211: remove set but not used variables 'phybw40, maxtargetpwr'

2018-12-19 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:1202:5: warning: variable 'phybw40' set but not used [-Wunused-but-set-variable] drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:4625:5: warning: variable 'phybw40' set bu

[PATCH iproute2-next 08/12] ip address: Split ip_linkaddr_list into link and addr functions

2018-12-19 Thread David Ahern
From: David Ahern Split ip_linkaddr_list into one function that generates a list of devices and a second that generates the list of addresses. Signed-off-by: David Ahern --- ip/ip_common.h | 3 +-- ip/ipaddress.c | 39 --- ip/ipvrf.c | 2 +- 3 files ch

[PATCH iproute2-next 02/12] libnetlink: Use NLMSG_LENGTH to set nlmsg_len

2018-12-19 Thread David Ahern
From: David Ahern Change nlmsg_len from sizeof(req) to use NLMSG_LENGTH on the header. 2 of the inner headers are not 4-byte aligned, so add a 0-length buf after the header with the __aligned(NLMSG_ALIGNTO) to ensure the size of the request is large enough. Use NLMSG_ALIGN in NLMSG_LENGTH to set

[PATCH iproute2-next 04/12] ip route: Remove rtnl_rtcache_request

2018-12-19 Thread David Ahern
From: David Ahern Add a filter option to rtnl_routedump_req and use it to set rtm_flags removing the need for rtnl_rtcache_request for dump requests. Signed-off-by: David Ahern --- include/libnetlink.h | 7 --- ip/ipmroute.c| 2 +- ip/iproute.c | 43 ++

[PATCH iproute2-next 12/12] neighbor: Add support for protocol attribute

2018-12-19 Thread David Ahern
From: David Ahern Add support to set protocol on neigh entries and to print the protocol on dumps. Signed-off-by: David Ahern --- ip/ipneigh.c | 39 --- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/ip/ipneigh.c b/ip/ipneigh.c index 6041c467

[PATCH iproute2-next 06/12] mroute: fix up family handling

2018-12-19 Thread David Ahern
From: David Ahern Only ipv4 and ipv6 have multicast routing. Set family accordingly and just return for other cases. Signed-off-by: David Ahern --- ip/ipmroute.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/ip/ipmroute.c b/ip/ipmroute.c index de7a035f852

[PATCH iproute2-next 05/12] ip route: Add protocol, table id and device to dump request

2018-12-19 Thread David Ahern
From: David Ahern Add protocol, table id and device to dump request if set in filter. If kernel side filtering is supported it is used to reduce the amount of data sent to userspace. Older kernels do not parse attributes on a route dump request, so these are silently ignored and ip will do the f

[PATCH iproute2-next 10/12] ip bridge: Set NETLINK_DUMP_STRICT_CHK on socket

2018-12-19 Thread David Ahern
From: David Ahern iproute2 has been updated for the new strict policy in the kernel. Add a helper to call setsockopt to enable the feature. Add a call to ip.c and bridge.c The setsockopt fails on older kernels and the error can be safely ignored - any new fields or attributes are ignored by the

[PATCH iproute2-next 00/12] Updates for strict checking and kernel side filtering

2018-12-19 Thread David Ahern
From: David Ahern Refactorings and updates to use the new strict checking in the kernel along with the new kernel side filtering. David Ahern (12): libnetlink: dump extack string in done message libnetlink: Use NLMSG_LENGTH to set nlmsg_len libnetlink: linkdump_req: Only AF_UNSPEC family e

[PATCH iproute2-next 01/12] libnetlink: dump extack string in done message

2018-12-19 Thread David Ahern
From: David Ahern Print any extack message that has been appended to a NLMSG_DONE message. To avoid duplication, move the existing print code to a new helper. Signed-off-by: David Ahern --- lib/libnetlink.c | 44 +++- 1 file changed, 39 insertions(+), 5

[PATCH iproute2-next 03/12] libnetlink: linkdump_req: Only AF_UNSPEC family expects an ext_filter_mask

2018-12-19 Thread David Ahern
From: David Ahern Only AF_UNSPEC handled by rtnl_dump_ifinfo expects an ext_filter_mask on a dump request. Update the linkdump request functions to only set and send ext_filter_mask for AF_UNSPEC. Signed-off-by: David Ahern --- lib/libnetlink.c | 93

[PATCH iproute2-next 09/12] ip address: Set device index in dump request

2018-12-19 Thread David Ahern
From: David Ahern Add a filter function to rtnl_addrdump_req to set device index in the address dump request if the user is filtering addresses by device. In addition, add a new ipaddr_link_get to do a single RTM_GETLINK request instead of a device dump yet still store the data in the linfo list.

[PATCH iproute2-next 07/12] mroute: Add table id attribute for kernel side filtering

2018-12-19 Thread David Ahern
From: David Ahern Similar to 'ip route' add the table id to the dump request for kernel side filtering if it is supported. Signed-off-by: David Ahern --- ip/ipmroute.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/ip/ipmroute.c b/ip/ipmroute.c index b8f0bc

[PATCH iproute2-next 11/12] ip route: Rename do_ipv6 to dump_family

2018-12-19 Thread David Ahern
From: David Ahern do_ipv6 is really the preferred dump family. Rename it to make that apparent. Signed-off-by: David Ahern --- ip/iproute.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 5bffb9d88b58.

Re: [PATCH net-next] net: ipv4: allocate ipv4_devconf memory for init_net

2018-12-19 Thread Tonghao Zhang
On Wed, Dec 19, 2018 at 7:09 AM David Miller wrote: > > From: Cong Wang > Date: Sun, 16 Dec 2018 11:06:39 -0800 > > > On Sun, Dec 16, 2018 at 8:24 AM wrote: > >> > >> From: Tonghao Zhang > >> > >> The devconf setting on the init_net will affect other > >> namespace when them created. For exampl

[PATCH net-next 1/9] net: hns3: refine the handle for hns3_nic_net_open/stop()

2018-12-19 Thread Peng Li
From: Jian Shen When triggering nic down, there is a time window between bringing down the protocol stack and stopping the work task. If the net is up in the time window, it may bring up the protocol stack again. This patch fixes it by stop the work task at the beginning of hns3_nic_net_stop().

[PATCH net-next 4/9] net: hns3: add max vector number check for pf

2018-12-19 Thread Peng Li
From: Jian Shen Each pf supports max 64 vectors and 128 tqps. For 2p/4p core scenario, there may be more than 64 cpus online. So the result of min_t(u16, num_Online_cpus(), tqp_num) may be more than 64. This patch adds check for the vector number. Fixes: dd38c72604dc ("net: hns3: fix for coalesc

[PATCH net-next 2/9] net: hns3: change default tc state to close

2018-12-19 Thread Peng Li
From: Jian Shen In original codes, default tc value is set to the max tc. It's more reasonable to close tc by changing default tc value to 1. Users can enable it with lldp tool when they want to use tc. Signed-off-by: Jian Shen Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hn

[PATCH net-next 8/9] net: hns3: fix the descriptor index when get rss type

2018-12-19 Thread Peng Li
Driver gets rss information from the last descriptor of the packet. When driver handle the rss type, ring->next_to_clean indicates the first descriptor of next packet. This patch fix the descriptor index with "ring->next_to_clean - 1". Fixes: 232fc64b6e62 ("net: hns3: Add HW RSS hash information

[PATCH net-next 6/9] net: hns3: fix vf id check issue when add flow director rule

2018-12-19 Thread Peng Li
From: Jian Shen When add flow director fule for vf, the vf id is used as array subscript before valid checking, which may cause memory overflow. Fixes: dd74f815dd41 ("net: hns3: Add support for rule add/delete for flow director") Signed-off-by: Jian Shen Signed-off-by: Peng Li --- drivers/ne

[PATCH net-next 3/9] net: hns3: fix a bug caused by udelay

2018-12-19 Thread Peng Li
udelay() in driver may always occupancy processor. If there is only one cpu in system, the VF driver may initialize fail when insmod PF and VF driver in the same system. This patch use msleep() to free cpu when VF wait PF message. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hn

[PATCH net-next 5/9] net: hns3: reset tqp while doing DOWN operation

2018-12-19 Thread Peng Li
From: Huazhong Tan While doing DOWN operation, the driver will reclaim the memory which has already used for TX. If the hardware is processing this memory, it will cause a RCB error to the hardware. According the hardware's description, the driver should reset the tqp before reclaim the memory du

[PATCH net-next 9/9] net: hns3: remove redundant variable initialization

2018-12-19 Thread Peng Li
This patch removes the redundant variable initialization, as driver will devm_kzalloc to set value to hdev soon. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon

[PATCH net-next 7/9] net: hns3: don't restore rules when flow director is disabled

2018-12-19 Thread Peng Li
From: Jian Shen When user disables flow director, all the rules will be disabled. But when reset happens, it will restore all the rules again. It's not reasonable. This patch fixes it by add flow director status check before restore fules. Fixes: 6871af29b3ab ("net: hns3: Add reset handle for fl

[PATCH net-next 0/9] net: hns3: code optimizations & bugfixes for HNS3 driver

2018-12-19 Thread Peng Li
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Huazhong Tan (1): net: hns3: reset tqp while doing DOWN operation Jian Shen (5): net: hns3: refine the handle for hns3_nic_net_open/stop() net: hns3: change default tc state to close net: hns3:

Re: [PATH bpf-next 00/13] bpf: propose new jmp32 instructions

2018-12-19 Thread Alexei Starovoitov
On Wed, Dec 19, 2018 at 05:44:07PM -0500, Jiong Wang wrote: > Current eBPF ISA has 32-bit sub-register and has defined a set of ALU32 > instructions. > > However, there is no JMP32 instructions, the consequence is code-gen for > 32-bit sub-registers is not efficient. For example, explicit sign-ext

[PATCH v1 net] net: dsa: microchip: fix unicast frame leak

2018-12-19 Thread Tristram.Ha
From: Tristram Ha Port partitioning is done by enabling UNICAST_VLAN_BOUNDARY and changing the default port membership of 0x7f to other values such that there is no communication between ports. In KSZ9477 the member for port 1 is 0x41; port 2, 0x42; port 3, 0x44; port 4, 0x48; port 5, 0x50; and

Re: [PATCH bpf-next 1/3] bpf: sockmap, metadata support for reporting size of msg

2018-12-19 Thread Alexei Starovoitov
On Sun, Dec 16, 2018 at 03:47:04PM -0800, John Fastabend wrote: > This adds metadata to sk_msg_md for BPF programs to read the sk_msg > size. > > When the SK_MSG program is running under an application that is using > sendfile the data is not copied into sk_msg buffers by default. Rather > the BPF

Re: [PULL] virtio fix

2018-12-19 Thread pr-tracker-bot
The pull request you sent on Wed, 19 Dec 2018 18:29:58 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ab63e725b49c80f941446327d79ba5b68593bf5a Thank you! -- Deet-doot-dot, I am a bot

[PATCH] mac80211-next: remove set but not used variable 'w_priv'

2018-12-19 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/wireless/virt_wifi.c: In function 'virt_wifi_net_device_stop': drivers/net/wireless/virt_wifi.c:432:31: warning: variable 'w_priv' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- drivers/net/wireless/virt_wif

[PATCH] mac80211-next: remove duplicated include from virt_wifi.c

2018-12-19 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/wireless/virt_wifi.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c index 64b2186..245d4d0 100644 --- a/drivers/net/wireless/virt_wifi.c +++ b/drivers

linux-next: build failure after merge of the net-next tree

2018-12-19 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/vxlan.c: In function 'vxlan_changelink': drivers/net/vxlan.c:3763:10: error: too few arguments to function 'vxlan_fdb_update' err = vxlan_fdb_update(vxlan, all_zeros_mac,

Re: [PATCH bpf-next] libbpf: Show possible section(type) names on when failed to guess a type

2018-12-19 Thread Jakub Kicinski
On Thu, 20 Dec 2018 09:47:12 +0900, Taeung Song wrote: > On 12/20/18 3:52 AM, Jakub Kicinski wrote: > > On Wed, 19 Dec 2018 17:52:40 +0900, Taeung Song wrote: > >> We need to let users check their wrong section name > >> with proper section names when failed to get proper type from it. > >> Becau

Re: [PATCH net-next] net: sched: add checks for tbf classid

2018-12-19 Thread Tonghao Zhang
On Thu, Dec 20, 2018 at 1:40 AM Cong Wang wrote: > > On Tue, Dec 18, 2018 at 11:08 PM wrote: > > > > From: Tonghao Zhang > > > > tbf has only one qdisc class. When adding qdisc for it, > > we should check the classid, otherwise the parentid:1 > > classid is available, no matter what classid tc s

linux-next: manual merge of the net-next tree with the net tree

2018-12-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/mellanox/mlx5/core/en_rep.c between commit: 8956f0014ea5 ("net/mlx5e: Fix default amount of channels for VF representors") from the net tree and commit: d9ee0491c2ff ("net/mlx5e: Use dedicated

linux-next: manual merge of the net-next tree with the net tree

2018-12-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: tools/testing/selftests/net/Makefile between commit: 55cbe0794294 ("selftests: net: Add test_vxlan_fdb_changelink.sh") from the net tree and commit: e87f53b4fab7 ("selftests: add some benchmark for UDP GRO") ( and

linux-next: manual merge of the net-next tree with the net tree

2018-12-19 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/vxlan.c between commits: 6db924687139 ("vxlan: Fix error path in __vxlan_dev_create()") ce5e098f7a10 ("vxlan: changelink: Fix handling of default remotes") from the net tree and commit: 0e6160f3f5a9 (

Re: [PATCH net] neighbor: NTF_PROXY is a valid ndm_flag for a dump request

2018-12-19 Thread David Miller
From: David Ahern Date: Wed, 19 Dec 2018 16:54:38 -0800 > From: David Ahern > > When dumping proxy entries the dump request has NTF_PROXY set in > ndm_flags. strict mode checking needs to be updated to allow this > flag. > > Fixes: 51183d233b5a ("net/neighbor: Update neigh_dump_info for strict

Re: [PATCH net-next] neighbor: Initialize protocol when new pneigh_entry are created

2018-12-19 Thread David Miller
From: David Ahern Date: Wed, 19 Dec 2018 15:53:22 -0800 > From: David Ahern > > pneigh_lookup uses kmalloc versus kzalloc when new entries are allocated. > Given that the newly added protocol field needs to be initialized. > > Fixes: df9b0e30d44c ("neighbor: Add protocol attribute") > Signed-o

Re: [RFT][PATCH 4/7] net: dsa: microchip: Remove dev->txbuf

2018-12-19 Thread Florian Fainelli
On 12/19/18 5:06 PM, Marek Vasut wrote: > Previous patches unconver that ksz_spi_write() is always ever called > with len = 1, 2 or 4. We can thus drop the if (len > SPI_TX_BUF_LEN) > check and we can also drop the allocation of the txbuf which is part > of the driver data. This wastes 256 bytes fo

Re: [PATCH bpf-next 1/1] bpf: sparc64: Enable sparc64 jit to provide bpf_line_info

2018-12-19 Thread Daniel Borkmann
On 12/19/2018 10:36 PM, David Miller wrote: > From: Martin KaFai Lau > Date: Wed, 19 Dec 2018 13:30:54 -0800 > >> This patch enables sparc64's bpf_int_jit_compile() to provide >> bpf_line_info by calling bpf_prog_fill_jited_linfo(). >> >> Signed-off-by: Martin KaFai Lau > > Acked-by: David S. M

Re: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-19 Thread Marek Vasut
On 12/20/2018 12:31 AM, Marek Vasut wrote: > On 12/20/2018 12:11 AM, Marek Vasut wrote: >> On 12/19/2018 11:30 PM, tristram...@microchip.com wrote: Can this use regmap instead ? >>> >>> To tell the truth I do not know how. >>> >>> Some customers, like Sergio, seem to be using KSZ9897 with

[RFT][PATCH 4/7] net: dsa: microchip: Remove dev->txbuf

2018-12-19 Thread Marek Vasut
Previous patches unconver that ksz_spi_write() is always ever called with len = 1, 2 or 4. We can thus drop the if (len > SPI_TX_BUF_LEN) check and we can also drop the allocation of the txbuf which is part of the driver data. This wastes 256 bytes for no reason and can be replaced with 8-byte stac

[RFT][PATCH 3/7] net: dsa: microchip: Inline ksz_spi.h

2018-12-19 Thread Marek Vasut
The functions in the header file are static, and the header file is included from single C file, just inline the code into the C file. The bonus is that it's easier to spot further content to clean up. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Tristram Ha Cc: Woojung

[RFT][PATCH 7/7] net: dsa: microchip: Dispose of ksz_io_ops

2018-12-19 Thread Marek Vasut
Since the driver now uses regmap , get rid of ad-hoc ksz_io_ops abstraction, which no longer has any meaning. Moreover, since regmap has it's own locking, get rid of the register access mutex. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Tristram Ha Cc: Woojung Huh ---

[RFT][PATCH 6/7] net: dsa: microchip: Initial SPI regmap support

2018-12-19 Thread Marek Vasut
Add basic SPI regmap support into the driver. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Tristram Ha Cc: Woojung Huh --- drivers/net/dsa/microchip/Kconfig | 1 + drivers/net/dsa/microchip/ksz9477_spi.c | 85 - drivers/net/dsa/microchip/

[RFT][PATCH 5/7] net: dsa: microchip: Factor out register access opcode generation

2018-12-19 Thread Marek Vasut
Factor out the code which sends out the register read/write opcodes to the switch, since the code differs in single bit between read and write. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Tristram Ha Cc: Woojung Huh --- drivers/net/dsa/microchip/ksz9477_spi.c | 22 +++

[RFT][PATCH 1/7] net: dsa: microchip: Remove ksz_{read,write}24()

2018-12-19 Thread Marek Vasut
These functions and callbacks are never used, remove them. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Tristram Ha Cc: Woojung Huh --- drivers/net/dsa/microchip/ksz9477_spi.c | 25 - drivers/net/dsa/microchip/ksz_common.h | 22

[RFT][PATCH 0/7] net: dsa: microchip: Convert to regmap

2018-12-19 Thread Marek Vasut
This patchset converts KSZ9477 switch driver to regmap. This was only compile-tested as I don't own a device with KSZ9477, but is implemented in hope that it will help with proper regmap conversion. Note that the first 5 patches might just go in as cleanups, the 6/7 and 7/7 probably need more deb

[RFT][PATCH 2/7] net: dsa: microchip: Remove ksz_{get,set}()

2018-12-19 Thread Marek Vasut
These functions and callbacks are never used, remove them. Signed-off-by: Marek Vasut Cc: Andrew Lunn Cc: Florian Fainelli Cc: Tristram Ha Cc: Woojung Huh --- drivers/net/dsa/microchip/ksz9477_spi.c | 2 -- drivers/net/dsa/microchip/ksz_common.h | 24 drivers/net/d

[PATCH net] neighbor: NTF_PROXY is a valid ndm_flag for a dump request

2018-12-19 Thread David Ahern
From: David Ahern When dumping proxy entries the dump request has NTF_PROXY set in ndm_flags. strict mode checking needs to be updated to allow this flag. Fixes: 51183d233b5a ("net/neighbor: Update neigh_dump_info for strict data checking") Signed-off-by: David Ahern --- net/core/neighbour.c

Re: [PATCH bpf-next v2 0/7] Add support for XDP_ATTACH

2018-12-19 Thread Alexei Starovoitov
On Wed, Dec 19, 2018 at 10:34:28AM +0100, Björn Töpel wrote: > > On 2018-12-19 00:04, Alexei Starovoitov wrote: > > On Mon, Dec 17, 2018 at 04:30:05PM +0100, Björn Töpel wrote: > > > > > > > > Instead of introducing the XDP_ATTACH option to the bind call, can we > > > > just make this association

Re: [PATCH bpf-next] libbpf: Show possible section(type) names on when failed to guess a type

2018-12-19 Thread Taeung Song
On 12/20/18 3:52 AM, Jakub Kicinski wrote: On Wed, 19 Dec 2018 17:52:40 +0900, Taeung Song wrote: We need to let users check their wrong section name with proper section names when failed to get proper type from it. Because there is no knowing what kind of section name can be used. # bpftoo

Re: [PATCH bpf-next 07/19] bpf: verifier: remove dead code

2018-12-19 Thread Alexei Starovoitov
On Wed, Dec 19, 2018 at 10:29:18AM -0800, Jakub Kicinski wrote: > Instead of overwriting dead code with jmp -1 instructions > remove it completely for root. Adjust verifier state and > line info appropriately. > > Signed-off-by: Jakub Kicinski > --- > include/linux/filter.h | 1 + > kernel/bp

Re: [PATCH net-next] net: dsa: mv88e6xxx: Add missing watchdog ops for 6320 family

2018-12-19 Thread David Miller
From: Andrew Lunn Date: Wed, 19 Dec 2018 18:28:54 +0100 > The 6320 family of switches uses the same watchdog registers as the > 6390. > > Signed-off-by: Andrew Lunn Applied, thanks Andrew.

Re: [PATCH net-next v2] selftests: net: refactor reuseport_addr_any test

2018-12-19 Thread David Miller
From: Peter Oskolkov Date: Wed, 19 Dec 2018 10:20:09 -0800 > This patch refactors reuseport_add_any selftest a bit: > - makes it more modular (eliminates several copy/pasted blocks); > - skips DCCP tests if DCCP is not supported > > V2: added "Signed-off-by" tag. > > Signed-off-by: Peter Oskolk

Re: [PATCH net v4] net: mvpp2: fix the phylink mode validation

2018-12-19 Thread David Miller
From: Antoine Tenart Date: Wed, 19 Dec 2018 18:00:12 +0100 > The mvpp2_phylink_validate() sets all modes that are supported by a > given PPv2 port. An mistake made the 1baseT_Full mode being > advertised in some cases when a port wasn't configured to perform at > 10G. This patch fixes this. >

Re: [PATCH net] net/sched: cls_flower: Remove old entries from rhashtable

2018-12-19 Thread David Miller
From: Roi Dayan Date: Wed, 19 Dec 2018 18:07:56 +0200 > When replacing a rule we add the new rule to the rhashtable > but only remove the old if not in skip_sw. > This commit fix this and remove the old rule anyway. > > Fixes: 35cc3cefc4de ("net/sched: cls_flower: Reject duplicated rules also >

Re: [PATCH net] net/tls: allocate tls context using GFP_ATOMIC

2018-12-19 Thread David Miller
From: Ganesh Goudar Date: Wed, 19 Dec 2018 17:18:22 +0530 > create_ctx can be called from atomic context, hence use > GFP_ATOMIC instead of GFP_KERNEL. > > [ 395.962599] BUG: sleeping function called from invalid context at > mm/slab.h:421 > [ 395.979896] in_atomic(): 1, irqs_disabled(): 0, p

Re: [PATCH net-next,v6 00/12] add flow_rule infrastructure

2018-12-19 Thread Jakub Kicinski
On Thu, 20 Dec 2018 01:03:13 +0100, Pablo Neira Ayuso wrote: > On Wed, Dec 19, 2018 at 11:57:03AM -0800, Jakub Kicinski wrote: > > > Anyway, the problem that this patchset addresses _already exists_ with > > > ethtool_rxnfc and cls_flower in place, it would be good to fix it now. > > > > That's

Re: [v3, PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

2018-12-19 Thread David Miller
From: Biao Huang Date: Wed, 19 Dec 2018 15:22:39 +0800 > changes in v3: > resend this series base on the latest net-next tree. > > changes in v2 as comments from Sean: > 1. fix typo. > 2. use capital letters for RMII/MII/RGMII in driver and bindings. > > v1: > This new series is the result of d

[PATCH iproute2 v2] iproute: lwtunnel set TUNNEL_KEY on LWTUNNEL_IP_FLAGS

2018-12-19 Thread wenxu
From: wenxu ip l add dev tun type gretap external ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap For gretap example when the command set the id but don't set the TUNNEL_KEY flags. There is no key field in the send packet Signed-off-by: wenxu --- include/uapi/linux/if_tunnel.h

Re: [PATCH net-next 0/2] net: phy: make PHY_HALTED a transition state to PHY_READY

2018-12-19 Thread David Miller
From: Heiner Kallweit Date: Wed, 19 Dec 2018 07:50:43 +0100 > PHY_HALTED and PHY_READY both are non-started states and quite similar. > Major difference is that phy_start() changes from PHY_HALTED to > PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does). > > There's no guarantee that

  1   2   3   4   >