Re: linux-next: build warnings after merge of the wireless-drivers-next tree

2018-12-18 Thread Kalle Valo
Stephen Rothwell writes: > On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell > wrote: >> >> After merging the wireless-drivers-next tree, today's linux-next build >> (x86_64 allmodconfig) produced these warnings: >> >> drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function >> 'iwl_parse_

Re: [PATCH net-next] net: add network device notifier trace points

2018-12-18 Thread Jesper Dangaard Brouer
On Tue, 18 Dec 2018 18:27:06 -0800 Stephen Hemminger wrote: > This is the result of a conversation about monitoring of link > state changes with BPF. If you want to use this from BPF then you are in for a surprise. As tracepoints BPF cannot read these "__string" constructs, here the netdev name

Re: [PATCH V2] net/mlx4: Get rid of page operation after dma_alloc_coherent

2018-12-18 Thread Christoph Hellwig
On Tue, Dec 18, 2018 at 05:12:41PM -0700, Stephen Warren wrote: > On 12/18/18 1:56 PM, Christoph Hellwig wrote: >> This goes in the right direction, but I think we need to stop >> abusing the scatterlist for the coherent mapping entirely. Something >> like the patch below (based on yours): > > Oh,

[v3, PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

2018-12-18 Thread Biao Huang
changes in v3: resend this series base on the latest net-next tree. changes in v2 as comments from Sean: 1. fix typo. 2. use capital letters for RMII/MII/RGMII in driver and bindings. v1: This new series is the result of discussion in: http://lkml.org/lkml/2018/12/13/1007 http://lkml.org/lkml/201

[v3, PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

2018-12-18 Thread Biao Huang
1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71 +

[v3, PATCH 1/2] net-next: dt-binding: dwmac-mediatek: remove fine-tune property

2018-12-18 Thread Biao Huang
remove fine-tune property in device tree, modify the corresponding description in dt-binding. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 31 +++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree/bin

[PATCH 2/5] net: drivers/amd: restore access to MIPS Alchemy platform

2018-12-18 Thread Manuel Lauss
The MIPS Alchemy platform needs access to the au1000_eth.c driver, which resides in the AMD driver directory (as the chips were at a time made by AMD). Cc: netdev@vger.kernel.org Signed-off-by: Manuel Lauss --- drivers/net/ethernet/amd/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH net-next] net: sched: add checks for tbf classid

2018-12-18 Thread xiangxia . m . yue
From: Tonghao Zhang tbf has only one qdisc class. When adding qdisc for it, we should check the classid, otherwise the parentid:1 classid is available, no matter what classid tc specified. $ tc qdisc add dev eth1 handle 10: root tbf rate 0.5mbit burst 5kb latency 70ms $ tc class show dev eth1 cl

[PATCH net-next 2/2] net: phy: remove states PHY_CHANGELINK and PHY_RESUMING

2018-12-18 Thread Heiner Kallweit
After having made PHY_HALTED a transition state to PHY_READY and having removed direct use of PHY_CHANGELINK in drivers we can remove states PHY_RESUMING and PHY_CHANGELINK. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 4 include/linux/phy.h | 12 2 files chang

[PATCH net-next 1/2] net: phy: make PHY_HALTED a transition state to PHY_READY

2018-12-18 Thread Heiner Kallweit
PHY_HALTED and PHY_READY both are non-started states and quite similar. Major difference is that phy_start() changes from PHY_HALTED to PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does). There's no guarantee that PHY registers are completely untouched when waking up from power-down, e

[PATCH net-next 0/2] net: phy: make PHY_HALTED a transition state to PHY_READY

2018-12-18 Thread Heiner Kallweit
PHY_HALTED and PHY_READY both are non-started states and quite similar. Major difference is that phy_start() changes from PHY_HALTED to PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does). There's no guarantee that PHY registers are completely untouched when waking up from power-down, e

[PATCH net-next] xfrm6_tunnel: Fix spi check in __xfrm6_tunnel_alloc_spi

2018-12-18 Thread YueHaibing
gcc warn this: net/ipv6/xfrm6_tunnel.c:143 __xfrm6_tunnel_alloc_spi() warn: always true condition '(spi <= 4294967295) => (0-u32max <= u32max)' 'spi' is u32, which always not greater than XFRM6_TUNNEL_SPI_MAX because of wrap around. So the second forloop will never reach. Signed-off-by: YueHaib

Re: pull-request: bpf 2018-12-18

2018-12-18 Thread David Miller
From: Alexei Starovoitov Date: Tue, 18 Dec 2018 22:25:50 -0800 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) promote bpf_perf_event.h to mandatory UAPI header, from Masahiro. > > Please consider pulling these changes from: > > git://

pull-request: bpf 2018-12-18

2018-12-18 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) promote bpf_perf_event.h to mandatory UAPI header, from Masahiro. Please consider pulling these changes from: git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Thanks a lot!

Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-18 Thread Sergio Paracuellos
Hi Rob, On Tue, Dec 18, 2018 at 4:10 PM Rob Herring wrote: > > On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: > > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Sergio Paracuellos > > --- >

[PATCH v2] iptunnel: make TUNNEL_FLAGS available in uapi

2018-12-18 Thread wenxu
From: wenxu ip l add dev tun type gretap external ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap For gretap Key example when the command set the id but don't set the TUNNEL_KEY flags. There is no key field in the send packet In the lwtunnel situation, some TUNNEL_FLAGS should c

[PATCH net-next 09/10] mlxsw: spectrum_router: Hold a reference on RIF's netdev

2018-12-18 Thread Ido Schimmel
Previous patches tried to make RIF deletion more robust and avoid use-after-free situations. As another precaution, hold a reference on a RIF's netdev and release it when the RIF is deleted. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- drivers/net/ethernet/mellanox/mlxsw/spectrum_

[PATCH net-next 08/10] mlxsw: spectrum_router: Make RIF deletion more robust

2018-12-18 Thread Ido Schimmel
In the past we had multiple instances where RIFs were not properly deleted. One of the reasons for leaking a RIF was that at the time when IP addresses were flushed from the respective netdev (prompting the destruction of the RIF), the netdev was no longer a mlxsw upper. This caused the inet{,6}ad

[PATCH net-next 06/10] mlxsw: spectrum: Properly cleanup LAG uppers when removing port from LAG

2018-12-18 Thread Ido Schimmel
When a LAG device or a VLAN device on top of it is enslaved to a bridge, the driver propagates the CHANGEUPPER event to the LAG's slaves. This causes each physical port to increase the reference count of the internal representation of the bridge port by calling mlxsw_sp_port_bridge_join(). Howeve

[PATCH net-next 10/10] selftests: mlxsw: Add rtnetlink tests

2018-12-18 Thread Ido Schimmel
Add a new test that is focused on rtnetlink configuration. Its purpose is to test valid and invalid (as deemed by mlxsw) configurations and make sure that they succeed / fail without producing a trace. Some of the test cases are derived from recent fixes in order to make sure that the fixed bugs a

[PATCH net-next 07/10] mlxsw: spectrum_router: Propagate 'struct mlxsw_sp' further

2018-12-18 Thread Ido Schimmel
Next patch is going to make RIF deletion more robust by removing reliance on fragile mlxsw_sp_lower_get(). This is because a netdev is not necessarily our upper anymore when its IP addresses are flushed. The inet{,6}addr notification blocks are going to resolve 'struct mlxsw_sp' using container_of

[PATCH net-next 00/10] mlxsw: Make driver more robust

2018-12-18 Thread Ido Schimmel
In recent months we fixed several bugs in the driver that could have been avoided by re-evaluating some of the involved code paths and by introducing relevant and comprehensive test cases. This patchset tries to do that by introducing a set of small and mostly non-functional changes in addition to

[PATCH net-next 02/10] mlxsw: spectrum_router: Do not destroy RIFs based on FID's reference count

2018-12-18 Thread Ido Schimmel
Currently, when a RIF is constructed on top of a FID, the RIF increments the FID's reference count and the RIF is destroyed when the FID's reference count drops to 1. This effectively means that when no local ports are member in the FID, the FID is destroyed regardless if the router port is a membe

[PATCH net-next 01/10] mlxsw: spectrum: Sanitize VLAN interface's uppers

2018-12-18 Thread Ido Schimmel
Currently, only VRF and macvlan uppers are supported on top of VLAN device configured over a bridge, so make sure the driver forbids other uppers. Note that enslavement to a VRF is handled earlier in the notification block, so there is no need to check for a VRF upper here. Signed-off-by: Ido Sch

Re: [PATCH net-next] net: ethernet: don't set phylib state CHANGELINK in drivers

2018-12-18 Thread David Miller
From: Heiner Kallweit Date: Wed, 19 Dec 2018 00:43:58 +0100 > After phy_start() phylib takes care of all needed actions, including > aneg settings and checking link state. There's no need to set state > PHY_CHANGELINK in drivers. > > Signed-off-by: Heiner Kallweit Applied.

[PATCH net-next 04/10] mlxsw: spectrum: Handle VLAN device unlinking

2018-12-18 Thread Ido Schimmel
In commit 993107fea5ee ("mlxsw: spectrum_switchdev: Fix VLAN device deletion via ioctl") I fixed a bug caused by the fact that the driver views differently the deletion of a VLAN device when it is deleted via an ioctl and netlink. Instead of relying on a specific order of events (device being unre

[PATCH net-next 03/10] mlxsw: spectrum_fid: Remove unused function

2018-12-18 Thread Ido Schimmel
This function is no longer used. Remove it. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 1 - drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c | 5 - 2 files changed, 6 deletions(-) diff --git a/drivers/net/ethernet/mellan

[PATCH net-next 05/10] mlxsw: spectrum: Remove reference count from VLAN entries

2018-12-18 Thread Ido Schimmel
Commit b3529af6bb0d ("spectrum: Reference count VLAN entries") started reference counting port-VLAN entries in a similar fashion to the 8021q driver. However, this is not actually needed and only complicates things. Instead, the driver should forbid the creation of a VLAN on a port if this VLAN al

Re: [PATCH rdma-next 0/2] Allocate the per-port Q counter

2018-12-18 Thread Leon Romanovsky
On Tue, Dec 18, 2018 at 10:11:14PM -0700, Jason Gunthorpe wrote: > On Sun, Dec 09, 2018 at 12:52:34PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Hi > > > > See commit message for the patch description. > > > > Thanks > > > > Leon Romanovsky (1): > > net/mlx5: Add shared Q co

Re: [PATCH v4 perf, bpf-next 5/7] perf util: handle PERF_RECORD_BPF_EVENT

2018-12-18 Thread Song Liu
Please ignore this one. The other 5/7 is the right patch. Thanks, Song > On Dec 18, 2018, at 10:02 PM, Song Liu wrote: > > This patch handles PERF_RECORD_BPF_EVENT in perf record/report. > Specifically, map and symbol are created for PERF_BPF_EVENT_PROG_LOAD, > and removed for PERF_BPF_EVENT_P

Re: [PATCH v3] net/smc: fix TCP fallback socket release

2018-12-18 Thread David Miller
From: Myungho Jung Date: Tue, 18 Dec 2018 09:02:25 -0800 > clcsock can be released while kernel_accept() references it in TCP > listen worker. Also, clcsock needs to wake up before released if TCP > fallback is used and the clcsock is blocked by accept. Add a lock to > safely release clcsock and

Re: [PATCH] vxge: ensure data0 is initialized in when fetching firmware version information

2018-12-18 Thread David Miller
From: Colin King Date: Tue, 18 Dec 2018 15:19:47 + > From: Colin Ian King > > Currently variable data0 is not being initialized so a garbage value is > being passed to vxge_hw_vpath_fw_api and this value is being written to > the rts_access_steer_data0 register. There are other occurrances

[PATCH v4 perf, bpf-next 6/7] perf util: handle PERF_RECORD_BPF_EVENT

2018-12-18 Thread Song Liu
This patch adds basic handling of PERF_RECORD_BPF_EVENT. Tracking of PERF_RECORD_BPF_EVENT is OFF by default. Option --bpf-event is added to turn it on. Signed-off-by: Song Liu --- tools/perf/builtin-record.c | 1 + tools/perf/perf.h | 1 + tools/perf/util/Build | 2 ++ tools/

[PATCH v4 perf, bpf-next 2/7] sync tools/include/uapi/linux/perf_event.h

2018-12-18 Thread Song Liu
sync changes for PERF_RECORD_KSYMBOL Signed-off-by: Song Liu --- tools/include/uapi/linux/perf_event.h | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h index 9de8780ac8d9..6c

[PATCH v4 perf, bpf-next 5/7] perf util: handle PERF_RECORD_KSYMBOL

2018-12-18 Thread Song Liu
This patch handles PERF_RECORD_KSYMBOL in perf record/report. Specifically, map and symbol are created for ksymbol register, and removed for ksymbol unregister. This patch also set perf_event_attr.ksymbol properly. The flag is ON by default. Signed-off-by: Song Liu --- tools/perf/util/event.c

[PATCH v4 perf, bpf-next 1/7] perf, bpf: Introduce PERF_RECORD_KSYMBOL

2018-12-18 Thread Song Liu
For better performance analysis of dynamically JITed and loaded kernel functions, such as BPF programs, this patch introduces PERF_RECORD_KSYMBOL, a new perf_event_type that exposes kernel symbol register/unregister information to user space. The following data structure is used for PERF_RECORD_KS

[PATCH v4 perf, bpf-next 4/7] sync tools/include/uapi/linux/perf_event.h

2018-12-18 Thread Song Liu
sync for PERF_RECORD_BPF_EVENT Signed-off-by: Song Liu --- tools/include/uapi/linux/perf_event.h | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h index 6c9e327e87ed..68db

[PATCH v4 perf, bpf-next 5/7] perf util: handle PERF_RECORD_BPF_EVENT

2018-12-18 Thread Song Liu
This patch handles PERF_RECORD_BPF_EVENT in perf record/report. Specifically, map and symbol are created for PERF_BPF_EVENT_PROG_LOAD, and removed for PERF_BPF_EVENT_PROG_UNLOAD. This patch also set perf_event_attr.bpf_event properly. The flag is ON by default. Signed-off-by: Song Liu --- tools

[PATCH v4 perf, bpf-next 7/7] perf tools: synthesize PERF_RECORD_* for loaded BPF programs

2018-12-18 Thread Song Liu
This patch synthesize PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT for BPF programs loaded before perf-record. This is achieved by gathering information about all BPF programs via sys_bpf. Signed-off-by: Song Liu --- tools/perf/builtin-record.c | 6 ++ tools/perf/util/bpf-event.c | 204 ++

Re: [PATCH] xen/netfront: tolerate frags with no data

2018-12-18 Thread Juergen Gross
On 19/12/2018 07:00, David Miller wrote: > From: Juergen Gross > Date: Tue, 18 Dec 2018 16:06:19 +0100 > >> At least old Xen net backends seem to send frags with no real data >> sometimes. In case such a fragment happens to occur with the frag limit >> already reached the frontend will BUG curren

[PATCH v4 perf, bpf-next 0/7] reveal invisible bpf programs

2018-12-18 Thread Song Liu
This set catches symbol for all bpf programs loaded/unloaded before/during/after perf-record run PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT. PERF_RECORD_KSYMBOL and PERF_RECORD_BPF_EVENT includes key information of a bpf program load and unload. They are sent through perf ringbuffer, and stored

[PATCH v4 perf, bpf-next 3/7] perf, bpf: introduce PERF_RECORD_BPF_EVENT

2018-12-18 Thread Song Liu
For better performance analysis of BPF programs, this patch introduces PERF_RECORD_BPF_EVENT, a new perf_event_type that exposes BPF program load/unload information to user space. Each BPF program may contain up to BPF_MAX_SUBPROGS (256) sub programs. The following example shows kernel symbols for

Re: [PATCH] xen/netfront: tolerate frags with no data

2018-12-18 Thread David Miller
From: Juergen Gross Date: Tue, 18 Dec 2018 16:06:19 +0100 > At least old Xen net backends seem to send frags with no real data > sometimes. In case such a fragment happens to occur with the frag limit > already reached the frontend will BUG currently even if this situation > is easily recoverable

Re: hard-coded limit on unresolved multicast route cache in ipv4/ipmr.c causes slow, unreliable creation of multicast routes on busy networks

2018-12-18 Thread David Miller
From: Sukumar Gopalakrishnan Date: Wed, 19 Dec 2018 10:57:02 +0530 > Hi David, > > There are two patch for this issue: >1) Your changes which removes cache_resolve_queue_len > 2) Hangbin's changes which make cache_resolve_queue_len configurable. > > Which one will be chosen for this i

Re: [PATCH net-next] MAINTAINERS: Add a maintainer for Microsemi switches

2018-12-18 Thread David Miller
From: Alexandre Belloni Date: Tue, 18 Dec 2018 15:25:39 +0100 > Microsemi has been bought by Microchip and Microchip is supporting those > switches. > > Signed-off-by: Alexandre Belloni Applied.

Re: [PATCH net-next] tipc: handle broadcast NAME_DISTRIBUTOR packet when receiving it

2018-12-18 Thread David Miller
From: Zhenbo Gao Date: Tue, 18 Dec 2018 17:43:52 +0800 > NAME_DISTRIBUTOR messages are transmitted through unicast link on TIPC > 2.0, by contrast, the messages are delivered through broadcast link on > TIPC 1.7. But at present, NAME_DISTRIBUTOR messages received by > broadcast link cannot be han

Re: [PATCH net] net: phy: Fix the issue that netif always links up after resuming

2018-12-18 Thread David Miller
From: Kunihiko Hayashi Date: Tue, 18 Dec 2018 16:57:04 +0900 > Even though the link is down before entering hibernation, > there is an issue that the network interface always links up after resuming > from hibernation. > > If the link is still down before enabling the network interface, > and af

Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-18 Thread David Miller
From: Heiner Kallweit Date: Tue, 18 Dec 2018 19:09:36 +0100 > Eventually defining 1Gbps as default isn’t something we would need to roll > back later once PHYs above 1Gbps are the standard. We can deal with this in > phylib w/o affecting existing drivers. Therefore I think the proposed change > i

Re: [v2, PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

2018-12-18 Thread David Miller
From: Biao Huang Date: Tue, 18 Dec 2018 13:48:14 +0800 > changes in v2 as comments from Sean: > 1. fix typo. > 2. use capital letters for RMII/MII/RGMII in driver and bindings. > > v1: > This new series is the result of discussion in: > http://lkml.org/lkml/2018/12/13/1007 > http://lkml.org/lkml

Re: [PATCH net] lan78xx: Resolve issue with changing MAC address

2018-12-18 Thread David Miller
From: Jason Martinsen Date: Tue, 18 Dec 2018 05:38:22 + > Current state for the lan78xx driver does not allow for changing the MAC > address of the interface, without either removing the module (if you compiled > it that way) or rebooting the machine. If you attempt to change the MAC > ad

Re: [PATCH net-next] net: phy: remove unused code in phy_probe

2018-12-18 Thread David Miller
From: Heiner Kallweit Date: Mon, 17 Dec 2018 23:43:25 +0100 > 3c1bcc8614db ("net: ethernet: Convert phydev advertize and supported > from u32 to link mode") left some unused code in phy_probe(), remove it. > > Signed-off-by: Heiner Kallweit Applied.

Re: linux-next: build warning after merge of the net-next tree

2018-12-18 Thread Stephen Rothwell
> >> > >> This due to my use of -Wimplicit-fallthrough. This is new code. The > >> warning can be suppressed by adding a comment like /* fall through */ > >> at the appropriate places to indicate that the fallthrough is intended. > > > > I am s

Re: [PATCH v1 net] lan743x: Expand phy search for LAN7431

2018-12-18 Thread David Miller
From: Bryan Whitehead Date: Mon, 17 Dec 2018 16:44:50 -0500 > The LAN7431 uses an external phy, and it can be found anywhere in > the phy address space. This patch uses phy address 1 for LAN7430 > only. And searches all addresses otherwise. > > Signed-off-by: Bryan Whitehead Applied, thanks Br

Re: [PATCH] lib/rhashtable: Fix work initialization in rhashtable_init()

2018-12-18 Thread David Miller
From: Bart Van Assche Date: Mon, 17 Dec 2018 13:40:58 -0800 > The test_insert_dup() function from lib/test_rhashtable.c passes a > pointer to a stack object to rhltable_init(). Avoid that the following > is reported with object debugging enabled while running the selftest > from lib/test_rhashtab

Re: [PATCH net v3 0/4] vxlan: Various fixes

2018-12-18 Thread David Miller
From: Petr Machata Date: Tue, 18 Dec 2018 13:15:57 + > This patch set contains three fixes for the vxlan driver. > > Patch #1 fixes handling of offload mark on replaced VXLAN FDB entries. A > way to trigger this is to replace the FDB entry with one that can not be > offloaded. A future patch

[Patch net] ipv6: explicitly initialize udp6_addr in udp_sock_create6()

2018-12-18 Thread Cong Wang
syzbot reported the use of uninitialized udp6_addr::sin6_scope_id. We can just set ::sin6_scope_id to zero, as tunnels are unlikely to use an IPv6 address that needs a scope id and there is no interface to bind in this context. For net-next, it looks different as we have cfg->bind_ifindex there so

Re: [PATCH rdma-next 0/2] Allocate the per-port Q counter

2018-12-18 Thread Jason Gunthorpe
On Sun, Dec 09, 2018 at 12:52:34PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi > > See commit message for the patch description. > > Thanks > > Leon Romanovsky (1): > net/mlx5: Add shared Q counter bits > > Yishai Hadas (1): > IB/mlx5: Allocate the per-port Q counter shar

Re: [PATCH net-next v4 RFC 0/8] devlink: Add configuration parameters support for devlink_port

2018-12-18 Thread Jakub Kicinski
On Wed, 19 Dec 2018 08:57:21 +0530, Vasundhara Volam wrote: > This patchset adds support for configuration parameters setting through > devlink_port. Each device registers supported configuration parameters > table. Since you're not planning to address my comments, could you please quote what I s

[net-next] tipc: fix uninitialized value for broadcast retransmission

2018-12-18 Thread Hoang Le
When sending broadcast message on high load system, there are a lot of unnecessary packets restranmission. That issue was caused by missing in initial criteria for retransmission. To prevent this happen, just initialize this criteria for retransmission in next 10 milliseconds. Fixes: 31c4f4cc32f7

Re: [net] tipc: fix uninitialized value for broadcast retransmission

2018-12-18 Thread kbuild test robot
Hi Hoang, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Hoang-Le/tipc-fix-uninitialized-value-for-broadcast-retransmission/20181219-112414 config: nds32-allmodconfig (attached as .config) compiler: nds32

RE: [PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-18 Thread Woojung.Huh
Hi Tristram, > diff --git a/drivers/net/dsa/microchip/ksz9477_i2c.c > b/drivers/net/dsa/microchip/ksz9477_i2c.c > new file mode 100644 > index 000..29511e9 > --- /dev/null > +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c .. > +static int ksz_i2c_read24(struct ksz_device *dev, u32 reg, u32 *val)

Re: [PATCH v2 net-next 08/10] net: eth: altera: add support for ptp and timestamping

2018-12-18 Thread Richard Cochran
On Thu, Dec 13, 2018 at 09:52:50AM -0800, dwest...@gmail.com wrote: > Changes from V1: > -> Remove debugfs for tod manipulation > -> Reorder variable declarations in functions to order > by length of declaration, largest to smallest > -> Rename altera_ptp to intel_fpga_tod > -> Rename funct

Re: [PATCH net-next v2 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue

2018-12-18 Thread Cong Wang
On Mon, Dec 17, 2018 at 2:30 AM Jiri Pirko wrote: > > Sun, Dec 16, 2018 at 07:52:18PM CET, xiyou.wangc...@gmail.com wrote: > >On Sun, Dec 16, 2018 at 8:32 AM Vlad Buslov wrote: > >> > >> On Thu 13 Dec 2018 at 23:32, Cong Wang wrote: > >> > On Tue, Dec 11, 2018 at 2:19 AM Vlad Buslov wrote: > >>

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Cong Wang
On Tue, Dec 18, 2018 at 4:40 AM Stefano Brivio wrote: > Not as far as I know. The selftests checking this path, by design, only > use supported configurations, they don't forge packets. > > Maybe it would be nice to have a semi-automated way to isolate and > describe/name specific conditions found

Re: [net] tipc: fix uninitialized value for broadcast retransmission

2018-12-18 Thread kbuild test robot
Hi Hoang, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Hoang-Le/tipc-fix-uninitialized-value-for-broadcast-retransmission/20181219-112414 config: i386-randconfig-x002-201850 (attached as .config) compil

[PATCH v1 net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-18 Thread Tristram.Ha
From: Tristram Ha Add KSZ9477 I2C driver support. The code ksz9477.c and ksz_common.c are used together to generate the I2C driver. Signed-off-by: Tristram Ha --- v1 - Return error code from i2c_transfer - Change GPL license - Change author drivers/net/dsa/microchip/Kconfig | 6 + dr

Re: [PATCH net-next] net: add network device notifier trace points

2018-12-18 Thread David Ahern
On 12/18/18 7:27 PM, Stephen Hemminger wrote: > There already are network trace points for transmit and receive but > nothing for state changes. Add network tracepoints for before and > after netlink callback is done. This is simple (without extack or > other info) but that could be added if usefu

[PATCH net-next v4 RFC 4/8] devlink: Add support for driverinit get value for devlink_port

2018-12-18 Thread Vasundhara Volam
Add support for "driverinit" configuration mode value for devlink_port configuration parameters. Add devlink_port_param_driverinit_value_get() function to help the driver get the value from devlink_port. Also, move the common code to __devlink_param_driverinit_value_get() to be used by both device

[PATCH net-next v4 RFC 2/8] devlink: Add port param get command

2018-12-18 Thread Vasundhara Volam
Add port param get command which gets data per parameter. It also has option to dump the parameters data per port. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/uapi/linux/devlink.h | 2 + net/core/devlink.c | 102 --- 2 files cha

[PATCH net-next v4 RFC 1/8] devlink: Add devlink_param for port register and unregister

2018-12-18 Thread Vasundhara Volam
Add functions to register and unregister for the driver supported configuration parameters table per port. v2->v3: - Add a helper __devlink_params_register() with common code used by both devlink_params_register() and devlink_port_params_register(). Cc: Jiri Pirko Signed-off-by: Vasundhara Vol

[PATCH net-next v4 RFC 0/8] devlink: Add configuration parameters support for devlink_port

2018-12-18 Thread Vasundhara Volam
This patchset adds support for configuration parameters setting through devlink_port. Each device registers supported configuration parameters table. The user can retrieve data on these parameters by "devlink port param show" command and can set new value to a parameter by "devlink port param set

[PATCH net-next v4 RFC 8/8] bnxt_en: Add bnxt_en initial port params table and register it

2018-12-18 Thread Vasundhara Volam
Register devlink_port with devlink and create initial port params table for bnxt_en. The table consists of a generic parameter: wake_on_lan: Enables Wake on Lan for this port when magic packet is received with this port's MAC address using ACPI pattern. If enabled, the controller asserts a wake pi

[PATCH net-next v4 RFC 7/8] devlink: Add a generic wake_on_lan port parameter

2018-12-18 Thread Vasundhara Volam
wake_on_lan - Enables Wake on Lan for this port. If enabled, the controller asserts a wake pin based on the WOL type. v2->v3: - Define only WOL types used now and define them as bitfield, so that mutliple WOL types can be enabled upon power on. - Modify "wake-on-lan" name to "wake_on_lan" to be

[PATCH net-next v4 RFC 3/8] devlink: Add port param set command

2018-12-18 Thread Vasundhara Volam
Add port param set command to set the value for a parameter. Value can be set to any of the supported configuration modes. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/uapi/linux/devlink.h | 1 + net/core/devlink.c | 37 - 2 files cha

[PATCH net-next v4 RFC 5/8] devlink: Add support for driverinit set value for devlink_port

2018-12-18 Thread Vasundhara Volam
Add support for "driverinit" configuration mode value for devlink_port configuration parameters. Add devlink_port_param_driverinit_value_set() function to help the driver set the value to devlink_port. Also, move the common code to __devlink_param_driverinit_value_set() to be used by both device a

[PATCH net-next v4 RFC 6/8] devlink: Add devlink notifications support for port params

2018-12-18 Thread Vasundhara Volam
Add notification call for devlink port param set, register and unregister functions. Add devlink_port_param_value_changed() function to enable the driver notify devlink on value change. Driver should use this function after value was changed on any configuration mode part to driverinit. Cc: Jiri P

Re: linux-next: build warning after merge of the net-next tree

2018-12-18 Thread Gustavo A. R. Silva
at the appropriate places to indicate that the fallthrough is intended. I am still seeing these warnings. That's weird. I don't see them anymore in next-20181218. They were fixed by this commit: c1cb11bcbd09f5f027cbc7fadddab169714948df Thanks -- Gustavo

Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE

2018-12-18 Thread Jisheng Zhang
On Mon, 17 Dec 2018 08:37:35 +0100 Thomas Petazzoni wrote: > Hello Marcin, > > On Mon, 17 Dec 2018 00:25:58 +0100, Marcin Wojtas wrote: > > > Thanks. Indeed, the patch is valid as a fix for current version of SW > > BM. However, because this concept is broken, I will rework it and > > submit p

Re: bpftool cross-compilation for arm64

2018-12-18 Thread Ivan Babrou
On Tue, Dec 18, 2018 at 7:02 PM Stanislav Fomichev wrote: > > On 12/18, Ivan Babrou wrote: > > On Tue, Dec 18, 2018 at 6:06 PM Stanislav Fomichev wrote: > > > > > > On 12/18, Ivan Babrou wrote: > > > > On Tue, Dec 18, 2018 at 4:30 PM Stanislav Fomichev > > > > wrote: > > > > > > > > > > On 12/1

Re: bpftool cross-compilation for arm64

2018-12-18 Thread Stanislav Fomichev
On 12/18, Ivan Babrou wrote: > On Tue, Dec 18, 2018 at 6:06 PM Stanislav Fomichev wrote: > > > > On 12/18, Ivan Babrou wrote: > > > On Tue, Dec 18, 2018 at 4:30 PM Stanislav Fomichev > > > wrote: > > > > > > > > On 12/18, Ivan Babrou wrote: > > > > > Hey, > > > > > > > > > > Is it possible to cr

[PATCH] ipw2x00: cleanup dead code

2018-12-18 Thread YueHaibing
Fix smatch warning: drivers/net/wireless/intel/ipw2x00/ipw2100.c:5606 shim__set_security() warn: always true condition '(sec->active_key <= 3) => (0-3 <= 3)' drivers/net/wireless/intel/ipw2x00/ipw2200.c:10725 shim__set_security() warn: always true condition '(sec->active_key <= 3) => (0-3 <= 3

[net] tipc: fix uninitialized value for broadcast retransmission

2018-12-18 Thread Hoang Le
When sending broadcast message on high load system, there are a lot of unnecessary packets restranmission. That issue was caused by missing in initial criteria for retransmission. To prevent this happen, just initialize this criteria for retransmission in next 10 milliseconds. Fixes: 31c4f4cc32f7

Re: linux-next: build warnings after merge of the wireless-drivers-next tree

2018-12-18 Thread Stephen Rothwell
Hi all, On Fri, 30 Nov 2018 12:05:55 +1100 Stephen Rothwell wrote: > > After merging the wireless-drivers-next tree, today's linux-next build > (x86_64 allmodconfig) produced these warnings: > > drivers/net/wireless/intel/iwlwifi/iwl-drv.c: In function > 'iwl_parse_tlv_firmware': > drivers/net

Re: linux-next: build warning after merge of the net-next tree

2018-12-18 Thread Stephen Rothwell
Hi all, On Thu, 29 Nov 2018 11:24:28 +1100 Stephen Rothwell wrote: > > After merging the net-next tree, today's linux-next build > (x86_64_allmodconfig) produced this warning: > > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function 'run_xdp': > drivers/net/ethernet/freescale/dpaa2/dpa

[net-next 3/5] tipc: add trace_events for tipc socket

2018-12-18 Thread Tuong Lien
The commit adds the new trace_events for TIPC socket object: trace_tipc_sk_create() trace_tipc_sk_poll() trace_tipc_sk_sendmsg() trace_tipc_sk_sendmcast() trace_tipc_sk_sendstream() trace_tipc_sk_filter_rcv() trace_tipc_sk_advance_rx() trace_tipc_sk_rej_msg() trace_tipc_sk_drop_msg() trace_tipc_sk

[net-next 5/5] tipc: add trace_events for tipc bearer

2018-12-18 Thread Tuong Lien
The commit adds the new trace_event for TIPC bearer, L2 device event: trace_tipc_l2_device_event() Also, it puts the trace at the tipc_l2_device_event() function, then the device/bearer events and related info can be traced out during runtime when needed. Acked-by: Ying Xue Tested-by: Ying Xue

[net-next 1/5] tipc: enable tracepoints in tipc

2018-12-18 Thread Tuong Lien
As for the sake of debugging/tracing, the commit enables tracepoints in TIPC along with some general trace_events as shown below. It also defines some 'tipc_*_dump()' functions that allow to dump TIPC object data whenever needed, that is, for general debug purposes, ie. not just for the trace_event

[net-next 2/5] tipc: add trace_events for tipc link

2018-12-18 Thread Tuong Lien
The commit adds the new trace_events for TIPC link object: trace_tipc_link_timeout() trace_tipc_link_fsm() trace_tipc_link_reset() trace_tipc_link_too_silent() trace_tipc_link_retrans() trace_tipc_link_bc_ack() trace_tipc_link_conges() And the traces for PROTOCOL messages at building and receivin

[net-next 0/5] tipc: tracepoints and trace_events in TIPC

2018-12-18 Thread Tuong Lien
The patch series is the first step of introducing a tracing framework in TIPC, which will assist in collecting complete & plentiful data for post analysis, even in the case of a single failure occurrence e.g. when the failure is unreproducible. The tracing code in TIPC utilizes the powerful kernel

[net-next 4/5] tipc: add trace_events for tipc node

2018-12-18 Thread Tuong Lien
The commit adds the new trace_events for TIPC node object: trace_tipc_node_create() trace_tipc_node_delete() trace_tipc_node_lost_contact() trace_tipc_node_timeout() trace_tipc_node_link_up() trace_tipc_node_link_down() trace_tipc_node_reset_links() trace_tipc_node_fsm_evt() trace_tipc_node_check_

[PATCH net-next] net: add network device notifier trace points

2018-12-18 Thread Stephen Hemminger
There already are network trace points for transmit and receive but nothing for state changes. Add network tracepoints for before and after netlink callback is done. This is simple (without extack or other info) but that could be added if useful. Network namespace id would also be helpful but hard

Re: bpftool cross-compilation for arm64

2018-12-18 Thread Ivan Babrou
On Tue, Dec 18, 2018 at 6:06 PM Stanislav Fomichev wrote: > > On 12/18, Ivan Babrou wrote: > > On Tue, Dec 18, 2018 at 4:30 PM Stanislav Fomichev wrote: > > > > > > On 12/18, Ivan Babrou wrote: > > > > Hey, > > > > > > > > Is it possible to cross-compile bpftool for arm64? I'm trying to do > > >

Re: bpftool cross-compilation for arm64

2018-12-18 Thread Stanislav Fomichev
On 12/18, Ivan Babrou wrote: > On Tue, Dec 18, 2018 at 4:30 PM Stanislav Fomichev wrote: > > > > On 12/18, Ivan Babrou wrote: > > > Hey, > > > > > > Is it possible to cross-compile bpftool for arm64? I'm trying to do > > > the same thing we do for perf, but bpftool Makefile doesn't seem to > > > s

[PATCH net v2] net: phy: Fix the issue that netif always links up after resuming

2018-12-18 Thread Kunihiko Hayashi
Even though the link is down before entering hibernation, there is an issue that the network interface always links up after resuming from hibernation. If the link is still down before enabling the network interface, and after resuming from hibernation, the phydev->state is forcibly set to PHY_UP

Re: [PATCH net] net: phy: Fix the issue that netif always links up after resuming

2018-12-18 Thread Kunihiko Hayashi
Hi Heiner, On Tue, 18 Dec 2018 19:15:39 +0100 wrote: > On 18.12.2018 08:57, Kunihiko Hayashi wrote: > > Even though the link is down before entering hibernation, > > there is an issue that the network interface always links up after resuming > > from hibernation. > > > > If the link is still do

[PATCH net-next] xfrm: policy: remove set but not used variable 'priority'

2018-12-18 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: net/xfrm/xfrm_policy.c: In function 'xfrm_policy_lookup_bytype': net/xfrm/xfrm_policy.c:2079:6: warning: variable 'priority' set but not used [-Wunused-but-set-variable] It not used since commit 6be3b0db6db8 ("xfrm: policy: add inexact policy search

[bpf-next RFCv2 2/3] veth: support AF_XDP.

2018-12-18 Thread William Tu
The patch adds support for AF_XDP async xmit. Users can use AF_XDP on both side of the veth and get better performance, with the cost of ksoftirqd doing the xmit. The veth_xsk_async_xmit simply kicks the napi function, veth_poll, to run, and the transmit logic is implemented there. Tested using

[bpf-next RFCv2 3/3] samples: bpf: add veth AF_XDP example.

2018-12-18 Thread William Tu
Add example use cases for AF_XDP socket on two namespaces. The script runs sender at the root namespace, and receiver at the at_ns0 namespace with different XDP actions. Signed-off-by: William Tu --- samples/bpf/test_veth_afxdp.sh | 67 ++ 1 file changed,

[bpf-next RFCv2 1/3] xsk: add xsk_umem_consume_tx_virtual.

2018-12-18 Thread William Tu
Currently the xsk_umem_consume_tx expects only the physical NICs so the api returns a dma address. This patch introduce the new function to return the virtual address, when XSK is used by a virtual device. Signed-off-by: William Tu --- include/net/xdp_sock.h | 7 +++ net/xdp/xdp_umem.c

[bpf-next RFCv2 0/3] AF_XDP support for veth.

2018-12-18 Thread William Tu
The patch series adds AF_XDP async xmit support for veth device. First patch add a new API for supporting non-physical NIC device to get packet's virtual address. The second patch implements the async xmit, and last patch adds example use cases. I tested with 2 namespaces, one as sender, the othe

  1   2   3   4   >