[PATCH] cxgb4: remove DEFINE_SIMPLE_DEBUGFS_FILE()

2018-12-14 Thread Yangtao Li
We already have the DEFINE_SHOW_ATTRIBUTE. There is no need to define such a macro, so remove DEFINE_SIMPLE_DEBUGFS_FILE. Also use the DEFINE_SHOW_ATTRIBUTE macro to simplify some code. Signed-off-by: Yangtao Li --- .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 113 -- .../ethe

[PATCH] 6lowpan: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-14 Thread Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- net/6lowpan/debugfs.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/net/6lowpan/debugfs.c b/net/6lowpan/debugfs.c index 24915e0bb9ea..6c152f9ea26e 100644 --- a/net/6lowpan/debu

[PATCH] ipconfig: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-14 Thread Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- net/ipv4/ipconfig.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 88212615bf4c..fcb817d0eb24 100644 --- a/net/ipv4/ipconfig.c ++

[PATCH] sunrpc: convert to DEFINE_SHOW_ATTRIBUTE

2018-12-14 Thread Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- net/sunrpc/rpc_pipe.c | 19 +++ net/sunrpc/stats.c| 14 +- 2 files changed, 4 insertions(+), 29 deletions(-) diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c index 4fda1

[PATCH] SUNRPC: fix comment style

2018-12-14 Thread zhengbin
If there is only one line comment, we should use /* ... */ Signed-off-by: zhengbin --- net/sunrpc/xprt.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c index ce92700..68a80eb 100644 --- a/net/sunrpc/xprt.c +++ b/net/sunrpc/xprt.c

Re: BUG at /net/ipx/af_ipx.c

2018-12-14 Thread Stephen Hemminger
On Sat, 15 Dec 2018 12:14:41 +0800 (CST) tenys <15667082...@163.com> wrote: > it looks like a pointer stored without holding a reference > for the source code  in kernel version v4.14.88, and the fuction is : > ipxitf_insert_socket > > static void ipxitf_insert_socket(struct ipx_interface *intrf

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-14 Thread Taehee Yoo
On Sat, 15 Dec 2018 at 09:58, David Miller wrote: > > From: Taehee Yoo > Date: Wed, 12 Dec 2018 10:19:26 +0900 > > > When bpfilter error occurred bpfilter_umh will be stopped via __stop_umh(). > > The bpfilter_umh() couldn't start again because there is no restart > > routine. > > > > The section

[PATCH net-next v2 2/4] bridge: support for ndo_fdb_get

2018-12-14 Thread Roopa Prabhu
From: Roopa Prabhu This patch implements ndo_fdb_get for the bridge fdb. Signed-off-by: Roopa Prabhu Acked-by: Nikolay Aleksandrov --- net/bridge/br_device.c | 1 + net/bridge/br_fdb.c | 26 ++ net/bridge/br_private.h | 3 +++ 3 files changed, 30 insertions(+)

[PATCH net-next v2 0/4] rtnl fdb get

2018-12-14 Thread Roopa Prabhu
From: Roopa Prabhu This series adds support for rtnl fdb get similar to route get. v2: add nda_policy, fixes to exact msgs, strict nlmsg parsing Roopa Prabhu (4): net: rtnetlink: support for fdb get bridge: support for ndo_fdb_get vxlan: support for ndo_fdb_get selftests: net: rtnetlink

[PATCH net-next v2 1/4] net: rtnetlink: support for fdb get

2018-12-14 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support for fdb get similar to route get. arguments can be any of the following (similar to fdb add/del/dump): [bridge, mac, vlan] or [bridge_port, mac, vlan, flags=[NTF_MASTER]] or [dev, mac, [vni|vlan], flags=[NTF_SELF]] Signed-off-by: Roopa Prabhu --- incl

[PATCH net-next v2 3/4] vxlan: support for ndo_fdb_get

2018-12-14 Thread Roopa Prabhu
From: Roopa Prabhu This patch implements ndo_fdb_get for a vxlan device. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 49d4b58..71c3b7b 100644 --- a/dri

[PATCH net-next v2 4/4] selftests: net: rtnetlink.sh: add fdb get test

2018-12-14 Thread Roopa Prabhu
From: Roopa Prabhu tests the below three cases of bridge fdb get: [bridge, mac, vlan] [bridge_port, mac, vlan, flags=[NTF_MASTER]] [vxlandev, mac, flags=NTF_SELF] depends on iproute2 support for bridge fdb get. Signed-off-by: Roopa Prabhu --- tools/testing/selftests/net/rtnetlink.sh | 53

BUG at /net/ipx/af_ipx.c

2018-12-14 Thread tenys
it looks like a pointer stored without holding a reference for the source code  in kernel version v4.14.88, and the fuction is : ipxitf_insert_socket static void ipxitf_insert_socket(struct ipx_interface *intrfc, struct sock *sk) { ipxitf_hold(intrfc); spin_lock_bh(&intrfc->if_skli

Re: [PATCH bpf-next 6/8] tools: bpftool: add probes for eBPF helper functions

2018-12-14 Thread Quentin Monnet
2018-12-15 01:08 UTC+0100 ~ Daniel Borkmann > On 12/13/2018 01:19 PM, Quentin Monnet wrote: >> Similarly to what was done for program types and map types, add a set of >> probes to test the availability of the different eBPF helper functions >> on the current system. >> >> Sample output: >> >>

Re: [PATCH bpf-next 1/8] tools: bpftool: add basic probe capability, probe syscall and kversion

2018-12-14 Thread Quentin Monnet
2018-12-15 00:35 UTC+0100 ~ Daniel Borkmann > On 12/13/2018 01:19 PM, Quentin Monnet wrote: >> Add a new component and command for bpftool, in order to probe the >> system to dump a set of eBPF-related parameters so that users can know >> what features are available on the system. >> >> Parameters

Re: [PATCH bpf-next 3/8] tools: bpftool: add probes for kernel configuration options

2018-12-14 Thread Quentin Monnet
2018-12-15 00:56 UTC+0100 ~ Daniel Borkmann > On 12/13/2018 01:19 PM, Quentin Monnet wrote: >> Add probes to dump a number of options set (or not set) for compiling >> the kernel image. These parameters provide information about what BPF >> components should be available on the system. A number of

Re: [PATCH bpf-next 2/8] tools: bpftool: add probes for /proc/ eBPF parameters

2018-12-14 Thread Quentin Monnet
2018-12-15 00:40 UTC+0100 ~ Daniel Borkmann > On 12/13/2018 01:19 PM, Quentin Monnet wrote: >> Add a set of probes to dump the eBPF-related parameters available from >> /proc/: availability of bpf() syscall for unprivileged users, >> JIT compiler status and hardening status, kallsyms exports statu

Re: [PATCH bpf-next 1/8] tools: bpftool: add basic probe capability, probe syscall and kversion

2018-12-14 Thread Quentin Monnet
2018-12-14 10:45 UTC-0800 ~ Stanislav Fomichev > On 12/14, Quentin Monnet wrote: >> 2018-12-13 18:50 UTC-0800 ~ Stanislav Fomichev >>> On 12/13, Quentin Monnet wrote: Add a new component and command for bpftool, in order to probe the system to dump a set of eBPF-related parameters so th

[Patch net 02/10] net: hns: All ports can not work when insmod hns ko after rmmod.

2018-12-14 Thread Peng Li
From: Yonglong Liu There are two test cases: 1. Remove the 4 modules:hns_enet_drv/hns_dsaf/hnae/hns_mdio, and install them again, must use "ifconfig down/ifconfig up" command pair to bring port to work. This patch calls phy_stop function when init phy to fix this bug. 2. Remove the 2 m

[Patch net 06/10] net: hns: Free irq when exit from abnormal branch

2018-12-14 Thread Peng Li
From: Yonglong Liu 1.In "hns_nic_init_irq", if request irq fail at index i, the function return directly without releasing irq resources that already requested. 2.In "hns_nic_net_up" after "hns_nic_init_irq", if exceptional branch occurs, irqs that already requested are not release. Sig

[Patch net 07/10] net: hns: Avoid net reset caused by pause frames storm

2018-12-14 Thread Peng Li
From: Yonglong Liu There will be a large number of MAC pause frames on the net, which caused tx timeout of net device. And then the net device was reset to try to recover it. So that is not useful, and will cause some other problems. So need doubled ndev->watchdog_timeo if device watchdog occurr

[Patch net 00/10] net: hns: Code improvements & fixes for HNS driver

2018-12-14 Thread Peng Li
This patchset introduces some code improvements and fixes for the identified problems in the HNS driver. Every patch is independent. Yonglong Liu (10): net: hns: Incorrect offset address used for some registers. net: hns: All ports can not work when insmod hns ko after rmmod. net: hns: some

[Patch net 09/10] net: hns: Add mac pcs config when enable|disable mac

2018-12-14 Thread Peng Li
From: Yonglong Liu In some case, when mac enable|disable and adjust link, may cause hard to link(or abnormal) between mac and phy. This patch adds the code for rx PCS to avoid this bug. Disable the rx PCS when driver disable the gmac, and enable the rx PCS when driver enable the mac. Signed-off

[Patch net 05/10] net: hns: Clean rx fbd when ae stopped.

2018-12-14 Thread Peng Li
From: Yonglong Liu If there are packets in hardware when changing the speed or duplex, it may cause hardware hang up. This patch adds the code to wait rx fbd clean up when ae stopped. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 3

[Patch net 01/10] net: hns: Incorrect offset address used for some registers.

2018-12-14 Thread Peng Li
From: Yonglong Liu According to the hip06 Datasheet: 1. The offset of INGRESS_SW_VLAN_TAG_DISC should be 0x1A00+4*all_chn_num 2. The offset of INGRESS_IN_DATA_STP_DISC should be 0x1A50+4*all_chn_num Signed-off-by: Yonglong Liu Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns/hns_

[Patch net 08/10] net: hns: Fix ntuple-filters status error.

2018-12-14 Thread Peng Li
From: Yonglong Liu The ntuple-filters features is forced on by chip. But it shows "ntuple-filters: off [fixed]" when use ethtool. This patch make it correct with "ntuple-filters: on [fixed]". Signed-off-by: Yonglong Liu Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns/hns_enet.c

[Patch net 10/10] net: hns: Fix ping failed when use net bridge and send multicast

2018-12-14 Thread Peng Li
From: Yonglong Liu Create a net bridge, add eth and vnet to the bridge. The vnet is used by a virtual machine. When ping the virtual machine from the outside host and the virtual machine send multicast at the same time, the ping package will lost. The multicast package send to the eth, eth will

[Patch net 03/10] net: hns: Some registers use wrong address according to the datasheet.

2018-12-14 Thread Peng Li
From: Yonglong Liu According to the hip06 datasheet: 1.Six registers use wrong address: RCB_COM_SF_CFG_INTMASK_RING RCB_COM_SF_CFG_RING_STS RCB_COM_SF_CFG_RING RCB_COM_SF_CFG_INTMASK_BD RCB_COM_SF_CFG_BD_RINT_STS DSAF_INODE_VC1_IN_PKT_NUM_0_REG 2.The offset of DSAF_INODE_VC1_IN_PKT_NU

[Patch net 04/10] net: hns: Fixed bug that netdev was opened twice

2018-12-14 Thread Peng Li
From: Yonglong Liu After resetting dsaf to try to repair chip error such as ecc error, the net device will be open if net interface is up. But at this time if there is the users set the net device up with the command ifconfig, the net device will be opened twice consecutively. Function napi_enab

[PATCH 5/7] ethtool: dsa: mv88e6xxx: add pretty dump for 88E6352

2018-12-14 Thread Vivien Didelot
This patch adds support for pretty dump the port registers of the 88E6172, 88E6176, 88E6240 and 88E6352 switches, which all share the same datasheet. Signed-off-by: Vivien Didelot --- dsa.c | 175 ++ 1 file changed, 175 insertions(+) diff

[PATCH 7/7] ethtool: dsa: mv88e6xxx: pretty dump others

2018-12-14 Thread Vivien Didelot
This patch adds basic pretty dump for the remaining mv88e6xxx switches supported by the kernel DSA driver. Signed-off-by: Vivien Didelot --- dsa.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/dsa.c b/dsa.c index bba31f6..e4014e1 100644 --- a/dsa.c +++ b/dsa.c @@ -607,17 +6

[PATCH 0/7] ethtool: add pretty dump for DSA mv88e6xxx drivers

2018-12-14 Thread Vivien Didelot
This patch series adds support to pretty dump the registers of user ports created by the kernel "dsa" subsystem. The first patch adds the base support for "dsa" interfaces. The second patch adds the boilerplate for the "mv88e6xxx" DSA driver, all using 32 registers of 16 bits, the switch ID being

[PATCH 3/7] ethtool: dsa: mv88e6xxx: add pretty dump for 88E6185

2018-12-14 Thread Vivien Didelot
This patch adds support for pretty dump the port registers of the 88E6185 switch. Signed-off-by: Vivien Didelot --- dsa.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/dsa.c b/dsa.c index e747c1f..d447a7f 100644 --- a/dsa.c +++ b

[PATCH 4/7] ethtool: dsa: mv88e6xxx: add pretty dump for 88E6161

2018-12-14 Thread Vivien Didelot
This patch adds support for pretty dump the port registers of the 88E6161 and 88E6123 switches, which both share the same datasheet. Signed-off-by: Vivien Didelot --- dsa.c | 164 ++ 1 file changed, 164 insertions(+) diff --git a/dsa.c b/d

[PATCH 1/7] ethtool: dsa: add pretty dump

2018-12-14 Thread Vivien Didelot
This patch adds the preliminary bits for pretty dumping the registers of the "dsa" kernel drivers. Following patches will add support for the "mv88e6xxx" DSA driver. Signed-off-by: Vivien Didelot --- Makefile.am | 2 +- dsa.c | 12 ethtool.c | 1 + internal.h | 3 +++ 4

[PATCH 2/7] ethtool: dsa: mv88e6xxx: add pretty dump

2018-12-14 Thread Vivien Didelot
The mv88e6xxx DSA driver supports many Marvell devices all using 32 registers of 16 bits. However each devices have a slightly different register definition. This patch adds the boilerplate for providing an optional function per mv88e6xxx switch. Signed-off-by: Vivien Didelot --- dsa.c | 77 +++

[PATCH 6/7] ethtool: dsa: mv88e6xxx: add pretty dump for 88E6390

2018-12-14 Thread Vivien Didelot
This patch adds support for pretty dump the port registers of the 88E6190, 88E6290, 88E6390, 88E6190X and 88E6390X switches, which all share the same datasheet. Signed-off-by: Vivien Didelot --- dsa.c | 182 ++ 1 file changed, 182 insertion

Re: [PATCH] ethtool: zero initialize coalesce struct

2018-12-14 Thread Maciej Żenczykowski
> The dmac member of struct ethtool_coalesce was removed by commit > c0b078ce7e88 ("Revert "ethtool: Add DMA Coalescing support"") because it > has never been added in kernel (as that would break compatibility with > older ethtool versions). Hmm, well, it doesn't hurt to zero init either way...

Re: [PATCH] ethtool: zero initialize coalesce struct

2018-12-14 Thread Michal Kubecek
On Fri, Dec 14, 2018 at 05:19:23PM -0800, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > prior to fetching it from kernel. > > Otherwise we run the risk of very tail portion of it (dmac field) > being left entirely uninitialized, and likely containing some sort > of stale data. The

[PATCH] ethtool: change to new sane powerpc64 kernel headers

2018-12-14 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This fixes: In file included from ethtool-copy.h:22:0, from internal.h:32, from ethtool.c:29: .../include/linux/types.h:32:25: error: conflicting types for '__be64' typedef __u64 __bitwise __be64; ^

[PATCH] ethtool: zero initialize coalesce struct

2018-12-14 Thread Maciej Żenczykowski
From: Maciej Żenczykowski prior to fetching it from kernel. Otherwise we run the risk of very tail portion of it (dmac field) being left entirely uninitialized, and likely containing some sort of stale data. It seems to likely be some sort of time (a second's counter). Tested: 'ethtool -c et

Re: [PATCH bpf-next] bpf: remove useless variable

2018-12-14 Thread Daniel Borkmann
On 12/14/2018 06:03 PM, Martin Lau wrote: > On Thu, Dec 13, 2018 at 10:44:57PM +0100, Andrea Claudi wrote: >> bytes is initialized to end - start at the beginning of this function, >> and is never changed. Remove it making the code a bit more readable. >> >> Suggested-by: Stefano Brivio >> Signed-

Re: [PATCH bpf-next 6/6] bpf: BPF_PROG_TYPE_CGROUP_{SKB,SOCK,SOCK_ADDR} require cgroups enabled

2018-12-14 Thread Alexei Starovoitov
On Thu, Dec 13, 2018 at 11:03 AM Stanislav Fomichev wrote: > > There is no way to exercise appropriate attach points without cgroups > enabled. This lets test_verifier correctly skip tests for these > prog_types if kernel was compiled without BPF cgroup support. > > Signed-off-by: Stanislav Fomich

Re: [PATCH v2 6/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-12-14 Thread Deepa Dinamani
> > diff --git a/arch/alpha/include/uapi/asm/socket.h > > b/arch/alpha/include/uapi/asm/socket.h > > index 00e45c80e574..352e3dc0b3d9 100644 > > --- a/arch/alpha/include/uapi/asm/socket.h > > +++ b/arch/alpha/include/uapi/asm/socket.h > > @@ -3,6 +3,7 @@ > > #define _UAPI_ASM_SOCKET_H > > > > #i

Re: [PATCH V3 3/3] net: dsa: ksz: Add STP multicast handling

2018-12-14 Thread Florian Fainelli
On 12/14/18 4:58 PM, Marek Vasut wrote: > In case the destination address is link local, add override bit into the > switch tag to let such a packet through the switch even if the port is > blocked. > > Signed-off-by: Marek Vasut > Cc: Tristram Ha > Cc: Vivien Didelot > Cc: Woojung Huh > Cc: D

Re: [PATCH V3 1/3] net: dsa: ksz: Rename NET_DSA_TAG_KSZ to _KSZ9477

2018-12-14 Thread Florian Fainelli
On 12/14/18 4:58 PM, Marek Vasut wrote: > From: Tristram Ha > > Rename the tag Kconfig option and related macros in preparation for > addition of new KSZ family switches with different tag formats. > > Signed-off-by: Tristram Ha > Signed-off-by: Marek Vasut > Cc: Vivien Didelot > Cc: Woojung

[PATCH V3 3/3] net: dsa: ksz: Add STP multicast handling

2018-12-14 Thread Marek Vasut
In case the destination address is link local, add override bit into the switch tag to let such a packet through the switch even if the port is blocked. Signed-off-by: Marek Vasut Cc: Tristram Ha Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller Reviewed-by: Andrew Lunn --- V2: New patc

[PATCH V3 0/3] net: dsa: ksz: Clean up the tag code in prep for more switches

2018-12-14 Thread Marek Vasut
Clean up the KSZ DSA tag code in preparation for adding more switches. Marek Vasut (1): net: dsa: ksz: Add STP multicast handling Tristram Ha (2): net: dsa: ksz: Rename NET_DSA_TAG_KSZ to _KSZ9477 net: dsa: ksz: Factor out common tag code drivers/net/dsa/microchip/Kconfig | 2 +- driv

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-14 Thread David Miller
From: Taehee Yoo Date: Wed, 12 Dec 2018 10:19:26 +0900 > When bpfilter error occurred bpfilter_umh will be stopped via __stop_umh(). > The bpfilter_umh() couldn't start again because there is no restart > routine. > > The section of bpfilter_umh_{start/end} is no longer .init.rodata > because th

[PATCH V3 1/3] net: dsa: ksz: Rename NET_DSA_TAG_KSZ to _KSZ9477

2018-12-14 Thread Marek Vasut
From: Tristram Ha Rename the tag Kconfig option and related macros in preparation for addition of new KSZ family switches with different tag formats. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller Reviewed-by: Andrew Lunn --- V2

[PATCH V3 2/3] net: dsa: ksz: Factor out common tag code

2018-12-14 Thread Marek Vasut
From: Tristram Ha Factor out common code from the tag_ksz , so that the code can be used with other KSZ family switches which use differenly sized tags. Signed-off-by: Tristram Ha Signed-off-by: Marek Vasut Cc: Vivien Didelot Cc: Woojung Huh Cc: David S. Miller -- V2: - Rebase on next/maste

Re: [PATCH V2 2/3] net: dsa: ksz: Factor out common tag code

2018-12-14 Thread Marek Vasut
On 12/14/2018 09:11 PM, Andrew Lunn wrote: > On Fri, Dec 14, 2018 at 02:30:35PM +0100, Marek Vasut wrote: >> On 12/14/2018 10:05 AM, Andrew Lunn wrote: +static struct sk_buff *ksz_common_xmit(struct sk_buff *skb, + struct net_device *dev, int len) { >

Re: [PATCH v2 bpf-next 0/4] bpf: improve verifier state analysis

2018-12-14 Thread Daniel Borkmann
On 12/13/2018 08:42 PM, Alexei Starovoitov wrote: > v1->v2: > with optimization suggested by Jakub patch 4 safety check became cheap enough. > > Several improvements to verifier state logic. > Patch 1 - trivial optimization > Patch 3 - significant optimization for stack state equivalence > Patch 4

Re: [PATCH bpf-next v2 0/5] tools: bpftool: clean up code and documentation

2018-12-14 Thread Daniel Borkmann
On 12/14/2018 02:55 PM, Quentin Monnet wrote: > Hi, > This series contains several minor fixes for bpftool source and > documentation. > > The first patches focus on documentation: addition of an option in the page > for "bpftool prog", clean up and update of the same page, and addition of > an ex

Re: [PATCH] net: phy: tja11xx: Add TJA11xx PHY driver

2018-12-14 Thread Marek Vasut
On 12/14/2018 09:19 PM, Andrew Lunn wrote: Oh, nice. Shouldn't this be basic_t1 , which is already supported ? >>> >>> I'm getting the various T mixed up. Yes, basic_t1. >> >> Hmmm, is there a 10/Full variant of the T1 ? > > 10BaseT1 would be 802.3cg. There is also 100BaseT2, 100BaseT4 which

Re: [PATCH bpf-next 6/8] tools: bpftool: add probes for eBPF helper functions

2018-12-14 Thread Daniel Borkmann
On 12/13/2018 01:19 PM, Quentin Monnet wrote: > Similarly to what was done for program types and map types, add a set of > probes to test the availability of the different eBPF helper functions > on the current system. > > Sample output: > > # bpftool feature probe kernel > ... > Scan

Re: [PATCH bpf-next 3/8] tools: bpftool: add probes for kernel configuration options

2018-12-14 Thread Daniel Borkmann
On 12/13/2018 01:19 PM, Quentin Monnet wrote: > Add probes to dump a number of options set (or not set) for compiling > the kernel image. These parameters provide information about what BPF > components should be available on the system. A number of them are not > directly related to eBPF, but are

Re: [PATCH net-next 0/5] net: prefer listeners bound to an address

2018-12-14 Thread David Miller
From: Peter Oskolkov Date: Wed, 12 Dec 2018 13:15:32 -0800 > A relatively common use case is to have several IPs configured > on a host, and have different listeners for each of them. We would > like to add a "catch all" listener on addr_any, to match incoming > connections not served by any of t

Re: [PATCH net-next] add snmp counters document

2018-12-14 Thread David Miller
From: yupeng Date: Wed, 12 Dec 2018 00:14:10 -0800 > Add explainations for some general IP counters, SACK and DSACK related > counters > > Signed-off-by: yupeng Applied, thank you.

Re: [Patch net] tipc: check tsk->group in tipc_wait_for_cond()

2018-12-14 Thread David Miller
From: Cong Wang Date: Tue, 11 Dec 2018 21:43:51 -0800 > tipc_wait_for_cond() drops socket lock before going to sleep, > but tsk->group could be freed right after that release_sock(). > So we have to re-check and reload tsk->group after it wakes up. > > After this patch, tipc_wait_for_cond() retu

Re: [PATCH net-next 0/5] neighbor: More gc_list changes

2018-12-14 Thread David Miller
From: David Ahern Date: Tue, 11 Dec 2018 18:57:20 -0700 > From: David Ahern > > More gc_list changes and cleanups. > > The first 2 patches are bug fixes from the first gc_list change. > Specifically, fix the locking order to be consistent - table lock > followed by neighbor lock, and then entr

Re: [PATCH bpf-next 2/8] tools: bpftool: add probes for /proc/ eBPF parameters

2018-12-14 Thread Daniel Borkmann
On 12/13/2018 01:19 PM, Quentin Monnet wrote: > Add a set of probes to dump the eBPF-related parameters available from > /proc/: availability of bpf() syscall for unprivileged users, > JIT compiler status and hardening status, kallsyms exports status. > > Sample output: > > # bpftool feature

Re: [PATCH] Allow class-e address assignment via ifconfig ioctl

2018-12-14 Thread David Miller
From: Dave Taht Date: Tue, 11 Dec 2018 15:30:34 -0800 > While most distributions long ago switched to the iproute2 suite > of utilities, which allow class-e (240.0.0.0/4) address assignment, > distributions relying on busybox, toybox and other forms of > ifconfig cannot assign class-e addresses w

[RFC PATCH] net/mlx4: Get rid of page operation after dma_alloc_coherent

2018-12-14 Thread Stephen Warren
From: Stephen Warren This is a port of commit 378efe798ecf ("RDMA/hns: Get rid of page operation after dma_alloc_coherent") to the mlx4 driver. That change was described as: > In general, dma_alloc_coherent() returns a CPU virtual address and > a DMA address, and we have no guarantee that the un

[PATCH bpf-next v2 4/8] tools/bpf: sync btf.h header from kernel to tools

2018-12-14 Thread Yonghong Song
Sync include/uapi/linux/btf.h to tools/include/uapi/linux/btf.h. Signed-off-by: Yonghong Song --- tools/include/uapi/linux/btf.h | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/include/uapi/linux/btf.h b/tools/include/uapi/linux/btf.h index 14f66948fc95

[PATCH bpf-next v2 0/8] bpf: btf: fix struct/union/fwd types with kind_flag

2018-12-14 Thread Yonghong Song
Commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)") introduced BTF, a debug info format for BTF. The original design has a couple of issues though. First, the bitfield size is only encoded in int type. If the struct member bitfield type is enum, pahole ([1]) or llvm is forced to repl

Re: [PATCH bpf-next 1/8] tools: bpftool: add basic probe capability, probe syscall and kversion

2018-12-14 Thread Daniel Borkmann
On 12/13/2018 01:19 PM, Quentin Monnet wrote: > Add a new component and command for bpftool, in order to probe the > system to dump a set of eBPF-related parameters so that users can know > what features are available on the system. > > Parameters are dumped in plain or JSON output (with -j/-p opt

[PATCH bpf-next v2 7/8] tools: bpftool: refactor btf_dumper_int_bits()

2018-12-14 Thread Yonghong Song
The core dump funcitonality in btf_dumper_int_bits() is refactored into a separate function btf_dumper_bitfield() which will be used by the next patch. Signed-off-by: Yonghong Song --- tools/bpf/bpftool/btf_dumper.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) d

[PATCH bpf-next v2 6/8] tools/bpf: test kernel bpffs map pretty print with struct kind_flag

2018-12-14 Thread Yonghong Song
The new tests are added to test bpffs map pretty print in kernel with kind_flag for structure type. $ test_btf -p .. BTF pretty print array(#1)..OK BTF pretty print array(#2)..OK PASS:8 SKIP:0 FAIL:0 Signed-off-by: Yonghong Song --- tools/testing/selftests/bpf/test_btf.c |

[PATCH bpf-next v2 3/8] bpf: enable cgroup local storage map pretty print with kind_flag

2018-12-14 Thread Yonghong Song
Commit 970289fc0a83 ("bpf: add bpffs pretty print for cgroup local storage maps") added bpffs pretty print for cgroup local storage maps. The commit worked for struct without kind_flag set. This patch refactored and made pretty print also work with kind_flag set for the struct. Signed-off-by: Yon

Re: [PATCH] ip6mr: Fix potential Spectre v1 vulnerability

2018-12-14 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 11 Dec 2018 14:10:08 -0600 > vr.mifi is indirectly controlled by user-space, hence leading to > a potential exploitation of the Spectre variant 1 vulnerability. > > This issue was detected with the help of Smatch: > > net/ipv6/ip6mr.c:1845 ip6mr_ioctl() wa

[PATCH bpf-next v2 8/8] tools: bpftool: support pretty print with kind_flag set

2018-12-14 Thread Yonghong Song
The following example shows map pretty print with structures which include bitfield members. enum A { A1, A2, A3, A4, A5 }; typedef enum A ___A; struct tmp_t { char a1:4; int a2:4; int :4; __u32 a3:4; int b; ___A b1:4; enum A b2:4; }; st

[PATCH bpf-next v2 5/8] tools/bpf: add test_btf unit tests for kind_flag

2018-12-14 Thread Yonghong Song
This patch added unit tests for different types handling type->info.kind_flag. The following new tests are added: $ test_btf ... BTF raw test[82] (invalid int kind_flag): OK BTF raw test[83] (invalid ptr kind_flag): OK BTF raw test[84] (invalid array kind_flag): OK BTF raw test[85] (inv

[PATCH bpf-next v2 1/8] bpf: btf: refactor btf_int_bits_seq_show()

2018-12-14 Thread Yonghong Song
Refactor function btf_int_bits_seq_show() by creating function btf_bitfield_seq_show() which has no dependence on btf and btf_type. The function btf_bitfield_seq_show() will be in later patch to directly dump bitfield member values. Signed-off-by: Yonghong Song --- kernel/bpf/btf.c | 35

[PATCH bpf-next v2 2/8] bpf: btf: fix struct/union/fwd types with kind_flag

2018-12-14 Thread Yonghong Song
This patch fixed two issues with BTF. One is related to struct/union bitfield encoding and the other is related to forward type. Issue #1 and solution: == Current btf encoding of bitfield follows what pahole generates. For each bitfield, pahole will duplicate the type chain an

Re: [Patch net-next] net_sched: fold tcf_block_cb_call() into tc_setup_cb_call()

2018-12-14 Thread David Miller
From: Cong Wang Date: Tue, 11 Dec 2018 11:15:46 -0800 > After commit 69bd48404f25 ("net/sched: Remove egdev mechanism"), > tc_setup_cb_call() is nearly identical to tcf_block_cb_call(), > so we can just fold tcf_block_cb_call() into tc_setup_cb_call() > and remove its unused parameter 'exts'. >

Re: [PATCH v2 0/8] net: y2038-safe socket timestamps

2018-12-14 Thread David Miller
From: Deepa Dinamani Date: Tue, 11 Dec 2018 12:25:12 -0800 > The series introduces new socket timestamps that are > y2038 safe. Please address Willem's feedback, thank you.

Re: [PATCH] Bluetooth: Fix locking in bt_accept_enqueue() for BH context

2018-12-14 Thread Doug Anderson
Hi, On Mon, Oct 15, 2018 at 3:39 PM Matthias Kaehlcke wrote: > > With commit e16337622016 ("Bluetooth: Handle bt_accept_enqueue() socket > atomically") lock_sock[_nested]() is used to acquire the socket lock > before manipulating the socket. lock_sock[_nested]() may block, which > is problematic

[PATCH net-next] nfp: abm: allow to opt-out of RED offload

2018-12-14 Thread Jakub Kicinski
FW team asks to be able to not support RED even if NIC is capable of buffering for testing and experimentation. Add an opt-out flag. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/abm/ctrl.c | 11 drivers/net/ethernet/netronome/nfp

Re: [PATCH] w90p910_ether: remove incorrect __init annotation

2018-12-14 Thread David Miller
From: Arnd Bergmann Date: Fri, 14 Dec 2018 23:22:10 +0100 > On Fri, Dec 14, 2018 at 10:23 PM David Miller wrote: >> >> From: Arnd Bergmann >> Date: Mon, 10 Dec 2018 21:45:07 +0100 >> >> > The get_mac_address() function is normally inline, but when it is >> > not, we get a warning that this conf

Re: [PATCH v2] VSOCK: bind to random port for VMADDR_PORT_ANY

2018-12-14 Thread David Miller
From: Lepton Wu Date: Tue, 11 Dec 2018 11:12:55 -0800 > The old code always starts from fixed port for VMADDR_PORT_ANY. Sometimes > when VMM crashed, there is still orphaned vsock which is waiting for > close timer, then it could cause connection time out for new started VM > if they are trying t

Re: [PATCH net-next,v6 02/12] net/mlx5e: support for two independent packet edit actions

2018-12-14 Thread Saeed Mahameed
On Fri, Dec 14, 2018 at 10:12 AM Pablo Neira Ayuso wrote: > > This patch adds pedit_headers_action structure to store the result of > parsing tc pedit actions. Then, it calls alloc_tc_pedit_action() to > populate the mlx5e hardware intermediate representation once all actions > have been parsed. >

[PATCH net-next 4/5] tcp: Allow getsockopt of listener's keypool

2018-12-14 Thread Christoph Paasch
Allow to get the full list of the listener's keypool through a getsockopt. Signed-off-by: Christoph Paasch --- net/ipv4/tcp.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 27e2f6837062..cdb317392138 100644 --- a/net/ipv4

[PATCH net-next 2/5] tcp: TFO: search for correct cookie and accept data

2018-12-14 Thread Christoph Paasch
This change allows to search for the right cookie and accepts old ones (announcing a new one if it has changed). __tcp_fastopen_cookie_gen_with_ctx() allows to generate a cookie based on a given TFO-context. A later patch will cleanup the duplicate code. Signed-off-by: Christoph Paasch --- incl

[PATCH net-next 0/5] tcp: Introduce a TFO key-pool for clean cookie-rotation

2018-12-14 Thread Christoph Paasch
Currently, TFO only allows a single TFO-secret. This means that whenever the secret gets changed for key-rotation purposes, all the previously issued TFO-cookies become invalid. This means that clients will fallback to "regular" TCP, incurring a cost of one additional round-trip. This patchset i

[PATCH net-next 3/5] tcp: Print list of TFO-keys from proc

2018-12-14 Thread Christoph Paasch
Print the list of the TFO-keys with a comma separated. For setting the keys, we still only allow a single one to be set. Signed-off-by: Christoph Paasch --- net/ipv4/sysctl_net_ipv4.c | 41 ++--- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/

[PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-14 Thread Christoph Paasch
Instead of having a single TFO-context, we now have a list of tcp_fastopen_context, bounded by TCP_FASTOPEN_CTXT_LEN (set to 2). This enables us to do a rolling TFO-key update that allows the server to accept old cookies and at the same time announce new ones to the client (see follow-up patch).

[PATCH net-next 5/5] tcp: TFO - cleanup code duplication

2018-12-14 Thread Christoph Paasch
We can actually easily reuse __tcp_fastopen_cookie_gen_with_ctx to generate the cookie based on a give TFO-context. This cleans up some of the code. Signed-off-by: Christoph Paasch --- net/ipv4/tcp_fastopen.c | 51 +++-- 1 file changed, 11 insertions(

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-14 Thread David Miller
From: David Ahern Date: Tue, 11 Dec 2018 08:22:04 -0700 > On 12/10/18 10:59 PM, David Miller wrote: >> From: David Ahern >> Date: Mon, 10 Dec 2018 19:47:33 -0700 >> >>> On 12/7/18 4:45 PM, David Miller wrote: Right, neigh->ha[] should probably be kept 8-byte aligned. >>> >>> From

Re: [PATCH] r8152: Add support for MAC address pass through on RTL8153-BND

2018-12-14 Thread David Miller
From: Mario Limonciello Date: Tue, 11 Dec 2018 08:16:14 -0600 > All previous docks and dongles that have supported this feature use > the RTL8153-AD chip. > > RTL8153-BND is a new chip that will be used in upcoming Dell type-C docks. > It should be added to the whitelist of devices to activate M

Re: [PATCH net-next 0/6] net: hns3: Add more commands to Debugfs in HNS3 driver

2018-12-14 Thread David Miller
From: David Miller Date: Fri, 14 Dec 2018 14:30:46 -0800 (PST) > From: Salil Mehta > Date: Tue, 11 Dec 2018 17:13:24 + > >> This patch-set adds few more debugfs commands to HNS3 Ethernet >> Driver. Support has been added to query info related to below >> items: >> 1. Packet buffer descripto

Re: [PATCH net-next 0/6] net: hns3: Add more commands to Debugfs in HNS3 driver

2018-12-14 Thread David Miller
From: Salil Mehta Date: Tue, 11 Dec 2018 17:13:24 + > This patch-set adds few more debugfs commands to HNS3 Ethernet > Driver. Support has been added to query info related to below > items: > 1. Packet buffer descriptor ("echo bd info [queue no] [bd index] > cmd") > 2. Manager table("echo dum

Re: [PATCH] w90p910_ether: remove incorrect __init annotation

2018-12-14 Thread Arnd Bergmann
On Fri, Dec 14, 2018 at 10:23 PM David Miller wrote: > > From: Arnd Bergmann > Date: Mon, 10 Dec 2018 21:45:07 +0100 > > > The get_mac_address() function is normally inline, but when it is > > not, we get a warning that this configuration is broken: > > > > WARNING: vmlinux.o(.text+0x4aff00): Sec

Re: [PATCH bpf-next 0/2] verbose log bpf_line_info in verifier

2018-12-14 Thread Alexei Starovoitov
On Thu, Dec 13, 2018 at 10:41:46AM -0800, Martin KaFai Lau wrote: > This patch set provides bpf_line_info during the verifier's verbose > log. Please see individual patch for details. Looks great! Applied

Re: KASAN: use-after-free Read in ccid_hc_tx_delete

2018-12-14 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:eb6cf9f8cb9d Merge tag 'arm64-fixes' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11a09b6d40 kernel config: https://syzkaller.appspot.com/x/.config?x=c8970c

[net-next 13/13] net/mlx5: Handle LAG FW commands failure gracefully

2018-12-14 Thread Saeed Mahameed
From: Aviv Heller When create_lag or destroy_lag FW commands fail, display an appropriate error message, and try to recover, if possible. Signed-off-by: Aviv Heller Reviewed-by: Roi Dayan Reviewed-by: Yevgeny Kliteynik Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/cor

[net-next 12/13] net/mlx5: Make RoCE and SR-IOV LAG modes explicit

2018-12-14 Thread Saeed Mahameed
From: Aviv Heller With the introduction of SR-IOV LAG, checking whether LAG is active is no longer good enough, since RoCE and SR-IOV LAG each entails different behavior by both the core and infiniband drivers. This patch introduces facilities to discern LAG type, in addition to mlx5_lag_is_acti

[net-next 10/13] net/mlx5: Allow co-enablement of uplink LAG and SRIOV

2018-12-14 Thread Saeed Mahameed
From: Rabie Loulou Enable setting uplink LAG if sriov is enabled on both ports in switchdev mode. Once the sriov mode is changed from switchdev for any of the ports, the LAG instance is disabled. Signed-off-by: Rabie Loulou Signed-off-by: Aviv Heller Signed-off-by: Jianbo Liu Signed-off-by:

[net-next 06/13] net/mlx5e: Offload TC e-switch rules with egress LAG device

2018-12-14 Thread Saeed Mahameed
From: Rabie Loulou When parsing TC FDB actions, if the egress device is a bond/team net-device which enslaved the uplink representor of the e-switch, use the uplink representor as the destination in the HW rule. Signed-off-by: Rabie Loulou Signed-off-by: Aviv Heller Reviewed-by: Roi Dayan Sig

[net-next 08/13] net/mlx5: Adjustments for the activate LAG logic to run under sriov

2018-12-14 Thread Saeed Mahameed
From: Rabie Loulou When HW lag is set/unset, roce must not be enabled on the port, as such we wrap such changes with roce enable/disable either directly or through re-creation of IB device. Currently, lag and sriov are mutually exclusive, so by definition this code doesn't run under sriov. Towa

  1   2   3   4   >