Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

On 2018/12/13 23:49, Stefan Hajnoczi wrote: > On Thu, Dec 13, 2018 at 11:08:04AM +0800, jiangyiwen wrote: >> On 2018/12/12 23:37, Michael S. Tsirkin wrote: >>> On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge bi

Re: [PATCH] vhost: return EINVAL if iovecs size does not match the message size

On 12/13/2018 10:55 PM, Michael S. Tsirkin wrote: > On Thu, Dec 13, 2018 at 05:53:50PM +0300, Pavel Tikhomirov wrote: >> We've failed to copy and process vhost_iotlb_msg so let userspace at >> least know about it. For instance before these patch the code below runs >> without any error: >> >> int m

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

On 2018/12/13 22:50, Michael S. Tsirkin wrote: > On Thu, Dec 13, 2018 at 11:11:48AM +0800, jiangyiwen wrote: >> On 2018/12/13 3:09, David Miller wrote: >>> From: jiangyiwen >>> Date: Wed, 12 Dec 2018 17:29:31 +0800 >>> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

On 2018/12/13 22:48, Michael S. Tsirkin wrote: > On Thu, Dec 13, 2018 at 11:08:04AM +0800, jiangyiwen wrote: >> On 2018/12/12 23:37, Michael S. Tsirkin wrote: >>> On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge

Re: A weird problem of Realtek r8168 after resume from S3

On 14.12.2018 04:33, Chris Chiu wrote: > On Thu, Dec 13, 2018 at 10:20 AM Chris Chiu wrote: >> >> Hi, >> We got an acer laptop which has a problem with ethernet networking after >> resuming from S3. The ethernet is popular realtek r8168. The lspci shows as >> follows. >> 02:00.1 Ethernet contr

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Dear Florian, Thanks for your comments. On Thu, 2018-12-13 at 21:11 -0800, Florian Fainelli wrote: > Le 12/13/18 à 7:01 PM, biao huang a écrit : > > Dear Andrew, > > Thanks for your comments. > > > > On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: > >> Hi Biao > >> > >>> + case

Re: [PATCH net 1/1] qed: Fix command number mismatch between driver and the mfw

From: Sudarsana Reddy Kalluru Date: Sun, 9 Dec 2018 23:27:01 -0800 > The value for OEM_CFG_UPDATE command differs between driver and the > Management firmware (mfw). Fix this gap with adding a reserved field. > > Fixes: cac6f691546b ("qed: Add support for Unified Fabric Port.") > Signed-off-by:

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Le 12/13/18 à 7:01 PM, biao huang a écrit : > Dear Andrew, > Thanks for your comments. > > On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: >> Hi Biao >> >>> + case PHY_INTERFACE_MODE_RGMII: >>> + /* the PHY is not responsible for inserting any internal >>> +* de

Re: DSA: external phy address and port number of switch conflicts

Hello, Le 12/13/18 à 4:12 PM, John Rama a écrit : > Dear DSA experts > > My name is John. > > I'm working for our custom board which has the Marvel 88e5050 ethernet switch > as shown below, and trying to make the system works using DSA subsystem. > > I found one problem and have a question. >

Re: mod_devicetable.h: correct kerneldoc typo, "PHYSID2" -> "MII_PHYSID2"

Le 12/13/18 à 12:00 PM, Robert P. J. Day a écrit : > > Signed-off-by: Robert P. J. Day Reviewed-by: Florian Fainelli > > --- > > diff --git a/include/linux/mod_devicetable.h > b/include/linux/mod_devicetable.h > index 01797cb4587e..a0dcc9b6a723 100644 > --- a/include/linux/mod_devicetable.h

Re: [PATCH net-next v2 RFC 1/8] devlink: Add devlink_param for port register and unregister

On Thu, Dec 13, 2018 at 6:32 PM Jiri Pirko wrote: > > Wed, Dec 12, 2018 at 02:43:14PM CET, vasundhara-v.vo...@broadcom.com wrote: > >On Tue, Dec 11, 2018 at 2:39 PM Jiri Pirko wrote: > >> > >> Tue, Dec 11, 2018 at 09:46:41AM CET, vasundhara-v.vo...@broadcom.com wrote: > >> >Add functions to regis

Re: [PATCH net-next v2 RFC 7/8] devlink: Add a generic port parameter

On Thu, Dec 13, 2018 at 6:33 PM Jiri Pirko wrote: > > Wed, Dec 12, 2018 at 01:30:23PM CET, vasundhara-v.vo...@broadcom.com wrote: > >On Wed, Dec 12, 2018 at 2:45 PM Michal Kubecek wrote: > >> > >> On Tue, Dec 11, 2018 at 02:16:47PM +0530, Vasundhara Volam wrote: > >> > wake-on-lan - Enables Wake

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

On 2018/12/14 上午4:12, Michael S. Tsirkin wrote: On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: Hi: This series tries to access virtqueue metadata through kernel virtual address instead of copy_user() friends since they had too much overheads like checks, spec barriers or even har

Re: [PATCH net-next 1/3] vhost: generalize adding used elem

On 2018/12/14 上午3:41, Michael S. Tsirkin wrote: On Thu, Dec 13, 2018 at 06:10:20PM +0800, Jason Wang wrote: Use one generic vhost_copy_to_user() instead of two dedicated accessor. This will simplify the conversion to fine grain accessors. Signed-off-by: Jason Wang The reason we did it like

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

On 2018/12/13 下午11:44, Michael S. Tsirkin wrote: On Thu, Dec 13, 2018 at 06:10:22PM +0800, Jason Wang wrote: It was noticed that the copy_user() friends that was used to access virtqueue metdata tends to be very expensive for dataplane implementation like vhost since it involves lots of softwa

[PATCH] cw1200: Fix concurrency use-after-free bugs in cw1200_hw_scan()

The function cw1200_bss_info_changed() and cw1200_hw_scan() can be concurrently executed. The two functions both access a possible shared variable "frame.skb". This shared variable is freed by dev_kfree_skb() in cw1200_upload_beacon(), which is called by cw1200_bss_info_changed(). The free operat

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

On 2018/12/13 下午11:27, Michael S. Tsirkin wrote: On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: Hi: This series tries to access virtqueue metadata through kernel virtual address instead of copy_user() friends since they had too much overheads like checks, spec barriers or even ha

Re: A weird problem of Realtek r8168 after resume from S3

On Thu, Dec 13, 2018 at 10:20 AM Chris Chiu wrote: > > Hi, > We got an acer laptop which has a problem with ethernet networking after > resuming from S3. The ethernet is popular realtek r8168. The lspci shows as > follows. > 02:00.1 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. >

Re: [pull request][net 0/9] Mellanox, mlx5 fixes 2018-12-13

From: Saeed Mahameed Date: Thu, 13 Dec 2018 08:45:29 -0800 > This series introduces some fixes to the mlx5 core and mlx5e netdevice > driver. Pulled. > Please pull and let me know if there's any problem. > > For -stable v4.18 > 338d615be484 ('net/mlx5e: Cancel DIM work on close SQ') > 91f40f99

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Dear Andrew, Thanks for your comments. On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: > Hi Biao > > > + case PHY_INTERFACE_MODE_RGMII: > > + /* the PHY is not responsible for inserting any internal > > +* delay by itself in PHY_INTERFACE_MODE_RGMII case, > >

Re: [PATCH bpf-next 2/8] tools: bpftool: add probes for /proc/ eBPF parameters

On 12/13, Quentin Monnet wrote: > Add a set of probes to dump the eBPF-related parameters available from > /proc/: availability of bpf() syscall for unprivileged users, > JIT compiler status and hardening status, kallsyms exports status. > > Sample output: > > # bpftool feature probe kernel >

Re: [PATCH bpf-next 1/8] tools: bpftool: add basic probe capability, probe syscall and kversion

On 12/13, Quentin Monnet wrote: > Add a new component and command for bpftool, in order to probe the > system to dump a set of eBPF-related parameters so that users can know > what features are available on the system. > > Parameters are dumped in plain or JSON output (with -j/-p options). > Addit

Re: [PATCH net V2 4/4] vhost: log dirty page correctly

On 2018/12/13 下午10:31, Michael S. Tsirkin wrote: Just to make sure I understand this. It looks to me we should: - allow passing GIOVA->GPA through UAPI - cache GIOVA->GPA somewhere but still use GIOVA->HVA in device IOTLB for performance Is this what you suggest? Thanks Not really. We alre

Re: [v7, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

Dear Andrew, Thanks for your comments. On Thu, 2018-12-13 at 13:36 +0100, Andrew Lunn wrote: > > +- mediatek,rx-delay-ps: RX clock delay macro value. Default is 0. > > + It should be defined for rgmii/rgmii-txid/mii/rmii interface. > > +Both delay properties need to be a multiple of 170

Re: [PATCH v2 5/5] VSOCK: batch sending rx buffer to increase bandwidth

On 2018/12/13 23:17, Stefan Hajnoczi wrote: > On Wed, Dec 12, 2018 at 05:35:27PM +0800, jiangyiwen wrote: >> Batch sending rx buffer can improve total bandwidth. >> >> Signed-off-by: Yiwen Jiang >> --- > > Please send patches with git-send-email --thread --no-chain-reply-to so > that your patch s

linux-next: manual merge of the net-next tree with the bpf tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: tools/testing/selftests/bpf/test_verifier.c between commit: 7640ead93924 ("bpf: verifier: make sure callees don't prune with caller differences") from the bpf tree and commit: e3da08d05700 ("bpf: allow BPF read ac

DSA: external phy address and port number of switch conflicts

Dear DSA experts My name is John. I'm working for our custom board which has the Marvel 88e5050 ethernet switch as shown below, and trying to make the system works using DSA subsystem. I havea problem and a question. - System - i.MX6 and Marvel 88e5050 Switch(PHY addr is 0x10) - port1-5

DSA: external phy address and port number of switch conflicts

Dear DSA experts My name is John. I'm working for our custom board which has the Marvel 88e5050 ethernet switch as shown below, and trying to make the system works using DSA subsystem. I found one problem and have a question. - System - i.MX6 and Marvel 88e5050 Switch(PHY addr is 0x10)

Re: [PATCH net-next v2 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue

On Tue, Dec 11, 2018 at 2:19 AM Vlad Buslov wrote: > > As a part of the effort to remove dependency on rtnl lock, cls API is being > converted to use fine-grained locking mechanisms instead of global rtnl > lock. However, chain_head_change callback for ingress Qdisc is a sleeping > function and ca

Re: [PATCH] net: sched: simplify the qdisc_leaf code

On Thu, Dec 13, 2018 at 12:43 AM wrote: > > From: Tonghao Zhang > > Except for returning, the var leaf is not > used in the qdisc_leaf(). For simplicity, remove it. > > Signed-off-by: Tonghao Zhang Acked-by: Cong Wang In the future, please explicitly mark it is for net-next. Thanks.

Re: [PATCH bpf-next] selftests/bpf: Fix sk lookup usage in test_sock_addr

On 12/13/2018 10:50 PM, Yonghong Song wrote: > On 12/13/18 1:19 PM, Andrey Ignatov wrote: >> Semantic of netns_id argument of bpf_sk_lookup_tcp and bpf_sk_lookup_udp >> was changed (fixed) in f71c6143c203. Corresponding changes have to be >> applied to all call sites in selftests. The patch fixes c

Re: IP (rtl8169) forwarding bug (performance)

On 13.12.2018 23:10, Risto Pajula wrote: > > On 13.12.2018 6:52, Stephen Hemminger wrote: >> >> Did you disable ethernet flow control?  Ethernet flow control is >> usually a bad idea, it can cause head of line blocking. Unfortunately, >> most devices default to on. > > Disable ethernet flow contr

Re: [PATCH v2 bpf-next 4/4] bpf: add self-check logic to liveness analysis

On Thu, 13 Dec 2018 11:42:34 -0800, Alexei Starovoitov wrote: > Introduce REG_LIVE_DONE to check the liveness propagation > and prepare the states for merging. > See algorithm description in clean_live_states(). > > Signed-off-by: Alexei Starovoitov Acked-by: Jakub Kicinski

Re: IP (rtl8169) forwarding bug (performance)

On 13.12.2018 6:52, Stephen Hemminger wrote: Did you disable ethernet flow control? Ethernet flow control is usually a bad idea, it can cause head of line blocking. Unfortunately, most devices default to on. Disable ethernet flow control from where? The rtl8169 driver does not support chan

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

On Thu, Dec 13, 2018 at 04:18:40PM -0500, Konrad Rzeszutek Wilk wrote: > .giant snip.. > > > + npinned = get_user_pages_fast(uaddr, npages, write, pages); > > > + if (npinned != npages) > > > + goto err; > > > + > > > > As I said I have doubts about the whole approach, but this > > impleme

Re: [PATCH bpf-next] selftests/bpf: Fix sk lookup usage in test_sock_addr

On 12/13/18 1:19 PM, Andrey Ignatov wrote: > Semantic of netns_id argument of bpf_sk_lookup_tcp and bpf_sk_lookup_udp > was changed (fixed) in f71c6143c203. Corresponding changes have to be > applied to all call sites in selftests. The patch fixes corresponding > call sites in test_sock_addr test

Re: [PATCH v3 perf, bpf-next 1/4] perf, bpf: Introduce PERF_RECORD_BPF_EVENT

> On Dec 13, 2018, at 10:45 AM, Peter Zijlstra wrote: > > On Wed, Dec 12, 2018 at 01:33:20PM -0500, Steven Rostedt wrote: >> On Wed, 12 Dec 2018 19:05:53 +0100 >> Peter Zijlstra wrote: >> >>> On Wed, Dec 12, 2018 at 05:09:17PM +, Song Liu wrote: > And while this tracks the bpf kallsy

Re: [PATCH v2 2/4] modules: Add new special vfree flags

On Thu, 2018-12-13 at 19:27 +, Nadav Amit wrote: > > On Dec 13, 2018, at 11:02 AM, Edgecombe, Rick P > > wrote: > > > > On Wed, 2018-12-12 at 23:40 +, Nadav Amit wrote: > > > > On Dec 11, 2018, at 4:03 PM, Rick Edgecombe > > > > wrote: > > > > > > > > Add new flags for handling freeing

[PATCH bpf-next] bpf: remove useless variable

bytes is initialized to end - start at the beginning of this function, and is never changed. Remove it making the code a bit more readable. Suggested-by: Stefano Brivio Signed-off-by: Andrea Claudi --- net/core/filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/n

Re: [PATCH bpf-next] selftests/bpf: Fix sk lookup usage in test_sock_addr

On Thu, 13 Dec 2018 at 13:19, Andrey Ignatov wrote: > > Semantic of netns_id argument of bpf_sk_lookup_tcp and bpf_sk_lookup_udp > was changed (fixed) in f71c6143c203. Corresponding changes have to be > applied to all call sites in selftests. The patch fixes corresponding > call sites in test_sock

[PATCH bpf-next] selftests/bpf: Fix sk lookup usage in test_sock_addr

Semantic of netns_id argument of bpf_sk_lookup_tcp and bpf_sk_lookup_udp was changed (fixed) in f71c6143c203. Corresponding changes have to be applied to all call sites in selftests. The patch fixes corresponding call sites in test_sock_addr test: pass BPF_F_CURRENT_NETNS instead of 0 in netns_id a

Re: [PATCH net-next 3/3] vhost: access vq metadata through kernel virtual address

.giant snip.. > > + npinned = get_user_pages_fast(uaddr, npages, write, pages); > > + if (npinned != npages) > > + goto err; > > + > > As I said I have doubts about the whole approach, but this > implementation in particular isn't a good idea > as it keeps the page around forever. >

Re: [iproute2-next] tc: fix xtables incorrect usage of LDFLAGS

On Wed, 12 Dec 2018 20:04:07 +0800 Syrone Wong wrote: > > So iiuc there's some other LDFLAG coming after -lxtables on some > > platform? sorry about that.. > > Issue found when compiling iproute2 4.17 for OpenWrt > > https://www.mail-archive.com/openwrt-devel@lists.openwrt.org/msg42783.html >

Re: [iproute] rdma broken on 32 bit

On Tue, 11 Dec 2018 17:33:19 + Leon Romanovsky wrote: > On Mon, Dec 10, 2018 at 02:10:20PM -0800, Stephen Hemminger wrote: > > It appears that RDMA is broken on 32 bit platforms. > > Sure you don't run on 32bit, but iproute2 needs to build everywhere. > > > > The issue is that you are assumi

Re: [PATCH bpf-next v2] bpf: support raw tracepoints in modules

On Thu, Dec 13, 2018 at 11:38:51AM -0800, Matt Mullins wrote: > On Thu, 2018-12-13 at 19:22 +, Martin Lau wrote: > > On Wed, Dec 12, 2018 at 04:42:37PM -0800, Matt Mullins wrote: > > > Distributions build drivers as modules, including network and filesystem > > > drivers which export numerous t

Re: Debugging eBPF was: Re: [PATCH bpf-next 0/8] tools: bpftool: add probes for system and device

On Thu, Dec 13, 2018 at 10:49:09AM -0300, Arnaldo Carvalho de Melo wrote: > > Only root can attach eBPF programs to tracepoints. > > Would be really good if we could have a more restricted program type to > attach to tracepoints, one that would be able to run only in the context > of their thread

Re: [PATCH iproute2-next] drop support for DECnet

On 12/11/18 9:40 AM, Stephen Hemminger wrote: > DECnet belongs in the history museum of dead protocols along > with Appletalk and IPX. > > Linux support has outlived its natural life and the time has > come to remove it from iproute2. Dead code is a source > of bugs and exploits. > > If anyone ac

Re: [PATCH bpf-next] bpf: remove obsolete prog->aux sanitation in bpf_insn_prepare_dump

On Wed, Dec 12, 2018 at 10:45:38AM +0100, Daniel Borkmann wrote: > This logic is not needed anymore since we got rid of the verifier > rewrite that was using prog->aux address in f6069b9aa993 ("bpf: > fix redirect to map under tail calls"). > > Signed-off-by: Daniel Borkmann Applied, Thanks

[PATCH] dt-bindings: can: rcar_can: Add r8a774c0 support

Document RZ/G2E (r8a774c0) SoC specific bindings. Signed-off-by: Fabrizio Castro --- Documentation/devicetree/bindings/net/can/rcar_can.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar

[PATCH] dt-bindings: net: ravb: Add support for r8a774c0 SoC

Document RZ/G2E (R8A774C0) SoC bindings. Signed-off-by: Fabrizio Castro --- Documentation/devicetree/bindings/net/renesas,ravb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt

Re: [net-next,v5,00/12] add flow_rule infrastructure

On Thu, Dec 13, 2018 at 08:54:39PM +0100, Pablo Neira Ayuso wrote: > On Thu, Dec 13, 2018 at 11:23:15AM -0800, Jakub Kicinski wrote: > > I think having the drivers call the IR translation could be a good > > compromise instead of having flower always pass down converted flows. > > > > tc flower ->

Re: [PATCH bpf-next 1/3] selftests: bpf: add trivial JSET test

On 12/13/2018 07:52 PM, Jakub Kicinski wrote: > On Thu, 13 Dec 2018 16:17:37 +0100, Daniel Borkmann wrote: >> Could we rather extend the test_verifier infrastructure in order to >> be able to define data input for bpf_prog_test_run()? I think this >> would be very useful for future tests there as w

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: > Hi: > > This series tries to access virtqueue metadata through kernel virtual > address instead of copy_user() friends since they had too much > overheads like checks, spec barriers or even hardware feature > toggling. > > Test shows a

Re: [PATCH] vhost: correct the related warning message

On 12/13/2018 06:21 PM, Michael S. Tsirkin wrote: >>> Fixes: 'commit d588cf8f618d ("target: Fix se_tpg_tfo->tf_subsys regression >>> + remove tf_subsystem")' >>> 'commit cbbd26b8b1a6 ("[iov_iter] new primitives - >>> copy_from_iter_full() and friends")' >> >> Fixes: d588cf8f618d ("target

Re: [PATCH bpf-next 4/4] bpf: add self-check logic to liveness analysis

On 13/12/18 00:00, Alexei Starovoitov wrote: > luckily found it in my email archives. next time could you send a link to > make sure we're talking about the same patch? Sorry, will do. > back then there was no per-register chains and push_stack() > has to do only one live_children++. > With per-re

mod_devicetable.h: correct kerneldoc typo, "PHYSID2" -> "MII_PHYSID2"

Signed-off-by: Robert P. J. Day --- diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h index 01797cb4587e..a0dcc9b6a723 100644 --- a/include/linux/mod_devicetable.h +++ b/include/linux/mod_devicetable.h @@ -565,7 +565,7 @@ struct platform_device_id { /** * struct

Re: [PATCH] vhost: return EINVAL if iovecs size does not match the message size

On Thu, Dec 13, 2018 at 05:53:50PM +0300, Pavel Tikhomirov wrote: > We've failed to copy and process vhost_iotlb_msg so let userspace at > least know about it. For instance before these patch the code below runs > without any error: > > int main() > { > struct vhost_msg msg; > struct iovec iov

Re: [net-next,v5,00/12] add flow_rule infrastructure

On Thu, Dec 13, 2018 at 11:23:15AM -0800, Jakub Kicinski wrote: > On Thu, 13 Dec 2018 12:06:39 +0200, Or Gerlitz wrote: > > > Maybe having a side library that could take a ethtool/flower/nft flow > > > and return common IR representation of that flow would be less painful? > > > Drivers could then

Re: [PATCH] qmi_wwan: Added support for Telit LN940 series

Jörgen Storvist writes: > Added support for the Telit LN940 series cellular modules QMI interface. > QMI_QUIRK_SET_DTR quirk requied for Qualcomm MDM9x40 chipset. > > Signed-off-by: Jörgen Storvist > --- > > usb-devices output > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 21 Spd=480 MxCh= 0 >

[PATCH v2 bpf-next 4/4] bpf: add self-check logic to liveness analysis

Introduce REG_LIVE_DONE to check the liveness propagation and prepare the states for merging. See algorithm description in clean_live_states(). Signed-off-by: Alexei Starovoitov --- include/linux/bpf_verifier.h | 1 + kernel/bpf/verifier.c| 108 ++- 2 fi

[PATCH v2 bpf-next 2/4] selftests/bpf: check insn processed in test_verifier

Teach test_verifier to parse verifier output for insn processed and compare with expected number. Signed-off-by: Alexei Starovoitov Acked-by: Edward Cree Acked-by: Jakub Kicinski --- tools/testing/selftests/bpf/test_verifier.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(

[PATCH v2 bpf-next 0/4] bpf: improve verifier state analysis

v1->v2: with optimization suggested by Jakub patch 4 safety check became cheap enough. Several improvements to verifier state logic. Patch 1 - trivial optimization Patch 3 - significant optimization for stack state equivalence Patch 4 - safety check for liveness and prep for future state merging

[PATCH v2 bpf-next 3/4] bpf: improve stacksafe state comparison

"if (old->allocated_stack > cur->allocated_stack)" check is too conservative. In some cases explored stack could have allocated more space, but that stack space was not live. The test case improves from 19 to 15 processed insns and improvement on real programs is significant as well:

[PATCH v2 bpf-next 1/4] bpf: speed up stacksafe check

Don't check the same stack liveness condition 8 times. once is enough. Signed-off-by: Alexei Starovoitov Acked-by: Edward Cree Acked-by: Jakub Kicinski --- kernel/bpf/verifier.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c

Re: [PATCH net-next 1/3] vhost: generalize adding used elem

On Thu, Dec 13, 2018 at 06:10:20PM +0800, Jason Wang wrote: > Use one generic vhost_copy_to_user() instead of two dedicated > accessor. This will simplify the conversion to fine grain accessors. > > Signed-off-by: Jason Wang The reason we did it like this is because it was faster. Want to try b

Re: [PATCH bpf-next v2] bpf: support raw tracepoints in modules

On Thu, 2018-12-13 at 19:22 +, Martin Lau wrote: > On Wed, Dec 12, 2018 at 04:42:37PM -0800, Matt Mullins wrote: > > Distributions build drivers as modules, including network and filesystem > > drivers which export numerous tracepoints. This enables > > bpf(BPF_RAW_TRACEPOINT_OPEN) to attach t

Re: [PATCH v2 2/4] modules: Add new special vfree flags

> On Dec 13, 2018, at 11:02 AM, Edgecombe, Rick P > wrote: > > On Wed, 2018-12-12 at 23:40 +, Nadav Amit wrote: >>> On Dec 11, 2018, at 4:03 PM, Rick Edgecombe >>> wrote: >>> >>> Add new flags for handling freeing of special permissioned memory in >>> vmalloc, >>> and remove places where t

Re: [PATCH bpf-next v2] bpf: support raw tracepoints in modules

On Wed, Dec 12, 2018 at 04:42:37PM -0800, Matt Mullins wrote: > Distributions build drivers as modules, including network and filesystem > drivers which export numerous tracepoints. This enables > bpf(BPF_RAW_TRACEPOINT_OPEN) to attach to those tracepoints. > > Signed-off-by: Matt Mullins > ---

Re: [net-next,v5,00/12] add flow_rule infrastructure

On Thu, 13 Dec 2018 12:06:39 +0200, Or Gerlitz wrote: > > Maybe having a side library that could take a ethtool/flower/nft flow > > and return common IR representation of that flow would be less painful? > > Drivers could then migrate at its own pace, for new functionality etc. > > Was that discuss

[PATCH bpf-next 4/6] selftests/bpf: skip verifier tests for unsupported map types

Use recently introduced bpf_map_type_supported() to skip tests in the test_verifier if map creation (create_map) fails. It's handled explicitly for each fixup, i.e. if bpf_create_map returns negative fd, we probe the kernel for the appropriate map support and skip the test is map type is not suppor

[PATCH bpf-next 5/6] selftests/bpf: mark verifier test that uses bpf_trace_printk as BPF_PROG_TYPE_TRACEPOINT

We don't have this helper if the kernel was compiled without CONFIG_BPF_EVENTS. Setting prog_type to BPF_PROG_TYPE_TRACEPOINT let's verifier correctly skip this test based on the missing prog_type support in the kernel. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_verif

[PATCH bpf-next 6/6] bpf: BPF_PROG_TYPE_CGROUP_{SKB,SOCK,SOCK_ADDR} require cgroups enabled

There is no way to exercise appropriate attach points without cgroups enabled. This lets test_verifier correctly skip tests for these prog_types if kernel was compiled without BPF cgroup support. Signed-off-by: Stanislav Fomichev --- include/linux/bpf_types.h | 2 ++ net/core/filter.c |

[PATCH bpf-next 1/6] selftests/bpf: add map/prog type probe helpers

Export bpf_map_type_supported() and bpf_prog_type_supported() which return true/false to indicate kernel support for the appropriate program or map type. These helpers will be used in the next commits to selectively skip test_verifier/test_maps tests. bpf_map_type_supported() supports only limited

[PATCH bpf-next 2/6] selftests/bpf: skip sockmap in test_maps if kernel doesn't have support

Use recently introduced bpf_map_type_supported() to skip test_sockmap() if map creation fails. The skipped test is indicated in the output. Example: test_sockmap SKIP (unsupported map type BPF_MAP_TYPE_SOCKMAP) Fork 1024 tasks to 'test_update_delete' ... test_sockmap SKIP (unsupported map type BP

Re: [PATCH v2 2/4] modules: Add new special vfree flags

On Wed, 2018-12-12 at 23:40 +, Nadav Amit wrote: > > On Dec 11, 2018, at 4:03 PM, Rick Edgecombe > > wrote: > > > > Add new flags for handling freeing of special permissioned memory in > > vmalloc, > > and remove places where the handling was done in module.c. > > > > This will enable this f

[PATCH bpf-next 3/6] selftests/bpf: skip verifier tests for unsupported program types

Use recently introduced bpf_prog_type_supported() to skip tests in the test_verifier() if bpf_verify_program() fails. The skipped test is indicated in the output. Example: ... 679/p bpf_get_stack return R0 within range SKIP (unsupported program type 5) 680/p ld_abs: invalid op 1 OK ... Summary: 8

[PATCH bpf-next 0/6] skip verifier/map tests if kernel support is missing

If test_maps/test_verifier is running against the kernel which doesn't have _all_ BPF features enabled, it fails with an error. This patch series tries to probe kernel support for each failed test and skip it instead. This lets users run BPF selftests in the not-all-bpf-yes environments and receive

Re: [oss-drivers] Re: [PATCH bpf] bpf: verifier: make sure callees don't prune with caller differences

On Thu, Dec 13, 2018 at 04:40:06PM +, Edward Cree wrote: > On 13/12/18 10:52, Jiong Wang wrote: > > Because there is inter-procedure register allocation support in LLVM > > (-enable-ipra), which could effectively eliminate register save/restore for > > one caller-saved register across function

Re: [PATCH] net: phy: tja11xx: Add TJA11xx PHY driver

Le 12/12/18 à 6:01 PM, Marek Vasut a écrit : > Add driver for the NXP TJA1100 and TJA1101 PHYs. These PHYs are special > BroadRReach 100BaseT1 PHYs used in automotive. > > Signed-off-by: Marek Vasut > --- [snip] > +#define PHY_ID_MASK 0xfff0 > +#define PHY_ID_TJA1100

Re: [PATCH bpf-next 1/3] selftests: bpf: add trivial JSET test

On Thu, 13 Dec 2018 16:17:37 +0100, Daniel Borkmann wrote: > Could we rather extend the test_verifier infrastructure in order to > be able to define data input for bpf_prog_test_run()? I think this > would be very useful for future tests there as well and avoid having > to duplicate or split functi

Re: [PATCHv3] Fixed PHY: Add fixed_phy_change_carrier()

Le 12/13/18 à 9:47 AM, Joakim Tjernlund a écrit : > Drivers can use this as .ndo_change_carrier() to change carrier > via /sys/class/net/ethX/carrier. > > Signed-off-by: Joakim Tjernlund Other than a few > --- > > v3 - Moved the logic into fixed PHY to minimize eth driver > impact > >

Re: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

Hi Ioanna > > > > > > Well if you don't have to use 64kb pages you can use the page_pool API > > (only > > > used from mlx5 atm) and get the xdp recycling for free. The memory > > 'waste' > > > for > > > 4kb pages isn't too much if the platforms the driver sits on have decent > > > amounts > > > of

Re: [PATCH v3 perf, bpf-next 1/4] perf, bpf: Introduce PERF_RECORD_BPF_EVENT

On Wed, Dec 12, 2018 at 01:33:20PM -0500, Steven Rostedt wrote: > On Wed, 12 Dec 2018 19:05:53 +0100 > Peter Zijlstra wrote: > > > On Wed, Dec 12, 2018 at 05:09:17PM +, Song Liu wrote: > > > > And while this tracks the bpf kallsyms, it does not do all kallsyms. > > > > > > > > Oooh, I s

[PATCH bpf-next 0/2] verbose log bpf_line_info in verifier

This patch set provides bpf_line_info during the verifier's verbose log. Please see individual patch for details. Martin KaFai Lau (2): bpf: Create a new btf_name_by_offset() for non type name use case bpf: verbose log bpf_line_info in verifier include/linux/bpf_verifier.h | 1 + include/l

[PATCH bpf-next 1/2] bpf: Create a new btf_name_by_offset() for non type name use case

The current btf_name_by_offset() is returning "(anon)" type name for the offset == 0 case and "(invalid-name-offset)" for the out-of-bound offset case. It fits well for the internal BTF verbose log purpose which is focusing on type. For example, offset == 0 => "(anon)" => anonymous type/name. Ret

[PATCH bpf-next 2/2] bpf: verbose log bpf_line_info in verifier

This patch adds bpf_line_info during the verifier's verbose. It can give error context for debug purpose. ~~ Here is the verbose log for backedge: while (a) { a += bpf_get_smp_processor_id(); bpf_trace_printk(fmt, sizeof(fmt), a); } ~> bpfto

Re: [PATCH bpf v2] bpf: verifier: make sure callees don't prune with caller differences

On Wed, Dec 12, 2018 at 04:29:07PM -0800, Jakub Kicinski wrote: > Currently for liveness and state pruning the register parentage > chains don't include states of the callee. This makes some sense > as the callee can't access those registers. However, this means > that READs done after the callee

Re: napi driver for multiport device with the only one dma channel - is it possible?

On Thu, 13 Dec 2018 13:30:50 + Jan Petrous wrote: > Hi, > > am I understand it right that I can not use NAPI-powered design in case > when there is only one rx queue and one tx queue (only two > dma channels) usable for data transfer with the ethernet controller for > all interfaces (2 ports

[PATCHv3] Fixed PHY: Add fixed_phy_change_carrier()

Drivers can use this as .ndo_change_carrier() to change carrier via /sys/class/net/ethX/carrier. Signed-off-by: Joakim Tjernlund --- v3 - Moved the logic into fixed PHY to minimize eth driver impact v2 - Only allow carrier changes for Fixed PHYs I will follow up with drivers using thi

RE: [PATCH v2 net-next 0/8] dpaa2-eth: Introduce XDP support

> -Original Message- > From: Ioana Ciocoi Radulescu > Sent: Friday, December 7, 2018 8:08 PM > To: 'Ilias Apalodimas' > Cc: Jesper Dangaard Brouer ; > netdev@vger.kernel.org; da...@davemloft.net; Ioana Ciornei > ; dsah...@gmail.com; Camelia Alexandra Groza > > Subject: RE: [PATCH v2 net-n

Re: hw csum failure + conntrack with more debugging information

On 18.11.2018 02:12, Eric Dumazet wrote: On Sat, Nov 17, 2018 at 3:18 PM Andre Tomt > wrote: I added Cong Wang's hw csum failure debug patch to my 4.19.2 tree and got a splat with a bit more information. > [47273.905616] p0xe0: hw csum failure > [4727

Re: [PATCH bpf-next 1/2] selftests/bpf: skip verifier tests that depend on CONFIG_CGROUP_BPF

On 12/13, Quentin Monnet wrote: > 2018-12-13 08:37 UTC-0800 ~ Stanislav Fomichev > > On 12/13, Quentin Monnet wrote: > >> 2018-12-13 12:52 UTC+0100 ~ Daniel Borkmann > >>> On 12/13/2018 07:06 AM, Alexei Starovoitov wrote: > On Wed, Dec 12, 2018 at 02:32:01PM -0800, Stanislav Fomichev wrote:

Re: [Patch net v2] mlx5: fixup checksum for short ethernet frame padding

On Thu, 2018-12-13 at 09:40 +0100, Nikola Ciprich wrote: > Hi Saeed, > > > for now i feel that you don't want csum complete in your servers > > and we > > already have the tool for that, just do: > > > > ethtool --set-priv-flags rx_no_csum_complete on > > ethtool --show-priv-flags > > Private f

Re: [PATCH bpf-next 1/2] selftests/bpf: skip verifier tests that depend on CONFIG_CGROUP_BPF

2018-12-13 08:37 UTC-0800 ~ Stanislav Fomichev > On 12/13, Quentin Monnet wrote: >> 2018-12-13 12:52 UTC+0100 ~ Daniel Borkmann >>> On 12/13/2018 07:06 AM, Alexei Starovoitov wrote: On Wed, Dec 12, 2018 at 02:32:01PM -0800, Stanislav Fomichev wrote: > > To summarize, I like your idea

Re: [PATCH net-next 02/13] sk_buff: add skb extension infrastructure

On 13/12/18 - 11:39:18, Florian Westphal wrote: > Eric Dumazet wrote: > > > If its going to be used as I expect, then the extension could be > > > discarded after the DSS mapping has been written to the tcp option > > > space, i.e. before cloning occurs. > > > > I do not see how this would work,

Re: [PATCH bpf-next 2/3] bpf: verifier: teach the verifier to reason about the BPF_JSET instruction

On 13/12/18 03:41, Jakub Kicinski wrote: > Some JITs (nfp) try to optimize code on their own. It could make > sense in case of BPF_JSET instruction which is currently not interpreted > by the verifier, meaning for instance that dead could would not be > detected if it was under BPF_JSET branch. >

[net 7/9] net/mlx5e: Avoid encap flows deletion attempt the 1st time a neigh is resolved

From: Or Gerlitz Currently, we are deleting offloaded encap flows in case the relevant neigh becomes unconnected while the encap is valid (a sign that it used to be connected), or if the curr neigh mac is different from the cached mac (a sign that the remote side changed their mac). The 2nd chec

[net 8/9] net/mlx5e: Remove unused UDP GSO remaining counter

From: Mikhael Goikhman Remove tx_udp_seg_rem counter from ethtool output, as it is no longer being updated in the driver's data flow. Fixes: 3f44899ef2ce ("net/mlx5e: Use PARTIAL_GSO for UDP segmentation") Signed-off-by: Mikhael Goikhman Reviewed-by: Eran Ben Elisha Signed-off-by: Saeed Mahame

[net 9/9] net/mlx5e: Cancel DIM work on close SQ

From: Tal Gilboa TXQ SQ closure is followed by closing the corresponding CQ. A pending DIM work would try to modify the now non-existing CQ. This would trigger an error: [85535.835926] mlx5_core :af:00.0: mlx5_cmd_check:769:(pid 124399): MODIFY_CQ(0x403) op_mod(0x0) failed, status bad resourc

[net 2/9] net/mlx5e: Fix default amount of channels for VF representors

From: Gavi Teitz The default amount of channels a representor opens was erroneously changed from one to the maximum amount of channels, restore to its intended value. Fixes: 779d986d60de ("net/mlx5e: Do not ignore netdevice TX/RX queues number") Signed-off-by: Gavi Teitz Reviewed-by: Or Gerlitz

  1   2   3   >