Re: [net-next, RFC, 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-09 Thread Ilias Apalodimas
Hi Willy, > > I'll try to run some tests on my clearfog later, but for now I'm still > 100% busy until haproxy 1.9 gets released. Great. Keep in mind there's multiple hardware this drivers sits on. If your clearfog hardware usues the software buffer manager then you can test. We haven't done any

KASAN: use-after-free Read in ___neigh_create

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:83af01ba1c2d Merge branch 'tc-testing-next' git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=15562a4340 kernel config: https://syzkaller.appspot.com/x/.config?x=28ecefa8a6e10719 dashboard link: htt

KASAN: slab-out-of-bounds Read in neigh_mark_dead

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:83af01ba1c2d Merge branch 'tc-testing-next' git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=119cd8b340 kernel config: https://syzkaller.appspot.com/x/.config?x=28ecefa8a6e10719 dashboard link: htt

KASAN: slab-out-of-bounds Read in ___neigh_create

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:a60956ed72f7 net: dsa: Make dsa_master_set_mtu() static git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=17d2f3f540 kernel config: https://syzkaller.appspot.com/x/.config?x=28ecefa8a6e10719 dashboa

INFO: rcu detected stall in xfrm_hash_rebuild

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:74c4a24df7ca Add linux-next specific files for 20181207 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17dbb3d540 kernel config: https://syzkaller.appspot.com/x/.config?x=6e9413388bf37bed dashb

WARNING in xfrm_policy_inexact_gc_tree

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:74c4a24df7ca Add linux-next specific files for 20181207 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17bbea7d40 kernel config: https://syzkaller.appspot.com/x/.config?x=6e9413388bf37bed dashb

Re: [PATCH bpf-next 6/7] xsk: load a builtin XDP program on XDP_ATTACH

2018-12-09 Thread Björn Töpel
Den mån 10 dec. 2018 kl 03:17 skrev Jakub Kicinski : > > On Fri, 7 Dec 2018 12:44:30 +0100, Björn Töpel wrote: > > From: Björn Töpel > > > > This commit extends the XDP_ATTACH bind option by loading a builtin > > XDP program. > > > > The builtin program is the simplest program possible to redirec

[PATCH net 1/1] qed: Fix command number mismatch between driver and the mfw

2018-12-09 Thread Sudarsana Reddy Kalluru
The value for OEM_CFG_UPDATE command differs between driver and the Management firmware (mfw). Fix this gap with adding a reserved field. Fixes: cac6f691546b ("qed: Add support for Unified Fabric Port.") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/

Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data

2018-12-09 Thread Greg KH
On Sun, Dec 09, 2018 at 09:17:58PM +0100, Mathias Payer wrote: > > The whole kernel is full of situations where an int is returned and if it's > > negative it's an error. Why is this location so different? > > > > Just check < 0 and be done with it. > > OK, whatever you prefer. My fault, I was

[PATCH net-next 1/9] mlxsw: reg: Add Policy Engine Multicast Router Binding Table Register

2018-12-09 Thread Ido Schimmel
From: Nir Dotan In Spectrum-2, multicast routing is implemented explicitly using policy engine (ACL) block. PEMRBT register is used to bind a dedicated ACL group to a specific IP protocol. Add the register to be later used in multicast router implementation. Signed-off-by: Nir Dotan Reviewed-by

[PATCH net-next 9/9] selftests: forwarding: Add multicast routing test

2018-12-09 Thread Ido Schimmel
From: Nir Dotan Introduce basic testing for both IPv4 and IPv6 multicast. The test creates an (S,G) type route, sends traffic and verifies traffic arrives when the route is present and then verifies traffic does not arrive after deleting the route. This test requires smcroute - https://github.com

[PATCH net-next 7/9] mlxsw: spectrum_acl: Limit priority value

2018-12-09 Thread Ido Schimmel
From: Nir Dotan In Spectrum-2, higher priority value wins and priority valid values are in the range of {1,cap_kvd_size-1}. mlxsw_sp_acl_tcam_priority_get converts from lower-bound priorities alike tc flower to Spectrum-2 HW range. Up until now tc flower did not provide priority 0 or reached the

[PATCH net-next 8/9] mlxsw: spectrum_router: Add Multicast routing support for Spectrum-2

2018-12-09 Thread Ido Schimmel
From: Nir Dotan Add implementation of Spectrum-2 multicast routes for both IPv4 and IPv6 by using ACL module explicitly. In Spectrum-2, multicast routes are set as ACL rules, so initialization takes care of creating dedicated ACL groups and binding them to the appropriate multicast routing protoc

[PATCH net-next 5/9] mlxsw: spectrum_acl: Add replace rule action operation

2018-12-09 Thread Ido Schimmel
From: Nir Dotan Multicast routes actions may be updated after creation. An example for that is an addition of an egress interface to an existing route. So far, as tc flower API dictated, ACL rules were either created or deleted. Since multicast routes in Spectrum-2 are written to ACL as any rule,

[PATCH net-next 6/9] mlxsw: spectrum_acl: Support rule creation without action creation

2018-12-09 Thread Ido Schimmel
From: Nir Dotan Up until now, when ACL rule was created its action was created with it. It suits well for tc flower where ACL rule always needs an action, however it does not suit multicast router, where the action is created prior to setting a route, which in Spectrum-2 is actually an ACL rule.

[PATCH net-next 4/9] mlxsw: spectrum_acl: Add multicast router profile operations

2018-12-09 Thread Ido Schimmel
From: Nir Dotan Add specific ACL operations needed for programming multicast routing ACL groups and routes. Signed-off-by: Nir Dotan Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel --- .../net/ethernet/mellanox/mlxsw/spectrum.h| 1 + .../mellanox/mlxsw/spectrum_acl_tcam.c|

[PATCH net-next 0/9] mlxsw: Add Spectrum-2 multicast routing support

2018-12-09 Thread Ido Schimmel
Nir says: In Spectrum the firmware provided an abstraction for multicast routing on top of the policy engine. In Spectrum-2 this is no longer the case and the driver must interact directly with the policy engine in order to program multicast routes. Every route is written as an ACL rule, its prior

[PATCH net-next 2/9] mlxsw: spectrum: Change stage of ACL initialization

2018-12-09 Thread Ido Schimmel
From: Nir Dotan In Spectrum-2, MC routing is implemented using ACL block explicitly, so router initialization should take place after ACL initialization. Set the initialization of the ACL block before IP router initizalization takes place, so multicast router will be able to allocate ACL data str

[PATCH net-next 3/9] mlxsw: spectrum_acl: Add Spectrum-2 keys

2018-12-09 Thread Ido Schimmel
From: Nir Dotan Add virtual router ID fields to Spectrum-2 key blocks set, as the field is required for multicast routing. Signed-off-by: Nir Dotan Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_keys.h| 4 .../net/ethernet/m

BUG: corrupted list in neigh_mark_dead

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:83af01ba1c2d Merge branch 'tc-testing-next' git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14cea3f540 kernel config: https://syzkaller.appspot.com/x/.config?x=28ecefa8a6e10719 dashboard link: htt

BUG: corrupted list in ___neigh_create

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:97ef7b4c5501 ip: silence udp zerocopy smatch false positive git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=13f4592b40 kernel config: https://syzkaller.appspot.com/x/.config?x=28ecefa8a6e10719 das

KASAN: use-after-free Read in neigh_mark_dead

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:a60956ed72f7 net: dsa: Make dsa_master_set_mtu() static git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=14df67eb40 kernel config: https://syzkaller.appspot.com/x/.config?x=28ecefa8a6e10719 dashboa

Re: [PATCH v2 net-next] neighbor: Improve garbage collection

2018-12-09 Thread Eric Dumazet
On 12/09/2018 09:12 PM, Eric Dumazet wrote: > What protects gc_list linkage ? > > We can not use list_del_init(&n->gc_list);or >list_add_tail(&n->gc_list, &n->tbl->gc_list); > > if tbl->lock is not held. > > It seems to me this patch needs more care. >

Re: [PATCH v2 net-next] neighbor: Improve garbage collection

2018-12-09 Thread Eric Dumazet
On 12/07/2018 04:03 PM, David Miller wrote: > From: David Ahern > Date: Fri, 7 Dec 2018 12:24:57 -0800 > >> From: David Ahern >> >> The existing garbage collection algorithm has a number of problems: > ... >> This patch addresses these problems as follows: >> >> 1. Use of a separate list_he

[PATCH net-next] tun: replace get_cpu_ptr with this_cpu_ptr when bh disabled

2018-12-09 Thread Prashant Bhole
tun_xdp_one() runs with local bh disabled. So there is no need to disable preemption by calling get_cpu_ptr while updating stats. This patch replaces the use of get_cpu_ptr() with this_cpu_ptr() as a micro-optimization. Also removes related put_cpu_ptr call. Signed-off-by: Prashant Bhole --- dri

KASAN: use-after-free Read in tipc_group_bc_cong

2018-12-09 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:0844895a2e51 Merge tag 'char-misc-4.20-rc6' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=153c192540 kernel config: https://syzkaller.appspot.com/x/.config?x=8110fb1cd164e8f das

Re: [PATCH] net-udp: deprioritize cpu match for udp socket lookup

2018-12-09 Thread David Miller
From: David Ahern Date: Sun, 9 Dec 2018 20:29:04 -0700 > If this goes in can it target net-next first? Some soak time there > will help show if there are any side effects before propagating to > stable releases. Ok. Maciej please resubmit this specifically targetting net-next. Thank you.

Re: [PATCH] net-udp: deprioritize cpu match for udp socket lookup

2018-12-09 Thread David Ahern
On 12/7/18 11:24 PM, David Miller wrote: > From: Maciej Żenczykowski > Date: Fri, 7 Dec 2018 16:46:36 -0800 > >>> This doesn't apply to the current net tree. >>> >>> Also "net-udp: " is a weird subsystem prefix, just use "udp: ". >>> >>> Thank you. >> >> Interesting... this patch was on top of ne

答复: [PATCH] Fix mm->owner point to a task that does not exists(Internet mail)

2018-12-09 Thread 陈国民
>> From: guominchen >> >> Under normal circumstances,When do_exit exits, mm->owner will >> be updated, but when the kernel process calls unuse_mm and exits, >> mm->owner cannot be updated. And will point to a task that has >> been released. >> >> Below is my issue on vhost_net: >>

[PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-09 Thread Xue Chaojing
There is no need to schedule a different tasklet for refill, This patch remove it. Suggested-by: Neil Horman Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_rx.c | 23 +--- drivers/net/ethernet/huawei/hinic/hinic_rx.h | 2 -- 2 files changed, 5 insertion

[PATCH mlx5-next 03/10] net/mlx5: Add support for plugged-disabled cable status in PME

2018-12-09 Thread Saeed Mahameed
From: Mikhael Goikhman Support a new hardware module status in port module events: - module_status=0x4 (Cable plugged, but disabled) Signed-off-by: Mikhael Goikhman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/events.c | 2 ++ drivers/net/ethernet/mellanox/mlx5/

[PATCH mlx5-next 09/10] IB/mlx5: Simplify netdev unbinding

2018-12-09 Thread Saeed Mahameed
From: Or Gerlitz When dealing with netdev unregister events, we just need to know that this is our currently bounded netdev. There's no need to do any further checks/queries. This patch doesn't change any functionality. Signed-off-by: Or Gerlitz Reviewed-by: Mark Bloch Signed-off-by: Saeed Ma

[PATCH mlx5-next 05/10] net/mlx5: Revise gre and nvgre key formats

2018-12-09 Thread Saeed Mahameed
From: Oz Shlomo GRE RFC defines a 32 bit key field. NVGRE RFC splits the 32 bit key field to 24 bit VSID (gre_key_h) and 8 bit flow entropy (gre_key_l). Define the two key parsing alternatives in a union, thus enabling both access methods. Signed-off-by: Oz Shlomo Reviewed-by: Eli Britstein S

[PATCH mlx5-next 07/10] net/mlx5: E-Switch, Change vhca id valid bool field to bit flag

2018-12-09 Thread Saeed Mahameed
From: Eli Britstein Change the driver flow destination struct to use bit flags with the vhca id valid being the 1st one. Done to avoid bool fields in structs, as warned by static checkers, with no functionality change. Signed-off-by: Eli Britstein Reviewed-by: Or Gerlitz Reviewed-by: Oz Shlomo

[PATCH mlx5-next 10/10] net/mlx5: Remove the get protocol device interface entry

2018-12-09 Thread Saeed Mahameed
From: Or Gerlitz This isn't used anywhere across the mlx5 driver stack, remove it. Signed-off-by: Or Gerlitz Reviewed-by: Saeed Mahameed Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 22 --- .../net/ethernet/mellanox/mlx5/core/en_main.c |

[PATCH mlx5-next 02/10] net/mlx5: Add support for PCIe power slot exceeded error in PME

2018-12-09 Thread Saeed Mahameed
From: Mikhael Goikhman Support a new hardware error type in port module events: - error_type=0xc (PCIe system power slot exceeded) Signed-off-by: Mikhael Goikhman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/events.c | 2 ++ drivers/net/ethernet/mellanox/mlx5/co

[PATCH mlx5-next 08/10] net/mlx5: Support extended destination format in flow steering command

2018-12-09 Thread Saeed Mahameed
From: Eli Britstein Update the flow steering command formatting according to the extended destination API. Note that the FW dictates that multi destination FTEs that involve at least one encap must use the extended destination format, while single destination ones must use the legacy format. Usin

[PATCH mlx5-next 04/10] net/mlx5: Add monitor commands layout and event data

2018-12-09 Thread Saeed Mahameed
From: Eyal Davidovich Will be used in downstream patch to monitor counter changes by the HCA and report it to the driver by an event. The driver will update its counters cached data accordingly. Signed-off-by: Eyal Davidovich Reviewed-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed --- dri

[PATCH mlx5-next 06/10] net/mlx5: Introduce extended destination fields

2018-12-09 Thread Saeed Mahameed
From: Eli Britstein Extended destinations provide the ability to configure different encapsulation properties per destination on a single FTE. This is needed for use-cases such as remote mirroring over tunneled networks. Signed-off-by: Eli Britstein Reviewed-by: Or Gerlitz Reviewed-by: Oz Shlo

[PATCH mlx5-next 00/10] mlx5 core updates and cleanups

2018-12-09 Thread Saeed Mahameed
Hi This patchset is for mlx5-next shared branch, and will be applied there once the review is done. 1) From Eli Britstein, add mlx5 core support for flow steering extended destination 2) From Mikhael Goikhman, port module events cleanup and support for PCIe power slot exceeded errors and plugged-

[PATCH mlx5-next 01/10] net/mlx5: Rework handling of port module events

2018-12-09 Thread Saeed Mahameed
From: Mikhael Goikhman Add explicit HW defined error values. For simplicity, keep counters for all statuses starting from 0, although currently status=0 is not used. Additionally, when HW signals an unexpected cable status, it is reported now rather than ignored. And status counter is now update

Re: [bpf] bpf: powerpc: fix broken uapi for BPF_PROG_TYPE_PERF_EVENT

2018-12-09 Thread Michael Ellerman
On Thu, 2018-12-06 at 09:27:01 UTC, Sandipan Das wrote: > Now that there are different variants of pt_regs for userspace and > kernel, the uapi for the BPF_PROG_TYPE_PERF_EVENT program type must > be changed by exporting the user_pt_regs structure instead of the > pt_regs structure that is in-kerne

Re: [PATCH bpf] bpf: powerpc: fix broken uapi for BPF_PROG_TYPE_PERF_EVENT

2018-12-09 Thread Michael Ellerman
Alexei Starovoitov writes: > On Thu, Dec 06, 2018 at 02:57:01PM +0530, Sandipan Das wrote: >> Now that there are different variants of pt_regs for userspace and >> kernel, the uapi for the BPF_PROG_TYPE_PERF_EVENT program type must >> be changed by exporting the user_pt_regs structure instead of

Re: [PATCH V2 mlx5-next 0/4] mlx5 core CQE API and misc updates

2018-12-09 Thread Saeed Mahameed
On Wed, Dec 5, 2018 at 3:08 PM Saeed Mahameed wrote: > > Hi > > This patchset is for mlx5-next shared branch, and will be applied there > once the review is done. > > Patches 1,2,3 are trivial improvements to CQE API > 1. return CQE pointer instead of void pointer in get_cqe function > 2. helper f

Re: [PATCH bpf-next 6/7] xsk: load a builtin XDP program on XDP_ATTACH

2018-12-09 Thread Jakub Kicinski
On Fri, 7 Dec 2018 12:44:30 +0100, Björn Töpel wrote: > From: Björn Töpel > > This commit extends the XDP_ATTACH bind option by loading a builtin > XDP program. > > The builtin program is the simplest program possible to redirect a > frame to an attached socket. In restricted C it would look li

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread Stephen Rothwell
Hi Dave, On Sun, 09 Dec 2018 16:54:43 -0800 (PST) David Miller wrote: > > From: Stephen Rothwell > Date: Mon, 10 Dec 2018 11:48:48 +1100 > > > That is fine as a last resort, but it is probably less disruptive to > > find these things before you try to push i.e. as part of the "apply the > > pa

linux-next: manual merge of the net-next tree with the net tree

2018-12-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/sched/cls_flower.c between commit: 35cc3cefc4de ("net/sched: cls_flower: Reject duplicated rules also under skip_sw") from the net tree and commit: 5c72299fba9d ("net: sched: cls_flower: Classify packets using

Re: [PATCH] Fix mm->owner point to a task that does not exists

2018-12-09 Thread Michael S. Tsirkin
On Sun, Dec 09, 2018 at 03:21:17PM +0800, gchen.guo...@gmail.com wrote: > From: guominchen > > Under normal circumstances,When do_exit exits, mm->owner will > be updated, but when the kernel process calls unuse_mm and exits, > mm->owner cannot be updated. And will point to a task that has >

linux-next: manual merge of the net-next tree with the net tree

2018-12-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/dsa/master.c between commit: a3d7e01da060 ("net: dsa: Fix tagging attribute location") from the net tree and commits: a60956ed72f7 ("net: dsa: Make dsa_master_set_mtu() static") from the net-next tree. I fixe

Re: [PATCH bpf-next 7/7] bpf: libbpf: bpftool: Print bpf_line_info during prog dump

2018-12-09 Thread Jakub Kicinski
On Fri, 7 Dec 2018 16:42:32 -0800, Martin KaFai Lau wrote: > diff --git a/tools/bpf/bpftool/Documentation/bpftool-prog.rst > b/tools/bpf/bpftool/Documentation/bpftool-prog.rst > index 5524b6dccd85..7c30731a9b73 100644 > --- a/tools/bpf/bpftool/Documentation/bpftool-prog.rst > +++ b/tools/bpf/bpft

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread David Miller
From: Stephen Rothwell Date: Mon, 10 Dec 2018 11:48:48 +1100 > That is fine as a last resort, but it is probably less disruptive to > find these things before you try to push i.e. as part of the "apply the > patch" otherwise you could end up having to rebase a whole lot of later > commits. I mea

Re: [PATCH bpf] selftests/bpf: skip sockmap tests on kernels without support

2018-12-09 Thread David Miller
From: Jakub Kicinski Date: Sun, 9 Dec 2018 16:35:16 -0800 > IMHO its better for person running the test to know they are not > running all the tests than have them silently disappear. Agreed.

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread Stephen Rothwell
Hi Dave, On Sun, 09 Dec 2018 16:31:52 -0800 (PST) David Miller wrote: > > From: Sabrina Dubroca > Date: Mon, 10 Dec 2018 00:27:22 +0100 > > > Maybe Stephen's script to detect those missing sign-offs could be run > > as a commit/apply hook by David? This happens regularly, sometimes > > droppin

Re: [PATCH bpf] selftests/bpf: skip sockmap tests on kernels without support

2018-12-09 Thread Jakub Kicinski
On Thu, 6 Dec 2018 19:39:06 -0800, Stanislav Fomichev wrote: > Include "autoconf.h" header in the test_maps.c and selectively > disable test_sockmap if CONFIG_BPF_STREAM_PARSER is not specified > in the kernel config. > When building out of tree/without autoconf.h, fall back to 'enabled'. > > Sig

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread David Miller
From: Sabrina Dubroca Date: Mon, 10 Dec 2018 00:27:22 +0100 > Maybe Stephen's script to detect those missing sign-offs could be run > as a commit/apply hook by David? This happens regularly, sometimes > dropping more than just a sign-off. Yeah, that would probably be a good idea, maybe something

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread David Miller
From: Heiner Kallweit Date: Sun, 9 Dec 2018 22:33:10 +0100 > On 09.12.2018 22:11, Andrew Lunn wrote: >> On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote: >>> Hi all, >>> >>> Commits >>> >>> dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform >>> data") >>>

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread David Miller
From: Andrew Lunn Date: Sun, 9 Dec 2018 22:11:39 +0100 > On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote: >> Hi all, >> >> Commits >> >> dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform >> data") >> 04fa26bab06d ("net: phy: mdio-gpio: Add platform_dat

Re: [GIT] Networking

2018-12-09 Thread pr-tracker-bot
The pull request you sent on Sun, 09 Dec 2018 12:51:54 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d48f782e4fb20dc7ec935ca0ca41ae31e4a69362 Thank you! -- Deet-doot-dot, I am a bot.

IP (rtl8169) forwarding bug (performance)

2018-12-09 Thread Risto Pajula
Hello. Old subject: "Re: IP fragmentation performance and don't fragment bug when forwarding I have now been tracing the kernel and finding the bug seems difficult. I think the bug is combination of several things, likely cause is that it only occurs with rtl8169 and how it is using the n

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread Sabrina Dubroca
2018-12-09, 22:49:07 +0100, Andrew Lunn wrote: > On Sun, Dec 09, 2018 at 10:33:10PM +0100, Heiner Kallweit wrote: > > On 09.12.2018 22:11, Andrew Lunn wrote: > > > On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote: > > >> Hi all, > > >> > > >> Commits > > >> > > >> dc9d38cec71c ("n

[PATCH] qmi_wwan: Added support for Fibocom NL668 series

2018-12-09 Thread Jörgen Storvist
Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17. Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets. Signed-off-by: Jörgen Storvist drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.

Re: [PATCH net-next] rhashtable: further improve stability of rhashtable_walk

2018-12-09 Thread NeilBrown
On Fri, Dec 07 2018, Herbert Xu wrote: > On Wed, Dec 05, 2018 at 02:51:02PM +1100, NeilBrown wrote: >> >> If the sequence: >>obj = rhashtable_walk_next(iter); >>rhashtable_walk_stop(iter); >>rhashtable_remove_fast(ht, &obj->head, params); >>rhashtable_walk_start(iter); >> >> rac

re: [bpf-next,v3] media: bpf: add bpf function to report mouse movement

2018-12-09 Thread Alexei Starovoitov
somehow this patch didn't get into my inbox, but patchworks got it: https://patchwork.ozlabs.org/patch/1008772/ It looks good to me and I applied it to bpf-next. Thanks

Re: [PATCH bpf] bpf: powerpc: fix broken uapi for BPF_PROG_TYPE_PERF_EVENT

2018-12-09 Thread Alexei Starovoitov
On Thu, Dec 06, 2018 at 02:57:01PM +0530, Sandipan Das wrote: > Now that there are different variants of pt_regs for userspace and > kernel, the uapi for the BPF_PROG_TYPE_PERF_EVENT program type must > be changed by exporting the user_pt_regs structure instead of the > pt_regs structure that is in

Re: [PATCH v2 bpf-next] bpf: relax verifier restriction on BPF_MOV | BPF_ALU

2018-12-09 Thread Alexei Starovoitov
On Fri, Dec 07, 2018 at 12:16:18PM -0500, Jiong Wang wrote: > Currently, the destination register is marked as unknown for 32-bit > sub-register move (BPF_MOV | BPF_ALU) whenever the source register type is > SCALAR_VALUE. > > This is too conservative that some valid cases will be rejected. > Espe

Re: [PATCH bpf-next 0/7] Introduce bpf_line_info

2018-12-09 Thread Alexei Starovoitov
On Fri, Dec 07, 2018 at 04:42:24PM -0800, Martin KaFai Lau wrote: > This patch series introduces the bpf_line_info. Please see individual patch > for details. > > It will be useful for introspection purpose, like: > > [root@arch-fb-vm1 bpf]# ~/devshare/fb-kernel/linux/tools/bpf/bpftool/bpftool

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread Andrew Lunn
On Sun, Dec 09, 2018 at 10:33:10PM +0100, Heiner Kallweit wrote: > On 09.12.2018 22:11, Andrew Lunn wrote: > > On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote: > >> Hi all, > >> > >> Commits > >> > >> dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform > >> da

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread Heiner Kallweit
On 09.12.2018 22:11, Andrew Lunn wrote: > On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote: >> Hi all, >> >> Commits >> >> dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform >> data") >> 04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for >> p

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread Andrew Lunn
On Mon, Dec 10, 2018 at 08:00:45AM +1100, Stephen Rothwell wrote: > Hi all, > > Commits > > dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform > data") > 04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask") > > are missing a Signed-off-by from the

[PATCH net] r8169: fix crash if CONFIG_DEBUG_SHIRQ is enabled

2018-12-09 Thread Heiner Kallweit
If CONFIG_DEBUG_SHIRQ is enabled __free_irq() intentionally fires a spurious interrupt. This interrupt causes a crash because tp->dev->phydev is NULL at that time. Fixes: 38caff5a445b ("r8169: handle all interrupt events in the hard irq handler") Signed-off-by: Heiner Kallweit --- drivers/net/e

linux-next: Signed-off-by missing for commits in the net-next tree

2018-12-09 Thread Stephen Rothwell
Hi all, Commits dc9d38cec71c ("net: phy: mdio-gpio: Add phy_ignore_ta_mask to platform data") 04fa26bab06d ("net: phy: mdio-gpio: Add platform_data support for phy_mask") are missing a Signed-off-by from their author. -- Cheers, Stephen Rothwell pgprX3tKCp63x.pgp Description: OpenPGP dig

Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in

2018-12-09 Thread Mathias Payer
On 12/9/18 9:40 PM, David Miller wrote: > From: Mathias Payer > Date: Sun, 9 Dec 2018 21:17:58 +0100 > >> I've attached the updated patch. (Greg, please add your Signed-off-by). > > Patches should be posted inline, not as attachments as per > process/submitting-patches.rst Sorry! And thanks f

[GIT] Networking

2018-12-09 Thread David Miller
A decent batch of fixes here. I'd say about half are for problems that have existed for a while, and half are for new regressions added in the 4.20 merge window. 1) Fix 10G SFP phy module detection in mvpp2, from Baruch Siach. 2) Revert bogus emac driver change, from Benjamin Herrenschmidt. 3

Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in

2018-12-09 Thread David Miller
From: Mathias Payer Date: Sun, 9 Dec 2018 21:17:58 +0100 > I've attached the updated patch. (Greg, please add your Signed-off-by). Patches should be posted inline, not as attachments as per process/submitting-patches.rst

Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data

2018-12-09 Thread Mathias Payer
> The whole kernel is full of situations where an int is returned and if it's > negative it's an error. Why is this location so different? > > Just check < 0 and be done with it. OK, whatever you prefer. I've attached the updated patch. (Greg, please add your Signed-off-by). Best, Mathias comm

Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data

2018-12-09 Thread Mathias Payer
Hi David, >> +} else { >> port_spec = hso_get_config_data(interface); >> +if (IS_ERR_VALUE((long)port_spec)) >> +goto exit; > > 'port_spec' is an 'int', it makes no sense to cast it 3 times all the > way back to 'int' to figure out if it is a negat

Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data

2018-12-09 Thread Mathias Payer
FYI, this issue has been assigned CVE-2018-19985. Thanks, Mathias On 12/9/18 5:32 PM, Greg KH wrote: > From: Hui Peng > > The function hso_probe reads if_num from the USB device (as an u8) and uses > it without a length check to index an array, resulting in an OOB memory read > in hso_probe or

Re: trigger named just "tx" in drivers/net/wireless/atmel/at76c50x-usb.c

2018-12-09 Thread Pavel Machek
On Mon 2018-12-03 10:45:01, Kalle Valo wrote: > Pavel Machek writes: > > > While grepping something else, I came across LED trigger that is named > > just "tx". > > > > That's a bit too generic afaict? > > > > +++ b/drivers/net/wireless/atmel/at76c50x-usb.c > > @@ -520,7 +520,7 @@ static int at76

Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data,Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data

2018-12-09 Thread David Miller
From: Mathias Payer Date: Sun, 9 Dec 2018 21:02:25 +0100 > Passing an int to the macro results in a compiler warning. One option would be > to test for the individual errors (instead of using the macro) with the > drawback > that future extensions that return different errors may be missed. Anot

Re: [PATCH net] net/sched: cls_flower: Reject duplicated rules also under skip_sw

2018-12-09 Thread David Miller
From: Or Gerlitz Date: Sun, 9 Dec 2018 18:10:24 +0200 > Currently, duplicated rules are rejected only for skip_hw or "none", > hence allowing users to push duplicates into HW for no reason. > > Use the flower tables to protect for that. > > Signed-off-by: Or Gerlitz > Signed-off-by: Paul Blak

Re: [PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data

2018-12-09 Thread David Miller
From: Greg KH Date: Sun, 9 Dec 2018 17:32:45 +0100 > + } else { > port_spec = hso_get_config_data(interface); > + if (IS_ERR_VALUE((long)port_spec)) > + goto exit; 'port_spec' is an 'int', it makes no sense to cast it 3 times all the way back to

Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series

2018-12-09 Thread David Miller
From: Jörgen Storvist Date: Sun, 9 Dec 2018 16:35:48 +0100 > Added support for Fibocom NL668 series exposing QMI WWAN interface in > USB mode: AT+GTUSBMODE=17. > QMI_QUIRK_SET_DTR for Fibocom VID and PID required by Qualcomm MDM9x07 > chipsets. > > Signed-off-by: Jörgen Storvist > > drivers/

Re: [PATCH net 0/4] bnxt_en: Bug fixes.

2018-12-09 Thread David Miller
From: Michael Chan Date: Sun, 9 Dec 2018 07:00:58 -0500 > The first patch fixes a regression on CoS queue setup, introduced > recently by the 57500 new chip support patches. The rest are > fixes related to ring and resource accounting on the new 57500 chips. Series applied.

Re: 4.15.13 kernel panic, ip_rcv_finish, nf_xfrm_me_harder warnings continue to fill dmesg

2018-12-09 Thread Florian Westphal
Martin Zaharinov wrote: > I use latest kernel 4.19.8 and have same problem see down > i use pppoe with 1k+ users if i activate shaper with hfsc and imq machine > crash and reboot > after stop shaper for test mashine only send in dmesg bug error mesg. dst_hold use there sure looks fishy. Can yo

[PATCH] USB: hso: Fix OOB memory access in hso_probe/hso_get_config_data

2018-12-09 Thread Greg KH
From: Hui Peng The function hso_probe reads if_num from the USB device (as an u8) and uses it without a length check to index an array, resulting in an OOB memory read in hso_probe or hso_get_config_data. Added a length check for both locations and updated hso_probe to bail on error. Reported-by

[PATCH net] net/sched: cls_flower: Reject duplicated rules also under skip_sw

2018-12-09 Thread Or Gerlitz
Currently, duplicated rules are rejected only for skip_hw or "none", hence allowing users to push duplicates into HW for no reason. Use the flower tables to protect for that. Signed-off-by: Or Gerlitz Signed-off-by: Paul Blakey Reported-by: Chris Mi --- changes from RFC: - properly handle del

[PATCH] docs/networking: fix formatting of Intel drivers documentation

2018-12-09 Thread Mike Rapoport
The documentation of Intel drivers is missing the heading adornment for document titles. This causes the generated html to have TOC entries from these documents to appear as top level TOC entries: * Linux* Base Driver for Intel(R) Ethernet Network Connection * Contents * Identifying Your Adapter

[PATCH] qmi_wwan: Added support for Fibocom NL668 series

2018-12-09 Thread Jörgen Storvist
Added support for Fibocom NL668 series exposing QMI WWAN interface in USB mode: AT+GTUSBMODE=17. QMI_QUIRK_SET_DTR for Fibocom VID and PID required by Qualcomm MDM9x07 chipsets. Signed-off-by: Jörgen Storvist drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [RFC 3/3] virtio_ring: use new vring flags

2018-12-09 Thread Michael S. Tsirkin
On Sat, Dec 08, 2018 at 09:47:29PM +0800, Tiwei Bie wrote: > On Fri, Dec 07, 2018 at 01:10:48PM -0500, Michael S. Tsirkin wrote: > > On Fri, Dec 07, 2018 at 04:48:42PM +0800, Tiwei Bie wrote: > > > Switch to using the _SPLIT_ and _PACKED_ variants of vring flags > > > in split ring and packed ring

Re: [PATCH] vhost/vsock: fix reset orphans race with close timeout

2018-12-09 Thread Michael S. Tsirkin
On Sat, Dec 08, 2018 at 09:25:44PM -0800, David Miller wrote: > From: Stefan Hajnoczi > Date: Thu, 6 Dec 2018 19:14:34 + > > > If a local process has closed a connected socket and hasn't received a > > RST packet yet, then the socket remains in the table until a timeout > > expires. > > > >

[PATCH net 0/4] bnxt_en: Bug fixes.

2018-12-09 Thread Michael Chan
The first patch fixes a regression on CoS queue setup, introduced recently by the 57500 new chip support patches. The rest are fixes related to ring and resource accounting on the new 57500 chips. Michael Chan (4): bnxt_en: Fix CNP CoS queue regression. bnxt_en: Keep track of reserved IRQs.

[PATCH net 3/4] bnxt_en: Fix NQ/CP rings accounting on the new 57500 chips.

2018-12-09 Thread Michael Chan
The new 57500 chips have introduced the NQ structure in addition to the existing CP rings in all chips. We need to introduce a new bnxt_nq_rings_in_use(). On legacy chips, the 2 functions are the same and one will just call the other. On the new chips, they refer to the 2 separate ring structure

[PATCH net 1/4] bnxt_en: Fix CNP CoS queue regression.

2018-12-09 Thread Michael Chan
Recent changes to support the 57500 devices have created this regression. The bnxt_hwrm_queue_qportcfg() call was moved to be called earlier before the RDMA support was determined, causing the CoS queues configuration to be set before knowing whether RDMA was supported or not. Fix it by moving it

[PATCH net 2/4] bnxt_en: Keep track of reserved IRQs.

2018-12-09 Thread Michael Chan
The new 57500 chips use 1 NQ per MSIX vector, whereas legacy chips use 1 CP ring per MSIX vector. To better unify this, add a resv_irqs field to struct bnxt_hw_resc. On legacy chips, we initialize resv_irqs with resv_cp_rings. On new chips, we initialize it with the allocated MSIX resources. Si

[PATCH net 4/4] bnxt_en: Fix _bnxt_get_max_rings() for 57500 chips.

2018-12-09 Thread Michael Chan
The CP rings are accounted differently on the new 57500 chips. There must be enough CP rings for the sum of RX and TX rings on the new chips. The current logic may be over-estimating the RX and TX rings. The output parameter max_cp should be the maximum NQs capped by MSIX vectors available for n

[PATCH rdma-next 2/2] IB/mlx5: Allocate the per-port Q counter shared when DEVX is supported

2018-12-09 Thread Leon Romanovsky
From: Yishai Hadas The per-port Q counter is some kernel resource and as such may be used by few UID(s) upon DEVX usage. To enable using it for QP/RQ when DEVX context is used need to allocate it with a sharing mode indication to let firmware allows its usage. The UID = 0x was chosen to mar

[PATCH rdma-next 0/2] Allocate the per-port Q counter

2018-12-09 Thread Leon Romanovsky
From: Leon Romanovsky Hi See commit message for the patch description. Thanks Leon Romanovsky (1): net/mlx5: Add shared Q counter bits Yishai Hadas (1): IB/mlx5: Allocate the per-port Q counter shared when DEVX is supported drivers/infiniband/hw/mlx5/cmd.c | 17 + drive

[PATCH mlx5-next 1/2] net/mlx5: Add shared Q counter bits

2018-12-09 Thread Leon Romanovsky
From: Leon Romanovsky Updated HW specification file with needed bits to allow sharing of Q counters between DEVX contexts and kernel. Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/linux/mlx5/mlx

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-09 Thread Pavel Machek
On Thu 2018-12-06 20:00:26, tristram...@microchip.com wrote: > > >>> Update tag_ksz.c to access switch driver's tail tagging operations. > > >> > > >> Hi Tristram > > >> > > >> Humm, i'm not sure we want this, the tagging spit into two places. I > > >> need to take a closer look at the previous pa

4.15.13 kernel panic, ip_rcv_finish, nf_xfrm_me_harder warnings continue to fill dmesg

2018-12-09 Thread Martin Zaharinov
Hi Denys Do you find fix for this bug I use latest kernel 4.19.8 and have same problem see down i use pppoe with 1k+ users if i activate shaper with hfsc and imq machine crash and reboot after stop shaper for test mashine only send in dmesg bug error mesg. This is a Kernel BUG and need to by fi

  1   2   >