Tweaking some things on vger, please just ignore.
On Sat, Dec 1, 2018 at 6:11 AM Alexei Starovoitov
wrote:
>
> On Sat, Dec 01, 2018 at 01:23:04AM +0100, Matteo Croce wrote:
> > Small improvements to improve the readability and easiness
> > to use of the xdp1 sample.
>
> Applied to bpf-next.
>
> I think that sample code could be more useful if it'
netif_napi_add() could report an error like this below due to it allows
to pass a format string for wildcarding before calling
dev_get_valid_name(),
"netif_napi_add() called with weight 256 on device eth%d"
For example, hns_enet_drv module does this.
hns_nic_try_get_ae
hns_nic_init_ring_data
From: Jerin Jacob
Date: Sat, 1 Dec 2018 14:43:54 +0530
> @@ -987,6 +997,76 @@ static void nix_reset_tx_linkcfg(struct rvu *rvu, int
> blkaddr,
> NIX_AF_TL3_TL2X_LINKX_CFG(schq, link), 0x00);
> }
>
> +static int
> +rvu_get_tl1_schqs(struct rvu *rvu,
> +
From: Jerin Jacob
Date: Sat, 1 Dec 2018 14:43:51 +0530
> +#define FLOW_KEY_TYPE_PORT BIT(0)
> +#define FLOW_KEY_TYPE_IPV4 BIT(1)
> +#define FLOW_KEY_TYPE_IPV6 BIT(2)
> +#define FLOW_KEY_TYPE_TCPBIT(3)
> +#define FLOW_KEY_TYPE_UDPBIT(4)
> +#define FLOW_KEY_TYPE_SCTP BIT(5)
This i
The aux->func_info and aux->btf are leaked in the error out cases
during bpf_prog_load(). This patch fixes it.
Fixes: ba64e7d85252 ("bpf: btf: support proper non-jit func info")
Cc: Yonghong Song
Signed-off-by: Martin KaFai Lau
Acked-by: Yonghong Song
---
kernel/bpf/syscall.c | 2 ++
1 file c
Stephen please actually read the reports your forward here.
This is a report about arch/x86/lib/inat.c which is a set of CPU
instruction attributes and has nothing to do with networkig.
When NULL pointer accidentally passed to write_kprobe_events,
due to strlen(NULL), segmentation fault happens.
Changed code returns -1 to deal with this situation.
Bug issued with Smatch, static analysis.
Signed-off-by: Daniel T. Lee
---
samples/bpf/bpf_load.c | 4 +++-
1 file changed, 3 insert
On Fri, Nov 30, 2018 at 7:41 PM Daniel Borkmann wrote:
>
> On 12/01/2018 12:42 AM, Willem de Bruijn wrote:
> > On Fri, Nov 30, 2018 at 5:48 PM Song Liu wrote:
> >>
> >> On Fri, Nov 30, 2018 at 12:09 PM Willem de Bruijn
> >> wrote:
> >>>
> >>> From: Petar Penkov
> >>>
> >>> The pkt_len field in
is_last_ethertype_ip() is used to check IP/IPv6 protocol before
parsing IP/IPv6 headers.
But __vlan_get_protocol() is only bound to skb->len, a malicious
packet could exhaust all skb->len by inserting sufficient ETH_P_8021AD
headers, and it may not even contain an IP/IPv6 header at all, so we
have
On Sat, Dec 01, 2018 at 08:12:34PM +, Roman Gushchin wrote:
>
> From dc70ddb39c2f8d87d64b8d0fd71f4baa956d5f50 Mon Sep 17 00:00:00 2001
> From: Roman Gushchin
> Date: Sat, 1 Dec 2018 10:39:44 -0800
> Subject: [PATCH v2 bpf] bpf: refactor bpf_test_run() to separate own failures
> and test prog
On Sat, Dec 01, 2018 at 11:28:46AM -0800, Alexei Starovoitov wrote:
> On Sat, Dec 01, 2018 at 07:13:50PM +, Roman Gushchin wrote:
> > On Fri, Nov 30, 2018 at 02:58:03PM -0800, Alexei Starovoitov wrote:
> > > On Thu, Nov 29, 2018 at 01:27:03PM +0300, Dan Carpenter wrote:
> > > > Smatch complains
Begin forwarded message:
Date: Sat, 01 Dec 2018 17:20:33 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201829] New: Failed build kernel with nat
https://bugzilla.kernel.org/show_bug.cgi?id=201829
Bug ID: 201829
Summary: Fa
On Sat, Dec 01, 2018 at 07:13:50PM +, Roman Gushchin wrote:
> On Fri, Nov 30, 2018 at 02:58:03PM -0800, Alexei Starovoitov wrote:
> > On Thu, Nov 29, 2018 at 01:27:03PM +0300, Dan Carpenter wrote:
> > > Smatch complains that if bpf_test_run() fails with -ENOMEM at the
> > > begining then the "d
On Fri, Nov 30, 2018 at 02:58:03PM -0800, Alexei Starovoitov wrote:
> On Thu, Nov 29, 2018 at 01:27:03PM +0300, Dan Carpenter wrote:
> > Smatch complains that if bpf_test_run() fails with -ENOMEM at the
> > begining then the "duration" is uninitialized. We then copy the
> > unintialized variables
On Fri, 30 Nov 2018 at 17:36, Alexei Starovoitov
wrote:
>
> On Fri, Nov 30, 2018 at 03:32:20PM -0800, Joe Stringer wrote:
> > David Ahern and Nicolas Dichtel report that the handling of the netns id
> > 0 is incorrect for the BPF socket lookup helpers: rather than finding
> > the netns with id 0,
On Fri, 30 Nov 2018 23:51:53 -0500
Qian Cai wrote:
> + weight,
> + !strchr(dev->name, '%') ? dev->name : "unknown"
Agree with Joe, use netdev_err_once or use netdev_name().
On Sat, 1 Dec 2018 17:00:21 +0100
Jouke Witteveen wrote:
> Make it easy for userspace to respond to acquisition/loss of carrier.
> The uevent is picked up by udev and, on systems with systemd, the
> device unit of the interface announces a configuration reload.
>
> Signed-off-by: Jouke Witteveen
Hi,
On Mon, 26 Nov 2018, Pan Bian wrote:
> In the error handling block, nla_nest_cancel(skb, atd) is called to
> cancel the nest operation. But then, ipset_nest_end(skb, atd) is
> unexpected called to end the nest operation. This patch calls the
> ipset_nest_end only on the branch that nla_nest_c
On Fri, Nov 30, 2018 at 07:39:50PM +, Robin Murphy wrote:
> I was assuming the point was to also add something like
>
> default 131072 if HNS_ENET
>
> so that DMA debug doesn't require too much thought from the user. If they
> still have to notice the overflow message and empirically fig
Hi Pablo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on next-20181130]
[cannot apply to v4.20-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://gith
Signed-off-by: Jouke Witteveen
---
Documentation/networking/operstates.txt | 13 -
net/sched/sch_generic.c | 2 +-
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/Documentation/networking/operstates.txt
b/Documentation/networking/operstates.txt
index 3
Make it easy for userspace to respond to acquisition/loss of carrier.
The uevent is picked up by udev and, on systems with systemd, the
device unit of the interface announces a configuration reload.
Signed-off-by: Jouke Witteveen
---
I did not want to change the commit message into a systemd-howt
On Fri, Nov 30, 2018 at 09:58:36PM -0200, Anderson Luiz Alves wrote:
> Disable hardware level MAC learning because it breaks station roaming.
> When enabled it drops all frames that arrive from a MAC address
> that is on a different port at learning table.
>
> Signed-off-by: Anderson Luiz Alves
On Fri, 2018-11-30 at 23:51 -0500, Qian Cai wrote:
> netif_napi_add() could report an error like this below due to it allows
> to pass a format string for wildcarding before calling
> dev_get_valid_name(),
>
> "netif_napi_add() called with weight 256 on device eth%d"
>
> For example, hns_enet_drv
Hi!
While grepping something else, I came across LED trigger that is named
just "tx".
That's a bit too generic afaict?
+++ b/drivers/net/wireless/atmel/at76c50x-usb.c
@@ -520,7 +520,7 @@ static int at76_usbdfu_download(struct usb_device
*udev, u8 *buf, u32 size,
static int tx_activity;
static
Patch applied, thanks Paul.
On Fri, 30 Nov 2018 23:54:10 +
Saeed Mahameed wrote:
> On Fri, 2018-11-30 at 15:30 -0500, Michael S. Tsirkin wrote:
> > On Fri, Nov 30, 2018 at 08:10:58PM +, Saeed Mahameed wrote:
> > > On Thu, 2018-11-22 at 18:00 +0100, Toke Høiland-Jørgensen wrote:
> > > > David Ahern writes:
> > >
On Fri, 30 Nov 2018 20:41:48 -0800
Jakub Kicinski wrote:
> On Fri, 30 Nov 2018 13:35:53 -0700, David Ahern wrote:
> > On 11/30/18 1:30 PM, Michael S. Tsirkin wrote:
> > I would like to see basic packets, bytes, and dropped counters
> > tracked
> > for Rx and Tx via the standard n
Hi Jakub,
On Thu, Nov 29, 2018 at 12:48:22PM -0800, Jakub Kicinski wrote:
> On Thu, 29 Nov 2018 03:22:24 +0100, Pablo Neira Ayuso wrote:
> > This patch provides the flow_stats structure that acts as container for
> > tc_cls_flower_offload, then we can use to restore the statistics on the
> > exist
From: Vamsi Attunuru
The following set of NPC registers allow the driver to configure NPC
to generate different key value schemes to compare against packet
payload in MCAM search.
NPC_AF_INTF(0..1)_KEX_CFG
NPC_AF_KEX_LDATA(0..1)_FLAGS_CFG
NPC_AF_INTF(0..1)_LID(0..7)_LT(0..15)_LD(0..1)_CFG
NPC_AF
From: Nithin Dabilpuram
NIX_AF_LSO_FORMAT(0..31)_FIELD(0..7) register enables an SW defined
means to define LSO packet modification formats.
0..31 works as an index to choose the algorithm, On success, the mailbox
returns the index to the client of chosen LSO algorithm selection.
This index will
From: Nithin Dabilpuram
Setup TPID's for vlan0 and vlan1 for Tx VLAN insertion offloads.
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Jerin Jacob
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/marvell/
From: Vidhya Raman
Adds mailbox support for L4 checksum verification
and L3 and L4 length verification configuration.
Signed-off-by: Vidhya Raman
Signed-off-by: Jerin Jacob
---
.../net/ethernet/marvell/octeontx2/af/mbox.h | 10 +
.../net/ethernet/marvell/octeontx2/af/rvu.h | 3 ++
...
From: Jerin Jacob
In order to support all NIX specific valid length errors and
checksum errors on Rx, Update all NIX_AF_RX_DEF_* registers.
Also sorted all registers in HRM definition order.
Signed-off-by: Jerin Jacob
---
.../ethernet/marvell/octeontx2/af/rvu_nix.c | 25 +++
From: Krzysztof Kanas
NIX_AF_MARK_FORMAT(0..127)_CTL register enables an SW defined
means to mark/insert various data in the packet based on
final packet color from traffic shaping HW.
0..127 works as an index to choose the algorithm. On success,
the mailbox returns the index to the client.
Add
From: Nithin Dabilpuram
The default behavior was to free all the TLx Tx schedule
queues. This patch adds support for freeing a single Tx
schedule queue if TXSCHQ_FREE_ALL flag is not set.
Signed-off-by: Krzysztof Kanas
Signed-off-by: Nithin Dabilpuram
Signed-off-by: Jerin Jacob
---
.../ether
From: Vamsi Attunuru
This patch adds support for enabling RSS in promiscuous mode
if RSS is already requested by the AF client.
Signed-off-by: Vamsi Attunuru
Signed-off-by: Jerin Jacob
---
.../ethernet/marvell/octeontx2/af/rvu_npc.c | 35 ---
1 file changed, 31 insertions(+)
From: Jerin Jacob
Introduce state-based algorithm to convert the flow_key value
to RSS algo field used by NIX_AF_RX_FLOW_KEY_ALGX_FIELDX register.
The outer `for loop` goes over _all_ protocol field and the following
variables depict the state machine forward progress logic.
a) keyoff_marker -
From: Jerin Jacob
This patch enables the inner IPv4 checksum and
defines the error code for Rx inner and outer checksum errors.
Setting ERRCODE as 1 so that CQE descriptor can be embedded
valid checksum error code and the driver can interpret
checksum error as ERRLEV = LID + 1 and ERRCODE = 1.
S
From: Nithin Dabilpuram
TL1 is the root node in the scheduling hierarchy and
it is a global resource with a limited number.
This patch introduces restriction and validation on
the allocation of the TL1 nodes for the effective resource
sharing across the AF consumers.
- Limit TL1 allocation to 2
From: Jerin Jacob
Introduced reserve_flowkey_alg_idx()to reserve RSS algorithm index,
it would internally use set_flowkey_fields() to generate fields
based on the flow key dynamically.
On AF driver init, it would reserve a predefined set RSS algo indexes,
which will be available all the time for
From: Jerin Jacob
This patchset is a continuation to earlier submitted four patch
series to add a new driver for Marvell's OcteonTX2 SOC's
Resource virtualization unit (RVU) admin function driver.
1. octeontx2-af: Add RVU Admin Function driver
https://www.spinics.net/lists/netdev/msg528272.ht
From: Sunil Goutham
At the time of initial broadcast packet replication table init,
NIXLFs are not yet attached to PF_FUNCs. Hence skipped checking
NIXLF while submitting MCE entry init instruction to NIX admin queue.
Also did a minor cleanup while installing bcast match entry in
packet parser u
From: Jerin Jacob
Added response for nix_rss_flowkey_cfg message to return
selected RSS algorithm index.
The FLOW_KEY_TYPE* definition is part of the mbox message and
it will be used by the other consumers of AF driver hence moving to mbox.h.
Signed-off-by: Jerin Jacob
---
drivers/net/etherne
For micro-mips, srlv inside POOL32A encoding space should use 0x50
sub-opcode, NOT 0x90.
Some early version ISA doc describes the encoding as 0x90 for both srlv and
srav, this looks to me was a typo. I checked Binutils libopcode
implementation which is using 0x50 for srlv and 0x90 for srav.
Fixes
On Fri, Nov 30, 2018 at 10:26:50AM +1100, NeilBrown wrote:
>
> diff --git a/lib/rhashtable.c b/lib/rhashtable.c
> index 30526afa8343..852ffa5160f1 100644
> --- a/lib/rhashtable.c
> +++ b/lib/rhashtable.c
> @@ -1179,8 +1179,7 @@ struct rhash_head __rcu **rht_bucket_nested(const
> struct bucket_tabl
Fri, Nov 30, 2018 at 02:57:02PM CET, eduma...@google.com wrote:
>When a rate estimator is active, "tc -s qd" displays
>something like :
>
>rate 12616bit 11ppsbacklog 0b 0p requeues 2
>
>instead of :
>
>rate 12616bit 11pps backlog 0b 0p requeues 2
>
>Fixes: 4fcec7f3665b ("tc: jsonify stats2")
>Signe
Hi Jon,
On Fri, Nov 30, 2018 at 11:15 PM Jonathan Corbet wrote:
> On Fri, 30 Nov 2018 14:12:19 -0800
> Jarkko Sakkinen wrote:
>
> > As a maintainer myself (and based on somewhat disturbed feedback from
> > other maintainers) I can only make the conclusion that nobody knows what
> > the responsib
49 matches
Mail list logo
