[PATCH RFC bpf-next 1/3] bpf: Add BPF_F_ANY_ALIGNMENT.

2018-11-28 Thread David Miller
Often we want to write tests cases that check things like bad context offset accesses. And one way to do this is to use an odd offset on, for example, a 32-bit load. This unfortunately triggers the alignment checks first on platforms that do not set CONFIG_EFFICIENT_UNALIGNED_ACCESS. So the te

[PATCH RFC bpf-next 0/3] bpf: Improve verifier coverage on sparc64 et al.

2018-11-28 Thread David Miller
On sparc64 a ton of test cases in test_verifier.c fail because the memory accesses in the test case are unaligned (or cannot be proven to be aligned by the verifier). Perhaps we can eventually try to (carefully) modify each one with this problem to not use unaligned accesses but: 1) That is del

[PATCH RFC bpf-next 2/3] bpf: Make use of 'any' alignment in selftests.

2018-11-28 Thread David Miller
Add F_LOAD_WITH_ANY_ALIGNMENT. On architectures which are don't have efficient unaligned accesses, this provides a way to force test cases to ignore alignment issues and instead test the actual problem the testcase is targetting. Only use this initially for programs where the expected result is

[PATCH RFC bpf-next 3/3] bpf: Apply F_LOAD_WITH_ANY_ALIGNMENT to ACCEPT test cases too.

2018-11-28 Thread David Miller
If a testcase has alignment problems but is expected to be ACCEPT, verify it using F_LOAD_WITH_ANY_ALIGNMENT however to not try to execute it. In this way folks on inefficient unaligned access architectures can more fully regression test the verifier. Signed-off-by: David S. Miller --- tools/

Re: [PATCH] amd-xgbe: set skb to NULL after freeing it

2018-11-28 Thread PanBian
On Wed, Nov 28, 2018 at 10:49:31AM -0800, David Miller wrote: > From: Pan Bian > Date: Wed, 28 Nov 2018 16:09:45 +0800 > > If either of these two cases are executed, it means that it must be > the case that: > > !last || context_next > > is FALSE, therefore the conditional in the tail cod

Re: pull-request: can-next 2018-11-28,pull-request: can-next 2018-11-28,Re: pull-request: can-next 2018-11-28,pull-request: can-next 2018-11-28

2018-11-28 Thread David Miller
From: Marc Kleine-Budde Date: Thu, 29 Nov 2018 08:14:36 +0100 > Done, here's the pull request with the git:// URL: Pulled, thanks.

Re: pull-request: can-next 2018-11-28,pull-request: can-next 2018-11-28

2018-11-28 Thread Marc Kleine-Budde
On 11/28/18 8:21 PM, David Miller wrote: > From: Marc Kleine-Budde > Date: Wed, 28 Nov 2018 17:01:13 +0100 > >> >> ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git >> tags/linux-can-next-for-4.21-20181128 > > This doesn't w

[PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_hash_transport

2018-11-28 Thread Xin Long
In sctp_hash_transport, it dereferences a transport's asoc only under rcu_read_lock. Without holding the transport, its asoc could be freed already, which leads to a use-after-free panic. A similar fix as Commit bab1be79a516 ("sctp: hold transport before accessing its asoc in sctp_transport_get_ne

[PATCHv2 net] sctp: hold transport before accessing its asoc in sctp_epaddr_lookup_transport

2018-11-28 Thread Xin Long
Without holding transport to dereference its asoc, a use after free panic can be caused in sctp_epaddr_lookup_transport. Note that a sock lock can't protect these transports that belong to other socks. A similar fix as Commit bab1be79a516 ("sctp: hold transport before accessing its asoc in sctp_tr

[PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

2018-11-28 Thread Xin Long
Now when using stream reconfig to add out streams, stream->out will get re-allocated, and all old streams' information will be copied to the new ones and the old ones will be freed. So without stream->out_curr updated, next time when trying to send from stream->out_curr stream, a panic would be ca

[PATCH bpf] bpf: Fix verifier log string check for bad alignment.

2018-11-28 Thread David Miller
The message got changed a lot time ago. This was responsible for 36 test case failures on sparc64. Fixes: f1174f77b50c ("bpf/verifier: rework value tracking") Signed-off-by: David S. Miller --- tools/testing/selftests/bpf/test_verifier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH AUTOSEL 4.19 10/68] can: ucan: remove set but not used variable 'udev'

2018-11-28 Thread Sasha Levin
From: YueHaibing [ Upstream commit 207681fc5f3d5d398f106d1ae0080fc2373f707a ] Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/can/usb/ucan.c: In function 'ucan_disconnect': drivers/net/can/usb/ucan.c:1578:21: warning: variable 'udev' set but not used [-Wunused-but-set-variable] st

Re: [PATCH 2/2] x86/modules: Make x86 allocs to flush when free

2018-11-28 Thread Edgecombe, Rick P
On Wed, 2018-11-28 at 17:40 -0800, Andy Lutomirski wrote: > > On Nov 27, 2018, at 4:07 PM, Rick Edgecombe < > > rick.p.edgeco...@intel.com> wrote: > > > > Change the module allocations to flush before freeing the pages. > > > > Signed-off-by: Rick Edgecombe > > --- > > arch/x86/kernel/module.c |

[PATCH AUTOSEL 4.19 14/68] batman-adv: Use explicit tvlv padding for ELP packets

2018-11-28 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit f4156f9656feac21f4de712fac94fae964c5d402 ] The announcement messages of batman-adv COMPAT_VERSION 15 have the possibility to announce additional information via a dynamic TVLV part. This part is optional for the ELP packets and currently not parsed by the L

[PATCH AUTOSEL 4.19 11/68] can: rcar_can: Fix erroneous registration

2018-11-28 Thread Sasha Levin
From: Fabrizio Castro [ Upstream commit 68c8d209cd4337da4fa04c672f0b62bb735969bc ] Assigning 2 to "renesas,can-clock-select" tricks the driver into registering the CAN interface, even though we don't want that. This patch improves one of the checks to prevent that from happening. Fixes: 862e2b6

[PATCH AUTOSEL 4.19 15/68] batman-adv: Expand merged fragment buffer for full packet

2018-11-28 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit d7d8bbb40a5b1f682ee6589e212934f4c6b8ad60 ] The complete size ("total_size") of the fragmented packet is stored in the fragment header and in the size of the fragment chain. When the fragments are ready for merge, the skbuff's tail of the first fragment is e

[PATCH AUTOSEL 4.19 18/68] qed: Fix PTT leak in qed_drain()

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit 9aaa4e8ba12972d674caeefbc5f88d83235dd697 ] Release PTT before entering error flow. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2

[PATCH AUTOSEL 4.19 17/68] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

2018-11-28 Thread Sasha Levin
From: Sudarsana Reddy Kalluru [ Upstream commit 77e461d14ed141253573eeeb4d34eccc51e38328 ] Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW uses this channel for DMAE operations (e.g., TIME_SYNC implementation). Driver also uses the same channel 0 for DMAE operations for

[PATCH AUTOSEL 4.19 20/68] qed: Fix rdma_info structure allocation

2018-11-28 Thread Sasha Levin
From: Michal Kalderon [ Upstream commit 291d57f67d2449737d1e370ab5b9a583818eaa0c ] Certain flows need to access the rdma-info structure, for example dcbx update flows. In some cases there can be a race between the allocation or deallocation of the structure which was done in roce start / roce st

[PATCH AUTOSEL 4.19 31/68] net/mlx4: Fix UBSAN warning of signed integer overflow

2018-11-28 Thread Sasha Levin
From: Aya Levin [ Upstream commit a463146e67c848cbab5ce706d6528281b7cded08 ] UBSAN: Undefined behavior in drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:626:29 signed integer overflow: 1802201963 + 1802201963 cannot be represented in type 'int' The union of res_reserved and res_port_rsvd

[PATCH AUTOSEL 4.19 32/68] drivers/net/ethernet/qlogic/qed/qed_rdma.h: fix typo

2018-11-28 Thread Sasha Levin
From: Andrew Morton [ Upstream commit a97b9565338350d70d8d971c4ee6f0d4fa967418 ] Add missing semicolon. Fixes: 291d57f67d244973 ("qed: Fix rdma_info structure allocation") Cc: Michal Kalderon Cc: Denis Bolotin Cc: David S. Miller Signed-off-by: Andrew Morton Signed-off-by: David S. Miller

[PATCH AUTOSEL 4.19 29/68] net/mlx4_core: Zero out lkey field in SW2HW_MPT fw command

2018-11-28 Thread Sasha Levin
From: Jack Morgenstein [ Upstream commit bd85fbc2038a1bbe84990b23ff69b6fc81a32b2c ] When re-registering a user mr, the mpt information for the existing mr when running SRIOV is obtained via the QUERY_MPT fw command. The returned information includes the mpt's lkey. This retrieved mpt informatio

[PATCH AUTOSEL 4.19 30/68] net/mlx4_core: Fix uninitialized variable compilation warning

2018-11-28 Thread Sasha Levin
From: Tariq Toukan [ Upstream commit 3ea7e7ea53c9f6ee41cb69a29c375fe9dd9a56a7 ] Initialize the uid variable to zero to avoid the compilation warning. Fixes: 7a89399ffad7 ("net/mlx4: Add mlx4_bitmap zone allocator") Signed-off-by: Tariq Toukan Signed-off-by: David S. Miller Signed-off-by: Sash

[PATCH AUTOSEL 4.19 21/68] qed: Fix reading wrong value in loop condition

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit ed4eac20dcffdad47709422e0cb925981b056668 ] The value of "sb_index" is written by the hardware. Reading its value and writing it to "index" must finish before checking the loop condition. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-o

[PATCH AUTOSEL 4.19 45/68] net: ena: fix crash during failed resume from hibernation

2018-11-28 Thread Sasha Levin
From: Arthur Kiyanovski [ Upstream commit e76ad21d070f79e566ac46ce0b0584c3c93e1b43 ] During resume from hibernation if ena_restore_device fails, ena_com_dev_reset() is called, and uses the readless read mechanism, which was already destroyed by the call to ena_com_mmio_reg_read_request_destroy()

[PATCH AUTOSEL 4.19 47/68] qed: Fix bitmap_weight() check

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit 276d43f0ae963312c0cd0e2b9a85fd11ac65dfcc ] Fix the condition which verifies that only one flag is set. The API bitmap_weight() should receive size in bits instead of bytes. Fixes: b5a9ee7cf3be ("qed: Revise QM cofiguration") Signed-off-by: Denis Bolotin Si

[PATCH AUTOSEL 4.19 48/68] qed: Fix QM getters to always return a valid pq

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit eb62cca9bee842e5b23bd0ddfb1f271ca95e8759 ] The getter callers doesn't know the valid Physical Queues (PQ) values. This patch makes sure that a valid PQ will always be returned. The patch consists of 3 fixes: - When qed_init_qm_get_idx_from_flags() receive

[PATCH AUTOSEL 4.19 62/68] ibmvnic: Update driver queues after change in ring size support

2018-11-28 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit 5bf032ef08e6a110edc1e3bfb3c66a208fb55125 ] During device reset, queue memory is not being updated to accommodate changes in ring buffer sizes supported by backing hardware. Track any differences in ring buffer sizes following the reset and update queue memor

[PATCH AUTOSEL 4.19 55/68] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts

2018-11-28 Thread Sasha Levin
From: Vincent Chen [ Upstream commit 426a593e641ebf0d9288f0a2fcab644a86820220 ] In the original ftmac100_interrupt(), the interrupts are only disabled when the condition "netif_running(netdev)" is true. However, this condition causes kerenl hang in the following case. When the user requests to d

[PATCH AUTOSEL 4.19 65/68] team: no need to do team_notify_peers or team_mcast_rejoin when disabling port

2018-11-28 Thread Sasha Levin
From: Hangbin Liu [ Upstream commit 5ed9dc99107144f83b6c1bb52a69b58875baf540 ] team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin() will send multicast join group message to notify peers. We should do this when enabling/changed to a new port. But it doesn't make sense to

[PATCH AUTOSEL 4.19 67/68] net: thunderx: set tso_hdrs pointer to NULL in nicvf_free_snd_queue

2018-11-28 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit ef2a7cf1d8831535b8991459567b385661eb4a36 ] Reset snd_queue tso_hdrs pointer to NULL in nicvf_free_snd_queue routine since it is used to check if tso dma descriptor queue has been previously allocated. The issue can be triggered with the following reproduc

[PATCH AUTOSEL 4.19 60/68] net: thunderx: set xdp_prog to NULL if bpf_prog_add fails

2018-11-28 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit 6d0f60b0f8588fd4380ea5df9601e12fddd55ce2 ] Set xdp_prog pointer to NULL if bpf_prog_add fails since that routine reports the error code instead of NULL in case of failure and xdp_prog pointer value is used in the driver to verify if XDP is currently enabl

[PATCH AUTOSEL 4.19 66/68] net: amd: add missing of_node_put()

2018-11-28 Thread Sasha Levin
From: Yangtao Li [ Upstream commit c44c749d3b6fdfca39002e7e48e03fe9f9fe37a3 ] of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it. Signed-off-by: Yangtao Li Signed-off-by: David S. Mi

[PATCH AUTOSEL 4.14 08/35] batman-adv: Use explicit tvlv padding for ELP packets

2018-11-28 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit f4156f9656feac21f4de712fac94fae964c5d402 ] The announcement messages of batman-adv COMPAT_VERSION 15 have the possibility to announce additional information via a dynamic TVLV part. This part is optional for the ELP packets and currently not parsed by the L

[PATCH AUTOSEL 4.14 09/35] batman-adv: Expand merged fragment buffer for full packet

2018-11-28 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit d7d8bbb40a5b1f682ee6589e212934f4c6b8ad60 ] The complete size ("total_size") of the fragmented packet is stored in the fragment header and in the size of the fragment chain. When the fragments are ready for merge, the skbuff's tail of the first fragment is e

[PATCH AUTOSEL 4.14 11/35] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

2018-11-28 Thread Sasha Levin
From: Sudarsana Reddy Kalluru [ Upstream commit 77e461d14ed141253573eeeb4d34eccc51e38328 ] Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW uses this channel for DMAE operations (e.g., TIME_SYNC implementation). Driver also uses the same channel 0 for DMAE operations for

[PATCH AUTOSEL 4.14 05/35] can: rcar_can: Fix erroneous registration

2018-11-28 Thread Sasha Levin
From: Fabrizio Castro [ Upstream commit 68c8d209cd4337da4fa04c672f0b62bb735969bc ] Assigning 2 to "renesas,can-clock-select" tricks the driver into registering the CAN interface, even though we don't want that. This patch improves one of the checks to prevent that from happening. Fixes: 862e2b6

[PATCH v2] net: usb: aqc111: Initialize wol_cfg with memset in aqc111_suspend

2018-11-28 Thread Nathan Chancellor
Clang warns: drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around initialization of subobject [-Wmissing-braces] struct aqc111_wol_cfg wol_cfg = { 0 }; ^ {} 1 warning gen

[PATCH AUTOSEL 4.14 12/35] qed: Fix PTT leak in qed_drain()

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit 9aaa4e8ba12972d674caeefbc5f88d83235dd697 ] Release PTT before entering error flow. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2

[PATCH AUTOSEL 4.14 15/35] net/mlx4_core: Zero out lkey field in SW2HW_MPT fw command

2018-11-28 Thread Sasha Levin
From: Jack Morgenstein [ Upstream commit bd85fbc2038a1bbe84990b23ff69b6fc81a32b2c ] When re-registering a user mr, the mpt information for the existing mr when running SRIOV is obtained via the QUERY_MPT fw command. The returned information includes the mpt's lkey. This retrieved mpt informatio

[PATCH AUTOSEL 4.14 16/35] net/mlx4_core: Fix uninitialized variable compilation warning

2018-11-28 Thread Sasha Levin
From: Tariq Toukan [ Upstream commit 3ea7e7ea53c9f6ee41cb69a29c375fe9dd9a56a7 ] Initialize the uid variable to zero to avoid the compilation warning. Fixes: 7a89399ffad7 ("net/mlx4: Add mlx4_bitmap zone allocator") Signed-off-by: Tariq Toukan Signed-off-by: David S. Miller Signed-off-by: Sash

[PATCH AUTOSEL 4.14 13/35] qed: Fix reading wrong value in loop condition

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit ed4eac20dcffdad47709422e0cb925981b056668 ] The value of "sb_index" is written by the hardware. Reading its value and writing it to "index" must finish before checking the loop condition. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-o

[PATCH AUTOSEL 4.14 17/35] net/mlx4: Fix UBSAN warning of signed integer overflow

2018-11-28 Thread Sasha Levin
From: Aya Levin [ Upstream commit a463146e67c848cbab5ce706d6528281b7cded08 ] UBSAN: Undefined behavior in drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:626:29 signed integer overflow: 1802201963 + 1802201963 cannot be represented in type 'int' The union of res_reserved and res_port_rsvd

[PATCH AUTOSEL 4.14 24/35] qed: Fix QM getters to always return a valid pq

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit eb62cca9bee842e5b23bd0ddfb1f271ca95e8759 ] The getter callers doesn't know the valid Physical Queues (PQ) values. This patch makes sure that a valid PQ will always be returned. The patch consists of 3 fixes: - When qed_init_qm_get_idx_from_flags() receive

[PATCH AUTOSEL 4.14 29/35] net: thunderx: set xdp_prog to NULL if bpf_prog_add fails

2018-11-28 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit 6d0f60b0f8588fd4380ea5df9601e12fddd55ce2 ] Set xdp_prog pointer to NULL if bpf_prog_add fails since that routine reports the error code instead of NULL in case of failure and xdp_prog pointer value is used in the driver to verify if XDP is currently enabl

[PATCH AUTOSEL 4.14 30/35] ibmvnic: Fix RX queue buffer cleanup

2018-11-28 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit b7cdec3d699db2e5985ad39de0f25d3b6111928e ] The wrong index is used when cleaning up RX buffer objects during release of RX queues. Update to use the correct index counter. Signed-off-by: Thomas Falcon Signed-off-by: David S. Miller Signed-off-by: Sasha Le

[PATCH AUTOSEL 4.14 32/35] virtio-net: fail XDP set if guest csum is negotiated

2018-11-28 Thread Sasha Levin
From: Jason Wang [ Upstream commit 18ba58e1c234ea1a2d9835ac8c1735d965ce4640 ] We don't support partial csumed packet since its metadata will be lost or incorrect during XDP processing. So fail the XDP set if guest_csum feature is negotiated. Fixes: f600b6905015 ("virtio_net: Add XDP support") R

[PATCH AUTOSEL 4.14 34/35] net: amd: add missing of_node_put()

2018-11-28 Thread Sasha Levin
From: Yangtao Li [ Upstream commit c44c749d3b6fdfca39002e7e48e03fe9f9fe37a3 ] of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it. Signed-off-by: Yangtao Li Signed-off-by: David S. Mi

[PATCH AUTOSEL 4.14 33/35] team: no need to do team_notify_peers or team_mcast_rejoin when disabling port

2018-11-28 Thread Sasha Levin
From: Hangbin Liu [ Upstream commit 5ed9dc99107144f83b6c1bb52a69b58875baf540 ] team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin() will send multicast join group message to notify peers. We should do this when enabling/changed to a new port. But it doesn't make sense to

[PATCH AUTOSEL 4.9 12/18] net/mlx4_core: Fix uninitialized variable compilation warning

2018-11-28 Thread Sasha Levin
From: Tariq Toukan [ Upstream commit 3ea7e7ea53c9f6ee41cb69a29c375fe9dd9a56a7 ] Initialize the uid variable to zero to avoid the compilation warning. Fixes: 7a89399ffad7 ("net/mlx4: Add mlx4_bitmap zone allocator") Signed-off-by: Tariq Toukan Signed-off-by: David S. Miller Signed-off-by: Sash

[PATCH AUTOSEL 4.9 09/18] qed: Fix PTT leak in qed_drain()

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit 9aaa4e8ba12972d674caeefbc5f88d83235dd697 ] Release PTT before entering error flow. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2

[PATCH AUTOSEL 4.9 08/18] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

2018-11-28 Thread Sasha Levin
From: Sudarsana Reddy Kalluru [ Upstream commit 77e461d14ed141253573eeeb4d34eccc51e38328 ] Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW uses this channel for DMAE operations (e.g., TIME_SYNC implementation). Driver also uses the same channel 0 for DMAE operations for

[PATCH AUTOSEL 4.9 15/18] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts

2018-11-28 Thread Sasha Levin
From: Vincent Chen [ Upstream commit 426a593e641ebf0d9288f0a2fcab644a86820220 ] In the original ftmac100_interrupt(), the interrupts are only disabled when the condition "netif_running(netdev)" is true. However, this condition causes kerenl hang in the following case. When the user requests to d

[PATCH AUTOSEL 4.9 13/18] net/mlx4: Fix UBSAN warning of signed integer overflow

2018-11-28 Thread Sasha Levin
From: Aya Levin [ Upstream commit a463146e67c848cbab5ce706d6528281b7cded08 ] UBSAN: Undefined behavior in drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:626:29 signed integer overflow: 1802201963 + 1802201963 cannot be represented in type 'int' The union of res_reserved and res_port_rsvd

[PATCH AUTOSEL 4.9 05/18] can: rcar_can: Fix erroneous registration

2018-11-28 Thread Sasha Levin
From: Fabrizio Castro [ Upstream commit 68c8d209cd4337da4fa04c672f0b62bb735969bc ] Assigning 2 to "renesas,can-clock-select" tricks the driver into registering the CAN interface, even though we don't want that. This patch improves one of the checks to prevent that from happening. Fixes: 862e2b6

[PATCH AUTOSEL 4.9 18/18] net: amd: add missing of_node_put()

2018-11-28 Thread Sasha Levin
From: Yangtao Li [ Upstream commit c44c749d3b6fdfca39002e7e48e03fe9f9fe37a3 ] of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it. Signed-off-by: Yangtao Li Signed-off-by: David S. Mi

[PATCH AUTOSEL 4.9 07/18] batman-adv: Expand merged fragment buffer for full packet

2018-11-28 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit d7d8bbb40a5b1f682ee6589e212934f4c6b8ad60 ] The complete size ("total_size") of the fragmented packet is stored in the fragment header and in the size of the fragment chain. When the fragments are ready for merge, the skbuff's tail of the first fragment is e

[PATCH AUTOSEL 4.9 10/18] qed: Fix reading wrong value in loop condition

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit ed4eac20dcffdad47709422e0cb925981b056668 ] The value of "sb_index" is written by the hardware. Reading its value and writing it to "index" must finish before checking the loop condition. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-o

[PATCH AUTOSEL 4.4 06/13] qed: Fix PTT leak in qed_drain()

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit 9aaa4e8ba12972d674caeefbc5f88d83235dd697 ] Release PTT before entering error flow. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2

[PATCH AUTOSEL 4.4 09/13] net/mlx4_core: Fix uninitialized variable compilation warning

2018-11-28 Thread Sasha Levin
From: Tariq Toukan [ Upstream commit 3ea7e7ea53c9f6ee41cb69a29c375fe9dd9a56a7 ] Initialize the uid variable to zero to avoid the compilation warning. Fixes: 7a89399ffad7 ("net/mlx4: Add mlx4_bitmap zone allocator") Signed-off-by: Tariq Toukan Signed-off-by: David S. Miller Signed-off-by: Sash

[PATCH AUTOSEL 4.4 07/13] qed: Fix reading wrong value in loop condition

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit ed4eac20dcffdad47709422e0cb925981b056668 ] The value of "sb_index" is written by the hardware. Reading its value and writing it to "index" must finish before checking the loop condition. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-o

[PATCH AUTOSEL 4.4 11/13] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts

2018-11-28 Thread Sasha Levin
From: Vincent Chen [ Upstream commit 426a593e641ebf0d9288f0a2fcab644a86820220 ] In the original ftmac100_interrupt(), the interrupts are only disabled when the condition "netif_running(netdev)" is true. However, this condition causes kerenl hang in the following case. When the user requests to d

[PATCH AUTOSEL 4.4 08/13] net/mlx4_core: Zero out lkey field in SW2HW_MPT fw command

2018-11-28 Thread Sasha Levin
From: Jack Morgenstein [ Upstream commit bd85fbc2038a1bbe84990b23ff69b6fc81a32b2c ] When re-registering a user mr, the mpt information for the existing mr when running SRIOV is obtained via the QUERY_MPT fw command. The returned information includes the mpt's lkey. This retrieved mpt informatio

[PATCH AUTOSEL 3.18 3/6] net/mlx4_core: Zero out lkey field in SW2HW_MPT fw command

2018-11-28 Thread Sasha Levin
From: Jack Morgenstein [ Upstream commit bd85fbc2038a1bbe84990b23ff69b6fc81a32b2c ] When re-registering a user mr, the mpt information for the existing mr when running SRIOV is obtained via the QUERY_MPT fw command. The returned information includes the mpt's lkey. This retrieved mpt informatio

[PATCH AUTOSEL 3.18 6/6] net: amd: add missing of_node_put()

2018-11-28 Thread Sasha Levin
From: Yangtao Li [ Upstream commit c44c749d3b6fdfca39002e7e48e03fe9f9fe37a3 ] of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it. Signed-off-by: Yangtao Li Signed-off-by: David S. Mi

[PATCH AUTOSEL 3.18 2/6] can: rcar_can: Fix erroneous registration

2018-11-28 Thread Sasha Levin
From: Fabrizio Castro [ Upstream commit 68c8d209cd4337da4fa04c672f0b62bb735969bc ] Assigning 2 to "renesas,can-clock-select" tricks the driver into registering the CAN interface, even though we don't want that. This patch improves one of the checks to prevent that from happening. Fixes: 862e2b6

[PATCH AUTOSEL 3.18 4/6] net/mlx4: Fix UBSAN warning of signed integer overflow

2018-11-28 Thread Sasha Levin
From: Aya Levin [ Upstream commit a463146e67c848cbab5ce706d6528281b7cded08 ] UBSAN: Undefined behavior in drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:626:29 signed integer overflow: 1802201963 + 1802201963 cannot be represented in type 'int' The union of res_reserved and res_port_rsvd

[PATCH AUTOSEL 3.18 5/6] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts

2018-11-28 Thread Sasha Levin
From: Vincent Chen [ Upstream commit 426a593e641ebf0d9288f0a2fcab644a86820220 ] In the original ftmac100_interrupt(), the interrupts are only disabled when the condition "netif_running(netdev)" is true. However, this condition causes kerenl hang in the following case. When the user requests to d

[PATCH AUTOSEL 4.4 13/13] net: amd: add missing of_node_put()

2018-11-28 Thread Sasha Levin
From: Yangtao Li [ Upstream commit c44c749d3b6fdfca39002e7e48e03fe9f9fe37a3 ] of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. This place doesn't do that, so fix it. Signed-off-by: Yangtao Li Signed-off-by: David S. Mi

[PATCH AUTOSEL 4.4 03/13] can: rcar_can: Fix erroneous registration

2018-11-28 Thread Sasha Levin
From: Fabrizio Castro [ Upstream commit 68c8d209cd4337da4fa04c672f0b62bb735969bc ] Assigning 2 to "renesas,can-clock-select" tricks the driver into registering the CAN interface, even though we don't want that. This patch improves one of the checks to prevent that from happening. Fixes: 862e2b6

[PATCH AUTOSEL 4.4 05/13] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

2018-11-28 Thread Sasha Levin
From: Sudarsana Reddy Kalluru [ Upstream commit 77e461d14ed141253573eeeb4d34eccc51e38328 ] Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW uses this channel for DMAE operations (e.g., TIME_SYNC implementation). Driver also uses the same channel 0 for DMAE operations for

[PATCH AUTOSEL 4.4 04/13] batman-adv: Expand merged fragment buffer for full packet

2018-11-28 Thread Sasha Levin
From: Sven Eckelmann [ Upstream commit d7d8bbb40a5b1f682ee6589e212934f4c6b8ad60 ] The complete size ("total_size") of the fragmented packet is stored in the fragment header and in the size of the fragment chain. When the fragments are ready for merge, the skbuff's tail of the first fragment is e

[PATCH AUTOSEL 4.4 10/13] net/mlx4: Fix UBSAN warning of signed integer overflow

2018-11-28 Thread Sasha Levin
From: Aya Levin [ Upstream commit a463146e67c848cbab5ce706d6528281b7cded08 ] UBSAN: Undefined behavior in drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:626:29 signed integer overflow: 1802201963 + 1802201963 cannot be represented in type 'int' The union of res_reserved and res_port_rsvd

[PATCH AUTOSEL 4.9 11/18] net/mlx4_core: Zero out lkey field in SW2HW_MPT fw command

2018-11-28 Thread Sasha Levin
From: Jack Morgenstein [ Upstream commit bd85fbc2038a1bbe84990b23ff69b6fc81a32b2c ] When re-registering a user mr, the mpt information for the existing mr when running SRIOV is obtained via the QUERY_MPT fw command. The returned information includes the mpt's lkey. This retrieved mpt informatio

[PATCH AUTOSEL 4.9 17/18] team: no need to do team_notify_peers or team_mcast_rejoin when disabling port

2018-11-28 Thread Sasha Levin
From: Hangbin Liu [ Upstream commit 5ed9dc99107144f83b6c1bb52a69b58875baf540 ] team_notify_peers() will send ARP and NA to notify peers. team_mcast_rejoin() will send multicast join group message to notify peers. We should do this when enabling/changed to a new port. But it doesn't make sense to

[PATCH AUTOSEL 4.14 35/35] net: thunderx: set tso_hdrs pointer to NULL in nicvf_free_snd_queue

2018-11-28 Thread Sasha Levin
From: Lorenzo Bianconi [ Upstream commit ef2a7cf1d8831535b8991459567b385661eb4a36 ] Reset snd_queue tso_hdrs pointer to NULL in nicvf_free_snd_queue routine since it is used to check if tso dma descriptor queue has been previously allocated. The issue can be triggered with the following reproduc

[PATCH AUTOSEL 4.9 03/18] brcmutil: really fix decoding channel info for 160 MHz bandwidth

2018-11-28 Thread Sasha Levin
From: Rafał Miłecki [ Upstream commit 3401d42c7ea2d064d15c66698ff8eb96553179ce ] Previous commit /adding/ support for 160 MHz chanspecs was incomplete. It didn't set bandwidth info and didn't extract control channel info. As the result it was also using uninitialized "sb" var. This change has b

[PATCH AUTOSEL 4.14 31/35] virtio-net: disable guest csum during XDP set

2018-11-28 Thread Sasha Levin
From: Jason Wang [ Upstream commit e59ff2c49ae16e1d179de679aca81405829aee6c ] We don't disable VIRTIO_NET_F_GUEST_CSUM if XDP was set. This means we can receive partial csumed packets with metadata kept in the vnet_hdr. This may have several side effects: - It could be overridden by header adju

[PATCH AUTOSEL 4.14 26/35] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts

2018-11-28 Thread Sasha Levin
From: Vincent Chen [ Upstream commit 426a593e641ebf0d9288f0a2fcab644a86820220 ] In the original ftmac100_interrupt(), the interrupts are only disabled when the condition "netif_running(netdev)" is true. However, this condition causes kerenl hang in the following case. When the user requests to d

[PATCH AUTOSEL 4.14 23/35] qed: Fix bitmap_weight() check

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit 276d43f0ae963312c0cd0e2b9a85fd11ac65dfcc ] Fix the condition which verifies that only one flag is set. The API bitmap_weight() should receive size in bits instead of bytes. Fixes: b5a9ee7cf3be ("qed: Revise QM cofiguration") Signed-off-by: Denis Bolotin Si

[PATCH AUTOSEL 4.14 03/35] brcmutil: really fix decoding channel info for 160 MHz bandwidth

2018-11-28 Thread Sasha Levin
From: Rafał Miłecki [ Upstream commit 3401d42c7ea2d064d15c66698ff8eb96553179ce ] Previous commit /adding/ support for 160 MHz chanspecs was incomplete. It didn't set bandwidth info and didn't extract control channel info. As the result it was also using uninitialized "sb" var. This change has b

[PATCH AUTOSEL 4.19 68/68] net: gemini: Fix copy/paste error

2018-11-28 Thread Sasha Levin
From: Andreas Fiedler [ Upstream commit 07093b76476903f820d83d56c3040e656fb4d9e3 ] The TX stats should be started with the tx_stats_syncp, there seems to be a copy/paste error in the driver. Signed-off-by: Andreas Fiedler Signed-off-by: Linus Walleij Signed-off-by: David S. Miller Signed-off

[PATCH AUTOSEL 4.19 61/68] ibmvnic: Fix RX queue buffer cleanup

2018-11-28 Thread Sasha Levin
From: Thomas Falcon [ Upstream commit b7cdec3d699db2e5985ad39de0f25d3b6111928e ] The wrong index is used when cleaning up RX buffer objects during release of RX queues. Update to use the correct index counter. Signed-off-by: Thomas Falcon Signed-off-by: David S. Miller Signed-off-by: Sasha Le

[PATCH AUTOSEL 4.19 64/68] virtio-net: fail XDP set if guest csum is negotiated

2018-11-28 Thread Sasha Levin
From: Jason Wang [ Upstream commit 18ba58e1c234ea1a2d9835ac8c1735d965ce4640 ] We don't support partial csumed packet since its metadata will be lost or incorrect during XDP processing. So fail the XDP set if guest_csum feature is negotiated. Fixes: f600b6905015 ("virtio_net: Add XDP support") R

[PATCH AUTOSEL 4.19 63/68] virtio-net: disable guest csum during XDP set

2018-11-28 Thread Sasha Levin
From: Jason Wang [ Upstream commit e59ff2c49ae16e1d179de679aca81405829aee6c ] We don't disable VIRTIO_NET_F_GUEST_CSUM if XDP was set. This means we can receive partial csumed packets with metadata kept in the vnet_hdr. This may have several side effects: - It could be overridden by header adju

[PATCH AUTOSEL 4.19 49/68] net/ibmnvic: Fix deadlock problem in reset

2018-11-28 Thread Sasha Levin
From: Juliet Kim [ Upstream commit a5681e20b541a507c7d4fd48ae4a4040d32ee1ef ] This patch changes to use rtnl_lock only during a reset to avoid deadlock that could occur when a thread operating close is holding rtnl_lock and waiting for reset_lock acquired by another thread, which is waiting for

[PATCH AUTOSEL 4.19 26/68] bnxt_en: Fix filling time in bnxt_fill_coredump_record()

2018-11-28 Thread Sasha Levin
From: Vasundhara Volam [ Upstream commit 8dc5ae2d48976764cf3498e97963fa06befefb0e ] Fix the year and month offset while storing it in bnxt_fill_coredump_record(). Fixes: 6c5657d085ae ("bnxt_en: Add support for ethtool get dump.") Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Sig

[PATCH AUTOSEL 4.19 19/68] qed: Fix overriding offload_tc by protocols without APP TLV

2018-11-28 Thread Sasha Levin
From: Denis Bolotin [ Upstream commit e90202ed1cf9672c48a363c84a929932ebfe6fc0 ] The TC received from APP TLV is stored in offload_tc, and should not be set by protocols which did not receive an APP TLV. Fixed the condition when overriding the offload_tc. Signed-off-by: Denis Bolotin Signed-of

[PATCH AUTOSEL 4.19 07/68] mt76: fix building without CONFIG_LEDS_CLASS

2018-11-28 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit b374e8686fc35ae124e62dc78725ea656ba1ef8a ] When CONFIG_LEDS_CLASS is disabled, or it is a loadable module while mt76 is built-in, we run into a link error: drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_register_device': mac80211.c:(.text

[PATCH AUTOSEL 4.19 06/68] brcmutil: really fix decoding channel info for 160 MHz bandwidth

2018-11-28 Thread Sasha Levin
From: Rafał Miłecki [ Upstream commit 3401d42c7ea2d064d15c66698ff8eb96553179ce ] Previous commit /adding/ support for 160 MHz chanspecs was incomplete. It didn't set bandwidth info and didn't extract control channel info. As the result it was also using uninitialized "sb" var. This change has b

Re: macb: probe of 10090000.ethernet failed with error -110

2018-11-28 Thread Andrew Lunn
>diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c >index 7cae17517744..8e0a71ee6bab 100644 >--- a/drivers/net/phy/mscc.c >+++ b/drivers/net/phy/mscc.c >@@ -1822,6 +1822,24 @@ static int vsc85xx_probe(struct phy_device *phydev) > return vsc85xx_dt_led_modes_get(

Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend

2018-11-28 Thread Nathan Chancellor
On Wed, Nov 28, 2018 at 09:52:41PM -0800, David Miller wrote: > From: Nathan Chancellor > Date: Wed, 28 Nov 2018 22:18:09 -0700 > > > Clang warns: > > > > drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around > > initialization of subobject [-Wmissing-braces] > > struc

[PATCH net] virtio-net: keep vnet header zeroed after processing XDP

2018-11-28 Thread Jason Wang
We copy vnet header unconditionally in page_to_skb() this is wrong since XDP may modify the packet data. So let's keep a zeroed vnet header for not confusing the conversion between vnet header and skb metadata. In the future, we should able to detect whether or not the packet was modified and keep

Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend

2018-11-28 Thread David Miller
From: Nathan Chancellor Date: Wed, 28 Nov 2018 22:18:09 -0700 > Clang warns: > > drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around > initialization of subobject [-Wmissing-braces] > struct aqc111_wol_cfg wol_cfg = { 0 }; >

Re: [PATCH iproute2] ss: add support for delivered and delivered_ce fields

2018-11-28 Thread Eric Dumazet
On Wed, Nov 28, 2018 at 9:16 PM David Ahern wrote: > > On 11/28/18 10:10 PM, Eric Dumazet wrote: > > > > > > On 11/28/2018 04:01 PM, Stephen Hemminger wrote: > >> On Mon, 26 Nov 2018 14:29:53 -0800 > >> Eric Dumazet wrote: > >> > >>> Kernel support was added in linux-4.18 in commit feb5f2ec6464 >

[PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend

2018-11-28 Thread Nathan Chancellor
Clang warns: drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around initialization of subobject [-Wmissing-braces] struct aqc111_wol_cfg wol_cfg = { 0 }; ^ {} 1 warning gen

Re: [PATCH bpf 2/2] bpf: test_verifier, test for lookup on queue/stack maps

2018-11-28 Thread Prashant Bhole
On 11/28/2018 10:06 PM, Mauricio Vasquez wrote: On 11/28/18 3:45 AM, Daniel Borkmann wrote: On 11/28/2018 08:51 AM, Prashant Bhole wrote: This patch adds tests to check whether bpf verifier prevents lookup on queue/stack maps Signed-off-by: Prashant Bhole ---   tools/testing/selftests/bpf

Re: [PATCH iproute2] ss: add support for delivered and delivered_ce fields

2018-11-28 Thread David Ahern
On 11/28/18 10:10 PM, Eric Dumazet wrote: > > > On 11/28/2018 04:01 PM, Stephen Hemminger wrote: >> On Mon, 26 Nov 2018 14:29:53 -0800 >> Eric Dumazet wrote: >> >>> Kernel support was added in linux-4.18 in commit feb5f2ec6464 >>> ("tcp: export packets delivery info") >>> >>> Tested: >>> >>> ss

Re: [RFC PATCH] net: macb: Apply RXUBR workaround only to versions with errata

2018-11-28 Thread Harini Katakam
Hi Brandon, On Thu, Nov 29, 2018 at 2:39 AM Brandon Streiff wrote: > > On 11/23/2018 3:59 AM, Harini Katakam wrote: > > +/* Errata mask bits */ > > +#define MACB_ERRATA_RXLOCKUP 0x0001 > > + > > /* LSO settings */ > > #define MACB_LSO_UFO_ENABLE 0x01 > > #d

Re: [PATCH iproute2] ss: add support for delivered and delivered_ce fields

2018-11-28 Thread Eric Dumazet
On 11/28/2018 04:01 PM, Stephen Hemminger wrote: > On Mon, 26 Nov 2018 14:29:53 -0800 > Eric Dumazet wrote: > >> Kernel support was added in linux-4.18 in commit feb5f2ec6464 >> ("tcp: export packets delivery info") >> >> Tested: >> >> ss -ti >> ... >> ESTAB 0 2270520 [2607:f8b0:8099:e1

  1   2   3   4   >