Since commit 509db2833e0d ("bpf: error handling when map_lookup_elem
isn't supported") when map lookup isn't supported, the map_lookup_elem
function should return ERR_PTR(-EOPNOTSUPP).
Fixes: f1a2e44a3aec ("bpf: add queue and stack maps")
Signed-off-by: Prashant Bhole
---
kernel/bpf/queue_stack_
This set fixes map_lookup_elem return value for queue/stack map.
Also adds verifier tests to check whether verifier prevents lookup on
these maps.
Note that patch 2 isn't dependant on patch 1. The verifier prevents
lookup on queue/stack map because key size is zero.
Prashant Bhole (2):
bpf: que
This patch adds tests to check whether bpf verifier prevents lookup
on queue/stack maps
Signed-off-by: Prashant Bhole
---
tools/testing/selftests/bpf/test_verifier.c | 52 +
1 file changed, 52 insertions(+)
diff --git a/tools/testing/selftests/bpf/test_verifier.c
b/tools/te
On Tue, Nov 27, 2018 at 10:17 PM 배석진 wrote:
> >> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK.
> >
> > These sessions should have a timer, and eventually disappear.
>
> FIN_WAIT2 and TIME_WAIT have a timer.
> but FIN_WAIT1 and LAST_ACK are have too?
What harm is caused by
The net device ndev is freed via free_netdev when failing to register
the device. The control flow then jumps to the error handling code
block. ndev is used and freed again. Resulting in a use-after-free bug.
Signed-off-by: Pan Bian
---
drivers/net/ethernet/hisilicon/hip04_eth.c | 4 +---
1 file
What is the plan ahead here? I think the nvme code looks pretty
reasonable now (I'll do another pass at nitpicking), but we need the
networking stuff sorted out with at least ACKs, or a merge through
the networking tree and then a shared branch we can pull in.
skb is freed via dev_kfree_skb_any, however, skb->len is read then. This
may result in a use-after-free bug.
Fixes: e6161d64263 ("rapidio/rionet: rework driver initialization and removal")
Signed-off-by: Pan Bian
---
drivers/net/rionet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
rtnl_newlink() used to create VLAs based on link kind. Since
commit ccf8dbcd062a ("rtnetlink: Remove VLA usage") statically
sized array is created on the stack, so there is no more use
for a separate code block that used to be the VLA's live range.
While at it christmas tree the variables. Note
Standard kernel compilation produces the following warning:
net/core/rtnetlink.c: In function ‘rtnl_newlink’:
net/core/rtnetlink.c:3232:1: warning: the frame size of 1288 bytes is larger
than 1024 bytes [-Wframe-larger-than=]
}
^
This should not really be an issue, as rtnl_newlink() stack is
Hi!
I've been hoping for some time that someone more competent would fix
the stack frame size warning in rtnl_newlink(), but looks like I'll
have to take a stab at it myself :) That's the only warning I see
in most of my builds.
First patch refactors away a somewhat surprising if (1) code block.
nd_q is only used at the very end of nfp_net_tx(), there is no need
to initialize it early.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/et
FW/HW can generally support the standard networking offloads
on representors without any trouble. Add the ability for FW
to advertise which features should be available on representors.
Because representors are muxed on top of the vNIC we need to listen
on feature changes of their lower devices,
When troubleshooting incorrect FW capabilities it's useful to know
where the faulty TLV is located. Add offset to all errors messages.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
.../net/ethernet/netronome/nfp/nfp_net_ctrl.c| 16
1 file changed, 8 ins
Move temporary variables in scope of the loop in nfp_net_tx_complete(),
and add a temp for txbuf software structure. This saves us 0.2% of CPU.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
.../ethernet/netronome/nfp/nfp_net_common.c | 31 ++-
1 file chang
Our representors are software devices built on top of the PF
vNIC, the queuing should only happen at the vNIC netdevice.
Allow representors to run qdisc-less.
Signed-off-by: Jakub Kicinski
Reviewed-by: John Hurley
---
drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 1 +
1 file changed, 1 in
The TSO-related offsets in the descriptor should not include
the length of the prepended metadata. Adjust them. Note that
this could not have caused issues in the past as we don't
support TSO with metadata prepend as of this patch.
Signed-off-by: Michael Rapson
Signed-off-by: Jakub Kicinski
Re
In preparation for TSO over representors make sure the port id
prepend will always fit in the frame. The current max header
length is 255, which is ample, so assume worst case scenario
of 8 byte prepend and save ourselves the conditionals.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der
Hi!
This set starts with three micro optimizations to the TX path.
The improvement is measurable, but below 1% of CPU utilization.
Patches 4 - 9 add basic TX offloads to representor devices, like
checksum offload or TSO, and remove the unnecessary TX lock and
Qdisc (our representors are software
Up until now we never needed to keep a networking locks around
representors accesses, we only accessed them when device was
reconfigured (under nfp pf->lock) or on fast path (under RCU).
Now we want to be able to iterate over all representors during
notifications, so make sure representor assignmen
Chained descriptors for fragments need to duplicate all the descriptor
fields of the skb head, so we copy the descriptor and then modify the
relevant fields. This is wasteful, because the top half of the descriptor
will get overwritten entirely while the bottom half is not modified at all.
Copy on
FW reconfiguration timeouts are a common indicator of FW trouble.
To make debugging easier print requested update and control word
when reconfiguration fails.
Signed-off-by: Jakub Kicinski
Reviewed-by: Dirk van der Merwe
---
drivers/net/ethernet/netronome/nfp/nfp_net.h| 2 ++
drivers/ne
Our representors are software devices built on top of the PF
vNIC, the only state they have are per-cpu stats, so make
the TX run locklessly.
Signed-off-by: Jakub Kicinski
Reviewed-by: John Hurley
---
drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 2 ++
1 file changed, 2 insertions(+)
dif
>> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK.
>
> These sessions should have a timer, and eventually disappear.
FIN_WAIT2 and TIME_WAIT have a timer.
but FIN_WAIT1 and LAST_ACK are have too?
> Do you have a test to demonstrate the issue ?
>
> I know Lorenzo wrote te
From: Kuninori Morimoto
This patch updates license to use SPDX-License-Identifier
instead of verbose license text.
Signed-off-by: Kuninori Morimoto
Acked-by: Ramesh Shanmugasundaram
---
drivers/net/can/rcar/Kconfig | 1 +
drivers/net/can/rcar/Makefile | 1 +
drivers/net/can/rcar/rc
When an ethernet frame is padded to meet the minimum ethernet frame
size, the padding octets are not covered by the hardware checksum.
Fortunately the padding octets are ususally zero's, which don't affect
checksum. However, we have a switch which pads non-zero octets, this
causes kernel hardware c
On 2018/11/28 13:03, Jason Wang wrote:
> On 2018/11/27 下午3:04, Toshiaki Makita wrote:
>> On 2018/11/26 10:37, Toshiaki Makita wrote:
>>> On 2018/11/23 1:43, David Ahern wrote:
On 11/21/18 5:53 PM, Toshiaki Makita wrote:
>> We really need consistency in the counters and at a minimum, users
On Tue, Nov 27, 2018 at 09:24:05AM -0500, Aaron Conole wrote:
>
> 1. Introduce flowmap again, this time, basically having it close to a
> copy of the hashmap. Introduce a few function calls that allow an
> external module to easily manipulate all maps of that type to insert
> / r
From: David Ahern
Date: Tue, 27 Nov 2018 20:52:24 -0800
> From: David Ahern
>
> Randy reported when CONFIG_PROC_FS is not enabled:
> ld: net/ipv4/af_inet.o: in function `inet_init':
> af_inet.c:(.init.text+0x42d): undefined reference to `raw_init'
>
> Fix by moving the endif up to the
On Mon, Nov 26, 2018 at 4:45 AM Lorenz Bauer wrote:
>
> That's what I had initially, but that makes re-using test_attr really
> awkward. Either
> you need to reset data_out_size before every call because it is used
> to return the
> buffer size,
I think that is exactly what the user of the interf
On 11/27/2018 08:57 PM, Eric Dumazet wrote:
>
>
> On 11/27/2018 05:09 PM, 배석진 wrote:
>> Hello all,
>>
>> nobody concern about this? minor problem? :(
>> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK.
>
> These sessions should have a timer, and eventually disappear.
>
On 11/27/2018 05:09 PM, 배석진 wrote:
> Hello all,
>
> nobody concern about this? minor problem? :(
> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK.
These sessions should have a timer, and eventually disappear.
Do you have a test to demonstrate the issue ?
I know Lorenzo
From: David Ahern
Randy reported when CONFIG_PROC_FS is not enabled:
ld: net/ipv4/af_inet.o: in function `inet_init':
af_inet.c:(.init.text+0x42d): undefined reference to `raw_init'
Fix by moving the endif up to the end of the proc entries
Fixes: 6897445fb194c ("net: provide a sysctl ra
> [1] https://e2e.ti.com/support/arm/sitara_arm/f/791/t/701669
Reading this, the interesting part is:
My guess would be that the driver would have to track the
configuration of the switch hardware to correctly pad the
frame.
Have you tried that?
Andrew
On 11/27/18 8:47 PM, Randy Dunlap wrote:
> On 11/26/18 8:25 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20181126:
>>
>
> as reported for linux-next-20181109:
> (see
> https://lore.kernel.org/lkml/499e91d0-7349-641f-9826-753571317...@infradead.org/)
>
> when CONFIG_PROC_FS is not e
On 2018/11/27 下午3:04, Toshiaki Makita wrote:
On 2018/11/26 10:37, Toshiaki Makita wrote:
On 2018/11/23 1:43, David Ahern wrote:
On 11/21/18 5:53 PM, Toshiaki Makita wrote:
We really need consistency in the counters and at a minimum, users
should be able to track packet and byte counters for
On 11/26/18 8:25 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20181126:
>
as reported for linux-next-20181109:
(see
https://lore.kernel.org/lkml/499e91d0-7349-641f-9826-753571317...@infradead.org/)
when CONFIG_PROC_FS is not enabled:
ld: net/ipv4/af_inet.o: in function `inet_init':
On Tue, Nov 27, 2018 at 11:18:02PM +0100, Jakub Audykowicz wrote:
> On 2018-11-19 08:20, Xin Long wrote:
>
> > On Mon, Nov 19, 2018 at 5:49 AM Jakub Audykowicz
> > wrote:
> >> Calling send on a connected SCTP socket results in kernel panic if
> >> spp_pathmtu was configured manually before an ass
On Tue, 2018-11-27 at 10:00 +, Maxim Mikityanskiy wrote:
> Hi everyone,
>
> We are experiencing an issue with Mellanox mlx5 driver, and I tracked
> it down to
> the packet_snd function in net/packet/af_packet.c.
>
> Brief description: when a socket is created by calling
> `socket(AF_PACKET,
>
From: Roopa Prabhu
commit c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
broke previous use of -c to represent compressvlans. This restores
previous use of -c to represent compressvlans. Understand the original
motivation to use -c to represent color consistently everywhere b
On Tue, Nov 27, 2018 at 5:49 PM Eric Dumazet wrote:
>
>
> Sure this patch handles short frames, but I am saying the issue is
> more generic than that.
Yeah. Let's fix one problem in one patch.
I will clarify that I am only fixing short frames in v2, as I need to update
it anyway.
Thanks!
On Tue, Nov 27, 2018 at 5:42 PM Cong Wang wrote:
>
> On Tue, Nov 27, 2018 at 5:25 PM Eric Dumazet wrote:
> >
> >
> >
> > On 11/27/2018 04:07 PM, Cong Wang wrote:
> > > On Tue, Nov 27, 2018 at 3:48 PM Eric Dumazet
> > > wrote:
> >
> > >>
> > >> But the padding might be added on normal packets (s
On Tue, Nov 27, 2018 at 5:25 PM Eric Dumazet wrote:
>
>
>
> On 11/27/2018 04:07 PM, Cong Wang wrote:
> > On Tue, Nov 27, 2018 at 3:48 PM Eric Dumazet wrote:
>
> >>
> >> But the padding might be added on normal packets (say 1000 bytes + 3 bytes
> >> of padding) ?
> >
> > I never see other padding
On Tue, 2018-11-27 at 11:21 +0100, Daniel Borkmann wrote:
> On 11/27/2018 01:19 AM, Edgecombe, Rick P wrote:
> > On Mon, 2018-11-26 at 16:36 +0100, Jessica Yu wrote:
> > > +++ Rick Edgecombe [20/11/18 15:23 -0800]:
> >
> > [snip]
> > > Hi Rick!
> > >
> > > Sorry for the delay. I'd like to take a
On Tue, Nov 27, 2018 at 5:11 PM Saeed Mahameed wrote:
>
> On Tue, 2018-11-27 at 16:07 -0800, Cong Wang wrote:
> > On Tue, Nov 27, 2018 at 3:48 PM Eric Dumazet
> > wrote:
> > > The bug here is that mlx5 csum only includes the data in IP frame.
> > >
> > > I would simply force skb->ip_summed to CHE
Hi Andrew,
On 11/25/18 8:27 PM, Andrew Lunn wrote:
> On Sun, Nov 25, 2018 at 05:43:15PM -0600, Grygorii Strashko wrote:
>> For proper VLAN packets forwarding CPSW driver uses min tx packet size of
>> 64bytes (VLAN_ETH_ZLEN, excluding ETH_FCS) which was corrected by
>> commit 9421c9015047 ("net: et
On 11/27/2018 04:07 PM, Cong Wang wrote:
> On Tue, Nov 27, 2018 at 3:48 PM Eric Dumazet wrote:
>>
>> But the padding might be added on normal packets (say 1000 bytes + 3 bytes
>> of padding) ?
>
> I never see other padding cases than ETH_ZLEN. Does ethernet standard
> require padding for oth
> On Nov 27, 2018, at 5:06 PM, Nadav Amit wrote:
>
>> On Nov 27, 2018, at 4:07 PM, Rick Edgecombe
>> wrote:
>>
>> Sometimes when memory is freed via the module subsystem, an executable
>> permissioned TLB entry can remain to a freed page. If the page is re-used to
>> back an address that will
Hi Heiner,
> From: Heiner Kallwei, Sent: Wednesday, November 28, 2018 4:46 AM
>
> On 27.11.2018 17:44, Andrew Lunn wrote:
> > On Tue, Nov 27, 2018 at 12:18:20PM +, Yoshihiro Shimoda wrote:
> >> Some PHY device needs edge signal of the reset, but the previous code
> >> is impossible to achieve
On Tue, 2018-11-27 at 16:07 -0800, Cong Wang wrote:
> On Tue, Nov 27, 2018 at 3:48 PM Eric Dumazet
> wrote:
> >
> >
> > On 11/27/2018 03:21 PM, Cong Wang wrote:
> > > When an ethernet frame is padded to meet the minimum ethernet
> > > frame
> > > size, the padding octets are not covered by the h
Hi Andrew,
> From: Andrew Lunn, Sent: Wednesday, November 28, 2018 1:44 AM
>
> On Tue, Nov 27, 2018 at 12:18:20PM +, Yoshihiro Shimoda wrote:
> > Some PHY device needs edge signal of the reset, but the previous code
> > is impossible to achieve it like following:
> >
> > 1) Kernel boots by u
Hello all,
nobody concern about this? minor problem? :(
we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK.
and easily reproduced in wifi network because of android gms... :p
i heard that gms try connect to their server to confirm wifi connection.
and they can't recieve the fin
On Tue, Nov 27, 2018 at 6:08 PM Willem de Bruijn
wrote:
>
> On Tue, Nov 27, 2018 at 3:32 PM Willem de Bruijn
> wrote:
> >
> > On Tue, Nov 27, 2018 at 2:58 PM Willem de Bruijn
> > wrote:
> > >
> > > On Tue, Nov 27, 2018 at 1:41 PM Maxim Mikityanskiy
> > > wrote:
> > > >
> > > > Hi everyone,
> >
> On Nov 27, 2018, at 4:07 PM, Rick Edgecombe
> wrote:
>
> Sometimes when memory is freed via the module subsystem, an executable
> permissioned TLB entry can remain to a freed page. If the page is re-used to
> back an address that will receive data from userspace, it can result in user
> data b
From: Sudarsana Reddy Kalluru
Date: Mon, 26 Nov 2018 22:25:55 -0800
> From: Sudarsana Reddy Kalluru
>
> The patch series populates MBI and storm firware versions in the ethtool
> driver info query.
>
> Please consider applying it to 'net-next' tree.
Series applied.
From: Eric Dumazet
Date: Mon, 26 Nov 2018 15:05:02 -0800
> One thing that could be done without too much impact is to provide a cbext[]
> only for TCP packets in write/rtx queue, that is not in sk_buff but
> on the struct sk_buff_fclones
>
> This extra space would not be 0-initialized at alloc_s
From: Eric Dumazet
Date: Mon, 26 Nov 2018 14:49:12 -0800
> Only one caller needs to pull TCP headers, so lets
> move __skb_pull() to the caller side.
>
> Signed-off-by: Eric Dumazet
> Acked-by: Yuchung Cheng
> ---
> v2: sent as a standalone patch.
Applied, thanks Eric.
From: Vijay Khemka
Date: Mon, 26 Nov 2018 13:49:04 -0800
> This patch adds OEM Mellanox commands and response handling. It also
> defines OEM Get MAC Address handler to get and configure the device.
>
> ncsi_oem_gma_handler_mlx: This handler send NCSI mellanox command for
> getting mac address.
From: Heiner Kallweit
Date: Mon, 26 Nov 2018 20:24:16 +0100
> writex() has implicit barriers, that's what makes it different from
> writex_relaxed(). Therefore these calls to mmiowb() can be removed.
>
> Signed-off-by: Heiner Kallweit
Applied.
> Then, do you think it would be better to have a new API part of struct
> mii_bus that drivers should register so that, the mii core to check if the
> bus is idle before lunching a new request?
I'm not sure that actually brings anything useful. The core does not
benefit from it, and it does not
Sometimes when memory is freed via the module subsystem, an executable
permissioned TLB entry can remain to a freed page. If the page is re-used to
back an address that will receive data from userspace, it can result in user
data being mapped as executable in the kernel. The root of this behavior i
Since vfree will lazily flush the TLB, but not lazily free the underlying pages,
it often leaves stale TLB entries to freed pages that could get re-used. This is
undesirable for cases where the memory being freed has special permissions such
as executable.
Having callers flush the TLB after callin
Change the module allocations to flush before freeing the pages.
Signed-off-by: Rick Edgecombe
---
arch/x86/kernel/module.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/module.c b/arch/x86/kernel/module.c
index b052e883dd8c..1694daf256b3 100644
--- a/ar
From: Salil Mehta
Date: Mon, 26 Nov 2018 18:43:00 +
> From: Peng Li
>
> Port 0/1 of HiP08 supports 10G and 25G. This patch adds a
> change to configure NIC port speed same as that of optical
> module(SFP/QFSP). Driver gets the optical module speed and
> sets NIC port speed accordingly.
>
From: Bryan Whitehead
Date: Mon, 26 Nov 2018 12:27:10 -0500
> This driver was designed to work with both LAN7430 and LAN7431.
> The only difference between the two is the LAN7431 has support
> for external phy.
>
> This change adds LAN7431 to the list of recognized devices
> supported by this dr
From: Jon Maloy
Date: Mon, 26 Nov 2018 12:26:14 -0500
> We see the following lockdep warning:
...
> The reason is that the node timer handler sometimes needs to delete a
> node which has been disconnected for too long. To do this, it grabs
> the lock 'node_list_lock', which may at the same time
From: Bryan Whitehead
Date: Mon, 26 Nov 2018 12:04:57 -0500
> The lan743x driver, when under heavy traffic load, has been noticed
> to sometimes hang, or cause a kernel panic.
>
> Debugging reveals that the TX napi poll routine was returning
> the wrong value, 'weight'. Most other drivers return
On Mon, Nov 26, 2018 at 1:35 AM, Sharath Chandra Vurukala
wrote:
> when the tcp_retranmission_timer expires and tcp_retranmsit_skb is
> called if the retranmsission fails due to local congestion,
> backoff should not incremented.
>
> tcp_retransmit_skb() returns non-zero negative value in some cas
On Fri, 2018-11-16 at 09:20 -0600, Thor Thayer wrote:
> Hi Dalon,
>
> Just a few comments/questions.
>
> On 11/14/18 6:50 PM, Dalon Westergreen wrote:
> > From: Dalon Westergreen
> >
> > Add support for the mSGDMA prefetcher. The prefetcher adds support
> > for a linked list of descriptors in
From: Ioana Ciocoi Radulescu
Date: Mon, 26 Nov 2018 16:27:28 +
> Add support for XDP programs. Only XDP_PASS, XDP_DROP and XDP_TX
> actions are supported for now. Frame header changes are also
> allowed.
>
> v2: - count the XDP packets in the rx/tx inteface stats
> - add message with the
From: Colin King
Date: Mon, 26 Nov 2018 15:34:01 +
> From: Colin Ian King
>
> The text in array velocity_gstrings contains a spelling mistake,
> rename rx_frame_alignement_errors to rx_frame_alignment_errors.
>
> Signed-off-by: Colin Ian King
Applied.
On Tue, Nov 27, 2018 at 11:17:26AM +0100, Ilya Dryomov wrote:
> On Tue, Nov 27, 2018 at 10:22 AM Pan Bian wrote:
> >
> > The function ceph_monc_handle_map calls kfree(old) to free the old
> > monitor map, old points to monc->monmap. However, after that, it reads
> > monc->monmap->epoch and passes
From: Colin King
Date: Mon, 26 Nov 2018 15:53:54 +
> From: Colin Ian King
>
> The text in array s_igu_fifo_error_strs contains a spelling mistake,
> fix it.
>
> Signed-off-by: Colin Ian King
Applied.
From: Nicolas Dichtel
Date: Mon, 26 Nov 2018 15:42:01 +0100
>
> The goal of this series is to ease the interpretation of nsid received in
> netlink messages from other netns (when the user uses
> NETLINK_F_LISTEN_ALL_NSID).
>
> After this series, with a patched iproute2:
...
> v3 -> v4:
> -
From: Lorenzo Bianconi
Date: Mon, 26 Nov 2018 15:07:16 +0100
> Fix a possible NULL pointer dereference in nic_remove routine
> removing the nicpf module if nic_probe fails.
> The issue can be triggered with the following reproducer:
>
> $rmmod nicvf
> $rmmod nicpf
>
> [ 521.412008] Unable to h
From: Sudarsana Reddy Kalluru
Date: Mon, 26 Nov 2018 02:26:56 -0800
> From: Sudarsana Reddy Kalluru
>
> The patch series add few enhancements to qed/qede drivers.
>
> Changes from previous versions:
> ---
> v3: Revert v2 changes as the other paths (i.e. ptp) access
From: Sharath Chandra Vurukala
Date: Mon, 26 Nov 2018 15:05:50 +0530
> when the tcp_retranmission_timer expires and tcp_retranmsit_skb is
> called if the retranmsission fails due to local congestion,
> backoff should not incremented.
>
> tcp_retransmit_skb() returns non-zero negative value in so
On Tue, Nov 27, 2018 at 3:48 PM Eric Dumazet wrote:
>
>
>
> On 11/27/2018 03:21 PM, Cong Wang wrote:
> > When an ethernet frame is padded to meet the minimum ethernet frame
> > size, the padding octets are not covered by the hardware checksum.
> > Fortunately the padding octets are ususally zero's
On 11/27/2018 03:21 PM, Cong Wang wrote:
> When an ethernet frame is padded to meet the minimum ethernet frame
> size, the padding octets are not covered by the hardware checksum.
> Fortunately the padding octets are ususally zero's, which don't affect
> checksum. However, we have a switch which
From: Igor Russkikh
Date: Mon, 26 Nov 2018 09:32:56 +
> This patchset introduces support for new multigig ethernet to USB dongle,
> developed jointly by Aquantia (Phy) and ASIX (USB MAC).
Series applied, thanks.
From: Xin Long
Date: Mon, 26 Nov 2018 14:52:44 +0800
> I changed to count sk_wmem_alloc by skb truesize instead of 1 to
> fix the sk_wmem_alloc leak caused by later truesize's change in
> xfrm in Commit 02968ccf0125 ("sctp: count sk_wmem_alloc by skb
> truesize in sctp_packet_transmit").
>
> But
From: yupeng
Date: Sun, 25 Nov 2018 23:35:46 -0800
> Add explaination of below counters:
> TcpExtTCPRcvCoalesce
> TcpExtTCPAutoCorking
> TcpExtTCPOrigDataSent
> TCPSynRetrans
> TCPFastOpenActiveFail
> TcpExtListenOverflows
> TcpExtListenDrops
> TcpExtTCPHystartTrainDetect
> TcpExtTCPHystartTrainC
From: Colin King
Date: Sun, 25 Nov 2018 23:21:08 +
> From: Colin Ian King
>
> There are spelling mistakes in debug messages, fix them.
>
> Signed-off-by: Colin Ian King
Applied.
From: Ido Schimmel
Date: Sun, 25 Nov 2018 09:43:53 +
> The driver is using 802.1Q filtering identifiers (FIDs) to represent the
> different VLANs in the VLAN-aware bridge (only one is supported).
>
> However, the device cannot assign a VNI to such FIDs, which prevents the
> driver from suppo
From: YueHaibing
Date: Sat, 24 Nov 2018 18:16:41 +0800
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:260:7:
> warning: variable 'err' set but not used [-Wunused-but-set-variable]
>
> 'err' should be returned while set MPI_DEIN
On Tue, Nov 27, 2018 at 3:21 PM Cong Wang wrote:
> + if (proto == htons(ETH_P_IP)) {
> + struct iphdr *ipv4 = ip_p;
> +
> + pad_offset = network_depth + be16_to_cpu(ipv4->tot_len);
> + } else if (proto == htons(ETH_P_IPV6)) {
> + struct ipv6hd
When an ethernet frame is padded to meet the minimum ethernet frame
size, the padding octets are not covered by the hardware checksum.
Fortunately the padding octets are ususally zero's, which don't affect
checksum. However, we have a switch which pads non-zero octets, this
causes kernel hardware c
From: Sagi Grimberg
The single caller to csum_and_copy_to_iter is skb_copy_and_csum_datagram
and we are trying to unite its logic with skb_copy_datagram_iter by passing
a callback to the copy function that we want to apply. Thus, we need
to make the checksum pointer private to the function.
Sign
From: Sagi Grimberg
Signed-off-by: Sagi Grimberg
---
include/linux/nvme-tcp.h | 189 +++
include/linux/nvme.h | 1 +
2 files changed, 190 insertions(+)
create mode 100644 include/linux/nvme-tcp.h
diff --git a/include/linux/nvme-tcp.h b/include/linux/n
Changes from v3:
- various changes based on comments from christoph
- removed unused variables
- united send/recv iter initialization
- removed unneeded void * casting
- fixed long lines
- removed unneeded wrappers (nvme_tcp_free_tagset and friends)
- remove null sgl setting
- fixed s
From: Sagi Grimberg
This patch implements the TCP transport driver for the NVMe over Fabrics
target stack. This allows exporting NVMe over Fabrics functionality over
good old TCP/IP.
The driver implements the TP 8000 of how nvme over fabrics capsules and
data are encapsulated in nvme-tcp pdus an
From: Sagi Grimberg
Reviewed-by: Max Gurtovoy
Reviewed-by: Christoph Hellwig
Signed-off-by: Sagi Grimberg
---
drivers/nvme/target/configfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index db2cb64be7ba..618bbd006544 100
From: Sagi Grimberg
skb_copy_datagram_iter and skb_copy_and_csum_datagram are essentialy
the same but with a couple of differences: The first is the copy
operation used which either a simple copy or a csum_and_copy, and the
second are the behavior on the "short copy" path where simply copy
needs
From: Sagi Grimberg
Allow consumers that want to use iov iterator helpers and also update
a predefined hash calculation online when copying data. This is useful
when copying incoming network buffers to a local iterator and calculate
a digest on the incoming stream. nvme-tcp host driver that will
From: Sagi Grimberg
nvmet-tcp will implement it to allocate queue commands which
are only known at nvmf connect time (sq size).
Reviewed-by: Christoph Hellwig
Signed-off-by: Sagi Grimberg
---
drivers/nvme/target/fabrics-cmd.c | 10 ++
drivers/nvme/target/nvmet.h | 1 +
2 files
From: Sagi Grimberg
Data digest is a nvme-tcp specific feature, but nothing prevents other
transports reusing the concept so do not associate with tcp transport
solely.
Reviewed-by: Christoph Hellwig
Signed-off-by: Sagi Grimberg
---
drivers/nvme/host/fabrics.c | 5 +
drivers/nvme/host/fab
From: Sagi Grimberg
This will be useful to consolidate skb_copy_and_hash_datagram_iter and
skb_copy_and_csum_datagram to a single code path.
Signed-off-by: Sagi Grimberg
---
net/core/datagram.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/net/core/datagram.c b/n
From: Sagi Grimberg
This patch implements the NVMe over TCP host driver. It can be used to
connect to remote NVMe over Fabrics subsystems over good old TCP/IP.
The driver implements the TP 8000 of how nvme over fabrics capsules and
data are encapsulated in nvme-tcp pdus and exchaged on top of a
From: Sagi Grimberg
Introduce a helper to copy datagram into an iovec iterator
but also update a predefined hash. This is useful for
consumers of skb_copy_datagram_iter to also support inflight
data digest without having to finish to copy and only then
traverse the iovec and calculate the digest
From: Sagi Grimberg
Header digest is a nvme-tcp specific feature, but nothing prevents other
transports reusing the concept so do not associate with tcp transport
solely.
Reviewed-by: Christoph Hellwig
Signed-off-by: Sagi Grimberg
---
drivers/nvme/host/fabrics.c | 5 +
drivers/nvme/host/f
From: Sagi Grimberg
Prevent a namespace conflict as in following patches as skbuff.h will
include the crypto API.
Cc: Kalle Valo
Signed-off-by: Sagi Grimberg
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 +-
drivers/net/wireless/ath/ath6kl/common.h | 2 +-
drivers/net/wireless/ath/ath6
1 - 100 of 216 matches
Mail list logo
