Re: [PATCH bpf-next] tools: bpftool: add map create command

On Fri, Oct 12, 2018 at 11:06:14AM -0700, Jakub Kicinski wrote: > Add a way of creating maps from user space. The command takes > as parameters most of the attributes of the map creation system > call command. After map is created its pinned to bpffs. This makes > it possible to easily and dynam

Re: [net-next,v2,2/4] net/smc: ipv6 support for smc_diag.c

On Tue, Oct 09, 2018 at 04:41:43PM +0200, Ursula Braun wrote: > Eugene, > > we are considering the following patch: > > --- > net/smc/smc_diag.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/smc/smc_diag.c b/net/smc/smc_diag.c > index dbf64a93d68a..371b4cf31fcd

[PATCH net] ipv6: mcast: fix a use-after-free in inet6_mc_check

syzbot found a use-after-free in inet6_mc_check [1] The problem here is that inet6_mc_check() uses rcu and read_lock(&iml->sflock) So the fact that ip6_mc_leave_src() is called under RTNL and the socket lock does not help us, we need to acquire iml->sflock in write mode. In the future, we should

[PATCH bpf-next v2 6/8] tls: add bpf support to sk_msg handling

From: John Fastabend This work adds BPF sk_msg verdict program support to kTLS allowing BPF and kTLS to be combined together. Previously kTLS and sk_msg verdict programs were mutually exclusive in the ULP layer which created challenges for the orchestrator when trying to apply TCP based policy, f

[PATCH bpf-next v2 0/8] sockmap integration for ktls

This work adds a generic sk_msg layer and converts both sockmap and later ktls over to make use of it as a common data structure for application data (similarly as sk_buff for network packets). With that in place the sk_msg framework spans accross ULP layer in the kernel and allows for introspectio

[PATCH bpf-next v2 4/8] tls: convert to generic sk_msg interface

Convert kTLS over to make use of sk_msg interface for plaintext and encrypted scattergather data, so it reuses all the sk_msg helpers and data structure which later on in a second step enables to glue this to BPF. This also allows to remove quite a bit of open coded helpers which are covered by th

[PATCH bpf-next v2 8/8] bpf, doc: add maintainers entry to related files

Add a MAINTAINERS entry to the skmsg and related files such that patches, features, bug reports land with the right Cc. Signed-off-by: Daniel Borkmann Signed-off-by: John Fastabend --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 54

[PATCH bpf-next v2 1/8] tcp, ulp: enforce sock_owned_by_me upon ulp init and cleanup

Whenever the ULP data on the socket is mangled, enforce that the caller has the socket lock held as otherwise things may race with initialization and cleanup callbacks from ulp ops as both would mangle internal socket state. Joint work with John. Signed-off-by: Daniel Borkmann Signed-off-by: Joh

[PATCH bpf-next v2 5/8] tls: replace poll implementation with read hook

From: John Fastabend Instead of re-implementing poll routine use the poll callback to trigger read from kTLS, we reuse the stream_memory_read callback which is simpler and achieves the same. This helps to align sockmap and kTLS so we can more easily embed BPF in kTLS. Joint work with Daniel. Si

[PATCH bpf-next v2 2/8] tcp, ulp: remove ulp bits from sockmap

In order to prepare sockmap logic to be used in combination with kTLS we need to detangle it from ULP, and further split it in later commits into a generic API. Joint work with John. Signed-off-by: Daniel Borkmann Signed-off-by: John Fastabend --- include/net/tcp.h| 1 - kernel/bpf/sockma

[PATCH bpf-next v2 7/8] bpf: add tls support for testing in test_sockmap

From: John Fastabend This adds a --ktls option to test_sockmap in order to enable the combination of ktls and sockmap to run, which makes for another batch of 648 test cases for both in combination. Signed-off-by: John Fastabend Signed-off-by: Daniel Borkmann --- tools/testing/selftests/bpf/t

[PATCH net-next 2/2] selftests: pmtu: Add optional traffic captures for single tests

If --trace is passed as an option and tcpdump is available, capture traffic for all relevant interfaces to per-test pcap files named _.pcap. Signed-off-by: Stefano Brivio Reviewed-by: Sabrina Dubroca --- tools/testing/selftests/net/pmtu.sh | 60 + 1 file changed, 53

[PATCH net-next 0/2] selftests: pmtu: Add test choice and captures

This series adds a couple of features useful for debugging: 1/2 allows selecting single tests and 2/2 adds optional traffic captures. Semantics for current invocation of test script are preserved. Stefano Brivio (2): selftests: pmtu: Allow selection of single tests selftests: pmtu: Add option

[PATCH net-next 1/2] selftests: pmtu: Allow selection of single tests

As number of tests is growing, it's quite convenient to allow single tests to be run. Display usage when the script is run with any invalid argument, keep existing semantics when no arguments are passed so that automated runs won't break. Instead of just looping on the list of requested tests, if

[PATCH net 2/2] geneve, vxlan: Don't set exceptions if skb->len < mtu

We shouldn't abuse exceptions: if the destination MTU is already higher than what we're transmitting, no exception should be created. Fixes: 52a589d51f10 ("geneve: update skb dst pmtu on tx path") Fixes: a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path") Signed-off-by: Stefano Brivio Reviewed

[PATCH net 1/2] geneve, vxlan: Don't check skb_dst() twice

Commit f15ca723c1eb ("net: don't call update_pmtu unconditionally") avoids that we try updating PMTU for a non-existent destination, but didn't clean up cases where the check was already explicit. Drop those redundant checks. Signed-off-by: Stefano Brivio Reviewed-by: Sabrina Dubroca --- driver

[PATCH net 0/2] geneve, vxlan: Don't set exceptions if skb->len < mtu

This series fixes the exception abuse described in 2/2, and 1/2 is just a preparatory change to make 2/2 less ugly. Stefano Brivio (2): geneve, vxlan: Don't check skb_dst() twice geneve, vxlan: Don't set exceptions if skb->len < mtu drivers/net/geneve.c | 14 +++--- drivers/net/vxlan

Re: [PATCH bpf-next 4/8] tls: convert to generic sk_msg interface

On 10/12/2018 10:16 PM, Dave Watson wrote: > On 10/11/18 02:45 AM, Daniel Borkmann wrote: >> Convert kTLS over to make use of sk_msg interface for plaintext and >> encrypted scattergather data, so it reuses all the sk_msg helpers >> and data structure which later on in a second step enables to glue

[PATCH bpf-next] bpf: Fix dev pointer dereference from sk_skb

Dan Carpenter reports: The patch 6acc9b432e67: "bpf: Add helper to retrieve socket in BPF" from Oct 2, 2018, leads to the following Smatch complaint: net/core/filter.c:4893 bpf_sk_lookup() error: we previously assumed 'skb->dev' could be null (see line 4885) Fix this issue by checking sk

[PATCH net-next] r8169: remove unneeded call to netif_stop_queue in rtl8169_net_suspend

netif_device_detach() stops all tx queues already, so we don't need this call. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index e6e1790f4..

[PATCH net-next] r8169: simplify rtl8169_set_magic_reg

Simplify this function, no functional change intended. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 32 +++- 1 file changed, 12 insertions(+), 20 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r

Re: [PATCH net] net/sched: properly init chain in case of multiple control actions

On Fri, Oct 12, 2018 at 1:39 PM Davide Caratti wrote: > Several TC actions allow users to specify a fallback control action, that > is usually stored in the action private data. 'goto chain x' never worked > for that case, because the action handler was never initialized. There is > only one 'goto

Re: [PATCH V2 net-next 5/5] ptp: Add a driver for InES time stamping IP core.

On Sun, Oct 07, 2018 at 10:38:23AM -0700, Richard Cochran wrote: > The InES at the ZHAW offers a PTP time stamping IP core. The FPGA > logic recognizes and time stamps PTP frames on the MII bus. This > patch adds a driver for the core along with a device tree binding to > allow hooking the driver

[PATCH net] net/sched: properly init chain in case of multiple control actions

the following script: # tc f a dev v0 egress chain 4 matchall action simple sdata "A triumph!" # tc f a dev v0 egress matchall action pass random determ goto chain 4 5 produces the following crash: BUG: unable to handle kernel NULL pointer dereference at PGD 0 P4D 0 Oops: 0

Re: [PATCH bpf-next 4/8] tls: convert to generic sk_msg interface

On 10/11/18 02:45 AM, Daniel Borkmann wrote: > Convert kTLS over to make use of sk_msg interface for plaintext and > encrypted scattergather data, so it reuses all the sk_msg helpers > and data structure which later on in a second step enables to glue > this to BPF. Looks very clean, thanks! > >

Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

David Miller wrote: > > Nit : Correct attribution would require a Reported-by: tag > > Right. And I've posted a new version with that and the reviewed-by from Arnd. David

[PATCH bpf-next 11/13] tools/bpf: refactor to implement btf_get_from_id() in lib/bpf

The function get_btf() is implemented in tools/bpf/bpftool/map.c to get a btf structure given a map_info. This patch refactored this function to be function btf_get_from_id() in tools/lib/bpf so that it can be used later. Signed-off-by: Yonghong Song --- tools/bpf/bpftool/map.c | 68 ++--

[PATCH bpf-next 12/13] tools/bpf: enhance test_btf file testing to test func info

Change the bpf programs test_btf_haskv.c and test_btf_nokv.c to have two sections, and enhance test_btf.c test_file feature to test btf func_info returned by the kernel. Signed-off-by: Yonghong Song --- tools/testing/selftests/bpf/test_btf.c | 72 +++- tools/testing/selftes

[PATCH bpf-next 13/13] tools/bpf: bpftool: add support for jited func types

This patch added support to print function signature if btf func_info is available. Note that ksym now uses function name instead of prog_name as prog_name has a limit of 16 bytes including ending '\0'. The following is a sample output for selftests test_btf with file test_btf_haskv.o: $ bpftoo

[PATCH bpf-next 10/13] tools/bpf: do not use pahole if clang/llvm can generate BTF sections

Add additional checks in tools/testing/selftests/bpf and samples/bpf such that if clang/llvm compiler can generate BTF sections, do not use pahole. Signed-off-by: Yonghong Song --- samples/bpf/Makefile | 8 tools/testing/selftests/bpf/Makefile | 8 2 files chang

[PATCH bpf-next 05/13] bpf: get better bpf_prog ksyms based on btf func type_id

This patch added interface to load a program with the following additional information: . prog_btf_fd . func_info and func_info_len where func_info will provides function range and type_id corresponding to each function. If verifier agrees with function range provided by the user, the bpf_pr

[PATCH bpf-next 06/13] tools/bpf: sync kernel uapi bpf.h header to tools directory

The kernel uapi bpf.h is synced to tools directory. Signed-off-by: Yonghong Song --- tools/include/uapi/linux/bpf.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index f9187b41dff6..7ebbf4f06a65 100644 --- a/tools

[iproute2 PATCH] tc: flower: Classify packets based port ranges

Added support for filtering based on port ranges. Example: 1. Match on a port range: - $ tc filter add dev enp4s0 protocol ip parent :\ prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw\ action drop $ tc -s filter show dev enp4s0 parent : filter protocol

[PATCH bpf-next 07/13] tools/bpf: add new fields for program load in lib/bpf

The new fields are added for program load in lib/bpf so application uses api bpf_load_program_xattr() is able to load program with btf and func_info data. This functionality will be used in next patch by bpf selftest test_btf. Signed-off-by: Yonghong Song --- tools/lib/bpf/bpf.c | 3 +++ tools/

[PATCH bpf-next 03/13] tools/bpf: sync kernel btf.h header

The kernel uapi btf.h is synced to the tools directory. Signed-off-by: Martin KaFai Lau Signed-off-by: Yonghong Song --- tools/include/uapi/linux/btf.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/include/uapi/linux/btf.h b/tools/include/uapi/linux/btf.h in

[PATCH bpf-next 08/13] tools/bpf: extends test_btf to test load/retrieve func_type info

A two function bpf program is loaded with btf and func_info. After successful prog load, the bpf_get_info syscall is called to retrieve prog info to ensure the types returned from the kernel matches the types passed to the kernel from the user space. Several negative tests are also added to test l

[PATCH bpf-next 02/13] bpf: btf: Add BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO

This patch adds BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO support to the type section. BTF_KIND_FUNC_PROTO is used to specify the type of a function pointer. With this, BTF has a complete set of C types (except float). BTF_KIND_FUNC is used to specify the signature of a defined subprogram. BTF_KIND_FU

[PATCH bpf-next 01/13] bpf: btf: Break up btf_type_is_void()

This patch breaks up btf_type_is_void() into btf_type_is_void() and btf_type_is_fwd(). It also adds btf_type_nosize() to better describe it is testing a type has nosize info. Signed-off-by: Martin KaFai Lau --- kernel/bpf/btf.c | 37 ++--- 1 file changed, 22 inse

[PATCH bpf-next 04/13] tools/bpf: add btf func/func_proto unit tests in selftest test_btf

Add several BTF_KIND_FUNC and BTF_KIND_FUNC_PROTO unit tests in bpf selftest test_btf. Signed-off-by: Martin KaFai Lau Signed-off-by: Yonghong Song --- tools/lib/bpf/btf.c| 4 + tools/testing/selftests/bpf/test_btf.c | 216 + 2 files changed, 220 in

[PATCH bpf-next 09/13] tools/bpf: add support to read .BTF.ext sections

The .BTF section is already available to encode types. These types can be used for map pretty print. The whole .BTF will be passed to the kernel as well for which kernel can verify and return to the user space for pretty print etc. Recently landed llvm patch "[BPF] Add BTF generation for BPF targe

[PATCH bpf-next 00/13] bpf: add btf func info support

The BTF support was added to kernel by Commit 69b693f0aefa ("bpf: btf: Introduce BPF Type Format (BTF)"), which introduced .BTF section into ELF file and is primarily used for map pretty print. pahole is used to convert dwarf to BTF for ELF files. The next step would be add func type info and debu

[net-next PATCH] net: sched: cls_flower: Classify packets using port ranges

Added support in tc flower for filtering based on port ranges. This is a rework of the RFC patch at: https://patchwork.ozlabs.org/patch/969595/ Example: 1. Match on a port range: - $ tc filter add dev enp4s0 protocol ip parent :\ prio 1 flower ip_proto tcp dst_port ra

Re: [rtnetlink] Potential bug in Linux (rt)netlink code

On Fri, 12 Oct 2018 09:30:40 +0200 Henning Rogge wrote: > Hi, > > I am working on a self-written routing agent > (https://github.com/OLSR/OONF) and am stuck on a problem with netlink > that I cannot explain with an userspace error. > > I am using a netlink socket for setting routes > (RTM_NE

Re: [PATCH net-next v2] vxlan: support NTF_USE refresh of fdb entries

On Thu, 11 Oct 2018 12:35:13 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > This makes use of NTF_USE in vxlan driver consistent > with bridge driver. > > Signed-off-by: Roopa Prabhu > --- > v2: fix patch prefix > > drivers/net/vxlan.c | 10 +++--- > 1 file changed, 7 insertions(+),

Re: [PATCH net-next 0/4] s390/qeth: updates 2018-10-12

From: Julian Wiedmann Date: Fri, 12 Oct 2018 17:27:11 +0200 > please apply one more patchset for net-next. This extends the TSO support > in qeth. Series applied.

Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

From: Eric Dumazet Date: Fri, 12 Oct 2018 08:19:20 -0700 > > > On 10/12/2018 07:52 AM, David Howells wrote: >> The udpv6_encap_enable() function is part of the ipv6 code, and if that is >> configured as a loadable module and rxrpc is built in then a build failure >> will occur because the condi

[PATCH net-next] nfp: devlink port split support for 1x100G CXP NIC

From: Ryan C Goodfellow This commit makes it possible to use devlink to split the 100G CXP Netronome into two 40G interfaces. Currently when you ask for 2 interfaces, the math in src/nfp_devlink.c:nfp_devlink_port_split calculates that you want 5 lanes per port because for some reason eth_port.po

[PATCH bpf-next] tools: bpftool: add map create command

Add a way of creating maps from user space. The command takes as parameters most of the attributes of the map creation system call command. After map is created its pinned to bpffs. This makes it possible to easily and dynamically (without rebuilding programs) test various corner cases related t

[PATCH net-next] netpoll: allow cleanup to be synchronous

This fixes a problem introduced by: commit 2cde6acd49da ("netpoll: Fix __netpoll_rcu_free so that it can hold the rtnl lock") When using netconsole on a bond, __netpoll_cleanup can asynchronously recurse multiple times, each __netpoll_free_async call can result in more __netpoll_free_async's. Thi

Re: [PATCH net-next] netpoll: allow cleanup to be synchronous

Actually I realized this patch might be problematic, although someone might be holding rtnl, it might not be the current callstack. A different solution is needed I think. Input appreciated. -Deb

Re: [PATCH] fore200e: fix sbus compile

From: Christoph Hellwig Date: Fri, 12 Oct 2018 10:17:51 +0200 > Fix a stupid typo introduced in the refactoring. > > Fixes: 0efe5523 ("fore200e: simplify fore200e_bus usage") > Signed-off-by: Christoph Hellwig Applied.

Re: [PATCH net-next] net: Evict neighbor entries on carrier down

From: David Ahern Date: Thu, 11 Oct 2018 20:33:49 -0700 > From: David Ahern > > When a link's carrier goes down it could be a sign of the port changing > networks. If the new network has overlapping addresses with the old one, > then the kernel will continue trying to use neighbor entries estab

Re: [PATCH v2 net-next] net/ipv6: Add knob to skip DELROUTE message on device down

From: David Ahern Date: Thu, 11 Oct 2018 20:17:21 -0700 > From: David Ahern > > Another difference between IPv4 and IPv6 is the generation of RTM_DELROUTE > notifications when a device is taken down (admin down) or deleted. IPv4 > does not generate a message for routes evicted by the down or de

Re: [PATCH net-next] net: cdc_ncm: remove set but not used variable 'ctx'

From: YueHaibing Date: Fri, 12 Oct 2018 01:49:13 + > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/usb/cdc_ncm.c: In function 'cdc_ncm_status': > drivers/net/usb/cdc_ncm.c:1603:22: warning: > variable 'ctx' set but not used [-Wunused-but-set-variable] > struct cdc_ncm_ctx

Re: [PATCH net-next] net: fddi: skfp: Remove unused macros 'PNMI_GET_ID' and 'PNMI_SET_ID'

From: YueHaibing Date: Fri, 12 Oct 2018 10:37:41 +0800 > The two PNMI macros are never used > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md

On Fri, 12 Oct 2018 17:58:55 +0200 Nicolas Dichtel wrote: > Le 12/10/2018 à 14:32, Stefano Brivio a écrit : > > Commit 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 > > tunnels") introduced a check to avoid updating PMTU when > > collect_md mode is enabled. > > > > Later, commit f15ca72

[PATCH net-next 6/6] dpaa2-eth: remove unused FD field

From: Ioana Radulescu According to the hardware ArchDef, the PTV1 field in FD[CTRL] is ignored by WRIOP, so setting it for Tx FDs is pointless. Remove all references to it from the code. Signed-off-by: Ioana Radulescu Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/dpaa

[PATCH net-next 5/6] dpaa2-eth: mark unused parameter in dpaa2_eth_tx_conf

The ch parameter is never used in the dpaa2_eth_tx_conf function but since its prototype must match the type defined in the consume field of struct dpaa2_eth_fq, just mark it as __always_unused. Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +- 1 file chan

[PATCH net-next 4/6] dpaa2-eth: remove unused priv parameter

The priv parameter is never used in the build_linear_skb and drain_channel function. Remove it from the function definitions. Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/n

[PATCH net-next 3/6] dpaa2-eth: fix uninitialized variable warnings

All 3 cases of possible uninitialized variables are false positives since they are used only as output parameters. Nonetheless, fix the warnings. Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

[PATCH net-next 0/6] dpaa2-eth: code cleanup

There are no functional changes in this patch set, only some cleanup changes such as: unused parameters, uninitialized variables and unnecessary Kconfig dependencies. Ioana Ciornei (4): dpaa2-eth: make dpaa2_eth_set_dist_key static dpaa2-eth: fix uninitialized variable warnings dpaa2-eth: re

[PATCH v3 lora-next 2/5] net: lora: sx1301: replace burst spi functions with regmap_noinc

We can now use to regmap_noinc API to allow reading and writing to the internal FIFO register which controls processor memory. We also remove the now defunct spi element from the structure as this completes the move to regmap. Signed-off-by: Ben Whitten --- drivers/net/lora/sx1301.c | 22 ++-

[PATCH v3 lora-next 3/5] net: lora: sx1301: convert to using regmap fields for bit ops

From: Ben Whitten We convert to using regmap fields to allow bit access to the registers where regmap handles the read update write. Signed-off-by: Ben Whitten --- drivers/net/lora/sx1301.c | 234 +- drivers/net/lora/sx1301.h | 46 + 2 files

[PATCH v3 lora-next 4/5] net: lora: sx125x: convert to regmap fields

From: Ben Whitten We convert to using regmap fields to allow regmap to take care of read modify writes and bit shifting for ofset fields. Signed-off-by: Ben Whitten --- drivers/net/lora/sx125x.c | 59 --- 1 file changed, 51 insertions(+), 8 deletions

[PATCH net-next 1/6] dpaa2-eth: Fix Kconfig dependencies

From: Ioana Radulescu Both ARCH_LAYERSCAPE and COMPILE_TEST dependencies are already implied through the FSL_MC_BUS dep, so there's no need to state it explicitly. Also, the fsl-mc bus depends on COMPILE_TEST only for some architectures (arm, arm64, ppc, x86), so it's not correct to claim build

[PATCH net-next 2/6] dpaa2-eth: make dpaa2_eth_set_dist_key static

The dpaa2_eth_set_dist_key function is only used in a single file. Make it static. Signed-off-by: Ioana Ciornei --- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers

[PATCH v3 lora-next 5/5] net: lora: sx125x sx1301: allow radio to register as a clk provider

From: Ben Whitten The 32M is run from the radio, before we just enabled it based on the radio number but now we can use the clk framework to request the clk is started when we need it. The 32M clock produced from the radio is really a gated version of tcxo which is a fixed clock provided by hard

[PATCH v3 lora-next 0/5] based on 4.19-rc7 migration to regmap and clk framewor

This series is designed to be applied to a lora-next which is based on v4.19-rc7, not what is currently upstream, there were no additional changes in this rebase. In this series we add the write variant to regmap_noinc then use it within the sx1301 driver to load firmware. We complete the sx1301

Re: [PATCH net] ipv6: rate-limit probes for neighbourless routes

2018-10-12, 08:17:28 -0700, Eric Dumazet wrote: > > > On 10/12/2018 07:22 AM, Sabrina Dubroca wrote: > > When commit 270972554c91 ("[IPV6]: ROUTE: Add Router Reachability > > Probing (RFC4191).") introduced router probing, the rt6_probe() function > > required that a neighbour entry existed. This

Re: [PATCH iproute2 net-next] bridge: add support for backup port

On October 12, 2018 6:40:28 PM GMT+03:00, Stephen Hemminger wrote: >On Fri, 12 Oct 2018 14:42:55 +0300 >Nikolay Aleksandrov wrote: > >> This patch adds support for the new backup port option that can be >set >> on a bridge port. If the port's carrier goes down all of the traffic >> gets redirect

Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md

Le 12/10/2018 à 14:32, Stefano Brivio a écrit : > Commit 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 > tunnels") introduced a check to avoid updating PMTU when > collect_md mode is enabled. > > Later, commit f15ca723c1eb ("net: don't call update_pmtu > unconditionally") dropped this che

Re: [PATCH iproute2 net-next] bridge: add support for backup port

On Fri, 12 Oct 2018 14:42:55 +0300 Nikolay Aleksandrov wrote: > This patch adds support for the new backup port option that can be set > on a bridge port. If the port's carrier goes down all of the traffic > gets redirected to the configured backup port. We add the following new > arguments: > $

Re: [PATCH bpf-next 2/2] bpf, libbpf: simplify perf RB walk and do incremental updates

On Fri, 12 Oct 2018 15:30:57 +0200, Daniel Borkmann wrote: > On 10/12/2018 10:39 AM, Daniel Borkmann wrote: > > On 10/12/2018 05:04 AM, Jakub Kicinski wrote: > >> On Thu, 11 Oct 2018 16:02:07 +0200, Daniel Borkmann wrote: > >>> Clean up and improve bpf_perf_event_read_simple() ring walk a bit >

Re: [PATCH net-next] net: bridge: add support for per-port vlan stats

On Fri, 12 Oct 2018 13:41:16 +0300 Nikolay Aleksandrov wrote: > This patch adds an option to have per-port vlan stats instead of the > default global stats. The option can be set only when there are no port > vlans in the bridge since we need to allocate the stats if it is set > when vlans are be

Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

Eric Dumazet wrote: > Nit : Correct attribution would require a Reported-by: tag Point. I'll repost it with a To: line also, I'm waiting to see if Arnd will ack it. David

[PATCH iproute2] json: make 0xhex handle u64

Stephen converted macsec's sci to use 0xhex, but 0xhex handles unsigned int's, not 64 bits ints. Thus, the output of the "ip macsec show" command is mangled, with half of the SCI replaced with 0s: # ip macsec show 11: macsec0: [...] cipher suite: GCM-AES-128, using ICV length 16 TXSC:

[PATCH iproute2] macsec: fix off-by-one when parsing attributes

I seem to have had a massive brainfart with uses of parse_rtattr_nested(). The rtattr* array must have MAX+1 elements, and the call to parse_rtattr_nested must have MAX as its bound. Let's fix those. Fixes: b26fc590ce62 ("ip: add MACsec support") Signed-off-by: Sabrina Dubroca --- ip/ipmacsec.c

[PATCH net-next 3/4] s390/qeth: add support for IPv6 TSO

This adds TSO6 support for L3 qeth devices. Just like for standard IPv6 traffic, TSO6 doesn't use IP offload and thus runs over the normal qeth_xmit() path. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h | 2 ++ drivers/s390/net/qeth_core_main.c | 49 ++

[PATCH net-next 4/4] s390/qeth: add TSO support for L2 devices

Except for the new HW header id, this works just like TSO6 on L3 devices and reuses all the existing data path support in qeth_xmit(). Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core.h| 3 ++- drivers/s390/net/qeth_l2_main.c | 30 -- drivers/s390/ne

[PATCH net-next 1/4] s390/qeth: make TSO controls protocol-agnostic

In preparation for IPv6 TSO, turn the protocol version into a parameter for the TSO control code. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 41 --- 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/drivers/s390/net/qe

[PATCH net-next 2/4] s390/qeth: enhance TSO control sequence

TSO6 requires the full programming sequence, and not just a simple START command. This implements the additional ENABLE command, and adds some sanity checks that were missing for the START command. Signed-off-by: Julian Wiedmann --- drivers/s390/net/qeth_core_main.c | 77

[PATCH net-next 0/4] s390/qeth: updates 2018-10-12

Hi Dave, please apply one more patchset for net-next. This extends the TSO support in qeth. Thanks, Julian Julian Wiedmann (4): s390/qeth: make TSO controls protocol-agnostic s390/qeth: enhance TSO control sequence s390/qeth: add support for IPv6 TSO s390/qeth: add TSO support for L2 de

Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

On 10/12/2018 07:52 AM, David Howells wrote: > The udpv6_encap_enable() function is part of the ipv6 code, and if that is > configured as a loadable module and rxrpc is built in then a build failure > will occur because the conditional check is wrong: > > net/rxrpc/local_object.o: In function

Re: [PATCH net] ipv6: rate-limit probes for neighbourless routes

On 10/12/2018 07:22 AM, Sabrina Dubroca wrote: > When commit 270972554c91 ("[IPV6]: ROUTE: Add Router Reachability > Probing (RFC4191).") introduced router probing, the rt6_probe() function > required that a neighbour entry existed. This neighbour entry is used to > record the timestamp of the l

[PATCH net] ipv6: rate-limit probes for neighbourless routes

When commit 270972554c91 ("[IPV6]: ROUTE: Add Router Reachability Probing (RFC4191).") introduced router probing, the rt6_probe() function required that a neighbour entry existed. This neighbour entry is used to record the timestamp of the last probe via the ->updated field. Later, commit 2152caea

Re: [PATCH] igb: shorten maximum PHC timecounter update interval

On Fri, Oct 12, 2018 at 01:13:39PM +0200, Miroslav Lichvar wrote: > This fixes an issue with HW timestamps on 82580/I350/I354 being off by > ~1100 seconds for few seconds every ~9 minutes. This patch should go to the stable trees starting with v4.8. Thanks, Richard

Re: [PATCH] igb: shorten maximum PHC timecounter update interval

On Fri, Oct 12, 2018 at 01:13:39PM +0200, Miroslav Lichvar wrote: > Since commit 500462a9d ("timers: Switch to a non-cascading wheel"), > scheduling of delayed work seems to be less accurate and a requested > delay of 540 seconds may actually be longer than 550 seconds. Shorten > the delay to 480 s

Re: Possible bug in traffic control?

I've been able to narrow the scope down, the issue is with macsec itself. I setup two hosts with a macsec link between them, and let a couple iperf3 sessions blast traffic across. At approximately 4.2 billion packets / 6TB data transferred one end stopped transmitting packets. Doing a tcpdump on

Re: [PATCH bpf-next 2/2] bpf, libbpf: simplify perf RB walk and do incremental updates

On 10/12/2018 10:39 AM, Daniel Borkmann wrote: > On 10/12/2018 05:04 AM, Jakub Kicinski wrote: >> On Thu, 11 Oct 2018 16:02:07 +0200, Daniel Borkmann wrote: >>> Clean up and improve bpf_perf_event_read_simple() ring walk a bit >>> to use similar tail update scheme as in perf and bcc allowing the >>

[PATCH net] ip6_tunnel: Don't update PMTU on tunnels with collect_md

Commit 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6 tunnels") introduced a check to avoid updating PMTU when collect_md mode is enabled. Later, commit f15ca723c1eb ("net: don't call update_pmtu unconditionally") dropped this check, I guess inadvertently. Restore it. Fixes: f15ca723c1eb

URGENT RESPONSE NEEDED

Hello my dear. Did you receive my email message to you? Please, get back to me ASAP as the matter is becoming late. Expecting your urgent response. Sean.

[PATCH iproute2 net-next] bridge: add support for backup port

This patch adds support for the new backup port option that can be set on a bridge port. If the port's carrier goes down all of the traffic gets redirected to the configured backup port. We add the following new arguments: $ ip link set dev brport type bridge_slave backup_port brport2 $ ip link set

[PATCH] igb: shorten maximum PHC timecounter update interval

The timecounter needs to be updated at least once per ~550 seconds in order to avoid a 40-bit SYSTIM timestamp to be misinterpreted as an old timestamp. Since commit 500462a9d ("timers: Switch to a non-cascading wheel"), scheduling of delayed work seems to be less accurate and a requested delay of

Re: [PATCH ipsec] xfrm: policy: use hlist rcu variants on insert

On Wed, Oct 10, 2018 at 06:02:21PM +0200, Florian Westphal wrote: > bydst table/list lookups use rcu, so insertions must use rcu versions. > > Fixes: a7c44247f704e ("xfrm: policy: make xfrm_policy_lookup_bytype lockless") > Signed-off-by: Florian Westphal Applied, thanks Florian!

Re: [PATCH net] net/xfrm: fix out-of-bounds packet access

On Tue, Oct 09, 2018 at 09:59:36AM -0700, Alexei Starovoitov wrote: > BUG: KASAN: slab-out-of-bounds in _decode_session6+0x1331/0x14e0 > net/ipv6/xfrm6_policy.c:161 > Read of size 1 at addr 8801d882eec7 by task syz-executor1/6667 > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > d

Re: [PATCH bpf-next 2/2] bpf, libbpf: simplify perf RB walk and do incremental updates

On 10/12/2018 05:04 AM, Jakub Kicinski wrote: > On Thu, 11 Oct 2018 16:02:07 +0200, Daniel Borkmann wrote: >> Clean up and improve bpf_perf_event_read_simple() ring walk a bit >> to use similar tail update scheme as in perf and bcc allowing the >> kernel to make forward progress not only after full

[PATCH] fore200e: fix sbus compile

Fix a stupid typo introduced in the refactoring. Fixes: 0efe5523 ("fore200e: simplify fore200e_bus usage") Signed-off-by: Christoph Hellwig --- drivers/atm/fore200e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c index 2b5dc8f

[rtnetlink] Potential bug in Linux (rt)netlink code

Hi, I am working on a self-written routing agent (https://github.com/OLSR/OONF) and am stuck on a problem with netlink that I cannot explain with an userspace error. I am using a netlink socket for setting routes (RTM_NEWROUTE/RTM_DELROUTE), querying the kernel for the current routes in the