On Tue, 25 Sep 2018 09:37:41 -0600, David Ahern wrote:
> For ifaddrmsg ifa_flags aligns with ifi_type which is set by kernel side
> so this should be ok.
Does the existing user space set ifi_type to anything? Does it zero out
the field?
Are we able to find a flag value that is not going to be set
Hi,
On Tue, Sep 25, 2018 at 11:00 PM Harini Katakam wrote:
>
> Hi Daniel,
>
> On Tue, Sep 25, 2018 at 9:10 PM Andrew Lunn wrote:
> >
> > > I hope this this thread isn't too old to bring back to life. So it seems
> > > that Harini found that m88e did not need this errata, and Cisco
> > > previ
From: Vakul Garg
Date: Wed, 26 Sep 2018 04:19:25 +
> BTW, I noticed following build failure.
> It gets resolved after reverting d6ab93364734.
>
> CC [M] drivers/net/phy/marvell.o
> drivers/net/phy/marvell.c: In function 'm88e1121_config_aneg':
> drivers/net/phy/marvell.c:468:25: error: 'a
On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer
wrote:
>
> XDP can modify (and resize) the Ethernet header in the packet.
>
> There is a bug in generic-XDP, because skb->protocol and skb->pkt_type
> are setup before reaching (netif_receive_)generic_xdp.
>
> This bug was hit when XDP were po
From: Maciej Żenczykowski
(fix documentation and sysctl access to treat it as such)
Tested:
# zcat /proc/config.gz | egrep ^CONFIG_HZ
CONFIG_HZ_1000=y
CONFIG_HZ=1000
# echo $[(1<<32)/1000 + 1] | tee /proc/sys/net/ipv4/tcp_probe_interval
4294968
tee: /proc/sys/net/ipv4/tcp_probe_inter
The current netpoll implementation in the bnxt_en driver has problems
that may miss TX completion events. bnxt_poll_work() in effect is
only handling at most 1 TX packet before exiting. In addition,
there may be in flight TX completions that ->poll() may miss even
after we fix bnxt_poll_work() to
On Tue, 2018-09-25 at 18:16 +, Vijay Khemka wrote:
> Hi Joel,
> Thanks, I am adding netdev mailing list here.
> Yes, this command is supported for all Mellanox card. It is as per Mellanox
> specification.
>
> Regards
> -Vijay
Hi Vijay,
Thanks for the patch; before I get too into a review th
On Tue, Sep 25, 2018 at 3:25 PM Andrey Ignatov wrote:
>
> Print `bpftool net` output to stdout instead of stderr. Only errors
> should be printed to stderr. Regular output should go to stdout and this
> is what all other subcommands of bpftool do, including --json and
> --pretty formats of `bpftoo
> -Original Message-
> From: David Miller
> Sent: Wednesday, September 26, 2018 9:10 AM
> To: Vakul Garg
> Cc: netdev@vger.kernel.org; bor...@mellanox.com;
> avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com
> Subject: Re: [PATCH net-next] tls: Fix socket mem accounting error un
From: Maciej Żenczykowski
(the parameters in question are mark and flow_flags)
Reviewed-by: David Ahern
Signed-off-by: Maciej Żenczykowski
---
include/net/route.h | 3 +--
net/ipv4/ah4.c| 2 +-
net/ipv4/esp4.c | 2 +-
net/ipv4/icmp.c | 2 +-
net/ipv4/ip_g
From: Maciej Żenczykowski
(the parameters in question are mark and flow_flags)
Reviewed-by: David Ahern
Signed-off-by: Maciej Żenczykowski
---
include/net/route.h | 2 +-
net/ipv4/ah4.c | 2 +-
net/ipv4/esp4.c | 2 +-
net/ipv4/icmp.c
From: Daniel Borkmann
Date: Tue, 25 Sep 2018 22:43:43 +0200
> The following pull-request contains BPF updates for your *net-next*
> tree.
Pulled, there was a minor merge conflict. Please double check my work.
Thanks.
From: Vakul Garg
Date: Wed, 26 Sep 2018 01:54:25 +
> I don't find this patch and one other ("tls: Fixed a memory leak
> during socket close") in linux-net-next. Could you please kindly
> check? Regards.
After applying I didn't push out and instead I started a test build,
closed my laptop, di
From: Roopa Prabhu
Date: Tue, 25 Sep 2018 14:39:14 -0700
> From: Roopa Prabhu
>
> Fixes: ed842faeb2bd ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports")
> Signed-off-by: Roopa Prabhu
Applied.
From: Hauke Mehrtens
Date: Tue, 25 Sep 2018 21:55:33 +0200
> The driver uses devm_ioremap_resource() which is only available when
> CONFIG_HAS_IOMEM is set, make the driver depend on this config option.
> User mode Linux does not have CONFIG_HAS_IOMEM set and the driver was
> failing on this arch
From: Jeff Kirsher
Date: Tue, 25 Sep 2018 13:19:54 -0700
> This series contains updates to i40e and xsk.
...
> The following are changes since commit
> bd6207202db8974ca3d3183ca0d5611d45b2973c:
> net: macb: Clean 64b dma addresses if they are not detected
> and are available in the git reposi
From: Vlad Buslov
Date: Mon, 24 Sep 2018 19:18:32 +0300
...
> The goal of this change is to refactor tcf_block_find() and its
> dependencies to allow concurrent execution:
> - Extend Qdisc API with rcu to lookup and take reference to Qdisc
> without relying on rtnl lock.
> - Extend tcf_block w
On Tue, Sep 25, 2018 at 7:25 PM Eric Dumazet wrote:
>
> On Tue, Sep 25, 2018 at 7:15 PM Michael Chan
> wrote:
> >
> > On Tue, Sep 25, 2018 at 4:11 PM Michael Chan
> > wrote:
> > >
> > > On Tue, Sep 25, 2018 at 3:15 PM Eric Dumazet
> > > wrote:
> > >
> > > >
> > > > It seems bnx2 should have
On 09/25/2018 05:41 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> (fix documentation and sysctl access to treat it as such)
>
> Signed-off-by: Maciej Żenczykowski
> ---
While we are at it, we probably should add sane limits,
given tcp_mtu_check_reprobe() does :
u32 interva
On 09/24/2018 05:57 AM, Yafang Shao wrote:
> After sk_state exposed, we can get in which state this retransmission
> occurs. That could give us more detail for dignostic.
> For example, if this retransmission occurs in SYN_SENT state, it may
> also indicates that the syn packet may be dropped on
When add vxlan ttl inherit support, I forgot to fill it when dump
vlxan info. Fix it now.
Fixes: 72f6d71e491e6 ("vxlan: add ttl inherit support")
Signed-off-by: Hangbin Liu
---
drivers/net/vxlan.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
in
On Tue, Sep 25, 2018 at 7:15 PM Michael Chan wrote:
>
> On Tue, Sep 25, 2018 at 4:11 PM Michael Chan
> wrote:
> >
> > On Tue, Sep 25, 2018 at 3:15 PM Eric Dumazet wrote:
> >
> > >
> > > It seems bnx2 should have a similar issue ?
> > >
> >
> > Yes, I think so. The MSIX mode in bnx2 is also aut
On Tue, Sep 25, 2018 at 4:11 PM Michael Chan wrote:
>
> On Tue, Sep 25, 2018 at 3:15 PM Eric Dumazet wrote:
>
> >
> > It seems bnx2 should have a similar issue ?
> >
>
> Yes, I think so. The MSIX mode in bnx2 is also auto-masking, meaning
> that MSIX will only assert once after it is ARMed. If
> -Original Message-
> From: David Miller
> Sent: Tuesday, September 25, 2018 11:14 PM
> To: Vakul Garg
> Cc: netdev@vger.kernel.org; bor...@mellanox.com;
> avia...@mellanox.com; davejwat...@fb.com; doro...@fb.com
> Subject: Re: [PATCH net-next] tls: Fix socket mem accounting error und
On 9/25/18 6:41 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
A summary here of which 2 parameters are always 0 would be nice.
>
> Signed-off-by: Maciej Żenczykowski
> ---
> include/net/route.h | 3 +--
> net/ipv4/ah4.c| 2 +-
> net/ipv4/esp4.c | 2 +-
On 9/25/18 6:41 PM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
A summary here of which 2 parameters are always 0 would be nice.
> Signed-off-by: Maciej Żenczykowski
> ---
> include/net/route.h | 2 +-
> net/ipv4/ah4.c | 2 +-
> net/ipv4/esp4.c
From: Maciej Żenczykowski
(fix documentation and sysctl access to treat it as such)
Signed-off-by: Maciej Żenczykowski
---
Documentation/networking/ip-sysctl.txt | 2 +-
net/ipv4/sysctl_net_ipv4.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentatio
From: Maciej Żenczykowski
Signed-off-by: Maciej Żenczykowski
---
include/net/route.h | 3 +--
net/ipv4/ah4.c| 2 +-
net/ipv4/esp4.c | 2 +-
net/ipv4/icmp.c | 2 +-
net/ipv4/ip_gre.c | 4 ++--
net/ipv4/ip_vti.c | 2 +-
net/ipv4/ipcomp.c
From: Maciej Żenczykowski
Signed-off-by: Maciej Żenczykowski
---
include/net/route.h | 2 +-
net/ipv4/ah4.c | 2 +-
net/ipv4/esp4.c | 2 +-
net/ipv4/icmp.c | 2 +-
net/ipv4/ip_gre.c | 2 +-
net/ipv4/ip_vti.c
> On Sep 24, 2018, at 8:30 AM, Eric Dumazet wrote:
>
> On Sun, Sep 23, 2018 at 10:04 PM David Miller wrote:
>>
>> Series applied, thanks Eric.
>
> Thanks David.
>
> Song, would you please this additional patch ?
>
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index
> 3219a2932
Thanks Michael!
This works well in my tests.
Reviewed-and-tested-by: Song Liu
> On Sep 25, 2018, at 2:31 PM, Michael Chan wrote:
>
> The current netpoll implementation in the bnxt_en driver has problems
> that may miss TX completion events. bnxt_poll_work() in effect is
> only handling at
On Tue, Sep 25, 2018 at 3:15 PM Eric Dumazet wrote:
>
> It seems bnx2 should have a similar issue ?
>
Yes, I think so. The MSIX mode in bnx2 is also auto-masking, meaning
that MSIX will only assert once after it is ARMed. If we return from
->poll() when budget of 0 is reached without ARMing, w
Print `bpftool net` output to stdout instead of stderr. Only errors
should be printed to stderr. Regular output should go to stdout and this
is what all other subcommands of bpftool do, including --json and
--pretty formats of `bpftool net` itself.
Fixes: commit f6f3bac08ff9 ("tools/bpf: bpftool:
On 09/25/2018 02:31 PM, Michael Chan wrote:
> The current netpoll implementation in the bnxt_en driver has problems
> that may miss TX completion events. bnxt_poll_work() in effect is
> only handling at most 1 TX packet before exiting. In addition,
> there may be in flight TX completions that
From: Roopa Prabhu
Fixes: ed842faeb2bd ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports")
Signed-off-by: Roopa Prabhu
---
net/bridge/br_arp_nd_proxy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_arp_nd_proxy.c b/net/bridge/br_arp_nd_proxy.c
index 2cf77
The current netpoll implementation in the bnxt_en driver has problems
that may miss TX completion events. bnxt_poll_work() in effect is
only handling at most 1 TX packet before exiting. In addition,
there may be in flight TX completions that ->poll() may miss even
after we fix bnxt_poll_work() to
Hello
i have been trying to contact you i have a transaction for you.
On Mon, Sep 24, 2018 at 1:08 PM Dave Jones wrote:
>
> Callers of bond_for_each_slave_rcu are expected to hold the rcu lock,
> otherwise a trace like below is shown
Interesting, netpoll_send_skb_on_dev() already assumes RCU read lock
when it calls rcu_dereference_bh()...
I wonder how it can't cat
From: Roopa Prabhu
Signed-off-by: Roopa Prabhu
---
ip/ipneigh.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ip/ipneigh.c b/ip/ipneigh.c
index a0af705..5747152 100644
--- a/ip/ipneigh.c
+++ b/ip/ipneigh.c
@@ -139,6 +139,8 @@ static int ipneigh_modify(int cmd, int flags, int argc,
char
On Tue, Sep 25, 2018 at 11:25 AM Song Liu wrote:
>
> Hi Michael,
>
> This may not be related. But I am looking at this:
>
> bnxt_poll_work() {
>
> while (1) {
>
> if (rx_pkts == budget)
> return
> }
> }
>
> With budget o
I have been trying to contact you
Hi David,
The following pull-request contains BPF updates for your *net-next* tree.
The main changes are:
1) Allow for RX stack hardening by implementing the kernel's flow
dissector in BPF. Idea was originally presented at netconf 2017 [0].
Quote from merge commit:
[...] Because of t
From: Mariusz Stachura
This resolves an issue where the VF link state was not being updated
when the PF is down or up, and the VF link state would always show
that it is running.
Signed-off-by: Mariusz Stachura
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/int
From: Patryk Małek
msglen parameter seems to be unused in several virtchnl function.
This patch removes it from signatures of those functions.
Signed-off-by: Patryk Małek
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
.../ethernet/intel/i40e/i40e_virtchnl_pf.c| 96 +++--
From: Patryk Małek
In order to slightly simplify the code use the variables for pf and hw
that are declared in i40e_set_mac function.
Signed-off-by: Patryk Małek
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 9 -
1 file changed
From: Mariusz Stachura
This patch cleans up promiscuous configuration when a VF reset occurs.
Previously the promiscuous mode settings were still there after the VF
driver removal.
Signed-off-by: Mariusz Stachura
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
.../ethernet/intel/i40
From: Björn Töpel
Outstanding Rx descriptors are temporarily stored on a stash/reuse
queue. When/if the HW rings comes up again, entries from the stash are
used to re-populate the ring.
The latter required some restructuring of the allocation scheme for
the AF_XDP zero-copy implementation. There
This series contains updates to i40e and xsk.
Mariusz fixes an issue where the VF link state was not being updated
properly when the PF is down or up. Also cleaned up the promiscuous
configuration during a VF reset.
Patryk simplifies the code a bit to use the variables for PF and HW that
are dec
From: Harshitha Ramamurthy
When we are trying to change VF settings, it is possible for 2 race
conditions to happen. One, when the VF is created but not yet enabled.
Second, the VF is enabled but the VSI is still not created or not yet
re-created in the VF reset flow.
This patch introduces a hel
From: Björn Töpel
When the zero-copy enabled XDP Tx ring is torn down, due to
configuration changes, outstanding frames on the hardware descriptor
ring are queued on the completion ring.
The completion ring has a back-pressure mechanism that will guarantee
that there is sufficient space on the r
From: Jakub Kicinski
XSK UMEM is strongly single producer single consumer so reuse of
frames is challenging. Add a simple "stash" of FILL packets to
reuse for drivers to optionally make use of. This is useful
when driver has to free (ndo_stop) or resize a ring with an active
AF_XDP ZC socket.
From: Sergey Nemov
When isup is false meaning that interface is going to shut down
set new speed to 0 to avoid double 'NIC Link is Down' messages.
Signed-off-by: Sergey Nemov
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 5 -
1 fil
From: Björn Töpel
When an AF_XDP UMEM is attached to any of the Rx rings, we disallow a
user to change the number of descriptors via e.g. "ethtool -G IFNAME".
Otherwise, the size of the stash/reuse queue can grow unbounded, which
would result in OOM or leaking userspace buffers.
Signed-off-by:
The driver uses devm_ioremap_resource() which is only available when
CONFIG_HAS_IOMEM is set, make the driver depend on this config option.
User mode Linux does not have CONFIG_HAS_IOMEM set and the driver was
failing on this architecture.
Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA dri
This patch wraps the dissector key and mask - that flower uses to
represent the matching side - in the flow_match structure.
To avoid a follow up patch that would edit the same LoCs in the drivers,
this patch also wraps this new flow match structure around the flow rule
object. This new structure
This patch updates drivers to use the new flow action infrastructure.
Signed-off-by: Pablo Neira Ayuso
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 78 +++
.../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 251 ++--
drivers/net/ethernet/mellanox/mlx5/core/en_t
Update this driver to use the flow_rule infrastructure, hence the same
code to populate hardware IR can be used from ethtool_rx_flow and the
cls_flower interfaces.
Signed-off-by: Pablo Neira Ayuso
---
drivers/net/dsa/bcm_sf2_cfp.c | 311 ++
1 file changed,
This patch adds new infrastructure that defines actions that you can
perform in existing network drivers. This infrastructure allows us to
avoid the direct dependency with the software TC action infrastructure.
Signed-off-by: Pablo Neira Ayuso
---
include/net/flow_dissector.h | 70 ++
This patch adds a function to translate the ethtool_rx_flow_spec
structure to the flow_rule representation.
This allows us to reuse code from the driver side given the flower and
the ethtool_rx_flow interface use the same representation.
Signed-off-by: Pablo Neira Ayuso
---
include/net/flow_dis
Now that drivers have been converted to use the flow action
infrastructure, remove this field from the tc_cls_flower_offload
structure.
Signed-off-by: Pablo Neira Ayuso
---
include/net/pkt_cls.h | 1 -
net/sched/cls_flower.c | 5 -
2 files changed, 6 deletions(-)
diff --git a/include/net/p
Provide a tc_cls_flower_stats structure that acts as container for
tc_cls_flower_offload, then restore stats on the TC actions. Hence
tcf_exts_stats_update() is not used from drivers.
Signed-off-by: Pablo Neira Ayuso
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 4 ++--
drivers/ne
These actions need to be added to support bcm sf2 features available
through the ethtool_rx_flow interface.
Signed-off-by: Pablo Neira Ayuso
---
include/net/flow_dissector.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
index 9
This implements TC action to flow_action translation from cls_flower.
Signed-off-by: Pablo Neira Ayuso
---
net/sched/cls_flower.c | 124 -
1 file changed, 123 insertions(+), 1 deletion(-)
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.
Hi,
This patchset spins over the existing kernel representation for network
driver offloads based on the existing cls_flower dissector use for the
rule matching side and the TC action infrastructure to represent the
action side.
The proposed object that represent rules looks like this:
s
Although the packet edit infrastructure allows an arbitrary number of
packet mangling in the same action, it is still possible to define a
rule with two or more packet edit instances. This would result in the
last packet mangling action being applied to the mlx5e driver.
This patch adds pedit_head
> On Sep 25, 2018, at 7:43 AM, Michael Chan wrote:
>
> On Tue, Sep 25, 2018 at 7:20 AM Eric Dumazet wrote:
>>
>> On Tue, Sep 25, 2018 at 7:02 AM Michael Chan
>> wrote:
>>>
>>> On Mon, Sep 24, 2018 at 2:18 PM Song Liu wrote:
> On Sep 24, 2018, at 2:05 PM, Eric Dumaze
Hi Joel,
Thanks, I am adding netdev mailing list here.
Yes, this command is supported for all Mellanox card. It is as per Mellanox
specification.
Regards
-Vijay
On 9/24/18, 5:30 PM, "Joel Stanley" wrote:
Hi Vijay,
On Tue, 25 Sep 2018 at 09:39, Vijay Khemka wrote:
>
> Thi
On Mon, Sep 24, 2018 at 9:23 AM Vlad Buslov wrote:
>
> Currently, all netlink protocol handlers for updating rules, actions and
> qdiscs are protected with single global rtnl lock which removes any
> possibility for parallelism. This patch set is a third step to remove
> rtnl lock dependency from
From: Vakul Garg
Date: Tue, 25 Sep 2018 20:21:51 +0530
> During socket close, if there is a open record with tx context, it needs
> to be be freed apart from freeing up plaintext and encrypted scatter
> lists. This patch frees up the open record if present in tx context.
>
> Also tls_free_both_s
From: Vakul Garg
Date: Tue, 25 Sep 2018 16:26:17 +0530
> Current async encryption implementation sometimes showed up socket
> memory accounting error during socket close. This results in kernel
> warning calltrace. The root cause of the problem is that socket var
> sk_forward_alloc gets corrupted
From: Heiner Kallweit
Date: Tue, 25 Sep 2018 07:55:36 +0200
> This series includes smaller improvements, nothing exciting.
Series applied.
From: Michal Simek
Date: Tue, 25 Sep 2018 08:32:50 +0200
> Clear ADDR64 dma bit in DMACFG register in case that HW_DMA_CAP_64B is
> not detected on 64bit system.
> The issue was observed when bootloader(u-boot) does not check macb
> feature at DCFG6 register (DAW64_OFFSET) and enabling 64bit dma
Hi Daniel,
On Tue, Sep 25, 2018 at 9:10 PM Andrew Lunn wrote:
>
> > I hope this this thread isn't too old to bring back to life. So it seems
> > that Harini found that m88e did not need this errata, and Cisco
> > previously found that Harini's patch fixed m88e1112, we included it
> > internal
On 25.09.2018 10:28, Michal Kubecek wrote:
> (I wrote my comment to v1 because I overlooked there is a v2 already;
> duplicating it here.)
>
> On Mon, Sep 24, 2018 at 09:58:59PM +0200, Heiner Kallweit wrote:
>> Add flag wol_enabled to struct net_device indicating whether
>> Wake-on-LAN is enabled.
On 9/25/18 9:26 AM, Mike Manning wrote:
> On 24/09/2018 23:44, David Ahern wrote:
>> On 9/24/18 10:13 AM, Mike Manning wrote:
>>> From: Robert Shearman
>>>
>>> There is no easy way currently for applications that want to receive
>>> packets in the default VRF to be isolated from packets arriving i
> I hope this this thread isn't too old to bring back to life. So it seems
> that Harini found that m88e did not need this errata, and Cisco
> previously found that Harini's patch fixed m88e1112, we included it
> internally for that reason
>
> Now I'm getting reports that this errata fixes iss
On 9/25/18 8:47 AM, Jiri Benc wrote:
> On Tue, 25 Sep 2018 11:49:10 +0200, Christian Brauner wrote:
>> So if people really want to hide this issue as much as we can then we
>> can play the guessing game. I could send a patch that roughly does the
>> following:
>>
>> if (nlmsg_len(cb->nlh) < sizeof(
On 09/24/2018 10:49 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> BPF flow dissectors are configured per network namespace.
> __skb_flow_dissect looks up the netns through dev_net(skb->dev).
>
> In some dissector paths skb->dev is NULL, such as for Unix sockets.
> In these cases fall
> I've added Gokul who reported the issue to me. Is it possible that Harini
> and Cisco have different m88e phys? Maybe there's an issue with how they
> are hooked up ?
Hi Daniel
The lower 4 bits of the ID registers normally indicate the revision of
the PHY. It might be worth checking if ever
On 24/09/2018 23:44, David Ahern wrote:
On 9/24/18 10:13 AM, Mike Manning wrote:
From: Robert Shearman
There is no easy way currently for applications that want to receive
packets in the default VRF to be isolated from packets arriving in
VRFs, which makes using VRF-unaware applications in a V
On 04/18/2017 07:04 AM, Andrew Lunn wrote:
On Tue, Apr 18, 2017 at 06:16:33AM -0700, Daniel Walker wrote:
Hi,
Cisco is using a Marvell 88E1112 phy. It seems to be fairly similar
to the 88E which Harini added a fix for.
Hi Daniel
If you look at Marvell reference drive, DSDT, they are act
On Mon, 24 Sep 2018 18:35:55 +0200, Björn Töpel wrote:
> + if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)
> + return -EINVAL;
> +
> + if (adapter->flags & IXGBE_FLAG_DCB_ENABLED)
> + return -EINVAL;
Hm, should you add UMEM checks to all the places these may get
enab
This contains two formally verified C implementations of the Curve25519
scalar multiplication function, one for 32-bit systems, and one for
64-bit systems whose compiler supports efficient 128-bit integer types.
Not only are these implementations formally verified, but they are also
the fastest ava
During socket close, if there is a open record with tx context, it needs
to be be freed apart from freeing up plaintext and encrypted scatter
lists. This patch frees up the open record if present in tx context.
Also tls_free_both_sg() has been renamed to tls_free_open_rec() to
indicate that the fr
On Tue, 25 Sep 2018 11:49:10 +0200, Christian Brauner wrote:
> So if people really want to hide this issue as much as we can then we
> can play the guessing game. I could send a patch that roughly does the
> following:
>
> if (nlmsg_len(cb->nlh) < sizeof(struct ifinfomsg))
> guessed_header
On Tue, Sep 25, 2018 at 7:20 AM Eric Dumazet wrote:
>
> On Tue, Sep 25, 2018 at 7:02 AM Michael Chan
> wrote:
> >
> > On Mon, Sep 24, 2018 at 2:18 PM Song Liu wrote:
> > >
> > >
> > >
> > > > On Sep 24, 2018, at 2:05 PM, Eric Dumazet wrote:
> > > >
> > > >>
> > > >> Interesting, maybe a bnxt s
This XDP selftest also contain a small TC-bpf component. It provoke
the generic-XDP bug fixed in previous commit.
The selftest itself shows how to do VLAN manipulation from XDP and TC.
The test demonstrate how XDP ingress can remove a VLAN tag, and how TC
egress can add back a VLAN tag.
This use-
The helper bpf_skb_vlan_push is needed by next patch, and the helper
bpf_skb_vlan_pop is added for completeness, regarding VLAN helpers.
Signed-off-by: Jesper Dangaard Brouer
---
tools/testing/selftests/bpf/bpf_helpers.h |4
1 file changed, 4 insertions(+)
diff --git a/tools/testing/se
XDP can modify (and resize) the Ethernet header in the packet.
There is a bug in generic-XDP, because skb->protocol and skb->pkt_type
are setup before reaching (netif_receive_)generic_xdp.
This bug was hit when XDP were popping VLAN headers (changing
eth->h_proto), as skb->protocol still contains
While implementing PoC building blocks for eBPF code XDP+TC that can
manipulate VLANs headers, I discovered a bug in generic-XDP.
The fix should be backported to stable kernels. Even-though
generic-XDP were introduced in v4.12, I think the bug is not exposed
until v4.14 in the mentined fixes comm
On Tue, Sep 25, 2018 at 7:02 AM Michael Chan wrote:
>
> On Mon, Sep 24, 2018 at 2:18 PM Song Liu wrote:
> >
> >
> >
> > > On Sep 24, 2018, at 2:05 PM, Eric Dumazet wrote:
> > >
> > >>
> > >> Interesting, maybe a bnxt specific issue.
> > >>
> > >> It seems their model is to process TX/RX notifica
On Tue, 25 Sep 2018 09:44:41 +0530, Vasundhara Volam wrote:
> On Mon, Sep 24, 2018 at 10:11 PM Jakub Kicinski
> wrote:
> >
> > On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote:
> > > This patchset adds support for 3 generic and 1 driver-specific devlink
> > > parameters. Add documentat
On Tue, 25 Sep 2018 09:37:20 +0530, Vasundhara Volam wrote:
> > Why duplicate the description of the generic parameters?
> Not all generic parameters are used by all drivers. So, I want to add
> information about
> type and configuration mode about generic parameters used by bnxt_en driver.
> I c
On Mon, Sep 24, 2018 at 2:18 PM Song Liu wrote:
>
>
>
> > On Sep 24, 2018, at 2:05 PM, Eric Dumazet wrote:
> >
> >>
> >> Interesting, maybe a bnxt specific issue.
> >>
> >> It seems their model is to process TX/RX notification in the same queue,
> >> they throw away RX events if budget == 0
> >>
On 09/25/2018 02:46 PM, Jann Horn wrote:
> Hi!
>
> Per the policy at Documentation/networking/netdev-FAQ.rst, I'm sending
> this to netdev@ and davem, rather than stable@; with a CC to security@
> because I believe that this is a security process issue.
>
> Upstream commit dd066823db2ac4e22f721ec
On Tue, 25 Sep 2018 14:34:08 +0200
Christian Brauner wrote:
> On Tue, Sep 25, 2018, 14:07 Stephen Hemminger
> wrote:
>
> > On Tue, 25 Sep 2018 11:49:10 +0200
> > Christian Brauner wrote:
> >
> > > On Mon, Sep 24, 2018 at 09:19:06PM -0600, David Ahern wrote:
> > > > On top of net-next I am
make check from top level Makefile defines several flags which break
building generate_nlmsg:
$ make check
make -C tools
gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations
-Wold-style-definition -Wformat=2 -O2 -I../include -I../include/uapi
-DRESOLVE_HOSTNAMES -DLIBDIR=\
Hi!
Per the policy at Documentation/networking/netdev-FAQ.rst, I'm sending
this to netdev@ and davem, rather than stable@; with a CC to security@
because I believe that this is a security process issue.
Upstream commit dd066823db2ac4e22f721ec85190817b58059a54
("bpf/verifier: disallow pointer subt
On 9/16/2018 10:57 PM, Andrew Lunn wrote:
Why is this going under iproute rather than using one of the existing sensor
API's.
For example Intel NIC's have thermal sensors etc.
Hi Stephen
These are not that sort of sensors. This is part of the naming problem
here. It is not really to do wit
On Tue, 25 Sep 2018 11:49:10 +0200
Christian Brauner wrote:
> On Mon, Sep 24, 2018 at 09:19:06PM -0600, David Ahern wrote:
> > On top of net-next I am see a dmesg error:
> >
> > netlink: 16 bytes leftover after parsing attributes in process `ip'.
> >
> > I traced it to address lists and commit:
1 - 100 of 112 matches
Mail list logo
