Re: [PATCH v2 net] net: aquantia: memory corruption on jumbo frames

2018-09-23 Thread David Miller
From: Igor Russkikh Date: Tue, 18 Sep 2018 11:28:55 +0300 > >>> Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code") >>> >>> Reported-by: Friedemann Gerold >>> Reported-by: Michael Rauch >>> Signed-off-by: Friedemann Gerold >>> Tested-by: Nikita Danilov >>> Signed-off-by: I

[PATCH v2 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter.

2018-09-23 Thread Vasundhara Volam
This patch adds following driver-specific permanent mode boolean parameter. gre_ver_check - Generic Routing Encapsulation(GRE) version check will be enabled in the device. If disabled, device skips version checking for GRE packets. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/n

[PATCH v2 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter

2018-09-23 Thread Vasundhara Volam
This patch adds support for ignore_ari generic permanent mode devlink parameter. This parameter is disabled by default. It can be enabled using devlink param commands. ignore_ari - If enabled, device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same

[PATCH v2 net-next 1/9] devlink: Add generic parameter ignore_ari

2018-09-23 Thread Vasundhara Volam
ignore_ari - Device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same number of partitions when platform does not support ARI capability. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/cor

[PATCH v2 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max

2018-09-23 Thread Vasundhara Volam
msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device which is applicable per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/

[PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

2018-09-23 Thread Vasundhara Volam
This patch adds a new file to add information about configuration parameters that are supported by bnxt_en driver via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networking

[PATCH v2 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt

2018-09-23 Thread Vasundhara Volam
This patch adds a new file to add information about some of the generic configuration parameters set via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networking/devlink-para

[PATCH v2 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min

2018-09-23 Thread Vasundhara Volam
msix_vec_per_pf_min - This param sets the number of minimal MSIX vectors required for the device initialization. This value is set in the device which limits MSIX vectors per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core/devlin

[PATCH v2 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params.

2018-09-23 Thread Vasundhara Volam
This patch adds support for following generic permanent mode devlink parameters. They can be modified using devlink param commands. msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device whic

[PATCH v2 net-next 0/9] bnxt_en: devlink param updates

2018-09-23 Thread Vasundhara Volam
This patchset adds support for 3 generic and 1 driver-specific devlink parameters. Add documentation for these configuration parameters. Also, this patchset adds support to return proper error code if HWRM_NVM_GET/SET_VARIABLE commands return error code HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED. v1->v

[PATCH v2 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED

2018-09-23 Thread Vasundhara Volam
Return proper error code when Firmware returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE commands. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --g

Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers

2018-09-23 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Sep 2018 15:27:37 -0700 > As diagnosed by Song Liu, ndo_poll_controller() can > be very dangerous on loaded hosts, since the cpu > calling ndo_poll_controller() might steal all NAPI > contexts (for all RX/TX queues of the NIC). > > This capture, showing one ksoft

Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Ido Schimmel
On Mon, Sep 24, 2018 at 12:04:17AM +0200, Andrew Lunn wrote: > On Mon, Sep 24, 2018 at 12:51:00AM +0300, Ido Schimmel wrote: > > On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote: > > > > Therefore tweak the check to accept any FW version that is: > > > > > > > > - on the same branch as

Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Andrew Lunn
On Mon, Sep 24, 2018 at 12:51:00AM +0300, Ido Schimmel wrote: > On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote: > > > Therefore tweak the check to accept any FW version that is: > > > > > > - on the same branch as the preferred version, and > > > - the same as or newer than the prefer

Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Ido Schimmel
On Sun, Sep 23, 2018 at 10:58:09PM +0200, Andrew Lunn wrote: > > Therefore tweak the check to accept any FW version that is: > > > > - on the same branch as the preferred version, and > > - the same as or newer than the preferred version. > > Hi Ido > > Do you print this information out? If the

[net-next:master 13/221] drivers/net//ethernet/ni/nixge.c:145:2: note: in expansion of macro 'nixge_hw_dma_bd_set_addr'

2018-09-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 12ba7e1045521ec9f251c93ae0a6735cc3f42337 commit: 7e8d5755be0e6c92d3b86a85e54c6a550b1910c5 [13/221] net: nixge: Add support for 64-bit platforms config: i386-randconfig-x075-09240403 (attached as .config) com

Re: [PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Andrew Lunn
> Therefore tweak the check to accept any FW version that is: > > - on the same branch as the preferred version, and > - the same as or newer than the preferred version. Hi Ido Do you print this information out? If the check fails, it would be useful to know what the minimal version is.

Syrian Rescue

2018-09-23 Thread Syrian Rescue
Dear Sir/Madam, My name is Rybak Ahmed from Syria. I am a miner and i wish to introduce my Gold/Diamonds funds which I and my partner sold. Because of the constant war going on in our country my partner and his family are all dead.Hence i take this upon myself to find trustworthy partners who

Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers

2018-09-23 Thread Eric Dumazet
On Sun, Sep 23, 2018 at 12:29 PM David Miller wrote: > > From: Eric Dumazet > Date: Fri, 21 Sep 2018 15:27:37 -0700 > > > As diagnosed by Song Liu, ndo_poll_controller() can > > be very dangerous on loaded hosts, since the cpu > > calling ndo_poll_controller() might steal all NAPI > > contexts (f

Re: [PATCH net v2] net: phy: fix WoL handling when suspending the PHY

2018-09-23 Thread Heiner Kallweit
On 23.09.2018 18:49, Florian Fainelli wrote: > > > On September 23, 2018 6:38:21 AM PDT, Heiner Kallweit > wrote: >> Actually there's nothing wrong with the two changes marked as "Fixes", >> they just revealed a problem which has been existing before. >> After having switched r8169 to phylib it

Re: [PATCH net 00/15] netpoll: avoid capture effects for NAPI drivers

2018-09-23 Thread David Miller
From: Eric Dumazet Date: Fri, 21 Sep 2018 15:27:37 -0700 > As diagnosed by Song Liu, ndo_poll_controller() can > be very dangerous on loaded hosts, since the cpu > calling ndo_poll_controller() might steal all NAPI > contexts (for all RX/TX queues of the NIC). > > This capture, showing one ksoft

Re: [PATCH net] devlink: double free in devlink_resource_fill()

2018-09-23 Thread Jiri Pirko
Fri, Sep 21, 2018 at 10:07:55AM CEST, dan.carpen...@oracle.com wrote: >Smatch reports that devlink_dpipe_send_and_alloc_skb() frees the skb >on error so this is a double free. We fixed a bunch of these bugs in >commit 7fe4d6dcbcb4 ("devlink: Remove redundant free on error path") but >we accidental

Re: [PATCH net] af_key: free SKBs under RCU protection

2018-09-23 Thread Eric Dumazet
On 09/20/2018 12:25 PM, stran...@codeaurora.org wrote: > Perhaps a cleaner solution here is to always clone the SKB in > pfkey_broadcast_one(). That will ensure that the two kfree_skb() calls > in pfkey_broadcast() will never be passed an SKB with sock_rfree() as > its destructor, and we can avo

Re: [PATCH net v2] net: phy: fix WoL handling when suspending the PHY

2018-09-23 Thread Florian Fainelli
On September 23, 2018 6:38:21 AM PDT, Heiner Kallweit wrote: >Actually there's nothing wrong with the two changes marked as "Fixes", >they just revealed a problem which has been existing before. >After having switched r8169 to phylib it was reported that WoL from >shutdown doesn't work any lon

[PATCH net-next] mlxsw: Make MLXSW_SP1_FWREV_MINOR a hard requirement

2018-09-23 Thread Ido Schimmel
From: Petr Machata Up until now, mlxsw tolerated firmware versions that weren't exactly matching the required version, if the branch number matched. That allowed the users to test various firmware versions as long as they were on the right branch. On the other hand, it made it impossible for mlx

Re: [PATCH RFT net-next 0/2] net: phy: Eliminate unnecessary soft

2018-09-23 Thread Clemens Gruber
Hi, On Tue, Sep 18, 2018 at 06:35:03PM -0700, Florian Fainelli wrote: > Hi all, > > This patch series eliminates unnecessary software resets of the PHY. > This should hopefully not break anybody's hardware; but I would > appreciate testing to make sure this is is the case. > > Sorry for this lon

[PATCH net v2] net: phy: fix WoL handling when suspending the PHY

2018-09-23 Thread Heiner Kallweit
Actually there's nothing wrong with the two changes marked as "Fixes", they just revealed a problem which has been existing before. After having switched r8169 to phylib it was reported that WoL from shutdown doesn't work any longer (WoL from suspend isn't affected). Reason is that during shutdown

Re: [PATCH net v2] net: phy: fix WoL handling when suspending the PHY

2018-09-23 Thread Heiner Kallweit
Sorry, this patch was accidentally sent as reply. On 23.09.2018 15:33, Heiner Kallweit wrote: > Actually there's nothing wrong with the two changes marked as "Fixes", > they just revealed a problem which has been existing before. > After having switched r8169 to phylib it was reported that WoL fro

[PATCH net v2] net: phy: fix WoL handling when suspending the PHY

2018-09-23 Thread Heiner Kallweit
Actually there's nothing wrong with the two changes marked as "Fixes", they just revealed a problem which has been existing before. After having switched r8169 to phylib it was reported that WoL from shutdown doesn't work any longer (WoL from suspend isn't affected). Reason is that during shutdown

Re: [PATCH net-next 1/5] net: allow binding socket in a VRF when there's an unbound socket

2018-09-23 Thread kbuild test robot
Hi Robert, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Mike-Manning/vrf-allow-simultaneous-service-instances-in-default-and-other-VRFs/20180923-162308 config: i386-randconfig-x0-09231642

Re: [PATCH net-next 1/5] net: allow binding socket in a VRF when there's an unbound socket

2018-09-23 Thread kbuild test robot
Hi Robert, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Mike-Manning/vrf-allow-simultaneous-service-instances-in-default-and-other-VRFs/20180923-162308 config: x86_64-randconfig-x004-201838

[PATCH] iavh: fix a typo

2018-09-23 Thread Rami Rosen
This trivial patch fixes a typo in iavf.h. Signed-off-by: Rami Rosen --- drivers/net/ethernet/intel/iavf/iavf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h index a512f7521841..272d76b733aa 10