From: Intiyaz Basha
Control packets are processed in tasklet when interface is down and in
NAPI when interface is up. So tasklet can be disabled when interface up
and re-enabled when interface is down.
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
dr
On Fri, Sep 07, 2018 at 11:10:55PM +0200, Wolfgang Walter wrote:
> Hello Steffen,
>
> in one of your emails to Thomas you wrote:
> > xfrm_lookup+0x2a is at the very beginning of xfrm_lookup(), here we
> > find:
> >
> > u16 family = dst_orig->ops->family;
> >
> > ops has an offset of 32 bytes (20
From: Intiyaz Basha
With the changes in patch 1 and 2, droq lock is not required.
So removing droq lock.
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
.../net/ethernet/cavium/liquidio/octeon_device.c | 4 ---
drivers/net/ethernet/cavium/liquidio/o
After system suspend, sometimes the r8169 doesn't work when ethernet
cable gets pluggued.
This issue happens because rtl_reset_work() doesn't get called from
rtl8169_runtime_resume(), after system suspend.
In rtl_task(), RTL_FLAG_TASK_* only gets cleared if this condition is
met:
if (!netif_runni
From: Intiyaz Basha
Removed oom task unconditional rescheduling every 250ms and created per
queue oom work queue for refilling buffers.
The oom task refills only if the available descriptors is fallen to 64.
There will be no packets coming in after hitting this level. So NAPI will
not run until
From: Intiyaz Basha
Series of patches for removing droq lock from Rx Path.
Intiyaz Basha (3):
liquidio: Disabling tasklet when NAPI is active
liquidio: Per queue oom work queue
liquidio: Removed droq lock
drivers/net/ethernet/cavium/liquidio/lio_core.c| 77 +++--
drivers/net
On 2018年09月10日 06:44, Willem de Bruijn wrote:
From: Willem de Bruijn
Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers.
Interrupt moderation is currently not supported, so these accept and
display the default settings of 0 usec and 1 frame.
Toggle tx napi through a bit in
On 2018年09月10日 07:07, Willem de Bruijn wrote:
On Wed, Aug 29, 2018 at 9:01 AM Willem de Bruijn
wrote:
On Wed, Aug 29, 2018 at 3:56 AM Jason Wang wrote:
On 2018年08月29日 03:57, Willem de Bruijn wrote:
On Mon, Jul 30, 2018 at 2:06 AM Jason Wang wrote:
On 2018年07月25日 08:17, Jon Olson wrot
Since 4.19-rc1 (up to and including 4.19-rc3) there is now a problem
with the r8169 network interface when resuming from suspend - the
negotiated network speed after resume is only 10Mbit/s half-duplex.
There is no problem with 4.18.y, and when booting into 4.19-rc3 from
power-on the full 1000Mbit
From: Willem de Bruijn
Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers.
Interrupt moderation is currently not supported, so these accept and
display the default settings of 0 usec and 1 frame.
Toggle tx napi through a bit in tx-frames. So as to not interfere
with possible fu
From: Sergei Shtylyov
Date: Sun, 9 Sep 2018 12:45:50 +0300
> Hello!
>
> On 9/8/2018 11:11 PM, David Miller wrote:
>
>> It documents what is happening, and eliminates the spurious list
>> pointer poisoning.
>> In the long term, in order to get proper list head debugging, we
>> might want to use
On Wed, Aug 29, 2018 at 9:01 AM Willem de Bruijn
wrote:
>
> On Wed, Aug 29, 2018 at 3:56 AM Jason Wang wrote:
> >
> >
> >
> > On 2018年08月29日 03:57, Willem de Bruijn wrote:
> > > On Mon, Jul 30, 2018 at 2:06 AM Jason Wang wrote:
> > >>
> > >>
> > >> On 2018年07月25日 08:17, Jon Olson wrote:
> > >>>
after reconsider, I think we can remove this check directly, since
rht_grow_above_max() will be called to check the overflow again in
rhashtable_insert_one.
and atomic_read(&table->hash.nelems) always compares with unsigned
value, will force to switch unsigned, so the hash.nelems overflows can
be
From: Willem de Bruijn
Convert pr_info to net_info_ratelimited to limit the total number of
synflood warnings.
Commit 946cedccbd73 ("tcp: Change possible SYN flooding messages")
rate limits synflood warnings to one per listener.
Workloads that open many listener sockets can still see a high rat
From: Eric Dumazet
Date: Sun, 9 Sep 2018 13:51:21 -0700
>> Hi Eric,
>> Thank you for review!
>>
>> I think netfilter side ipv6 code change is needed
>> because netfilter ipv6 defrag routine also set fp->ip_defrag_offset value
>> so that fp->sk will not be NULL.
>> And I think these crash in ip_do
On Sun, Sep 09, 2018 at 09:11:46PM +0300, Arseny Maslennikov wrote:
> On Fri, Sep 07, 2018 at 09:43:59AM -0600, Jason Gunthorpe wrote:
> > On Thu, Sep 06, 2018 at 05:51:12PM +0300, Arseny Maslennikov wrote:
> > > Some tools may currently be using only the deprecated attribute;
> > > let's print an
> Hi Eric,
> Thank you for review!
>
> I think netfilter side ipv6 code change is needed
> because netfilter ipv6 defrag routine also set fp->ip_defrag_offset value
> so that fp->sk will not be NULL.
> And I think these crash in ip_do_fragment() and ip6_fragment() are
> actually same bug.
>
Right
This adds the DSA driver for the GSWIP Switch found in the VRX200 SoC.
This switch is integrated in the DSL SoC, this SoC uses a GSWIP version
2.1, there are other SoCs using different versions of this IP block, but
this driver was only tested with the version found in the VRX200.
Currently only th
This adds the binding for the GSWIP (Gigabit switch) core found in the
xrx200 / VR9 Lantiq / Intel SoC.
This part takes care of the switch, MDIO bus, and loading the FW into
the embedded GPHYs.
Signed-off-by: Hauke Mehrtens
Cc: devicet...@vger.kernel.org
---
.../devicetree/bindings/net/dsa/lant
When a DMA channel is opened the IRQ should not get activated
automatically, this allows it to pull data out manually without the help
of interrupts. This is needed for a workaround in the vrx200 Ethernet
driver.
Signed-off-by: Hauke Mehrtens
Acked-by: Paul Burton
---
arch/mips/lantiq/xway/dma.
This handles the tag added by the PMAC on the VRX200 SoC line.
The GSWIP uses internally a GSWIP special tag which is located after the
Ethernet header. The PMAC which connects the GSWIP to the CPU converts
this special tag used by the GSWIP into the PMAC special tag which is
added in front of the
This adds the binding for the PMAC core between the CPU and the GSWIP
switch found on the xrx200 / VR9 Lantiq / Intel SoC.
Signed-off-by: Hauke Mehrtens
Cc: devicet...@vger.kernel.org
---
.../devicetree/bindings/net/lantiq,xrx200-net.txt | 21 +
1 file changed, 21 insertion
This drives the PMAC between the GSWIP Switch and the CPU in the VRX200
SoC. This is currently only the very basic version of the Ethernet
driver.
When the DMA channel is activated we receive some packets which were
send to the SoC while it was still in U-Boot, these packets have the
wrong header.
This adds basic support for the GSWIP (Gigabit Switch) found in the
VRX200 SoC.
There are different versions of this IP core used in different SoCs, but
this driver was currently only tested on the VRX200 SoC line, for other
SoCs this driver probably need some adoptions to work.
I also plan to add
dma_zalloc_coherent() now crashes if no dev pointer is given.
Add a dev pointer to the ltq_dma_channel structure and fill it in the
driver using it.
This fixes a bug introduced in kernel 4.19.
Signed-off-by: Hauke Mehrtens
---
no changes since v1.
This should go into kernel 4.19 and I have som
2018-09-10 3:24 GMT+09:00 Eric Dumazet :
> On Sun, Sep 9, 2018 at 10:47 AM Taehee Yoo wrote:
>>
>> A kernel crash occurrs when defragmented packet is fragmented
>> in ip_do_fragment().
>> In defragment routine, skb_orphan() is called and
>> skb->ip_defrag_offset is set. but skb->sk and
>> skb->ip_
On Sun, Sep 9, 2018 at 10:47 AM Taehee Yoo wrote:
>
> A kernel crash occurrs when defragmented packet is fragmented
> in ip_do_fragment().
> In defragment routine, skb_orphan() is called and
> skb->ip_defrag_offset is set. but skb->sk and
> skb->ip_defrag_offset are same union member. so that
> fr
On Fri, Sep 07, 2018 at 09:43:59AM -0600, Jason Gunthorpe wrote:
> On Thu, Sep 06, 2018 at 05:51:12PM +0300, Arseny Maslennikov wrote:
> > Some tools may currently be using only the deprecated attribute;
> > let's print an elaborate and clear deprecation notice to kmsg.
> >
> > To do that, we have
A kernel crash occurrs when defragmented packet is fragmented
in ip_do_fragment().
In defragment routine, skb_orphan() is called and
skb->ip_defrag_offset is set. but skb->sk and
skb->ip_defrag_offset are same union member. so that
frag->sk is not NULL.
Hence crash occurrs in skb->sk check routine
On Sun, Sep 9, 2018 at 10:32 AM James Bottomley
wrote:
>
> On Mon, 2018-08-13 at 12:10 -0400, Stéphane Graber wrote:
> > Details can be found here:
> >
> > https://discuss.linuxcontainers.org/t/containers-micro-conference-a
> > t-linux-plumbers-2018/2417
>
> This website was giving a 503 error w
From:
Date: Sun, 9 Sep 2018 08:15:19 +
> From: Netanel Belgazal
>
> Netanel Belgazal (7):
> net: ena: fix surprise unplug NULL dereference kernel crash
> net: ena: fix driver when PAGE_SIZE == 64kB
> net: ena: fix device destruction to gracefully free resources
> net: ena: fix poten
On Sun, Sep 09, 2018 at 03:15:38PM +0100, Al Viro wrote:
> Umm... Interesting - TCA_U32_SEL is not the only thing that
> gets ignored there; TCA_U32_MARK gets the same treatment.
> And then there's a lovely question what to do with n->pf -
> it's an array of n->sel.nkeys counters, and apparently
From: Vakul Garg
Date: Thu, 6 Sep 2018 21:41:40 +0530
> tls_sw_sendmsg() allocates plaintext and encrypted SG entries using
> function sk_alloc_sg(). In case the number of SG entries hit
> MAX_SKB_FRAGS, sk_alloc_sg() returns -ENOSPC and sets the variable for
> current SG index to '0'. This lead
Hei Bjørn,
Thanks for the feedback!
On Sat, Sep 8, 2018 at 4:12 PM Bjørn Mork wrote:
> That's annoying, but hardly surprising. They obviously try to make life
> as hard as possible for the drivers. I wonder what the Windows drivers
> do here, if there are any? Or are these modules only used in
On Sun, Sep 09, 2018 at 08:58:50AM -0400, Jamal Hadi Salim wrote:
>
> Since you have the momentum here: i noticed something
> unusual while i was trying to craft a test that would
> vet some of your changes. This has nothing to do with
> your changes, same happens on my stock debian laptop
> with
Since you have the momentum here: i noticed something
unusual while i was trying to craft a test that would
vet some of your changes. This has nothing to do with
your changes, same happens on my stock debian laptop
with kernel:
4.17.0-0.bpo.3-amd64 #1 SMP Debian 4.17.17-1~bpo9+1 (2018-08-27)
Lo
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
Now that we have the knode count, we can instantly check if
any hnodes are non-empty. And that kills the check for extra
references to root hnode - those could happen only if there was
a knode to carry such a link.
Signed-off-by: Al Viro
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
allows to simplify u32_delete() considerably
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
the only thing we used ht for was ht->tp_c and callers can get that
without going through ->tp_c at all; start with lifting that into
the callers, next commits will massage those, eventually removing
->tp_c altogether.
Signed-off-by: Al Vir
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
* calculate key *once*, not for each hash chain element
* let tc_u_hash() return the pointer to chain head rather than index -
callers are cleaner that way.
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
unused
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
not used anymore
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
Signed-off-by: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
> Signed-off-by: Al Viro
Test is by hacking user space iproute2 to allow
sending a divisor > 255
Tested-by: Jamal Hadi Salim
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
Acked-by: Jamal Hadi Salim
cheers,
jamal
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
Operation makes no sense. Nothing will actually break if we do so
(depth limit in u32_classify() will prevent infinite loops), but
according to maintainers it's best prohibited outright.
NOTE: doing so guarantees that u32_destroy() will tr
On 2018-09-08 9:31 p.m., Al Viro wrote:
From: Al Viro
cls_u32.c misuses refcounts for struct tc_u_hnode - it counts references via
->hlist and via ->tp_root together. u32_destroy() drops the former and, in
case when there had been links, leaves the sucker on the list. As the result,
there's n
Hello!
On 9/8/2018 11:11 PM, David Miller wrote:
It documents what is happening, and eliminates the spurious list
pointer poisoning.
In the long term, in order to get proper list head debugging, we
might want to use the list poinson value as the indicator that
Poison?
an SKB is a single
From: Netanel Belgazal
When ena_destroy_device() is called from ena_suspend(), the device is
still reachable from the driver. Therefore, the driver can send a command
to the device to free all resources.
However, in all other cases of calling ena_destroy_device(), the device is
potentially in an
From: Netanel Belgazal
Netanel Belgazal (7):
net: ena: fix surprise unplug NULL dereference kernel crash
net: ena: fix driver when PAGE_SIZE == 64kB
net: ena: fix device destruction to gracefully free resources
net: ena: fix potential double ena_destroy_device()
net: ena: fix missing lo
From: Netanel Belgazal
ena_destroy_device() can potentially be called twice.
To avoid this, check that the device is running and
only then proceed destroying it.
Signed-off-by: Netanel Belgazal
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 5 +
1 file changed, 5 insertions(+)
diff --
From: Netanel Belgazal
Add READ_ONCE calls where necessary (for example when iterating
over a memory field that gets updated by the hardware).
Signed-off-by: Netanel Belgazal
---
drivers/net/ethernet/amazon/ena/ena_com.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
From: Netanel Belgazal
Added memory barriers where they were missing to support multiple
architectures, and removed redundant ones.
As part of removing the redundant memory barriers and improving
performance, we moved to more relaxed versions of memory barriers,
as well as to the more relaxed ve
From: Netanel Belgazal
The buffer length field in the ena rx descriptor is 16 bit, and the
current driver passes a full page in each ena rx descriptor.
When PAGE_SIZE equals 64kB or more, the buffer length field becomes
zero.
To solve this issue, limit the ena Rx descriptor to use 16kB even
when
From: Netanel Belgazal
acquire the rtnl_lock during device destruction to avoid
using partially destroyed device.
ena_remove() shares almost the same logic as ena_destroy_device(),
so use ena_destroy_device() and avoid duplications.
Signed-off-by: Netanel Belgazal
---
drivers/net/ethernet/ama
From: Netanel Belgazal
Starting with driver version 1.5.0, in case of a surprise device
unplug, there is a race caused by invoking ena_destroy_device()
from two different places. As a result, the readless register might
be accessed after it was destroyed.
Signed-off-by: Netanel Belgazal
---
dr
58 matches
Mail list logo
