Re: [PATCH net-next 0/2] Full phylink support for mv88e6352

2018-09-02 Thread David Miller
From: Andrew Lunn Date: Sun, 2 Sep 2018 18:13:13 +0200 > These two patches implement full phylink support for the mv88e6352 > family, when using an SFP connected to its SERDES interface. This adds > interrupt support to the SERDES, so that we get interrupts on link > up/down, and then make calls

Re: [PATCH net-next 0/4] mlx5e IPoIB stats

2018-09-02 Thread David Miller
From: Tariq Toukan Date: Sun, 2 Sep 2018 22:12:06 +0300 > I am temporarily covering Saeed with the mlx5 submissions. Ok, thanks for letting me know. > This patchset by Feras contains statistics enhancements and NDO > implementation for the mlx5e IPoIB driver. > > Series generated against net-

[PATCH ipsec-next 2/2] xfrm: reset crypto_done when iterating over multiple input xfrms

2018-09-02 Thread Sowmini Varadhan
We only support one offloaded xfrm (we do not have devices that can handle more than one offload), so reset crypto_done in xfrm_input() when iterating over multiple transforms in xfrm_input, so that we can invoke the appropriate x->type->input for the non-offloaded transforms Signed-off-by: Sowm

[PATCH ipsec-next 1/2] xfrm: reset transport header back to network header after all input transforms ahave been applied

2018-09-02 Thread Sowmini Varadhan
A policy may have been set up with multiple transforms (e.g., ESP and ipcomp). In this situation, the ingress IPsec processing iterates in xfrm_input() and applies each transform in turn, processing the nexthdr to find any additional xfrm that may apply. This patch resets the transport header back

[PATCH ipsec-next 0/2] xfrm: bug fixes when processing multiple transforms

2018-09-02 Thread Sowmini Varadhan
This series contains bug fixes that were encountered when I set up a libreswan tunnel using the config below, which will set up an IPsec policy involving 2 tmpls. type=transport compress=yes esp=aes_gcm_c-128-null # offloaded to Niantic auto=start The non-offload test case uses

Re: [PATCH] uapi: Fix linux/rds.h userspace compilation errors.

2018-09-02 Thread David Miller
From: Vinson Lee Date: Sat, 1 Sep 2018 21:20:27 + > Include linux/in6.h for struct in6_addr. ... > Fixes: b7ff8b1036f0 ("rds: Extend RDS API for IPv6 support") > Signed-off-by: Vinson Lee > Acked-by: Santosh Shilimkar Applied, thanks.

Re: pull-request: bpf 2018-09-02

2018-09-02 Thread David Miller
From: Daniel Borkmann Date: Sun, 2 Sep 2018 23:20:31 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix one remaining buggy offset override in sockmap's bpf_msg_pull_data() >when linearizing multiple scatterlist elements, from

pull-request: bpf 2018-09-02

2018-09-02 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix one remaining buggy offset override in sockmap's bpf_msg_pull_data() when linearizing multiple scatterlist elements, from Tushar. 2) Fix BPF sockmap's misuse of ULP when a collision wi

Re: [PATCH net] net/ipv6: Only update MTU metric if it set

2018-09-02 Thread David Miller
From: dsah...@kernel.org Date: Thu, 30 Aug 2018 14:15:43 -0700 > From: David Ahern > > Jan reported a regression after an update to 4.18.5. In this case ipv6 > default route is setup by systemd-networkd based on data from an RA. The > RA contains an MTU of 1492 which is used when the route is fi

Re: [bpf-next 1/3] flow_dissector: implements flow dissector BPF hook

2018-09-02 Thread Daniel Borkmann
On 08/30/2018 08:22 PM, Petar Penkov wrote: > From: Petar Penkov > > Adds a hook for programs of type BPF_PROG_TYPE_FLOW_DISSECTOR and > attach type BPF_FLOW_DISSECTOR that is executed in the flow dissector > path. The BPF program is per-network namespace. > > Signed-off-by: Petar Penkov > Sign

Re: [PATCH net-next] net/sched: fix type of htb statistics

2018-09-02 Thread David Miller
From: Florent Fourcot Date: Thu, 30 Aug 2018 16:39:23 +0200 > tokens and ctokens are defined as s64 in htb_class structure, > and clamped to 32bits value during netlink dumps: > > cl->xstats.tokens = clamp_t(s64, PSCHED_NS2TICKS(cl->tokens), > INT_MIN, INT_MAX); > >

Re: [PATCH 1/2] dt-bindings: net: cpsw: Document cpsw-phy-sel usage but prefer phandle

2018-09-02 Thread David Miller
From: Tony Lindgren Date: Wed, 29 Aug 2018 08:00:23 -0700 > The current cpsw usage for cpsw-phy-sel is undocumented but is used for > all the boards using cpsw. And cpsw-phy-sel is not really a child of > the cpsw device, it lives in the system control module instead. > > Let's document the exis

Re: [PATCH 2/2] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel

2018-09-02 Thread David Miller
From: Tony Lindgren Date: Wed, 29 Aug 2018 08:00:24 -0700 > The cpsw-phy-sel device is not a child of the cpsw interconnect target > module. It lives in the system control module. > > Let's fix this issue by trying to use cpsw-phy-sel phandle first if it > exists and if not fall back to current

Re: [bpf PATCH v2] bpf: avoid misuse of psock when TCP_ULP_BPF collides with another ULP

2018-09-02 Thread Daniel Borkmann
On 08/31/2018 06:25 AM, John Fastabend wrote: > Currently we check sk_user_data is non NULL to determine if the sk > exists in a map. However, this is not sufficient to ensure the psock > or the ULP ops are not in use by another user, such as kcm or TLS. To > avoid this when adding a sock to a map

Re: [PATCH net] bpf: Fix bpf_msg_pull_data()

2018-09-02 Thread Daniel Borkmann
On 08/31/2018 11:45 PM, Tushar Dave wrote: > Helper bpf_msg_pull_data() mistakenly reuses variable 'offset' while > linearizing multiple scatterlist elements. Variable 'offset' is used > to find first starting scatterlist element > i.e. msg->data = sg_virt(&sg[first_sg]) + start - offset" > >

Re: [PATCH bpf-next] tools/bpf: bpftool, add xskmap in map types

2018-09-02 Thread Daniel Borkmann
On 08/31/2018 10:45 AM, Jakub Kicinski wrote: > On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote: >> When listed all maps, bpftool currently shows (null) for xskmap. >> Added xskmap type in map_type_name[] to show correct type. >> >> Signed-off-by: Prashant Bhole > > Acked-by: Jakub Kicin

Re: [PATCH net 0/2] igmp: fix two incorrect unsolicit report count issues

2018-09-02 Thread David Miller
From: Hangbin Liu Date: Wed, 29 Aug 2018 18:06:07 +0800 > Just like the subject, fix two minor igmp unsolicit report count issues. Series applied, thanks.

Re: [PATCH net-next v3] tcp: propagate gso_segs to the new skb built in tcp collapse

2018-09-02 Thread Eric Dumazet
On 09/01/2018 05:21 AM, Yafang Shao wrote: > The gso_segs of the new built SKB in tcp collapse is inited to 0, > that makes us hard to know the accurate segments number of this new SKB. > We'd better propagate the gso_segs of the collapsed SKB to the new built > one, so when this SKB is dropped

[PATCH net-next 3/4] net/mlx5e: IPoIB, Add ndo stats support for IPoIB child devices

2018-09-02 Thread Tariq Toukan
From: Feras Daoud Expose RX and TX counters by implementing ndo_get_stats64 operation for child devices. Signed-off-by: Feras Daoud Signed-off-by: Saeed Mahameed Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib_vlan.c | 1 + 1 file changed, 1 insertion(+)

[PATCH net-next 1/4] net/mlx5e: IPoIB, Initialize max_opened_tc in mlx5i_init flow

2018-09-02 Thread Tariq Toukan
From: Feras Daoud Enhanced ipoib does not initialize max_opened_tc causing wrong ethtool statistics. As mlx5e_grp_sw_update_stats relies on this variable, without this change, the TX statistics will not be updated. Fixes: 05909babce53 ("net/mlx5e: Avoid reset netdev stats on configuration chang

[PATCH net-next 0/4] mlx5e IPoIB stats

2018-09-02 Thread Tariq Toukan
Hi Dave, I am temporarily covering Saeed with the mlx5 submissions. This patchset by Feras contains statistics enhancements and NDO implementation for the mlx5e IPoIB driver. Series generated against net-next commit: 2d5c28859839 net: bgmac: remove set but not used variable 'err' Thanks, Tariq.

[PATCH net-next 4/4] net/mlx5e: IPoIB, Use priv stats in completion rx flow

2018-09-02 Thread Tariq Toukan
From: Feras Daoud Since the RQs are shared between all pkey interfaces, the stats should be taken from where the per-ring stats are stored instead of the parent RQ. Fixes: 4c6c615e3f30 ("net/mlx5e: IPoIB, Add PKEY child interface nic profile") Signed-off-by: Feras Daoud Signed-off-by: Saeed Mah

[PATCH net-next 2/4] net/mlx5e: IPoIB, Add ndo stats support for IPoIB netdevices

2018-09-02 Thread Tariq Toukan
From: Feras Daoud Expose RX and TX counters by implementing ndo_get_stats64 operation for both parent devices. After this change, all the relevant statistics can be retrieved using ifconfig. Signed-off-by: Feras Daoud Signed-off-by: Saeed Mahameed Signed-off-by: Tariq Toukan --- .../net/ethe

Re: [PATCH RFC net-next 00/18] net: Improve route scalability via support for nexthop objects

2018-09-02 Thread David Miller
From: dsah...@kernel.org Date: Fri, 31 Aug 2018 17:49:35 -0700 > Examples > 1. Single path > $ ip nexthop add id 1 via 10.99.1.2 dev veth1 > $ ip route add 10.1.1.0/24 nhid 1 > > $ ip next ls > id 1 via 10.99.1.2 src 10.99.1.1 dev veth1 scope link > > $ ip ro ls > 10.1.1.

[PATCH net-next 03/12] net: phy: bcm63xx: Allow to be built with COMPILE_TEST

2018-09-02 Thread Andrew Lunn
There is nothing in this driver which prevents it to be compiled for other architectures. Add COMPILE_TEST so we get better compile test coverage. Signed-off-by: Andrew Lunn --- drivers/net/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/Kconfig b/

[PATCH net-next 01/12] net: phy: ste10Xp: Remove wrong SUPPORTED_Pause

2018-09-02 Thread Andrew Lunn
The PHY driver should not indicate that Pause is supported. It is upto the MAC drive enable it, if it supports Pause frames. So remove it from the ste10Xp driver. Signed-off-by: Andrew Lunn --- drivers/net/phy/ste10Xp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH net-next 00/12] Preparing for phylib limkmodes

2018-09-02 Thread Andrew Lunn
phylib currently makes us of a u32 bitmap for advertising, supported, and link partner capabilities. For a long time, this has been sufficient, for devices up to 1Gbps. With more MAC/PHY combinations now supporting speeds greater than 1Gbps, we have run out of bits. There is the need to replace thi

[PATCH net-next 10/12] net: ethernet: Add helper for set_pauseparam for Asym Pause

2018-09-02 Thread Andrew Lunn
ethtool can be used to enable/disable pause. Add a helper to configure the PHY when asym pause is supported. Signed-off-by: Andrew Lunn --- .../ethernet/apm/xgene/xgene_enet_ethtool.c | 26 ++--- drivers/net/ethernet/aurora/nb8800.c | 9 +--- drivers/net/ethernet/broadcom/tg3.c

[PATCH net-next 04/12] net: ethernet: Use phy_set_max_speed() to limit advertised speed

2018-09-02 Thread Andrew Lunn
Many Ethernet MAC drivers want to limit the PHY to only advertise a maximum speed of 100Mbs or 1Gbps. Rather than using a mask, make use of the helper function phy_set_max_speed(). Signed-off-by: Andrew Lunn --- drivers/net/ethernet/8390/ax88796.c | 4 +--- drivers/net/ethernet/ae

[PATCH net-next 08/12] net: ethernet: Add helper for MACs which support asym pause

2018-09-02 Thread Andrew Lunn
Rather than have the MAC drivers manipulate phydev members to indicate they support Asym Pause, add a helper function. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 4 ++-- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 4 +--- drivers/net/ethernet

[PATCH net-next 09/12] net: ethernet: Add helper for MACs which support pause

2018-09-02 Thread Andrew Lunn
Rather than have the MAC drivers manipulate phydev members, add a helper function for MACs supporting Pause, but not Asym Pause. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- drivers/net/ethernet/freescale/fec_main.c| 4 +--- drivers/net/phy/phy_device

[PATCH net-next 05/12] net: ethernet: genet: Fix speed selection

2018-09-02 Thread Andrew Lunn
The phy supported speed is being used to determine if the MAC should be configured to 100 or 1G. The masking logic is broken. Instead, look 1G supported speeds to enable 1G MAC support. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/broadcom/genet/bcmmii.c | 7 +++ 1 file changed, 3 ins

[PATCH net-next 12/12] net: ethernet: Add helper to determine if pause configuration is supported

2018-09-02 Thread Andrew Lunn
Rather than have MAC drivers open code the test, add a helper in phylib. This will help when we change the type of phydev->supported. Signed-off-by: Andrew Lunn --- .../ethernet/apm/xgene/xgene_enet_ethtool.c | 4 +--- drivers/net/ethernet/broadcom/tg3.c | 4 +--- .../ethernet/free

[PATCH net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-02 Thread Andrew Lunn
Some MAC hardware cannot support a subset of link modes. e.g. often 1Gbps Full duplex is supported, but Half duplex is not. Add a helper to remove such a link mode. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 6 +++--- drivers/net/ethernet/cadence/macb_main.c

[PATCH net-next 02/12] net: phy: et1011c: Remove incorrect missing 1000 Half

2018-09-02 Thread Andrew Lunn
The driver indicates it can do 10/100 full and half duplex, plus 1G Full. The datasheet indicates 1G half is also supported. So make use of the standard PHY_GBIT_FEATURES. It could be, this was added because there is a MAC which does not support 1G half. Bit this is the wrong place to enforce this

[PATCH net-next 11/12] net: ethernet: Add helper for set_pauseparam for Pause

2018-09-02 Thread Andrew Lunn
ethtool can be used to enable/disable pause. Add a helper to configure the PHY when Pause is supported. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 6 +- drivers/net/ethernet/freescale/fec_main.c| 8 +--- drivers/net/phy/phy_device.c

[PATCH net-next 06/12] net: ethernet: Fix up drivers masking pause support

2018-09-02 Thread Andrew Lunn
PHY drivers don't indicate they support pause. They expect MAC drivers to enable its support if the MAC has the needed hardware. Thus MAC drivers should not mask Pause support, but enable it. Change a few ANDs to ORs. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/broadcom/tg3.c

[PATCH net-next 2/2] net: dsa: mv88e6xxx: Add SERDES phydev_link_change for 6352

2018-09-02 Thread Andrew Lunn
The 6352 family has one SERDES interface, which can be used by either port 4 or port 5. Add interrupt support for the SERDES interface, and report when the link status changes. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 6 ++ drivers/net/dsa/mv88e6xxx/serdes.c | 105 ++

[PATCH net-next 0/2] Full phylink support for mv88e6352

2018-09-02 Thread Andrew Lunn
These two patches implement full phylink support for the mv88e6352 family, when using an SFP connected to its SERDES interface. This adds interrupt support to the SERDES, so that we get interrupts on link up/down, and then make calls phydev_link_change(). The first patch is a minor bug fix, which

[PATCH net-next 1/2] net: dsa: mv88e6xxx: Fix writing to a PHY page.

2018-09-02 Thread Andrew Lunn
After changing to the needed page, actually write the value to the register! Fixes: 09cb7dfd3f14 ("net: dsa: mv88e6xxx: describe PHY page and SerDes") Signed-off-by: Andrew Lunn --- It has been broken like this for over 2 years. So i don't think it has been important until now. So i've decided n

eBPF: verifier: back-edge

2018-09-02 Thread Sameeh Jubran
Hi all, I am trying to insert instructions into the bpf using the bof syscall, the instructions were generated using the following command line: clang -I ~/Builds/bpf_rss/iproute2/include -Wall -target bpf -O2 -emit-llvm -c upstream/qemu/hw/net/rss_tap_bpf_program.c -o - | llc -march=bpf -filetyp

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

2018-09-02 Thread Patrick Ruddy
Hi Roopa inline thx -pr On Fri, 2018-08-31 at 09:29 -0700, Roopa Prabhu wrote: > On Fri, Aug 31, 2018 at 4:20 AM, Patrick Ruddy > wrote: > > Some userspace applications need to know about IGMP joins from the kernel > > for 2 reasons > > 1. To allow the programming of multicast MAC filters in h

Re: [PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

2018-09-02 Thread Konstantin Khlebnikov
On 02.09.2018 12:29, Tariq Toukan wrote: On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote: XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. It seems not enough for RFS. All other drivers use toeplitz. Driver mlx4_en uses Toeplitz by default and warns if hash XOR is used together with

Re: [PATCH RFC] net/mlx5_en: switch to Toeplitz RSS hash by default

2018-09-02 Thread Tariq Toukan
On 31/08/2018 2:29 PM, Konstantin Khlebnikov wrote: XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits. It seems not enough for RFS. All other drivers use toeplitz. Driver mlx4_en uses Toeplitz by default and warns if hash XOR is used together with NETIF_F_RXHASH (enabled by default too):

Re: [PATCH net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-02 Thread Liran Alon
> On 1 Sep 2018, at 6:06, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/net_failover.c: In function 'net_failover_slave_unregister': > drivers/net/net_failover.c:598:35: warning: > variable 'primary_dev' set but not used [-Wunused-but-set-variable] > >