From: Thomas Falcon
Date: Thu, 30 Aug 2018 13:19:53 -0500
> Check the return codes of these functions and halt reset
> in case of failure. The driver will remain in a dormant state
> until the next reset event, when device initialization will be
> re-attempted.
>
> Signed-off-by: Thomas Falcon
From: Sabrina Dubroca
Date: Thu, 30 Aug 2018 16:01:18 +0200
> Some systems don't have the ping6 binary anymore, and use ping for
> everything. Detect the absence of ping6 and try to use ping instead.
>
> Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test")
> Signed-off-by: Sabrina D
From: Sabrina Dubroca
Date: Thu, 30 Aug 2018 16:01:17 +0200
> Since commit 82612de1c98e ("ip_tunnel: restore binding to ifaces with a
> large mtu"), the maximum MTU for vti4 is based on IP_MAX_MTU instead of
> the mysterious constant 0xFFF8. This makes this selftest fail.
>
> Fixes: 82612de1c98
From: Florian Westphal
Date: Thu, 30 Aug 2018 14:24:29 +0200
> RFC 1337 says:
> ''Ignore RST segments in TIME-WAIT state.
>If the 2 minute MSL is enforced, this fix avoids all three hazards.''
>
> So with net.ipv4.tcp_rfc1337=1, expected behaviour is to have TIME-WAIT sk
> expire rather tha
From: Marek Behún
Date: Thu, 30 Aug 2018 02:13:50 +0200
> On some boards the interrupt can be shared between multiple devices.
> For example on Turris Mox the interrupt is shared between all switches.
>
> Signed-off-by: Marek Behun
Applied.
From: dsah...@kernel.org
Date: Wed, 29 Aug 2018 16:54:01 -0700
> From: David Ahern
>
> nl_net is set on entry to ip6_route_info_create. Only devices
> within that namespace are considered so no need to reset it
> before returning.
>
> Signed-off-by: David Ahern
Applied.
From: dsah...@kernel.org
Date: Wed, 29 Aug 2018 16:53:27 -0700
> From: David Ahern
>
> Make IPv4 consistent with IPv6 and return an extack message that the
> ONLINK flag requires a nexthop device.
>
> Signed-off-by: David Ahern
Applied.
From: Jakub Kicinski
Date: Wed, 29 Aug 2018 12:46:08 -0700
> To avoid leaking a running timer we need to wait for the
> posted reconfigs after netdev is unregistered. In common
> case the process of deinitializing the device will perform
> synchronous reconfigs which wait for posted requests, bu
From: Yuchung Cheng
Date: Wed, 29 Aug 2018 14:53:56 -0700
> Currently a Linux IPv6 TCP sender will change the flow label upon
> timeouts to potentially steer away from a data path that has gone
> bad. However this does not help if the problem is on the ACK path
> and the data path is healthy. In
From: Eric Dumazet
Date: Wed, 29 Aug 2018 11:50:12 -0700
> This reverts commit 71e41286203c017d24f041a7cd71abea7ca7b1e0.
>
> mmap()/munmap() can not be backed by kmalloced pages :
>
> We fault in :
>
> VM_BUG_ON_PAGE(PageSlab(page), page);
>
> unmap_single_vma+0x8a/0x110
> unmap_v
From: Cong Wang
Date: Wed, 29 Aug 2018 10:15:36 -0700
> According to the new locking rule, we have to take tcf_lock
> for both ->init() and ->dump(), as RTNL will be removed.
> However, it is missing for act_connmark.
>
> Cc: Vlad Buslov
> Signed-off-by: Cong Wang
Applied.
From: Cong Wang
Date: Wed, 29 Aug 2018 10:15:35 -0700
> This reverts commit 331a9295de23 ("net: sched: act: add extack for lookup
> callback").
>
> This extack is never used after 6 months... In fact, it can be just
> set in the caller, right after ->lookup().
>
> Cc: Alexander Aring
> Signed
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/net_failover.c: In function 'net_failover_slave_unregister':
drivers/net/net_failover.c:598:35: warning:
variable 'primary_dev' set but not used [-Wunused-but-set-variable]
There should check the validity of 'slave_dev'.
Fixes: cfc80d9a
On 2018/9/1 0:39, Samudrala, Sridhar wrote:
> On 8/30/2018 8:46 PM, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/net/net_failover.c: In function 'net_failover_slave_unregister':
>> drivers/net/net_failover.c:598:35: warning:
>> variable 'primary_dev' set bu
On Thu, Aug 30, 2018 at 04:45:45PM +0200, Christian Brauner wrote:
> On Thu, Aug 30, 2018 at 11:49:31AM +0300, Kirill Tkhai wrote:
> > On 29.08.2018 21:13, Christian Brauner wrote:
> > > Hi Kirill,
> > >
> > > Thanks for the question!
> > >
> > > On Wed, Aug 29, 2018 at 11:30:37AM +0300, Kirill T
From: Daniel Borkmann
Date: Sat, 1 Sep 2018 02:05:06 +0200
> The following pull-request contains BPF updates for your *net-next* tree.
>
> The main changes are:
>
> 1) Add AF_XDP zero-copy support for i40e driver (!), from Björn and Magnus.
W00t!
> 2) BPF verifier improvements by giving each
From: Pradeep Nalla
Signed-off-by: Pradeep Nalla
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_core.c| 24 +++---
drivers/net/ethernet/cavium/liquidio/lio_main.c| 9 +++-
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 8 +++-
From: David Ahern
Initial import of nexthop code.
- Add new RTM commands for nexthop objects.
- Add new uapi attributes for creating nexthops. Attributes are similar
to the current nexthop attributes for routes.
- Add basic helpers for ipv4 and ipv6 references to nexthop data
Similar to routes
From: David Ahern
Move the device matching check in __fib_validate_source to a helper.
Code move only; no functional change intended.
Signed-off-by: David Ahern
---
net/ipv4/fib_frontend.c | 44 +++-
1 file changed, 27 insertions(+), 17 deletions(-)
dif
From: David Ahern
Add scope as input argument versus relying on fib_info reference in
fib_nh and export fib_info_update_nh_saddr.
Signed-off-by: David Ahern
---
include/net/ip_fib.h | 5 +++--
net/ipv4/fib_semantics.c | 9 -
2 files changed, 7 insertions(+), 7 deletions(-)
diff --
From: David Ahern
Allow users to specify a nexthop id to use with a route.
Signed-off-by: David Ahern
---
include/net/ip6_fib.h | 4 +++
include/net/nexthop.h | 3 ++
net/ipv4/nexthop.c| 5 +++
net/ipv6/addrconf.c | 3 ++
net/ipv6/ip6_fib.c| 17 ---
net/ipv6/ndisc.c
From: Vakul Garg
Date: Wed, 29 Aug 2018 15:30:14 +0530
> Added test case to receive multiple records with a single recvmsg()
> operation with a MSG_PEEK set.
Applied.
From: David Ahern
Add nexthop reference to fib_info along with a list_head for tracking
the association of nexthop back to the fib_info.
Add helpers to take a fib_info and return a fib_nh, a nexthop device
and nexthop gateway.
Add helper to validate a nexthop works with a fib_info.
Signed-off-
From: David Ahern
Move fib6_nh to the end of fib6_info and make an array of
size 0. Pass a flag to fib6_info_alloc indicating if the
allocation needs to add space for a fib6_nh.
The current code path always has a fib6_nh allocated; with
nexthop objects they will not.
Signed-off-by: David Ahern
From: David Ahern
Add nexthop selection to fib_result and update FIB_RES macros to
use it. Right now, fib_nh in fib_result will point to a nexthop
within a fib_info. Later, fib_nh can point to data with a nexthop.
Signed-off-by: David Ahern
---
include/net/ip_fib.h | 21 +--
From: David Ahern
Change fib_check_nh to take net, table and scope as input arguments
over struct fib_config and export for use by nexthop code.
Signed-off-by: David Ahern
---
include/net/ip_fib.h | 2 ++
net/ipv4/fib_semantics.c | 18 +-
2 files changed, 11 insertions(+),
From: David Ahern
Allow the creation of nexthop groups which reference other nexthop
objects to create multipath routes.
TO-DO: Add mpath support to IPv6
Signed-off-by: David Ahern
---
include/net/nexthop.h| 77 +--
net/ipv4/fib_semantics.c | 5 +-
net/ipv4/nexthop.c | 511 ++
From: David Ahern
Consolidate the fib_nh initialization which is duplicated between
fib_create_info for single path and fib_get_nhs for multipath.
Move the fib_nh cleanup code from free_fib_info_rcu into a new helper,
fib_nh_release. Move classid accounting into fib_nh_release which is
called pe
From: Vakul Garg
Date: Wed, 29 Aug 2018 15:26:55 +0530
> When tls records are decrypted using asynchronous acclerators such as
> NXP CAAM engine, the crypto apis return -EINPROGRESS. Presently, on
> getting -EINPROGRESS, the tls record processing stops till the time the
> crypto accelerator finis
From: David Ahern
Remove direct accesses to fi->fib_nh in favor of the helpers added
in the previous patch.
Signed-off-by: David Ahern
---
.../net/ethernet/mellanox/mlxsw/spectrum_router.c| 4 +++-
drivers/net/ethernet/rocker/rocker_ofdpa.c | 20 ++--
include/net
From: David Ahern
The header contains rtnh_ macros so rename the file accordingly.
Allows next patch to use the nexthop.h name.
Signed-off-by: David Ahern
---
include/net/{nexthop.h => rtnh.h} | 4 ++--
net/core/lwtunnel.c | 2 +-
net/decnet/dn_fib.c | 2 +-
net/ipv
From: David Ahern
Refactor initialization and cleanup of fib6_nh to helpers similar to
what was done for IPv4. Add fib6_nh_init to the ipv6 stubs for use by
core code when ipv6 is built as a module.
The replace helper is small enough, so make an inline rather than
requiring it to go through ipv6
From: David Ahern
Export fib_good_nh for use by the nexthop code when selecting a path
within a multipath nexthop.
As nexthops are deleted, fib entries referencing it are marked dead.
Export fib_flush so those entries can be removed in a timely
manner.
Signed-off-by: David Ahern
---
include/n
From: David Ahern
Define fib_get_nhs to return EINVAL when CONFIG_IP_ROUTE_MULTIPATH is
not enabled and remove the ifdef check for CONFIG_IP_ROUTE_MULTIPATH.
Signed-off-by: David Ahern
---
net/ipv4/fib_semantics.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --gi
From: David Ahern
Be optimistic about re-using a fib_info when nexthop id is given and
the route does not use metrics. Avoids a memory allocation which in
most cases is expected to be freed anyways.
Signed-off-by: David Ahern
---
net/ipv4/fib_semantics.c | 48 ++
From: David Ahern
Similar to ipv4, add helpers for accessing fib6_nh data and convert
existing users.
Signed-off-by: David Ahern
---
include/net/ip6_fib.h | 11 --
include/net/ip6_route.h | 2 ++
include/net/nexthop.h | 40 +++
include/t
From: David Ahern
Signed-off-by: David Ahern
---
include/uapi/linux/nexthop.h | 56
include/uapi/linux/rtnetlink.h | 8 +
ip/Makefile| 3 +-
ip/ip.c| 3 +-
ip/ip_common.h | 7 +-
ip/ipmonitor.c | 6 +
From: David Ahern
Add new RTA attribute to allow a user to specify a nexthop id to use
with a route instead of the current nexthop specification.
Signed-off-by: David Ahern
---
include/net/ip_fib.h | 1 +
include/uapi/linux/rtnetlink.h | 1 +
net/ipv4/fib_frontend.c| 7
From: David Ahern
As mentioned at netconf in Seoul, we would like to introduce nexthops as
independent objects from the routes to better align with both routing
daemons and hardware and to improve route insertion times into the kernel.
This series adds nexthop objects with their own lifecycle. T
Hi David,
The following pull-request contains BPF updates for your *net-next* tree.
The main changes are:
1) Add AF_XDP zero-copy support for i40e driver (!), from Björn and Magnus.
2) BPF verifier improvements by giving each register its own liveness
chain which allows to simplify and getti
On 08/31/2018 01:40 PM, Magnus Karlsson wrote:
> This patch set cleans up two code style issues with the xsk zero-copy
> code. The resulting code is smaller and simpler.
>
> Changes from v1:
>
> * Fixed bisecatbility problem reported by Daniel Borkmann by squashing
> the two last patches into o
On 08/31/2018 06:43 PM, Nikita V. Shirokov wrote:
> adding selftest for feature, introduced in
> commit 9452048c79404 ("bpf: add TCP_SAVE_SYN/TCP_SAVED_SYN options for
> bpf_(set|get)sockopt")
>
> Signed-off-by: Nikita V. Shirokov
Applied to bpf-next. Nikita, please also add a proper subsystem p
Sync both files.
Signed-off-by: Mauricio Vasquez B
---
tools/include/uapi/linux/bpf.h | 36
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
index 66917a4eba27..0a5b904ba42f 10064
Two types of tests are done:
- test_maps: only userspace api.
- test_progs: userspace api and ebpf helpers.
Signed-off-by: Mauricio Vasquez B
---
tools/lib/bpf/bpf.c| 12 ++
tools/lib/bpf/bpf.h|1
tools/testing/selftests/bpf/
Helper bpf_msg_pull_data() mistakenly reuses variable 'offset' while
linearizing multiple scatterlist elements. Variable 'offset' is used
to find first starting scatterlist element
i.e. msg->data = sg_virt(&sg[first_sg]) + start - offset"
Use different variable name while linearizing multiple
On 08/31/2018 05:15 AM, Daniel Borkmann wrote:
On 08/31/2018 10:37 AM, Tushar Dave wrote:
On 08/30/2018 12:20 AM, Daniel Borkmann wrote:
On 08/30/2018 02:21 AM, Tushar Dave wrote:
On 08/29/2018 05:07 PM, Tushar Dave wrote:
While doing some preliminary testing it is found that bpf helper
bp
Restrict the use of peek, push and pop helpers only to queue and stack
maps.
Signed-off-by: Mauricio Vasquez B
---
kernel/bpf/verifier.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 5bd67feb2f07..9e177ff4a3b9 100644
---
In some applications this is needed have a pool of free elements, like for
example the list of free L4 ports in a SNAT. None of the current maps allow
to do it as it is not possibleto get an any element without having they key
it is associated to.
This patchset implements two new kind of eBPF map
Implement two new kind of maps that support the peek, push and pop
operations.
A use case for this is to keep track of a pool of elements, like
network ports in a SNAT.
Signed-off-by: Mauricio Vasquez B
---
include/linux/bpf.h |8 +
include/linux/bpf_types.h |2
include/u
From: Jeff Kirsher
Date: Thu, 30 Aug 2018 14:11:32 -0700
> This series contains updates to i40e, i40evf and virtchnl.
Pulled, thanks Jeff.
On Fri, 2018-08-31 at 11:57 +0300, Arseny Maslennikov wrote:
> On Thu, Aug 30, 2018 at 04:17:58PM -0400, Doug Ledford wrote:
> > On Thu, 2018-08-30 at 21:22 +0300, Arseny Maslennikov wrote:
> > > Some InfiniBand network devices have multiple ports on the same PCI
> > > function. This initializes th
On Fri, Aug 31, 2018 at 12:03:56PM +, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/cavium/liquidio/request_manager.c: In function
> 'lio_process_iq_request_list':
> drivers/net/ethernet/cavium/liquidio/request_manager.c:383:27: warning:
> variab
On Tue, Aug 28, 2018 at 08:43:51PM +0200, Jakub Kicinski wrote:
> Ugh, CC: netdev..
>
> On Tue, 28 Aug 2018 20:05:39 +0200, Jakub Kicinski wrote:
> > Hi!
> >
> > I wonder if we can use phys_port_id in switchdev to group together
> > interfaces of a single PCI PF? Here is the problem:
On Mellano
Remove the incorrect WR_HDR field which can cause a misinterpretation
of this CPL by ULDs.
Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues")
Signed-off-by: Steve Wise
---
Dave, Doug, and Jason,
I request this merge through the rdma repo since the only user of this
struct
On 08/31/2018 05:26 PM, Jesper Dangaard Brouer wrote:
> The compiler does an efficient job of inlining static C functions.
> Perf top clearly shows that almost everything gets inlined into the
> function call xdp_do_redirect.
>
> The function xdp_do_redirect end-up containing and interleaving the
> On 8/31/18 10:19 AM, Lorenzo Bianconi wrote:
> >> On 8/31/18 5:43 AM, Lorenzo Bianconi wrote:
> >>> When moving a veth device to another namespace, userspace receives a
> >>> RTM_DELLINK message indicating the device has been removed from current
> >>> netns. However, the other peer does not rece
adding selftest for feature, introduced in
commit 9452048c79404 ("bpf: add TCP_SAVE_SYN/TCP_SAVED_SYN options for
bpf_(set|get)sockopt")
Signed-off-by: Nikita V. Shirokov
---
.../testing/selftests/bpf/test_tcpbpf_kern.c | 38 +--
.../testing/selftests/bpf/test_tcpbpf_user.c | 3
On 8/30/2018 8:46 PM, YueHaibing wrote:
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/net_failover.c: In function 'net_failover_slave_unregister':
drivers/net/net_failover.c:598:35: warning:
variable 'primary_dev' set but not used [-Wunused-but-set-variable]
Actually this gcc op
On Fri, Aug 31, 2018 at 4:20 AM, Patrick Ruddy
wrote:
> Some userspace applications need to know about IGMP joins from the kernel
> for 2 reasons
> 1. To allow the programming of multicast MAC filters in hardware
> 2. To form a multicast FORUS list for non link-local multicast
>groups to be se
On 8/31/18 10:19 AM, Lorenzo Bianconi wrote:
>> On 8/31/18 5:43 AM, Lorenzo Bianconi wrote:
>>> When moving a veth device to another namespace, userspace receives a
>>> RTM_DELLINK message indicating the device has been removed from current
>>> netns. However, the other peer does not receive a netl
> On 8/31/18 5:43 AM, Lorenzo Bianconi wrote:
> > When moving a veth device to another namespace, userspace receives a
> > RTM_DELLINK message indicating the device has been removed from current
> > netns. However, the other peer does not receive a netlink event
> > containing new values for IFLA_L
On 30/08/18 03:18, Alexei Starovoitov wrote:
> I think it's a better base to continue debugging.
> In particular:
> 1. we have instability issue in the verifier.
> from time to time the verifier goes to process extra 7 instructions on one
> of the cilium tests. This was happening before and after
The compiler does an efficient job of inlining static C functions.
Perf top clearly shows that almost everything gets inlined into the
function call xdp_do_redirect.
The function xdp_do_redirect end-up containing and interleaving the
map and non-map redirect code. This is sub-optimal, as it would
The compiler chooses to not-inline the function __xdp_map_lookup_elem,
because it can see that it is used by both Generic-XDP and native-XDP
do redirect calls (xdp_do_generic_redirect_map and xdp_do_redirect_map).
The compiler cannot know that this is a bad choice, as it cannot know
that a net dev
Notice the compiler generated ASM code layout was suboptimal. It
assumed map enqueue errors as the likely case, which is shouldn't.
It assumed that xdp_do_flush_map() was a likely case, due to maps
changing between packets, which should be very unlikely.
Signed-off-by: Jesper Dangaard Brouer
---
This patchset contains XDP micro optimizations for the redirect core.
These are not functional changes. The optimizations revolve around
getting the compiler to layout the code in a way that reflect how XDP
redirect is used.
Today the compiler chooses to inline and uninline (static C functions)
i
On 8/31/18 5:43 AM, Lorenzo Bianconi wrote:
> When moving a veth device to another namespace, userspace receives a
> RTM_DELLINK message indicating the device has been removed from current
> netns. However, the other peer does not receive a netlink event
> containing new values for IFLA_LINK_NETNSI
On Fri, Aug 31, 2018 at 9:44 AM Paolo Abeni wrote:
>
> On Fri, 2018-08-31 at 09:08 -0400, Willem de Bruijn wrote:
> > On Fri, Aug 31, 2018 at 5:09 AM Paolo Abeni wrote:
> > >
> > > Hi,
> > >
> > > On Tue, 2018-04-17 at 17:07 -0400, Willem de Bruijn wrote:
> > > > That said, for negotiated flows a
We've upgraded a few machines to a 4.18.3 kernel and we're running into
weird IPv6 neighbor discovery issues. Basically, the machines stop
responding to inbound IPv6 neighbor solicitation requests, which very
quickly breaks all IPv6 connectivity.
It seems like the routing table gets confused:
On Fri, 2018-08-31 at 09:08 -0400, Willem de Bruijn wrote:
> On Fri, Aug 31, 2018 at 5:09 AM Paolo Abeni wrote:
> >
> > Hi,
> >
> > On Tue, 2018-04-17 at 17:07 -0400, Willem de Bruijn wrote:
> > > That said, for negotiated flows an inverse GRO feature could
> > > conceivably be implemented to re
On 30.08.2018 19:10, David Ahern wrote:
> On 8/30/18 10:11 AM, Alexey Kodanev wrote:
...
>> unreferenced object 0x880b6aaa14e0 (size 64):
>> comm "ip", pid 10577, jiffies 4295149341 (age 1273.903s)
>> hex dump (first 32 bytes):
>> 01 00 04 00 04 00 00 00 10 00 00 00 00 00 00 00 ...
On Fri, Aug 31, 2018 at 5:09 AM Paolo Abeni wrote:
>
> Hi,
>
> On Tue, 2018-04-17 at 17:07 -0400, Willem de Bruijn wrote:
> > That said, for negotiated flows an inverse GRO feature could
> > conceivably be implemented to reduce rx stack traversal, too.
> > Though due to interleaving of packets on
Collect descriptors of all ULD and LLD hardware queues managed
by LLD.
Signed-off-by: Rahul Lakkireddy
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cudbg_entity.h | 42 +++
drivers/net/ethernet/chelsio/cxgb4/cudbg_if.h | 3 +-
drivers/net/ethernet/chelsio/cxgb4/cud
On 08/31/2018 10:37 AM, Tushar Dave wrote:
> On 08/30/2018 12:20 AM, Daniel Borkmann wrote:
>> On 08/30/2018 02:21 AM, Tushar Dave wrote:
>>> On 08/29/2018 05:07 PM, Tushar Dave wrote:
While doing some preliminary testing it is found that bpf helper
bpf_msg_pull_data does not calculate th
On Fri, Aug 31, 2018 at 03:09:05PM +0800, Xin Long wrote:
> On Wed, Aug 29, 2018 at 7:36 PM Neil Horman wrote:
> >
> > On Wed, Aug 29, 2018 at 12:08:40AM +0800, Xin Long wrote:
> > > On Mon, Aug 27, 2018 at 9:08 PM Neil Horman wrote:
> > > >
> > > > On Mon, Aug 27, 2018 at 06:38:31PM +0800, Xin L
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/cavium/liquidio/request_manager.c: In function
'lio_process_iq_request_list':
drivers/net/ethernet/cavium/liquidio/request_manager.c:383:27: warning:
variable 'irh' set but not used [-Wunused-but-set-variable]
Signed-off-by: Yu
sorry, patch description is messy, will fix it in V2.
On 2018/8/31 19:53, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/cavium/liquidio/request_manager.c: In function
> 'lio_process_iq_request_list':
> drivers/net/ethernet/cavium/liquidio/request_man
When moving a veth device to another namespace, userspace receives a
RTM_DELLINK message indicating the device has been removed from current
netns. However, the other peer does not receive a netlink event
containing new values for IFLA_LINK_NETNSID and IFLA_LINK veth
attributes.
Fix that behaviour
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/cavium/liquidio/request_manager.c: In function
'lio_process_iq_request_list':
drivers/net/ethernet/cavium/liquidio/request_manager.c:383:27: warning:
variable 'irh' set but not used [-Wunused-but-set-variable]
Signed-off-by: Yu
This commit gets rid of the structure xdp_umem_props. It was there to
be able to break a dependency at one point, but this is no longer
needed. The values in the struct are instead stored directly in the
xdp_umem structure. This simplifies the xsk code as well as af_xdp
zero-copy drivers and as a b
With certain gcc versions, it was possible to get the warning
"'tx_desc' may be used uninitialized in this function" for the
i40e_xmit_zc. This was not possible, however this commit simplifies
the code path so that this warning is no longer emitted.
Signed-off-by: Magnus Karlsson
---
drivers/net
This patch set cleans up two code style issues with the xsk zero-copy
code. The resulting code is smaller and simpler.
Changes from v1:
* Fixed bisecatbility problem reported by Daniel Borkmann by squashing
the two last patches into one.
Patch 1: Removes a potential compiler warning reported b
After commit d6990976af7c5d8f55903bfb4289b6fb030bf754 ("vti6: fix PMTU caching
and reporting on xmit"), some too big skbs might be potentially passed down to
__xfrm6_output, causing it to fail to transmit but not free the skb, causing a
leak of skb, and consequentially a leak of dst references.
Af
XOR (MLX5_RX_HASH_FN_INVERTED_XOR8) gives only 8 bits.
It seems not enough for RFS. All other drivers use toeplitz.
Driver mlx4_en uses Toeplitz by default and warns if hash XOR is used
together with NETIF_F_RXHASH (enabled by default too): "Enabling both
XOR Hash function and RX Hashing can limit
Some userspace applications need to know about MLD joins from the
kernel for 2 reasons:
1. To allow the programming of multicast MAC filters in hardware
2. To form a multicast FORUS list for non link-local multicast
groups to be sent to the kernel and from there to the interested
party.
(1) c
Some userspace applications need to know about IGMP joins from the kernel
for 2 reasons
1. To allow the programming of multicast MAC filters in hardware
2. To form a multicast FORUS list for non link-local multicast
groups to be sent to the kernel and from there to the interested
party.
(1) c
On 08/31/2018 03:00 AM, Prashant Bhole wrote:
> - xsks_map size was fixed to 4, changed it MAX_SOCKS
> - Remove redundant definition of MAX_SOCKS in xdpsock_user.c
> - In dump_stats(), add NULL check for xsks[i]
>
> Signed-off-by: Prashant Bhole
Applied, thanks Prashant!
On 08/31/2018 02:59 AM, Prashant Bhole wrote:
> Since xdp_umem_query() was added one assignment of bpf.command was
> missed from cleanup. Removing the assignment statement.
>
> Fixes: 84c6b86875e01a0 ("xsk: don't allow umem replace at stack level")
> Signed-off-by: Prashant Bhole
Applied, thanks
Driver displays an error message for each unrecognized dcbx TLV that's
received from the peer or configured on the device. It is observed that
syslog will be flooded with such messages in certain scenarios e.g.,
frequent link-flaps/lldp-transactions. Changing the severity of this
message to verbose
On 08/30/2018 03:56 PM, Magnus Karlsson wrote:
> The struct xdp_umem_props was removed in the xsk code and this commit
> adapts the i40e af_xdp zero-copy driver code to the new xdp_umem
> structure.
>
> Signed-off-by: Magnus Karlsson
> ---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 ++--
>
On 08/31/2018 02:09 AM, Paolo Abeni wrote:
> I hope quic can leverage such scenario, but I
> really know nothing about the protocol.
>
Most QUIC receivers are mobile phones, laptops, with wifi without GRO anyway...
Even if they had GRO, the inter-packet delay would be too high for GRO to be
s
Hi,
On Tue, 2018-04-17 at 17:07 -0400, Willem de Bruijn wrote:
> That said, for negotiated flows an inverse GRO feature could
> conceivably be implemented to reduce rx stack traversal, too.
> Though due to interleaving of packets on the wire, it aggregation
> would be best effort, similar to TCP T
On Thu, Aug 30, 2018 at 04:17:58PM -0400, Doug Ledford wrote:
> On Thu, 2018-08-30 at 21:22 +0300, Arseny Maslennikov wrote:
> > Some InfiniBand network devices have multiple ports on the same PCI
> > function. This initializes the `dev_port' sysfs field of those
> > network interfaces with their p
man ip-tunnel ttl section says:
0 is a special value meaning that packets inherit the TTL value.
IPv4 tunnel respect this in ip_tunnel_xmit(), but IPv6 tunnel has not
implement it yet. To make IPv6 behave consistently with IP tunnel,
add ipv6 tunnel inherit support.
Signed-off-by: Hangbin Liu
--
On Fri, 31 Aug 2018 15:32:42 +0900, Prashant Bhole wrote:
> When listed all maps, bpftool currently shows (null) for xskmap.
> Added xskmap type in map_type_name[] to show correct type.
>
> Signed-off-by: Prashant Bhole
Acked-by: Jakub Kicinski
Thank you! I feel tempted to suggest considering
On 08/30/2018 12:20 AM, Daniel Borkmann wrote:
On 08/30/2018 02:21 AM, Tushar Dave wrote:
On 08/29/2018 05:07 PM, Tushar Dave wrote:
While doing some preliminary testing it is found that bpf helper
bpf_msg_pull_data does not calculate the data and data_end offset
correctly. Fix it!
Fixes: 0
On 2018-08-29 21:19, Jakub Kicinski wrote:
XSK UMEM is strongly single producer single consumer so reuse of
frames is challenging. Add a simple "stash" of FILL packets to
reuse for drivers to optionally make use of. This is useful
when driver has to free (ndo_stop) or resize a ring with an acti
On Thu, 30 Aug 2018 14:06:24 +0200, Björn Töpel wrote:
> On 2018-08-29 21:14, Jakub Kicinski wrote:
> > On Tue, 28 Aug 2018 14:44:32 +0200, Björn Töpel wrote:
> >> From: Björn Töpel
> >>
> >> This patch adds zero-copy Rx support for AF_XDP sockets. Instead of
> >> allocating buffers of type
Den fre 31 aug. 2018 kl 03:04 skrev Prashant Bhole
:
>
> - xsks_map size was fixed to 4, changed it MAX_SOCKS
> - Remove redundant definition of MAX_SOCKS in xdpsock_user.c
> - In dump_stats(), add NULL check for xsks[i]
>
Thanks for the cleanup!
Acked-by: Björn Töpel
> Signed-off-by: Prashant
Den fre 31 aug. 2018 kl 03:02 skrev Prashant Bhole
:
>
> Since xdp_umem_query() was added one assignment of bpf.command was
> missed from cleanup. Removing the assignment statement.
>
Good catch!
Acked-by: Björn Töpel
> Fixes: 84c6b86875e01a0 ("xsk: don't allow umem replace at stack level")
> S
1 - 100 of 101 matches
Mail list logo
