[PATCH v2] net: mvpp2: initialize port of_node pointer

2018-08-28 Thread Baruch Siach
Without a valid of_node in struct device we can't find the mvpp2 port device by its DT node. Specifically, this breaks of_find_net_device_by_node(). For example, the Armada 8040 based Clearfog GT-8K uses Marvell 88E6141 switch connected to the &cp1_eth2 port: &cp1_mdio { ... swit

Re: bpfilter causes a leftover kernel process

2018-08-28 Thread Alexei Starovoitov
On Tue, Aug 28, 2018 at 01:23:38PM +0200, Olivier Brunel wrote: > On Mon, 27 Aug 2018 20:35:02 -0700 > Alexei Starovoitov wrote: > > > I'm also running Arch Linux in my VM, but I'm not able to reproduce > > umount issue. I'm guessing it's somehow related to non-static build > > and libc.so being

Re: [PATCH bpf] bpf: fix several offset tests in bpf_msg_pull_data

2018-08-28 Thread Alexei Starovoitov
On Tue, Aug 28, 2018 at 04:15:35PM +0200, Daniel Borkmann wrote: > While recently going over bpf_msg_pull_data(), I noticed three > issues which are fixed in here: > > 1) When we attempt to find the first scatterlist element (sge) >for the start offset, we add len to the offset before we check

[PATCH net-next v1] selftests/tls: Add test for recv(PEEK) spanning across multiple records

2018-08-28 Thread Vakul Garg
Added test case to receive multiple records with a single recvmsg() operation with a MSG_PEEK set. --- tools/testing/selftests/net/tls.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index b3ebf264

[PATCH net-next v2] net/tls: Add support for async decryption of tls records

2018-08-28 Thread Vakul Garg
When tls records are decrypted using asynchronous acclerators such as NXP CAAM engine, the crypto apis return -EINPROGRESS. Presently, on getting -EINPROGRESS, the tls record processing stops till the time the crypto accelerator finishes off and returns the result. This incurs a context switch and

Re: Oops running iptables -F OUTPUT

2018-08-28 Thread Nicholas Piggin
On Tue, 28 Aug 2018 18:09:09 +0200 Ard Biesheuvel wrote: > On 28 August 2018 at 15:56, Ard Biesheuvel wrote: > > Hello Andreas, Nick, > > > > On 28 August 2018 at 06:06, Nicholas Piggin > > wrote: > >> On Mon, 27 Aug 2018 19:11:01 +0200 > >> Andreas Schwab wrote: > >> > >>> I'm getting th

Re: Oops running iptables -F OUTPUT

2018-08-28 Thread Nicholas Piggin
On Wed, 29 Aug 2018 13:28:27 +1000 Nicholas Piggin wrote: > On Tue, 28 Aug 2018 14:06:32 +1000 > Nicholas Piggin wrote: > > > On Mon, 27 Aug 2018 19:11:01 +0200 > > Andreas Schwab wrote: > > > > > I'm getting this Oops when running iptables -F OUTPUT: > > > > > > [ 91.139409] Unable to h

[PATCH][net-next] vxlan: reduce dirty cache line in vxlan_find_mac

2018-08-28 Thread Li RongQing
vxlan_find_mac() unconditionally set f->used for every packet, this causes a cache miss for every packet, since remote, hlist and used of vxlan_fdb share the same cache line, which are accessed when send every packets. so f->used is set only if not equal to jiffies, to reduce dirty cache line time

Re: Oops running iptables -F OUTPUT

2018-08-28 Thread Nicholas Piggin
On Tue, 28 Aug 2018 14:06:32 +1000 Nicholas Piggin wrote: > On Mon, 27 Aug 2018 19:11:01 +0200 > Andreas Schwab wrote: > > > I'm getting this Oops when running iptables -F OUTPUT: > > > > [ 91.139409] Unable to handle kernel paging request for data at address > > 0xd001fff12f34 > > [

[PATCH] neighbour: confirm neigh entries when ARP packet is received

2018-08-28 Thread Vasily Khoruzhick
Update 'confirmed' timestamp when ARP packet is received. It shouldn't affect locktime logic and anyway entry can be confirmed by any higher-layer protocol. Thus it makes no sense not to confirm it when ARP packet is received. Fixes: 77d7123342 ("neighbour: update neigh timestamps iff update is ef

[PATCH net-next 1/4] liquidio: improve soft command handling

2018-08-28 Thread Felix Manlunas
1. Set LIO_SC_MAX_TMO_MS as the maximum timeout value for a soft command (sc). All sc's use this value as a hard timeout value. Add expiry_time in struct octeon_soft_command to keep the hard timeout value. The field wait_time and timeout in struct octeon_soft_command will be obsoleted in

[PATCH net-next 2/4] liquidio: make soft command calls synchronous

2018-08-28 Thread Felix Manlunas
1. Add wait_for_sc_completion_timeout() for waiting the response and handling common response errors 2. Send sc's synchronously: remove unused callback function, and context structure; use wait_for_sc_completion_timeout() to wait its response. Signed-off-by: Weilin Chang Signed-off-by: F

[PATCH net-next 3/4] liquidio: change octnic_ctrl_pkt to do synchronous soft commands

2018-08-28 Thread Felix Manlunas
1. Change struct octnic_ctrl_pkt to support synchronous operation. 2. Change code which use structure octnic_ctrl_pkt to send sc's synchronously. Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 15 ++--- drivers/net/ethernet/

[PATCH net-next 4/4] liquidio: remove obsolete functions and data structures

2018-08-28 Thread Felix Manlunas
1. Remove unused functions and data structures. 2. Change the sending of the remaining soft commands to synchronous. Signed-off-by: Weilin Chang Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 83 +--- drivers/net/ethernet/cavium/liquidio/lio_ethtool.

[PATCH net-next 0/4] liquidio: improve soft command/response handling

2018-08-28 Thread Felix Manlunas
From: Weilin Chang Change soft command handling to fix the possible race condition when the process handles a response of a soft command that was already freed by an application which got timeout for this request. Weilin Chang (4): liquidio: improve soft command handling liquidio: make soft

[PATCH can-next] can: ucan: remove set but not used variable 'udev'

2018-08-28 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/can/usb/ucan.c: In function 'ucan_disconnect': drivers/net/can/usb/ucan.c:1578:21: warning: variable 'udev' set but not used [-Wunused-but-set-variable] struct usb_device *udev; Signed-off-by: YueHaibing --- drivers/net/can/usb/ucan.

Re: [PATCH v2 iproute2-next 2/5] bridge: colorize output and use JSON print library

2018-08-28 Thread Roopa Prabhu
On Sat, Jul 14, 2018 at 6:41 PM, Roopa Prabhu wrote: > On Tue, Feb 20, 2018 at 11:24 AM, Stephen Hemminger > wrote: >> From: Stephen Hemminger >> >> Use new functions from json_print to simplify code. >> Provide standard flag for colorizing output. >> >> The shortened -c flag is ambiguous it cou

[PATCH can-next] can: ucan: remove duplicated include from ucan.c

2018-08-28 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/can/usb/ucan.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c index 0678a38..c6f4b41 100644 --- a/drivers/net/can/usb/ucan.c +++ b/drivers/net/can/usb/ucan.c @@ -3

Re: [net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-08-28

2018-08-28 Thread David Miller
From: Jeff Kirsher Date: Tue, 28 Aug 2018 14:35:44 -0700 > This series contains updates to ixgbe and ixgbevf only. ... Pulled.

Re: [PATCH net-next 00/15] nfp: add NFP5000 support

2018-08-28 Thread David Miller
From: Jakub Kicinski Date: Tue, 28 Aug 2018 13:20:32 -0700 > This series broadly speaking adds support for NFP5000 and > related products. ... Series applied, thanks Jakub.

Re: [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2018-08-28

2018-08-28 Thread David Miller
From: Jeff Kirsher Date: Tue, 28 Aug 2018 12:03:58 -0700 > This series contains new features and implementation updates for the > ice driver. ... Pulled.

[PATCH net-next,v5] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-28 Thread Doron Roberts-Kedes
decrypt_skb fails if the number of sg elements required to map it is greater than MAX_SKB_FRAGS. nsg must always be calculated, but skb_cow_data adds unnecessary memcpy's for the zerocopy case. The new function skb_nsg calculates the number of scatterlist elements required to map the skb without t

Re: [Patch iproute2] ss: add UNIX_DIAG_VFS and UNIX_DIAG_ICONS for unix sockets

2018-08-28 Thread Cong Wang
On Mon, Aug 27, 2018 at 3:27 PM Stephen Hemminger wrote: > > On Mon, 27 Aug 2018 14:46:52 -0700 > Cong Wang wrote: > > > UNIX_DIAG_VFS and UNIX_DIAG_ICONS are never used by ss, > > make them available in ss -e output. > > > > Cc: Stephen Hemminger > > Signed-off-by: Cong Wang > > --- > > misc/

[net-next 02/13] ixgbevf: VF2VF TCP RSS

2018-08-28 Thread Jeff Kirsher
From: Sebastian Basierski While VF2VF with RSS communication, RSS Type were wrongly recognized and RSS hash was not calculated as it should be. Packets was distributed on various queues by accident. This commit fixes that behaviour and causes proper RSS Type recognition. Signed-off-by: Sebastian

[net-next 03/13] ixgbe: don't clear IPsec sa counters on HW clearing

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson The software SA record counters should not be cleared when clearing the hardware tables. This causes the counters to be out of sync after a driver reset. Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA") Signed-off-by: Shannon Nelson Tested-by: Andrew Bowe

[net-next 01/13] ixgbe: firmware recovery mode

2018-08-28 Thread Jeff Kirsher
From: Sebastian Basierski Add check for FW NVM recovery mode during driver initialization and service task. If in recovery mode, log message and unregister device Signed-off-by: Sebastian Basierski Tested-by: Don Buchholz Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/ixgbe/ixgbe_com

[net-next 08/13] ixgbe: add VF IPsec offload request message handling

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson Add an add and a delete message for IPsec offload requests from the VF. These call into the IPsec functions that can translate the message buffer into a useful IPsec offload. These new messages bump the mbox API version to 1.4. Signed-off-by: Shannon Nelson Tested-by: And

[net-next 09/13] ixgbevf: add defines for IPsec offload request

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson Fix up the register definitions for using IPsec offloads and add the new mailbox message IDs. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbevf/defines.h | 8 drivers/net/ethernet/intel/ixgb

[net-next 06/13] ixgbe: add VF IPsec management

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson Add functions to translate VF IPsec offload add and delete requests into something the existing code can work with. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/ixgbe/ixgbe_ipsec.c| 256

[net-next 04/13] ixgbe: reload IPsec IP table after sa tables

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson Restore the IPsec hardware IP table after reloading the SA tables. This doesn't make much difference now, but will matter when we add support for VF IPsec offloads. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/etherne

[net-next 13/13] ixgbe: fix the return value for unsupported VF offload

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson When failing the request because we can't support that offload, reporting EOPNOTSUPP makes much more sense than ENXIO. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +- 1 file cha

[net-next 10/13] ixgbevf: add VF IPsec offload code

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson Add the IPsec offload support code. This is based off of the similar code in ixgbe, but instead of writing the SA registers, the VF asks the PF to setup the offload by sending the offload information to the PF via the standard mailbox. Signed-off-by: Shannon Nelson Tested-

[net-next 11/13] ixgbevf: enable VF IPsec offload operations

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson Add the IPsec initialization into the driver startup and add the Rx and Tx processing hooks. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbevf/defines.h | 2 +- drivers/net/ethernet/intel/ixgbevf/e

[net-next 03/13] ixgbe: don't clear IPsec sa counters on HW clearing

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson The software SA record counters should not be cleared when clearing the hardware tables. This causes the counters to be out of sync after a driver reset. Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA") Signed-off-by: Shannon Nelson Tested-by: Andrew Bowe

[net-next 07/13] ixgbe: add VF IPsec offload enable flag

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson Add a private flag to expressly enable support for VF IPsec offload. The VF will have to be "trusted" in order to use the hardware offload, but because of the general concerns of managing VF access, we want to be sure the user specifically is enabling the feature. This is li

[net-next 12/13] ixgbe: disallow IPsec Tx offload when in SR-IOV mode

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson There seems to be a problem in the x540's internal switch wherein if SR-IOV mode is enabled and an offloaded IPsec packet is sent to a local VF, the packet is silently dropped. This might never be a problem as it is somewhat a corner case, but if someone happens to be using

[net-next 00/13][pull request] 10GbE Intel Wired LAN Driver Updates 2018-08-28

2018-08-28 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf only. Sebastian adds support for firmware NVM recovery mode, which logs a message when errors are detected and un-registers the device. Also fixed RSS type recognition with VF to VF communication. Shannon Nelson implements IPsec hardware offload

[net-next 05/13] ixgbe: prep IPsec constants for later use

2018-08-28 Thread Jeff Kirsher
From: Shannon Nelson Pull out a couple of values from a function so they can be used later elsewhere. Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletio

[PATCH 1/3] IB/ipoib: Use dev_port to expose network interface port numbers

2018-08-28 Thread Arseny Maslennikov
Some InfiniBand network devices have multiple ports on the same PCI function. This initializes the `dev_port' sysfs field of those network interfaces with their port number. The use of `dev_id' was considered correct until Linux 3.15, when another field, `dev_port', was defined for this particular

[PATCH 2/3] IB/ipoib: Stop using dev_id to expose port numbers

2018-08-28 Thread Arseny Maslennikov
Some InfiniBand network devices have multiple ports on the same PCI function. Prior to this the kernel erroneously used the `dev_id' sysfs field of those network interfaces to convey the port number to userspace. `dev_id' is currently reserved for distinguishing stacked ifaces (e.g: VLANs) with th

[PATCH 0/3] IB/ipoib: Use dev_port to disambiguate port numbers

2018-08-28 Thread Arseny Maslennikov
Pre-3.15 userspace had trouble distinguishing different ports of a NIC on a single PCI bus/device/function. To solve this, a sysfs field `dev_port' was introduced quite a while ago (commit v3.14-rc3-739-g3f85944fe207), and some relevant device drivers were fixed to use it, but not in case of IPoIB.

[PATCH 3/3] Documentation/ABI: document /sys/class/net/*/dev_port

2018-08-28 Thread Arseny Maslennikov
The sysfs field was introduced 4 years ago along with fixes to various drivers that erroneously used `dev_id' for that purpose, but it was not properly documented anywhere. See commit v3.14-rc3-739-g3f85944fe207. Signed-off-by: Arseny Maslennikov --- Documentation/ABI/testing/sysfs-class-net | 1

[PATCH] rtnetlink: expose value from SET_NETDEV_DEVTYPE via IFLA_DEVTYPE attribute

2018-08-28 Thread Marcel Holtmann
The name value from SET_NETDEV_DEVTYPE only ended up in the uevent sysfs file as DEVTYPE= information. To avoid any kind of race conditions between netlink messages and reading from sysfs, it is useful to add the same string as new IFLA_DEVTYPE attribute included in the RTM_NEWLINK messages. For n

[PATCH net-next 03/15] nfp: interpret extended FW load result codes

2018-08-28 Thread Jakub Kicinski
To enable easier FW distribution NFP can now automatically select between FW stored on the flash and loaded from the kernel. If FW loading policy is set to auto it will compare the versions of FW from the host and from the flash and load the newer one. If FW type doesn't match (e.g. one advanced

[PATCH net-next 01/15] nfp: encapsulate NSP command arguments into structs

2018-08-28 Thread Jakub Kicinski
There is already a fair number of arguments to nfp_nsp_command() family of functions. Encapsulate them into structures to make adding new ones easier. No functional changes. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- .../ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 205 +

[PATCH net-next 14/15] nfp: support access to absolute RTsyms

2018-08-28 Thread Jakub Kicinski
Add support in nfpcore for reading the absolute RTsyms. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- .../ethernet/netronome/nfp/nfpcore/nfp_nffw.h | 13 +++--- .../netronome/nfp/nfpcore/nfp_rtsym.c | 42 +-- 2 files changed, 46 insertions(+), 9 delet

[PATCH net-next 05/15] nfp: abm: look up MAC addresses via management FW

2018-08-28 Thread Jakub Kicinski
In multi-host scenarios Management FW may allocate MAC addresses at runtime, we have to use the indirect lookup to find them. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/abm/main.c | 34 ++- 1 file changed, 25 insertions(+

[PATCH net-next 02/15] nfp: attempt FW load from flash

2018-08-28 Thread Jakub Kicinski
Flash may contain a default NFP application FW. This application can either be put there by the user (with ethtool -f) or shipped with the card. If file system FW is not found, attempt to load this flash stored app FW. Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/

[PATCH net-next 00/15] nfp: add NFP5000 support

2018-08-28 Thread Jakub Kicinski
Hi! This series broadly speaking adds support for NFP5000 and related products. First we add support for loading FW from flash. We need to allow for the management processor to provide extended log messages when FW is loaded. This is needed when FW selection policy is to compare the FW on the d

[PATCH net-next 15/15] nfp: make RTsym users handle absolute symbols correctly

2018-08-28 Thread Jakub Kicinski
Make the RTsym users access the size via the helper, which takes care of special handling of absolute symbols. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- drivers/net/ethernet/netronome/nfp/abm/ctrl.c | 4 +- drivers/net/ethernet/netronome/nfp/nfp_main.c | 6 +-- .../net

[PATCH net-next 13/15] nfp: convert all RTsym users to use new read/write helpers

2018-08-28 Thread Jakub Kicinski
Convert all users of RTsym to the new set of helpers which handle all targets correctly. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- drivers/net/ethernet/netronome/nfp/abm/ctrl.c | 28 ++- drivers/net/ethernet/netronome/nfp/nfp_main.c | 28 -

[PATCH net-next 08/15] nfp: save the MU locality field offset

2018-08-28 Thread Jakub Kicinski
We will soon need the MU locality field offset much more often than just for decoding MIP address. Save it in nfp_cpp for quick access. Note that we can already reuse the target config from nfp_cpp, no need to do the XPB read. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron ---

[PATCH net-next 12/15] nfp: convert existing RTsym helpers to full target decoding

2018-08-28 Thread Jakub Kicinski
Make nfp_rtsym_{read,write}_le() and nfp_rtsym_map() use the new target resolution helpers to allow accessing in-cache symbols. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- .../netronome/nfp/nfpcore/nfp_rtsym.c | 28 +-- 1 file changed, 14 insertions

[PATCH net-next 04/15] nfp: add support for indirect HWinfo lookup

2018-08-28 Thread Jakub Kicinski
Management FW can adjust some of the information in the HWinfo table at runtime. In some cases reading the table directly will not yield correct results. Add a NSP command for looking up information. Up until now we weren't making use of any of the values which may get adjusted. Signed-off-by: J

[PATCH net-next 06/15] nfp: add support for NFP5000

2018-08-28 Thread Jakub Kicinski
Add NFP5000 to supported chips, the chip is backward compatible with NFP4000 and NFP6000, so core PCIe code needs to handle it the same way as 4k and 6k. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 4 drivers/net/ethernet/netronome/nfp/nfpco

[PATCH net-next 09/15] nfp: add basic errors messages to target logic

2018-08-28 Thread Jakub Kicinski
Add error prints to CPP target encoding/decoding logic, otherwise it's quite hard to pin point the reasons why read or write operations fail. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- .../net/ethernet/netronome/nfp/nfpcore/nfp_target.c | 12 ++-- 1 file changed,

[PATCH net-next 11/15] nfp: pass cpp_id to nfp_cpp_map_area()

2018-08-28 Thread Jakub Kicinski
Align nfp_cpp_map_area() with other CPP-level APIs and pass encoded cpp_id/dest rather than target, action, domain tuple. Signed-off-by: Jakub Kicinski Reviewed-by: Francois H. Theron --- drivers/net/ethernet/netronome/nfp/nfp_net_main.c| 8 drivers/net/ethernet/netronome/nfp/nfpc

[PATCH net-next 07/15] nfp: refactor the per-chip PCIe config

2018-08-28 Thread Jakub Kicinski
Use a switch statement instead of ifs for code dependent on chip version. While at it make sure we fail for unknown chip revisions. Signed-off-by: Jakub Kicinski --- .../netronome/nfp/nfpcore/nfp6000_pcie.c | 50 ++- .../ethernet/netronome/nfp/nfpcore/nfp_cpp.h | 4 ++ 2

[PATCH net-next 10/15] nfp: add RTsym access helpers

2018-08-28 Thread Jakub Kicinski
RTsyms may have special encodings for more complex symbol types. For example symbols which are placed in external memory unit's cache directly, constants or local memory. Add set of helpers which will check for those special encodings and handle them correctly. For now only add direct cache acces

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-08-28 Thread Willem de Bruijn
On Mon, Jul 30, 2018 at 2:06 AM Jason Wang wrote: > > > > On 2018年07月25日 08:17, Jon Olson wrote: > > On Tue, Jul 24, 2018 at 3:46 PM Michael S. Tsirkin wrote: > >> On Tue, Jul 24, 2018 at 06:31:54PM -0400, Willem de Bruijn wrote: > >>> On Tue, Jul 24, 2018 at 6:23 PM Michael S. Tsirkin > >>> wr

[net-next 05/15] ice: Code optimization for ice_fill_sw_rule()

2018-08-28 Thread Jeff Kirsher
From: Zhenning Xiao Use the buffer in the s_rule structure directly instead of using a local array eth_hdr[DUMMY_ETH_HDR_LEN] Signed-off-by: Zhenning Xiao Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_switc

[net-next 04/15] ice: Prevent control queue operations during reset

2018-08-28 Thread Jeff Kirsher
From: Anirudh Venkataramanan Once reset is issued, the driver loses all control queue interfaces. Exercising control queue operations during reset is incorrect and may result in long timeouts. This patch introduces a new field 'reset_ongoing' in the hw structure. This is set to 1 by the core dri

[net-next 07/15] ice: Refactor VSI allocation, deletion and rebuild flow

2018-08-28 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch refactors aspects of the VSI allocation, deletion and rebuild flow. Some of the more noteworthy changes are described below. 1) On reset, all switch filters applied in the hardware are lost. In the rebuild flow, only MAC and broadcast filters are being

[net-next 09/15] ice: Clean up register file

2018-08-28 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch cleans up the existing register definitions. 1) Several instances of long defines names used in the BIT() macro were replaced to use the actual values they represent. As a result some defines for shifts (ending with _S) that were used only to crea

[net-next 11/15] ice: Implement ice_bridge_getlink and ice_bridge_setlink

2018-08-28 Thread Jeff Kirsher
From: Md Fahad Iqbal Polash ice_bridge_getlink returns the current bridge mode using ndo_dflt_bridge_getlink and the mode parameter available in first_switch->bridge_mode. ice_bridge_setlink is invoked when the bridge mode needs to changed. The value to be changed to is available as a netlink me

[net-next 02/15] ice: Updates to Tx scheduler code

2018-08-28 Thread Jeff Kirsher
From: Anirudh Venkataramanan 1) The maximum device nodes is a global value and shared by the whole device. Add element AQ command would fail if there is no space to add new nodes so the check for max nodes isn't required. So remove ice_sched_get_num_nodes_per_layer and ice_sched_val_max_

[net-next 08/15] ice: Implement handlers for ethtool PHY/link operations

2018-08-28 Thread Jeff Kirsher
From: Chinh Cao This patch implements handlers for ethtool get_link_ksettings and set_link_ksettings. Helper functions use by these handlers are also introduced in this patch. Signed-off-by: Chinh Cao Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Jeff Kirsher

[net-next 14/15] ice: Introduce SERVICE_DIS flag and service routine functions

2018-08-28 Thread Jeff Kirsher
From: Akeem G Abodunrin This patch introduces SERVICE_DIS flag to use for stopping service task. This flag will be checked before scheduling new tasks. Also add new functions ice_service_task_stop to stop service task. Signed-off-by: Akeem G Abodunrin Signed-off-by: Anirudh Venkataramanan Test

[net-next 10/15] ice: Add support for Tx hang, Tx timeout and malicious driver detection

2018-08-28 Thread Jeff Kirsher
From: Sudheer Mogilappagari When a malicious operation is detected, the firmware triggers an interrupt, which is then picked up by the service task (specifically by ice_handle_mdd_event). A reset is scheduled if required. Tx hang detection works in a similar way, except the logic here monitors t

[net-next 15/15] ice: Fix and update driver version string

2018-08-28 Thread Jeff Kirsher
From: Anirudh Venkataramanan Remove the "ice" prefix for the driver version string and bump version to 0.7.1-k. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1

[net-next 06/15] ice: Refactor switch rule management structures and functions

2018-08-28 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch is an adaptation of the work originally done by Grishma Kotecha that in summary refactors the switch filtering logic in the driver. More specifically, - Update the recipe structure to also store list of rules - Update the existing code for recipes like M

[net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2018-08-28

2018-08-28 Thread Jeff Kirsher
This series contains new features and implementation updates for the ice driver. Anirudh reworks the current flex programming logic to add support for a second flex descriptor profile. Updated the transmit scheduler code to handle changes to the spec, specifically the firmware expects a 4KB buffe

[net-next 13/15] ice: Enable VSI Rx/Tx pruning only when VLAN 0 is active

2018-08-28 Thread Jeff Kirsher
From: Brett Creeley VLAN pruning is not valid when VLAN 0 is not active. If VLAN pruning is enabled and VLAN 0 is not active (8021q driver not loaded) then normal, non-VLAN, traffic will not pass. TX/RX VLAN pruning is enabled when the VLAN 0 is added to the active_vlan bitmap and it is disabled

[net-next 03/15] ice: Update request resource command to latest specification

2018-08-28 Thread Jeff Kirsher
From: Dan Nowlin Align Request Resource Ownership AQ command (0x0008) to the latest specification. This includes: - Correcting the resource IDs for the Global Cfg and Change locks. - new enum ICE_CHANGE_LOCK_RES_ID - new enum ICE_GLOBAL_CFG_LOCK_RES_ID - Altering the flow for Global Config Lock

[net-next 12/15] ice: Enable firmware logging during device initialization.

2018-08-28 Thread Jeff Kirsher
From: Hieu Tran To enable FW logging, the "cq_en" and "uart_en" enable bits of the "fw_log" element in struct ice_hw need to set accordingly based on some user-provided parameters during driver loading. To select which FW log events to be emitted, the "cfg" elements of corresponding FW modules in

[net-next 01/15] ice: Rework flex descriptor programming

2018-08-28 Thread Jeff Kirsher
From: Anirudh Venkataramanan The driver can support two flex descriptor profiles, ICE_RXDID_FLEX_NIC and ICE_RXDID_FLEX_NIC_2. This patch reworks the current flex programming logic to add support for the latter profile. Signed-off-by: Anirudh Venkataramanan Tested-by: Tony Brelinski Signed-off

Re: phys_port_id in switchdev mode?

2018-08-28 Thread Jakub Kicinski
Ugh, CC: netdev.. On Tue, 28 Aug 2018 20:05:39 +0200, Jakub Kicinski wrote: > Hi! > > I wonder if we can use phys_port_id in switchdev to group together > interfaces of a single PCI PF? Here is the problem: > > With a mix of PF and VF interfaces it gets increasingly difficult to > figure out wh

[PATCH net-next 1/2] ip: fail fast on IP defrag errors

2018-08-28 Thread Peter Oskolkov
The current behavior of IP defragmentation is inconsistent: - some overlapping/wrong length fragments are dropped without affecting the queue; - most overlapping fragments cause the whole frag queue to be dropped. This patch brings consistency: if a bad fragment is detected, the whole frag queue

[PATCH net-next 2/2] selftests/net: add ip_defrag selftest

2018-08-28 Thread Peter Oskolkov
This test creates a raw IPv4 socket, fragments a largish UDP datagram and sends the fragments out of order. Then repeats in a loop with different message and fragment lengths. Then does the same with overlapping fragments (with overlapping fragments the expectation is that the recv times out). T

[PATCH net-next] liquidio: fix race condition in instruction completion processing

2018-08-28 Thread Felix Manlunas
From: Rick Farrington In lio_enable_irq, the pkt_in_done count register was being cleared to zero. However, there could be some completed instructions which were not yet processed due to budget and limit constraints. So, only write this register with the number of actual completions that were pr

[PATCH net-next] liquidio: remove unnecessary delay when processing IQ responses

2018-08-28 Thread Felix Manlunas
From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/request_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/caviu

Re: [PATCH bpf-next 01/11] xdp: implement convert_to_xdp_frame for MEM_TYPE_ZERO_COPY

2018-08-28 Thread Björn Töpel
Den tis 28 aug. 2018 kl 16:11 skrev Jesper Dangaard Brouer : > > On Tue, 28 Aug 2018 14:44:25 +0200 > Björn Töpel wrote: > > > From: Björn Töpel > > > > This commit adds proper MEM_TYPE_ZERO_COPY support for > > convert_to_xdp_frame. Converting a MEM_TYPE_ZERO_COPY xdp_buff to an > > xdp_frame is

Re: Oops running iptables -F OUTPUT

2018-08-28 Thread Andreas Schwab
On Aug 28 2018, Ard Biesheuvel wrote: > diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c > index 6a501b25dd85..57d09d5ceb1a 100644 > --- a/arch/powerpc/kernel/setup_64.c > +++ b/arch/powerpc/kernel/setup_64.c > @@ -779,7 +779,6 @@ EXPORT_SYMBOL(__per_cpu_offset); > >

Re: [Intel-wired-lan] [PATCH] i40e: report correct statistics when XDP is enabled

2018-08-28 Thread Björn Töpel
On 2018-08-28 19:00, Paul Menzel wrote: Dear Björn, On 08/24/18 16:00, Jesper Dangaard Brouer wrote: On Fri, 24 Aug 2018 13:21:59 +0200 Björn Töpel wrote: When XDP is enabled, the driver will report incorrect statistics. Received frames will reported as transmitted frames. This commits fix

Re: [Intel-wired-lan] [PATCH] i40e: report correct statistics when XDP is enabled

2018-08-28 Thread Paul Menzel
Dear Björn, On 08/24/18 16:00, Jesper Dangaard Brouer wrote: > On Fri, 24 Aug 2018 13:21:59 +0200 > Björn Töpel wrote: > >> When XDP is enabled, the driver will report incorrect >> statistics. Received frames will reported as transmitted frames. >> >> This commits fixes the i40e implementation

Re: [PATCH net 1/2] net_sched: reject unknown tcfa_action values

2018-08-28 Thread Cong Wang
On Tue, Aug 28, 2018 at 7:25 AM Paolo Abeni wrote: > > +int tcf_action_destroy_one(struct tc_action *a, int bind) > +{ > + struct tc_action *actions[] = { a, NULL }; > + > + return tcf_action_destroy(actions, bind); > +} Make it static. > + > static int tcf_action_put(struct tc_act

[PATCH net-next] net: thunderbolt: Convert to use SPDX identifier

2018-08-28 Thread Mika Westerberg
This gets rid of the licence boilerblate in favor of SPDX identifier which only takes a single line comment. Signed-off-by: Mika Westerberg --- drivers/net/thunderbolt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/thunderbolt.c b/drivers/net/thunderbolt.c

Re: [PATCH net] net/sched: act_pedit: fix dump of extended layered op

2018-08-28 Thread Cong Wang
On Mon, Aug 27, 2018 at 1:56 PM Davide Caratti wrote: > > in the (rare) case of failure in nla_nest_start(), missing NULL checks in > tcf_pedit_key_ex_dump() can make the following command > > # tc action add action pedit ex munge ip ttl set 64 > > dereference a NULL pointer: > > BUG: unable to

[bpf-next PATCH 1/2] bpf: sockmap test remove shutdown() calls

2018-08-28 Thread John Fastabend
Currently, we do a shutdown(sk, SHUT_RDWR) on both peer sockets and a shutdown on the sender as well. However, this is incorrect and can occasionally cause issues if you happen to have bad timing. First peer1 or peer2 may still be in use depending on the test and timing. Second we really should onl

[bpf-next PATCH 0/2] bpf: test_sockmap updates

2018-08-28 Thread John Fastabend
Two small test sockmap updates for bpf-next. These help me run some additional tests with test_sockmap. --- John Fastabend (2): bpf: sockmap test remove shutdown() calls bpf: use --cgroup in test_suite if supplied tools/testing/selftests/bpf/test_sockmap.c | 56 --

[bpf-next PATCH 2/2] bpf: use --cgroup in test_suite if supplied

2018-08-28 Thread John Fastabend
If the user supplies a --cgroup value in the arguments when running the test_suite go ahaead and run the self tests there. I use this to test with multiple cgroup users. Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/test_sockmap.c | 53 1 file chang

Re: Oops running iptables -F OUTPUT

2018-08-28 Thread Ard Biesheuvel
On 28 August 2018 at 15:56, Ard Biesheuvel wrote: > Hello Andreas, Nick, > > On 28 August 2018 at 06:06, Nicholas Piggin wrote: >> On Mon, 27 Aug 2018 19:11:01 +0200 >> Andreas Schwab wrote: >> >>> I'm getting this Oops when running iptables -F OUTPUT: >>> >>> [ 91.139409] Unable to handle ker

Re: [PATCH net] sctp: hold transport before accessing its asoc in sctp_transport_get_next

2018-08-28 Thread Xin Long
On Mon, Aug 27, 2018 at 9:08 PM Neil Horman wrote: > > On Mon, Aug 27, 2018 at 06:38:31PM +0800, Xin Long wrote: > > As Marcelo noticed, in sctp_transport_get_next, it is iterating over > > transports but then also accessing the association directly, without > > checking any refcnts before that, w

net-next is OPEN...

2018-08-28 Thread David Miller
You know the drill... http://vger.kernel.org/~davem/net-next.html

Re: [PATCH] iprule: Fix destination prefix output

2018-08-28 Thread Luca Boccassi
On Tue, 2018-08-28 at 16:27 +0200, Stefan Bader wrote: > When adding support for JSON output the new code for printing > the destination prefix adds a stray blank character before > the bitmask. This causes some user-space parsing to fail. > > Current output: >   ...: from x.x.x.x/l to y.y.y.y /l

Re: [PATCH net 0/3] ipv6: fix error path of inet6_init()

2018-08-28 Thread Xin Long
- Original Message - > The error path of inet6_init() can trigger multiple kernel panics, > mostly due to wrong ordering of cleanups. This series fixes those > issues. > > Sabrina Dubroca (3): > ipv6: fix cleanup ordering for ip6_mr failure > ipv6: fix cleanup ordering for pingv6 re

[PATCH] iprule: Fix destination prefix output

2018-08-28 Thread Stefan Bader
When adding support for JSON output the new code for printing the destination prefix adds a stray blank character before the bitmask. This causes some user-space parsing to fail. Current output: ...: from x.x.x.x/l to y.y.y.y /l Previous output: ...: from x.x.x.x/l to y.y.y.y/l Fixes: 0dd4ccc

[PATCH net 2/2] tc-testing: add test-cases for numeric and invalid control action

2018-08-28 Thread Paolo Abeni
Only the police action allows us to specify an arbitrary numeric value for the control action. This change introduces an explicit test case for the above feature and then leverage it for testing the kernel behavior for invalid control actions (reject). Signed-off-by: Paolo Abeni --- .../tc-testi

[PATCH net 1/2] net_sched: reject unknown tcfa_action values

2018-08-28 Thread Paolo Abeni
After the commit 802bfb19152c ("net/sched: user-space can't set unknown tcfa_action values"), unknown tcfa_action values are converted to TC_ACT_UNSPEC, but the common agreement is instead rejecting such configurations. This change also introduce an helper to simplify the destruction of a single a

[PATCH net 0/2] net_sched: reject unknown tcfa_action values

2018-08-28 Thread Paolo Abeni
As agreed some time ago, this changeset reject unknown tcfa_action values, instead of changing such values under the hood. A tdc test is included to verify the new behavior. Paolo Abeni (2): net_sched: reject unknown tcfa_action values tc-testing: add test-cases for numeric and invalid contro

  1   2   >