Use tcf spinlock to protect ipt action private data from concurrent
modification during dump. Ipt init already takes tcf spinlock when
modifying ipt state.
Signed-off-by: Vlad Buslov
---
net/sched/act_ipt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sched/act_ipt.c b/net/sched/ac
Rearrange pedit init code to only access pedit action data while holding
tcf spinlock. Change keys allocation type to atomic to allow it to execute
while holding tcf spinlock. Take tcf spinlock in dump function when
accessing pedit action data.
Signed-off-by: Vlad Buslov
---
net/sched/act_pedit.
Use tcf spinlock to protect police action private data from concurrent
modification during dump. (init already uses tcf spinlock when changing
police action state)
Pass tcf spinlock as estimator lock argument to gen_replace_estimator()
during action init.
Signed-off-by: Vlad Buslov
---
net/sche
Re-introduce mirred list spinlock, that was removed some time ago, in order
to protect it from concurrent modifications, instead of relying on rtnl
lock.
Use tcf spinlock to protect mirred action private data from concurrent
modification in init and dump. Rearrange access to mirred data in order t
Use tcf lock to protect tunnel key action struct private data from
concurrent modification in init and dump. Use rcu swap operation to
reassign params pointer under protection of tcf lock. (old params value is
not used by init, so there is no need of standalone rcu dereference step)
Remove rtnl lo
Move read of skbmod_p rcu pointer to be protected by tcf spinlock. Use tcf
spinlock to protect private skbmod data from concurrent modification during
dump.
Signed-off-by: Vlad Buslov
---
net/sched/act_skbmod.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/ne
Currently, all netlink protocol handlers for updating rules, actions and
qdiscs are protected with single global rtnl lock which removes any
possibility for parallelism. This patch set is a second step to remove
rtnl lock dependency from TC rules update path.
Recently, new rtnl registration flag R
Use tcf spinlock to protect vlan action private data from concurrent
modification during dump and init. Use rcu swap operation to reassign
params pointer under protection of tcf lock. (old params value is not used
by init, so there is no need of standalone rcu dereference step)
Remove rtnl asserti
Use tcf spinlock to protect gact action private state from concurrent
modification during dump and init. Remove rtnl assertion that is no longer
necessary.
Signed-off-by: Vlad Buslov
---
net/sched/act_gact.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/sched
Use tcf spinlock to protect private simple action data from concurrent
modification during dump. (simple init already uses tcf spinlock when
changing action state)
Signed-off-by: Vlad Buslov
---
net/sched/act_simple.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/net/s
Use tcf spinlock and rcu to protect params pointer from concurrent
modification during dump and init. Use rcu swap operation to reassign
params pointer under protection of tcf lock. (old params value is not used
by init, so there is no need of standalone rcu dereference step)
Ife action has meta-a
Use tcf spinlock to protect bpf action private data from concurrent
modification during dump and init. Remove rtnl lock assertion that is no
longer necessary.
Signed-off-by: Vlad Buslov
---
net/sched/act_bpf.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/net/sch
Extend rate estimator 'new' and 'replace' APIs with additional spinlock
parameter to be used by rtnl-unlocked actions to protect rate_est pointer
from concurrent modification.
Extract code that requires synchronization from gen_new_estimator into
__replace_estimator function in order to be used by
Use tcf spinlock to protect private sample action data from concurrent
modification during dump and init.
Signed-off-by: Vlad Buslov
---
net/sched/act_sample.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c
index
Use tcf lock to protect csum action struct private data from concurrent
modification in init and dump. Use rcu swap operation to reassign params
pointer under protection of tcf lock. (old params value is not used by
init, so there is no need of standalone rcu dereference step)
Remove rtnl assertio
On 08/06/2018 06:45 AM, Alexei Starovoitov wrote:
> On Sun, Aug 05, 2018 at 05:19:13PM -0700, Martin KaFai Lau wrote:
>> This patch changes the tools/lib/bpf/btf.[ch] to LGPL which
>> is inline with libbpf also.
>>
>> Signed-off-by: Martin KaFai Lau
>
> technically it's bpf tree material, but sin
On Sun, Aug 05, 2018 at 05:19:13PM -0700, Martin KaFai Lau wrote:
> This patch changes the tools/lib/bpf/btf.[ch] to LGPL which
> is inline with libbpf also.
>
> Signed-off-by: Martin KaFai Lau
technically it's bpf tree material, but since it changes
"comment" only and we're very late into the r
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 981467033a37d916649647fa3afe1fe99bba1817
commit: 91305f2812624c0cf7ccbb44133b66d3b24676e4 [457/471] ptp_qoriq: support
automatic configuration for ptp timer
config: arm-multi_v7_defconfig (attached as .confi
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 981467033a37d916649647fa3afe1fe99bba1817
commit: 6c5657d085ae8c13a8565b98e6a23fe68f0bede4 [1709/1739] bnxt_en: Add
support for ethtool get dump.
config: microblaze-allmodconfig (attached as .config)
compiler
On Sun, 2018-08-05 at 08:52 -0700, Linus Torvalds wrote:
> "long unsigned int" isn't _technically_ wrong. But we normally
> call that type "unsigned long".
So add a checkpatch test for it.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 20
1 file changed, 20 inserti
On 2018/8/6 8:33, David Miller wrote:
> From: zhong jiang
> Date: Sun, 5 Aug 2018 22:18:43 +0800
>
>> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
>> struct sk_buff *skb_trimmed = NULL;
>> const unsigned char *src;
>> struct igmphdr *ih;
>> -int
Hi all,
After merging the net-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/ptp/ptp_qoriq.o: In function `qoriq_ptp_probe':
ptp_qoriq.c:(.text+0xd0c): undefined reference to `__aeabi_uldivmod'
Caused by commit
91305f281262 ("ptp_qoriq: support automati
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 981467033a37d916649647fa3afe1fe99bba1817
commit: 6c5657d085ae8c13a8565b98e6a23fe68f0bede4 [1709/1739] bnxt_en: Add
support for ethtool get dump.
config: ia64-allmodconfig (attached as .config)
compiler: ia64
On Sun, Aug 5, 2018 at 8:37 PM David Miller wrote:
>
> From: Willem de Bruijn
> Date: Sun, 5 Aug 2018 15:48:01 -0400
>
> > From: Willem de Bruijn
> >
> > Initialize extack in dev_set_mtu and report only if set.
> >
> > Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> >
From: Vlad Buslov
Date: Sun, 5 Aug 2018 22:35:56 +0300
> Fix expected ip address to actually match configured ip address.
> Fix test to expect single matched filter.
>
> Signed-off-by: Vlad Buslov
> Acked-by: Jamal Hadi Salim
Applied.
From: Vlad Buslov
Date: Sun, 5 Aug 2018 22:37:09 +0300
> Match patterns for some skbedit tests contain duplicate whitespace that is
> not present in actual tc output. This causes tests to fail because they
> can't match required action, even when it was successfully created.
>
> Signed-off-by:
From: Vlad Buslov
Date: Sun, 5 Aug 2018 22:36:25 +0300
> Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
> on teardown. Leaking pipe action causes failures in other tests.
>
> Add additional teardown command to also flush gact actions.
>
> Signed-off-by: Vlad Buslov
From: Vlad Buslov
Date: Sun, 5 Aug 2018 22:36:44 +0300
> Match patterns for some connmark tests contain duplicate whitespace that is
> not present in actual tc output. This causes tests to fail because they
> can't match required action, even when it was successfully created.
>
> Fixes: 1dad0f9
From: Michael Chan
Date: Sun, 5 Aug 2018 16:51:45 -0400
> This series includes the usual firmware spec update. The driver has
> added external phy loopback test and phy setup retry logic that is
> needed during hotplug. In the SRIOV space, the driver has added a
> new VF resource allocation mo
From: Kalle Valo
Date: Sun, 05 Aug 2018 20:07:16 +0300
> a pull request to net-next tree for 4.19. If the merge window doesn't
> open today I'm planning to submit one more pull request later next week.
>
> Please let me know if you have any problems.
Pulled, thanks Kalle.
From: Willem de Bruijn
Date: Sun, 5 Aug 2018 15:48:01 -0400
> From: Willem de Bruijn
>
> Initialize extack in dev_set_mtu and report only if set.
>
> Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
> Reported-by: syzbot
> Signed-off-by: Willem de Bruijn
Someone bea
From: Xin Long
Date: Sun, 5 Aug 2018 22:46:07 +0800
> According to RFC791, 68 bytes is the minimum size of IPv4 datagram every
> device must be able to forward without further fragmentation while 576
> bytes is the minimum size of IPv4 datagram every device has to be able
> to receive, so in ip6
From: zhong jiang
Date: Sun, 5 Aug 2018 22:18:43 +0800
> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br,
> struct sk_buff *skb_trimmed = NULL;
> const unsigned char *src;
> struct igmphdr *ih;
> - int err;
> + int err = 0;
>
> err =
From: Johan Hedberg
Date: Sun, 5 Aug 2018 09:14:30 +0300
> Here's the main bluetooth-next pull request for the 4.19 kernel.
>
> - Added support for Bluetooth Advertising Extensions
> - Added vendor driver support to hci_h5 HCI driver
> - Added serdev support to hci_h5 driver
> - Added suppor
From: Ido Schimmel
Date: Sun, 5 Aug 2018 09:03:05 +0300
> Petr says:
>
> Due to an issue in Spectrum chips, when unicast traffic shares the same
> queue as BUM traffic, and there is a congestion, the BUM traffic is
> admitted to the queue anyway, thus pushing out all UC traffic. In order
> to g
From: "Gustavo A. R. Silva"
Date: Sat, 4 Aug 2018 21:42:05 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1402059 ("Missing break in switch")
> Addresses-Coverity-ID: 1402060 ("Missing break in swi
From: Al Viro
Date: Sat, 4 Aug 2018 21:41:27 +0100
> __inet6_lookup_established() expect th->dport passed in host-endian,
> not net-endian. The reason is microoptimization in __inet6_lookup(),
> but if you use the lower-level helpers, you have to play by their
> rules...
>
> Signed-off-by:
From: Dan Carpenter
Date: Fri, 3 Aug 2018 22:27:55 +0300
> We forgot to set the error code on this path, so we return NULL instead
> of an error pointer. In the current code kzalloc() won't fail for small
> allocations so this doesn't really affect runtime.
>
> Fixes: b95ec7eb3b4d ("net: sched:
From: Li RongQing
Date: Fri, 3 Aug 2018 15:45:21 +0800
> dev_set_mtu_ext is able to fail with a valid mtu value, at that
> condition, extack._msg is not set and random since it is in stack,
> then kernel will crash when print it.
>
> Fixes: 7a4c53bee3324a ("net: report invalid mtu value via net
On Fri, Aug 03, 2018 at 10:41:12AM +0200, Daniel Borkmann wrote:
> On 08/01/2018 07:09 AM, Tobin C. Harding wrote:
> > There are a few minor typos and grammatical issues. We should however
> > try to keep the current flavour of the document.
> >
> > Fix typos and grammar if glaringly required.
>
From: Cong Wang
Date: Thu, 2 Aug 2018 23:20:38 -0700
> All the callers of ip6_rt_copy_init()/rt6_set_from() hold refcnt
> of the "from" fib6_info, so there is no need to hold fib6_metrics
> refcnt again, because fib6_metrics refcnt is only released when
> fib6_info is gone, that is, they have th
On Fri, Aug 03, 2018 at 10:44:23AM +0200, Daniel Borkmann wrote:
> On 08/01/2018 07:09 AM, Tobin C. Harding wrote:
> [...]
> > -Starting bpf_dbg is trivial and just requires issuing:
> > +Starting bpf_dbg is trivial and just requires issuing::
> >
> > -# ./bpf_dbg
> > + # ./bpf_dbg
> >
> > In
From: Florian Westphal
Date: Fri, 3 Aug 2018 02:22:20 +0200
> don't bother with pathological cases, they only waste cycles.
> IPv6 requires a minimum MTU of 1280 so we should never see fragments
> smaller than this (except last frag).
>
> v3: don't use awkward "-offset + len"
> v2: drop IPv4 pa
On Sun, 5 Aug 2018 22:18:43 +0800
zhong jiang wrote:
> The err is not used after initalization, So remove it and make
> it void function.
>
> Signed-off-by: zhong jiang
Makes sense to me.
Acked-by: Stephen Hemminger
This patch changes the tools/lib/bpf/btf.[ch] to LGPL which
is inline with libbpf also.
Signed-off-by: Martin KaFai Lau
---
tools/lib/bpf/btf.c | 2 +-
tools/lib/bpf/btf.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
index 2d270
Michal Kubecek wrote:
> On Mon, Aug 06, 2018 at 01:15:37AM +0200, Florian Westphal wrote:
> > Michal Kubecek wrote:
> > > Oops, exactly this issue was already discussed almost a year ago:
> > >
> > > http://lkml.kernel.org/r/20170824104824.2c318a0...@unicorn.suse.cz
> > >
> > > But something
From: Peter Oskolkov
Date: Thu, 2 Aug 2018 22:45:57 +
> This patchset
> * changes IPv4 defrag behavior to match that of IPv6: overlapping
>fragments now cause the whole IP datagram to be discarded (suggested
>by David Miller): there are no legitimate use cases for overlapping
>f
From: Vakul Garg
Date: Thu, 2 Aug 2018 20:43:10 +0530
> Function zerocopy_from_iter() unmarks the 'end' in input sgtable while
> adding new entries in it. The last entry in sgtable remained unmarked.
> This results in KASAN error report on using apis like sg_nents(). Before
> returning, the func
From: Yangbo Lu
Date: Wed, 1 Aug 2018 18:05:52 +0800
> This patch is to add clocks property for fman ptp timer node.
>
> Signed-off-by: Yangbo Lu
> ---
> Changes for v2:
> - None.
Applied.
From: Georg Kohmann
Date: Thu, 2 Aug 2018 13:56:58 +0200
> When a ICMPV6_PKT_TOOBIG is received from a link local address the pmtu will
> be updated on a route with an arbitrary interface index. Subsequent packets
> sent back to the same link local address may therefore end up not
> considering
From: Yangbo Lu
Date: Wed, 1 Aug 2018 18:05:54 +0800
> This patch is to support automatic configuration for ptp timer.
> If required ptp dts properties are not provided, driver could
> try to calculate a set of default configurations to initialize
> the ptp timer. This makes the driver work for
From: Yangbo Lu
Date: Wed, 1 Aug 2018 18:05:53 +0800
> This patch is to add clocks property for fman ptp timer node.
>
> Signed-off-by: Yangbo Lu
> ---
> Changes for v2:
> - None.
Applied.
On Mon, Aug 06, 2018 at 01:15:37AM +0200, Florian Westphal wrote:
> Michal Kubecek wrote:
> > Oops, exactly this issue was already discussed almost a year ago:
> >
> > http://lkml.kernel.org/r/20170824104824.2c318a0...@unicorn.suse.cz
> >
> > But something more urgent came and I forgot to get
From: Pablo Neira Ayuso
Date: Sun, 5 Aug 2018 23:21:20 +0200
> The following patchset contains Netfilter updates for your net-next tree:
...
> You can pull these changes from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git
Pulled, thanks Pablo.
Dominique Martinet wrote on Sun, Aug 05, 2018:
> It's getting late but I'll try adding a pskb_pull in there tomorrow, it
> would be better to make the bpf program start with an offset but I don't
> think that'll be easy to change...
I can confirm the following patch fixes the issue for me:
-8<
Michal Kubecek wrote:
> Oops, exactly this issue was already discussed almost a year ago:
>
> http://lkml.kernel.org/r/20170824104824.2c318a0...@unicorn.suse.cz
>
> But something more urgent came and I forgot to get back to it. :-(
I did not even remeber, thanks for the pointer.
So I think be
On Sun, Aug 05, 2018 at 11:03:42PM +0200, Florian Westphal wrote:
> Satish Patel wrote:
> > Florian,
> >
> > It seems those rules coming from here
> > https://github.com/openstack/openstack-ansible-os_neutron/blob/master/files/post-up-metadata-checksum
>
> This is crazy, and, as you found, it do
Satish Patel wrote:
> Florian,
>
> It seems those rules coming from here
> https://github.com/openstack/openstack-ansible-os_neutron/blob/master/files/post-up-metadata-checksum
This is crazy, and, as you found, it doesn't even do what they seem to
think it does.
I see no reason for these rules
Satish Patel wrote:
> After reading further related DHCP checksum issue, it seems we need
> that rules when you running DHCP on same host machine where your guest
> using host DHCP service, in that case virtual nic won't do checksum.
> If your DHCP running on different host then your physical nic
The driver gathers statistics using 2 mechanisms. Some stats are DMA'ed
directly from hardware and others are polled from the driver's timer.
Currently, we only adjust the DMA frequency based on the ethtool
stats-block-usecs setting. This patch adjusts the driver's timer
frequency as well to make
The new mode is "minimal-static" to be used when resources are more
limited to support a large number of VFs, for example The PF driver
will provision guaranteed minimum resources of 0. Each VF has no
guranteed resources until it tries to reserve resources during device
open.
Signed-off-by: Mich
After reading further related DHCP checksum issue, it seems we need
that rules when you running DHCP on same host machine where your guest
using host DHCP service, in that case virtual nic won't do checksum.
If your DHCP running on different host then your physical nic perform
checksum.
On Sun, Au
During hotplug, the driver's open function can be called almost
immediately after power on reset. The PHY may not be ready and the
firmware may return failure when the driver tries to update PHY
settings. Add retry logic fired from the driver's timer to retry
the operation for 5 seconds.
Signed-
The CNP CoS queue is reserved for internal RDMA Congestion Notification
Packets (CNP) and should not be used for a TC. Modify the CoS queue
discovery code to skip over the CNP CoS queue and to reduce
bp->max_tc accordingly. However, if RDMA is disabled in NVRAM, the
the CNP CoS queue can be used
Use latest firmware API to notify firmware about IF state changes.
Firmware has the option to clean up resources during IF down and
to require the driver to reserve resources again during IF up.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 53 ++
Set the default hash mode flag in HWRM_VNIC_RSS_CFG to signal to the
firmware that the driver is compliant with the latest spec. With
that, the firmware can return expanded RSS profile IDs that the driver
checks to setup the proper gso_type for GRO-HW packets. But instead
of checking for the new
From: Vasundhara Volam
Add support to collect live firmware coredump via ethtool.
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.h | 66
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 333 +
driv
Add code to detect firmware support for external loopback and the extra
test entry for external loopback.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +++
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 ++
drivers/net/ethernet/broadcom/bnxt/bnxt
New interface has firmware core dump support, new extended port
statistics, and IF state change notifications to the firmware.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.h |4 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c |8 +-
drivers/net/eth
Expand the .ieee_setapp() and ieee_delapp() DCBNL methods to support
DSCP. This allows DSCP values to user priority mappings instead
of using VLAN priorities. Each DSCP mapping is added or deleted one
entry at a time using the firmware API. The firmware call can only be
made from a PF.
Signed-o
From: Vasundhara Volam
Export temperature sensor reading via hwmon sysfs.
Signed-off-by: Vasundhara Volam
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/Kconfig | 8
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 62 +++
drivers/net/ethernet/b
This series includes the usual firmware spec update. The driver has
added external phy loopback test and phy setup retry logic that is
needed during hotplug. In the SRIOV space, the driver has added a
new VF resource allocation mode that requires the VF driver to
reserve resources during IFUP. I
The BNXT_FLAG_NEW_RM flag is checked a lot in the code to determine if
the new resource manager is in effect. Define a macro to perform
this check.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 +++
drivers/net/ethernet/broadcom/bnxt/
The flags field is almost getting full. Move firmware capability flags
to a new fw_cap field to better organize these firmware flags.
Signed-off-by: Michael Chan
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 12 ++--
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 13 +++--
Florian,
I have removed those port 80 CHECKSUM rules and everything looks good
i didn't see kernel WARN mesg.
Thank you so much! You just nailed it :)
On Sun, Aug 5, 2018 at 4:15 PM, Satish Patel wrote:
> Florian,
>
> It seems those rules coming from here
> https://github.com/openstack/openstac
Florian,
It seems those rules coming from here
https://github.com/openstack/openstack-ansible-os_neutron/blob/master/files/post-up-metadata-checksum
On Sun, Aug 5, 2018 at 4:09 PM, Satish Patel wrote:
> Yes this is openstack-ansible deployment tool which set them up. I am
> wondering where are t
Yes this is openstack-ansible deployment tool which set them up. I am
wondering where are these rules saved? I believe openstack-ansible use
LXC container to deploy services so must be part of LXC startup
scripts.
I have checked there is no firewalld and iptables service running on system..
You t
Satish Patel wrote:
> > [84166:59495417] -A POSTROUTING -p tcp -m tcp --sport 80 -j CHECKSUM
> > --checksum-fill
> > [68739:5153476] -A POSTROUTING -p tcp -m tcp --sport 8000 -j CHECKSUM
> > --checksum-fill
These rules make no sense to me, and are also source of your backtrace.
Who set this up?
I am configured where are those rules stored why iptables -L -n -t nat
not showing them?
On Sun, Aug 5, 2018 at 3:56 PM, Satish Patel wrote:
> Oh wait!! I think you are right there i didn't notice that iptables
> has following setting.
>
> "CHECKSUM --checksum-fill"
>
> On Sun, Aug 5, 2018 at 3:5
Oh wait!! I think you are right there i didn't notice that iptables
has following setting.
"CHECKSUM --checksum-fill"
On Sun, Aug 5, 2018 at 3:54 PM, Satish Patel wrote:
> I have following kernel logging set.
>
> [root@ostack-infra-02 tools]# cat /proc/sys/kernel/printk
> 3 4 1 3
>
>
> iptables
I have following kernel logging set.
[root@ostack-infra-02 tools]# cat /proc/sys/kernel/printk
3 4 1 3
iptables output
[root@ostack-infra-02 tools]# iptables-save -c
# Generated by iptables-save v1.4.21 on Sun Aug 5 15:52:56 2018
*raw
:PREROUTING ACCEPT [42284573:38782693391]
:OUTPUT ACCEPT [2
From: Willem de Bruijn
Initialize extack in dev_set_mtu and report only if set.
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Reported-by: syzbot
Signed-off-by: Willem de Bruijn
---
net/core/dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Satish Patel wrote:
> Thanks Florian,
>
> FYI, I don't have any CHECKSUM configure in my iptables,
You have, according to WARN stacktrace you provided.
iptables-save -c
ip6tables-save -c
Match patterns for some skbedit tests contain duplicate whitespace that is
not present in actual tc output. This causes tests to fail because they
can't match required action, even when it was successfully created.
Signed-off-by: Vlad Buslov
Acked-by: Jamal Hadi Salim
---
.../tc-testing/tc-test
Match patterns for some connmark tests contain duplicate whitespace that is
not present in actual tc output. This causes tests to fail because they
can't match required action, even when it was successfully created.
Fixes: 1dad0f97 ("tc-testing: add connmark action tests")
Signed-off-by: Vlad
Test 6fb4 creates one mirred and one pipe action, but only flushes mirred
on teardown. Leaking pipe action causes failures in other tests.
Add additional teardown command to also flush gact actions.
Signed-off-by: Vlad Buslov
Acked-by: Jamal Hadi Salim
---
tools/testing/selftests/tc-testing/tc
Fix expected ip address to actually match configured ip address.
Fix test to expect single matched filter.
Signed-off-by: Vlad Buslov
Acked-by: Jamal Hadi Salim
---
tools/testing/selftests/tc-testing/tc-tests/filters/tests.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
for (i = 0; i < 2048; i++) {
...
req->l2t_idx = htonl(V_L2T_W_IDX(i));
...
in there is very odd; l2t_idx is a 16bit field, and
#define V_L2T_W_IDX(x) ((x) << S_L2T_W_IDX)
#define S_L2T_W_IDX0
IOW, we are taking htonl(something in range 0..2047) and
shove it int
Unlike fs.val.lport and fs.val.fport, cxgb4_process_flow_match()
sets fs.val.{l,f}ip to net-endian values without conversion - they come
straight from flow_dissector_key_ipv4_addrs ->dst and ->src resp. So
the assignment in mk_act_open_req() ought to be a straigh copy.
As far as I
On Sun, Aug 05, 2018 at 04:28:11PM +0100, Al Viro wrote:
> On little-endian host those do yield the right values - e.g. 0x1100 is
> {0, 17, 0, 0}, etc. On big-endian, though, these will end up checking
> in IPv4 case the octet at offset 10 (i.e. upper 16 bits of checksum) and for
> IPv6
> - the o
AFAICS, cxgb4_next_header() expects to find match_val/match_mask in
struct cxgb4_next_header stored as big-endian:
/* Found a possible candidate. Find a key that
* matches the corresponding offset, value, and
* mas
> > You should have a PHY device of some sort. Either a traditional
> > copper PHY, or an SFP module. There should be a driver for this PHY.
> > This could be one of those in drivers/net/phy. Or it could be
> > firmware running, running on a little microcontroller inside your
> > FPGA?
>
> in my
According to RFC791, 68 bytes is the minimum size of IPv4 datagram every
device must be able to forward without further fragmentation while 576
bytes is the minimum size of IPv4 datagram every device has to be able
to receive, so in ip6_tnl_xmit(), 68(IPV4_MIN_MTU) should be the right
value for the
Dominique Martinet wrote on Sun, Aug 05, 2018:
> (I'm not sure about offset, since we pass the full skb to parse message,
> wouldn't it look at the start of the buffer everytime? Well, offset
> seems to be 0 everytime the first time that check fails so I can
> probably ignore that for now...)
Oh,
Thanks Florian,
FYI, I don't have any CHECKSUM configure in my iptables, i have
following rules, also do you think this kernel WARNNING is just
warning and not impacting my performance, based on that i have to
decided criticality of this issue.
[root@ostack-infra-02 ~]# iptables -L -n
Chain INPUT
On Fri, Aug 03, 2018 at 12:42:22PM -0700, David Miller wrote:
> From: Guillaume Nault
> Date: Fri, 3 Aug 2018 17:00:11 +0200
>
> > If 'session' is not NULL and is not a PPP pseudo-wire, then we fail to
> > drop the reference taken by l2tp_session_get().
> >
> > Fixes: ecd012e45ab5 ("l2tp: filter
On Sun, 5 Aug 2018, Andrew Lunn wrote:
> On Sat, Aug 04, 2018 at 07:06:58AM -0400, Robert P. J. Day wrote:
> >
> > i'll try to keep this (relatively) short as there may be a
> > simple answer to this, or it could just be a stupid question --
> > sort of related to previous question (thank you, f
Satish Patel wrote:
> I am installing openstack and as you know i have lots of bridges and
> vlan interface on my Linux CentOS 7.5
>
> I was getting following error stack on 3.10 kernel and found this is
> kernel bug which required kernel upgrade so now i have upgraded my
> kernel to 4.17.12 but
98 matches
Mail list logo
