Re: [PATCH v6 bpf-next 4/9] veth: Handle xdp_frames in xdp napi ring

2018-07-31 Thread Toshiaki Makita
On 2018/07/31 21:46, Jesper Dangaard Brouer wrote: > On Tue, 31 Jul 2018 19:40:08 +0900 > Toshiaki Makita wrote: > >> On 2018/07/31 19:26, Jesper Dangaard Brouer wrote: >>> >>> Context needed from: [PATCH v6 bpf-next 2/9] veth: Add driver XDP >>> >>> On Mon, 30 Jul 2018 19:43:44 +0900 >>> Toshiak

Re: [PATCH net-next] xfrm: Make function xfrmi_get_link_net() static

2018-07-31 Thread Steffen Klassert
On Sat, Jul 28, 2018 at 06:49:48AM +, Wei Yongjun wrote: > Fixes the following sparse warning: > > net/xfrm/xfrm_interface.c:745:12: warning: > symbol 'xfrmi_get_link_net' was not declared. Should it be static? > > Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") > Signed-off-by: We

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-31 Thread Sagi Grimberg
Hi Max, Yes, since nvmf is the only user of this function. Still waiting for comments on the suggested patch :) Sorry for the late response (but I'm on vacation so I have an excuse ;)) I'm thinking that we should avoid trying to find an assignment when stuff like irqbalance daemon is running

Re: [patch net-next 2/2] net: sched: fix notifications for action-held chains

2018-07-31 Thread Cong Wang
On Tue, Jul 31, 2018 at 5:10 AM Jiri Pirko wrote: > > From: Jiri Pirko > > Chains that only have action references serve as placeholders. > Until a non-action reference is created, user should not be aware > of the chain. Also he should not receive any notifications about it. > So send notificati

Re: [patch net-next 1/2] net: sched: change name of zombie chain to "held_by_acts_only"

2018-07-31 Thread Cong Wang
On Tue, Jul 31, 2018 at 5:10 AM Jiri Pirko wrote: > > From: Jiri Pirko > > As mentioned by Cong and Jakub during the review process, it is a bit > odd to sometimes (act flow) create a new chain which would be > immediately a "zombie". So just rename it to "held_by_acts_only". > > Signed-off-by: J

Re: [PATCH net-next] tcp: remove set but not used variable 'skb_size'

2018-07-31 Thread Eric Dumazet
On 07/31/2018 06:59 PM, Wei Yongjun wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > net/ipv4/tcp_output.c: In function 'tcp_collapse_retrans': > net/ipv4/tcp_output.c:2700:6: warning: > variable 'skb_size' set but not used [-Wunused-but-set-variable] > int skb_size, next_skb_size

[PATCH net-next] tcp: remove set but not used variable 'skb_size'

2018-07-31 Thread Wei Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: net/ipv4/tcp_output.c: In function 'tcp_collapse_retrans': net/ipv4/tcp_output.c:2700:6: warning: variable 'skb_size' set but not used [-Wunused-but-set-variable] int skb_size, next_skb_size; ^ Signed-off-by: Wei Yongjun --- net/ipv4/tcp_o

[PATCH v2 net-next 0/5] tcp: add 4 new stats

2018-07-31 Thread Wei Wang
From: Wei Wang This patch series adds 3 RFC4898 stats: 1. tcpEStatsPerfHCDataOctetsOut 2. tcpEStatsPerfOctetsRetrans 3. tcpEStatsStackDSACKDups and an addtional stat to record the number of data packet reordering events seen: 4. tcp_reord_seen Together with the existing stats, application can us

[PATCH v2 net-next 2/5] tcp: add data bytes sent stats

2018-07-31 Thread Wei Wang
From: Wei Wang Introduce a new TCP stat to record the number of bytes sent (RFC4898 tcpEStatsPerfHCDataOctetsOut) and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell Acked-by: Soheil

[PATCH v2 net-next 5/5] tcp: add stat of data packet reordering events

2018-07-31 Thread Wei Wang
From: Wei Wang Introduce a new TCP stats to record the number of reordering events seen and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Application can use this stats to track the frequency of the reordering events in addition to the existing reordering stats

[PATCH v2 net-next 4/5] tcp: add dsack blocks received stats

2018-07-31 Thread Wei Wang
From: Wei Wang Introduce a new TCP stat to record the number of DSACK blocks received (RFC4989 tcpEStatsStackDSACKDups) and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell Acked-by: S

[PATCH v2 net-next 3/5] tcp: add data bytes retransmitted stats

2018-07-31 Thread Wei Wang
From: Wei Wang Introduce a new TCP stat to record the number of bytes retransmitted (RFC4898 tcpEStatsPerfOctetsRetrans) and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell Acked-by:

[PATCH v2 net-next 1/5] tcp: add a helper to calculate size of opt_stats

2018-07-31 Thread Wei Wang
From: Wei Wang This is to refactor the calculation of the size of opt_stats to a helper function to make the code cleaner and easier for later changes. Suggested-by: Stephen Hemminger Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell Acked-by: Soheil Hassas Yeganeh

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-07-31 Thread Pravin Shelar
On Tue, Jul 31, 2018 at 12:43 PM, Matteo Croce wrote: > On Mon, Jul 16, 2018 at 4:54 PM Matteo Croce wrote: >> >> On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote: >> > >> > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote: >> > > From: Stefano Brivio >> > > >> > > Open vSwitch sends to u

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-07-31 Thread Ben Pfaff
On Tue, Jul 31, 2018 at 07:43:34PM +, Matteo Croce wrote: > On Mon, Jul 16, 2018 at 4:54 PM Matteo Croce wrote: > > > > On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote: > > > > > > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote: > > > > From: Stefano Brivio > > > > > > > > Open vSwi

Re: [PATCH net] enic: do not call enic_change_mtu in enic_probe

2018-07-31 Thread David Miller
From: Govindarajulu Varadarajan Date: Mon, 30 Jul 2018 09:56:54 -0700 > In commit ab123fe071c9 ("enic: handle mtu change for vf properly") > ASSERT_RTNL() is added to _enic_change_mtu() to prevent it from being > called without rtnl held. enic_probe() calls enic_change_mtu() > without rtnl held.

Re: [PATCH net] ipv4: frags: handle possible skb truesize change

2018-07-31 Thread David Miller
From: Eric Dumazet Date: Mon, 30 Jul 2018 21:50:29 -0700 > ip_frag_queue() might call pskb_pull() on one skb that > is already in the fragment queue. > > We need to take care of possible truesize change, or we > might have an imbalance of the netns frags memory usage. > > IPv6 is immune to this

Re: [PATCH net] inet: frag: enforce memory limits earlier

2018-07-31 Thread David Miller
From: Eric Dumazet Date: Mon, 30 Jul 2018 20:09:11 -0700 > We currently check current frags memory usage only when > a new frag queue is created. This allows attackers to first > consume the memory budget (default : 4 MB) creating thousands > of frag queues, then sending tiny skbs to exceed high_

Re: [pull request][net 0/4] Mellanox, mlx5 fixes 2018-07-31

2018-07-31 Thread David Miller
From: Saeed Mahameed Date: Tue, 31 Jul 2018 13:29:55 -0700 > The following series includes four mlx5 fixes. > > Please pull and let me know if there's any problem. > > For -stable v4.14 > net/mlx5e: E-Switch, Initialize eswitch only if eswitch manager > > For -stable v4.16 > net/mlx5e: Set por

Re: [PATCH v2] bpf: verifier: MOV64 don't mark dst reg unbounded

2018-07-31 Thread Daniel Borkmann
On 07/31/2018 07:17 PM, Arthur Fabre wrote: > When check_alu_op() handles a BPF_MOV64 between two registers, > it calls check_reg_arg(DST_OP) on the dst register, marking it as unbounded. > If the src and dst register are the same, this marks the src as > unbounded, which can lead to unexpected err

[net 3/4] net/mlx5e: Fix null pointer access when setting MTU of vport representor

2018-07-31 Thread Saeed Mahameed
From: Adi Nissim MTU helper function is used by both conventional mlx5e instances (PF/VF) and the eswitch representors. The representor shouldn't change the nic vport context MTU, the VF is responsible for that. Therefore set_mtu_cb has a null value when changing the representor MTU. Fixes: 250a

[net 1/4] net/mlx5e: E-Switch, Initialize eswitch only if eswitch manager

2018-07-31 Thread Saeed Mahameed
From: Eli Cohen Execute mlx5_eswitch_init() only if we have MLX5_ESWITCH_MANAGER capabilities. Do the same for mlx5_eswitch_cleanup(). Fixes: a9f7705ffd66 ("net/mlx5: Unify vport manager capability check") Signed-off-by: Eli Cohen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellano

[net 2/4] net/mlx5e: Set port trust mode to PCP as default

2018-07-31 Thread Saeed Mahameed
From: Or Gerlitz The hairpin offload code has dependency on the trust mode being PCP. Hence we should set PCP as the default for handling cases where we are disallowed to read the trust mode from the FW, or failed to initialize it. Fixes: 106be53b6b0a ('net/mlx5e: Set per priority hairpin pairs

[net 4/4] net/mlx5e: IPoIB, Set the netdevice sw mtu in ipoib enhanced flow

2018-07-31 Thread Saeed Mahameed
From: Feras Daoud After introduction of the cited commit, mlx5e_build_nic_params receives the netdevice mtu in order to set the sw_mtu of mlx5e_params. For enhanced IPoIB, the netdevice mtu is not set in this stage, therefore, the initial sw_mtu equals zero. As a result, the hw_mtu of the receive

[pull request][net 0/4] Mellanox, mlx5 fixes 2018-07-31

2018-07-31 Thread Saeed Mahameed
Hi Dave, The following series includes four mlx5 fixes. Please pull and let me know if there's any problem. For -stable v4.14 net/mlx5e: E-Switch, Initialize eswitch only if eswitch manager For -stable v4.16 net/mlx5e: Set port trust mode to PCP as default For -stable v4.17 net/mlx5e: IPoIB, S

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

2018-07-31 Thread Matteo Croce
On Mon, Jul 16, 2018 at 4:54 PM Matteo Croce wrote: > > On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote: > > > > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote: > > > From: Stefano Brivio > > > > > > Open vSwitch sends to userspace all received packets that have > > > no associated flow

[PATCH net-next v1] net: add helpers checking if socket can be bound to nonlocal address

2018-07-31 Thread Vincent Bernat
The construction "net->ipv4.sysctl_ip_nonlocal_bind || inet->freebind || inet->transparent" is present three times and its IPv6 counterpart is also present three times. We introduce two small helpers to characterize these tests uniformly. Signed-off-by: Vincent Bernat --- include/net/inet_sock.h

RE: Issue with driver i40e stat strings count mismatch

2018-07-31 Thread Keller, Jacob E
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Stefan Assmann > Sent: Tuesday, July 31, 2018 12:06 AM > To: Jesper Dangaard Brouer ; Kirsher, Jeffrey T > > Cc: Topel, Bjorn ; Duyck, Alexander H > ; intel-wired-lan l...@list

RE: [Intel-wired-lan] Issue with driver i40e stat strings count mismatch

2018-07-31 Thread Keller, Jacob E
> -Original Message- > From: Wyborny, Carolyn > Sent: Tuesday, July 31, 2018 8:53 AM > To: Jesper Dangaard Brouer ; Stefan Assmann > ; Keller, Jacob E > Cc: netdev@vger.kernel.org; intel-wired-lan > ; > Topel, Bjorn ; Keller, Jacob E > > Subject: RE: [Intel-wired-lan] Issue with driver

Re: [PATCH v2] bpf: verifier: MOV64 don't mark dst reg unbounded

2018-07-31 Thread Edward Cree
On 31/07/18 18:17, Arthur Fabre wrote: > When check_alu_op() handles a BPF_MOV64 between two registers, > it calls check_reg_arg(DST_OP) on the dst register, marking it as unbounded. > If the src and dst register are the same, this marks the src as > unbounded, which can lead to unexpected errors f

Re: [PATCH net-next 2/2] rds: Remove IPv6 dependency

2018-07-31 Thread Santosh Shilimkar
On 7/30/2018 10:48 PM, Ka-Cheong Poon wrote: This patch removes the IPv6 dependency from RDS. Signed-off-by: Ka-Cheong Poon --- net/rds/Kconfig | 2 +- net/rds/af_rds.c | 32 +++- net/rds/bind.c | 4 +++- net/rds/connection.c | 2

Re: [patch net] net: dsa: mv88e6xxx: Fix SERDES support on 88E6141/6341

2018-07-31 Thread David Miller
From: Andrew Lunn Date: Tue, 31 Jul 2018 19:19:50 +0200 > Version 1 of the patch adding SERDES support to the 88E6141/6341 > correctly added the ops to the 88E6141/6341. However, by the time > version 3 was committed, the ops had moved to the 88E6085/6175. Put > them back where they belong. > >

Re: [PATCH net-next 1/2] rds: rds_ib_recv_alloc_cache() should call alloc_percpu_gfp() instead

2018-07-31 Thread Santosh Shilimkar
On 7/30/2018 10:48 PM, Ka-Cheong Poon wrote: Currently, rds_ib_conn_alloc() calls rds_ib_recv_alloc_caches() without passing along the gfp_t flag. But rds_ib_recv_alloc_caches() and rds_ib_recv_alloc_cache() should take a gfp_t parameter so that rds_ib_recv_alloc_cache() can call alloc_percpu_gf

[patch net] net: dsa: mv88e6xxx: Fix SERDES support on 88E6141/6341

2018-07-31 Thread Andrew Lunn
Version 1 of the patch adding SERDES support to the 88E6141/6341 correctly added the ops to the 88E6141/6341. However, by the time version 3 was committed, the ops had moved to the 88E6085/6175. Put them back where they belong. Fixes: 5bafeb6e7e87 ("net: dsa: mv88e6xxx: 88E6141/6341 SERDES support

[PATCH v2] bpf: verifier: MOV64 don't mark dst reg unbounded

2018-07-31 Thread Arthur Fabre
When check_alu_op() handles a BPF_MOV64 between two registers, it calls check_reg_arg(DST_OP) on the dst register, marking it as unbounded. If the src and dst register are the same, this marks the src as unbounded, which can lead to unexpected errors for further checks that rely on bounds info. For

Re: [PATCH net-next 1/3] qed: Add DCBX API - qed_dcbx_get_priority_tc()

2018-07-31 Thread David Miller
From: Denis Bolotin Date: Tue, 31 Jul 2018 10:26:06 +0300 > +int qed_dcbx_get_priority_tc(struct qed_hwfn *p_hwfn, u8 pri, u8 *p_tc) > +{ > + struct qed_dcbx_get *dcbx_info; > + int rc; > + > + if (pri >= QED_MAX_PFC_PRIORITIES) { > + DP_ERR(p_hwfn, "Invalid priority %d\n"

Re: [PATCH net-next 0/3] xsk: improvements to RX queue check and replace

2018-07-31 Thread David Miller
From: Daniel Borkmann Date: Tue, 31 Jul 2018 09:50:12 +0200 > On 07/31/2018 05:43 AM, Jakub Kicinski wrote: >> Hi! >> >> First 3 patches of my recent RFC. The first one make the check against >> real_num_rx_queues slightly more reliable, while the latter two redefine >> XDP_QUERY_XSK_UMEM sligh

Re: [net-next PATCH] mlx5: handle DMA mapping error case for XDP redirect

2018-07-31 Thread David Miller
From: Tariq Toukan Date: Tue, 31 Jul 2018 09:35:37 +0300 > On 30/07/2018 8:49 PM, Jesper Dangaard Brouer wrote: >> Commit 58b99ee3e3eb ("net/mlx5e: Add support for XDP_REDIRECT in >> device-out side") >> forgot to return/free the xdp_frame in case the DMA mapping failed, >> correct this. >> Also

RE: [Intel-wired-lan] Issue with driver i40e stat strings count mismatch

2018-07-31 Thread Wyborny, Carolyn
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Jesper Dangaard Brouer > Sent: Tuesday, July 31, 2018 7:29 AM > To: Stefan Assmann ; Keller, Jacob E > > Cc: netdev@vger.kernel.org; intel-wired-lan l...@lists.osuosl.org>; bro...@redha

Re: [PATCH net] inet: frag: enforce memory limits earlier

2018-07-31 Thread Florian Westphal
Jann Horn wrote: > On Tue, Jul 31, 2018 at 7:54 AM Florian Westphal wrote: > > > > Eric Dumazet wrote: > > > We currently check current frags memory usage only when > > > a new frag queue is created. This allows attackers to first > > > consume the memory budget (default : 4 MB) creating thousan

[PATCH V2 net-next 1/2] be2net: gather debug info and reset adapter (only for Lancer) on a tx-timeout

2018-07-31 Thread Suresh Reddy
This patch handles a TX-timeout as follows: 1) This patch gathers and prints the following info that can help in diagnosing the cause of a TX-timeout. a) TX queue and completion queue entries. b) SKB and TCP/UDP header details. 2) For Lancer NICs (TX-timeout recovery is not supported for

[PATCH V2 net-next 2/2] be2net: Update the driver version to 12.0.0.0

2018-07-31 Thread Suresh Reddy
Signed-off-by: Suresh Reddy --- drivers/net/ethernet/emulex/benet/be.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h index 7005949..d80fe03 100644 --- a/drivers/net/ethernet/emulex/benet/be.h ++

[PATCH V2 net-next 0/2] be2net: patch-set

2018-07-31 Thread Suresh Reddy
v1->v2 : Modified the subject line and commit log. Please consider applying these two patches to net-next. Suresh Reddy (2): be2net: gather debug info and reset adapter (only for Lancer) on a tx-timeout be2net: Update the driver version to 12.0.0.0 drivers/net/ethernet/emulex/benet/be.h

Re: [PATCH net] inet: frag: enforce memory limits earlier

2018-07-31 Thread Jann Horn
On Tue, Jul 31, 2018 at 7:54 AM Florian Westphal wrote: > > Eric Dumazet wrote: > > We currently check current frags memory usage only when > > a new frag queue is created. This allows attackers to first > > consume the memory budget (default : 4 MB) creating thousands > > of frag queues, then se

Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

2018-07-31 Thread Paolo Abeni
On Tue, 2018-07-31 at 09:53 -0400, Jamal Hadi Salim wrote: > BTW, I asked this earlier and Jiri said it was addressed in patch 2. > I just looked again and i may be missing something basic: > Lets say tomorrow in a new kernel we add new TC_ACT_XXX that then gets > exposed to uapi - so user space t

Re: Issue with driver i40e stat strings count mismatch

2018-07-31 Thread Jesper Dangaard Brouer
On Tue, 31 Jul 2018 09:05:40 +0200 Stefan Assmann wrote: > From: Stefan Assmann > To: Jesper Dangaard Brouer , Jeff Kirsher > > Cc: Björn Töpel , "alexander.h.du...@intel.com" > , intel-wired-lan > , "netdev@vger.kernel.org" > > Subject: Re: Issue with driver i40e stat strings count

Re: [PATCH rdma-next 00/27] Flow actions to mutate packets

2018-07-31 Thread Leon Romanovsky
On Sun, Jul 29, 2018 at 03:58:38PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This is PATCH variant of RFC posted in previous week to the ML. > https://patchwork.ozlabs.org/cover/944184/ > > Changelog: > RFC -> v0: > * Patch 1 a new patch which refactors the logic > w

[PATCH net] net: stmmac: Fix WoL for PCI-based setups

2018-07-31 Thread Jose Abreu
WoL won't work in PCI-based setups because we are not saving the PCI EP state before entering suspend state and not allowing D3 wake. Fix this by using a wrapper around stmmac_{suspend/resume} which correctly sets the PCI EP state. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto C

Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

2018-07-31 Thread Jamal Hadi Salim
On 31/07/18 05:41 AM, Paolo Abeni wrote: Before this patch, the kernel exposed the same behaviour for negative value of 'bar', while, for positive 'bar' values, the overall behaviour was more complex (some classifier always stops with unknown positive action value, others go to lower prio). >

[PATCH v2 net] bonding: avoid lockdep confusion in bond_get_stats()

2018-07-31 Thread Eric Dumazet
syzbot found that the following sequence produces a LOCKDEP splat [1] ip link add bond10 type bond ip link add bond11 type bond ip link set bond11 master bond10 To fix this, we can use the already provided nest_level. This patch also provides correct nesting for dev->addr_list_lock [1] WARNING:

Re: [PATCH net] bonding: avoid lockdep confusion in bond_get_stats()

2018-07-31 Thread Eric Dumazet
On 07/31/2018 06:25 AM, Eric Dumazet wrote: > syzbot found that the following sequence produces a LOCKDEP splat [1] > > ip link add bond10 type bond > ip link add bond11 type bond > ip link set bond11 master bond10 ... > +static struct lock_class_key bond_netdev_addr_lock_key; > + Oops, this

[PATCH net] bonding: avoid lockdep confusion in bond_get_stats()

2018-07-31 Thread Eric Dumazet
syzbot found that the following sequence produces a LOCKDEP splat [1] ip link add bond10 type bond ip link add bond11 type bond ip link set bond11 master bond10 To fix this, we can use the already provided nest_level. This patch also provides correct nesting for dev->addr_list_lock [1] WARNING:

Re: [PATCH net-next 1/3] net: update real_num_rx_queues even when !CONFIG_SYSFS

2018-07-31 Thread Jesper Dangaard Brouer
On Mon, 30 Jul 2018 20:43:51 -0700 Jakub Kicinski wrote: > We used to depend on real_num_rx_queues as a upper bound for sanity > checks. For AF_XDP socket validation it's useful if the check behaves > the same regardless of CONFIG_SYSFS setting. > > Signed-off-by: Jakub Kicinski > Reviewed-by:

Re: [PATCH v6 bpf-next 4/9] veth: Handle xdp_frames in xdp napi ring

2018-07-31 Thread Jesper Dangaard Brouer
On Tue, 31 Jul 2018 19:40:08 +0900 Toshiaki Makita wrote: > On 2018/07/31 19:26, Jesper Dangaard Brouer wrote: > > > > Context needed from: [PATCH v6 bpf-next 2/9] veth: Add driver XDP > > > > On Mon, 30 Jul 2018 19:43:44 +0900 > > Toshiaki Makita wrote: > > > >> +static struct sk_buff *vet

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

2018-07-31 Thread Michael S. Tsirkin
On Sun, Jul 29, 2018 at 05:32:56PM -0400, Willem de Bruijn wrote: > On Sun, Jul 29, 2018 at 12:01 PM David Miller wrote: > > > > From: Caleb Raitto > > Date: Mon, 23 Jul 2018 16:11:19 -0700 > > > > > From: Caleb Raitto > > > > > > The driver disables tx napi if it's not certain that completions

[patch net-next 2/2] net: sched: fix notifications for action-held chains

2018-07-31 Thread Jiri Pirko
From: Jiri Pirko Chains that only have action references serve as placeholders. Until a non-action reference is created, user should not be aware of the chain. Also he should not receive any notifications about it. So send notifications for the new chain only in case the chain gets the first non-

[patch net-next 1/2] net: sched: change name of zombie chain to "held_by_acts_only"

2018-07-31 Thread Jiri Pirko
From: Jiri Pirko As mentioned by Cong and Jakub during the review process, it is a bit odd to sometimes (act flow) create a new chain which would be immediately a "zombie". So just rename it to "held_by_acts_only". Signed-off-by: Jiri Pirko Suggested-by: Cong Wang Suggested-by: Jakub Kicinski

[patch net-next 0/2] net: sched: couple of adjustments/fixes

2018-07-31 Thread Jiri Pirko
From: Jiri Pirko Jiri Pirko (2): net: sched: change name of zombie chain to "held_by_acts_only" net: sched: fix notifications for action-held chains net/sched/cls_api.c | 84 ++--- 1 file changed, 48 insertions(+), 36 deletions(-) -- 2.14.4

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

2018-07-31 Thread Bjorn Helgaas
On Mon, Jul 30, 2018 at 08:19:50PM -0700, Alexander Duyck wrote: > On Mon, Jul 30, 2018 at 7:33 PM, Bjorn Helgaas wrote: > > On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: > >> On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > >> > On Sun, Jul 29, 2018 at 03:00:28PM -0700,

RE: Security enhancement proposal for kernel TLS

2018-07-31 Thread Vakul Garg
> -Original Message- > From: Dave Watson [mailto:davejwat...@fb.com] > Sent: Tuesday, July 31, 2018 2:46 AM > To: Vakul Garg > Cc: netdev@vger.kernel.org; Peter Doliwa ; Boris > Pismenny > Subject: Re: Security enhancement proposal for kernel TLS > > On 07/30/18 06:31 AM, Vakul Garg w

Re: [PATCH v6 bpf-next 4/9] veth: Handle xdp_frames in xdp napi ring

2018-07-31 Thread Toshiaki Makita
On 2018/07/31 19:26, Jesper Dangaard Brouer wrote: > > Context needed from: [PATCH v6 bpf-next 2/9] veth: Add driver XDP > > On Mon, 30 Jul 2018 19:43:44 +0900 > Toshiaki Makita wrote: > >> +static struct sk_buff *veth_build_skb(void *head, int headroom, int len, >> +

Re: [PATCH v6 bpf-next 4/9] veth: Handle xdp_frames in xdp napi ring

2018-07-31 Thread Jesper Dangaard Brouer
Context needed from: [PATCH v6 bpf-next 2/9] veth: Add driver XDP On Mon, 30 Jul 2018 19:43:44 +0900 Toshiaki Makita wrote: > +static struct sk_buff *veth_build_skb(void *head, int headroom, int len, > + int buflen) > +{ > + struct sk_buff *skb; > + > +

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

2018-07-31 Thread Max Gurtovoy
On 7/30/2018 6:47 PM, Steve Wise wrote: On 7/23/2018 11:53 AM, Max Gurtovoy wrote: On 7/23/2018 7:49 PM, Jason Gunthorpe wrote: On Fri, Jul 20, 2018 at 04:25:32AM +0300, Max Gurtovoy wrote: [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 queue 9 is not mapped (overlap)

Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

2018-07-31 Thread Paolo Abeni
On Mon, 2018-07-30 at 15:31 -0400, Jamal Hadi Salim wrote: > On 30/07/18 12:41 PM, Paolo Abeni wrote: > > On Mon, 2018-07-30 at 10:03 -0400, Jamal Hadi Salim wrote: > > > On 30/07/18 08:30 AM, Paolo Abeni wrote: > > > > } > > > > > > > > + if (!tcf_action_valid(a->tcfa_action)) {

Re: [patch net-next] net: sched: don't dump chains only held by actions

2018-07-31 Thread Jiri Pirko
Tue, Jul 31, 2018 at 10:01:46AM CEST, jakub.kicin...@netronome.com wrote: >On Tue, 31 Jul 2018 08:32:58 +0200, Jiri Pirko wrote: >> Mon, Jul 30, 2018 at 08:19:56PM CEST, xiyou.wangc...@gmail.com wrote: >> >On Sun, Jul 29, 2018 at 12:54 AM Jiri Pirko wrote: >> >> >> >> Sat, Jul 28, 2018 at 07:39:

Re: [patch net-next] net: sched: don't dump chains only held by actions

2018-07-31 Thread Jakub Kicinski
On Tue, 31 Jul 2018 08:32:58 +0200, Jiri Pirko wrote: > Mon, Jul 30, 2018 at 08:19:56PM CEST, xiyou.wangc...@gmail.com wrote: > >On Sun, Jul 29, 2018 at 12:54 AM Jiri Pirko wrote: > >> > >> Sat, Jul 28, 2018 at 07:39:36PM CEST, xiyou.wangc...@gmail.com wrote: > >> >On Sat, Jul 28, 2018 at 10:2

Re: [PATCH net-next 0/3] xsk: improvements to RX queue check and replace

2018-07-31 Thread Daniel Borkmann
On 07/31/2018 05:43 AM, Jakub Kicinski wrote: > Hi! > > First 3 patches of my recent RFC. The first one make the check against > real_num_rx_queues slightly more reliable, while the latter two redefine > XDP_QUERY_XSK_UMEM slightly to disallow replacing UMEM in the driver at > the stack level. >

Re: [PATCH v2 bpf-next 0/4] Support bpf_get_socket_cookie in more prog types

2018-07-31 Thread Daniel Borkmann
On 07/31/2018 02:42 AM, Andrey Ignatov wrote: > v1->v2: > - simplify attach_type guessing logic in selftest. > > This patch set adds support to call bpf_get_socket_cookie() helper from two > more program types: > * BPF_PROG_TYPE_CGROUP_SOCK_ADDR; > * BPF_PROG_TYPE_SOCK_OPS. > > Patch 1 adds kerne

[PATCH net-next 3/3] qed: Add Multi-TC RoCE support

2018-07-31 Thread Denis Bolotin
RoCE qps use a pair of physical queues (pq) received from the Queue Manager (QM) - an offload queue (OFLD) and a low latency queue (LLT). The QM block creates a pq for each TC, and allows RoCE qps to ask for a pq with a specific TC. As a result, qps with different VLAN priorities can be mapped to d

[PATCH net-next 2/3] qed: Add a flag which indicates if offload TC is set

2018-07-31 Thread Denis Bolotin
Distinguish not set offload_tc from offload_tc 0 and add getters and setters. Signed-off-by: Denis Bolotin Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed.h | 3 +++ drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_dev.c | 32

Re: [PATCH bpf-next] nfp: fix variable dereferenced before check in nfp_app_ctrl_rx_raw()

2018-07-31 Thread Daniel Borkmann
On 07/31/2018 05:33 AM, Jakub Kicinski wrote: > 'app' is dereferenced before used for the devlink trace point. > In case FW is buggy and sends a control message to a VF queue > we should make sure app is not NULL. > > Reported-by: Dan Carpenter > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk

[PATCH net-next 1/3] qed: Add DCBX API - qed_dcbx_get_priority_tc()

2018-07-31 Thread Denis Bolotin
The API receives a priority and looks for the TC it is mapped to in the operational DCBX configuration. Signed-off-by: Denis Bolotin Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 27 +++ drivers/net/ethernet/qlogic/qed/qed_dcbx.h | 2 ++ 2

Re: [PATCH bpf-next] lwt_bpf: remove unnecessary rcu_read_lock in run_lwt_bpf

2018-07-31 Thread Daniel Borkmann
On 07/30/2018 03:22 PM, Taehee Yoo wrote: > run_lwt_bpf is called by bpf_{input/output/xmit}. > These functions are already protected by rcu_read_lock. > because lwtunnel_{input/output/xmit} holds rcu_read_lock > and then calls bpf_{input/output/xmit}. > So that rcu_read_lock in the run_lwt_bpf is

[PATCH net-next 0/3] Add Multi-TC RoCE support

2018-07-31 Thread Denis Bolotin
Hi Dave, This patch series adds support for multiple concurrent traffic classes for RoCE. The first three patches enable the required parts of the driver to learn the TC configuration, and the last one makes use of it to enable the feature. Please consider applying this to net-next. (Re-sending to

Re: [PATCH bpf-next v3] bpf: add End.DT6 action to bpf_lwt_seg6_action helper

2018-07-31 Thread Daniel Borkmann
On 07/26/2018 04:10 AM, Mathieu Xhonneux wrote: > The seg6local LWT provides the End.DT6 action, which allows to > decapsulate an outer IPv6 header containing a Segment Routing Header > (SRH), full specification is available here: > > https://tools.ietf.org/html/draft-filsfils-spring-srv6-network-

Re: [RFC bpf-next 0/6] net: xsk: minor improvements around queue handling

2018-07-31 Thread Björn Töpel
Den tis 31 juli 2018 kl 04:49 skrev Jakub Kicinski : > > On Mon, 30 Jul 2018 14:49:32 +0200, Björn Töpel wrote: > > Den tors 26 juli 2018 kl 23:44 skrev Jakub Kicinski: > > > > > > Hi! > > > > Thanks for spending your time on this, Jakub. I'm (temporarily) back > > for a week, so you can expect fas

Re: Issue with driver i40e stat strings count mismatch

2018-07-31 Thread Stefan Assmann
On 10.07.2018 13:17, Jesper Dangaard Brouer wrote: > Hi Intel-fokes, > > Your i40e driver have issues with it's ethtool stats. A warning > triggers at drivers/net/ethernet/intel/i40e/i40e_ethtool.c line 1907 > (see splash below) in func i40e_get_stat_strings(). Hi Jesper, I ran into the same is