Re: [net-next PATCH] mlx5: handle DMA mapping error case for XDP redirect

On 30/07/2018 8:49 PM, Jesper Dangaard Brouer wrote: Commit 58b99ee3e3eb ("net/mlx5e: Add support for XDP_REDIRECT in device-out side") forgot to return/free the xdp_frame in case the DMA mapping failed, correct this. Also DMA unmap the frame in case mlx5e_xmit_xdp_frame() fails. Fixes: 58

Re: [PATCH net-next 0/3] xsk: improvements to RX queue check and replace

Den tis 31 juli 2018 kl 05:46 skrev Jakub Kicinski : > > Hi! > > First 3 patches of my recent RFC. The first one make the check against > real_num_rx_queues slightly more reliable, while the latter two redefine > XDP_QUERY_XSK_UMEM slightly to disallow replacing UMEM in the driver at > the stack l

Re: [patch net-next] net: sched: don't dump chains only held by actions

Mon, Jul 30, 2018 at 08:19:56PM CEST, xiyou.wangc...@gmail.com wrote: >On Sun, Jul 29, 2018 at 12:54 AM Jiri Pirko wrote: >> >> Sat, Jul 28, 2018 at 07:39:36PM CEST, xiyou.wangc...@gmail.com wrote: >> >On Sat, Jul 28, 2018 at 10:20 AM Cong Wang wrote: >> >> >> >> On Fri, Jul 27, 2018 at 12:47 AM

Re: [PATCH net] inet: frag: enforce memory limits earlier

Eric Dumazet wrote: > We currently check current frags memory usage only when > a new frag queue is created. This allows attackers to first > consume the memory budget (default : 4 MB) creating thousands > of frag queues, then sending tiny skbs to exceed high_thresh > limit by 2 to 3 order of magn

[PATCH net-next 2/2] rds: Remove IPv6 dependency

This patch removes the IPv6 dependency from RDS. Signed-off-by: Ka-Cheong Poon --- net/rds/Kconfig | 2 +- net/rds/af_rds.c | 32 +++- net/rds/bind.c | 4 +++- net/rds/connection.c | 26 -- net/rds/ib.c

[PATCH net-next 1/2] rds: rds_ib_recv_alloc_cache() should call alloc_percpu_gfp() instead

Currently, rds_ib_conn_alloc() calls rds_ib_recv_alloc_caches() without passing along the gfp_t flag. But rds_ib_recv_alloc_caches() and rds_ib_recv_alloc_cache() should take a gfp_t parameter so that rds_ib_recv_alloc_cache() can call alloc_percpu_gfp() using the correct flag instead of calling a

[PATCH net] ipv4: frags: handle possible skb truesize change

ip_frag_queue() might call pskb_pull() on one skb that is already in the fragment queue. We need to take care of possible truesize change, or we might have an imbalance of the netns frags memory usage. IPv6 is immune to this bug, because RFC5722, Section 4, amended by Errata ID 3089 states : W

Re: [PATCH v2 bpf-next 4/4] selftests/bpf: Test for get_socket_cookie

On 7/30/18 5:42 PM, Andrey Ignatov wrote: Add test to use get_socket_cookie() from BPF programs of types BPF_PROG_TYPE_SOCK_OPS and BPF_PROG_TYPE_CGROUP_SOCK_ADDR. The test attaches two programs to cgroup, runs TCP server and client in the cgroup and checks that two operations are done proper

[PATCH net-next 3/3] xsk: don't allow umem replace at stack level

Currently drivers have to check if they already have a umem installed for a given queue and return an error if so. Make better use of XDP_QUERY_XSK_UMEM and move this functionality to the core. We need to keep rtnl across the calls now. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet

[PATCH net-next 2/3] xsk: refactor xdp_umem_assign_dev()

Return early and only take the ref on dev once there is no possibility of failing. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-by: Björn Töpel --- net/xdp/xdp_umem.c | 49 -- 1 file changed, 21 insertions(+), 28 deletions(-) diff

[PATCH net-next 1/3] net: update real_num_rx_queues even when !CONFIG_SYSFS

We used to depend on real_num_rx_queues as a upper bound for sanity checks. For AF_XDP socket validation it's useful if the check behaves the same regardless of CONFIG_SYSFS setting. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- include/linux/netdevice.h | 3 ++- 1 file changed

[PATCH net-next 0/3] xsk: improvements to RX queue check and replace

Hi! First 3 patches of my recent RFC. The first one make the check against real_num_rx_queues slightly more reliable, while the latter two redefine XDP_QUERY_XSK_UMEM slightly to disallow replacing UMEM in the driver at the stack level. I'm not sure where this lays on the bpf vs net trees scale,

[PATCH bpf-next] nfp: fix variable dereferenced before check in nfp_app_ctrl_rx_raw()

'app' is dereferenced before used for the devlink trace point. In case FW is buggy and sends a control message to a VF queue we should make sure app is not NULL. Reported-by: Dan Carpenter Signed-off-by: Jakub Kicinski Reviewed-by: Dirk van der Merwe --- drivers/net/ethernet/netronome/nfp/nfp_

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

On Mon, Jul 30, 2018 at 7:33 PM, Bjorn Helgaas wrote: > On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: >> On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: >> > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: >> >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shem

IT Governance article

Greetings, My name is Michael and I am reaching out to ubuntu.com on behalf of Reciprocity Labs . We help

[PATCH net] inet: frag: enforce memory limits earlier

We currently check current frags memory usage only when a new frag queue is created. This allows attackers to first consume the memory budget (default : 4 MB) creating thousands of frag queues, then sending tiny skbs to exceed high_thresh limit by 2 to 3 order of magnitude. Note that before commit

Re: [RFC bpf-next 0/6] net: xsk: minor improvements around queue handling

On Mon, 30 Jul 2018 14:49:32 +0200, Björn Töpel wrote: > Den tors 26 juli 2018 kl 23:44 skrev Jakub Kicinski: > > > > Hi! > > Thanks for spending your time on this, Jakub. I'm (temporarily) back > for a week, so you can expect faster replies now... > > > This set tries to make the core take care

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

On Mon, Jul 30, 2018 at 08:02:48AM -0700, Alexander Duyck wrote: > On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: > >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh > >> wrote: > >> > On Sat, Jul 28, 2018 at 7:06 PM, Bj

Attn: IT Report

Dear User This is a courtesy notice by Admin Team, and to inform you that your e-mail account has exceeded its quota of mail on the database server. E-mail accounts will be blocked from sending and receiving emails if your email account is not verified. Click on to

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

On 2018年07月31日 03:51, Stephen Hemminger wrote: On Sun, 29 Jul 2018 09:00:27 -0700 (PDT) David Miller wrote: From: Caleb Raitto Date: Mon, 23 Jul 2018 16:11:19 -0700 From: Caleb Raitto The driver disables tx napi if it's not certain that completions will be processed affine with tx serv

[PATCH v2 bpf-next 4/4] selftests/bpf: Test for get_socket_cookie

Add test to use get_socket_cookie() from BPF programs of types BPF_PROG_TYPE_SOCK_OPS and BPF_PROG_TYPE_CGROUP_SOCK_ADDR. The test attaches two programs to cgroup, runs TCP server and client in the cgroup and checks that two operations are done properly on client socket when user calls connect(2):

[PATCH v2 bpf-next 2/4] bpf: Sync bpf.h to tools/

Sync bpf_get_socket_cookie() related bpf UAPI changes to tools/. Signed-off-by: Andrey Ignatov Acked-by: Yonghong Song --- tools/include/uapi/linux/bpf.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 870

[PATCH v2 bpf-next 1/4] bpf: Support bpf_get_socket_cookie in more prog types

bpf_get_socket_cookie() helper can be used to identify skb that correspond to the same socket. Though socket cookie can be useful in many other use-cases where socket is available in program context. Specifically BPF_PROG_TYPE_CGROUP_SOCK_ADDR and BPF_PROG_TYPE_SOCK_OPS programs can benefit from i

[PATCH v2 bpf-next 0/4] Support bpf_get_socket_cookie in more prog types

v1->v2: - simplify attach_type guessing logic in selftest. This patch set adds support to call bpf_get_socket_cookie() helper from two more program types: * BPF_PROG_TYPE_CGROUP_SOCK_ADDR; * BPF_PROG_TYPE_SOCK_OPS. Patch 1 adds kernel support and provides more details. Patch 2 syncs UAPI changes

[PATCH v2 bpf-next 3/4] selftests/bpf: Add bpf_get_socket_cookie to bpf_helpers.h

Add missing helper to bpf_helpers.h that is used in tests and samples. Signed-off-by: Andrey Ignatov Acked-by: Yonghong Song --- tools/testing/selftests/bpf/bpf_helpers.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/b

Re: [PATCH bpf-next 4/4] selftests/bpf: Test for get_socket_cookie

Yonghong Song [Mon, 2018-07-30 16:59 -0700]: > > > On 7/30/18 9:04 AM, Andrey Ignatov wrote: > > Add test to use get_socket_cookie() from BPF programs of types > > BPF_PROG_TYPE_SOCK_OPS and BPF_PROG_TYPE_CGROUP_SOCK_ADDR. > > > > The test attaches two programs to cgroup, runs TCP server and cl

partnership offer,

I want us to join hands as partners because i have a deal for you.

Re: [PATCH bpf] net: xsk: don't return frames via the allocator on error

On 07/28/2018 05:20 AM, Jakub Kicinski wrote: > xdp_return_buff() is used when frame has been successfully > handled (transmitted) or if an error occurred during delayed > processing and there is no way to report it back to > xdp_do_redirect(). > > In case of __xsk_rcv_zc() error is propagated all

Re: [PATCH bpf v3] tools/bpftool: fix a percpu_array map dump problem

On 07/30/2018 05:49 PM, Yonghong Song wrote: > I hit the following problem when I tried to use bpftool > to dump a percpu array. > > $ sudo ./bpftool map show > 61: percpu_array name stub flags 0x0 > key 4B value 4B max_entries 1 memlock 4096B > ... > $ sudo ./bpftool map du

Re: [PATCH bpf-next 4/4] selftests/bpf: Test for get_socket_cookie

On 7/30/18 9:04 AM, Andrey Ignatov wrote: Add test to use get_socket_cookie() from BPF programs of types BPF_PROG_TYPE_SOCK_OPS and BPF_PROG_TYPE_CGROUP_SOCK_ADDR. The test attaches two programs to cgroup, runs TCP server and client in the cgroup and checks that two operations are done proper

[PATCH net] enic: do not call enic_change_mtu in enic_probe

In commit ab123fe071c9 ("enic: handle mtu change for vf properly") ASSERT_RTNL() is added to _enic_change_mtu() to prevent it from being called without rtnl held. enic_probe() calls enic_change_mtu() without rtnl held. At this point netdev is not registered yet. Remove call to enic_change_mtu and a

Re: [PATCH bpf-next 3/4] selftests/bpf: Add bpf_get_socket_cookie to bpf_helpers.h

On 7/30/18 9:04 AM, Andrey Ignatov wrote: Add missing helper to bpf_helpers.h that is used in tests and samples. Signed-off-by: Andrey Ignatov Acked-by: Yonghong Song

Re: [PATCH bpf-next 2/4] bpf: Sync bpf.h to tools/

On 7/30/18 9:04 AM, Andrey Ignatov wrote: Sync bpf_get_socket_cookie() related bpf UAPI changes to tools/. Signed-off-by: Andrey Ignatov Acked-by: Yonghong Song

Re: [PATCH bpf-next 1/4] bpf: Support bpf_get_socket_cookie in more prog types

On 7/30/18 9:04 AM, Andrey Ignatov wrote: bpf_get_socket_cookie() helper can be used to identify skb that correspond to the same socket. Though socket cookie can be useful in many other use-cases where socket is available in program context. Specifically BPF_PROG_TYPE_CGROUP_SOCK_ADDR and BPF

Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER

> One usability issue with this approach is that one cannot specify > wake-on-LAN using WAKE_MAGICSECURE *and* WAKE_FILTER at the same time, > since it uses the same location in the ioctl() structure that is being > passed. Do you see this as a problem? Hi Florian I think you missed adding a chec

Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER

> The thing is that I need this now, but when Michal's work on ethtool > being migrated to netlink settles, we should have have any issues adding > a proper storage area for specifying filters anymore. The issue here is > of course that the size and layout of ethtool_wolinfo is largely fixed > and

Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

On Mon, Jul 30, 2018 at 3:14 PM Stephen Hemminger wrote: > > On Mon, 30 Jul 2018 14:59:09 -0700 > Wei Wang wrote: > > > + stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) + > > 7 * nla_total_size(sizeof(u32)) + > > 3 * nla_total_size(size

Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER

On 07/30/2018 03:30 PM, Andrew Lunn wrote: >> One usability issue with this approach is that one cannot specify >> wake-on-LAN using WAKE_MAGICSECURE *and* WAKE_FILTER at the same time, >> since it uses the same location in the ioctl() structure that is being >> passed. Do you see this as a problem

Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER

> One usability issue with this approach is that one cannot specify > wake-on-LAN using WAKE_MAGICSECURE *and* WAKE_FILTER at the same time, > since it uses the same location in the ioctl() structure that is being > passed. Do you see this as a problem? Hi Florian Maybe you can think ahead to whe

Re: [PATCH ethtool] ethtool: Add support for WAKE_FILTER

On 07/17/2018 08:36 AM, Florian Fainelli wrote: > Allow re-purposing the wol->sopass storage area to specify a bitmask of > filters > (programmed previously via ethtool::rxnfc) to be used as wake-up patterns. John, David, can you provide some feedback if the approach is acceptable? I will address

Re: [PATCH bpf-next] lwt_bpf: remove unnecessary rcu_read_lock in run_lwt_bpf

On Mon, Jul 30, 2018 at 6:22 AM, Taehee Yoo wrote: > run_lwt_bpf is called by bpf_{input/output/xmit}. > These functions are already protected by rcu_read_lock. > because lwtunnel_{input/output/xmit} holds rcu_read_lock > and then calls bpf_{input/output/xmit}. > So that rcu_read_lock in the run_l

Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

On Mon, 30 Jul 2018 14:59:09 -0700 Wei Wang wrote: > + stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) + > 7 * nla_total_size(sizeof(u32)) + > 3 * nla_total_size(sizeof(u8)), GFP_ATOMIC); This is getting a bit awkward. Maybe use the sty

[PATCH net-next 0/4] tcp: add 4 new stats

From: Wei Wang This patch series adds 3 RFC4898 stats: 1. tcpEStatsPerfHCDataOctetsOut 2. tcpEStatsPerfOctetsRetrans 3. tcpEStatsStackDSACKDups and an addtional stat to record the number of data packet reordering events seen: 4. tcp_reord_seen Together with the existing stats, application can us

[PATCH net-next 2/4] tcp: add data bytes retransmitted stats

From: Wei Wang Introduce a new TCP stat to record the number of bytes retransmitted (RFC4898 tcpEStatsPerfOctetsRetrans) and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell Acked-by:

[PATCH net-next 1/4] tcp: add data bytes sent stats

From: Wei Wang Introduce a new TCP stat to record the number of bytes sent (RFC4898 tcpEStatsPerfHCDataOctetsOut) and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell Acked-by: Soheil

[PATCH net-next 3/4] tcp: add dsack blocks received stats

From: Wei Wang Introduce a new TCP stat to record the number of DSACK blocks received (RFC4989 tcpEStatsStackDSACKDups) and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Signed-off-by: Wei Wang Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell Acked-by: S

[PATCH net-next 4/4] tcp: add stat of data packet reordering events

From: Wei Wang Introduce a new TCP stats to record the number of reordering events seen and expose it in both tcp_info (TCP_INFO) and opt_stats (SOF_TIMESTAMPING_OPT_STATS). Application can use this stats to track the frequency of the reordering events in addition to the existing reordering stats

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

On Mon, 30 Jul 2018 08:02:48 -0700, Alexander Duyck wrote: > On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: > >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh > >> wrote: > >> > On Sat, Jul 28, 2018 at 7:06 PM, Bjor

Re: Security enhancement proposal for kernel TLS

On 07/30/18 06:31 AM, Vakul Garg wrote: > > It's not entirely clear how your TLS handshake daemon works - Why is > > it necessary to set the keys in the kernel tls socket before the handshake > > is > > completed? > > IIUC, with the upstream implementation of tls record layer in kernel, the >

Re: [PATCH v8 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs

On Mon, Jul 30, 2018 at 12:20 PM, Sinan Kaya wrote: > +netdev, > > On 7/30/2018 9:45 AM, Alexander Duyck wrote: >> >> I haven't had a chance to work on this much myself. My understanding >> is that igb has had the barriers updated, but I don't think any of the >> other drivers have been worked ove

Re: [PATCH net-next] virtio_net: force_napi_tx module param.

On Sun, 29 Jul 2018 09:00:27 -0700 (PDT) David Miller wrote: > From: Caleb Raitto > Date: Mon, 23 Jul 2018 16:11:19 -0700 > > > From: Caleb Raitto > > > > The driver disables tx napi if it's not certain that completions will > > be processed affine with tx service. > > > > Its heuristic does

Re: pull-request: can 2018-07-30,Re: pull-request: can 2018-07-30

From: Marc Kleine-Budde Date: Mon, 30 Jul 2018 21:06:27 +0200 > Oops, it's definitely too hot in the office at the moment. here it it: That works, pulled, thanks :)

Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

On 30/07/18 12:41 PM, Paolo Abeni wrote: On Mon, 2018-07-30 at 10:03 -0400, Jamal Hadi Salim wrote: On 30/07/18 08:30 AM, Paolo Abeni wrote: } + if (!tcf_action_valid(a->tcfa_action)) { + NL_SET_ERR_MSG(extack, "invalid action value, using TC_ACT_UNSPEC instead"); +

Re: [PATCH v8 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs

+netdev, On 7/30/2018 9:45 AM, Alexander Duyck wrote: I haven't had a chance to work on this much myself. My understanding is that igb has had the barriers updated, but I don't think any of the other drivers have been worked over yet. Unfortunately, I have recently changed jobs and I no longer

Re: pull-request: can 2018-07-30

a004b5fa: openvswitch: meter: Fix setting meter id for new entries (2018-07-29 13:20:54 -0700) are available in the Git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.18-20180730 for you to fetch changes up to 72c05f32f4a5055c

Re: [patch net-next] net: sched: don't dump chains only held by actions

On Sun, Jul 29, 2018 at 12:54 AM Jiri Pirko wrote: > > Sat, Jul 28, 2018 at 07:39:36PM CEST, xiyou.wangc...@gmail.com wrote: > >On Sat, Jul 28, 2018 at 10:20 AM Cong Wang wrote: > >> > >> On Fri, Jul 27, 2018 at 12:47 AM Jiri Pirko wrote: > >> > > >> > From: Jiri Pirko > >> > > >> > In case a c

[net-next PATCH] mlx5: handle DMA mapping error case for XDP redirect

Commit 58b99ee3e3eb ("net/mlx5e: Add support for XDP_REDIRECT in device-out side") forgot to return/free the xdp_frame in case the DMA mapping failed, correct this. Also DMA unmap the frame in case mlx5e_xmit_xdp_frame() fails. Fixes: 58b99ee3e3eb ("net/mlx5e: Add support for XDP_REDIRECT in de

Re: [PATCH rdma-next 00/27] Flow actions to mutate packets

On 7/30/2018 10:10 AM, Jason Gunthorpe wrote: > On Sun, Jul 29, 2018 at 03:58:38PM +0300, Leon Romanovsky wrote: >> From: Leon Romanovsky >> >> Hi, >> >> This is PATCH variant of RFC posted in previous week to the ML. >> https://patchwork.ozlabs.org/cover/944184/ >> >> Changelog: >> RFC -> v0: >>

Microsoft Ignite - 2018

Hi, I hope you and your team must be well prepared for the event Microsoft Ignite - held on 09/24/2018 - 09/28/2018. I am checking in, if you would like to drive more traffic to your booth? If yes, we can help you with the current registered attendee list with the complete contact informati

Re: [PATCH rdma-next 00/27] Flow actions to mutate packets

On Sun, Jul 29, 2018 at 03:58:38PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Hi, > > This is PATCH variant of RFC posted in previous week to the ML. > https://patchwork.ozlabs.org/cover/944184/ > > Changelog: > RFC -> v0: > * Patch 1 a new patch which refactors the logic >

Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

From: Jiri Pirko Date: Mon, 30 Jul 2018 18:49:23 +0200 > So the changelog stays in the commit message, right? Yes.

Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

Mon, Jul 30, 2018 at 06:31:00PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 30 Jul 2018 14:40:13 +0200 > >> Oh, another nitpick: The changelog should go under "---" line. That way, >> the maintainer does not have to deal with it during apply (git apply >> will cut it out). > >I

Re: [PATCH net] net/ipv6: fix metrics leak

From: Sabrina Dubroca Date: Mon, 30 Jul 2018 16:23:10 +0200 > Since commit d4ead6b34b67 ("net/ipv6: move metrics from dst to > rt6_info"), ipv6 metrics are shared and refcounted. rt6_set_from() > assigns the rt->from pointer and increases the refcount on from's > metrics. This reference is never

Re: [PATCH net-next 0/5] A test for mirror-to-gretap with team in UL packet path

From: Petr Machata Date: Mon, 30 Jul 2018 16:37:17 +0200 > This patchset adds a test for "tc action mirred mirror" where the > mirrored-to device is a gretap, and underlay path contains a team > device. > > In patch #1 require_command() is added, which should henceforth be used > to declare depe

Re: [PATCH net-next v7] net/tls: Use socket data_ready callback on record availability

From: Vakul Garg Date: Mon, 30 Jul 2018 16:08:33 +0530 > On receipt of a complete tls record, use socket's saved data_ready > callback instead of state_change callback. In function tls_queue(), > the TLS record is queued in encrypted state. But the decryption > happen inline when tls_sw_recvmsg()

Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

On Mon, 2018-07-30 at 10:03 -0400, Jamal Hadi Salim wrote: > On 30/07/18 08:30 AM, Paolo Abeni wrote: > > } > > > > + if (!tcf_action_valid(a->tcfa_action)) { > > + NL_SET_ERR_MSG(extack, "invalid action value, using > > TC_ACT_UNSPEC instead"); > > + a->tcfa_action =

Re: [PATCH] bpf: verifier: BPF_MOV don't mark dst reg if src == dst

On 30/07/18 13:03, Daniel Borkmann wrote: > On 07/30/2018 12:58 PM, Arthur Fabre wrote: >> The check_alu_op() call handles 32bit and 64bit cases, but then in the >> 32bit case >> mark_reg_unknown() is called, discarding all the dst register state. >> I think this is equivalent to keeping a copy of

Re: [PATCH net-next v5 0/4] TC: refactor act_mirred packets re-injection

From: Paolo Abeni Date: Mon, 30 Jul 2018 14:30:41 +0200 > This series is aimed at improving the act_mirred redirect performances. > Such action is used by OVS to represent TC S/W flows, and it's current largest > bottle-neck is the need for a skb_clone() for each packet. > > The first 2 patches

Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

From: Jiri Pirko Date: Mon, 30 Jul 2018 14:40:13 +0200 > Oh, another nitpick: The changelog should go under "---" line. That way, > the maintainer does not have to deal with it during apply (git apply > will cut it out). I actually like the changelog to be _IN_ the commit message. It's useful i

Re: [PATCH] phy: Move "device present" masks earlier in file

From: "Robert P. J. Day" Date: Fri, 27 Jul 2018 15:32:20 -0400 (EDT) > Move the "device present" mask bits up immediately after the MMD > device definitions, since it makes no sense to have them further down > in the file. > > This is purely a cosmetic change for readability. > > Signed-off-by:

Re: [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in device-out side

On Mon, 30 Jul 2018 16:09:47 +0300 Tariq Toukan wrote: > On 30/07/2018 4:06 PM, Jesper Dangaard Brouer wrote: > > > > On Mon, 30 Jul 2018 14:10:21 +0200 Jesper Dangaard Brouer > > wrote: > > > >> On Thu, 26 Jul 2018 15:56:44 -0700 Saeed Mahameed > >> wrote: > >> > >>> +int mlx5e_xdp_xmi

Re: [PATCH net-next 1/2] be2net: Collect the transmit queue data in Tx timeout

From: Suresh Kumar Reddy Reddygari Date: Mon, 30 Jul 2018 16:23:12 +0530 > I am clarifying again about the patch (Lancer reset) as I didnt see a reply > from you after my clarification. Ok, please resubmit this patch. Thank you.

Re: pull-request: can 2018-07-30

From: Marc Kleine-Budde Date: Mon, 30 Jul 2018 11:08:21 +0200 > Hello David, > > this is a pull request of one patch for net/master. > > The patch by Anton Vasilyev and the Linux Driver Verification project > fixes a memory leak in the ems_usb driver's disconnect function. Where is the GIT URL

Re: [PATCH 1/5] net: remove bogus RCU annotations on socket.wq

From: Christoph Hellwig Date: Mon, 30 Jul 2018 09:44:54 +0200 > On Sun, Jul 29, 2018 at 01:05:51PM -0700, David Miller wrote: >> From: Christoph Hellwig >> Date: Fri, 27 Jul 2018 16:02:10 +0200 >> >> > We never use RCU protection for it, just a lot of cargo-cult >> > rcu_deference_protects call

Re: [net-next v1] net/ipv6: allow any source address for sendmsg pktinfo with ip_nonlocal_bind

From: Vincent Bernat Date: Mon, 30 Jul 2018 08:08:12 +0200 > ❦ 29 juillet 2018 12:28 -0700, David Miller  : > >>> When freebind feature is set of an IPv6 socket, any source address can >>> be used when sending UDP datagrams using IPv6 PKTINFO ancillary >>> message. Global non-local bind feature

[PATCH bpf-next 3/4] selftests/bpf: Add bpf_get_socket_cookie to bpf_helpers.h

Add missing helper to bpf_helpers.h that is used in tests and samples. Signed-off-by: Andrey Ignatov --- tools/testing/selftests/bpf/bpf_helpers.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h index f2

[PATCH bpf-next 2/4] bpf: Sync bpf.h to tools/

Sync bpf_get_socket_cookie() related bpf UAPI changes to tools/. Signed-off-by: Andrey Ignatov --- tools/include/uapi/linux/bpf.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 870113916cac..0ebaaf7f3568 1

[PATCH bpf-next 0/4] Support bpf_get_socket_cookie in more prog types

This patch set adds support to call bpf_get_socket_cookie() helper from two more program types: * BPF_PROG_TYPE_CGROUP_SOCK_ADDR; * BPF_PROG_TYPE_SOCK_OPS. Patch 1 adds kernel support and provides more details. Patch 2 syncs UAPI changes to tools/. Patch 3 adds missing helper to bpf_helpers.h. Pat

[PATCH bpf-next 1/4] bpf: Support bpf_get_socket_cookie in more prog types

bpf_get_socket_cookie() helper can be used to identify skb that correspond to the same socket. Though socket cookie can be useful in many other use-cases where socket is available in program context. Specifically BPF_PROG_TYPE_CGROUP_SOCK_ADDR and BPF_PROG_TYPE_SOCK_OPS programs can benefit from i

[PATCH bpf-next 4/4] selftests/bpf: Test for get_socket_cookie

Add test to use get_socket_cookie() from BPF programs of types BPF_PROG_TYPE_SOCK_OPS and BPF_PROG_TYPE_CGROUP_SOCK_ADDR. The test attaches two programs to cgroup, runs TCP server and client in the cgroup and checks that two operations are done properly on client socket when user calls connect(2):

[PATCH bpf v3] tools/bpftool: fix a percpu_array map dump problem

I hit the following problem when I tried to use bpftool to dump a percpu array. $ sudo ./bpftool map show 61: percpu_array name stub flags 0x0 key 4B value 4B max_entries 1 memlock 4096B ... $ sudo ./bpftool map dump id 61 bpftool: malloc.c:2406: sysmalloc: Assertion `(o

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On 7/23/2018 11:53 AM, Max Gurtovoy wrote: > > > On 7/23/2018 7:49 PM, Jason Gunthorpe wrote: >> On Fri, Jul 20, 2018 at 04:25:32AM +0300, Max Gurtovoy wrote: >>> >> [ 2032.194376] nvme nvme0: failed to connect queue: 9 ret=-18 > > queue 9 is not mapped (overlap). > please try th

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

On Mon, Jul 30, 2018 at 7:07 AM, Bjorn Helgaas wrote: > On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: >> On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh wrote: >> > On Sat, Jul 28, 2018 at 7:06 PM, Bjorn Helgaas wrote: >> >> On Thu, Jul 26, 2018 at 07:00:20AM -0700, Alexander D

Hello

DEAR FRIENDI am(Mr.Kamalesh Ashu),With the business proposal deal of US(US$10.5 million) to transfer into your account, if you are interested get back to me for more detail at my E-mail(ashukamalesh4...@gmail.com)Best Regard Mr. Kamalesh Ashu

[PATCH net-next 0/5] A test for mirror-to-gretap with team in UL packet path

This patchset adds a test for "tc action mirred mirror" where the mirrored-to device is a gretap, and underlay path contains a team device. In patch #1 require_command() is added, which should henceforth be used to declare dependence on a certain tool. In patch #2, two new functions, team_create(

[PATCH net-next 5/5] selftests: forwarding: Test mirror-to-gretap w/ UL team LACP

This tests mirror-to-gretap when an underlay packet path includes a team device which is not in loadbalance mode, but in LACP mode. The test manipulates LAG membership to achieve changes in txability, thus making sure that a driver that offloads mirror-to-gretap doesn't just consider upness of a de

[PATCH net-next 4/5] selftests: forwarding: Test mirror-to-gretap w/ UL team

Test for "tc action mirred egress mirror" that mirrors to gretap when the underlay route points at a VLAN-aware bridge (802.1q), and the traffic egresses the bridge through a team device. Test upping and downing individual team device slaves and verify the traffic flows as expected. Signed-off-by:

[PATCH net-next 3/5] selftests: forwarding: Introduce $ARPING

Instead of relying on "arping" being installed everywhere under that name, introduce a variable $ARPING like the other tools do. Convert an existing test, mirror_gre_vlan_bridge_1q.sh to require_command $ARPING and then invoke arping through the variable. Signed-off-by: Petr Machata --- tools/t

[PATCH net-next 2/5] selftests: forwarding: lib: Support team devices

Add team_create() and team_destroy() to manage team netdevices. Signed-off-by: Petr Machata --- tools/testing/selftests/net/forwarding/lib.sh | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/

[PATCH net-next 1/5] selftests: forwarding: lib: Add require_command()

The logic for testing whether a certain command is available is used several times in the current code base. The tests in follow-up patches add more requirements like that. Therefore extract the logic into a named function, require_command(), that can be used directly from lib.sh as well as from a

Re: [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding

On Wed, Jul 11, 2018 at 11:06 PM, Jesper Dangaard Brouer wrote: > On Wed, 11 Jul 2018 19:05:20 + > Saeed Mahameed wrote: > >> On Wed, 2018-07-11 at 17:01 +0200, Jesper Dangaard Brouer wrote: >> > Only driver sfc actually uses this, but I don't have this NIC, so I >> > tested this on mlx5, wit

Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

Mon, Jul 30, 2018 at 04:03:50PM CEST, j...@mojatatu.com wrote: >On 30/07/18 08:30 AM, Paolo Abeni wrote: >> } >> +if (!tcf_action_valid(a->tcfa_action)) { >> +NL_SET_ERR_MSG(extack, "invalid action value, using >> TC_ACT_UNSPEC instead"); >> +a->tcfa_action = TC_AC

[PATCH net] net/ipv6: fix metrics leak

Since commit d4ead6b34b67 ("net/ipv6: move metrics from dst to rt6_info"), ipv6 metrics are shared and refcounted. rt6_set_from() assigns the rt->from pointer and increases the refcount on from's metrics. This reference is never released. Introduce the fib6_metrics_release() helper and use it to r

Re: [net-next 10/16] net/mlx5: Support PCIe buffer congestion handling via Devlink

On Sun, Jul 29, 2018 at 03:00:28PM -0700, Alexander Duyck wrote: > On Sun, Jul 29, 2018 at 2:23 AM, Moshe Shemesh wrote: > > On Sat, Jul 28, 2018 at 7:06 PM, Bjorn Helgaas wrote: > >> On Thu, Jul 26, 2018 at 07:00:20AM -0700, Alexander Duyck wrote: > >> > On Thu, Jul 26, 2018 at 12:14 AM, Jiri Pi

Re: [PATCH net-next v5 1/4] net/sched: user-space can't set unknown tcfa_action values

On 30/07/18 08:30 AM, Paolo Abeni wrote: } + if (!tcf_action_valid(a->tcfa_action)) { + NL_SET_ERR_MSG(extack, "invalid action value, using TC_ACT_UNSPEC instead"); + a->tcfa_action = TC_ACT_UNSPEC; + } + return a; I think it would make

[PATCH bpf-next] lwt_bpf: remove unnecessary rcu_read_lock in run_lwt_bpf

run_lwt_bpf is called by bpf_{input/output/xmit}. These functions are already protected by rcu_read_lock. because lwtunnel_{input/output/xmit} holds rcu_read_lock and then calls bpf_{input/output/xmit}. So that rcu_read_lock in the run_lwt_bpf is unnecessary. Signed-off-by: Taehee Yoo --- net/co

Re: [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in device-out side

On 30/07/2018 4:06 PM, Jesper Dangaard Brouer wrote: On Mon, 30 Jul 2018 14:10:21 +0200 Jesper Dangaard Brouer wrote: On Thu, 26 Jul 2018 15:56:44 -0700 Saeed Mahameed wrote: +int mlx5e_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames, + u32 flags) +{

Re: [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in device-out side

On Mon, 30 Jul 2018 14:10:21 +0200 Jesper Dangaard Brouer wrote: > On Thu, 26 Jul 2018 15:56:44 -0700 Saeed Mahameed wrote: > > > +int mlx5e_xdp_xmit(struct net_device *dev, int n, struct xdp_frame > > **frames, > > + u32 flags) > > +{ [...] > > + xdpi.dma_addr = dma_

Re: [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in device-out side

On 30/07/2018 3:10 PM, Jesper Dangaard Brouer wrote: On Thu, 26 Jul 2018 15:56:44 -0700 Saeed Mahameed wrote: +int mlx5e_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames, + u32 flags) +{ + struct mlx5e_priv *priv = netdev_priv(dev); + struct mlx

Re: [RFC bpf-next 0/6] net: xsk: minor improvements around queue handling

Den tors 26 juli 2018 kl 23:44 skrev Jakub Kicinski : > > Hi! > Thanks for spending your time on this, Jakub. I'm (temporarily) back for a week, so you can expect faster replies now... > This set tries to make the core take care of error checking for the > drivers. In particular making sure that

  1   2   >