[PATCH net-next] xfrm: Make function xfrmi_get_link_net() static

2018-07-27 Thread Wei Yongjun
Fixes the following sparse warning: net/xfrm/xfrm_interface.c:745:12: warning: symbol 'xfrmi_get_link_net' was not declared. Should it be static? Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") Signed-off-by: Wei Yongjun --- net/xfrm/xfrm_interface.c | 2 +- 1 file changed, 1 inserti

[PATCH net] nfp: flower: fix port metadata conversion bug

2018-07-27 Thread Jakub Kicinski
From: John Hurley Function nfp_flower_repr_get_type_and_port expects an enum nfp_repr_type return value but, if the repr type is unknown, returns a value of type enum nfp_flower_cmsg_port_type. This means that if FW encodes the port ID in a way the driver does not understand instead of dropping

[PATCH bpf] net: xsk: don't return frames via the allocator on error

2018-07-27 Thread Jakub Kicinski
xdp_return_buff() is used when frame has been successfully handled (transmitted) or if an error occurred during delayed processing and there is no way to report it back to xdp_do_redirect(). In case of __xsk_rcv_zc() error is propagated all the way back to the driver, so there is no need to call x

[PATCH net] enic: handle mtu change for vf properly

2018-07-27 Thread Govindarajulu Varadarajan
When driver gets notification for mtu change, driver does not handle it for all RQs. It handles only RQ[0]. Fix is to use enic_change_mtu() interface to change mtu for vf. Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/cisco/enic/enic_main.c | 78 +++-- 1 file

[net-next V2 10/12] net/mlx5e: Vxlan, add sync lock for add/del vxlan port

2018-07-27 Thread Saeed Mahameed
Vxlan API can and will be called from different mlx5 modules, we should not count on mlx5e private state lock only, hence we introduce a vxlan private mutex to sync between add/del vxlan port operations. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx5/co

[net-next V2 07/12] net/mlx5e: Vxlan, rename struct mlx5e_vxlan to mlx5_vxlan_port

2018-07-27 Thread Saeed Mahameed
The name mlx5e_vxlan will be used in downstream patch to describe mlx5 vxlan structure that will replace mlx5e_vxlan_db. Hence we rename struct mlx5e_vxlan to mlx5_vxlan_port which describes a mlx5 vxlan port. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/

[net-next V2 04/12] net/mlx5e: Vxlan, cleanup an unused member in vxlan work

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman Cleanup the sa_family member of the vxlan work, it is unused/needed anywhere in the code. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 4 +--- dr

[net-next V2 06/12] net/mlx5e: Vxlan, move netdev only logic to en_main.c

2018-07-27 Thread Saeed Mahameed
Create a direct vxlan API to add and delete vxlan ports from HW. +void mlx5e_vxlan_add_port(struct mlx5e_priv *priv, u16 port); +void mlx5e_vxlan_del_port(struct mlx5e_priv *priv, u16 port); And move vxlan_add/del_work to en_main.c since they are netdev only logic. Signed-off-by: Saeed Mahameed

[net-next V2 09/12] net/mlx5e: Vxlan, return values for add/del port

2018-07-27 Thread Saeed Mahameed
For a better API mlx5_vxlan_{add/del}_port can fail, make them return error values. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx5/core/vxlan.c | 28 +-- .../net/ethernet/mellanox/mlx5/core/vxlan.h | 4 +-- 2 files changed, 21 inser

[net-next V2 12/12] net/mlx5e: Issue direct lookup on vxlan ports by vport representors

2018-07-27 Thread Saeed Mahameed
Remove uplink representor netdevice private structure lookup, and use mlx5 core handle directly from representor private structure to lookup vxlan ports. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 12 ++-- 1 file changed,

[net-next V2 11/12] net/mlx5e: Vxlan, move vxlan logic to core driver

2018-07-27 Thread Saeed Mahameed
Move vxlan logic and objects to mlx5 core dirver. Since it going to be used from different mlx5 interfaces. e.g. mlx5e PF NIC netdev and mlx5e E-Switch representors. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx5/core/Makefile | 4 ++-- drivers/net/et

[net-next V2 08/12] net/mlx5e: Vxlan, rename from mlx5e to mlx5

2018-07-27 Thread Saeed Mahameed
Rename vxlan functions from mlx5e_vxlan_* to mlx5_vxlan_*. Rename mlx5e_vxlan_db to mlx5_vxlan and move it from en.h to vxlan.c since it is not related to mlx5e anymore. Allocate mlx5_vxlan structure dynamically in order to make it easier to move later to core driver and to make it private in vxla

[net-next V2 05/12] net/mlx5e: Vxlan, add direct delete function

2018-07-27 Thread Saeed Mahameed
Add direct vxlan delete function to be called from vxlan_delete_work. Needed in downstream patch. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx5/core/vxlan.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/driv

[net-next V2 03/12] net/mlx5e: Vxlan, replace ports radix-tree with hash table

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman The VXLAN database is accessed in the data path for each VXLAN TX skb in order to check whether the UDP port is being offloaded or not. The number of elements in the database is relatively small, we can simplify the radix-tree to a hash table and speedup the lookup process. Me

[net-next V2 02/12] net/mlx5e: Vxlan, check maximum number of UDP ports

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman The NIC has a limited number of offloaded VXLAN UDP ports (usually 4). Instead of letting the firmware fail when trying to add more ports than it can handle, let the driver check it on its own. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethern

[net-next V2 01/12] net/mlx5e: Vxlan, reflect 4789 UDP port default addition to software database

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman The hardware offloads 4789 UDP port (default VXLAN port) automatically. Add it to the software database as well in order to reflect the hardware state appropriately. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/vxlan.c

[pull request][net-next V2 00/12] Mellanox, mlx5 updates 2018-07-27 (Vxlan updates)

2018-07-27 Thread Saeed Mahameed
Hi Dave, This series from Gal and Saeed provides updates to mlx5 vxlan implementation. For more information please see tag log below. Please pull and let me know if there's any problem. V1->V2: - Drop the rw lock patch. Thanks, Saeed. --- The following changes since commit 1f3ed383fb9a073a

Re: [**EXTERNAL**] Re: VRF with enslaved L3 enabled bridge

2018-07-27 Thread D'Souza, Nelson
David, With Ubuntu 18.04.1 (kernel 4.15.0-29) pings sent out on test-vrf and br0 are successful. # uname -rv 4.15.0-29-generic #31-Ubuntu SMP Tue Jul 17 15:39:52 UTC 2018 # ping -c 1 -I test-vrf 172.16.2.2 ping: Warning: source address might be selected on device other than test-vrf. PING 172.1

[PATCH bpf] tools/bpftool: fix a percpu_array map dump problem

2018-07-27 Thread Yonghong Song
I hit the following problem when I tried to use bpftool to dump a percpu array. $ sudo ./bpftool map show 61: percpu_array name stub flags 0x0 key 4B value 4B max_entries 1 memlock 4096B ... $ sudo ./bpftool map dump id 61 bpftool: malloc.c:2406: sysmalloc: Assertion `(o

[PATCH net-next] selftests: mlxsw: qos_dscp_bridge: Fix

2018-07-27 Thread Petr Machata
There are two problems in this test case: - When indexing in bash associative array, the subscript is interpreted as string, not as a variable name to be expanded. - The keys stored to t0s and t1s are not DSCP values, but priority + base (i.e. the logical DSCP value, not the full bitfield val

Re: [net-next 04/13] net/mlx5e: Vxlan, replace spinlock with read-write lock

2018-07-27 Thread Saeed Mahameed
On Fri, Jul 27, 2018 at 2:48 PM, Stephen Hemminger wrote: > On Fri, 27 Jul 2018 14:15:09 -0700 > Saeed Mahameed wrote: > >> From: Gal Pressman >> >> The VXLAN database is mainly used by readers in data path, and rarely >> used by control path writers. >> Multiple readers (threads) should not blo

[PATCH iproute2-next] sch_cake: Make gso-splitting configurable

2018-07-27 Thread Dave Taht
This patch makes sch_cake's gso/gro splitting configurable from userspace. To disable breaking apart superpackets in sch_cake: tc qdisc replace dev whatever root cake no-split-gso to enable: tc qdisc replace dev whatever root cake split-gso Signed-off-by: Toke Høiland-Jørgensen Signed-off-by:

Re: [net-next 04/13] net/mlx5e: Vxlan, replace spinlock with read-write lock

2018-07-27 Thread Stephen Hemminger
On Fri, 27 Jul 2018 14:15:09 -0700 Saeed Mahameed wrote: > From: Gal Pressman > > The VXLAN database is mainly used by readers in data path, and rarely > used by control path writers. > Multiple readers (threads) should not block each other and cause an > unnecessary contention on the lock. >

[PATCH net] tcp_bbr: fix bw probing to raise in-flight data for very small BDPs

2018-07-27 Thread Neal Cardwell
For some very small BDPs (with just a few packets) there was a quantization effect where the target number of packets in flight during the super-unity-gain (1.25x) phase of gain cycling was implicitly truncated to a number of packets no larger than the normal unity-gain (1.0x) phase of gain cycling

[net-next 10/13] net/mlx5e: Vxlan, return values for add/del port

2018-07-27 Thread Saeed Mahameed
For a better API mlx5_vxlan_{add/del}_port can fail, make them return error values. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx5/core/vxlan.c | 28 +-- .../net/ethernet/mellanox/mlx5/core/vxlan.h | 4 +-- 2 files changed, 21 inser

[net-next 02/13] net/mlx5e: Vxlan, check maximum number of UDP ports

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman The NIC has a limited number of offloaded VXLAN UDP ports (usually 4). Instead of letting the firmware fail when trying to add more ports than it can handle, let the driver check it on its own. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethern

[net-next 09/13] net/mlx5e: Vxlan, rename from mlx5e to mlx5

2018-07-27 Thread Saeed Mahameed
Rename vxlan functions from mlx5e_vxlan_* to mlx5_vxlan_*. Rename mlx5e_vxlan_db to mlx5_vxlan and move it from en.h to vxlan.c since it is not related to mlx5e anymore. Allocate mlx5_vxlan structure dynamically in order to make it easier to move later to core driver and to make it private in vxla

[net-next 01/13] net/mlx5e: Vxlan, reflect 4789 UDP port default addition to software database

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman The hardware offloads 4789 UDP port (default VXLAN port) automatically. Add it to the software database as well in order to reflect the hardware state appropriately. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/vxlan.c

Re: [PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c

2018-07-27 Thread Saeed Mahameed
On Fri, Jul 27, 2018 at 8:59 AM, Kamal Heib wrote: > On Thu, Jul 26, 2018 at 11:51:49AM -0700, Saeed Mahameed wrote: >> On Sun, Jul 15, 2018 at 12:06 PM, Kamal Heib wrote: >> > Move the definition of mlx5e_priv_flags into en_ethtool.c because it's >> > only used there. >> > >> > Fixes: 4e59e28881

[net-next 13/13] net/mlx5e: Issue direct lookup on vxlan ports by vport representors

2018-07-27 Thread Saeed Mahameed
Remove uplink representor netdevice private structure lookup, and use mlx5 core handle directly from representor private structure to lookup vxlan ports. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 12 ++-- 1 file changed,

[net-next 04/13] net/mlx5e: Vxlan, replace spinlock with read-write lock

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman The VXLAN database is mainly used by readers in data path, and rarely used by control path writers. Multiple readers (threads) should not block each other and cause an unnecessary contention on the lock. Replacing the spinlock with rwlock optimizes the common use case where ad

[net-next 06/13] net/mlx5e: Vxlan, add direct delete function

2018-07-27 Thread Saeed Mahameed
Add direct vxlan delete function to be called from vxlan_delete_work. Needed in downstream patch. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx5/core/vxlan.c| 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/driv

[net-next 08/13] net/mlx5e: Vxlan, rename struct mlx5e_vxlan to mlx5_vxlan_port

2018-07-27 Thread Saeed Mahameed
The name mlx5e_vxlan will be used in downstream patch to describe mlx5 vxlan structure that will replace mlx5e_vxlan_db. Hence we rename struct mlx5e_vxlan to mlx5_vxlan_port which describes a mlx5 vxlan port. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/

[net-next 11/13] net/mlx5e: Vxlan, add sync lock for add/del vxlan port

2018-07-27 Thread Saeed Mahameed
Vxlan API can and will be called from different mlx5 modules, we should not count on mlx5e private state lock only, hence we introduce a vxlan private mutex to sync between add/del vxlan port operations. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx5/co

[net-next 12/13] net/mlx5e: Vxlan, move vxlan logic to core driver

2018-07-27 Thread Saeed Mahameed
Move vxlan logic and objects to mlx5 core dirver. Since it going to be used from different mlx5 interfaces. e.g. mlx5e PF NIC netdev and mlx5e E-Switch representors. Signed-off-by: Saeed Mahameed Reviewed-by: Or Gerlitz --- .../net/ethernet/mellanox/mlx5/core/Makefile | 4 ++-- drivers/net/et

[net-next 07/13] net/mlx5e: Vxlan, move netdev only logic to en_main.c

2018-07-27 Thread Saeed Mahameed
Create a direct vxlan API to add and delete vxlan ports from HW. +void mlx5e_vxlan_add_port(struct mlx5e_priv *priv, u16 port); +void mlx5e_vxlan_del_port(struct mlx5e_priv *priv, u16 port); And move vxlan_add/del_work to en_main.c since they are netdev only logic. Signed-off-by: Saeed Mahameed

[net-next 05/13] net/mlx5e: Vxlan, cleanup an unused member in vxlan work

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman Cleanup the sa_family member of the vxlan work, it is unused/needed anywhere in the code. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/vxlan.c | 4 +--- dr

[pull request][net-next 00/13] Mellanox, mlx5 updates 2018-07-27 (Vxlan updates)

2018-07-27 Thread Saeed Mahameed
Hi Dave, This series from Gal and Saeed provides updates to mlx5 vxlan implementation. For more information please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit 1f3ed383fb9a073ae2e408cd7a0717b04c7c3a21: net: sch

[net-next 03/13] net/mlx5e: Vxlan, replace ports radix-tree with hash table

2018-07-27 Thread Saeed Mahameed
From: Gal Pressman The VXLAN database is accessed in the data path for each VXLAN TX skb in order to check whether the UDP port is being offloaded or not. The number of elements in the database is relatively small, we can simplify the radix-tree to a hash table and speedup the lookup process. Me

Re: [PATCH net-next] net: dcb: add DSCP to comment about priority selector types

2018-07-27 Thread Petr Machata
Jakub Kicinski writes: > Commit ee2059819450 ("net/dcb: Add dscp to priority selector type") > added a define for the new DSCP selector type created by > IEEE 802.1Qcd, but missed the comment enumerating all selector types. > Update the comment. > > Signed-off-by: Jakub Kicinski Reviewed-by: Pe

Re: [iproute PATCH] lib/namespace: avoid double-mounting a /sys

2018-07-27 Thread Stephen Hemminger
On Tue, 24 Jul 2018 19:26:38 +0200 Lubomir Rintel wrote: > This partly reverts 8f0807023d067e2bb585a2ae8da93e59689d10f1, bringing > back the umount(/sys) attempt. > > In a LXC container we're unable to umount the sysfs instance, nor mount > a read-write one. We still are able to create a new rea

[PATCHi iproute2-next] ip: show min and max mtu

2018-07-27 Thread Stephen Hemminger
From: Stephen Hemminger Add min/max MTU to the link details Signed-off-by: Stephen Hemminger --- include/uapi/linux/if_link.h | 2 ++ ip/ipaddress.c | 10 ++ 2 files changed, 12 insertions(+) diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index

[PATCH net-next 0/3] mtu related changes

2018-07-27 Thread Stephen Hemminger
While looking at other MTU issues, noticed a couple oppurtunties for improving user experience. Stephen Hemminger (3): failover: change mtu has RTNL net: report min and max mtu network device settings net: report invalid mtu value via netlink extack drivers/net/net_failover.c | 4 ++--

[PATCH net-next 1/3] failover: change mtu has RTNL

2018-07-27 Thread Stephen Hemminger
When changing MTU, RTNL is held so use rtnl_dereference instead of rcu_dereference. Signed-off-by: Stephen Hemminger --- drivers/net/net_failover.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index d00d42c845b7..

[PATCH net-next 3/3] net: report invalid mtu value via netlink extack

2018-07-27 Thread Stephen Hemminger
If an invalid MTU value is set through rtnetlink return extra error information instead of putting message in kernel log. For other cases where there is no visible API, keep the error report in the log. Example: # ip li set dev enp12s0 mtu 1 Error: mtu greater than device maxim

[PATCH net-next 2/3] net: report min and max mtu network device settings

2018-07-27 Thread Stephen Hemminger
Report the minimum and maximum MTU allowed on a device via netlink so that it can be displayed by tools like ip link. Signed-off-by: Stephen Hemminger --- include/uapi/linux/if_link.h | 2 ++ net/core/rtnetlink.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/include/uapi/lin

Re: [PATCH net-next] cxgb4: print ULD queue information managed by LLD

2018-07-27 Thread David Miller
From: Rahul Lakkireddy Date: Fri, 27 Jul 2018 14:29:22 +0530 > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar Applied, thanks.

Re: [PATCH net-next 0/4] l2tp: remove unused session fields

2018-07-27 Thread David Miller
From: Guillaume Nault Date: Fri, 27 Jul 2018 10:59:55 +0200 > Several fields of the session structures can be set, but remain unused > otherwise. > This series removes these fields and explicitely ignores the associated > ioctls and netlink attributes. Series applied, thank you.

Re: [PATCH net-next 0/8] mlxsw: Support DSCP prioritization and rewrite

2018-07-27 Thread David Miller
From: Ido Schimmel Date: Fri, 27 Jul 2018 15:26:54 +0300 > Petr says: > > On ingress, a network device such as a switch assigns to packets > priority based on various criteria. Common options include interpreting > PCP and DSCP fields according to user configuration. When a packet > egresses the

[PATCH net-next] net: dcb: add DSCP to comment about priority selector types

2018-07-27 Thread Jakub Kicinski
Commit ee2059819450 ("net/dcb: Add dscp to priority selector type") added a define for the new DSCP selector type created by IEEE 802.1Qcd, but missed the comment enumerating all selector types. Update the comment. Signed-off-by: Jakub Kicinski --- include/uapi/linux/dcbnl.h | 3 ++- 1 file chan

[PATCH] phy: Move "device present" masks earlier in file

2018-07-27 Thread Robert P. J. Day
Move the "device present" mask bits up immediately after the MMD device definitions, since it makes no sense to have them further down in the file. This is purely a cosmetic change for readability. Signed-off-by: Robert P. J. Day --- since the *only* thing that actually uses the MMD definiti

[PATCH net-next] Implement a rtnetlink device which simulates wifi.

2018-07-27 Thread Cody Schuffelen
The device added here is used through "ip link add ... type virt_wifi" The intention is to take over an existing network device and produce a new one that appears like a wireless connection, returning enough canned responses to nl80211 to satisfy a standard network manager. If necessary, it can als

Hello Dear

2018-07-27 Thread Tracy William
Hello Dear, how are you today,I hope you are doing great. It is my great pleasure to contact you,I want to make a new and special friend,I hope you don't mind. My name is Tracy William from the United States, Am a french and English nationality. I will give you pictures and more details a

Re: pull request (net-next): ipsec-next 2018-07-27

2018-07-27 Thread David Miller
From: Steffen Klassert Date: Fri, 27 Jul 2018 09:24:35 +0200 > 4) Add virtual xfrm interfaces. The purpose of these interfaces >is to overcome the design limitations that the existing >VTI devices have. Thanks for taking the time to explain this in detail. Looks great. Pulled, thanks S

Re: pull request (net): ipsec 2018-07-27

2018-07-27 Thread David Miller
From: Steffen Klassert Date: Fri, 27 Jul 2018 08:51:49 +0200 > 1) Fix PMTU handling of vti6. We update the PMTU on >the xfrm dst_entry which is not cached anymore >after the flowchache removal. So update the >PMTU of the original dst_entry instead. >From Eyal Birger. > > 2) Fix a

[PATCH net] ipv4: remove BUG_ON() from fib_compute_spec_dst

2018-07-27 Thread Lorenzo Bianconi
Remove BUG_ON() from fib_compute_spec_dst routine and check in_dev pointer during flowi4 data structure initialization. fib_compute_spec_dst routine can be run concurrently with device removal where ip_ptr net_device pointer is set to NULL. This can happen if userspace enables pkt info on UDP rx so

Re: [PATCH net] net/mlx5e: Move mlx5e_priv_flags into en_ethtool.c

2018-07-27 Thread Kamal Heib
On Thu, Jul 26, 2018 at 11:51:49AM -0700, Saeed Mahameed wrote: > On Sun, Jul 15, 2018 at 12:06 PM, Kamal Heib wrote: > > Move the definition of mlx5e_priv_flags into en_ethtool.c because it's > > only used there. > > > > Fixes: 4e59e2888139 ("net/mlx5e: Introduce net device priv flags > > infras

Re: Deadlock with restart_syscall()

2018-07-27 Thread Stephen Hemminger
On Mon, 16 Jul 2018 09:31:06 +0200 André Pribil wrote: > Hello, > > I'm using kernel 4.14.52-rt34 on a single core ARM system and I'm seeing a > deadlock inside the kernel when two RT processes make calls in the right > temporal distance. The first process is trying to bring the Ethernet > in

Re: [net-next v5 3/3] net/tls: Remove redundant array allocation.

2018-07-27 Thread Dave Watson
On 07/27/18 09:34 AM, Vakul Garg wrote: > > > > -Original Message- > > From: Dave Watson [mailto:davejwat...@fb.com] > > Sent: Thursday, July 26, 2018 2:31 AM > > To: Vakul Garg > > Cc: David Miller ; netdev@vger.kernel.org; > > bor...@mellanox.com; avia...@mellanox.com; Doron Roberts-Ke

Re: [PATCH linux-firmware] Mellanox: Add new mlxsw_spectrum firmware 13.1702.6

2018-07-27 Thread Josh Boyer
Applied and pushed out. josh On Sun, Jul 22, 2018 at 7:43 AM Nir Dotan wrote: > > This new firmware contains: - Support for new types of cables - Support for > flashing future firmware without reboot - Support for Router ARP BC and UC > traps Signed-off-by: Nir Dotan --- WHENCE | 3 ++- > mella

Re: [PATCH iproute2 0/3] l2tp: remove unused fields in struct l2tp_parm

2018-07-27 Thread Guillaume Nault
On Fri, Jul 27, 2018 at 07:57:12AM -0700, Stephen Hemminger wrote: > On Fri, 27 Jul 2018 12:26:28 +0200 > Guillaume Nault wrote: > > > Several fields of struct l2tp_parm are handled by create_session() but > > can't actually be set by user. > > Most of these fields can also be set by get_response

Re:

2018-07-27 Thread Laura Marcela Ramirez Romero
Has ganado 1,500,000.00 usd Correo de contacto: juanabellofundat...@yandex.com Estimados todos, Espero que este correo os encuentre bien. Os envío los links de los dos primeros volúmenes de la Colección Perspectivas Iberoamericanas sobre la Justicia,

Re: [PATCH iproute2 0/3] l2tp: remove unused fields in struct l2tp_parm

2018-07-27 Thread Stephen Hemminger
On Fri, 27 Jul 2018 12:26:28 +0200 Guillaume Nault wrote: > Several fields of struct l2tp_parm are handled by create_session() but > can't actually be set by user. > Most of these fields can also be set by get_response(), but are ignored > afterwards. > > Since these fields can't have any visibl

[PATCH 5/5] net: remove sock_poll_busy_flag

2018-07-27 Thread Christoph Hellwig
Fold it into the only caller to make the code simpler and easier to read. Signed-off-by: Christoph Hellwig --- include/net/busy_poll.h | 6 -- net/socket.c| 16 +++- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/net/busy_poll.h b/include/ne

[PATCH 3/5] net: don not detour through struct sock to find the poll waitqueue

2018-07-27 Thread Christoph Hellwig
For any open socket file descriptor sock->sk->sk_wq->wait will always point to sock->wq->wait. That means we can do the shorter dereference and removal a NULL check and don't have to not worry about any RCU protection. Signed-off-by: Christoph Hellwig --- include/net/sock.h | 5 ++--- 1 file ch

[PATCH 2/5] net: simplify sock_poll_wait

2018-07-27 Thread Christoph Hellwig
The wait_address argument is always directly derived from the filp argument, so remove it. Signed-off-by: Christoph Hellwig --- crypto/af_alg.c| 2 +- include/net/sock.h | 11 ++- net/atm/common.c | 2 +- net/caif/caif_socket.c | 2 +- net/core/datagram.c| 2 +-

[PATCH 4/5] net: remove sock_poll_busy_loop

2018-07-27 Thread Christoph Hellwig
There is no point in hiding this logic in a helper. Also remove the useless events != 0 check and only busy loop once we know we actually have a poll method. Signed-off-by: Christoph Hellwig --- include/net/busy_poll.h | 9 - net/socket.c| 5 - 2 files changed, 4 inserti

[PATCH 1/5] net: remove bogus RCU annotations on socket.wq

2018-07-27 Thread Christoph Hellwig
We never use RCU protection for it, just a lot of cargo-cult rcu_deference_protects calls. Note that we do keep the kfree_rcu call for it, as the references through struct sock are RCU protected and thus might require a grace period before freeing. Signed-off-by: Christoph Hellwig --- include/l

socket poll related cleanups

2018-07-27 Thread Christoph Hellwig
A couple of cleanups I stumbled upon when studying the networking poll code.

Re: [PATCH net-next v4 1/4] net/sched: user-space can't set unknown tcfa_action values

2018-07-27 Thread Paolo Abeni
On Thu, 2018-07-26 at 21:28 -0300, Marcelo Ricardo Leitner wrote: > Hi, > > On Thu, Jul 26, 2018 at 04:34:57PM +0200, Paolo Abeni wrote: > ... > > @@ -895,6 +904,14 @@ struct tc_action *tcf_action_init_1(struct net *net, > > struct tcf_proto *tp, > > } > > } > > > > + if (!tcf

[PATCH net-next 8/8] selftests: mlxsw: Add test for trust-DSCP

2018-07-27 Thread Ido Schimmel
From: Petr Machata Add a test that exercises the new code. Send DSCP-tagged packets, and observe how they are prioritized in the switch and the DSCP is updated on egress again. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- .../drivers/net/mlxsw/qos_dscp_bridge.sh | 248

[PATCH net-next 5/8] mlxsw: reg: Add QoS ReWrite Enable Register

2018-07-27 Thread Ido Schimmel
From: Petr Machata This register configures the rewrite enable (whether PCP or DSCP value in packet should be updated according to packet priority) per receive port. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 39

[PATCH net-next 7/8] mlxsw: spectrum: Support ieee_setapp, ieee_delapp

2018-07-27 Thread Ido Schimmel
From: Petr Machata The APP TLVs are used for communicating priority-to-protocol ID maps for a given netdevice. Support the following APP TLVs: - DSCP (selector 5) to configure priority-to-DSCP code point maps. Use these maps to configure packet priority on ingress, and DSCP code point rewrit

[PATCH net-next 6/8] mlxsw: reg: Add QoS Priority to DSCP Mapping Register

2018-07-27 Thread Ido Schimmel
From: Petr Machata This register controls mapping from Priority to DSCP for purposes of rewrite. Note that rewrite happens as the packet is transmitted provided that the DSCP rewrite bit is enabled for the packet. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/etherne

[PATCH net-next 3/8] mlxsw: reg: Add QoS Port DSCP to Priority Mapping Register

2018-07-27 Thread Ido Schimmel
From: Petr Machata The QPDPM register controls the mapping from DSCP field to Switch Priority for IP packets. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 52 +++ 1 file changed, 52 insertions(+) diff --git a/driv

[PATCH net-next 2/8] net: dcb: Add priority-to-DSCP map getters

2018-07-27 Thread Ido Schimmel
From: Petr Machata On ingress, a network device such as a switch assigns to packets priority based on various criteria. Common options include interpreting PCP and DSCP fields according to user configuration. When a packet egresses the switch, a reverse process may rewrite PCP and/or DSCP values

[PATCH net-next 4/8] mlxsw: reg: Add QoS Priority Trust State Register

2018-07-27 Thread Ido Schimmel
From: Petr Machata The QPTS register controls the port policy to calculate the switch priority and packet color based on incoming packet fields. Signed-off-by: Petr Machata Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 39 +++ 1 file changed,

[PATCH net-next 1/8] net: dcb: For wild-card lookups, use priority -1, not 0

2018-07-27 Thread Ido Schimmel
From: Petr Machata The function dcb_app_lookup walks the list of specified DCB APP entries, looking for one that matches a given criteria: ifindex, selector, protocol ID and optionally also priority. The "don't care" value for priority is set to 0, because that priority has not been allowed under

[PATCH net-next 0/8] mlxsw: Support DSCP prioritization and rewrite

2018-07-27 Thread Ido Schimmel
Petr says: On ingress, a network device such as a switch assigns to packets priority based on various criteria. Common options include interpreting PCP and DSCP fields according to user configuration. When a packet egresses the switch, a reverse process may rewrite PCP and/or DSCP headers accordin

[PATCH iproute2 0/3] l2tp: remove unused fields in struct l2tp_parm

2018-07-27 Thread Guillaume Nault
Several fields of struct l2tp_parm are handled by create_session() but can't actually be set by user. Most of these fields can also be set by get_response(), but are ignored afterwards. Since these fields can't have any visible effect, let's just remove them. Guillaume Nault (3): l2tp: drop dat

[PATCH iproute2 3/3] l2tp: drop lns_mode

2018-07-27 Thread Guillaume Nault
This option is never set. Signed-off-by: Guillaume Nault --- ip/ipl2tp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index 41fefb85..5e7f0390 100644 --- a/ip/ipl2tp.c +++ b/ip/ipl2tp.c @@ -58,7 +58,6 @@ struct l2tp_parm { unsigned int udp_csum:1;

[PATCH iproute2 2/3] l2tp: drop mtu

2018-07-27 Thread Guillaume Nault
This option can't be set by user and is never printed. Signed-off-by: Guillaume Nault --- ip/ipl2tp.c | 5 - 1 file changed, 5 deletions(-) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index aca9912c..41fefb85 100644 --- a/ip/ipl2tp.c +++ b/ip/ipl2tp.c @@ -53,7 +53,6 @@ struct l2tp_parm {

[PATCH iproute2 1/3] l2tp: drop data_seq

2018-07-27 Thread Guillaume Nault
This option can't be set by user and is never printed. Furthermore, L2TP_ATTR_DATA_SEQ has always been a noop in Linux. Signed-off-by: Guillaume Nault --- ip/ipl2tp.c | 5 - 1 file changed, 5 deletions(-) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index 05e96387..aca9912c 100644 --- a/ip/ipl2tp

pull-request: can-next 2018-01-16

2018-07-27 Thread Marc Kleine-Budde
t.git tags/linux-can-next-for-4.19-20180727 for you to fetch changes up to 1f6ed42c742e8d1cfd3811ef7a134eaa75a511d6: can: kvaser_usb: Simplify struct kvaser_cmd_cardinfo (2018-07-27 10:40:19 +0200) ---- li

RE: [net-next v5 3/3] net/tls: Remove redundant array allocation.

2018-07-27 Thread Vakul Garg
> -Original Message- > From: Dave Watson [mailto:davejwat...@fb.com] > Sent: Thursday, July 26, 2018 2:31 AM > To: Vakul Garg > Cc: David Miller ; netdev@vger.kernel.org; > bor...@mellanox.com; avia...@mellanox.com; Doron Roberts-Kedes > > Subject: Re: [net-next v5 3/3] net/tls: Remove

RE: Deadlock with restart_syscall()

2018-07-27 Thread André Pribil
> I've found this thread, where a similar issue with restart_syscall() > has been reported: > https://www.spinics.net/lists/netdev/msg415144.html Found another old report about restart_syscall() producing a dead loop: https://lists.gt.net/linux/kernel/2371438 I do not agree with the conclusion th

[PATCH net-next] cxgb4: print ULD queue information managed by LLD

2018-07-27 Thread Rahul Lakkireddy
Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 296 +++-- 1 file changed, 277 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxg

[PATCH net-next 4/4] l2tp: drop ->mru from struct l2tp_session

2018-07-27 Thread Guillaume Nault
This field is not used. Treat PPPIOC*MRU the same way as PPPIOC*FLAGS: "get" requests return 0, while "set" requests vadidate the user supplied pointer but discard its value. Signed-off-by: Guillaume Nault --- include/uapi/linux/l2tp.h | 2 +- net/l2tp/l2tp_core.c | 1 - net/l2tp/l2tp_co

[PATCH net-next 0/4] l2tp: remove unused session fields

2018-07-27 Thread Guillaume Nault
Several fields of the session structures can be set, but remain unused otherwise. This series removes these fields and explicitely ignores the associated ioctls and netlink attributes. Guillaume Nault (4): l2tp: ignore L2TP_ATTR_DATA_SEQ netlink attribute l2tp: ignore L2TP_ATTR_VLAN_ID netlink

[PATCH net-next 3/4] l2tp: drop ->flags from struct pppol2tp_session

2018-07-27 Thread Guillaume Nault
This field is not used. Keep validating user input in PPPIOCSFLAGS. Even though we discard the value, it would look wrong to succeed if an invalid address was passed from userspace. Signed-off-by: Guillaume Nault --- net/l2tp/l2tp_ppp.c | 13 ++--- 1 file changed, 2 insertions(+), 11 de

[PATCH net-next 1/4] l2tp: ignore L2TP_ATTR_DATA_SEQ netlink attribute

2018-07-27 Thread Guillaume Nault
The value of this attribute is never used. Signed-off-by: Guillaume Nault --- include/uapi/linux/l2tp.h | 7 --- net/l2tp/l2tp_core.h | 8 net/l2tp/l2tp_debugfs.c | 4 +--- net/l2tp/l2tp_netlink.c | 6 -- 4 files changed, 5 insertions(+), 20 deletions(-) diff --git a/i

[PATCH net-next 2/4] l2tp: ignore L2TP_ATTR_VLAN_ID netlink attribute

2018-07-27 Thread Guillaume Nault
The value of this attribute is never used. Signed-off-by: Guillaume Nault --- include/uapi/linux/l2tp.h | 4 ++-- net/l2tp/l2tp_core.h | 1 - net/l2tp/l2tp_netlink.c | 3 --- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/uapi/linux/l2tp.h b/include/uapi/linux/l2tp

[PATCHv4 net-next 1/2] route: add support for directed broadcast forwarding

2018-07-27 Thread Xin Long
This patch implements the feature described in rfc1812#section-5.3.5.2 and rfc2644. It allows the router to forward directed broadcast when sysctl bc_forwarding is enabled. Note that this feature could be done by iptables -j TEE, but it would cause some problems: - target TEE's gateway param has

[PATCHv4 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

2018-07-27 Thread Xin Long
As Ido's suggestion, this patch is to add a selftest for directed broadcast forwarding with vrf. It does the assertion by checking the src IP of the echo-reply packet in ping_test_from. Signed-off-by: Xin Long --- .../selftests/net/forwarding/router_broadcast.sh | 233 + 1

[PATCHv4 net-next 0/2] route: add support and selftests for directed broadcast forwarding

2018-07-27 Thread Xin Long
Patch 1/2 is the feature and 2/2 is the selftest. Check the changelog on each of them to know the details. v1->v2: - fix a typo in changelog. - fix an uapi break that Davide noticed. - flush route cache when bc_forwarding is changed. - add the selftest for this patch as Ido's suggestion.

[PATCH][net-next] openvswitch: eliminate cpu_used_mask from sw_flow

2018-07-27 Thread Li RongQing
The size of struct cpumask varies with CONFIG_NR_CPUS, some config CONFIG_NR_CPUS is very larger, like 5120, struct cpumask will take 640 bytes, if there is thousands of flows, it will take lots of memory cpu_used_mask has two purposes 1: Assume first cpu as cpu0 which maybe not true; now use c

[patch net-next] net: sched: don't dump chains only held by actions

2018-07-27 Thread Jiri Pirko
From: Jiri Pirko In case a chain is empty and not explicitly created by a user, such chain should not exist. The only exception is if there is an action "goto chain" pointing to it. In that case, don't show the chain in the dump. Track the chain references held by actions and use them to find out

Re: [PATCH RFC ipsec-next] xfrm: Check Reverse-Mark Lookup Before ADDSA/DELSA

2018-07-27 Thread Steffen Klassert
On Wed, Jul 25, 2018 at 03:36:47PM -0700, Nathan Harold wrote: > > diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c > index b669262682c9..ee212a7c91a9 100644 > --- a/net/xfrm/xfrm_state.c > +++ b/net/xfrm/xfrm_state.c > @@ -815,10 +815,10 @@ xfrm_init_tempstate(struct xfrm_state *x, cons

[PATCH 07/14] xfrm: use time64_t for in-kernel timestamps

2018-07-27 Thread Steffen Klassert
From: Arnd Bergmann The lifetime managment uses '__u64' timestamps on the user space interface, but 'unsigned long' for reading the current time in the kernel with get_seconds(). While this is probably safe beyond y2038, it will still overflow in 2106, and the get_seconds() call is deprecated be

[PATCH 01/14] xfrm: Extend the output_mark to support input direction and masking.

2018-07-27 Thread Steffen Klassert
We already support setting an output mark at the xfrm_state, unfortunately this does not support the input direction and masking the marks that will be applied to the skb. This change adds support applying a masked value in both directions. The existing XFRMA_OUTPUT_MARK number is reused for this

  1   2   >