Re: [PATCH net-next] xdp: fix uninitialized 'err' variable

On 07/17/2018 04:08 AM, Jakub Kicinski wrote: > Smatch caught an uninitialized variable error which GCC seems > to miss. > > Fixes: a25717d2b604 ("xdp: support simultaneous driver and hw XDP attachment") > Signed-off-by: Jakub Kicinski Acked-by: Daniel Borkmann David, feel free to take this di

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

On Fri, Jul 13, 2018 at 9:39 PM Marcelo Ricardo Leitner wrote: > > On Fri, Jul 13, 2018 at 11:26:28AM -0700, Cong Wang wrote: > > On Fri, Jul 13, 2018 at 6:04 AM Marcelo Ricardo Leitner > > wrote: > > > > > > On Thu, Jul 12, 2018 at 11:05:45PM -0700, Cong Wang wrote: > > > > On Wed, Jul 11, 2018

Re: [PATCH net-next] liquidio: correct error msg text when removing VLAN ID

From: Felix Manlunas Date: Mon, 16 Jul 2018 18:06:07 -0700 > From: Rick Farrington > > Signed-off-by: Rick Farrington > Signed-off-by: Felix Manlunas Applied.

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

On Fri, Jul 13, 2018 at 9:51 PM Marcelo Ricardo Leitner wrote: > > Well, it would help if you didn't cut out key parts of my words. Sorry about it, please allow me to copy and paste all of your words here: "Yes, but Michel wants to drop from other lower priorities if needed, and that's not possi

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

On 07/17/2018 12:20 AM, Sowmini Varadhan wrote: - Looks like rds_connect() is checking things in the right order (thanks) However, rds_cancel_sent_to is still looking at the len to figure out the family.. as we move to ipv6, it would be better if we allow the caller to specify stru

Re: [PATCH ipsec-next] xfrm: Allow Set Mark to be Updated Using UPDSA

On Mon, 16 Jul 2018 15:27:26 -0700 Nathan Harold wrote: > < re-sent with apologies due to incorrect formatting last > time... :-( > > > Hi Eyal, > > > If x1 points to a state previously found using > > __xfrm_state_locate(x), won't __xfrm_state_bump_genids(x1) be > > equivalent to x1->genid++ i

Re: [PATCH bpf-next 6/9] bpf: offload: allow program and map sharing per-ASIC

On Mon, 16 Jul 2018 20:00:47 -0700, Alexei Starovoitov wrote: > On Mon, Jul 16, 2018 at 07:37:20PM -0700, Jakub Kicinski wrote: > > Create a higher-level entity to represent a device/ASIC to allow > > programs and maps to be shared between device ports. The extra > > work is required to make sure

Re: [PATCH bpf-next 6/9] bpf: offload: allow program and map sharing per-ASIC

On Mon, Jul 16, 2018 at 07:37:20PM -0700, Jakub Kicinski wrote: > Create a higher-level entity to represent a device/ASIC to allow > programs and maps to be shared between device ports. The extra > work is required to make sure we don't destroy BPF objects as > soon as the netdev for which they we

[PATCH bpf-next 5/9] bpf: offload: aggregate offloads per-device

Currently we have two lists of offloaded objects - programs and maps. Netdevice unregister notifier scans those lists to orphan objects associated with device being unregistered. This puts unnecessary (even if negligible) burden on all netdev unregister calls in BPF- -enabled kernel. The lists of

[PATCH bpf-next 7/9] netdevsim: allow program sharing between devices

Allow program sharing between devices which were linked together. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/netdevsim/bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/bpf.c b/drivers/net/netdevsim/bpf.c index 9eab29f

[PATCH bpf-next 9/9] selftests/bpf: add test for sharing objects between netdevs

Add tests for sharing programs and maps between different netdevs. Use netdevsim's ability to pretend multiple netdevs belong to the same "ASIC". Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/testing/selftests/bpf/test_offload.py | 146 +++- 1 file changed,

[PATCH bpf-next 0/9] bpf: offload program and map sharing

Hi! This patchset adds support for sharing BPF objects within one ASIC. This will allow us to reuse of the same program on multiple ports of a device leading to better code store utilization. It also enables sharing maps between programs attached to different ports of a device. Jakub Kicinski (9

[PATCH bpf-next 6/9] bpf: offload: allow program and map sharing per-ASIC

Create a higher-level entity to represent a device/ASIC to allow programs and maps to be shared between device ports. The extra work is required to make sure we don't destroy BPF objects as soon as the netdev for which they were loaded gets destroyed, as other ports may still be using them. When

[PATCH bpf-next 2/9] netdevsim: add shared netdevsim devices

Factor out sharable netdevsim sub-object and use IFLA_LINK to link netdevsims together at creation time. Sharable object will have its own DebugFS directory. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/netdevsim/netdev.c| 87 --- dr

[PATCH bpf-next 8/9] nfp: bpf: allow program sharing within ASIC

Allow program sharing between netdevs of the same NFP ASIC. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/bpf/offload.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/offloa

[PATCH bpf-next 3/9] netdevsim: associate bound programs with shared dev

Move bound program information from netdevsim to shared sub-object, as programs will soon be shared between netdevs of the same ASIC. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/netdevsim/bpf.c | 30 - drivers/net/netdevsim/netde

[PATCH bpf-next 1/9] netdevsim: add switch_id attribute

Grouping netdevsim devices into "ASICs" will soon be supported. Add switch_id attribute to all netdevsims. For now each netdevsim will have its switch_id matching the device id. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/netdevsim/netdev.c| 24 +++

[PATCH bpf-next 4/9] nfp: add .ndo_init() and .ndo_uninit() callbacks

BPF code should unregister the offload capabilities from .ndo_uninit(), to make sure the operation is atomic with unlist_netdevice(). Plumb the init/uninit NDOs for vNICs and representors. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/nfp_app.

[net-next:master 238/243] drivers/net/phy/mdio-thunder.c:40:8: error: implicit declaration of function 'pcim_enable_device'; did you mean 'pci_enable_device'?

Hi Alexander, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: ccdb51717ba3bdc9585998e4ffd41d70c04dedea commit: 7e2bc7fb65d544bb8598a0ab64e40ee9c60ded6e [238/243] net: cavium: Drop dependency of NET_VENDOR_CAVIUM o

[PATCH net-next] xdp: fix uninitialized 'err' variable

Smatch caught an uninitialized variable error which GCC seems to miss. Fixes: a25717d2b604 ("xdp: support simultaneous driver and hw XDP attachment") Signed-off-by: Jakub Kicinski --- net/core/rtnetlink.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/net/cor

[PATCH mlx5-next 5/8] net/mlx5: Add missing SET_DRIVER_VERSION command translation

From: Noa Osherovich When translating command opcodes to a string, SET_DRIVER_VERSION command was missing. Fixes: 42ca502e179d0 ('net/mlx5_core: Use a macro in mlx5_command_str()') Signed-off-by: Noa Osherovich Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c |

[PATCH mlx5-next 8/8] net/mlx5: Fix tristate and description for MLX5 module

From: Eran Ben Elisha Current description did not include new devices. Fix that by proving the correct generic description. Signed-off-by: Eran Ben Elisha Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/Kconfig | 2 +- drivers/net/ethernet/mellanox/mlx5/core/Kconfig

[PATCH mlx5-next 4/8] net/mlx5: Add XRQ commands definitions

From: Max Gurtovoy Update mlx5 command list and error return function to handle XRQ commands. Signed-off-by: Max Gurtovoy Reviewed-by: Daniel Jurgens Reviewed-by: Artemy Kovalyov Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c |

[PATCH mlx5-next 7/8] net/mlx5: Better return types for CQE API

From: Tariq Toukan Reduce sizes of return types. Use bool for binary indication. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- include/linux/mlx5/device.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/mlx5/device.h b/include/linux/ml

[PATCH mlx5-next 2/8] net/mlx5: Expose MPEGC (Management PCIe General Configuration) structures

From: Eran Ben Elisha This patch exposes PRM layout for handling MPEGC (Management PCIe General Configuration). This will be used in the downstream patch for configuring MPEGC via the driver. Signed-off-by: Eran Ben Elisha Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- include

[PATCH mlx5-next 1/8] net/mlx5: FW tracer, add hardware structures

From: Feras Daoud This change adds the infrastructure to mlx5 core fw tracer. It introduces the following 4 new registers: MLX5_REG_MTRC_CAP - Used to read tracer capabilities MLX5_REG_MTRC_CONF - Used to set tracer configurations MLX5_REG_MTRC_STDB - Used to query tracer strings database MLX5_R

[PATCH mlx5-next 6/8] net/mlx5: Use ERR_CAST() instead of coding it

From: Roi Dayan This makes it more readable that rule is being used to return an err. Signed-off-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/

[PATCH mlx5-next 3/8] net/mlx5: Add core support for double vlan push/pop steering action

From: Jianbo Liu As newer firmware supports double push/pop in a single FTE, we add core bits and extend vlan action logic for it. Signed-off-by: Jianbo Liu Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/diag/fs_tracepoint.h | 2 ++ .../ethernet/me

[PATCH mlx5-next 0/8] Mellanox, mlx5 updates 2018-07-16

Hi, This series includes mlx5 core infrastructure updates and fixes aimed for mlx5-next branch. In case of no objections, below patches will be applied to mlx5-next branch and next mlx5 net-next pull request will start with a merge commit pointing to the last patch in this series. >From Eran: -

[PATCH net-next] liquidio: correct error msg text when removing VLAN ID

From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 2 +- drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/caviu

Re: [PATCH v2 iproute2-next 06/31] tc/util: add print helpers for JSON

On 7/10/18 3:05 PM, Stephen Hemminger wrote: > From: Stephen Hemminger > > Add a helper to print rate, time and size in numeric or pretty format > based on JSON flag. > > Signed-off-by: Stephen Hemminger > --- > tc/tc_util.c | 83 +--- > tc/tc_ut

Re: [PATCH][net-next][v2] net: convert gro_count to bitmask

Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on next-20180713] [cannot apply to v4.18-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.co

Re: [PATCH] net: cavium: Drop dependency of NET_VENDOR_CAVIUM on PCI

/commits/Alexander-Sverdlin/net-cavium-Drop-dependency-of-NET_VENDOR_CAVIUM-on-PCI/20180716-002448 config: s390-defconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

Re: [PATCH next] bonding: pass link-local packets to bonding master also.

On Mon, 16 Jul 2018 16:57:22 -0700 Mahesh Bandewar (महेश बंडेवार) wrote: > On Mon, Jul 16, 2018 at 4:33 PM, Stephen Hemminger > wrote: > > On Sun, 15 Jul 2018 18:12:46 -0700 > > Mahesh Bandewar wrote: > > > >> From: Mahesh Bandewar > >> > >> Commit b89f04c61efe ("bonding: deliver link-local

Re: [PATCH][net-next][v2] net: convert gro_count to bitmask

From: Eric Dumazet Date: Mon, 16 Jul 2018 16:40:52 -0700 > I guess we could either use BITS_PER_LONG or : > > diff --git a/net/core/dev.c b/net/core/dev.c > index > c883b17ee0fe2c8a7ca2f2867560ba74004790a7..4f8b92d81d107fc9acd2499297435cbd9e9b5c67 > 100644 > --- a/net/core/dev.c > +++ b/net/co

Re: [PATCH next] bonding: pass link-local packets to bonding master also.

On Mon, Jul 16, 2018 at 4:33 PM, Stephen Hemminger wrote: > On Sun, 15 Jul 2018 18:12:46 -0700 > Mahesh Bandewar wrote: > >> From: Mahesh Bandewar >> >> Commit b89f04c61efe ("bonding: deliver link-local packets with >> skb->dev set to link that packets arrived on") changed the behavior >> of how

Re: [PATCH next] bonding: pass link-local packets to bonding master also.

On Mon, Jul 16, 2018 at 2:24 PM, Jay Vosburgh wrote: > Mahesh Bandewar wrote: > >>From: Mahesh Bandewar >> >>Commit b89f04c61efe ("bonding: deliver link-local packets with >>skb->dev set to link that packets arrived on") changed the behavior >>of how link-local-multicast packets are processed. T

[net:master 66/72] drivers/net/hyperv/rndis_filter.c:1341:16: sparse: Using plain integer as NULL pointer

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 3578a7ecb69920efc3885dbd610e98c00dbdf5db commit: 916c5e1413be058d1c1f6e502db350df890730ce [66/72] hv/netvsc: fix handling of fallback to single queue mode reproduce: # apt-get install sparse git ch

Re: [PATCH][net-next][v2] net: convert gro_count to bitmask

On 07/12/2018 11:41 PM, Li RongQing wrote: > gro_hash size is 192 bytes, and uses 3 cache lines, if there is few */ > @@ -9264,6 +9273,9 @@ static struct hlist_head * __net_init > netdev_create_hash(void) > /* Initialize per network namespace state */ > static int __net_init

Re: [PATCH net-next 4/4] act_mirred: use ACT_REDIRECT when possible

On Fri, Jul 13, 2018 at 2:55 AM Paolo Abeni wrote: > > When mirred is invoked from the ingress path, and it wants to redirect > the processed packet, it can now use the ACT_REDIRECT action, > filling the tcf_result accordingly. > > This avoids a skb_clone() in the TC S/W data path giving a ~10% >

Re: [PATCH bpf-next 0/2] tools: bpf: build cleanups

On Tue, Jul 17, 2018 at 12:34:03AM +0200, Daniel Borkmann wrote: > On 07/16/2018 07:57 PM, Jakub Kicinski wrote: > > Hi! > > > > While tracking down the perf vs libbpf vs reallocarray build issue > > I noticed libbpf is checking for a feature it never uses and that > > bpftool's makefile attempt t

Re: [PATCH next] bonding: pass link-local packets to bonding master also.

On Sun, 15 Jul 2018 18:12:46 -0700 Mahesh Bandewar wrote: > From: Mahesh Bandewar > > Commit b89f04c61efe ("bonding: deliver link-local packets with > skb->dev set to link that packets arrived on") changed the behavior > of how link-local-multicast packets are processed. The change in > the beh

Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

On 07/16/2018 02:52 PM, Jesus Sanchez-Palencia wrote: > Hi Eric, > > > > On 07/13/2018 10:35 AM, Eric Dumazet wrote: >> >> >> On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote: >>> This is done in preparation for the upcoming time based transmission >>> patchset. Now that skb->tstamp will

Re: [PATCH bpf-next 0/2] tools: bpf: build cleanups

On 07/16/2018 07:57 PM, Jakub Kicinski wrote: > Hi! > > While tracking down the perf vs libbpf vs reallocarray build issue > I noticed libbpf is checking for a feature it never uses and that > bpftool's makefile attempt to reuse feature dump doesn't really > make sense. > > Jakub Kicinski (2): >

Re: [PATCH ipsec-next] xfrm: Allow Set Mark to be Updated Using UPDSA

< re-sent with apologies due to incorrect formatting last time... :-( > Hi Eyal, > If x1 points to a state previously found using __xfrm_state_locate(x), > won't __xfrm_state_bump_genids(x1) be equivalent to x1->genid++ in > this case? In the vanilla case this is true. IE, if there are no strang

[PATCH iproute2 net-next] ipneigh: exclude NTF_EXT_LEARNED from default filter

From: Roopa Prabhu NUD_NOARP entries are filtered out by default by iproute2. We dont want NUD_NOARP with NTF_EXT_LEARNED flag filtered out. This patch extends the default filter check for ip neigh show to include the NTF_EXT_LEARNED flag. Signed-off-by: Roopa Prabhu --- ip/ipneigh.c | 1 + 1

Re: [PATCH 2/2] samples/bpf: test_cgrp2_sock2: fix an off by one

On Fri, Jul 13, 2018 at 06:05:37PM +0300, Dan Carpenter wrote: > "prog_cnt" is the number of elements which are filled out in prog_fd[] > so the test should be >= instead of >. > > Signed-off-by: Dan Carpenter since this is sample code I've applied both patches to bpf-next tree. Thanks

RE: [RFC PATCH mlx5-next 07/18] net/mlx5: Expose new packet reformat capabilities

> -Original Message- > From: Or Gerlitz [mailto:gerlitz...@gmail.com] > Sent: Monday, July 16, 2018 2:33 PM > To: Mark Bloch > Cc: Doug Ledford ; Jason Gunthorpe > ; Leon Romanovsky ; RDMA > mailing list ; Saeed Mahameed > ; linux-netdev > Subject: Re: [RFC PATCH mlx5-next 07/18] net/mlx

Re: [PATCH v2 net-next 01/14] net: Clear skb->tstamp only on the forwarding path

Hi Eric, On 07/13/2018 10:35 AM, Eric Dumazet wrote: > > > On 07/03/2018 03:42 PM, Jesus Sanchez-Palencia wrote: >> This is done in preparation for the upcoming time based transmission >> patchset. Now that skb->tstamp will be used to hold packet's txtime, >> we must ensure that it is being cl

Re: [PATCH net-next] cxgb4: collect ASIC LA dumps from ULP TX

From: Rahul Lakkireddy Date: Mon, 16 Jul 2018 19:40:54 +0530 > From: Surendra Mobiya > > Signed-off-by: Surendra Mobiya > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar Applied, thank you.

RE: [RFC PATCH rdma-next 13/18] RDMA/mlx5: Enable decap and packet reformat on flow tables

> -Original Message- > From: Or Gerlitz [mailto:gerlitz...@gmail.com] > Sent: Monday, July 16, 2018 2:24 PM > To: Mark Bloch > Cc: Doug Ledford ; Jason Gunthorpe > ; Leon Romanovsky ; RDMA > mailing list ; Saeed Mahameed > ; linux-netdev > Subject: Re: [RFC PATCH rdma-next 13/18] RDMA/ml

Re: [PATCH net 0/2] tg3: Update copyright and fix for tx timeout with 5762

From: Siva Reddy Kallam Date: Mon, 16 Jul 2018 11:13:30 +0530 > From: Siva Reddy Kallam > > First patch: > Update copyright > > Second patch: > Add higher cpu clock for 5762 Series applied, thank you.

Re: [PATCH net] ibmvnic: Fix error recovery on login failure

From: John Allen Date: Mon, 16 Jul 2018 10:29:30 -0500 > Testing has uncovered a failure case that is not handled properly. In the > event that a login fails and we are not able to recover on the spot, we > return 0 from do_reset, preventing any error recovery code from being > triggered. Additi

Re: [RFC PATCH mlx5-next 07/18] net/mlx5: Expose new packet reformat capabilities

On Mon, Jul 16, 2018 at 11:22 AM, Leon Romanovsky wrote: > From: Mark Bloch > > Expose new abilities when creating a packet reformat context. > > The new types which can be created are: > MLX5_REFORMAT_TYPE_L2_TO_L2_TUNNEL: Ability to create generic encap > opertion to be done by the HW. opertio

Re: [RFC PATCH mlx5-next 04/18] net/mlx5: Break encap/decap into two separated flags

On Mon, Jul 16, 2018 at 11:22 AM, Leon Romanovsky wrote: > From: Mark Bloch > > Today we are able to attach encap and decap actions only to the FDB. > In preparation to enable those actions on the NIC flow tables break tables break --> tables, break > the single flag into two.

Re: [RFC PATCH mlx5-next 02/18] net/mlx5: Export modify header alloc/dealloc functions

On Mon, Jul 16, 2018 at 11:22 AM, Leon Romanovsky wrote: > From: Mark Bloch > > Those function will be used by the RDMA side to create modify header function --> functions > actions to be attached to flow steering rules via verbs.

Re: [PATCH next] bonding: pass link-local packets to bonding master also.

Mahesh Bandewar wrote: >From: Mahesh Bandewar > >Commit b89f04c61efe ("bonding: deliver link-local packets with >skb->dev set to link that packets arrived on") changed the behavior >of how link-local-multicast packets are processed. The change in >the behavior broke some legacy use cases where t

Re: [RFC PATCH rdma-next 13/18] RDMA/mlx5: Enable decap and packet reformat on flow tables

On Mon, Jul 16, 2018 at 11:23 AM, Leon Romanovsky wrote: > From: Mark Bloch > > If NIC RX flow tables support decap opertion, enable it on creation. opertion --> operation > If NIC TX flow tables support reformat opertion, enable it on creation. What is the trigger to use the decap flag on RX

Re: [RFC PATCH mlx5-next 01/18] net/mlx5: Add proper NIC TX steering flow tables support

On Mon, Jul 16, 2018 at 11:22 AM, Leon Romanovsky wrote: > From: Mark Bloch > > Expose the ability to add steering rules to NIC TX flow tables. > For now, we are only adding TX bypass (egress) which is used by the RDMA > side. While we are here clean the switch logic. > > We expose the same numbe

Re: [PATCH v2 net] net/ipv6: Do not allow device only routes via the multipath API

From: dsah...@kernel.org Date: Sun, 15 Jul 2018 09:35:19 -0700 > From: David Ahern > > Eric reported that reverting the patch that fixed and simplified IPv6 > multipath routes means reverting back to invalid userspace notifications. > eg., > $ ip -6 route add 2001:db8:1::/64 nexthop dev eth0 nex

Re: [PATCH net] net/mlx4_en: Don't reuse RX page when XDP is set

From: Tariq Toukan Date: Sun, 15 Jul 2018 13:54:39 +0300 > From: Saeed Mahameed > > When a new rx packet arrives, the rx path will decide whether to reuse > the remainder of the page or not according to one of the below conditions: > 1. frag_info->frag_stride == PAGE_SIZE / 2 > 2. frags->page_o

Re: [RFC net-next v1 1/1] net/sched: Introduce the taprio scheduler

On Mon, 16 Jul 2018 10:13:23 -0700, Vinicius Costa Gomes wrote: > Hi Jiri, > > Jiri Pirko writes: > > [...] > > >> > >>gates.sched > > > > Any particular reason this has to be in file and not on the cmdline? > > The idea here was to keep longer schedules more manageable. And during > testi

Re: [PATCH net-next] mlxsw: spectrum: Expose counters for various packet sizes

From: Ido Schimmel Date: Sun, 15 Jul 2018 10:45:42 +0300 > From: Jiri Pirko > > Expose counters ASIC has in the group of RFC 2819 counters that count > number of packets within specific size range. > > Signed-off-by: Jiri Pirko > Signed-off-by: Ido Schimmel Applied.

Re: [PATCH net-next] liquidio: fix hang when re-binding VF host drv after running DPDK VF driver

From: Felix Manlunas Date: Fri, 13 Jul 2018 12:50:21 -0700 > From: Rick Farrington > > When configuring SLI_PKTn_OUTPUT_CONTROL, VF driver was assuming that IPTR > mode was disabled by reset, which was not true. Since DPDK driver had > set IPTR mode previously, the VF driver (which uses buf-pt

Re: [PATCH net] hv/netvsc: fix handling of fallback to single queue mode

From: Stephen Hemminger Date: Fri, 13 Jul 2018 10:38:38 -0700 > The netvsc device may need to fallback to running in single queue > mode if host side only wants to support single queue. > > Recent change for handling mtu broke this in setup logic. > > Reported-by: Dan Carpenter > Fixes: 3ffe64

[PATCH net] af_unix: ensure POLLOUT on remote close() for connected dgram sockets

Applications use ECONNREFUSED as returned from write() in order to determine that a socket should be closed. When using connected dgram unix sockets in a poll/write loop, this relies on POLLOUT being signaled when the remote end closes. However, due to a race POLLOUT can be missed when the remote c

Re: [PATCH net] ibmvnic: Revise RX/TX queue error messages

From: Thomas Falcon Date: Fri, 13 Jul 2018 12:03:32 -0500 > During a device failover, there may be latency between the loss > of the current backing device and a notification from firmware that > a failover has occurred. This latency can result in a large amount of > error printouts as firmware r

Re: [PATCH net] ipv6: make DAD fail with enhanced DAD when nonce length differs

From: Sabrina Dubroca Date: Fri, 13 Jul 2018 17:21:42 +0200 > Commit adc176c54722 ("ipv6 addrconf: Implemented enhanced DAD (RFC7527)") > added enhanced DAD with a nonce length of 6 bytes. However, RFC7527 > doesn't specify the length of the nonce, other than being 6 + 8*k bytes, > with integer k

Re: [PATCH] net: cavium: Drop dependency of NET_VENDOR_CAVIUM on PCI

From: Alexander Sverdlin Date: Fri, 13 Jul 2018 17:04:28 +0200 > Octeon Ethernet drivers work perfectly without PCI. > > Signed-off-by: Alexander Sverdlin Applied.

Re: [PATCH net-next] cxgb4: do not return DUPLEX_UNKNOWN when link is down

From: Ganesh Goudar Date: Fri, 13 Jul 2018 17:56:55 +0530 > We were returning DUPLEX_UNKNOWN in get_link_ksettings() when > the link was down. Unfortunately, this causes a problem when > "ethtool -s autoneg on" is issued for a link which is down because > the ethtool code first reads the setting

Re: [PATCH][net-next][v2] net: convert gro_count to bitmask

From: Li RongQing Date: Fri, 13 Jul 2018 14:41:36 +0800 > gro_hash size is 192 bytes, and uses 3 cache lines, if there is few > flows, gro_hash may be not fully used, so it is unnecessary to iterate > all gro_hash in napi_gro_flush(), to occupy unnecessary cacheline. > > convert gro_count to a b

Re: [PATCH net-next] net: ip6_gre: get ipv6hdr after skb_cow_head()

From: Prashant Bhole Date: Fri, 13 Jul 2018 14:40:50 +0900 > A KASAN:use-after-free bug was found related to ip6-erspan > while running selftests/net/ip6_gre_headroom.sh > > It happens because of following sequence: > - ipv6hdr pointer is obtained from skb > - skb_cow_head() is called, skb->head

Re: [PATCH net] tun: Fix use-after-free on XDP_TX

From: Toshiaki Makita Date: Fri, 13 Jul 2018 13:24:38 +0900 > On XDP_TX we need to free up the frame only when tun_xdp_tx() returns a > negative value. A positive value indicates that the packet is > successfully enqueued to the ptr_ring, so freeing the page causes > use-after-free. > > Fixes: 7

Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values

From: Helge Deller Date: Thu, 12 Jul 2018 22:36:29 +0200 > Use the existing %pad printk format to print dma_addr_t values. > This avoids the following warnings when compiling on the parisc platform: > > warning: format '%llx' expects argument of type 'long long unsigned int', but > argument 2 h

Re: [PATCH net-next] net: phy: realtek: add missing entry for RTL8211C to mdio_device_id table

From: Heiner Kallweit Date: Thu, 12 Jul 2018 21:45:08 +0200 > Add missing entry for RTL8211C to mdio_device_id table. > > Signed-off-by: Heiner Kallweit > Fixes: cf87915cb9f8 ("net: phy: realtek: add support for RTL8211C") Applied.

Re: [PATCH net-next v2 0/2] net: phy: add functionality to speed down PHY when waiting for WoL packet

From: Heiner Kallweit Date: Thu, 12 Jul 2018 21:30:19 +0200 > Some network drivers include functionality to speed down the PHY when > suspending and just waiting for a WoL packet because this saves energy. > > This patch is based on our recent discussion about factoring out this > functionality

Re: [PATCH net-next] selftests: tls: add selftests for TLS sockets

From: Dave Watson Date: Thu, 12 Jul 2018 10:59:20 -0700 > Add selftests for tls socket. Tests various iov and message options, > poll blocking and nonblocking behavior, partial message sends / receives, > and control message data. Tests should pass regardless of if TLS > is enabled in the kern

Re: [PATCH net] tls: Stricter error checking in zerocopy sendmsg path

From: Dave Watson Date: Thu, 12 Jul 2018 08:03:43 -0700 > In the zerocopy sendmsg() path, there are error checks to revert > the zerocopy if we get any error code. syzkaller has discovered > that tls_push_record can return -ECONNRESET, which is fatal, and > happens after the point at which it is

[net-next:master 717/734] drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c:173:21: sparse: cast to restricted __be64

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 568a74d491124c720e604ed3265722f969a5fb38 commit: afd3baaa938ce85dc738cd9279716cdb684cc707 [717/734] net/mlx5e: TLS, add software statistics reproduce: # apt-get install sparse git checkout af

RE: tc mqprio offload command error

> -Original Message- > From: Jesus Sanchez-Palencia > Sent: Monday, July 16, 2018 11:28 PM > To: Alexander Duyck ; Chopra, Manish > > Cc: Stephen Hemminger ; David Miller > ; Jiri Pirko ; > netdev@vger.kernel.org > Subject: Re: tc mqprio offload command error > > External Email > > Hi,

Re: [PATCH net v2] KEYS: DNS: fix parsing multiple options

From: Eric Biggers Date: Wed, 11 Jul 2018 10:46:29 -0700 > From: Eric Biggers > > My recent fix for dns_resolver_preparse() printing very long strings was > incomplete, as shown by syzbot which still managed to hit the > WARN_ONCE() in set_precision() by adding a crafted "dns_resolver" key: >

Re: [PATCHv2 net 0/2] multicast: init as INCLUDE when join SSM INCLUDE group

From: Hangbin Liu Date: Tue, 10 Jul 2018 22:41:25 +0800 > Based on RFC3376 5.1 and RFC3810 6.1, we should init as INCLUDE when join SSM > INCLUDE group. In my first version I only clear the group change record. But > this is not enough as when a new group join, it will init as EXCLUDE and > trigg

Re: tc mqprio offload command error

Hi, On 07/16/2018 10:20 AM, Alexander Duyck wrote: > On Sun, Jul 15, 2018 at 6:30 PM, Chopra, Manish > wrote: >> Hello Folks, >> >> I am trying to set below command to try mqprio offload on 4.18 kernel. It is >> throwing the flowing error. >> >> # tc qdisc add dev eth0 root mqprio num_tc 2 map

[PATCH bpf-next 2/2] tools: bpftool: don't pass FEATURES_DUMP to libbpf

bpftool does not export features it probed for, i.e. FEATURE_DUMP_EXPORT is always empty, so don't try to communicate the features to libbpf. It has no effect. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v1 iproute2] tc: Do not use addattr_nest_compat on mqprio and netem

Here we are partially reverting commit c14f9d92eee107 "treewide: Use addattr_nest()/addattr_nest_end() to handle nested attributes" . As discussed in [1], changing from the 'manually' coded version that used addattr_l() to addattr_nest_compat() wasn't functionally equivalent, because now the messa

[PATCH bpf-next 1/2] tools: libbpf: remove libelf-getphdrnum feature detection

libbpf does not depend on libelf-getphdrnum feature, don't check it. $ git grep HAVE_ELF_GETPHDRNUM_SUPPORT tools/perf/Makefile.config:CFLAGS += -DHAVE_ELF_GETPHDRNUM_SUPPORT tools/perf/util/symbol-elf.c:#ifndef HAVE_ELF_GETPHDRNUM_SUPPORT Signed-off-by: Jakub Kicinski Reviewed-by: Quentin M

[PATCH bpf-next 0/2] tools: bpf: build cleanups

Hi! While tracking down the perf vs libbpf vs reallocarray build issue I noticed libbpf is checking for a feature it never uses and that bpftool's makefile attempt to reuse feature dump doesn't really make sense. Jakub Kicinski (2): tools: libbpf: remove libelf-getphdrnum feature detection to

[net-next:master 716/721] drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls_rxtx.c:329:66: sparse: incorrect type in argument 6 (different base types)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: aea06eb276d99590f400c877ca2bd74b4db91330 commit: 00aebab27c8752c7420dce286270ccedc70ac39a [716/721] net/mlx5e: TLS, add Innova TLS rx data path reproduce: # apt-get install sparse git checkou

Re: tc mqprio offload command error

On Sun, Jul 15, 2018 at 6:30 PM, Chopra, Manish wrote: > Hello Folks, > > I am trying to set below command to try mqprio offload on 4.18 kernel. It is > throwing the flowing error. > > # tc qdisc add dev eth0 root mqprio num_tc 2 map 1 1 1 1 0 0 0 0 > RTNETLINK answers: Numerical result out of ra

Re: [PATCH v2 net] net/ipv6: Do not allow device only routes via the multipath API

On 7/16/18 10:09 AM, Eric Dumazet wrote: > Yes, I guess we have no real choice for the moment. It is unfortunate that we are forever stuck with this mess from a short sighted implementation years ago. From a uapi perspective, dev-only nexthops and proper add-to/append/replace semantics should have

Re: [RFC net-next v1 1/1] net/sched: Introduce the taprio scheduler

Hi Jiri, Jiri Pirko writes: [...] >> >>gates.sched > > Any particular reason this has to be in file and not on the cmdline? The idea here was to keep longer schedules more manageable. And during testing I found it more ergonomic to have a file. It also has the advantage that the file can be r

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

Hey Max: On 7/16/2018 11:46 AM, Max Gurtovoy wrote: > > > On 7/16/2018 5:59 PM, Sagi Grimberg wrote: >> >>> Hi, >>> I've tested this patch and seems problematic at this moment. >> >> Problematic how? what are you seeing? > > Connection failures and same error Steve saw: > > [Mon Jul 16 16:19:11 2

Re: [PATCH RFC net-next] openvswitch: Queue upcalls to userspace in per-port round-robin order

On Tue, Jul 10, 2018 at 6:31 PM Pravin Shelar wrote: > > On Wed, Jul 4, 2018 at 7:23 AM, Matteo Croce wrote: > > From: Stefano Brivio > > > > Open vSwitch sends to userspace all received packets that have > > no associated flow (thus doing an "upcall"). Then the userspace > > program creates a n

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

On 7/16/2018 5:59 PM, Sagi Grimberg wrote: Hi, I've tested this patch and seems problematic at this moment. Problematic how? what are you seeing? Connection failures and same error Steve saw: [Mon Jul 16 16:19:11 2018] nvme nvme0: Connect command failed, error wo/DNR bit: -16402 [Mon

Re: [PATCH v3 net-next 0/3] rds: IPv6 support

- Looks like rds_connect() is checking things in the right order (thanks) However, rds_cancel_sent_to is still looking at the len to figure out the family.. as we move to ipv6, it would be better if we allow the caller to specify struct sockaddr_storage, or even a union of sockaddr_

Re: [PATCH v2 net] net/ipv6: Do not allow device only routes via the multipath API

On 07/15/2018 09:35 AM, dsah...@kernel.org wrote: > From: David Ahern > > Eric reported that reverting the patch that fixed and simplified IPv6 > multipath routes means reverting back to invalid userspace notifications. > eg., > $ ip -6 route add 2001:db8:1::/64 nexthop dev eth0 nexthop dev et

[PATCH net] ibmvnic: Fix error recovery on login failure

Testing has uncovered a failure case that is not handled properly. In the event that a login fails and we are not able to recover on the spot, we return 0 from do_reset, preventing any error recovery code from being triggered. Additionally, the state is set to "probed" meaning that when we are abl

[net-next:master 715/721] drivers/net/ethernet/mellanox/mlx5/core/en_accel/tls.c:172:52: sparse: incorrect type in argument 2 (different base types)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: aea06eb276d99590f400c877ca2bd74b4db91330 commit: ca942c78f3237e09567d80ac19dffe9690c74d79 [715/721] net/mlx5e: TLS, add innova rx support reproduce: # apt-get install sparse git checkout ca94

Re: [PATCH mlx5-next] RDMA/mlx5: Don't use cached IRQ affinity mask

Hi, I've tested this patch and seems problematic at this moment. Problematic how? what are you seeing? maybe this is because of the bug that Steve mentioned in the NVMe mailing list. Sagi mentioned that we should fix it in the NVMe/RDMA initiator and I'll run his suggestion as well. Is y

general protection fault in do_raw_spin_unlock

Hello, syzbot found the following crash on: HEAD commit:1d4eb636f0ab Add linux-next specific files for 20180716 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1186bf0c40 kernel config: https://syzkaller.appspot.com/x/.config?x=ea5926dddb0db97a

  1   2   >