[PATCH net] sctp: fix the issue that pathmtu may be set lower than MINSEGMENT

2018-07-01 Thread Xin Long
After commit b6c5734db070 ("sctp: fix the handling of ICMP Frag Needed for too small MTUs"), sctp_transport_update_pmtu would refetch pathmtu from the dst and set it to transport's pathmtu without any check. The new pathmtu may be lower than MINSEGMENT if the dst is obsolete and updated by .get_ds

[PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding

2018-07-01 Thread Xin Long
As Ido's suggestion, this patch is to add a selftest for directed broadcast forwarding with vrf. Just note that it puts the h2 into the main route space, so that ping_test could get echo_reply. Signed-off-by: Xin Long --- .../selftests/net/forwarding/router_broadcast.sh | 142 +

[PATCHv2 net-next 1/2] route: add support for directed broadcast forwarding

2018-07-01 Thread Xin Long
This patch implements the feature described in rfc1812#section-5.3.5.2 and rfc2644. It allows the router to forward directed broadcast when sysctl bc_forwarding is enabled. Note that this feature could be done by iptables -j TEE, but it would cause some problems: - target TEE's gateway param has

[PATCHv2 net-next 0/2] route: add support and selftests for directed broadcast forwarding

2018-07-01 Thread Xin Long
Patch 1/2 is the feature and 2/2 is the selftest. Check the changelog on each of them to know the details. v1->v2: - fix a typo in changelog. - fix an uapi break that Davide noticed. - flush route cache when bc_forwarding is changed. - add the selftest for this patch as Ido's suggestion.

[PATCH] net: phy: marvell: change default m88e1510 LED configuration

2018-07-01 Thread Wang Dongsheng
The m88e1121 LED default configuration does not apply m88e151x. So add a function to relpace m88e1121 LED configuration. Signed-off-by: Wang Dongsheng --- drivers/net/phy/marvell.c | 54 - include/linux/marvell_phy.h | 2 ++ 2 files changed, 38 insertions(+

[PATCH net-next] net: phy: realtek: add support for RTL8211C

2018-07-01 Thread Heiner Kallweit
RTL8211C has an issue when operating in Gigabit slave mode, therefore genphy driver can't be used. See also this U-boot change. https://lists.denx.de/pipermail/u-boot/2016-March/249712.html Add a PHY driver for this chip with the quirk to force Gigabit master mode. As a note: This will make it imp

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-07-01 Thread Boris Pismenny
On 7/2/2018 4:45 AM, Willem de Bruijn wrote: I've noticed that we could get cleaner code in our driver if we remove these two lines from net/ipv4/udp_offload.c: if (skb_is_gso(segs)) mss *= skb_shinfo(segs)->gso_segs; I think that this is correct in case of GSO_PARTIAL segmenta

Re: [PATCH net-next v3 3/4] net: vhost: factor out busy polling logic to vhost_net_busy_poll()

2018-07-01 Thread Tonghao Zhang
On Mon, Jul 2, 2018 at 10:29 AM Jason Wang wrote: > > > > On 2018年06月30日 14:33, xiangxia.m@gmail.com wrote: > > From: Tonghao Zhang > > > > Factor out generic busy polling logic and will be > > used for tx path in the next patch. And with the patch, > > qemu can set differently the busyloop_t

[PATCH net-next 1/1] net sched actions: add extack messages in pedit action

2018-07-01 Thread Roman Mashak
Signed-off-by: Roman Mashak --- net/sched/act_pedit.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c index ab151346d3d4..55bc96b610e8 100644 --- a/net/sched/act_pedit.c +++ b/net/sched/act_pedit.c @@ -144,8 +144,

Re: [PATCH vhost] vhost_net: Fix too many vring kick on busypoll

2018-07-01 Thread Jason Wang
On 2018年07月02日 10:52, Toshiaki Makita wrote: On 2018/07/02 11:41, Jason Wang wrote: On 2018年06月30日 00:38, Michael S. Tsirkin wrote: On Fri, Jun 29, 2018 at 05:09:50PM +0900, Toshiaki Makita wrote: Under heavy load vhost busypoll may run without suppressing notification. For example tx zeroc

[PATCH net 2/4] qed: Fix setting of incorrect eswitch mode.

2018-07-01 Thread Sudarsana Reddy Kalluru
By default, driver sets the eswitch mode incorrectly as VEB (virtual Ethernet bridging). Need to set VEB eswitch mode only when sriov is enabled, and it should be to set NONE by default. The patch incorporates this change. Fixes: 0fefbfbaa ("qed*: Management firmware - notifications and defaults")

[PATCH net 3/4] qed: Fix use of incorrect size in memcpy call.

2018-07-01 Thread Sudarsana Reddy Kalluru
Use the correct size value while copying chassis/port id values. Fixes: 6ad8c632e ("qed: Add support for query/config dcbx.") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Michal Kalderon --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 8 1 file changed, 4 insertions(+), 4 del

[PATCH net 4/4] qede: Adverstise software timestamp caps when PHC is not available.

2018-07-01 Thread Sudarsana Reddy Kalluru
When ptp clock is not available for a PF (e.g., higher PFs in NPAR mode), get-tsinfo() callback should return the software timestamp capabilities instead of returning the error. Fixes: 4c55215c ("qede: Add driver support for PTP") Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Michal Kalde

[PATCH net 1/4] qed: Limit msix vectors in kdump kernel to the minimum required count.

2018-07-01 Thread Sudarsana Reddy Kalluru
Memory size is limited in the kdump kernel environment. Allocation of more msix-vectors (or queues) consumes few tens of MBs of memory, which might lead to the kdump kernel failure. This patch adds changes to limit the number of MSI-X vectors in kdump kernel to minimum required value (i.e., 2 per e

[PATCH net 0/4] qed*: Fix series.

2018-07-01 Thread Sudarsana Reddy Kalluru
From: Sudarsana Reddy Kalluru The patch series addresses few issues in the qed* drivers. Please consider applying it to 'net' branch. Sudarsana Reddy Kalluru (4): qed: Limit msix vectors in kdump kernel to the minimum required count. qed: Fix setting of incorrect eswitch mode. qed: Fix us

[RFC PATCH] ipv6: make ipv6_renew_options() interrupt/kernel safe

2018-07-01 Thread Paul Moore
From: Paul Moore At present the ipv6_renew_options_kern() function ends up calling into access_ok() which is problematic if done from inside an interrupt as access_ok() calls WARN_ON_IN_IRQ() on some (all?) architectures (x86-64 is affected). Example warning/backtrace is shown below: WARNING:

Re: [PATCH vhost] vhost_net: Fix too many vring kick on busypoll

2018-07-01 Thread Toshiaki Makita
On 2018/06/30 1:38, Michael S. Tsirkin wrote: ... >> Performance numbers: >> >> - Bulk transfer from guest to external physical server. >> [Guest]->vhost_net->tap--(XDP_REDIRECT)-->i40e --(wire)--> [Server] >> - Set 10us busypoll. >> - Guest disables checksum and TSO because of host XDP. >> - M

Re: [PATCH vhost] vhost_net: Fix too many vring kick on busypoll

2018-07-01 Thread Jason Wang
On 2018年07月02日 10:45, Toshiaki Makita wrote: Hi Jason, On 2018/06/29 18:30, Jason Wang wrote: On 2018年06月29日 16:09, Toshiaki Makita wrote: ... To fix this, poll the work instead of enabling notification when busypoll is interrupted by something. IMHO signal_pending() and vhost_has_work() a

Re: [PATCH vhost] vhost_net: Fix too many vring kick on busypoll

2018-07-01 Thread Toshiaki Makita
On 2018/07/02 11:41, Jason Wang wrote: > On 2018年06月30日 00:38, Michael S. Tsirkin wrote: >> On Fri, Jun 29, 2018 at 05:09:50PM +0900, Toshiaki Makita wrote: >>> Under heavy load vhost busypoll may run without suppressing >>> notification. For example tx zerocopy callback can push tx work while >>>

[net-next:master 75/95] drivers/net/ethernet/stmicro/stmmac/.tmp_gl_stmmac_tc.o:undefined reference to `__udivdi3'

2018-07-01 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 97680ade43dc6a8ad2451389d66b0492458196d4 commit: 1f705bc61aee5fab2826bcf6de152a5d92378a85 [75/95] net: stmmac: Add support for CBS QDISC config: microblaze-allyesconfig (attached as .config) compiler: microb

Re: [net-next 01/12] net/mlx5e: Add UDP GSO support

2018-07-01 Thread Willem de Bruijn
>> I've noticed that we could get cleaner code in our driver if we remove >> these two lines from net/ipv4/udp_offload.c: >> if (skb_is_gso(segs)) >> mss *= skb_shinfo(segs)->gso_segs; >> >> I think that this is correct in case of GSO_PARTIAL segmentation for the >> following reasons:

Re: [net-next PATCH v6 0/7] Symmetric queue selection using XPS for Rx queues

2018-07-01 Thread David Miller
From: Amritha Nambiar Date: Fri, 29 Jun 2018 21:26:35 -0700 > This patch series implements support for Tx queue selection based on > Rx queue(s) map. This is done by configuring Rx queue(s) map per Tx-queue > using sysfs attribute. If the user configuration for Rx queues does > not apply, then th

Compiler warnings in kernel 4.14.51

2018-07-01 Thread Enrico Mioso
Hello! While compiling kernel 4.14.51 I got the following warnings: CC net/core/dev.o net/core/dev.c: In function 'validate_xmit_skb_list': net/core/dev.c:3121:15: warning: 'tail' may be used uninitialized in this function [-Wmaybe-uninitialized] ... CC net/ipv4/fib_trie.o net/ipv4/fib

[PATCH v5 net-next] net:sched: add action inheritdsfield to skbedit

2018-07-01 Thread Qiaobin Fu
The new action inheritdsfield copies the field DS of IPv4 and IPv6 packets into skb->priority. This enables later classification of packets based on the DS field. v5: *Update the drop counter for TC_ACT_SHOT v4: *Not allow setting flags other than the expected ones. *Allow dumping the pure flags

Re: [PATCH bpf] bpf: hash_map: decrement counter on error

2018-07-01 Thread Mauricio Vasquez
On 06/30/2018 06:20 PM, Daniel Borkmann wrote: On 06/29/2018 02:48 PM, Mauricio Vasquez B wrote: Decrement the number of elements in the map in case the allocation of a new node fails. Signed-off-by: Mauricio Vasquez B Thanks for the fix, Mauricio! Could you reply with a Fixes: tag in orde

[PATCH net-next] net: phy: realtek: add missing entry for RTL8211 to mdio_device_id table

2018-07-01 Thread Heiner Kallweit
When adding support for RTL8211 I forgot to update the mdio_device_id table. Signed-off-by: Heiner Kallweit Fixes: d241d4aac93f ("net: phy: realtek: add support for RTL8211") --- drivers/net/phy/realtek.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/phy/realtek.c b/drivers/net

Re: 862591bf4("xfrm: skip policies marked as dead while rehashing")

2018-07-01 Thread Greg KH
On Wed, Jun 20, 2018 at 05:42:51PM -0400, Zubin Mithra wrote: > Hello, > > Syzkaller has reported a crash here[1] for a slab OOB read in > xfrm_hash_rebuild. > > Could the following 2 patches be applied in order to on 4.4.y? > > 6916fb3b10("xfrm: Ignore socket policies when rebuilding hash table

Re: [PATCH net-next] r8169: remove old PHY reset hack

2018-07-01 Thread Heiner Kallweit
On 01.07.2018 00:25, Heiner Kallweit wrote: > This hack (affecting the non-PCIe models only) was introduced in 2004 > to deal with link negotiation failures in 1GBit mode. Based on a > comment in the r8169 vendor driver I assume the issue affects RTL8169sb > in combination with particular 1GBit swi

Re: [PATCH linux-firmware] Mellanox: Add new mlxsw_spectrum firmware 13.1701.2

2018-07-01 Thread Ido Schimmel
On Tue, Jun 19, 2018 at 09:33:06AM +0300, Nir Dotan wrote: > This new firmware contains: > - Support for new types of cables > - Support for flashing future firmware without reboot > - Support for Router ARP BC and UC traps Please disregard the patch. We found a problem with this

Re: [PATCH net] tcp: prevent bogus FRTO undos with non-SACK flows

2018-07-01 Thread David Miller
From: Ilpo Järvinen Date: Fri, 29 Jun 2018 13:07:53 +0300 (EEST) > If SACK is not enabled and the first cumulative ACK after the RTO > retransmission covers more than the retransmitted skb, a spurious > FRTO undo will trigger (assuming FRTO is enabled for that RTO). > The reason is that any non-r

[PATCHv2 net] ipvlan: call dev_change_flags when ipvlan mode is reset

2018-07-01 Thread Hangbin Liu
After we change the ipvlan mode from l3 to l2, or vice versa, we only reset IFF_NOARP flag, but don't flush the ARP table cache, which will cause eth->h_dest to be equal to eth->h_source in ipvlan_xmit_mode_l2(). Then the message will not come out of host. Here is the reproducer on local host: ip

Re: [PATCH net-next 5/5] net: gemini: Indicate that we can handle jumboframes

2018-07-01 Thread Andrew Lunn
On Sat, Jun 30, 2018 at 06:18:06PM +0200, Linus Walleij wrote: > The hardware supposedly handles frames up to 10236 bytes and > implements .ndo_change_mtu() so accept 10236 minus the ethernet > header for a VLAN tagged frame on the netdevices. > > Signed-off-by: Linus Walleij > --- > drivers/net

Re: [PATCH net-next 2/5] net: gemini: Improve connection prints

2018-07-01 Thread Andrew Lunn
On Sat, Jun 30, 2018 at 06:18:03PM +0200, Linus Walleij wrote: > Instead of just specify that a PHY is connected at some > speed, also specify which one. This is helpful with several > PHYs on the system. Hi Linus Could you just use phy_print_status() Andrew