Re: [PATCH net] ipvlan: fix IFLA_MTU ignored on NEWLINK

From: Xin Long Date: Thu, 21 Jun 2018 12:56:04 +0800 > Commit 296d48568042 ("ipvlan: inherit MTU from master device") adjusted > the mtu from the master device when creating a ipvlan device, but it > would also override the mtu value set in rtnl_create_link. It causes > IFLA_MTU param not to take

Re: [PATCH bpf 2/2] tools: bpftool: remember to close the libbpf object after prog load

On Wed, Jun 20, 2018 at 11:42 AM, Jakub Kicinski wrote: > Remembering to close all descriptors and free memory may not seem > important in a user space tool like bpftool, but if we were to run > in batch mode the consumed resources start to add up quickly. Make > sure program load closes the libb

Re: [PATCH bpf 1/2] tools: bpftool: remove duplicated error message on prog load

On Wed, Jun 20, 2018 at 11:42 AM, Jakub Kicinski wrote: > do_pin_fd() will already print out an error message if something > goes wrong. Printing another error is unnecessary and will break > JSON output, since error messages are full objects: > > $ bpftool -jp prog load tracex1_kern.o /sys/fs/bp

Re: Route fallback issue

On 06/20/2018 01:00 PM, Julian Anastasov wrote: You can also try alternative routes. "Alternative routes"? I can't say as I've heard that description as a specific technique / feature / capability before. Is that it's official name? Where can I find out more about it? But as the kernel su

[PATCH net] ipvlan: fix IFLA_MTU ignored on NEWLINK

Commit 296d48568042 ("ipvlan: inherit MTU from master device") adjusted the mtu from the master device when creating a ipvlan device, but it would also override the mtu value set in rtnl_create_link. It causes IFLA_MTU param not to take effect. So this patch is to not adjust the mtu if IFLA_MTU pa

Re: [PATCH net] bpf: enforce correct alignment for instructions

On 06/20/2018 08:46 PM, David Miller wrote: > From: Eric Dumazet > Date: Wed, 20 Jun 2018 17:24:09 -0700 > >> After commit 9facc336876f ("bpf: reject any prog that failed read-only lock") >> offsetof(struct bpf_binary_header, image) became 3 instead of 4, >> breaking powerpc BPF badly, since i

Re: [PATCH net] sctp: fix erroneous inc of snmp SctpFragUsrMsgs

From: Marcelo Ricardo Leitner Date: Wed, 20 Jun 2018 12:47:52 -0300 > Currently it is incrementing SctpFragUsrMsgs when the user message size > is of the exactly same size as the maximum fragment size, which is wrong. > > The fix is to increment it only when user message is bigger than the > max

Re: [PATCH net] bpf: enforce correct alignment for instructions

From: Eric Dumazet Date: Wed, 20 Jun 2018 17:24:09 -0700 > After commit 9facc336876f ("bpf: reject any prog that failed read-only lock") > offsetof(struct bpf_binary_header, image) became 3 instead of 4, > breaking powerpc BPF badly, since instructions need to be word aligned. > > Fixes: 9facc33

[net:master 6/6] drivers/net/ethernet/mscc/ocelot.c:377:17: sparse: incorrect type in argument 2 (different base types)

tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master head: 08d02364b12faa54d76dbfea2090321fd27996f2 commit: 08d02364b12faa54d76dbfea2090321fd27996f2 [6/6] net: mscc: fix the injection header reproduce: # apt-get install sparse git checkout 08d02364b12faa54

[PATCH v2 bpf-net] bpf: Change bpf_fib_lookup to return lookup status

From: David Ahern For ACLs implemented using either FIB rules or FIB entries, the BPF program needs the FIB lookup status to be able to drop the packet. Since the bpf_fib_lookup API has not reached a released kernel yet, change the return code to contain an encoding of the FIB lookup result and r

Re: [PATCH net] ipvlan: call dev_change_flags when reset ipvlan mode

On Wed, Jun 20, 2018 at 10:45:39AM -0700, Cong Wang wrote: > On Tue, Jun 19, 2018 at 10:31 PM, David Miller wrote: > > From: Hangbin Liu > > Date: Wed, 20 Jun 2018 11:22:54 +0800 > > > >> The only case dev_change_flags() return an err is when we change IFF_UP > >> flag. > >> Since we only set/re

Re: [PATCH] r8169: Fix netpoll oops

From: Ville Syrjala Date: Wed, 20 Jun 2018 15:01:53 +0300 > From: Ville Syrjälä > > Pass the correct thing to rtl8169_interrupt() from netpoll. > > Cc: Realtek linux nic maintainers > Cc: netdev@vger.kernel.org > Cc: Heiner Kallweit > Cc: David S. Miller > Fixes: ebcd5daa7ffd ("r8169: chang

Re: [PATCH net-next 0/2] fixes for ipsec selftests

On 6/20/2018 4:18 PM, Anders Roxell wrote: On Thu, 21 Jun 2018 at 00:26, Shannon Nelson wrote: On 6/20/2018 12:09 PM, Anders Roxell wrote: On Wed, 20 Jun 2018 at 07:42, Shannon Nelson wrote: A couple of bad behaviors in the ipsec selftest were pointed out by Anders Roxell and are addresse

Re: [net RFC] net/mlx4_en: Use frag stride in crossing page boundary condition

On 06/20/2018 04:41 PM, Saeed Mahameed wrote: > > I see, I wanted to use _stride_ as grantee for how much a page frag can > grow, for example in mlx5 we need the whole stride to build_skb around > the frag, since we always need the trailer, but it is different in here > and we can avoid resour

Re: [PATCH] bpfilter: fix user mode helper cross compilation

From: Matteo Croce Date: Wed, 20 Jun 2018 16:04:34 +0200 > Use $(OBJDUMP) instead of literal 'objdump' to avoid > using host toolchain when cross compiling. > > Fixes: 421780fd4983 ("bpfilter: fix build error") > Signed-off-by: Matteo Croce Applied.

[PATCH net] bpf: enforce correct alignment for instructions

After commit 9facc336876f ("bpf: reject any prog that failed read-only lock") offsetof(struct bpf_binary_header, image) became 3 instead of 4, breaking powerpc BPF badly, since instructions need to be word aligned. Fixes: 9facc336876f ("bpf: reject any prog that failed read-only lock") Signed-off-

Re: net-next compilation failures

From: "Chopra, Manish" Date: Wed, 20 Jun 2018 21:00:40 + > I am trying to compile net-next kernel and I face these below > compilation errros for some reason. Attached the kernel .config > used. Any idea for what reason these failures could be stemming ? The net-next tree isn't open and the

Re: [net RFC] net/mlx4_en: Use frag stride in crossing page boundary condition

On Tue, 2018-06-19 at 17:25 -0700, Eric Dumazet wrote: > > On 06/19/2018 11:05 AM, Saeed Mahameed wrote: > > > this is only true for XDP setup, for non XDP max stride_size can > > only > > be around ~3k and only for mtu > ~6k > > > > For XDP setup you suggested: > > - priv->frag_in

Re: [PATCH net-next 0/2] fixes for ipsec selftests

f the rtnetlink.sh script. + ip x s add proto esp src 10.66.17.140 dst 10.66.17.141 spi 0x07 mode transport reqid 0x07 replay-window 32 aead 'rfc4106(gcm(aes))' 0x3132333435 363738393031323334353664636261 128 sel src 10.66.17.140/24 dst 10.66.17.141/24 RTNETLINK answers: Protocol not support

Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388 hfsc_dequeue+0x319/0x350 [sch_hfsc]

On Wed, Jun 20, 2018 at 12:00 AM, Marco Berizzi wrote: >> Il 19 giugno 2018 alle 13.42 Marco Berizzi ha scritto: >> >> > Il 18 giugno 2018 alle 21.28 Cong Wang ha >> > scritto: >> > Can you test the attached patch? >> > >> > It almost certainly fixes the warning, but I am not sure if >> > it pa

Re: [PATCH net 1/1] net/smc: coordinate wait queues for nonblocking connect

On Wed, Jun 20, 2018 at 1:07 AM, Ursula Braun wrote: > diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c > index da7f02edcd37..21c84b924ffb 100644 > --- a/net/smc/af_smc.c > +++ b/net/smc/af_smc.c > @@ -605,6 +605,8 @@ static int smc_connect(struct socket *sock, struct > sockaddr *addr, > >

Re: [PATCH net-next 0/2] fixes for ipsec selftests

On 6/20/2018 12:09 PM, Anders Roxell wrote: On Wed, 20 Jun 2018 at 07:42, Shannon Nelson wrote: A couple of bad behaviors in the ipsec selftest were pointed out by Anders Roxell and are addressed here. Shannon Nelson (2): selftests: rtnetlink: hide complaint from terminated monitor sel

Re: [bpf PATCH v2 2/6] bpf: sockmap only allow ESTABLISHED sock state

On 06/18/2018 02:17 PM, Martin KaFai Lau wrote: > On Mon, Jun 18, 2018 at 07:50:19AM -0700, John Fastabend wrote: >> On 06/14/2018 05:18 PM, Martin KaFai Lau wrote: >>> On Thu, Jun 14, 2018 at 09:44:52AM -0700, John Fastabend wrote: Per the note in the TLS ULP (which is actually a generic stat

862591bf4("xfrm: skip policies marked as dead while rehashing")

Hello, Syzkaller has reported a crash here[1] for a slab OOB read in xfrm_hash_rebuild. Could the following 2 patches be applied in order to on 4.4.y? 6916fb3b10("xfrm: Ignore socket policies when rebuilding hash tables") 862591bf4f("xfrm: skip policies marked as dead while rehashing") [1] htt

Re: [PATCH RFC v2 ipsec-next 0/3] Virtual xfrm interfaces

This set of patches entire resolves issues Android was having with VTIs, specifically that we need multiple IPsec tunnels with the same source/destination endpoints. These tests pass the following regression tests (https://android-review.googlesource.com/c/kernel/tests/+/588259/24): - Outbound enc

[PATCH net-next] tcp_bbr: fix bbr pacing rate for internal pacing

From: Eric Dumazet This commit makes BBR use only the MSS (without any headers) to calculate pacing rates when internal TCP-layer pacing is used. This is necessary to achieve the correct pacing behavior in this case, since tcp_internal_pacing() uses only the payload length to calculate pacing de

Re: [PATCH net-next 0/2] fixes for ipsec selftests

On Wed, 20 Jun 2018 at 07:42, Shannon Nelson wrote: > > A couple of bad behaviors in the ipsec selftest were pointed out > by Anders Roxell and are addressed here. > > Shannon Nelson (2): > selftests: rtnetlink: hide complaint from terminated monitor > selftests: rtnetlink: use a local IP add

Re: Route fallback issue

Hello, On Wed, 20 Jun 2018, Akshat Kakkar wrote: > Hi netdev community, > > I have 2 interfaces > eno1 : 192.168.1.10/24 > eno2 : 192.168.2.10/24 > > I added routes as > 172.16.0.0/12 via 192.168.1.254 metric 1 > 172.16.0.0/12 via 192.168.2.254 metric 2 > > My intention : All traffic

Re: [PATCH] r8169: Fix netpoll oops

On 20.06.2018 14:01, Ville Syrjala wrote: > From: Ville Syrjälä > > Pass the correct thing to rtl8169_interrupt() from netpoll. > Indeed, this place I missed to change. Only small remark: The patch should be annotated as "net" so that it can go to 4.18. > Cc: Realtek linux nic maintainers > C

[PATCH bpf 2/2] tools: bpftool: remember to close the libbpf object after prog load

Remembering to close all descriptors and free memory may not seem important in a user space tool like bpftool, but if we were to run in batch mode the consumed resources start to add up quickly. Make sure program load closes the libbpf object (which unloads and frees it). Fixes: 49a086c201a9 ("bp

[PATCH bpf 1/2] tools: bpftool: remove duplicated error message on prog load

do_pin_fd() will already print out an error message if something goes wrong. Printing another error is unnecessary and will break JSON output, since error messages are full objects: $ bpftool -jp prog load tracex1_kern.o /sys/fs/bpf/a { "error": "can't pin the object (/sys/fs/bpf/a): File exi

[PATCH bpf 0/2] tools: bpftool: small fixes for error handling in prog load

Hi! Two small fixes for error handling in bpftool prog load, first patch removes a duplicated message, second one frees resources correctly. Multiple error messages break JSON: # bpftool -jp prog load tracex1_kern.o /sys/fs/bpf/a { "error": "can't pin the object (/sys/fs/bpf/a): File exists"

Re: [PATCH v4 net-next] net:sched: add action inheritdsfield to skbedit

On Wed, Jun 20, 2018 at 07:02:41PM +0200, Davide Caratti wrote: ... > > I agree that we should update the drop counter, but given that > > you're already converting the stats to be per-cpu counters, whatever we > > add now will be just symbolic since you're going to change it anyway. It woul

Re: [PATCH net] cls_flower: fix use after free in flower S/W path

On Wed, Jun 20, 2018 at 10:34 AM, Paolo Abeni wrote: > > +static void fl_mask_free(struct fl_flow_mask *mask) > +{ > + rhashtable_destroy(&mask->ht); I don't believe you can call rhashtable_destroy() in BH context, it acquires a mutex...

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

Hi Florian, On Wed, Jun 20, 2018 at 10:58:26AM -0700, Florian Fainelli wrote: > On 06/20/2018 10:51 AM, Ilias Apalodimas wrote: > > Hello Ivan, > > On Wed, Jun 20, 2018 at 02:56:48PM +0200, Ivan Vecera wrote: > >> On 18.6.2018 22:19, Ilias Apalodimas wrote: > >>> Jiri proposed using devlink, which

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

On 06/20/2018 10:51 AM, Ilias Apalodimas wrote: > Hello Ivan, > On Wed, Jun 20, 2018 at 02:56:48PM +0200, Ivan Vecera wrote: >> On 18.6.2018 22:19, Ilias Apalodimas wrote: >>> Jiri proposed using devlink, which makes sense, but i am not sure it's >>> applicable on this patchset. This will change th

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

> > Another good reason for a new driver. > > > > I. > This is actually conflicting at least to my understanding. Jiri proposed > using > devlink was used as an alternative method to enable a new mode instead of > adding it on a .config option. A new driver wouldn't have a need for that > righ

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

Hello Ivan, On Wed, Jun 20, 2018 at 02:56:48PM +0200, Ivan Vecera wrote: > On 18.6.2018 22:19, Ilias Apalodimas wrote: > > Jiri proposed using devlink, which makes sense, but i am not sure it's > > applicable on this patchset. This will change the driver completely and will > > totally break backwa

Re: [PATCH net] ipvlan: call dev_change_flags when reset ipvlan mode

On Tue, Jun 19, 2018 at 10:31 PM, David Miller wrote: > From: Hangbin Liu > Date: Wed, 20 Jun 2018 11:22:54 +0800 > >> The only case dev_change_flags() return an err is when we change IFF_UP flag. >> Since we only set/reset IFF_NOARP, do you think we still need to check the >> return value? > > I

[PATCH net] cls_flower: fix use after free in flower S/W path

If flower filter is created without the skip_sw flag, fl_mask_put() can race with fl_classify() and we can destroy the mask rhashtable while a lookup operation is accessing it. BUG: unable to handle kernel paging request at 000911d1 PGD 0 P4D 0 SMP PTI CPU: 3 PID: 5582 Comm: vhost-5541

Re: [PATCH iproute2-next 1/1] tc: jsonify nat action

On 6/18/18 12:57 PM, Keara Leibovitz wrote: > Add json output support for nat action > ... > > Signed-off-by: Keara Leibovitz > --- > tc/m_nat.c | 32 +++- > 1 file changed, 19 insertions(+), 13 deletions(-) > applied to iproute2-next. Thanks

Re: [PATCH iproute2-next v3] ip-xfrm: Add support for OUTPUT_MARK

On 6/15/18 8:32 PM, Subash Abhinov Kasiviswanathan wrote: > This patch adds support for OUTPUT_MARK in xfrm state to exercise the > functionality added by kernel commit 077fbac405bf > ("net: xfrm: support setting an output mark."). > ... > v1->v2: Moved the XFRMA_OUTPUT_MARK print after XFRMA_MA

Re: [PATCH] net: Fix device name resolving crash in default_device_exit()

On 6/20/18 2:57 AM, Kirill Tkhai wrote: > From: Kirill Tkhai > > The following script makes kernel to crash since it can't obtain > a name for a device, when the name is occupied by another device: > > #!/bin/bash > ifconfig eth0 down > ifconfig eth1 down > index=`cat /sys/class/net/eth1/ifindex

Re: [PATCH net] sctp: fix erroneous inc of snmp SctpFragUsrMsgs

On Wed, Jun 20, 2018 at 12:47:52PM -0300, Marcelo Ricardo Leitner wrote: > Currently it is incrementing SctpFragUsrMsgs when the user message size > is of the exactly same size as the maximum fragment size, which is wrong. > > The fix is to increment it only when user message is bigger than the >

Re: [PATCH v4 net-next] net:sched: add action inheritdsfield to skbedit

On Wed, 2018-06-20 at 12:47 -0400, Michel Machado wrote: > On 06/20/2018 12:08 PM, Davide Caratti wrote: > > On Tue, 2018-06-12 at 15:42 +, Fu, Qiaobin wrote: > > > The new action inheritdsfield copies the field DS of > > > IPv4 and IPv6 packets into skb->priority. This enables > > > later clas

Re: [PATCH v4 net-next] net:sched: add action inheritdsfield to skbedit

On 06/20/2018 12:08 PM, Davide Caratti wrote: On Tue, 2018-06-12 at 15:42 +, Fu, Qiaobin wrote: The new action inheritdsfield copies the field DS of IPv4 and IPv6 packets into skb->priority. This enables later classification of packets based on the DS field. v4: *Not allow setting flags oth

Re: [PATCH] tc, bpf: add option to dump bpf verifier as C program fragment

On Wed, 20 Jun 2018 00:13:52 +0200 Daniel Borkmann wrote: > On 06/18/2018 11:44 PM, David Ahern wrote: > > On 6/18/18 2:18 PM, Jakub Kicinski wrote: > >> On Sun, 17 Jun 2018 08:48:41 +, Ophir Munk wrote: > >>> Similar to cbpf used within tcpdump utility with a "-d" option to dump > >>> th

Re: [PATCH] tc: fix batch force option

On Wed, 20 Jun 2018 10:24:21 +0300 Vlad Buslov wrote: > When sending accumulated compound command results an error, check 'force' > option before exiting. Move return code check after putting batch bufs and > freeing iovs to prevent memory leak. Break from loop, instead of returning > error code

[PATCH v2] ucc_geth: Add BQL support

Signed-off-by: Joakim Tjernlund --- v2 - Reoder varibles according to Dave Add call to netdev_reset_queue(dev) open/close drivers/net/ethernet/freescale/ucc_geth.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/ucc_geth.c b/driv

Re: [PATCH v4 net-next] net:sched: add action inheritdsfield to skbedit

On Tue, 2018-06-12 at 15:42 +, Fu, Qiaobin wrote: > The new action inheritdsfield copies the field DS of > IPv4 and IPv6 packets into skb->priority. This enables > later classification of packets based on the DS field. > > v4: > *Not allow setting flags other than the expected ones. > > *Allo

[PATCH net] sctp: fix erroneous inc of snmp SctpFragUsrMsgs

Currently it is incrementing SctpFragUsrMsgs when the user message size is of the exactly same size as the maximum fragment size, which is wrong. The fix is to increment it only when user message is bigger than the maximum fragment size. Fixes: bfd2e4b8734d ("sctp: refactor sctp_datamsg_from_user

Re: Route fallback issue

On 06/20/2018 09:18 AM, Grant Taylor wrote: Where can I find more information on ignore_routes_with_linkdown?  I don't see it listed in $Kernel/Documentation/networking/ip-sysctl.txt. (I do see fib_multipath_use_neigh documented there in.) I'm specifically interested in if ignore_routes_with_l

Re: Incomplete fix for be9c798 / 7b2ee50 hv_netvsc: common detach logic?

On Tue, Jun 19, 2018 at 04:14:40PM -0700, Stephen Hemminger wrote: > On Wed, 20 Jun 2018 08:01:50 +0900 > Greg KH wrote: > > > On Tue, Jun 19, 2018 at 03:19:41PM -0400, Thomas Walker wrote: > > > Upon updating some internal kernels from 4.14.18 to 4.14.49, our hyper-v > > > guests failed to brin

Re: Route fallback issue

On 06/20/2018 07:48 AM, David Ahern wrote: See the ignore_routes_with_linkdown and fib_multipath_use_neigh sysctl settings. Where can I find more information on ignore_routes_with_linkdown? I don't see it listed in $Kernel/Documentation/networking/ip-sysctl.txt. (I do see fib_multipath_use_n

Re: [PATCH v4 net-next] net:sched: add action inheritdsfield to skbedit

On Tue, Jun 12, 2018 at 03:42:55PM +, Fu, Qiaobin wrote: > The new action inheritdsfield copies the field DS of > IPv4 and IPv6 packets into skb->priority. This enables > later classification of packets based on the DS field. > > v4: > *Not allow setting flags other than the expected ones. >

Re: [PATCH] bpfilter: fix user mode helper cross compilation

On Wed, 20 Jun 2018 16:04:34 +0200 Matteo Croce wrote: > Use $(OBJDUMP) instead of literal 'objdump' to avoid > using host toolchain when cross compiling. > > Fixes: 421780fd4983 ("bpfilter: fix build error") > Signed-off-by: Matteo Croce Reported-by: Stefano Brivio -- Stefano

Re: [PATCH] bpfilter: fix build error

On Wed, Jun 20, 2018 at 12:39 PM Stefano Brivio wrote: > > On Tue, 19 Jun 2018 17:16:20 +0200 > Matteo Croce wrote: > > > bpfilter Makefile assumes that the system locale is en_US, and the > > parsing of objdump output fails. > > Set LC_ALL=C and, while at it, rewrite the objdump parsing so it sp

[PATCH] bpfilter: fix user mode helper cross compilation

Use $(OBJDUMP) instead of literal 'objdump' to avoid using host toolchain when cross compiling. Fixes: 421780fd4983 ("bpfilter: fix build error") Signed-off-by: Matteo Croce --- net/bpfilter/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bpfilter/Makefile b/net/

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

On 20.6.2018 14:59, Ilias Apalodimas wrote: > On Wed, Jun 20, 2018 at 02:53:47PM +0200, Ivan Vecera wrote: >> On 20.6.2018 09:08, Jiri Pirko wrote: >>> Tue, Jun 19, 2018 at 01:19:00AM CEST, grygorii.stras...@ti.com wrote: On 06/14/2018 06:43 AM, Ilias Apalodimas wrote: > On Thu,

Re: Route fallback issue

On 6/20/18 2:26 AM, Akshat Kakkar wrote: > Hi netdev community, > > I have 2 interfaces > eno1 : 192.168.1.10/24 > eno2 : 192.168.2.10/24 > > I added routes as > 172.16.0.0/12 via 192.168.1.254 metric 1 > 172.16.0.0/12 via 192.168.2.254 metric 2 > > My intention : All traffic to 172.16.0.0/12 sh

Re: [PATCH net 1/5] net sched actions: fix coding style in pedit action

Davide Caratti writes: > On Tue, 2018-06-19 at 12:56 -0400, Roman Mashak wrote: >> Fix coding style issues in tc pedit action detected by the >> checkpatch script. >> >> Signed-off-by: Roman Mashak > ... > >> --- >> @@ -316,16 +318,15 @@ static int tcf_pedit(struct sk_buff *skb, const struct >

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

On Wed, Jun 20, 2018 at 02:53:47PM +0200, Ivan Vecera wrote: > On 20.6.2018 09:08, Jiri Pirko wrote: > > Tue, Jun 19, 2018 at 01:19:00AM CEST, grygorii.stras...@ti.com wrote: > >> > >> > >> On 06/14/2018 06:43 AM, Ilias Apalodimas wrote: > >>> On Thu, Jun 14, 2018 at 01:39:58PM +0200, Jiri Pirko wr

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

On 18.6.2018 22:19, Ilias Apalodimas wrote: > Jiri proposed using devlink, which makes sense, but i am not sure it's > applicable on this patchset. This will change the driver completely and will > totally break backwards compatibility. Another good reason for a new driver. I.

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

On 20.6.2018 09:08, Jiri Pirko wrote: > Tue, Jun 19, 2018 at 01:19:00AM CEST, grygorii.stras...@ti.com wrote: >> >> >> On 06/14/2018 06:43 AM, Ilias Apalodimas wrote: >>> On Thu, Jun 14, 2018 at 01:39:58PM +0200, Jiri Pirko wrote: Thu, Jun 14, 2018 at 01:34:04PM CEST, ilias.apalodi...@linaro.o

Re: [PATCH net] net: sungem: fix rx checksum support

On 06/20/2018 04:22 AM, Mathieu Malaterre wrote: > Thanks for the stable tag. > > IMHO the commit message should have also reference commit 7ce5a27f2ef8 > ("Revert "net: Handle CHECKSUM_COMPLETE more adequately in > pskb_trim_rcsum().""). Which means that commit 88078d98d1bb ("net: > pskb_tri

Re: [PATCH v4 net-next] net:sched: add action inheritdsfield to skbedit

On 06/20/2018 07:53 AM, Jamal Hadi Salim wrote: On 19/06/18 08:39 AM, Michel Machado wrote:  Notice that, different from skbmod, there's no field parm->flags in skbedit. Skbedit infers the flags in d->flags from the presence of the parameters of each of its actions. But SKBEDIT_F_INHERITDSFIEL

Re: [PATCH] bpfilter: fix build error

On Tue, 19 Jun 2018 17:16:20 +0200 Matteo Croce wrote: > bpfilter Makefile assumes that the system locale is en_US, and the > parsing of objdump output fails. > Set LC_ALL=C and, while at it, rewrite the objdump parsing so it spawns > only 2 processes instead of 7. > > Fixes: d2ba09c17a064 ("net

Re: [PATCH net 1/5] net sched actions: fix coding style in pedit action

On Tue, 2018-06-19 at 12:56 -0400, Roman Mashak wrote: > Fix coding style issues in tc pedit action detected by the > checkpatch script. > > Signed-off-by: Roman Mashak ... > --- > @@ -316,16 +318,15 @@ static int tcf_pedit(struct sk_buff *skb, const struct > tc_action *a, >

[PATCH] r8169: Fix netpoll oops

From: Ville Syrjälä Pass the correct thing to rtl8169_interrupt() from netpoll. Cc: Realtek linux nic maintainers Cc: netdev@vger.kernel.org Cc: Heiner Kallweit Cc: David S. Miller Fixes: ebcd5daa7ffd ("r8169: change interrupt handler argument type") Signed-off-by: Ville Syrjälä --- drivers

Re: [PATCH v4 net-next] net:sched: add action inheritdsfield to skbedit

On 19/06/18 08:39 AM, Michel Machado wrote: Notice that, different from skbmod, there's no field parm->flags in skbedit. Skbedit infers the flags in d->flags from the presence of the parameters of each of its actions. But SKBEDIT_F_INHERITDSFIELD has no parameter and adding field parm->flags

Re: [PATCH net] net: sungem: fix rx checksum support

On Wed, Jun 20, 2018 at 7:31 AM David Miller wrote: > > From: Eric Dumazet > Date: Tue, 19 Jun 2018 19:18:50 -0700 > > > After commit 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE > > are friends"), sungem owners reported the infamous "eth0: hw csum failure" > > message. > > > > CHE

Re: Grant

-- I Mikhail Fridman. has selected you specially as one of my beneficiaries for my Charitable Donation, Just as I have declared on May 23, 2016 to give my fortune as charity. Check the link below for confirmation: http://www.ibtimes.co.uk/russias-second-wealthiest-man-mikhail-fridman-plans-l

Re: [PATCH][v2] xfrm: replace NR_CPU with nr_cpu_ids

Steffen Klassert wrote: > On Tue, Jun 19, 2018 at 09:53:49AM +0200, Florian Westphal wrote: > > Li RongQing wrote: > > > The default NR_CPUS can be very large, but actual possible nr_cpu_ids > > > usually is very small. For some x86 distribution, the NR_CPUS is 8192 > > > and nr_cpu_ids is 4, so

[PATCH] tc: fix batch force option

When sending accumulated compound command results an error, check 'force' option before exiting. Move return code check after putting batch bufs and freeing iovs to prevent memory leak. Break from loop, instead of returning error code to allow cleanup at the end of batch function. Don't reset ret c

RE: ICT Service Desk

From: Concepcion Bas Sent: Wednesday, June 20, 2018 2:18 AM To: Concepcion Bas Subject: ICT Service Desk ICT Service Desk vereist dat u bijwerkt / opnieuw valideert naar de meest recente e-mail Outlook Web Apps 2018, vriendelijk Klik op Service Desk

[PATCH] net: Fix device name resolving crash in default_device_exit()

From: Kirill Tkhai The following script makes kernel to crash since it can't obtain a name for a device, when the name is occupied by another device: #!/bin/bash ifconfig eth0 down ifconfig eth1 down index=`cat /sys/class/net/eth1/ifindex` ip link set eth1 name dev$index unshare -n sleep 1h & pi

Re: WARNING: CPU: 3 PID: 0 at net/sched/sch_hfsc.c:1388 hfsc_dequeue+0x319/0x350 [sch_hfsc]

> Il 19 giugno 2018 alle 13.42 Marco Berizzi ha scritto: > > > Il 18 giugno 2018 alle 21.28 Cong Wang ha > > scritto: > > Can you test the attached patch? > > > > It almost certainly fixes the warning, but I am not sure if > > it papers out any other real problem. Please make sure > > hfsc sti

Re: [RFC v2, net-next, PATCH 4/4] net/cpsw_switchdev: add switchdev mode of operation on cpsw driver

Tue, Jun 19, 2018 at 01:19:00AM CEST, grygorii.stras...@ti.com wrote: > > >On 06/14/2018 06:43 AM, Ilias Apalodimas wrote: >> On Thu, Jun 14, 2018 at 01:39:58PM +0200, Jiri Pirko wrote: >>> Thu, Jun 14, 2018 at 01:34:04PM CEST, ilias.apalodi...@linaro.org wrote: On Thu, Jun 14, 2018 at 01:30:2

[PATCH net 1/1] net/smc: coordinate wait queues for nonblocking connect

The recent poll change may lead to stalls for non-blocking connecting SMC sockets, since sock_poll_wait is no longer performed on the internal CLC socket, but on the outer SMC socket. kernel_connect() on the internal CLC socket returns with -EINPROGRESS, but the wake up logic does not work in all

Re: [PATCH net 0/5] net sched actions: code style cleanup and fixes

On Tue, Jun 19, 2018 at 12:56:03PM -0400, Roman Mashak wrote: > The patchset fixes a few code stylistic issues and typos, as well as one > detected by sparse semantic checker tool. > > No functional changes introduced. > > Patch 1 & 2 fix coding style bits caught by the checkpatch.pl script > Pat

Re: Route fallback issue

Hi netdev community, I have 2 interfaces eno1 : 192.168.1.10/24 eno2 : 192.168.2.10/24 I added routes as 172.16.0.0/12 via 192.168.1.254 metric 1 172.16.0.0/12 via 192.168.2.254 metric 2 My intention : All traffic to 172.16.0.0/12 should go thru eno1. If 192.168.1.254 is not reachable (no arp en