[PATCH V2 net-next 4/6] liquidio: Moved common definition octnic_gather to octeon_network.h

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moving common definition octnic_gather to octeon_network.h Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 21 - drivers/net/ethernet/cavium/liquidio/lio_vf_m

[PATCH V2 net-next 6/6] liquidio: enhanced ethtool --set-channels feature

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Enhancing driver to accept max supported queues for ethtool --set-channels Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- .../ethernet/cavium/liquidio/cn23xx_pf_device.c| 6 +- .../ethernet/cavium/liquidio/cn23xx_pf_device.h

[PATCH V2 net-next 2/6] liquidio: Moved common function list_delete_head to octeon_network.h

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moved common function list_delete_head to octeon_network.h and renamed it to lio_list_delete_head Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_main.c| 23 ++-- drivers/

[PATCH V2 net-next 3/6] liquidio: Moved common function delete_glists to lio_core.c

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moved common function delete_glists to lio_core.c and renamed it to lio_delete_glists Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 41 ++ drivers/net/ethernet/c

[PATCH V2 net-next 5/6] liquidio: Moved common function setup_glists to lio_core.c

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moved common function setup_glists to lio_core.c and reamed it to lio_setup_glists Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 83 + drivers/net/ethernet/c

[PATCH V2 net-next 1/6] liquidio: Moved common function if_cfg_callback to lio_core.c

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha Moved common function if_cfg_callback to lio_core.c and renamed it to lio_if_cfg_callback. Signed-off-by: Intiyaz Basha Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_core.c| 32 drivers/net/eth

[PATCH V2 net-next 0/6] liquidio: enhanced ethtool --set-channels feature

2018-04-27 Thread Felix Manlunas
From: Intiyaz Basha For the ethtool --set-channels feature, the liquidio driver currently accepts max combined value as the queue count configured during driver load time, where max combined count is the total count of input and output queues. This limitation is applicable only when SR-IOV is en

[PATCH v6 net-next 1/3] lan78xx: Lan7801 Support for Fixed PHY

2018-04-27 Thread Raghuram Chary J
Adding Fixed PHY support to the lan78xx driver. Signed-off-by: Raghuram Chary J --- v0->v1: * Remove driver version #define * Modify netdev_info to netdev_dbg * Move lan7801 specific to new routine and add switch case * Minor cleanup v1->v2: * Removed fixedphy variable and used phy

[PATCH v6 net-next 3/3] lan78xx: Modify error messages

2018-04-27 Thread Raghuram Chary J
Modify the error messages when phy registration fails. Signed-off-by: Raghuram Chary J --- v5->v6: * Modified error msg --- drivers/net/usb/lan78xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 54f8db887e3

[PATCH v6 net-next 2/3] lan78xx: Remove DRIVER_VERSION for lan78xx driver

2018-04-27 Thread Raghuram Chary J
Remove driver version info from the lan78xx driver. Signed-off-by: Raghuram Chary J --- drivers/net/usb/lan78xx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 81dfd10c3b92..54f8db887e3d 100644 --- a/drivers/net/usb/lan78xx.c +++

[PATCH v6 net-next 0/3] lan78xx updates along with Fixed phy Support

2018-04-27 Thread Raghuram Chary J
These series of patches handle few modifications in driver and adds support for fixed phy. Raghuram Chary J (3): lan78xx: Lan7801 Support for Fixed PHY lan78xx: Remove DRIVER_VERSION for lan78xx driver lan78xx: Modify error messages drivers/net/usb/Kconfig | 1 + drivers/net/usb/lan78x

Re: [PATCH] bpf: fix misaligned access for BPF_PROG_TYPE_PERF_EVENT program type on x86_32 platform

2018-04-27 Thread Wang YanQing
On Sat, Apr 28, 2018 at 01:33:15AM +0200, Daniel Borkmann wrote: > On 04/28/2018 12:48 AM, Alexei Starovoitov wrote: > > On Thu, Apr 26, 2018 at 05:57:49PM +0800, Wang YanQing wrote: > >> All the testcases for BPF_PROG_TYPE_PERF_EVENT program type in > >> test_verifier(kselftest) report below error

Re: WARNING in perf_trace_buf_alloc (2)

2018-04-27 Thread Alexei Starovoitov
On Sat, Apr 21, 2018 at 12:37:01PM -0700, Eric Biggers wrote: > [+bpf maintainers and netdev] > > On Mon, Nov 06, 2017 at 03:56:01AM -0800, syzbot wrote: > > Hello, > > > > syzkaller hit the following crash on > > 5cb0512c02ecd7e6214e912e4c150f4219ac78e0 > > git://git.kernel.org/pub/scm/linux/ker

Re: [PATCH bpf-next v7 05/10] bpf/verifier: improve register value range tracking with ARSH

2018-04-27 Thread Yonghong Song
On 4/27/18 4:48 PM, Alexei Starovoitov wrote: On Wed, Apr 25, 2018 at 12:29:05PM -0700, Yonghong Song wrote: When helpers like bpf_get_stack returns an int value and later on used for arithmetic computation, the LSH and ARSH operations are often required to get proper sign extension into 64-bi

Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

2018-04-27 Thread Greg KH
On Fri, Apr 27, 2018 at 07:43:52PM +0100, Eddie Chapman wrote: > On 27/04/18 19:07, Thomas Deutschmann wrote: > > Hi Greg, > > > > first, we need to cherry-pick another patch first: > > > From 52a589d51f1008f62569bf89e95b26221ee76690 Mon Sep 17 00:00:00 2001 > > > From: Xin Long > > > Date: Mon,

[PATCH net-next] libcxgb,cxgb4: use __skb_put_zero to simplfy code

2018-04-27 Thread YueHaibing
use helper __skb_put_zero to replace the pattern of __skb_put() && memset() Signed-off-by: YueHaibing --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 3 +-- drivers/net/ethernet/chelsio/cxgb4/srq.c | 3 +-- drivers/net/ethernet/chelsio/libcxgb/libcxgb_cm.h | 15 +--

[PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-04-27 Thread Zumeng Chen
Reading hw_stats will get the actual data after a sucessfull tg3_reset_hw, which actually after tg3_timer_start, so tg->hw_stats_flag is introduced to tell tg3_get_stats64 when hw_stats is ready to read, and it will be false after having done memset(tp->hw_stats, 0) in tg3_halt. Plus tg3_get_stats6

Re: Performance regressions in TCP_STREAM tests in Linux 4.15 (and later)

2018-04-27 Thread Steven Rostedt
We'd like this email archived in netdev list, but since netdev is notorious for blocking outlook email as spam, it didn't go through. So I'm replying here to help get it into the archives. Thanks! -- Steve On Fri, 27 Apr 2018 23:05:46 + Michael Wenig wrote: > As part of VMware's performa

Re: [RFC v3 0/5] virtio: support packed ring

2018-04-27 Thread Jason Wang
On 2018年04月27日 17:12, Tiwei Bie wrote: On Fri, Apr 27, 2018 at 02:17:51PM +0800, Jason Wang wrote: On 2018年04月27日 12:18, Michael S. Tsirkin wrote: On Fri, Apr 27, 2018 at 11:56:05AM +0800, Jason Wang wrote: On 2018年04月25日 13:15, Tiwei Bie wrote: Hello everyone, This RFC implements packed r

Re: [PATCH net-next] udp: remove stray export symbol

2018-04-27 Thread David Miller
From: Willem de Bruijn Date: Fri, 27 Apr 2018 11:12:10 -0400 > From: Willem de Bruijn > > UDP GSO needs to export __udp_gso_segment to call it from ipv6. > > I accidentally exported static ipv4 function __udp4_gso_segment. > Remove that EXPORT_SYMBOL_GPL. > > Fixes: ee80d1ebe5ba ("udp: add ud

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Jason Wang
On 2018年04月28日 09:51, Kevin Easton wrote: On Fri, Apr 27, 2018 at 09:07:56PM -0400, Kevin Easton wrote: On Fri, Apr 27, 2018 at 07:05:45PM +0300, Michael S. Tsirkin wrote: On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: The struct vhost_msg within struct vhost_msg_node is copie

[PATCH v2 0/2] net: stmmac: dwmac-meson: 100M phy mode support for AXG SoC

2018-04-27 Thread Yixun Lan
Due to the dwmac glue layer register changed, we need to introduce a new compatible name for the Meson-AXG SoC to support for the RMII 100M ethernet PHY. Change since v1 at [1]: - implement set_phy_mode() for each SoC [1] https://lkml.kernel.org/r/20180426160508.29380-1-yixun@amlogic.com

[PATCH v2 1/2] dt-bindings: net: meson-dwmac: new compatible name for AXG SoC

2018-04-27 Thread Yixun Lan
We need to introduce a new compatible name for the Meson-AXG SoC in order to support the RMII 100M ethernet PHY, since the PRG_ETH0 register of the dwmac glue layer is changed from previous old SoC. Signed-off-by: Yixun Lan --- Documentation/devicetree/bindings/net/meson-dwmac.txt | 1 + 1 file

[PATCH v2 2/2] net: stmmac: dwmac-meson: extend phy mode setting

2018-04-27 Thread Yixun Lan
In the Meson-AXG SoC, the phy mode setting of PRG_ETH0 in the glue layer is extended from bit[0] to bit[2:0]. There is no problem if we configure it to the RGMII 1000M PHY mode, since the register setting is coincidentally compatible with previous one, but for the RMII 100M PHY mode, the config

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Kevin Easton
On Fri, Apr 27, 2018 at 09:07:56PM -0400, Kevin Easton wrote: > On Fri, Apr 27, 2018 at 07:05:45PM +0300, Michael S. Tsirkin wrote: > > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > > > The struct vhost_msg within struct vhost_msg_node is copied to userspace, > > > so it should be

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Martin KaFai Lau
On Fri, Apr 27, 2018 at 02:26:50PM -0700, Martin KaFai Lau wrote: > On Fri, Apr 27, 2018 at 11:31:36PM +0300, Dan Carpenter wrote: > > On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > > > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > > > On Fri, Apr 27, 2018 at 10:55:46AM -0700

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Kevin Easton
On Fri, Apr 27, 2018 at 07:05:45PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > > The struct vhost_msg within struct vhost_msg_node is copied to userspace, > > so it should be allocated with kzalloc() to ensure all structure padding > > is zeroe

Re: Suggestions on iterating eBPF maps

2018-04-27 Thread Alexei Starovoitov
On Fri, Apr 27, 2018 at 06:33:56PM +, Chenbo Feng wrote: > resend with plain text > > On Fri, Apr 27, 2018 at 11:22 AM Chenbo Feng wrote: > > > Hi net-next, > > > When doing the eBPF tools user-space development I noticed that the map > iterating process in user-space have some little flaw

Re: [Cake] [PATCH iproute2-next v7] Add support for cake qdisc

2018-04-27 Thread Stephen Hemminger
On Fri, 27 Apr 2018 21:57:20 +0200 Toke Høiland-Jørgensen wrote: > sch_cake is intended to squeeze the most bandwidth and latency out of even > the slowest ISP links and routers, while presenting an API simple enough > that even an ISP can configure it. > > Example of use on a cable ISP uplink:

Re: [PATCH v4] bpf, x86_32: add eBPF JIT compiler for ia32

2018-04-27 Thread Daniel Borkmann
On 04/26/2018 12:12 PM, Wang YanQing wrote: [...] > +/* encode 'dst_reg' and 'src_reg' registers into x86_32 opcode 'byte' */ > +static u8 add_2reg(u8 byte, u32 dst_reg, u32 src_reg) > +{ > + return byte + dst_reg + (src_reg << 3); > +} > + > +static void jit_fill_hole(void *area, unsigned int

Re: [PATCH v7 net-next 4/4] netvsc: refactor notifier/event handling code to use the failover framework

2018-04-27 Thread Siwei Liu
On Thu, Apr 26, 2018 at 4:42 PM, Michael S. Tsirkin wrote: > On Thu, Apr 26, 2018 at 03:14:46PM -0700, Siwei Liu wrote: >> On Wed, Apr 25, 2018 at 7:28 PM, Michael S. Tsirkin wrote: >> > On Wed, Apr 25, 2018 at 03:57:57PM -0700, Siwei Liu wrote: >> >> On Wed, Apr 25, 2018 at 3:22 PM, Michael S. T

[RFC net-next 0/5] Support for PHY test modes

2018-04-27 Thread Florian Fainelli
Hi all, This patch series adds support for specifying PHY test modes through ethtool and paves the ground for adding support for more complex test modes that might require data to be exchanged between user and kernel space. As an example, patches are included to add support for the IEEE electrica

[RFC net-next 2/5] net: ethtool: Add UAPI for PHY test modes

2018-04-27 Thread Florian Fainelli
Add the necessary UAPI changes to support querying the PHY tests modes implemented and optionally associated test specific data. This will be used as the foundation for supporting: - IEEE standard electrical test modes - cable diagnostics - packet tester Signed-off-by: Florian Fainelli --- incl

[RFC net-next 3/5] net: ethtool: Add plumbing to get/set PHY test modes

2018-04-27 Thread Florian Fainelli
Implement the core ethtool changes to get/set PHY test modes, no driver implements that yet, but the internal API is defined and now allows it. We also provide the required helpers in PHYLIB in order to call the appropriate functions within the drivers. Signed-off-by: Florian Fainelli --- includ

[RFC net-next 4/5] net: phy: Add support for IEEE standard test modes

2018-04-27 Thread Florian Fainelli
Add support for the 100BaseT2 and 1000BaseT standard test modes as defined by the IEEE 802.3-2012-Section two and three. We provide a set of helper functions for PHY drivers to either punt entirely onto genphy_* functions or if they desire, build additional tests on top of the standard ones availab

[RFC net-next 5/5] net: phy: broadcom: Add support for PHY test modes

2018-04-27 Thread Florian Fainelli
Re-use the generic PHY library test modes for 100BaseT2 and 1000BaseT and advertise support for those through the newly added ethtool knobs. Signed-off-by: Florian Fainelli --- drivers/net/phy/bcm-phy-lib.c | 15 +-- drivers/net/phy/bcm7xxx.c | 3 +++ 2 files changed, 12 inserti

[RFC net-next 1/5] net: phy: Pass stringset argument to ethtool operations

2018-04-27 Thread Florian Fainelli
In preparation for returning a different type of strings other than ETH_SS_STATS update the PHY drivers, helpers and consumers of these functions. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 4 ++-- drivers/net/phy/bcm-phy-lib.c| 12 +--- drivers/net/phy/b

[PATCH ethtool 2/2] ethtool: Add support for PHY test modes

2018-04-27 Thread Florian Fainelli
Add two new commands: --get-phy-tests which allows fetching supported test modes by a given network device's PHY interface --set-phy-test which allows entering one of the modes listed before and pass an eventual set of test specific data Signed-off-by: Florian Fainelli --- ethtool.c | 115 +

[PATCH ethtool 1/2] ethtool-copy.h: Sync with net-next

2018-04-27 Thread Florian Fainelli
This brings support for PHY test modes (not accepted yet) Signed-off-by: Florian Fainelli --- ethtool-copy.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/ethtool-copy.h b/ethtool-copy.h index 8cc61e9ab40b..42fb94129da5 100644 --- a/ethtool-copy.h +++ b/ethtool-cop

Re: [PATCH net-next v2 0/6] mlxsw: SPAN: Support routes pointing at bridges

2018-04-27 Thread David Miller
From: Ido Schimmel Date: Fri, 27 Apr 2018 18:11:05 +0300 > Changes from v1 to v2: > > - Change the suite of bridge accessor functions to br_vlan_pvid_rtnl(), > br_vlan_info_rtnl(), br_fdb_find_port_rtnl(). Please address Stephen Hemminger's feedback, otherwise this series looks good to go. T

Re: [net-next v2] ipv6: sr: Add documentation for seg_flowlabel sysctl

2018-04-27 Thread David Miller
From: Ahmed Abdelsalam Date: Fri, 27 Apr 2018 17:51:48 +0200 > This patch adds a documentation for seg_flowlabel sysctl into > Documentation/networking/ip-sysctl.txt > > Signed-off-by: Ahmed Abdelsalam Applied, thank you.

Re: [PATCH net 0/2] sfc: more ARFS fixes

2018-04-27 Thread David Miller
From: Edward Cree Date: Fri, 27 Apr 2018 15:07:19 +0100 > A couple more bits of breakage in my recent ARFS and async filters work. > Patch #1 in particular fixes a bug that leads to memory trampling and > consequent crashes. Series applied, thanks Edward.

Re: [PATCH] drivers: net: replace UINT64_MAX with U64_MAX

2018-04-27 Thread David Miller
From: Jisheng Zhang Date: Fri, 27 Apr 2018 16:18:58 +0800 > U64_MAX is well defined now while the UINT64_MAX is not, so we fall > back to drivers' own definition as below: > > #ifndef UINT64_MAX > #define UINT64_MAX (u64)(~((u64)0)) > #endif > > I believe this is i

Re: [bpf-next PATCH v2 3/3] bpf: selftest additions for SOCKHASH

2018-04-27 Thread Alexei Starovoitov
On Fri, Apr 27, 2018 at 04:24:43PM -0700, John Fastabend wrote: > This runs existing SOCKMAP tests with SOCKHASH map type. To do this > we push programs into include file and build two BPF programs. One > for SOCKHASH and one for SOCKMAP. > > We then run the entire test suite with each type. > >

Re: [bpf-next PATCH v2 2/3] bpf: sockmap, add hash map support

2018-04-27 Thread Alexei Starovoitov
On Fri, Apr 27, 2018 at 04:24:38PM -0700, John Fastabend wrote: > Sockmap is currently backed by an array and enforces keys to be > four bytes. This works well for many use cases and was originally > modeled after devmap which also uses four bytes keys. However, > this has become limiting in larger

Re: [PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF

2018-04-27 Thread Alexei Starovoitov
On Fri, Apr 27, 2018 at 10:59:19AM -0400, David Miller wrote: > From: Mathieu Xhonneux > Date: Tue, 24 Apr 2018 18:44:15 +0100 > > > This patch adds the End.BPF action to the LWT seg6local infrastructure. > > This action works like any other seg6local End action, meaning that an IPv6 > > header w

Re: [PATCH net-next] net: sch: prio: Set bands to default on delete instead of noop

2018-04-27 Thread David Miller
From: Nogah Frankel Date: Thu, 26 Apr 2018 16:32:36 +0300 > When a band is created, it is set to the default qdisc, which is > "invisible" pfifo. > However, if a band is set to a qdisc that is later being deleted, it will > be set to noop qdisc. This can cause a packet loss, while there is no cle

Re: [PATCH v2] net/mlx4_en: fix potential use-after-free with dma_unmap_page

2018-04-27 Thread David Miller
From: Sarah Newman Date: Wed, 25 Apr 2018 21:00:34 -0700 > When swiotlb is in use, calling dma_unmap_page means that > the original page mapped with dma_map_page must still be valid > as swiotlb will copy data from its internal cache back to the > originally requested DMA location. When GRO is en

Re: [PATCH bpf-next v7 05/10] bpf/verifier: improve register value range tracking with ARSH

2018-04-27 Thread Alexei Starovoitov
On Wed, Apr 25, 2018 at 12:29:05PM -0700, Yonghong Song wrote: > When helpers like bpf_get_stack returns an int value > and later on used for arithmetic computation, the LSH and ARSH > operations are often required to get proper sign extension into > 64-bit. For example, without this patch: > 5

Re: [PATCH] net: support compat 64-bit time in {s,g}etsockopt

2018-04-27 Thread David Miller
From: Lance Richardson Date: Wed, 25 Apr 2018 10:21:54 -0400 > For the x32 ABI, struct timeval has two 64-bit fields. However > the kernel currently interprets the user-space values used for > the SO_RCVTIMEO and SO_SNDTIMEO socket options as having a pair > of 32-bit fields. > > When the second

Re: [PATCH] bpf: fix misaligned access for BPF_PROG_TYPE_PERF_EVENT program type on x86_32 platform

2018-04-27 Thread Daniel Borkmann
On 04/28/2018 12:48 AM, Alexei Starovoitov wrote: > On Thu, Apr 26, 2018 at 05:57:49PM +0800, Wang YanQing wrote: >> All the testcases for BPF_PROG_TYPE_PERF_EVENT program type in >> test_verifier(kselftest) report below errors on x86_32: >> " >> 172/p unpriv: spill/fill of different pointers ldx F

[bpf-next PATCH v2 2/3] bpf: sockmap, add hash map support

2018-04-27 Thread John Fastabend
Sockmap is currently backed by an array and enforces keys to be four bytes. This works well for many use cases and was originally modeled after devmap which also uses four bytes keys. However, this has become limiting in larger use cases where a hash would be more appropriate. For example users may

[bpf-next PATCH v2 1/3] bpf: sockmap, refactor sockmap routines to work with hashmap

2018-04-27 Thread John Fastabend
This patch only refactors the existing sockmap code. This will allow much of the psock initialization code path and bpf helper codes to work for both sockmap bpf map types that are backed by an array, the currently supported type, and the new hash backed bpf map type sockhash. Most the fallout com

Re: [PATCH bpf-next v7 04/10] bpf: remove never-hit branches in verifier adjust_scalar_min_max_vals

2018-04-27 Thread Alexei Starovoitov
On Wed, Apr 25, 2018 at 12:29:04PM -0700, Yonghong Song wrote: > In verifier function adjust_scalar_min_max_vals, > when src_known is false and the opcode is BPF_LSH/BPF_RSH, > early return will happen in the function. So remove > the branch in handling BPF_LSH/BPF_RSH when src_known is false. > >

[bpf-next PATCH v2 3/3] bpf: selftest additions for SOCKHASH

2018-04-27 Thread John Fastabend
This runs existing SOCKMAP tests with SOCKHASH map type. To do this we push programs into include file and build two BPF programs. One for SOCKHASH and one for SOCKMAP. We then run the entire test suite with each type. Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/Makefile

[bpf-next PATCH v2 0/3] Hash support for sock

2018-04-27 Thread John Fastabend
In the original sockmap implementation we got away with using an array similar to devmap. However, unlike devmap where an ifindex has a nice 1:1 function into the map we have found some use cases with sockets that need to be referenced using longer keys. This series adds support for a sockhash map

Re: [PATCH bpf-next v7 03/10] bpf/verifier: refine retval R0 state for bpf_get_stack helper

2018-04-27 Thread Alexei Starovoitov
On Wed, Apr 25, 2018 at 12:29:03PM -0700, Yonghong Song wrote: > The special property of return values for helpers bpf_get_stack > and bpf_probe_read_str are captured in verifier. > Both helpers return a negative error code or > a length, which is equal to or smaller than the buffer > size argument

[bpf-next PATCH 0/3] Hash support for sock

2018-04-27 Thread John Fastabend
In the original sockmap implementation we got away with using an array similar to devmap. However, unlike devmap where an ifindex has a nice 1:1 function into the map we have found some use cases with sockets need to be referenced using longer keys. This series adds support for a sockhash map type

Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options

2018-04-27 Thread Mikulas Patocka
On Fri, 27 Apr 2018, Michael S. Tsirkin wrote: > 2. Ability to control this from a separate config >option. > >It's still not that clear to me why is this such a >hard requirement. If a distro wants to force specific >boot time options, why isn't CONFIG_CMDLINE sufficient? So,

Re: [bpf-next PATCH 0/3] Hash support for sock

2018-04-27 Thread John Fastabend
On 04/27/2018 03:54 PM, Alexei Starovoitov wrote: > On Fri, Apr 27, 2018 at 10:51 PM, John Fastabend > wrote: >> In the original sockmap implementation we got away with using an >> array similar to devmap. However, unlike devmap where an ifindex >> has a nice 1:1 function into the map we have foun

Re: [bpf-next PATCH 0/3] Hash support for sock

2018-04-27 Thread Alexei Starovoitov
On Fri, Apr 27, 2018 at 10:51 PM, John Fastabend wrote: > In the original sockmap implementation we got away with using an > array similar to devmap. However, unlike devmap where an ifindex > has a nice 1:1 function into the map we have found some use cases > with sockets need to be referenced usi

[bpf-next PATCH 0/3] Hash support for sock

2018-04-27 Thread John Fastabend
In the original sockmap implementation we got away with using an array similar to devmap. However, unlike devmap where an ifindex has a nice 1:1 function into the map we have found some use cases with sockets need to be referenced using longer keys. This series adds support for a sockhash map type

[bpf-next PATCH 3/3] bpf: selftest additions for SOCKHASH

2018-04-27 Thread John Fastabend
This runs existing SOCKMAP tests with SOCKHASH map type. To do this we push programs into include file and build two BPF programs. One for SOCKHASH and one for SOCKMAP. We then run the entire test suite with each type. Signed-off-by: John Fastabend --- tools/testing/selftests/bpf/Makefile

[bpf-next PATCH 2/3] bpf: sockmap, add hash map support

2018-04-27 Thread John Fastabend
Sockmap is currently backed by an array and enforces keys to be four bytes. This works well for many use cases and was originally modeled after devmap which also uses four bytes keys. However, this has become limiting in larger use cases where a hash would be more appropriate. For example users may

[bpf-next PATCH 1/3] bpf: sockmap, refactor sockmap routines to work with hashmap

2018-04-27 Thread John Fastabend
This patch only refactors the existing sockmap code. This will allow much of the psock initialization code path and bpf helper codes to work for both sockmap bpf map types that are backed by an array, the currently supported type, and the new hash backed bpf map type sockhash. Most the fallout com

Re: [PATCH] bpf: fix misaligned access for BPF_PROG_TYPE_PERF_EVENT program type on x86_32 platform

2018-04-27 Thread Alexei Starovoitov
On Thu, Apr 26, 2018 at 05:57:49PM +0800, Wang YanQing wrote: > All the testcases for BPF_PROG_TYPE_PERF_EVENT program type in > test_verifier(kselftest) report below errors on x86_32: > " > 172/p unpriv: spill/fill of different pointers ldx FAIL > Unexpected error message! > 0: (bf) r6 = r10 > 1:

arch/x86/net/bpf_jit_comp conflicts. was: [tip:x86/cleanups] x86/bpf: Clean up non-standard comments, to make the code more readable

2018-04-27 Thread Alexei Starovoitov
On 4/27/18 5:13 AM, Daniel Borkmann wrote: Hi Ingo, On 04/27/2018 01:00 PM, tip-bot for Ingo Molnar wrote: Commit-ID: 5f26c50143f58f256535bee8d93a105f36d4d2da Gitweb: https://git.kernel.org/tip/5f26c50143f58f256535bee8d93a105f36d4d2da Author: Ingo Molnar AuthorDate: Fri, 27 Apr 2018 1

Greetings

2018-04-27 Thread Miss.Zeliha Omer Faruk
Hello Dear Greetings to you, please I have a very important business proposal for our mutual benefit, please let me know if you are interested i have asked you before. Best Regards, Miss. Zeliha ömer Faruk Caddesi Kristal Kule Binasi No:215

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Martin KaFai Lau
On Fri, Apr 27, 2018 at 11:31:36PM +0300, Dan Carpenter wrote: > On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > > >> On Fri, Apr 27, 2018 at 10:20:25AM -0700,

IP_PKTINFO broken by acf568ee859f0 (xfrm: Reinject transport-mode packets through tasklet)

2018-04-27 Thread Maxime Bizon
Hello Herbert, That patch just went into stable 4.14 and is causing a regression on my setup. Basically, IP_PKTINFO does not work anymore on transport-mode packets, because skb->cb is now used to store the finish callback. Was that expected or is it an unforeseen side effect ? Thanks, -- Max

[PATCH net-next] erspan: auto detect truncated packets.

2018-04-27 Thread William Tu
Currently the truncated bit is set only when the mirrored packet is larger than mtu. For certain cases, the packet might already been truncated before sending to the erspan tunnel. In this case, the patch detect whether the IP header's total length is larger than the actual skb->len. If true, th

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Dan Carpenter
On Fri, Apr 27, 2018 at 10:21:17PM +0200, Daniel Borkmann wrote: > On 04/27/2018 09:39 PM, Dan Carpenter wrote: > > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300

r8169 doesn't work after boot until `transmit queue 0 timed out`

2018-04-27 Thread ojab //
Oh hai! I've created bugzilla ticket about this, but I'm not sure if anyone reads it, so duplicating here. I have new motherboard (ASUS A320-K) with 10ec:8168 realtek network card installed and it doesn't work (i. e. `tcpdump` shows outgoing packets but no packets are actually transmitted and `tc

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Daniel Borkmann
On 04/27/2018 09:39 PM, Dan Carpenter wrote: > On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: >> On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: >>> On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: We know "err" is zero so we can remove these

[PATCH net-next] net: core: Assert the size of netdev_featres_t

2018-04-27 Thread Florian Fainelli
We have about 53 netdev_features_t bits defined and counting, add a build time check to catch when an u64 type will not be enough and we will have to convert that to a bitmap. This is done in register_netdevice() for convenience. Signed-off-by: Florian Fainelli --- include/linux/netdevice.h | 6

Re: [PATCH net-next v2 3/7] dt-bindings: net: add DT bindings for Microsemi Ocelot Switch

2018-04-27 Thread Rob Herring
On Thu, Apr 26, 2018 at 09:59:27PM +0200, Alexandre Belloni wrote: > DT bindings for the Ethernet switch found on Microsemi Ocelot platforms. > > Cc: Rob Herring > Cc: James Hogan > Signed-off-by: Alexandre Belloni > --- > .../devicetree/bindings/net/mscc-ocelot.txt | 82 +++

Re: [PATCH net-next v2 1/7] dt-bindings: net: add DT bindings for Microsemi MIIM

2018-04-27 Thread Rob Herring
On Thu, Apr 26, 2018 at 09:59:25PM +0200, Alexandre Belloni wrote: > DT bindings for the Microsemi MII Management Controller found on Microsemi > SoCs > > Cc: Rob Herring > Reviewed-by: Florian Fainelli > Signed-off-by: Alexandre Belloni > --- > .../devicetree/bindings/net/mscc-miim.txt |

[PATCH iproute2-next v7] Add support for cake qdisc

2018-04-27 Thread Toke Høiland-Jørgensen
sch_cake is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter To shape

[PATCH net] MAINTAINERS: add myself as SCTP co-maintainer

2018-04-27 Thread Marcelo Ricardo Leitner
Signed-off-by: Marcelo Ricardo Leitner --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 92be777d060a7df333a17d69e71bfd01760fa8f2..5bac32b545607933ea41fe9a56cc96d57ee7a094 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12507,6 +12507,7 @@ F:

[PATCH net-next] net: phy: Fix modular PHYLIB build

2018-04-27 Thread Florian Fainelli
After commit c59530d0d5dc ("net: Move PHY statistics code into PHY library helpers") we made net/core/ethtool.c reference symbols which are part of the library which can be modular. David introduced a temporary fix with 1ecd6e8ad996 ("phy: Temporary build fix after phylib changes.") which would pre

Re: [PATCH 2/2] bpf: btf: remove a couple conditions

2018-04-27 Thread Dan Carpenter
On Fri, Apr 27, 2018 at 10:55:46AM -0700, Martin KaFai Lau wrote: > On Fri, Apr 27, 2018 at 10:20:25AM -0700, Martin KaFai Lau wrote: > > On Fri, Apr 27, 2018 at 05:04:59PM +0300, Dan Carpenter wrote: > > > We know "err" is zero so we can remove these and pull the code in one > > > indent level. >

[PATCH iproute2-next v6] Add support for cake qdisc

2018-04-27 Thread Toke Høiland-Jørgensen
sch_cake is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20Mbit nat docsis ack-filter To shape

[PATCH net-next v5] Add Common Applications Kept Enhanced (cake) qdisc

2018-04-27 Thread Toke Høiland-Jørgensen
sch_cake targets the home router use case and is intended to squeeze the most bandwidth and latency out of even the slowest ISP links and routers, while presenting an API simple enough that even an ISP can configure it. Example of use on a cable ISP uplink: tc qdisc add dev eth0 cake bandwidth 20

Re: [PATCH net-next v9 0/4] Enable virtio_net to act as a standby for a passthru device

2018-04-27 Thread Jiri Pirko
Fri, Apr 27, 2018 at 07:53:01PM CEST, sridhar.samudr...@intel.com wrote: >On 4/27/2018 10:45 AM, Jiri Pirko wrote: >> Fri, Apr 27, 2018 at 07:06:56PM CEST, sridhar.samudr...@intel.com wrote: [...] >> >> No changes in v9? > >I listed v9 updates at the start of the message. Hmm, odd. I expected t

Re: [PATCH net] vhost: Use kzalloc() to allocate vhost_msg_node

2018-04-27 Thread Michael S. Tsirkin
On Fri, Apr 27, 2018 at 06:11:31PM +0200, Dmitry Vyukov wrote: > On Fri, Apr 27, 2018 at 6:05 PM, Michael S. Tsirkin wrote: > > On Fri, Apr 27, 2018 at 11:45:02AM -0400, Kevin Easton wrote: > >> The struct vhost_msg within struct vhost_msg_node is copied to userspace, > >> so it should be allocate

Re: [PATCH bpf-next v2 00/15] Introducing AF_XDP support

2018-04-27 Thread Björn Töpel
2018-04-27 21:06 GMT+02:00 Willem de Bruijn : > On Fri, Apr 27, 2018 at 2:12 PM, Björn Töpel wrote: >> 2018-04-27 19:16 GMT+02:00 Willem de Bruijn >> : >>> On Fri, Apr 27, 2018 at 8:17 AM, Björn Töpel wrote: From: Björn Töpel This patch set introduces a new address family called

Re: [PATCH] ptp_pch: use helpers function for converting between ns and timespec

2018-04-27 Thread David Miller
From: YueHaibing Date: Fri, 27 Apr 2018 15:36:18 +0800 > use ns_to_timespec64() and timespec64_to_ns() instead of open coding > > Signed-off-by: YueHaibing Applied to net-next, thanks.

Re: [PATCH v5 net-next 3/3] lan78xx: Modify error messages

2018-04-27 Thread Sergei Shtylyov
Hello! On 04/27/2018 09:47 PM, Raghuram Chary J wrote: > Modify the error messages when phy registration fails. > > Signed-off-by: Raghuram Chary J > --- > drivers/net/usb/lan78xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/usb/lan78xx.c b/driver

Re: [PATCH] net: systemport: fix spelling mistake: "asymetric" -> "asymmetric"

2018-04-27 Thread Florian Fainelli
On 04/27/2018 12:09 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in netdev_warn warning message > > Signed-off-by: Colin Ian King Acked-by: Florian Fainelli Thanks Colin! -- Florian

Re: [PATCH v3] net: qrtr: Expose tunneling endpoint to user space

2018-04-27 Thread David Miller
From: Bjorn Andersson Date: Thu, 26 Apr 2018 22:28:49 -0700 > This implements a misc character device named "qrtr-tun" for the purpose > of allowing user space applications to implement endpoints in the qrtr > network. > > This allows more advanced (and dynamic) testing of the qrtr code as well

[PATCH] net: systemport: fix spelling mistake: "asymetric" -> "asymmetric"

2018-04-27 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in netdev_warn warning message Signed-off-by: Colin Ian King --- drivers/net/ethernet/broadcom/bcmsysport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/etherne

Re: [PATCH bpf-next v2 00/15] Introducing AF_XDP support

2018-04-27 Thread Willem de Bruijn
On Fri, Apr 27, 2018 at 2:12 PM, Björn Töpel wrote: > 2018-04-27 19:16 GMT+02:00 Willem de Bruijn : >> On Fri, Apr 27, 2018 at 8:17 AM, Björn Töpel wrote: >>> From: Björn Töpel >>> >>> This patch set introduces a new address family called AF_XDP that is >>> optimized for high performance packet

Re: [PATCH net-next 03/13] sctp: remove an if() that is always true

2018-04-27 Thread Neil Horman
On Fri, Apr 27, 2018 at 03:13:49PM -0300, Marcelo Ricardo Leitner wrote: > On Fri, Apr 27, 2018 at 06:50:50AM -0400, Neil Horman wrote: > > On Thu, Apr 26, 2018 at 04:58:52PM -0300, Marcelo Ricardo Leitner wrote: > > > As noticed by Xin Long, the if() here is always true as PMTU can never > > > be

Re: [RFC PATCH] MAINTAINERS: add davem in NETWORKING DRIVERS

2018-04-27 Thread David Miller
From: Vivien Didelot Date: Thu, 26 Apr 2018 19:47:35 -0400 > "./scripts/get_maintainer.pl -f" does not actually show us David as the > maintainer of drivers/net directories such as team, bonding, phy or dsa. > Adding him in an M: entry of NETWORKING DRIVERS fixes this. > > Signed-off-by: Vivien

Re: [PATCH net-next 0/7] selftests: Add tests for mirroring to gretap

2018-04-27 Thread David Miller
From: Petr Machata Date: Fri, 27 Apr 2018 01:17:05 +0200 > This suite tests GRE-encapsulated mirroring. The general topology that > most of the tests use is as follows, but each test defines details of > the topology based on its needs, and some tests actually use a somewhat > different topology.

[PATCH V2 net-next 2/2] selftest: add test for TCP_INQ

2018-04-27 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Signed-off-by: Soheil Hassas Yeganeh Signed-off-by: Yuchung Cheng Signed-off-by: Willem de Bruijn Reviewed-by: Eric Dumazet Reviewed-by: Neal Cardwell --- tools/testing/selftests/net/Makefile | 3 +- tools/testing/selftests/net/tcp_inq.c | 189

[PATCH V2 net-next 1/2] tcp: send in-queue bytes in cmsg upon read

2018-04-27 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Applications with many concurrent connections, high variance in receive queue length and tight memory bounds cannot allocate worst-case buffer size to drain sockets. Knowing the size of receive queue length, applications can optimize how they allocate buffers to read f

Re: [PATCH net-next 2/2] net-backports: selftest: add test for TCP_INQ

2018-04-27 Thread Soheil Hassas Yeganeh
On Fri, Apr 27, 2018 at 2:50 PM, Soheil Hassas Yeganeh wrote: > From: Soheil Hassas Yeganeh > > Signed-off-by: Soheil Hassas Yeganeh > Signed-off-by: Yuchung Cheng > Signed-off-by: Willem de Bruijn > Reviewed-by: Eric Dumazet > Reviewed-by: Neal Cardwell Really sorry about the wrong patch s

[PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

2018-04-27 Thread Sergei Shtylyov
Document the R-Car V3H (R8A77980) SoC support in the R-Car CAN-FD bindings. Signed-off-by: Sergei Shtylyov --- The patch is against the 'linux-can-next.git' repo plus the R8A77970 bindings patch posted yesterday. Although I wouldn't object if they're both merged to the 'linux-can.git' repo inste

Re: [PATCH net-next v2 00/14] bnxt_en: Net-next updates.

2018-04-27 Thread David Miller
From: Michael Chan Date: Thu, 26 Apr 2018 17:44:30 -0400 > This series has 3 main features. The first is to add mqprio TC to > hardware queue mapping to avoid reprogramming hardware CoS queue > watermarks during run-time. The second is DIM improvements from > Andy Gospo. The third is some impr

  1   2   3   4   >