and switch to https where possible.
All links have been eyeballed to verify that the domains have
not changed, etc.
Signed-off-by: Sanjeev Gupta
---
Documentation/isdn/INTERFACE.CAPI | 2 +-
Documentation/isdn/README | 4 ++--
Documentation/isdn/README.FAQ | 4 ++--
Documentation
Ever since commit 3a06c7ac24f9 ("posix-clocks: Remove interval timer
facility and mmap/fasync callbacks") the possibility of PHC based
posix timers has been removed. In addition it will probably never
make sense to implement this functionality.
This patch removes the misleading text which seems t
On 3/23/2018 6:36 PM, Michael Chan wrote:
>> + mmiowb();
> Sorry for the late review. mmiowb() is not required here because we
> are in NAPI context, so only one CPU will be updating this doorbell.
>
> Other than that, it looks good.
>
OK, I'll fix this on the next version.
--
S
On Thu, 22 Mar 2018 15:57:57 -0700, David Ahern wrote:
> From: David Ahern
>
> Add devlink support to netdevsim and use it to implement a simple,
> profile based resource controller. Only one controller is needed
> per namespace, so the first netdevsim netdevice in a namespace
> registers with de
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Vinicius Costa Gomes
> Sent: Wednesday, March 21, 2018 5:34 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com>
> Subject: [Intel-wired-lan] [next-queu
On Fri, 23 Mar 2018 07:29:41 +0100, Jiri Pirko wrote:
> >This will associate the PF netdev with physical port, incl. all ethtool
> >information. Im not sure we want to do that. phy_repr carries this
> >functionality.
>
> I was not sure originally what this port is. Okay, what I would like to
>
From: Fuyun Liang
Default rss_hash_key value should be given to all vports. But just the
PF rss_hash_key has the default value here. This patch adds rss_hash_key
Initialization for all vports.
Signed-off-by: Fuyun Liang
Signed-off-by: Peng Li
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hcl
From: Fuyun Liang
The return type of hns3_get_rss_key_size is u32. But a negative value is
returned. This patch fixes it by replacing the negative value with zero.
Signed-off-by: Fuyun Liang
Signed-off-by: Peng Li
---
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +-
1 file changed,
This patchset fixes some bugs for HNS3 driver:
[Patch 1/5 - 2/5] fix 2 return vlaue issues.
[Patch 3/5 - 4/5] fix 2 comments reported by code review.
[Ptach 5/5] avoid sending message to IMP because IMP will not
handle any message when it is resetting.
Fuyun Liang (4):
net: hns3: fix for returni
From: Fuyun Liang
The return type of hns3_get_rss_indir_size is u32. But a negative value is
returned. This patch fixes it by replacing the negative value with zero.
Signed-off-by: Fuyun Liang
Signed-off-by: Peng Li
---
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +-
1 file changed
IMP will not handle and command queue message any more when it is
in core/global, driver should not send command queue message to
IMP until reinitialize the NIC HW.
This patch checks the status and avoid the message sent to IMP when
reset.
Signed-off-by: Peng Li
---
.../ethernet/hisilicon/hns3/
From: Fuyun Liang
Third parameter of hnae_set_field is shift, But a mask is given. This
patch fixes it by replacing HNS3_TXD_BDTYPE_M with HNS3_TXD_BDTYPE_S.
Signed-off-by: Fuyun Liang
Signed-off-by: Peng Li
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +-
1 file changed, 1 inserti
NFP program allocation length is in bytes and NFP program length
is in instructions, fix the comparison of the two.
Fixes: 9314c442d7dd ("nfp: bpf: move translation prepare to offload.c")
Signed-off-by: Jakub Kicinski
Reviewed-by: Jiong Wang
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 6
JSON does not accept hex numbers with 0x prefix. Simply print
as decimal numbers, JSON should be primarily machine-readable.
Signed-off-by: Jakub Kicinski
Reviewed-by: Quentin Monnet
Fixes: 831a0aafe5c3 ("tools: bpftool: add JSON output for `bpftool map *`
commands")
---
tools/bpf/bpftool/map
From: Dirk van der Merwe
The NSP default buffer is a piece of NFP memory where additional
command data can be placed. Its format has been copied from
host buffer, but the PCIe selection bits do not make sense in
this case. If those get masked out from a NFP address - writes
to random place in t
On 3/23/18 7:30 PM, Alexei Starovoitov wrote:
From: Alexei Starovoitov
v4->v5:
- adopted Daniel's fancy REPEAT macro in bpf_trace.c in patch 7
Daniel,
if you don't mind I'd like to land the patch set in this shape
and you can follow up with additional macro magic,
since I don't understand how
On 2018-03-23 19:58, Jeff Kirsher wrote:
On Fri, 2018-03-23 at 14:53 -0700, Alexander Duyck wrote:
On Fri, Mar 23, 2018 at 11:52 AM, Sinan Kaya
wrote:
> Code includes wmb() followed by writel() in multiple places. writel()
> already has a barrier on some architectures like arm64.
>
> This ends
From: Alexei Starovoitov
add empty raw_tracepoint bpf program to test overhead similar
to kprobe and traditional tracepoint tests
Signed-off-by: Alexei Starovoitov
---
samples/bpf/Makefile| 1 +
samples/bpf/bpf_load.c | 14 ++
samples/bpf/test_
From: Alexei Starovoitov
Introduce BPF_PROG_TYPE_RAW_TRACEPOINT bpf program type to access
kernel internal arguments of the tracepoints in their raw form.
>From bpf program point of view the access to the arguments look like:
struct bpf_raw_tracepoint_args {
__u64 args[0];
};
int bpf_pro
From: Alexei Starovoitov
similar to traditional traceopint test add bpf_get_stackid() test
from raw tracepoints
and reduce verbosity of existing stackmap test
Signed-off-by: Alexei Starovoitov
---
tools/testing/selftests/bpf/test_progs.c | 91
1 file changed, 7
From: Alexei Starovoitov
move COUNT_ARGS() macro from apparmor to generic header and extend it
to count till twelve.
COUNT() was an alternative name for this logic, but it's used for
different purpose in many other places.
Similarly for CONCATENATE() macro.
Suggested-by: Linus Torvalds
Signed
From: Alexei Starovoitov
- fix trace_hfi1_ctxt_info() to pass large struct by reference instead of by
value
- convert 'type array[]' tracepoint arguments into 'type *array',
since compiler will warn that sizeof('type array[]') == sizeof('type *array')
and later should be used instead
The CA
From: Alexei Starovoitov
v4->v5:
- adopted Daniel's fancy REPEAT macro in bpf_trace.c in patch 7
v3->v4:
- adopted Linus's CAST_TO_U64 macro to cast any integer, pointer, or small
struct to u64. That nicely reduced the size of patch 1
v2->v3:
- with Linus's suggestion introduced generic COU
From: Alexei Starovoitov
two trace events defined with the same name and both unused.
They conflict in allyesconfig build. Rename one of them.
Signed-off-by: Alexei Starovoitov
---
net/mac802154/trace.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/mac802154/t
From: Alexei Starovoitov
add bpf_raw_tracepoint_open(const char *name, int prog_fd) api to libbpf
Signed-off-by: Alexei Starovoitov
---
tools/include/uapi/linux/bpf.h | 11 +++
tools/lib/bpf/bpf.c| 11 +++
tools/lib/bpf/bpf.h| 1 +
3 files changed, 23 i
From: Alexei Starovoitov
add fancy macro to compute number of arguments passed into tracepoint
at compile time and store it as part of 'struct tracepoint'.
The number is necessary to check safety of bpf program access that
is coming in subsequent patch.
for_each_tracepoint_range() api has no use
From: Alexei Starovoitov
fix iwlwifi_dev_ucode_error tracepoint to pass pointer to a table
instead of all 17 arguments by value.
dvm/main.c and mvm/utils.c have 'struct iwl_error_event_table'
defined with very similar yet subtly different fields and offsets.
tracepoint is still common and using d
From: Alexei Starovoitov
two trace events defined with the same name and both unused.
They conflict in allyesconfig build. Rename one of them.
Signed-off-by: Alexei Starovoitov
---
drivers/net/wireless/mediatek/mt7601u/trace.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -
On Fri, Mar 23, 2018 at 6:43 PM, Alexei Starovoitov wrote:
>
> it's not the limit I'm hitting, but self referential issue.
> Exactly half gets expanded.
> I don't think there is an easy workaround other
> than duplicating the whole chain of REPEAT macro twice
> with slightly different name.
Take
From: Davide Caratti
Date: Fri, 23 Mar 2018 19:31:30 +0100
> use u16 in place of __be16 to suppress the following sparse warnings:
>
> net/sched/act_vlan.c:150:26: warning: incorrect type in assignment
> (different base types)
> net/sched/act_vlan.c:150:26: expected restricted __be16 [usertyp
From: Davide Caratti
Date: Fri, 23 Mar 2018 19:09:39 +0100
> tcf_idr_cleanup() is no more used, so remove it.
>
> Suggested-by: Cong Wang
> Signed-off-by: Davide Caratti
Applied, thank you.
From: Ido Schimmel
Date: Fri, 23 Mar 2018 21:03:58 +0300
> In net commit 8175f7c4736f ("mlxsw: spectrum: Prevent duplicate
> mirrors") we prevented the user from mirroring more than once from a
> single binding point (port-direction pair).
>
> The fix was essentially reverted in a merge conflict
On 3/23/18 5:58 PM, Alexei Starovoitov wrote:
On 3/23/18 4:13 PM, Daniel Borkmann wrote:
On 03/22/2018 04:41 PM, Alexei Starovoitov wrote:
On 3/22/18 2:43 AM, Daniel Borkmann wrote:
On 03/21/2018 07:54 PM, Alexei Starovoitov wrote:
[...]
@@ -546,6 +556,53 @@ extern void ftrace_profile_free_fi
On Sat, 24 Mar 2018 00:13:28 +0100
Daniel Borkmann wrote:
> #define UNPACK(...) __VA_ARGS__
> #define REPEAT_1(FN, DL, X, ...) FN(X)
> #define REPEAT_2(FN, DL, X, ...) FN(X) UNPACK DL REPEAT_1(FN, DL,
> __VA_ARGS__)
> #define REPEAT_3(FN, DL, X, ...) FN(X) UNPACK
On 3/23/18 4:13 PM, Daniel Borkmann wrote:
On 03/22/2018 04:41 PM, Alexei Starovoitov wrote:
On 3/22/18 2:43 AM, Daniel Borkmann wrote:
On 03/21/2018 07:54 PM, Alexei Starovoitov wrote:
[...]
@@ -546,6 +556,53 @@ extern void ftrace_profile_free_filter(struct perf_event
*event);
void perf_tra
From: Intiyaz Basha
Removing checks for netif_is_multiqueue.
Configuring single queue will be a multiqueue netdev with one queues.
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_core.c| 18 ++---
drivers/ne
From: Intiyaz Basha
Removing one line function wake_q
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c| 14 ++
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 12 +---
2 files
From: Intiyaz Basha
For consistency renaming txqs_start to start_txqs
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +-
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 2 +-
drivers/ne
Hi,
On 03/22/2018 03:52 PM, Thomas Gleixner wrote:
> On Thu, 22 Mar 2018, Jesus Sanchez-Palencia wrote:
>> Our plan was to work directly with the Qbv-like scheduling (per-port) just
>> after
>> the cbs qdisc (Qav), but the feedback here and offline was that there were
>> use
>> cases for a more
From: Intiyaz Basha
For consistency renaming txqs_wake to wake_txqs
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 4 ++--
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 4 ++--
drivers/
From: Intiyaz Basha
Using skb_iq function for deriving queue from skb
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c| 3 +--
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 3 +--
2 files change
From: Intiyaz Basha
Removing start_txq function from VF and PF files
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 16 +---
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 16
From: Intiyaz Basha
Removing one line function stop_q
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c| 12 +---
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c | 12 +---
2 files ch
From: Intiyaz Basha
Moving common function skb_iq to to octeon_network.h
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 10 --
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 10 -
From: Intiyaz Basha
For consistency renaming txqs_stop to stop_txqs
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +-
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c| 4 ++--
drivers/ne
From: Intiyaz Basha
Removing one line function stop_txq
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/net/ethernet
From: Intiyaz Basha
Moving common function txqs_start to octeon_network.h
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 16
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
From: Intiyaz Basha
Moving common function txqs_wake to octeon_network.h
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c| 28 --
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
From: Intiyaz Basha
Moving common function txqs_stop to octeon_network.h
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
drivers/net/ethernet/cavium/liquidio/lio_main.c | 16
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c
From: Intiyaz Basha
Moved some common function to octeon_network.h
Removed some unwanted functions and checks.
Intiyaz Basha (13):
liquidio: Moved common function txqs_stop to octeon_network.h
liquidio: Moved common function txqs_wake to octeon_network.h
liquidio: Moved common function txq
On Fri, 2018-03-23 at 14:53 -0700, Alexander Duyck wrote:
> On Fri, Mar 23, 2018 at 11:52 AM, Sinan Kaya
> wrote:
> > Code includes wmb() followed by writel() in multiple places. writel()
> > already has a barrier on some architectures like arm64.
> >
> > This ends up CPU observing two barriers b
From: Colin Ian King
The call to rmnet_get_endpoint can potentially return NULL so check
for this to avoid any subsequent null pointer dereferences on a NULL
ep.
Detected by CoverityScan, CID#1465385 ("Dereference null return value")
Fixes: 23790ef12082 ("net: qualcomm: rmnet: Allow to configur
Hi Thomas,
On 03/23/2018 01:49 AM, Thomas Gleixner wrote:
> On Thu, 22 Mar 2018, Jesus Sanchez-Palencia wrote:
>> On 03/22/2018 03:11 PM, Thomas Gleixner wrote:
>> So, are you just opposing to the case where sorting off + offload off is
>> used?
>> (i.e. the scheduled FIFO case)
>
> FIFO does n
Prefer the direct use of octal for permissions.
Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
and some typing.
Miscellanea:
o Whitespace neatening around these conversions.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/8390/apne.c | 2 +-
drivers/net/e
From: Shannon Nelson
With the patch
commit f8aa2696b4af ("esp: check the NETIF_F_HW_ESP_TX_CSUM bit before
segmenting")
we no longer need to protect ourself from checksum
offload requests on IPsec packets, so we can remove
the check in our .ndo_features_check callback.
Signed-off-by: Shannon Ne
From: Paul Greenwalt
Replaced an assignment operation with an OR operation.
The variable assignment was overwriting the value read from the PHY
register. The OR operation sets only the intended register bits.
The bits that were being overwritten are reserved, so the assignment had no
functional
From: Björn Töpel
The current page counting scheme assumes that the reference count
cannot decrease until the received frame is sent to the upper layers
of the networking stack. This assumption does not hold for the
XDP_REDIRECT action, since a page (pointed out by xdp_buff) can have
its referenc
From: Tony Nguyen
This implements the XDP_TX action which is modeled on the ixgbe
implementation. However instead of using CPU id to determine which XDP
queue to use, this uses the received RX queue index, which is similar
to i40e. Doing this eliminates the restriction that number of CPUs not
exc
This series contains updates to ixgbe and ixgbevf only.
Paul adds status register reads to reduce a potential race condition
where registers can read 0x during a PCI reset, which in turn
causes the driver to remove the adapter. Then fixes an assignment
operation with an "OR" operation.
S
From: Tony Nguyen
Current XDP implementation hits the tail on every XDP_TX; change the
driver to only hit the tail after packet processing is complete.
Based on
commit 7379f97a4fce ("ixgbe: delay tail write to every 'n' packets")
Signed-off-by: Tony Nguyen
Acked-by: John Fastabend
Tested-by:
From: Shannon Nelson
There is no need to calculate the trailer length if we're doing
a GSO/TSO, as there is no trailer added to the packet data.
Also, don't bother clearing the flags field as it was already
cleared earlier.
Signed-off-by: Shannon Nelson
Tested-by: Andrew Bowers
Signed-off-by:
From: Shannon Nelson
Since the ipsec data fields will be zero anyway in the non-ipsec
case, we can remove the conditional jump.
Suggested-by: Alexander Duyck
Signed-off-by: Shannon Nelson
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
From: Tony Nguyen
XDP stats are included in TX stats, however, they are not
reported in TX queue stats since they are setup on different
queues. Add reporting for XDP queue stats to provide
consistency between the total stats and per queue stats.
Signed-off-by: Tony Nguyen
Acked-by: John Fasta
From: Tony Nguyen
Implement XDP_PASS and XDP_DROP based on the ixgbe implementation.
Based largely on commit 924708081629 ("ixgbe: add XDP support for pass and
drop actions").
Signed-off-by: Tony Nguyen
Acked-by: John Fastabend
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drive
From: Shannon Nelson
Fix things up to support TSO offload in conjunction
with IPsec hw offload. This raises throughput with
IPsec offload on to nearly line rate.
Signed-off-by: Shannon Nelson
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ips
From: Paul Greenwalt
Add status register reads and delay between reads to ixgbe_check_remove.
Registers can read 0x during PCI reset, which causes the driver
to remove the adapter. The additional status register reads can reduce the
chance of this race condition.
If the status register i
From: Tony Nguyen
Add support for XDP meta data when using build skb.
Based on commit 366a88fe2f40 ("bpf, ixgbe: add meta data support")
Signed-off-by: Tony Nguyen
Acked-by: John Fastabend
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_m
On 03/22/2018 04:41 PM, Alexei Starovoitov wrote:
> On 3/22/18 2:43 AM, Daniel Borkmann wrote:
>> On 03/21/2018 07:54 PM, Alexei Starovoitov wrote:
>> [...]
>>> @@ -546,6 +556,53 @@ extern void ftrace_profile_free_filter(struct
>>> perf_event *event);
>>> void perf_trace_buf_update(void *record,
On 23 March 2018 at 15:09, Juri Lelli wrote:
> On 23/03/18 14:43, Rafał Miłecki wrote:
>> Hi,
>>
>> On 23 March 2018 at 10:47, Juri Lelli wrote:
>> > I've got a Dell XPS 13 9343/0TM99H (BIOS A15 01/23/2018) mounting a
>> > BCM4352 802.11ac (rev 03) wireless card and so far I've been using it on
>
Prefer the direct use of octal for permissions.
Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
and some typing.
Miscellanea:
o Whitespace neatening around these conversions.
Signed-off-by: Joe Perches
---
drivers/net/bonding/bond_procfs.c | 2 +-
drivers/net/bonding/bond_s
Prefer the direct use of octal for permissions.
Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
and some typing.
Miscellanea:
o Whitespace neatening around these conversions.
Signed-off-by: Joe Perches
---
drivers/net/wireless/ath/ath5k/base.c | 6 +-
drivers/net/w
Prefer the direct use of octal for permissions.
Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
and some typing.
Miscellanea:
o Whitespace neatening around these conversions.
Signed-off-by: Joe Perches
---
net/8021q/vlanproc.c | 6 ++---
net/appletalk/atalk
Using octal and not symbolic permissions is preferred by many as
more readable.
https://lkml.org/lkml/2016/8/2/1945
Rather than getting these piecemeal, just do them all.
Done with checkpatch and some typing.
Joe Perches (4):
ethernet: Use octal not symbolic permissions
wireless: Use octal n
From: Colin Ian King
In the case where hard_iface is NULL, the error path may pass a null
pointer to batadv_hardif_put causing a null pointer dereference error.
Avoid this by only calling the function if hard_iface not null.
Detected by CoverityScan, CID#1466456 ("Explicit null dereferenced")
From: Aviv Heller
We support outer VLAN offload in driver and HW regardless of whether
an encapsulation is present in the next headers.
Exposing this in hw_enc_features will allow us to offload outer VLANs
in cases where encapsulation protocols like VXLAN and IPsec are used.
Signed-off-by: Aviv
From: Moshe Shemesh
Added the following packets drop counter:
Rx steering missed dropped packets - counts packets which were dropped
due to miss on NIC rx steering rules.
This counter will be shown on ethtool as a new counter called
rx_steer_missed_packets.
Signed-off-by: Moshe Shemesh
Signed-o
From: Or Gerlitz
Currently, we are emulating the offload of vlan push/pop actions using
global setup as done by commit f5f82476090f ("net/mlx5: E-Switch, Support
VLAN actions in the offloads mode"). With newer NICs, we can apply a flow
action for that matter, do that while keeping the emulated pa
From: Inbar Karmy
Implement set/get functions to configure PFC stall prevention
timeout by tunables api through ethtool.
By default the stall prevention timeout is configured to 8 sec.
Timeout range is: 80-8000 msec.
Enabling stall prevention without a specific timeout will set
the timeout to 100
From: Leon Romanovsky
The system with CONFIG_UBSAN enabled on produces the following error
during driver initialization. The reason to it that max_reg_cmds can be
larger enough to cause to "1 << max_reg_cmds" overflow the unsigned long.
===
From: Moshe Shemesh
Added the following packets dropped while vport down statistics:
Rx dropped while vport down - counts packets which were steered by
e-switch to a vport, but dropped since the vport was down. This counter
will be shown on ip link tool as part of the vport rx_dropped counter.
From: Moshe Shemesh
Add support for new FW command QUERY_VNIC_ENV.
The command is used by the driver to query vnic diagnostic statistics
from FW.
Signed-off-by: Moshe Shemesh
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 2 ++
include/linux/mlx5/mlx5_ifc.h
From: Gal Pressman
Add a new macro to prevent copy-pasting the same code for each new
feature.
Signed-off-by: Gal Pressman
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 26 ++-
1 file changed, 11 insertions(+), 15 deletions(-)
diff
From: Moshe Shemesh
Added the following packets drop counter:
Rx interface down dropped packets - counts packets which were received
while the ETH interface was down.
This counter will be shown on ethtool as a new counter called
rx_if_down_packets.
The implementation allocates a q_counter for dr
From: Gal Pressman
The function is used in en_main.c only, we can make it static and remove
its declaration from en.h
Signed-off-by: Gal Pressman
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 -
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 +-
From: Or Gerlitz
Align the checks for modify header and encap actions with the
rest of the code.
Signed-off-by: Or Gerlitz
Reviewed-by: Mark Bloch
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
From: Inbar Karmy
Add the needed capability bit and counters to device spec description.
Expose the following two counters in ethtool:
tx_pause_storm_warning_events: when the device is stalled for a period
longer than a pre-configured watermark, the counter increase, allowing
the debug utility a
From: Gal Pressman
ethtool core code makes sure data isn't NULL before calling
get_ethtool_stats, testing it again in the driver is redundant.
Signed-off-by: Gal Pressman
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 ---
1 file changed, 3 deletion
Hi Dave,
This series includes some misc updates to mlx5 core and netdev driver,
please note that there is a small change to net/core/ethtool.c and
include/uapi/linux/ethtool.h that adds new tunable for PFC stall
prevention on/off support, which was already reviewed as RFC [1].
For more informati
From: Inbar Karmy
In the event where the device unexpectedly becomes unresponsive
for a long period of time, flow control mechanism may propagate
pause frames which will cause congestion spreading to the entire
network.
To prevent this scenario, when the device is stalled for a period
longer than
From: Or Gerlitz
Newer NICs (ConnectX-5 and onward) can apply vlan pop or push as an
action taking place during flow steering. Add the core bits for that.
Signed-off-by: Or Gerlitz
Reviewed-by: Mark Bloch
Signed-off-by: Saeed Mahameed
---
.../net/ethernet/mellanox/mlx5/core/diag/fs_tracepoin
On Fri, Mar 23, 2018 at 3:23 PM, Sinan Kaya wrote:
> Code includes wmb() followed by writel(). writel() already has a barrier on
> some architectures like arm64.
>
> This ends up CPU observing two barriers back to back before executing the
> register write.
>
> Create a new wrapper function with r
Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
the register write.
Since code already has an explicit barrier call, changing writel() to
writel_relaxed().
Signed-off-
barrier() doesn't guarantee memory writes to be observed by the hardware on
all architectures. barrier() only tells compiler not to move this code
with respect to other read/writes.
If memory write needs to be observed by the HW, wmb() is the right choice.
Signed-off-by: Sinan Kaya
---
drivers/
From: Shahar Klein
When mlx5_core is loaded it is expected to sync ports
with all vxlan devices so it can support vxlan encap/decap.
This is done via udp_tunnel_get_rx_info(). Currently this
call is set in mlx5e_nic_enable() and if the netdev is not in
NETREG_REGISTERED state it will not be calle
Hi Dave,
The following series includes fixes for mlx5 netdev and eswitch.
For -stable v4.12
('net/mlx5e: Avoid using the ipv6 stub in the TC offload neigh update path')
('net/mlx5e: Fix traffic being dropped on VF representor')
For -stable v4.13
('net/mlx5e: Fix memory usage issues i
Code includes wmb() followed by writel(). writel() already has a
barrier on some architectures like arm64.
This ends up CPU observing two barriers back to back before executing
the register write.
Since code already has an explicit barrier call, changing code to
wmb()
writel_relaxed()
mmiowb()
From: Jianbo Liu
The vport admin original link state will be re-applied after returning
back to legacy mode, it is not right to change the admin link state value
when in switchdev mode.
Use direct vport commands to alter logical vport state in netdev
representor open/close flows rather than the
From: Or Gerlitz
SQs are 32 and not 16 bits, hence it's wrong to use only 16 bits to
store the sq number for which are going to set steering rule, fix that.
Fixes: cb67b832921c ('net/mlx5e: Introduce SRIOV VF representors')
Signed-off-by: Or Gerlitz
Reviewed-by: Mark Bloch
Signed-off-by: Saeed
From: Jianbo Liu
For NIC flows, the parsed attributes are not freed when we exit
successfully from mlx5e_configure_flower().
There is possible double free for eswitch flows. If error is returned
from rhashtable_insert_fast(), the parse attrs will be freed in
mlx5e_tc_del_flow(), but they will be
From: Or Gerlitz
Currently we use the global ipv6_stub var to access the ipv6 global
nd table. This practice gets us to troubles when the stub is only partially
set e.g when ipv6 is loaded under the disabled policy. In this case, as of
commit
343d60aada5a "ipv6: change ipv6_stub_impl.ipv6_dst_lo
1 - 100 of 329 matches
Mail list logo
