On 2017-08-21 10:14, Konstantin Khlebnikov wrote:
> When codel wants to drop last packet in ->dequeue() it cannot call
> qdisc_tree_reduce_backlog() right away - it will notify parent qdisc
> about zero qlen and HTB/HFSC will deactivate class. The same class will
> be deactivated second time by cal
We already return an error when some dependencies (e.g., 'jq') are
missing so lets be consistent and do that for all.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
tools/testing/selftests/net/forwarding/lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/t
Similar to the VLAN-aware bridge test, test the VLAN-unaware bridge and
make sure that ping, FDB learning and flooding work as expected.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
.../net/forwarding/bridge_vlan_unaware.sh | 86 ++
1 file changed, 86 ins
Some users want to be able to run the tests without a configuration file
which is useful when one needs to test both virtual and physical
interfaces on the same machine.
Move the defines that set the type of interface to create and whether to
create it away from the optional configuration file to
Returning 0 gives a false sense of success when the required modules did
not even manage to be initialized and register the required net devices.
Signed-off-by: Ido Schimmel
Reviewed-by: Jiri Pirko
---
tools/testing/selftests/net/forwarding/lib.sh | 4 ++--
1 file changed, 2 insertions(+), 2 de
First patch adds a new test for VLAN-unaware bridges.
Next two patches make the tests fail in case they are missing interfaces
or dependencies.
Last patch allows one to create the veth interfaces even without the
optional configuration file.
Ido Schimmel (4):
selftests: forwarding: Add a test
From: Petr Machata
mlxsw_spectrum supports offloading of a tc action mirred egress mirror
to a gretap or an ip6gretap netdevice, which necessitates calls to
functions defined in ip_gre, ip6_gre and ip6_tunnel modules. Previously
this was enabled by introducing a hard dependency of MLXSW_SPECTRUM
From: Petr Machata
In order to abstract away access to the
ipv6.sysctl.multipath_hash_policy variable, which is not available on
systems compiled without IPv6 support, introduce a wrapper function
ip6_multipath_hash_policy() that falls back to 0 on non-IPv6 systems.
Use this wrapper from mlxsw/s
From: Petr Machata
Move the function next to the rest of gretap4 functions. Thus the
generic functions shared between gretap4 and gretap6 are in one block at
the beginning, followed by a gretap4 block, followed by a gretap6 block.
Signed-off-by: Petr Machata
Signed-off-by: Ido Schimmel
---
..
Petr says:
mlxsw_spectrum supports offloading of a tc action mirred egress mirror
to a gretap or ip6gretap netdevice, which necessitates calls to
functions defined in ip_gre, ip6_gre and ip6_tunnel modules. Previously
this was enabled by introducing a hard dependency of MLXSW_SPECTRUM on
NET_IPGRE
Petr says:
mlxsw_spectrum supports offloading of a tc action mirred egress mirror
to a gretap or ip6gretap netdevice, which necessitates calls to
functions defined in ip_gre, ip6_gre and ip6_tunnel modules. Previously
this was enabled by introducing a hard dependency of MLXSW_SPECTRUM on
NET_IPGRE
Hi Brad,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Brad-Mouring/net-macb-Reorganize-macb_mii-bringup/20180311-133616
config: i386-randconfig-x012-201810 (attached as .config)
compiler: gcc
On Sat, Mar 10, 2018 at 1:43 AM, Alexei Starovoitov wrote:
> On 3/9/18 11:37 AM, Andy Lutomirski wrote:
>>
>> On Fri, Mar 9, 2018 at 6:55 PM, David Miller wrote:
>>>
>>> From: Alexei Starovoitov
>>> Date: Fri, 9 Mar 2018 10:50:49 -0800
>>>
On 3/9/18 10:23 AM, Andy Lutomirski wrote:
>
>>
On 03/10/2018 05:12 PM, Kees Cook wrote:
On Sat, Mar 10, 2018 at 3:06 PM, Arend van Spriel
wrote:
On 3/9/2018 1:30 PM, Andreas Christoforou wrote:
The kernel would like to have all stack VLA usage removed.
I think there was a remark made earlier to give more explanation here. It
should e
> Just wondering. Is this actually a VLA. FFT_NUM_SAMPLES was static const so
> not really going to show a lot of variation. This array will always have the
> same size on the stack.
The issue is that unlike in C++, a `static const` can't be used in a
constant expression in C. It's unclear why C i
On Sat, Mar 10, 2018 at 3:06 PM, Arend van Spriel
wrote:
> On 3/9/2018 1:30 PM, Andreas Christoforou wrote:
>>
>> The kernel would like to have all stack VLA usage removed.
>
>
> I think there was a remark made earlier to give more explanation here. It
> should explain why we want "VLA on stack" r
On 3/9/2018 1:30 PM, Andreas Christoforou wrote:
The kernel would like to have all stack VLA usage removed.
I think there was a remark made earlier to give more explanation here.
It should explain why we want "VLA on stack" removed.
Signed-off-by: Andreas Christoforou
---
drivers/net/wir
Hi Andrew,
On Sat, Mar 10, 2018 at 05:17:18PM +0100, Andrew Lunn wrote:
> On Fri, Mar 09, 2018 at 04:12:31PM -0600, Brad Mouring wrote:
> > The macb mii setup (mii_probe() and mii_init()) previously was
> > somewhat interspersed, likely a result of organic growth and hacking.
>
> Hi Brad
>
> For
On Fri, Mar 09, 2018 at 07:03:03PM -0800, Igor Mitsyanko wrote:
> Main goal of the patchset is to allow for flooding offload to switchdev
> in scenarios when HW switchdev ports and SW ports are operating in a
> single bridge.
>
> In case a data frame that needs to be flooded is ingressed on a SW p
On Thu, Mar 8, 2018 at 6:08 PM, zhangliping wrote:
> From: zhangliping
>
> Max delat_t should be the full_bucket/rate instead of the full_bucket.
> Also report EINVAL if the rate is zero.
>
> Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure")
> Cc: Andy Zhou
> Signed-off-by: zhanglipi
Would you like to be part of our supply?
Please respond back to my private email
on: kuanwaich...@gmail.com
From: Markus Elfring
Date: Sat, 10 Mar 2018 22:18:45 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/net/wireless/ti/wlcore/acx.c |
From: Markus Elfring
Date: Sat, 10 Mar 2018 22:00:31 +0100
Return directly after a call of the function "kzalloc" failed
at the beginning.
Signed-off-by: Markus Elfring
---
drivers/net/wireless/ti/wlcore/acx.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/n
From: Markus Elfring
Date: Sat, 10 Mar 2018 21:51:17 +0100
The local variable "ret" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/net/wireless/ti/wlcore/acx.c | 2 +-
1 file changed, 1 insertio
From: Markus Elfring
Date: Sat, 10 Mar 2018 22:25:45 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an unnecessary variable initialisation
Return directly after a failed kzalloc()
Use common error handling code
drivers/
On Sat, Mar 10, 2018 at 07:22:55PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 10 Mar 2018 19:05:45 +0100
>
> Two update suggestions were taken into account
> from static source code analysis.
Hi Markus
How about re-writing this driver to use phylib. The whole of
ax88179
On Tue, 24 Oct 2017 08:15:01 -0700, syzbot wrote:
> Hello,
>
> syzkaller hit the following crash on
> b9f1f1ce866c28e3d9b86202441b220244754a69
> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master
> compiler: gcc (GCC) 7.1.1 20170620
> .config is attached
> Raw console
On Sat, Mar 10, 2018 at 6:51 PM, Linus Torvalds
wrote:
>
> So in *historical* context - when a compiler didn't do variable length
> arrays at all - the original semantics of C "constant expressions"
> actually make a ton of sense.
>
> You can basically think of a constant expression as something t
On Sun, Mar 11, 2018 at 12:22:32AM +0800, Xin Long wrote:
> On Sat, Mar 10, 2018 at 9:13 PM, Neil Horman wrote:
> > On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote:
> >> On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman wrote:
> >> > On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote:
> >
Stephen Hemminger writes:
> On Sat, 10 Mar 2018 08:31:26 -0500
> Roman Mashak wrote:
>
>> Signed-off-by: Roman Mashak
>> ---
>> tc/f_flower.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tc/f_flower.c b/tc/f_flower.c
>> index 5a4ec832bc19..5cf19139dcae 100644
>>
On Sat, Mar 10, 2018 at 8:41 PM, Joe Perches wrote:
> On Sat, 2018-03-10 at 19:24 +0100, SF Markus Elfring wrote:
>> From: Markus Elfring
>> Date: Sat, 10 Mar 2018 18:22:43 +0100
>>
>> Adjust a jump target so that a bit of common code can be better reused
>> at the end of this function.
>
> Pleas
On Sat, 2018-03-10 at 19:24 +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 10 Mar 2018 18:22:43 +0100
>
> Adjust a jump target so that a bit of common code can be better reused
> at the end of this function.
Please stop mindlessly sending patching Markus.
How about looking
On Sat, 10 Mar 2018 09:18:46 -0800
Kees Cook wrote:
> On Sat, Mar 10, 2018 at 12:43 AM, Stefano Brivio wrote:
> > On Sat, 10 Mar 2018 09:40:44 +0200
> > Andreas Christoforou wrote:
> >
> >> diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
> >> index b15075a..270a53a 100644
> >> --
From: Markus Elfring
Date: Sat, 10 Mar 2018 18:53:28 +0100
Use three values directly for a condition check without assigning them
to intermediate variables.
Signed-off-by: Markus Elfring
---
drivers/net/usb/ax88179_178a.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
dif
From: Markus Elfring
Date: Sat, 10 Mar 2018 18:22:43 +0100
Adjust a jump target so that a bit of common code can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/net/usb/ax88179_178a.c | 34 ++
From: Markus Elfring
Date: Sat, 10 Mar 2018 19:05:45 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Use common code
Delete three unnecessary variables
drivers/net/usb/ax88179_178a.c | 45 +++---
On Sat, Mar 10, 2018 at 9:34 AM, Miguel Ojeda
wrote:
>
> So the warning is probably implemented to just trigger whenever VLAs
> are used but the given standard does not allow them, for all
> languages. The problem is why the ISO C90 frontend is not giving an
> error for using invalid syntax for ar
On Sat, Mar 10, 2018 at 5:30 PM, Linus Torvalds
wrote:
> On Sat, Mar 10, 2018 at 7:33 AM, Kees Cook wrote:
>>
>> Alright, I'm giving up on fixing max(). I'll go back to STACK_MAX() or
>> some other name for the simple macro. Bleh.
>
> Oh, and I'm starting to see the real problem.
>
> It's not tha
Hi Andrew,
Thank you very much for taking care of this.
Please find my answers to your remarks below.
On Fri, 9 Mar 2018 14:12:52 -0800
Andrew Morton wrote:
> On Fri, 09 Mar 2018 21:41:38 +0100 Greg Kurz wrote:
>
> > If it was interrupted by a signal, the 9p client may need to send some
> >
On Sat, Mar 10, 2018 at 12:43 AM, Stefano Brivio wrote:
> On Sat, 10 Mar 2018 09:40:44 +0200
> Andreas Christoforou wrote:
>
>> diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
>> index b15075a..270a53a 100644
>> --- a/net/ipv6/xfrm6_state.c
>> +++ b/net/ipv6/xfrm6_state.c
>> @@ -62,7
On Sat, 10 Mar 2018 08:31:26 -0500
Roman Mashak wrote:
> Signed-off-by: Roman Mashak
> ---
> tc/f_flower.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tc/f_flower.c b/tc/f_flower.c
> index 5a4ec832bc19..5cf19139dcae 100644
> --- a/tc/f_flower.c
> +++ b/tc/f_flower.
On Thu, 8 Mar 2018 18:08:26 +0200
Tariq Toukan wrote:
> TX rate limit fields are unsigned (__u32).
> Use %u and print_uint when printing.
>
> Tested:
> $ ip link set ens1 vf 1 rate 2294967296
> $ ip link show |grep -iE "vf 1" | grep rate
>
> before:
> vf 1 MAC 00:00:00:00:00:00, tx rate -2
On Fri, Mar 09, 2018 at 07:03:06PM -0800, Igor Mitsyanko wrote:
> Introduce BR_FLOOD_OFFLOAD bridge port flag that can be used by
> switchdev-capable hardware to advertize that it wants to handle all
> flooding by itself.
> In that case there is no need for a driver to set skb::offload_fwd_mark
> o
On Fri, 9 Mar 2018 09:21:33 -0800
Anirudh Venkataramanan wrote:
> + /* VSI stats */
> + struct rtnl_link_stats64 net_stats;
> + struct rtnl_link_stats64 net_stats_prev;
> + struct ice_eth_stats eth_stats;
> + struct ice_eth_stats eth_stats_prev;
You also don't need current a
On Fri, 9 Mar 2018 09:21:30 -0800
Anirudh Venkataramanan wrote:
> This patch configures the VSIs to be able to send and receive
> packets by doing the following:
>
> 1) Initialize flexible parser to extract and include certain
>fields in the Rx descriptor.
>
> 2) Add Tx queues by programmi
On Fri, Mar 09, 2018 at 07:03:05PM -0800, Igor Mitsyanko wrote:
> sysfs interface to configure bridge flags only updates SW copy but does
> not notify hardware through switchdev interface. Make sure it is.
>
> Signed-off-by: Igor Mitsyanko
> ---
> net/bridge/br_sysfs_if.c | 15 +++
>
On Fri, 9 Mar 2018 09:21:33 -0800
Anirudh Venkataramanan wrote:
> + /* VSI stats */
> + struct rtnl_link_stats64 net_stats;
> + struct rtnl_link_stats64 net_stats_prev;
> + struct ice_eth_stats eth_stats;
> + struct ice_eth_stats eth_stats_prev;
> +
There is already a stats6
On Fri, 9 Mar 2018 19:03:04 -0800
Igor Mitsyanko wrote:
> Default bridge port flags for switchdev devices can be different from
> what is used in bridging core. Get default value from switchdev itself
> on port initialization.
>
> Signed-off-by: Igor Mitsyanko
> ---
Yes hardware devices may c
On Fri, Mar 09, 2018 at 07:03:04PM -0800, Igor Mitsyanko wrote:
> Default bridge port flags for switchdev devices can be different from
> what is used in bridging core. Get default value from switchdev itself
> on port initialization.
>
> Signed-off-by: Igor Mitsyanko
> ---
> net/bridge/br_if.c
On Sat, Mar 10, 2018 at 7:33 AM, Kees Cook wrote:
>
> Alright, I'm giving up on fixing max(). I'll go back to STACK_MAX() or
> some other name for the simple macro. Bleh.
Oh, and I'm starting to see the real problem.
It's not that our current "min/max()" are broiken. It's that "-Wvla" is garbage
On Sat, Mar 10, 2018 at 9:13 PM, Neil Horman wrote:
> On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote:
>> On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman wrote:
>> > On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote:
>> >> Hello,
>> >>
>> >> syzbot hit the following crash on net-next c
On Fri, Mar 09, 2018 at 04:12:33PM -0600, Brad Mouring wrote:
You should have at least one line here, even if it is the subject line
differently worded.
> Signed-off-by: Brad Mouring
On Fri, Mar 09, 2018 at 04:12:31PM -0600, Brad Mouring wrote:
> The macb mii setup (mii_probe() and mii_init()) previously was
> somewhat interspersed, likely a result of organic growth and hacking.
Hi Brad
For netdev it is normal to include a cover note for patch series,
which explains the big p
On Sat, Mar 10, 2018 at 7:33 AM, Kees Cook wrote:
>
> And sparse freaks out too:
>
>drivers/net/ethernet/via/via-velocity.c:97:26: sparse: incorrect
> type in initializer (different address spaces) @@expected void
> *addr @@got struct mac_regs [noderef]
On Fri, Mar 9, 2018 at 11:03 PM, Miguel Ojeda
wrote:
>
> Just compiled 4.9.0 and it seems to work -- so that would be the
> minimum required.
>
> Sigh...
>
> Some enterprise distros are either already shipping gcc >= 5 or will
> probably be shipping it soon (e.g. RHEL 8), so how much does it hurt
On Fri, Mar 9, 2018 at 10:10 PM, Miguel Ojeda
wrote:
> On Sat, Mar 10, 2018 at 4:11 AM, Randy Dunlap wrote:
>> On 03/09/2018 04:07 PM, Andrew Morton wrote:
>>> On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote:
>>>
When max() is used in stack array size calculations from literal values
On Fri, Mar 09, 2018 at 06:34:18PM -0800, Alexei Starovoitov wrote:
> On 3/9/18 11:38 AM, Linus Torvalds wrote:
> > On Fri, Mar 9, 2018 at 11:12 AM, Linus Torvalds
> > wrote:
> > >
> > > How are you going to handle five processes doing the same setup
> > > concurrently?
Let's keep in mind we don
check firmware capabilities before setting ethtool
link mode mask, also add few missing speeds.
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c | 24 --
.../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c| 37 ++
2 files changed
Signed-off-by: Roman Mashak
---
tc/f_flower.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/f_flower.c b/tc/f_flower.c
index 5a4ec832bc19..5cf19139dcae 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -1131,7 +1131,7 @@ static void flower_print_ip_attr(char *name, struct
On Sat, Mar 10, 2018 at 03:58:04PM +0800, Xin Long wrote:
> On Sat, Mar 10, 2018 at 6:08 AM, Neil Horman wrote:
> > On Fri, Mar 09, 2018 at 12:59:06PM -0800, syzbot wrote:
> >> Hello,
> >>
> >> syzbot hit the following crash on net-next commit
> >> fd372a7a9e5e9d8011a0222d10edd3523abcd3b1 (Thu Mar
50Gbps is a supported speed, Stop reporting it as
unsupported speed.
Signed-off-by: Ganesh Goudar
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
b/drivers/net/ethernet/chelsio/cxgb4/cxgb4
Now when using 'ss' in iproute, kernel would try to load all _diag
modules, which also causes corresponding family and proto modules
to be loaded as well due to module dependencies.
Like after running 'ss', sctp, dccp, af_packet (if it works as a module)
would be loaded.
For example:
$ lsmod|g
On Sat, 10 Mar 2018 09:40:44 +0200
Andreas Christoforou wrote:
> diff --git a/net/ipv6/xfrm6_state.c b/net/ipv6/xfrm6_state.c
> index b15075a..270a53a 100644
> --- a/net/ipv6/xfrm6_state.c
> +++ b/net/ipv6/xfrm6_state.c
> @@ -62,7 +62,7 @@ __xfrm6_sort(void **dst, void **src, int n, int (*cmp)(vo
From: Veerasenareddy Burru
In a scenario where the command queued to firmware get dropped or times
out, MTU change from host will not propagate to firmware. So, it is
required for host driver to wait for response from firmware or timeout
and then return correct status to caller of ndo_change_mtu.
64 matches
Mail list logo
