Re: [PATCH net v2 1/2] Revert "tuntap: add missing xdp flush"

2018-02-21 Thread Sergei Shtylyov
On 2/22/2018 9:24 AM, Jason Wang wrote: This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The reason is we try to batch packets for devmap which causes calling xdp_do_flush() under the process context. Simply disable premmption s/under/in/. Disabling preemption. may not wor

Re: [PATCH net v2 2/2] tuntap: correctly add the missing xdp flush

2018-02-21 Thread Sergei Shtylyov
Hello! On 2/22/2018 9:24 AM, Jason Wang wrote: Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or MSG_MORE is clear. This may lead BUG() since

[PATCH iproute2-next v1] rdma: Add batch command support

2018-02-21 Thread Leon Romanovsky
From: Leon Romanovsky Implement an option (-b) to execute RDMAtool commands from supplied file. This follows the same model as in use for ip and devlink tools, by expecting every new command to be on new line. These commands are expected to be without any -* (e.g. -d, -j, e.t.c) global flags, wh

[PATCH bpf] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-21 Thread Yonghong Song
Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback function") fixed a memory leak and removed unnecessary locks in map_free callback function. Unfortrunately, it introduced a lockdep warning. When lockdep checking is turned on, running tools/testing/selftests/bpf/test_lpm_ma

[PATCH net v2 1/2] Revert "tuntap: add missing xdp flush"

2018-02-21 Thread Jason Wang
This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The reason is we try to batch packets for devmap which causes calling xdp_do_flush() under the process context. Simply disable premmption may not work since process may move among processors which lead xdp_do_flush() to miss some flushes

[PATCH net v2 2/2] tuntap: correctly add the missing xdp flush

2018-02-21 Thread Jason Wang
Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or MSG_MORE is clear. This may lead BUG() since xdp_do_flush() was called under process context wi

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-21 Thread Bo YU
Hi, On Wed, Feb 21, 2018 at 04:41:05PM +0100, Jason A. Donenfeld wrote: Fixes: 41c87425a1ac ("netlink: do not set cb_running if dump's start() errs") I think you Would better to resend it. Bo,

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

2018-02-21 Thread Jason Wang
On 2018年02月21日 00:52, John Fastabend wrote: On 02/20/2018 03:17 AM, Jesper Dangaard Brouer wrote: On Fri, 16 Feb 2018 09:19:02 -0800 John Fastabend wrote: On 02/16/2018 07:41 AM, Jesper Dangaard Brouer wrote: On Fri, 16 Feb 2018 13:31:37 +0800 Jason Wang wrote: On 2018年02月16日 06:43,

[PATCH iproute2 net-next] ss: print skmeminfo for packet sockets

2018-02-21 Thread Roopa Prabhu
From: Roopa Prabhu before: $ss --packet -p -m p_raw0 0*:eth0 users:(("lldpd",pid=2240,fd=11)) after: $ss --packet -p -m p_raw0 0*:eth0 users:(("lldpd",pid=2240,fd=11)) skmem:(r0,rb2662

F.LLI PISTOLESI Snc

2018-02-21 Thread . F.LLI PISTOLESI Snc
Hello , I am looking for a reliable supplier /manufacturer of products for sell in Europe. I came across your listing and wanted to get some information regarding minimum Order Quantities, FOB pricing and also the possibility of packaging including payments terms. So could you please get

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Alexei Starovoitov
On Wed, Feb 21, 2018 at 07:53:22PM -0800, Eric Dumazet wrote: > > So what kinda comment there would make sense? > > I was thinking of something very explicit : > > /* byte sequence for following assembly code used by eBPF >call ... >... >retq > */ > #define RETPOLINE_RAX_DIRECT_FOR_EB

Re: [PATCH bpf v2] bpf: fix memory leak in lpm_trie map_free callback function

2018-02-21 Thread Yonghong Song
On 2/21/18 7:40 PM, Eric Dumazet wrote: On Tue, 2018-02-13 at 19:17 -0800, Alexei Starovoitov wrote: On Tue, Feb 13, 2018 at 07:00:21PM -0800, Yonghong Song wrote: There is a memory leak happening in lpm_trie map_free callback function trie_free. The trie structure itself does not get freed.

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Eric Dumazet
On Wed, 2018-02-21 at 19:43 -0800, Alexei Starovoitov wrote: > On Wed, Feb 21, 2018 at 07:04:02PM -0800, Eric Dumazet wrote: > > On Thu, 2018-02-22 at 01:05 +0100, Daniel Borkmann wrote: > > > > ... > > > > > +/* Instead of plain jmp %rax, we emit a retpoline to control > > > + * speculative exec

[PATCH net-next 3/3] nfp: advertise firmware for mixed 10G/25G mode

2018-02-21 Thread Jakub Kicinski
From: Dirk van der Merwe The AMDA0099-0001 platform can support the 1x10G + 1x25G mixed mode operation. Recently, firmware has been added for this configuration mode. Signed-off-by: Dirk van der Merwe Acked-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 1 + 1 file cha

[PATCH net-next 2/3] aquantia: add Makefiles to all directories

2018-02-21 Thread Jakub Kicinski
To be able to build separate objects we need to provide Kbuild with a Makefile in each directory. Signed-off-by: Jakub Kicinski --- CC: Igor Russkikh drivers/net/ethernet/aquantia/atlantic/hw_atl/Makefile | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 drivers/net/ethernet/aquantia

[PATCH net-next] ibmvnic: Split counters for scrq/pools/napi

2018-02-21 Thread Nathan Fontenot
The approach of one counter to rule them all when tracking the number of active sub-crqs, pools, and napi has problems handling some failover scenarios. This is due to the split in initializing the sub crqs, pools and napi in different places and the placement of updating the active counts. This p

[PATCH net-next 0/3] nfp: build and FW initramfs updates

2018-02-21 Thread Jakub Kicinski
Hi! This set brings empty makefiles to allow building single object files (useful for build-testing), Kbuild does not cater to this use case too well. There are two ethernet drivers right now which suffer from this (nfp, aquantia), both are fixed. Dirk adds an uncommon FW image name to the list

[PATCH net-next 1/3] nfp: add Makefiles to all directories

2018-02-21 Thread Jakub Kicinski
To be able to build separate objects we need to provide Kbuild with a Makefile in each directory. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/bpf/Makefile | 2 ++ drivers/net/ethernet/netronome/nfp/flower/Makefile | 2 ++ drivers/net/ethernet/netrono

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Alexei Starovoitov
On Wed, Feb 21, 2018 at 07:04:02PM -0800, Eric Dumazet wrote: > On Thu, 2018-02-22 at 01:05 +0100, Daniel Borkmann wrote: > > ... > > > +/* Instead of plain jmp %rax, we emit a retpoline to control > > + * speculative execution for the indirect branch. > > + */ > > +static void emit_retpoline_rax

Re: [PATCH bpf v2] bpf: fix memory leak in lpm_trie map_free callback function

2018-02-21 Thread Eric Dumazet
On Tue, 2018-02-13 at 19:17 -0800, Alexei Starovoitov wrote: > On Tue, Feb 13, 2018 at 07:00:21PM -0800, Yonghong Song wrote: > > There is a memory leak happening in lpm_trie map_free callback > > function trie_free. The trie structure itself does not get freed. > > > > Also, trie_free function di

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Samudrala, Sridhar
On 2/21/2018 6:35 PM, Samudrala, Sridhar wrote: On 2/21/2018 5:59 PM, Siwei Liu wrote: On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck wrote: On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: I haven't checked emails for days and did not realize the new revision had already came out. And th

Re: [RFC net PATCH] virtio_net: disable XDP_REDIRECT in receive_mergeable() case

2018-02-21 Thread Jason Wang
On 2018年02月16日 23:41, Jesper Dangaard Brouer wrote: On Fri, 16 Feb 2018 13:31:37 +0800 Jason Wang wrote: On 2018年02月16日 06:43, Jesper Dangaard Brouer wrote: The virtio_net code have three different RX code-paths in receive_buf(). Two of these code paths can handle XDP, but one of them is br

[PATCH iproute2] README: re-add updated information link

2018-02-21 Thread Jakub Kicinski
From: Quentin Monnet The "Information" link was removed from README file in commit d7843207e6fd ("README: update location of git repositories, remove broken info link"), because it redirected to a page that no longer existed on the Linux Foundation wiki. This page has just been restored, so we c

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Eric Dumazet
On Thu, 2018-02-22 at 01:05 +0100, Daniel Borkmann wrote: ... > +/* Instead of plain jmp %rax, we emit a retpoline to control > + * speculative execution for the indirect branch. > + */ > +static void emit_retpoline_rax_trampoline(u8 **pprog) > +{ > + u8 *prog = *pprog; > + int cnt = 0; >

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-21 Thread Andrew Lunn
> +static void lan743x_intr_unregister_isr(struct lan743x_adapter *adapter, > + int vector_index) > +{ > + struct lan743x_vector *vector = &adapter->intr.vector_list > + [vector_index]; > + > + devm_free_irq(&adapter->p

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Samudrala, Sridhar
On 2/21/2018 5:59 PM, Siwei Liu wrote: On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck wrote: On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: I haven't checked emails for days and did not realize the new revision had already came out. And thank you for the effort, this revision really look

[PATCH v2] selftests/bpf/test_maps: exit child process without error in ENOMEM case

2018-02-21 Thread Li Zhijian
From: Li Zhijian test_maps contains a series of stress tests, and previously it will break the rest tests when it failed to alloc memory. --- Failed to create hashmap key=8 value=262144 'Cannot allocate memory' Failed to create hashmap key=16 value=262144 'Cannot allocate memo

[PATCH iproute2] ip: Properly display AF_BRIDGE address information for neighbor events

2018-02-21 Thread Donald Sharp
The vxlan driver when a neighbor add/delete event occurs sends NDA_DST filled with a union: union vxlan_addr { struct sockaddr_in sin; struct sockaddr_in6 sin6; struct sockaddr sa; }; This eventually calls rt_addr_n2a_r which had no handler for the AF_BRIDGE family and "??

Re: ss issue on arm not showing UDP listening ports

2018-02-21 Thread Jesse Cooper
Thank you for the suggestions. This is on a raspberry pi 3 not sure if that fact matters. I will notify Raspbian of the issue. On 02/21/2018 03:03 PM, Stefano Brivio wrote: > On Wed, 21 Feb 2018 12:37:31 -0500 > jesse_coo...@codeholics.com wrote: > >> ss utility, iproute2-ss161212 > > Works for

nft/bpf interpreters and spectre2. Was: [PATCH RFC 0/4] net: add bpfilter

2018-02-21 Thread Alexei Starovoitov
On Wed, Feb 21, 2018 at 01:13:03PM +0100, Florian Westphal wrote: > > Obvious candidates are: meta, numgen, limit, objref, quota, reject. > > We should probably also consider removing > CONFIG_NFT_SET_RBTREE and CONFIG_NFT_SET_HASH and just always > build both too (at least rbtree since that offe

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Samudrala, Sridhar
On 2/21/2018 6:02 PM, Jakub Kicinski wrote: On Wed, 21 Feb 2018 12:57:09 -0800, Alexander Duyck wrote: I don't see why the team cannot be there always. It is more the logistical nightmare. Part of the goal here was to work with the cloud base images that are out there such as https://alt.fedora

[PATCH v2 iproute2-next 1/3] ip: Use the `struct fib_rule_hdr` for rules

2018-02-21 Thread Donald Sharp
The iprule.c code was using `struct rtmsg` as the data type to pass into the kernel for the netlink message. While 'struct rtmsg' and `struct fib_rule_hdr` are the same size and mostly the same, we should use the correct data structure. This commit translates the data structures to have iprule.c u

[PATCH v2 iproute2-next 2/3] ip: Display ip rule protocol used

2018-02-21 Thread Donald Sharp
Modify 'ip rule' command to notice when the kernel passes to us the originating protocol. Add code to allow the `ip rule flush protocol XXX` command to be accepted and properly handled. Modify the documentation to reflect these code changes. Signed-off-by: Donald Sharp --- ip/iprule.c|

[PATCH v2 iproute2-next 0/3] Allow 'ip rule' command to use protocol

2018-02-21 Thread Donald Sharp
Fix iprule.c to use the actual `struct fib_rule_hdr` and to allow the end user to see and use the protocol keyword for rule manipulations. v2: Rearrange and code changes as per David Ahern Donald Sharp (3): ip: Use the `struct fib_rule_hdr` for rules ip: Display ip rule protocol used ip: Al

[PATCH v2 iproute2-next 3/3] ip: Allow rules to accept a specified protocol

2018-02-21 Thread Donald Sharp
Allow the specification of a protocol when the user adds/modifies/deletes a rule. Signed-off-by: Donald Sharp --- ip/iprule.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ip/iprule.c b/ip/iprule.c index 39008768..192fe215 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -683,6 +683,12

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Jakub Kicinski
On Wed, 21 Feb 2018 12:57:09 -0800, Alexander Duyck wrote: > > I don't see why the team cannot be there always. > > It is more the logistical nightmare. Part of the goal here was to work > with the cloud base images that are out there such as > https://alt.fedoraproject.org/cloud/. With just the

Re: [PATCH RFC PoC 0/3] nftables meets bpf

2018-02-21 Thread Jakub Kicinski
On Wed, 21 Feb 2018 16:30:07 -0800, Florian Fainelli wrote: > On 02/21/2018 03:46 PM, Jakub Kicinski wrote: > > On Tue, 20 Feb 2018 11:58:22 +0100, Pablo Neira Ayuso wrote: > >> We also have a large range of TCAM based hardware offload outthere > >> that will _not_ work with your BPF HW offload i

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Siwei Liu
On Wed, Feb 21, 2018 at 4:17 PM, Alexander Duyck wrote: > On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: >> I haven't checked emails for days and did not realize the new revision >> had already came out. And thank you for the effort, this revision >> really looks to be a step forward towards o

Bug with 'ip' command where build a stuck list of interfaces

2018-02-21 Thread Rm Beer
Hello. With 'ip tunnel add tun0 mode ipip dev enp1s0' make two interfaces called 'tunl0' and 'tun0'. Late with 'ip tunnel del tun0' remove only 'tun0' and forget the 'tunl0' in the list. with this you can not do anything else in the list, it can not be created and it can not be deleted. It is hangi

[PATCH v2 net-next] net: dsa: mv88e6xxx: scratch registers and external MDIO pins

2018-02-21 Thread Andrew Lunn
MV88E6352 and later switches support GPIO control through the "Scratch & Misc" global2 register. Two of the pins controlled this way on the mv88e6390 family are the external MDIO pins. They can either by used as part of the MII interface for port 0, GPIOs, or MDIO. Add a function to configure them

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Daniel Borkmann
On 02/22/2018 01:37 AM, Shuah Khan wrote: > On 02/21/2018 05:33 PM, Daniel Borkmann wrote: >> Hi Shuah, >> >> On 02/22/2018 12:03 AM, Shuah Khan wrote: >>> On 02/21/2018 03:48 PM, David Miller wrote: From: Anders Roxell Date: Wed, 21 Feb 2018 22:30:01 +0100 > bpf builds a test p

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Willem de Bruijn
On Wed, Feb 21, 2018 at 7:26 PM, Sowmini Varadhan wrote: > On (02/21/18 18:45), Willem de Bruijn wrote: >> >> I do mean returning 0 instead of -EAGAIN if control data is ready. >> Something like >> >> @@ -611,7 +611,8 @@ int rds_recvmsg(struct socket *sock, struct msghdr >> *msg, size_t size, >> >

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Shuah Khan
On 02/21/2018 05:33 PM, Daniel Borkmann wrote: > Hi Shuah, > > On 02/22/2018 12:03 AM, Shuah Khan wrote: >> On 02/21/2018 03:48 PM, David Miller wrote: >>> From: Anders Roxell >>> Date: Wed, 21 Feb 2018 22:30:01 +0100 >>> bpf builds a test program for loading BPF ELF files. Add the executabl

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Daniel Borkmann
Hi Shuah, On 02/22/2018 12:03 AM, Shuah Khan wrote: > On 02/21/2018 03:48 PM, David Miller wrote: >> From: Anders Roxell >> Date: Wed, 21 Feb 2018 22:30:01 +0100 >> >>> bpf builds a test program for loading BPF ELF files. Add the executable >>> to the .gitignore list. >>> >>> Signed-off-by: Ander

Re: [PATCH RFC PoC 0/3] nftables meets bpf

2018-02-21 Thread Florian Fainelli
On 02/21/2018 03:46 PM, Jakub Kicinski wrote: > On Tue, 20 Feb 2018 11:58:22 +0100, Pablo Neira Ayuso wrote: >> We also have a large range of TCAM based hardware offload outthere >> that will _not_ work with your BPF HW offload infrastructure. What >> this bpf infrastructure pushes into the kernel

[PATCH net] ibmvnic: Fix early release of login buffer

2018-02-21 Thread Thomas Falcon
The login buffer is released before the driver can perform sanity checks between resources the driver requested and what firmware will provide. Don't release the login buffer until the sanity check is performed. Fixes: 34f0f4e3f488 ("ibmvnic: Fix login buffer memory leaks") Signed-off-by: Thomas F

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Sowmini Varadhan
On (02/21/18 18:45), Willem de Bruijn wrote: > > I do mean returning 0 instead of -EAGAIN if control data is ready. > Something like > > @@ -611,7 +611,8 @@ int rds_recvmsg(struct socket *sock, struct msghdr > *msg, size_t size, > > if (!rds_next_incoming(rs, &inc)) { >

Re: [PATCH] selftests/bpf: tcpbpf_kern: use in6_* macros from glibc

2018-02-21 Thread Daniel Borkmann
On 02/21/2018 05:51 PM, Anders Roxell wrote: > Both glibc and the kernel have in6_* macros definitions. Build fails > because it picks up wrong in6_* macro from the kernel header and not the > header from glibc. > > Fixes build error below: > clang -I. -I./include/uapi -I../../../include/uapi >

[PATCH net-next] ibmvnic: Fix TX descriptor tracking

2018-02-21 Thread Thomas Falcon
With the recent change, transmissions that only needed one descriptor were being missed. The result is that such packets were tracked as outstanding transmissions but never removed when its completion notification was received. Fixes: ffc385b95adb ("ibmvnic: Keep track of supplementary TX descript

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Alexander Duyck
On Wed, Feb 21, 2018 at 3:50 PM, Siwei Liu wrote: > I haven't checked emails for days and did not realize the new revision > had already came out. And thank you for the effort, this revision > really looks to be a step forward towards our use case and is close to > what we wanted to do. A few ques

Re: [PATCH] bpf: clean up unused-variable warning

2018-02-21 Thread Daniel Borkmann
On 02/20/2018 11:07 PM, Arnd Bergmann wrote: > The only user of this variable is inside of an #ifdef, causing > a warning without CONFIG_INET: > > net/core/filter.c: In function 'bpf_sock_ops_cb_flags_set': > net/core/filter.c:3382:6: error: unused variable 'val' > [-Werror=unused-variable] >

[PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-21 Thread Daniel Borkmann
Implement a retpoline [0] for the BPF tail call JIT'ing that converts the indirect jump via jmp %rax that is used to make the long jump into another JITed BPF image. Since this is subject to speculative execution, we need to control the transient instruction sequence here as well when CONFIG_RETPOL

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Siwei Liu
I haven't checked emails for days and did not realize the new revision had already came out. And thank you for the effort, this revision really looks to be a step forward towards our use case and is close to what we wanted to do. A few questions in line. On Sat, Feb 17, 2018 at 9:12 AM, Alexander

Re: [PATCH RFC PoC 0/3] nftables meets bpf

2018-02-21 Thread Jakub Kicinski
On Tue, 20 Feb 2018 11:58:22 +0100, Pablo Neira Ayuso wrote: > We also have a large range of TCAM based hardware offload outthere > that will _not_ work with your BPF HW offload infrastructure. What > this bpf infrastructure pushes into the kernel is just a blob > expressing things in a very low-le

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Willem de Bruijn
>> Okay. If callers must already handle 0 as a valid return code, then >> it is fine to add another case that does this. >> >> The extra branch in the hot path is still rather unfortunately. Could >> this be integrated in the existing if (nonblock) branch below? > > that's where I first started. it

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Sowmini Varadhan
On (02/21/18 17:50), Willem de Bruijn wrote: > > In the common case no more than one notification will be outstanding, > but with a fixed number of notifications per packet, in edge cases this > list may be long. : > Socket functions block if sk_err is non-zero. See for instance > tcp_sendmsg_l

[PATCH net-next 4/7] net: Rename NETEVENT_MULTIPATH_HASH_UPDATE

2018-02-21 Thread David Ahern
Rename NETEVENT_MULTIPATH_HASH_UPDATE to NETEVENT_IPV4_MPATH_HASH_UPDATE to denote it relates to a change in the IPv4 hash policy. Signed-off-by: David Ahern --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- include/net/netevent.h| 2 +- net/ipv4/s

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Shuah Khan
On 02/21/2018 03:48 PM, David Miller wrote: > From: Anders Roxell > Date: Wed, 21 Feb 2018 22:30:01 +0100 > >> bpf builds a test program for loading BPF ELF files. Add the executable >> to the .gitignore list. >> >> Signed-off-by: Anders Roxell > > Acked-by: David S. Miller > > Thanks. I wi

Proposal

2018-02-21 Thread melisa mehmet
Hello Greetings to you and everyone around you please did you get my previous email regarding my proposal ? please let me know if we can work together on this. Best Reagrds

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Willem de Bruijn
On Wed, Feb 21, 2018 at 5:14 PM, Sowmini Varadhan wrote: > On (02/21/18 16:54), Willem de Bruijn wrote: >> >> I'd put this optimization behind a socket option. > > Yes, that thought occurred to me as well- I think RDS applications > are unlikely to use the error_queue path because, as I mentioned

Re: [PATCH net-next v4 0/2] Remove IPVlan module dependencies on IPv6 and L3 Master dev

2018-02-21 Thread David Miller
From: Matteo Croce Date: Wed, 21 Feb 2018 01:31:12 +0100 > The IPVlan module currently depends on IPv6 and L3 Master dev. > Refactor the code to allow building IPVlan module regardless of the value > of CONFIG_IPV6 as done in other drivers like VxLAN or GENEVE. > Also change the CONFIG_NET_L3_MAS

Re: [PATCH net-next v2 1/1] net: Allow a rule to track originating protocol

2018-02-21 Thread David Miller
From: Donald Sharp Date: Tue, 20 Feb 2018 08:55:58 -0500 > Allow a rule that is being added/deleted/modified or > dumped to contain the originating protocol's id. > > The protocol is handled just like a routes originating > protocol is. This is especially useful because there > is starting to b

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread David Miller
From: Anders Roxell Date: Wed, 21 Feb 2018 22:30:01 +0100 > bpf builds a test program for loading BPF ELF files. Add the executable > to the .gitignore list. > > Signed-off-by: Anders Roxell Acked-by: David S. Miller

[PATCH] net/smc9194: Remove bogus CONFIG_MAC reference

2018-02-21 Thread Finn Thain
AFAIK the only version of smc9194.c with Mac support is the one in the linux-mac68k CVS repo, which never made it to the mainline. Despite that, from v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194 under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55. (See pre-git era "[PATCH

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Sowmini Varadhan
On (02/21/18 16:54), Willem de Bruijn wrote: > > I'd put this optimization behind a socket option. Yes, that thought occurred to me as well- I think RDS applications are unlikely to use the error_queue path because, as I mentioned before, these are heavily request-response based, so you're going

Re: syzcaller patch postings...

2018-02-21 Thread Florian Westphal
David Miller wrote: > I have to mention this now before it gets out of control. > > I would like to ask that syzkaller stop posting the patch it is > testing when it posts to netdev. Same for netfilter-devel. I could not get a reproducer to trigger and asked syzbot to test the patch (great feat

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Willem de Bruijn
On Wed, Feb 21, 2018 at 3:19 PM, Sowmini Varadhan wrote: > This commit is an optimization that builds on top of commit 01883eda72bd > ("rds: support for zcopy completion notification") for PF_RDS sockets. > > Cookies associated with zerocopy completion are passed up on the POLLIN > channel, piggyb

[PATCH v2 net-next 2/2] lan743x: Update MAINTAINERS to include lan743x driver

2018-02-21 Thread Bryan Whitehead
Update MAINTAINERS to include lan743x driver Signed-off-by: Bryan Whitehead --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a7f76e..c340125 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9149,6 +9149,13 @@ F: drivers/net/dsa/micro

Re: [PATCH] rds: send: mark expected switch fall-through in rds_rm_size

2018-02-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 19 Feb 2018 12:10:20 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1465362 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Applied.

syzcaller patch postings...

2018-02-21 Thread David Miller
I have to mention this now before it gets out of control. I would like to ask that syzkaller stop posting the patch it is testing when it posts to netdev. This creates a lot of confusion and I have to manually change the status in patchwork of every patch syzcaller posts in this way. I would su

Re: [PATCH] selftests/bpf: tcpbpf_kern: use in6_* macros from glibc

2018-02-21 Thread Daniel Díaz
On 02/21/2018 10:51 AM, Anders Roxell wrote: > Both glibc and the kernel have in6_* macros definitions. Build fails > because it picks up wrong in6_* macro from the kernel header and not the > header from glibc. > > Fixes build error below: > clang -I. -I./include/uapi -I../../../include/uapi >

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Daniel Díaz
On 02/21/2018 03:30 PM, Anders Roxell wrote: > bpf builds a test program for loading BPF ELF files. Add the executable > to the .gitignore list. > > Signed-off-by: Anders Roxell Tested-by: Daniel Díaz > --- > tools/testing/selftests/bpf/.gitignore | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH 00/19] Netfilter fixes for net

2018-02-21 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 20 Feb 2018 17:38:47 +0100 > The following patchset contains large batch with Netfilter fixes for > your net tree, mostly due to syzbot report fixups and pr_err() > ratelimiting, more specifically, they are: ... > You can pull these changes from: > > git://g

[PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Anders Roxell
bpf builds a test program for loading BPF ELF files. Add the executable to the .gitignore list. Signed-off-by: Anders Roxell --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitig

Possible iputils infrastructure/hosting issue on skbuff.net

2018-02-21 Thread Graph Worlok
http://www.skbuff.net/iputils/ has a list of source tarball releases. All of these releases reference http://www.skbuff.net/iputils/iputils-current.tar.bz2 as the location to obtain the source. This URL 404's, meaning that most linux systems in existence refer to a unavailable URL for the source

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Alexander Duyck
On Wed, Feb 21, 2018 at 11:38 AM, Jiri Pirko wrote: > Wed, Feb 21, 2018 at 06:56:35PM CET, alexander.du...@gmail.com wrote: >>On Wed, Feb 21, 2018 at 8:58 AM, Jiri Pirko wrote: >>> Wed, Feb 21, 2018 at 05:49:49PM CET, alexander.du...@gmail.com wrote: On Wed, Feb 21, 2018 at 8:11 AM, Jiri Pirk

[for-next 1/7] net/mlx5: CQ Database per EQ

2018-02-21 Thread Saeed Mahameed
Before this patch the driver had one CQ database protected via one spinlock, this spinlock is meant to synchronize between CQ adding/removing and CQ IRQ interrupt handling. On a system with large number of CPUs and on a work load that requires lots of interrupts, this global spinlock becomes a ver

[pull request][for-next 0/7] Mellanox, mlx5 shared code updates 2018-02-21

2018-02-21 Thread Saeed Mahameed
Hi Dave & Doug, This series includes shared code updates for mlx5 core driver for both netdev and rdma subsystems. This series should be pulled to both trees so we can continue netdev and rdma specific submissions separately. For more information please see tag log below. P.S. We expect two mor

[for-next 2/7] net/mlx5: Add missing likely/unlikely hints to cq events

2018-02-21 Thread Saeed Mahameed
If a hardware event is targeting a CQ, that CQ should exist. Add unlikely to error handling flows. Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman --- drivers/net/ethernet/mellanox/mlx5/core/cq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ether

[for-next 5/7] net/mlx5: Move CQ completion and event forwarding logic to eq.c

2018-02-21 Thread Saeed Mahameed
Since CQ tree is now per EQ, CQ completion and event forwarding became specific implementation of EQ logic, this patch moves that logic to eq.c and makes those functions static. Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman --- drivers/net/ethernet/mellanox/mlx5/core/cq.c | 45 ---

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Santosh Shilimkar
On 2/21/2018 12:19 PM, Sowmini Varadhan wrote: This commit is an optimization that builds on top of commit 01883eda72bd ("rds: support for zcopy completion notification") for PF_RDS sockets. Cookies associated with zerocopy completion are passed up on the POLLIN channel, piggybacked with data wh

Re: ss issue on arm not showing UDP listening ports

2018-02-21 Thread Stefano Brivio
On Wed, 21 Feb 2018 12:37:31 -0500 jesse_coo...@codeholics.com wrote: > ss utility, iproute2-ss161212 Works for me on iproute2-ss161212 and 4.9.0 kernel on armv7l. Unless somebody on the list has other ideas, I guess you should either try more recent versions, debug it (strace should show a pair

Re: [PATCH V7 2/4] sctp: Add ip option support

2018-02-21 Thread Paul Moore
On February 21, 2018 9:33:51 AM Marcelo Ricardo Leitner wrote: > On Tue, Feb 20, 2018 at 07:15:27PM +, Richard Haines wrote: >> Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 >> and CALIPSO/IPv6 services. >> >> Signed-off-by: Richard Haines > > LGTM too, thanks! >

[PATCH v2 net-next 0/2] lan743x: Add new lan743x driver

2018-02-21 Thread Bryan Whitehead
Add new lan743x driver. The lan743x from Microchip Technologies Inc, is a PCIe to Gigabit Ethernet Controller. Bryan Whitehead (2): lan743x: Add main source files for new lan743x driver lan743x: Update MAINTAINERS to include lan743x driver MAINTAINERS |

Re: Qualcomm rmnet driver and qmi_wwan

2018-02-21 Thread Subash Abhinov Kasiviswanathan
On 2018-02-21 04:38, Daniele Palmas wrote: Hello, in rmnet kernel documentation I read: "This driver can be used to register onto any physical network device in IP mode. Physical transports include USB, HSIC, PCIe and IP accelerator." Does this mean that it can be used in association with t

[for-next 6/7] net/mlx5: Remove redundant EQ API exports

2018-02-21 Thread Saeed Mahameed
EQ structure and API is private to mlx5_core driver only, external drivers should not have access or the means to manipulate EQ objects. Remove redundant exports and move API functions out of the linux/mlx5 include directory into the driver's mlx5_core.h private include file. Signed-off-by: Saeed

Re: [PATCH net-next,v3] net: sched: add em_ipt ematch for calling xtables matches

2018-02-21 Thread David Miller
From: Eyal Birger Date: Thu, 15 Feb 2018 19:42:43 +0200 > The commit a new tc ematch for using netfilter xtable matches. > > This allows early classification as well as mirroning/redirecting traffic > based on logic implemented in netfilter extensions. > > Current supported use case is classifi

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Guillaume Nault
On Sun, Feb 18, 2018 at 12:01:02PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-16 20:48, Guillaume Nault wrote: > > On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: > > > As far as i can see there is only KASAN triggered again(and server > > > rebooted > > > shortly after t

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Guillaume Nault
On Wed, Feb 21, 2018 at 12:26:51PM +0200, Denys Fedoryshchenko wrote: > It seems even rebuilding seemingly stable version triggering crashes too > (but different ones) Different ones? The trace following your message looks very similar to your first KASAN report. Or are you refering to the lockup y

Re: [PATCH net-next ] ibmvnic: Correct goto target for tx irq initialization failure

2018-02-21 Thread David Miller
From: Nathan Fontenot Date: Tue, 20 Feb 2018 11:04:18 -0600 > When a failure occurs during initialization of the tx sub crq > irqs, we should branch to the cleanup of the tx irqs. The current > code branches to the rx irq cleanup and attempts to cleanup the > rx irqs which have not been initializ

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-21 Thread Ido Schimmel
On Wed, Feb 21, 2018 at 12:41:39PM -0700, David Ahern wrote: > On 2/21/18 12:25 PM, Ido Schimmel wrote: > >> > >> and can talk to the hosts: > >> # ping6 ff02::2%br0 > > > > Can you try ff02::1 ? > > same result. > > > > >> PING ff02::2%br0(ff02::2) 56 data bytes > >> 64 bytes from fe80::7efe:9

Re: [PATCH net] amd-xgbe: Restore PCI interrupt enablement setting on resume

2018-02-21 Thread David Miller
From: Tom Lendacky Date: Tue, 20 Feb 2018 15:22:05 -0600 > After resuming from suspend, the PCI device support must re-enable the > interrupt setting so that interrupts are actually delivered. > > Signed-off-by: Tom Lendacky > --- > > Please queue this patch up to stable releases 4.14 and abov

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-21 Thread David Ahern
On 2/21/18 1:24 PM, Ido Schimmel wrote: >>> Does it matter if you try IPv4 ping or if vlan_filtering is set 1? >>> Unfortunately, I can't reproduce on my switch. >> >> Bring up the hosts and then reboot the switch. At that point I get no >> host to host communication. As soon as I flap the port on

[PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Sowmini Varadhan
This commit is an optimization that builds on top of commit 01883eda72bd ("rds: support for zcopy completion notification") for PF_RDS sockets. Cookies associated with zerocopy completion are passed up on the POLLIN channel, piggybacked with data whereever possible. Such cookies are passed up as a

Re: pull-request: bpf 2018-02-20

2018-02-21 Thread David Miller
From: Daniel Borkmann Date: Tue, 20 Feb 2018 22:08:32 +0100 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Pulled, thanks Daniel.

Re: [PATCH net-next] ipv6: allow userspace to add IFA_F_OPTIMISTIC addresses

2018-02-21 Thread David Miller
From: Sabrina Dubroca Date: Tue, 20 Feb 2018 19:17:17 +0100 > 2018-02-20, 10:25:41 -0700, David Ahern wrote: >> On 2/20/18 9:43 AM, Sabrina Dubroca wrote: >> > According to RFC 4429 (section 3.1), adding new IPv6 addresses as >> > optimistic addresses is acceptable, as long as the implementation

Re: [PATCH net-next 6/7] mlxsw: spectrum_router: Add support for ipv6 hash policy update

2018-02-21 Thread Ido Schimmel
On Wed, Feb 21, 2018 at 10:49:53AM -0800, David Ahern wrote: > Similar to 28678f07f127d ("mlxsw: spectrum_router: Update multipath hash > parameters upon netevents") for IPv4, make sure the kernel and asic are > using the same hash algorithm for path selection. > > Signed-off-by: David Ahern Rev

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Jiri Pirko
Wed, Feb 21, 2018 at 06:56:35PM CET, alexander.du...@gmail.com wrote: >On Wed, Feb 21, 2018 at 8:58 AM, Jiri Pirko wrote: >> Wed, Feb 21, 2018 at 05:49:49PM CET, alexander.du...@gmail.com wrote: >>>On Wed, Feb 21, 2018 at 8:11 AM, Jiri Pirko wrote: Wed, Feb 21, 2018 at 04:56:48PM CET, alexan

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Denys Fedoryshchenko
On 2018-02-21 20:55, Guillaume Nault wrote: On Wed, Feb 21, 2018 at 12:26:51PM +0200, Denys Fedoryshchenko wrote: It seems even rebuilding seemingly stable version triggering crashes too (but different ones) Different ones? The trace following your message looks very similar to your first KASA

Re: [net PATCH 0/4] virtio_net: several bugs in XDP code for driver virtio_net

2018-02-21 Thread David Miller
From: Jesper Dangaard Brouer Date: Tue, 20 Feb 2018 14:31:59 +0100 > The virtio_net driver actually violates the original memory model of > XDP causing hard to debug crashes. Per request of John Fastabend, > instead of removing the XDP feature I'm fixing as much as possible. > While testing virt

  1   2   >