[PATCH iproute2-next 08/10] rdma: Rename free function to be rd_cleanup

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rdma/rdma.c b/rdma/rdma.c index f9f4f2a2..a05a2fb6 100644 --- a/rdma/rdma.c +++ b/rdma/rdma.c @@ -70,7 +70,7 @@ static int rd_init(struct rd *rd, int argc

[PATCH iproute2-next 02/10] rdma: Protect dev_map_lookup from wrong input

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky Despite the fact that all callers to dev_map_lookup are ensuring that there is always device name prior to call to that function, it is better and safer to check that in the dev_map_lookup itself. Fixes: 40df8263a0f0 ("rdma: Add dev object") Signed-off-by: Leon Romanovsky

[PATCH iproute2-next 03/10] rdma: Move per-device handler function to generic code

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky Most of the proposed objects are working in the scope "dev" and will implement the same logic. Move the code to utils.c, so other objects will be able to reuse the code. Signed-off-by: Leon Romanovsky --- rdma/dev.c | 28 +--- rdma/rdma.h | 1 +

[PATCH iproute2-next 07/10] rdma: Get rid of dev_map_free call

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky The dev_map_free() is called once only and it is short, so it is better to integrate it into the caller's site. Signed-off-by: Leon Romanovsky --- rdma/utils.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/rdma/utils.c b/rdma/utils.c in

[PATCH iproute2-next 10/10] rdma: Move link execution logic to common code

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/link.c | 46 +- rdma/rdma.h | 1 + rdma/utils.c | 49 + 3 files changed, 51 insertions(+), 45 deletions(-) diff --git a/rdma/link.c b/rdm

[PATCH iproute2-next 05/10] rdma: Check that port index exists before operate on link layer

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky Link layer operates on port layer, hence it should check it existence before execution commands. Fixes: da990ab40a92 ("rdma: Add link object") Signed-off-by: Leon Romanovsky --- rdma/link.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rdma/link.c b/rdma/link.c i

[PATCH iproute2-next 09/10] rdma: Rename rd_free_devmap to be rd_free

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/rdma.c | 3 +-- rdma/rdma.h | 2 +- rdma/utils.c | 3 ++- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rdma/rdma.c b/rdma/rdma.c index a05a2fb6..0e8fd688 100644 --- a/rdma/rdma.c +++ b/rdma/rdma.c @@ -74,8 +74,7 @

[PATCH iproute2-next 04/10] rdma: Fix misspelled SYS_IMAGE_GUID

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky SYS_IMAGE_GUIG is actually SYS_IMAGE_GUID. Fixes: da990ab40a92 ("rdma: Add link object") Signed-off-by: Leon Romanovsky --- rdma/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rdma/link.c b/rdma/link.c index 3a4b00bd..f0eaccbb 100644 --- a/rdma

[PATCH iproute2-next 00/10] RDMAtool cleanup and refactoring code

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky Hi, The following patchset comes as a preparation to more complex code, which will add resource tracking visibility to the rdmatool, where the kernel part is under review of RDMA community. Thanks [1] https://marc.info/?l=linux-rdma&m=151412508816802&w=2 Leon Romanovsky

[PATCH iproute2-next 06/10] rdma: Print supplied device name in case of wrong name

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky Signed-off-by: Leon Romanovsky --- rdma/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rdma/utils.c b/rdma/utils.c index 5c0f021a..998a178d 100644 --- a/rdma/utils.c +++ b/rdma/utils.c @@ -176,7 +176,7 @@ int rd_exec_dev(struct rd *rd, int (*cb

[PATCH iproute2-next 01/10] rdma: Reduce scope of _dev_map_lookup call

2017-12-26 Thread Leon Romanovsky
From: Leon Romanovsky There is no external users of _dev_map_lookup function, so let's limit its scope to be local. Fixes: 40df8263a0f0 ("rdma: Add dev object") Signed-off-by: Leon Romanovsky --- rdma/rdma.h | 1 - rdma/utils.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --g

[PATCH net-next] cxgb4: use CLIP with LIP6 on T6 for TCAM filters

2017-12-26 Thread Ganesh Goudar
On T6, LIP compression is always enabled for IPv6 and uncompressed IPv6 for LIP is not supported. So, for IPv6 TCAM filters on T6, add LIP6 to CLIP on filter creation, and release the same on filter deletion. Signed-off-by: Kumar Sanghvi Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/che

RE: [PATCH net] bnx2x: Improve reliability in case of nested PCI errors

2017-12-26 Thread Shaikh, Shahed
> -Original Message- > From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com] > Sent: Friday, December 22, 2017 8:32 PM > To: Elior, Ariel ; Dept-Eng Everest Linux L2 engeverestlinu...@cavium.com> > Cc: netdev@vger.kernel.org; gpicc...@linux.vnet.ibm.com; > gpicc...@protonmail.ch

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-26 Thread Masami Hiramatsu
On Tue, 26 Dec 2017 17:57:32 -0800 Alexei Starovoitov wrote: > On Tue, Dec 26, 2017 at 04:46:59PM +0900, Masami Hiramatsu wrote: > > Check whether error injectable event is on function entry or not. > > Currently it checks the event is ftrace-based kprobes or not, > > but that is wrong. It should

[PATCH 3/3] staging: irda: separate multiple assignments

2017-12-26 Thread JI-HUN KIM
Clean up checkpatch warning: CHECK: multiple assignments should be avoided Signed-off-by: JI-HUN KIM --- drivers/staging/irda/drivers/esi-sir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/irda/drivers/esi-sir.c b/drivers/staging/irda/drivers/esi-sir.c i

[PATCH 2/3] staging: irda: add spaces around '|' operator

2017-12-26 Thread JI-HUN KIM
Clean up checkpatch warning: CHECK: spaces preferred around that '|' (ctx:VxV) Signed-off-by: JI-HUN KIM --- drivers/staging/irda/drivers/esi-sir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/irda/drivers/esi-sir.c b/drivers/staging/irda/drivers/esi-sir.c

[PATCH 1/3] staging: irda: fix type from "unsigned" to "unsigned int"

2017-12-26 Thread JI-HUN KIM
Clean up checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: JI-HUN KIM --- drivers/staging/irda/drivers/esi-sir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/irda/drivers/esi-sir.c b/drivers/staging/irda/driver

Re: [PATCH net-next v5 1/6] net: tcp: Add trace events for TCP congestion window tracing

2017-12-26 Thread Masami Hiramatsu
On Tue, 26 Dec 2017 18:51:55 -0500 (EST) David Miller wrote: > From: Masami Hiramatsu > Date: Fri, 22 Dec 2017 11:05:33 +0900 > > > This adds an event to trace TCP stat variables with > > slightly intrusive trace-event. This uses ftrace/perf > > event log buffer to trace those state, no needs t

Re: [PATCH net-next v2] net: sched: fix skb leak in dev_requeue_skb()

2017-12-26 Thread John Fastabend
On 12/24/2017 07:49 PM, Wei Yongjun wrote: > When dev_requeue_skb() is called with bluked skb list, only the > first skb of the list will be requeued to qdisc layer, and leak > the others without free them. > > TCP is broken due to skb leak since no free skb will be considered > as still in the ho

Re: BUG warnings in 4.14.9

2017-12-26 Thread alexander . levin
On Tue, Dec 26, 2017 at 10:54:37PM +0200, Ido Schimmel wrote: >On Tue, Dec 26, 2017 at 07:59:55PM +0100, Willy Tarreau wrote: >> Guys, >> >> Chris reported the bug below and confirmed that reverting commit >> 9704f81 (ipv6: grab rt->rt6i_ref before allocating pcpu rt) seems to >> have fixed the iss

Re: [patch net-next v2 00/10] Add support for resource abstraction

2017-12-26 Thread David Ahern
On 12/26/17 5:23 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Many of the ASIC's internal resources are limited and are shared between > several hardware procedures. For example, unified hash-based memory can > be used for many lookup purposes, like FDB and LPM. In many cases the user > can provi

Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-26 Thread Alexei Starovoitov
On Fri, Dec 22, 2017 at 06:50:01PM +, Quentin Monnet wrote: > Hi Roman, > > 2017-12-22 16:11 UTC+ ~ Roman Gushchin > > Bpftool build is broken with binutils version 2.28 and later. > > Could you check the binutils version? I believe it changed in 2.29 > instead of 2.28. Could you update

[PATCH net-next 04/10] net: qualcomm: rmnet: Rename ingress data format to data format

2017-12-26 Thread Subash Abhinov Kasiviswanathan
This is done so that we can use this field for both ingress and egress flags. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 10 +- drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 2 +- drivers/net/ethernet/qualcomm/rmnet/

[PATCH net-next 05/10] net: qualcomm: rmnet: Set pacing rate

2017-12-26 Thread Subash Abhinov Kasiviswanathan
With a default pacing rate of 10, the uplink data rate for a single TCP stream is around 10Mbps. Setting it to 8 increases it to 146Mbps which is the maximum supported transmit rate. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 3 +++ 1

[PATCH net-next 01/10] net: qualcomm: rmnet: Remove redundant check when stamping map header

2017-12-26 Thread Subash Abhinov Kasiviswanathan
We already check the headroom once in rmnet_map_egress_handler(), so this is not needed. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data

[PATCH net-next 10/10] net: qualcomm: rmnet: Add support for GSO

2017-12-26 Thread Subash Abhinov Kasiviswanathan
Real devices may support scatter gather(SG), so enable SG on rmnet devices to use GSO. GSO reduces CPU cycles by 20% for a rate of 146Mpbs for a single stream TCP connection. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 1 + 1 file changed,

[PATCH net-next 03/10] net: qualcomm: rmnet: Remove unused function declaration

2017-12-26 Thread Subash Abhinov Kasiviswanathan
rmnet_map_demultiplex() is only declared but not defined anywhere, so remove it. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h b/drivers/net/eth

[PATCH net-next 02/10] net: qualcomm: rmnet: Remove invalid condition while stamping mux id

2017-12-26 Thread Subash Abhinov Kasiviswanathan
rmnet devices cannot have a mux id of 255. This is validated when assigning the mux id to the rmnet devices. As a result, checking for mux id 255 does not apply in egress path. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 5 + 1 fil

[PATCH net-next 00/10] net: qualcomm: rmnet: Enable csum offloads

2017-12-26 Thread Subash Abhinov Kasiviswanathan
This series introduces the MAPv4 packet format for checksum offload plus some other minor changes. Patches 1-3 are cleanups. Patch 4 renames the ingress format to data format so that all data formats can be configured using this going forward. Patch 5 uses the pacing helper to improve TCP transm

[PATCH net-next 06/10] net: qualcomm: rmnet: Define the MAPv4 packet formats

2017-12-26 Thread Subash Abhinov Kasiviswanathan
The MAPv4 packet format adds support for RX / TX checksum offload. For a bi-directional UDP stream at a rate of 570 / 146 Mbps, roughly 10% CPU cycles are saved. For receive path, there is a checksum trailer appended to the end of the MAP packet. The valid field indicates if hardware has computed

[PATCH net-next 07/10] net: qualcomm: rmnet: Add support for RX checksum offload

2017-12-26 Thread Subash Abhinov Kasiviswanathan
When using the MAPv4 packet format, receive checksum offload can be enabled in hardware. The checksum computation over pseudo header is not offloaded but the rest of the checksum computation over the payload is offloaded. This applies only for TCP / UDP packets which are not fragmented. rmnet vali

[PATCH net-next 08/10] net: qualcomm: rmnet: Handle command packets with checksum trailer

2017-12-26 Thread Subash Abhinov Kasiviswanathan
When using the MAPv4 packet format in conjunction with MAP commands, a dummy DL checksum trailer will be appended to the packet. Before this packet is sent out as an ACK, the DL checksum trailer needs to be removed. Signed-off-by: Subash Abhinov Kasiviswanathan --- drivers/net/ethernet/qualcomm/

[PATCH net-next 09/10] net: qualcomm: rmnet: Add support for TX checksum offload

2017-12-26 Thread Subash Abhinov Kasiviswanathan
TX checksum offload applies to TCP / UDP packets which are not fragmented using the MAPv4 checksum header. The following needs to be done to have checksum computed in hardware - 1. Set the checksum start offset and inset offset. 2. Set the csum_enabled bit 3. Compute and set 1's complement of part

Re: [PATCH bpf-next 2/3] libbpf: add error reporting in XDP

2017-12-26 Thread Alexei Starovoitov
On Mon, Dec 25, 2017 at 11:13:24PM +0100, Eric Leblond wrote: > Parse netlink ext attribute to get the error message returned by > the card. > > Signed-off-by: Eric Leblond ... > diff --git a/tools/lib/bpf/nlattr.c b/tools/lib/bpf/nlattr.c > new file mode 100644 > index ..962de14f74e3

Re: [RFC PATCH bpf-next v2 4/4] error-injection: Support fault injection framework

2017-12-26 Thread Alexei Starovoitov
On Tue, Dec 26, 2017 at 04:48:25PM +0900, Masami Hiramatsu wrote: > Support in-kernel fault-injection framework via debugfs. > This allows you to inject a conditional error to specified > function using debugfs interfaces. > > Signed-off-by: Masami Hiramatsu > --- > Documentation/fault-injection

Re: [RFC PATCH bpf-next v2 3/4] error-injection: Separate error-injection from kprobe

2017-12-26 Thread Alexei Starovoitov
On Tue, Dec 26, 2017 at 04:47:55PM +0900, Masami Hiramatsu wrote: > Since error-injection framework is not limited to be used > by kprobes, nor bpf. Other kernel subsystems can use it > freely for checking safeness of error-injection, e.g. > livepatch, ftrace etc. > So this separate error-injection

Re: [PATCH net-next v8 1/2] dt-bindings: net: add DT bindings for Socionext UniPhier AVE

2017-12-26 Thread Masahiro Yamada
2017-12-25 10:10 GMT+09:00 Kunihiko Hayashi : > DT bindings for the AVE ethernet controller found on Socionext's > UniPhier platforms. > > Signed-off-by: Kunihiko Hayashi > Signed-off-by: Jassi Brar > Acked-by: Rob Herring > --- > .../bindings/net/socionext,uniphier-ave4.txt | 47 > +

Re: [RFC PATCH bpf-next v2 2/4] tracing/kprobe: bpf: Compare instruction pointer with original one

2017-12-26 Thread Alexei Starovoitov
On Tue, Dec 26, 2017 at 04:47:26PM +0900, Masami Hiramatsu wrote: > Compare instruction pointer with original one on the > stack instead using per-cpu bpf_kprobe_override flag. > > This patch also consolidates reset_current_kprobe() and > preempt_enable_no_resched() blocks. Those can be done > in

Re: [RFC PATCH bpf-next v2 1/4] tracing/kprobe: bpf: Check error injectable event is on function entry

2017-12-26 Thread Alexei Starovoitov
On Tue, Dec 26, 2017 at 04:46:59PM +0900, Masami Hiramatsu wrote: > Check whether error injectable event is on function entry or not. > Currently it checks the event is ftrace-based kprobes or not, > but that is wrong. It should check if the event is on the entry > of target function. Since error i

RE: [PATCH net,stable 1/1] net: fec: unmap the xmit buffer that are not transferred by DMA

2017-12-26 Thread Andy Duan
From: Fugang Duan Sent: Friday, December 22, 2017 5:12 PM >The enet IP only support 32 bit, it will use swiotlb buffer to do dma mapping >when xmit buffer DMA memory address is bigger than 4G in i.MX platform. >After stress suspend/resume test, it will print out: > >log: >[12826.352864] fec 5b0400

Re: [RFC PATCH v12 0/5] PCI: rockchip: Move PCIe WAKE# handling into pci core

2017-12-26 Thread Rafael J. Wysocki
On Tuesday, December 26, 2017 3:36:41 AM CET Jeffy Chen wrote: > > Currently we are handling wake irq in mrvl wifi driver. Move it into > pci core. > > Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi). > > > Changes in v13: > Fix compiler error reported by kbuild test robot > >

Re: [PATCH net-next v5 1/6] net: tcp: Add trace events for TCP congestion window tracing

2017-12-26 Thread David Miller
From: Masami Hiramatsu Date: Fri, 22 Dec 2017 11:05:33 +0900 > This adds an event to trace TCP stat variables with > slightly intrusive trace-event. This uses ftrace/perf > event log buffer to trace those state, no needs to > prepare own ring-buffer, nor custom user apps. > > User can use ftrace

Re: [PATCH v5 net-next 0/7] net: ILA notification mechanism and fixes

2017-12-26 Thread Tom Herbert
On Tue, Dec 26, 2017 at 2:29 PM, David Miller wrote: > From: Tom Herbert > Date: Thu, 21 Dec 2017 11:33:25 -0800 > >> This patch set adds support to get netlink notifications for ILA >> routes when a route is used. >> >> This patch set contains: >> >> - General infrastructure for route notificati

Re: [PATCH] hv_netvsc: update VF after name has changed.

2017-12-26 Thread Stephen Hemminger
On Tue, 26 Dec 2017 17:11:19 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Tue, 26 Dec 2017 13:51:43 -0800 > > > On Tue, 26 Dec 2017 12:25:12 -0500 (EST) > > David Miller wrote: > > > >> From: Stephen Hemminger > >> Date: Wed, 20 Dec 2017 14:33:23 -0800 > >> > >> > S

Re: [PATCH v2 bpf-next 10/11] bpf: Add BPF_SOCK_OPS_STATE_CB

2017-12-26 Thread Alexei Starovoitov
On Thu, Dec 21, 2017 at 05:21:00PM -0800, Lawrence Brakmo wrote: > Adds support for calling sock_ops BPF program when there is a TCP state > change. Two arguments are used; one for the old state and another for > the new state. > > New op: BPF_SOCK_OPS_STATE_CB. > > Signed-off-by: Lawrence Brakmo

[PATCH net] phylink: ensure we report link down when LOS asserted

2017-12-26 Thread Russell King
Although we disable the netdev carrier, we fail to report in the kernel log that the link went down. Fix this. Signed-off-by: Russell King --- drivers/net/phy/phylink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c in

[PATCH net] sfp: fix sfp-bus oops when removing socket/upstream

2017-12-26 Thread Russell King
When we remove a socket or upstream, and the other side isn't registered, we dereference a NULL pointer, causing a kernel oops. Fix this. Signed-off-by: Russell King --- drivers/net/phy/sfp-bus.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/sfp-bus.c

Re: BUG warnings in 4.14.9

2017-12-26 Thread alexander . levin
On Tue, Dec 26, 2017 at 07:59:55PM +0100, Willy Tarreau wrote: >Guys, > >Chris reported the bug below and confirmed that reverting commit >9704f81 (ipv6: grab rt->rt6i_ref before allocating pcpu rt) seems to >have fixed the issue for him. This patch is a94b9367 in mainline. > >I personally have no

Re: [PATCHv4 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-12-26 Thread Rob Herring
On Fri, Dec 22, 2017 at 11:45 PM, wrote: > From: Jassi Brar > > This patch adds documentation for Device-Tree bindings for the > Socionext NetSec Controller driver. > > Signed-off-by: Jassi Brar > Signed-off-by: Ard Biesheuvel > --- > .../devicetree/bindings/net/socionext-netsec.txt | 55 >

Re: [PATCHv2 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-12-26 Thread Rob Herring
On Wed, Dec 20, 2017 at 2:02 AM, Jassi Brar wrote: > Hi Mark, > > On Tue, Dec 12, 2017 at 10:59 PM, Mark Rutland wrote: >> Hi, >> >> On Tue, Dec 12, 2017 at 10:45:21PM +0530, jassisinghb...@gmail.com wrote: >>> From: Jassi Brar >>> >>> This patch adds documentation for Device-Tree bindings for t

Re: [PATCH] tcp: make function tcp_recv_timestamp static

2017-12-26 Thread David Miller
From: Colin King Date: Fri, 22 Dec 2017 01:01:35 + > From: Colin Ian King > > The function tcp_recv_timestamp is local to the source and does not > need to be in global scope, so make it static. > > Cleans up sparse warning: > symbol 'tcp_recv_timestamp' was not declared. Should it be stat

Re: [PATCH bpf-next v2 6/8] bpf: offload: report device information for offloaded programs

2017-12-26 Thread Alexei Starovoitov
On Thu, Dec 21, 2017 at 01:01:18PM -0800, Jakub Kicinski wrote: > Report to the user ifindex and namespace information of offloaded > programs. If device has disappeared return -ENODEV. Specify the > namespace using dev/inode combination. > > CC: Eric W. Biederman > Signed-off-by: Jakub Kicinsk

Re: [PATCH net-next] net: erspan: remove md NULL check

2017-12-26 Thread David Miller
From: William Tu Date: Thu, 21 Dec 2017 15:51:22 -0800 > The 'md' is allocated from 'tun_dst = ip_tun_rx_dst' and > since we've checked 'tun_dst', 'md' will never be NULL. > The patch removes it at both ipv4 and ipv6 erspan. > > Fixes: afb4c97d90e6 ("ip6_gre: fix potential memory leak in ip6ersp

Re: [PATCH v5 net-next 0/7] net: ILA notification mechanism and fixes

2017-12-26 Thread David Miller
From: Tom Herbert Date: Thu, 21 Dec 2017 11:33:25 -0800 > This patch set adds support to get netlink notifications for ILA > routes when a route is used. > > This patch set contains: > > - General infrastructure for route notifications > - The ILA route notification mechanism > - Add net to il

Re: [PATCH net] tcp: Avoid preprocessor directives in tracepoint macro args

2017-12-26 Thread David Miller
From: Mat Martineau Date: Thu, 21 Dec 2017 10:29:09 -0800 > Using a preprocessor directive to check for CONFIG_IPV6 in the middle of > a DECLARE_EVENT_CLASS macro's arg list causes sparse to report a series > of errors: > > ./include/trace/events/tcp.h:68:1: error: directive in argument list > .

Re: [PATCH net-next] tcp: md5: Handle RCU dereference of md5sig_info

2017-12-26 Thread David Miller
From: Mat Martineau Date: Thu, 21 Dec 2017 10:29:10 -0800 > Dereference tp->md5sig_info in tcp_v4_destroy_sock() the same way it is > done in the adjacent call to tcp_clear_md5_list(). > > Resolves this sparse warning: > > net/ipv4/tcp_ipv4.c:1914:17: warning: incorrect type in argument 1 (diff

Re: [PATCH v2 net-next] net: dsa: lan9303: lan9303_csr_reg_wait cleanups

2017-12-26 Thread David Miller
From: Egil Hjelmeland Date: Thu, 21 Dec 2017 18:34:35 +0100 > Non-functional cleanups in lan9303_csr_reg_wait(): > - Change type of param 'mask' from int to u32. > - Remove param 'value' (will probably never be used) > - Reduced retries from 1000 to 25, consistent with lan9303_read_wait. > -

Re: [PATCH net-next v2] xen-netback: make copy batch size configurable

2017-12-26 Thread David Miller
From: Joao Martins Date: Thu, 21 Dec 2017 17:24:28 + > Commit eb1723a29b9a ("xen-netback: refactor guest rx") refactored Rx > handling and as a result decreased max grant copy ops from 4352 to 64. > Before this commit it would drain the rx_queue (while there are > enough slots in the ring to

Re: [PATCH] hv_netvsc: update VF after name has changed.

2017-12-26 Thread David Miller
From: Stephen Hemminger Date: Tue, 26 Dec 2017 13:51:43 -0800 > On Tue, 26 Dec 2017 12:25:12 -0500 (EST) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Wed, 20 Dec 2017 14:33:23 -0800 >> >> > Since commit 6123c66854c1 ("netvsc: delay setup of VF device") >> > the automatic bring

Re: [PATCH] hv_netvsc: update VF after name has changed.

2017-12-26 Thread Stephen Hemminger
On Tue, 26 Dec 2017 12:25:12 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Wed, 20 Dec 2017 14:33:23 -0800 > > > Since commit 6123c66854c1 ("netvsc: delay setup of VF device") > > the automatic bring up of the VF is delayed to allow userspace (udev) > > a chance to rename th

Re: BUG warnings in 4.14.9

2017-12-26 Thread Ido Schimmel
On Tue, Dec 26, 2017 at 07:59:55PM +0100, Willy Tarreau wrote: > Guys, > > Chris reported the bug below and confirmed that reverting commit > 9704f81 (ipv6: grab rt->rt6i_ref before allocating pcpu rt) seems to > have fixed the issue for him. This patch is a94b9367 in mainline. > > I personally h

Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time

2017-12-26 Thread Bjorn Andersson
On Tue 19 Dec 09:04 PST 2017, Colin King wrote: > From: Colin Ian King > > msg_body.min_ch_time is being assigned twice; remove the redundant > first assignment. > > Detected by CoverityScan, CID#1463042 ("Unused Value") > Happy to see Coverity working for us :) This should have had a: Fix

Re: [PATCH V2 net-next] selftests/net: fix bugs in address and port initialization

2017-12-26 Thread Willem de Bruijn
On Mon, Dec 25, 2017 at 5:43 PM, Sowmini Varadhan wrote: > Address/port initialization should work correctly regardless > of the order in which command line arguments are supplied, > E.g, cfg_port should be used to connect to the remote host > even if it is processed after -D, src/dst address init

Re: [PATCHv3 1/3] dt-bindings: net: Add DT bindings for Socionext Netsec

2017-12-26 Thread Florian Fainelli
On 12/21/2017 05:55 AM, Andrew Lunn wrote: >> +- mdio device tree subnode: When the Netsec has a phy connected to its local >> +mdio, there must be device tree subnode with the following >> +required properties: >> + >> +- compatible: Must be "socionext,snq-mdio". > > I

[PATCH net-next] selftests: rtnetlink: add erspan and ip6erspan

2017-12-26 Thread William Tu
Add test cases for ipv4, ipv6 erspan, v1 and v2 native mode and external (collect metadata) mode. Signed-off-by: William Tu --- tools/testing/selftests/net/rtnetlink.sh | 131 +++ 1 file changed, 131 insertions(+) diff --git a/tools/testing/selftests/net/rtnetlink.sh

Re: BUG warnings in 4.14.9

2017-12-26 Thread Willy Tarreau
Guys, Chris reported the bug below and confirmed that reverting commit 9704f81 (ipv6: grab rt->rt6i_ref before allocating pcpu rt) seems to have fixed the issue for him. This patch is a94b9367 in mainline. I personally have no opinion on the patch, just found it because it was the only one touchi

[PATCH v3 net-next 4/4] qed*: Advance drivers' version to 8.33.0.20

2017-12-26 Thread Tomer Tayar
Signed-off-by: Ariel Elior Signed-off-by: Chad Dupuis Signed-off-by: Manish Rangankar Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 8 drivers/net/ethernet/qlogic/qede/qede.h | 6 +++--- drivers/scsi/qedf/qedf_version.h| 8 drivers/scsi/qedi

[PATCH v3 net-next 0/4] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread Tomer Tayar
This series advances all qed* drivers to use firmware 8.33.1.0 which brings new capabilities and initial support of new HW. The changes are mostly in qed, and include changes in the FW interface files, as well as updating the FW initialization and debug collection code. The protocol drivers have mi

[PATCH iproute2 net-next] erspan: add erspan usage description

2017-12-26 Thread William Tu
The patch adds erspan usage description, so 'ip link help erspan' and 'ip link help ip6erspan' shows the options. Signed-off-by: William Tu --- ip/link_gre.c | 4 ip/link_gre6.c | 4 2 files changed, 8 insertions(+) diff --git a/ip/link_gre.c b/ip/link_gre.c index 0b9c71baebaf..65ad8

RE: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread Tayar, Tomer
From: David Miller [mailto:da...@davemloft.net] Sent: Tuesday, December 26, 2017 8:08 PM > Subject: Re: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0 > > > This says "0/3" and then a 4 patch series shows up... Sorry, my bad. Will send a fixed series.

Re: [PATCH] wl1251: check return from call to wl1251_acx_arp_ip_filter

2017-12-26 Thread Pavel Machek
On Tue 2017-12-26 17:33:18, Colin King wrote: > From: Colin Ian King > > Currently the less than zero error check on ret is incorrect > as it is checking a far earlier ret assignment rather than the > return from the call to wl1251_acx_arp_ip_filter. Fix this by > adding in the missing assginment

Re: [PATCH net-next v2] enic: add wq clean up budget

2017-12-26 Thread David Miller
From: Govindarajulu Varadarajan Date: Thu, 21 Dec 2017 08:12:28 -0800 > In case of tx clean up, we set '-1' as budget. This means clean up until > wq is empty or till (1 << 32) pkts are cleaned. Under heavy load this > will run for long time and cause > "watchdog: BUG: soft lockup - CPU#25 stuck

Re: [PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread David Miller
This says "0/3" and then a 4 patch series shows up...

Re: [net 1/1] tipc: fix memory leak of group member when peer node is lost

2017-12-26 Thread David Miller
From: Jon Maloy Date: Thu, 21 Dec 2017 14:36:34 +0100 > When a group member receives a member WITHDRAW event, this might have > two reasons: either the peer member is leaving the group, or the link > to the member's node has been lost. > > In the latter case we need to issue a DOWN event to the

Re: [patch net] net: sched: fix possible null pointer deref in tcf_block_put

2017-12-26 Thread David Miller
From: Jiri Pirko Date: Thu, 21 Dec 2017 13:13:59 +0100 > From: Jiri Pirko > > We need to check block for being null in both tcf_block_put and > tcf_block_put_ext. > > Fixes: 343723dd51ef ("net: sched: fix clsact init error path") > Reported-by: Prashant Bhole > Signed-off-by: Jiri Pirko App

Re: [net 1/1] tipc: base group replicast ack counter on number of actual receivers

2017-12-26 Thread David Miller
From: Jon Maloy Date: Thu, 21 Dec 2017 13:07:11 +0100 > In commit 2f487712b893 ("tipc: guarantee that group broadcast doesn't > bypass group unicast") we introduced a mechanism that requires the first > (replicated) broadcast sent after a unicast to be acknowledged by all > receivers before permi

Re: [PATCH net-next v7 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-26 Thread David Miller
From: Kunihiko Hayashi Date: Thu, 21 Dec 2017 20:12:56 +0900 > + writel(AVE_TXDC_ADDR_START > + | (((priv->tx.ndesc * priv->desc_size) << 16) & AVE_TXDC_SIZE), > + priv->base + AVE_TXDC); ... > + writel(AVE_RXDC0_ADDR_START > +| (((priv->rx.ndesc * priv

[PATCH v2 net-next 4/4] qed*: Advance drivers' version to 8.33.0.20

2017-12-26 Thread Tomer Tayar
Signed-off-by: Ariel Elior Signed-off-by: Chad Dupuis Signed-off-by: Manish Rangankar Signed-off-by: Tomer Tayar --- drivers/net/ethernet/qlogic/qed/qed.h | 8 drivers/net/ethernet/qlogic/qede/qede.h | 6 +++--- drivers/scsi/qedf/qedf_version.h| 8 drivers/scsi/qedi

[PATCH v2 net-next 0/3] qed*: Advance to FW 8.33.1.0

2017-12-26 Thread Tomer Tayar
This series advances all qed* drivers to use firmware 8.33.1.0 which brings new capabilities and initial support of new HW. The changes are mostly in qed, and include changes in the FW interface files, as well as updating the FW initialization and debug collection code. The protocol drivers have mi

[PATCH] wl1251: check return from call to wl1251_acx_arp_ip_filter

2017-12-26 Thread Colin King
From: Colin Ian King Currently the less than zero error check on ret is incorrect as it is checking a far earlier ret assignment rather than the return from the call to wl1251_acx_arp_ip_filter. Fix this by adding in the missing assginment. Detected by CoverityScan, CID#1164835 ("Logically dead

Re: [PATCH net-next] rtnetlink: Replace implementation of ASSERT_RTNL() macro with WARN_ONCE()

2017-12-26 Thread David Miller
From: Leon Romanovsky Date: Thu, 21 Dec 2017 11:40:04 +0200 > From: Leon Romanovsky > > ASSERT_RTNL() macro is actual open-coded variant of WARN_ONCE() with > two exceptions. First, it prints stack for multiple hits and not only > once as WARN_ONCE() does. Second, the user can disable prints of

Re: [Patch net] net_sched: fix a missing rcu barrier in mini_qdisc_pair_swap()

2017-12-26 Thread David Miller
From: Cong Wang Date: Wed, 20 Dec 2017 23:26:24 -0800 > The rcu_barrier_bh() in mini_qdisc_pair_swap() is to wait for > flying RCU callback installed by a previous mini_qdisc_pair_swap(), > however we miss it on the tp_head==NULL path, which leads to that > the RCU callback still uses miniq_old->

Re: [PATCH] net: phy: micrel: ksz9031: reconfigure autoneg after phy autoneg workaround

2017-12-26 Thread David Miller
From: Grygorii Strashko Date: Wed, 20 Dec 2017 18:45:10 -0600 > Under some circumstances driver will perform PHY reset in > ksz9031_read_status() to fix autoneg failure case (idle error count = > 0xFF). When this happens ksz9031 will not detect link status change any > more when connecting to Net

Re: [PATCH] hv_netvsc: update VF after name has changed.

2017-12-26 Thread David Miller
From: Stephen Hemminger Date: Wed, 20 Dec 2017 14:33:23 -0800 > Since commit 6123c66854c1 ("netvsc: delay setup of VF device") > the automatic bring up of the VF is delayed to allow userspace (udev) > a chance to rename the device. This delay is problematic because > it delays boot and may not be

Re: [PATCH net] ip6_gre: fix device features for ioctl setup

2017-12-26 Thread David Miller
From: Alexey Kodanev Date: Wed, 20 Dec 2017 19:36:03 +0300 > When ip6gre is created using ioctl, its features, such as > scatter-gather, GSO and tx-checksumming will be turned off: > > # ip -f inet6 tunnel add gre6 mode ip6gre remote fd00::1 > # ethtool -k gre6 (truncated output) > tx-ch

Re: [net 02/14] Revert "mlx5: move affinity hints assignments to generic code"

2017-12-26 Thread Sagi Grimberg
Are you sure it won't get populated at all ? even if you manually set IRQ affinity via sysfs ? Yes, the msi_desc affinity is not initialized without the affinity descriptor passed (which is what PCI_IRQ_AFFINITY is for). Anyway we can implement this driver helper function to return the IRQ

Re: [PATCH iproute2 0/2] ip/tunnel: Do not free() answer on rtnl_talk() error, correct ip6gre

2017-12-26 Thread Stephen Hemminger
On Wed, 20 Dec 2017 09:57:08 +0200 Serhey Popovych wrote: > In this series I present next set of improvements/fixes: > > 1) If rtnl_talk(), called with answer != NULL fails it > never returns with allocated answer: no need to > initialize answer and free() it in the caller on error.

Re: [PATCH net 2/2] net: mediatek: remove superfluous pin setup for MT7622 SoC

2017-12-26 Thread David Miller
From: Date: Wed, 20 Dec 2017 17:47:06 +0800 > From: Sean Wang > > Remove superfluous pin setup to get out of accessing invalid I/O pin > registers because the way for pin configuring tends to be different from > various SoCs and thus it should be better being managed and controlled by > the pin

Re: [PATCH net 1/2] dt-bindings: net: mediatek: add condition to property mediatek,pctl

2017-12-26 Thread David Miller
From: Date: Wed, 20 Dec 2017 17:47:05 +0800 > From: Sean Wang > > The property "mediatek,pctl" is only required for SoCs such as MT2701 and > MT7623, so adding a few words for stating the condition. > > Signed-off-by: Sean Wang Applied to net-next.

Re: [PATCH iproute2 1/3] vxcan,veth: Forbid "type" for peer device

2017-12-26 Thread Stephen Hemminger
On Wed, 20 Dec 2017 09:37:29 +0200 Serhey Popovych wrote: > It is already given for original device we configure this > peer for. > > Results from following command before/after change applied > are shown below: > > $ ip link add dev veth1a type veth peer name veth1b \ >

RE: [PATCH iproute] qdisc: Print offload indication

2017-12-26 Thread Yuval Mintz
> >Use the newly added TCA_HW_OFFLOAD indication from kernel > >to print a consistent 'offloaded' message to user when listing qdiscs. > > > >Signed-off-by: Yuval Mintz > > Reviewed-by: Jiri Pirko Just now saw the Stephen's e-mail regarding iproute's net-next branch. In this case the new uapi n

Re: [PATCH bpf-next v2 1/8] bpf: offload: don't require rtnl for dev list manipulation

2017-12-26 Thread Kirill Tkhai
Hi, Jakub, On 22.12.2017 00:01, Jakub Kicinski wrote: > We don't need the RTNL lock for all operations on offload state. > We only need to hold it around ndo calls. The device offload > initialization doesn't require it. The soon-to-come querying > of the offload info will only need it partially

Re: [net 02/14] Revert "mlx5: move affinity hints assignments to generic code"

2017-12-26 Thread Saeed Mahameed
On Mon, Dec 25, 2017 at 5:53 AM, Sagi Grimberg wrote: > >> Before the offending commit, mlx5 core did the IRQ affinity itself, >> and it seems that the new generic code have some drawbacks and one >> of them is the lack for user ability to modify irq affinity after >> the initial affinity values g

Re: [PATCH net-next] phylib: rename reset-(post-)delay-us to reset-(de)assert-us

2017-12-26 Thread Rob Herring
On Fri, Dec 22, 2017 at 4:08 AM, Richard Leitner wrote: > From: Richard Leitner > > As suggested by Rob Herring [1] rename the previously introduced > reset-{,post-}delay-us bindings to the clearer reset-{,de}assert-us > > [1] https://patchwork.kernel.org/patch/10104905/ > > Signed-off-by: Richar

[patch net-next v5 03/10] net: sched: introduce block mechanism to handle netif_keep_dst calls

2017-12-26 Thread Jiri Pirko
From: Jiri Pirko Couple of classifiers call netif_keep_dst directly on q->dev. That is not possible to do directly for shared blocke where multiple qdiscs are owning the block. So introduce a infrastructure to keep track of the block owners in list and use this list to implement block variant of

[patch net-next v5 05/10] net: sched: keep track of offloaded filters and check tc offload feature

2017-12-26 Thread Jiri Pirko
From: Jiri Pirko During block bind, we need to check tc offload feature. If it is disabled yet still the block contains offloaded filters, forbid the bind. Also forbid to register callback for a block that already containes offloaded filters, as the play back is not supported now. For keeping tra

[patch net-next v5 10/10] mlxsw: spectrum_acl: Pass mlxsw_sp_port down to ruleset bind/unbind ops

2017-12-26 Thread Jiri Pirko
From: Jiri Pirko No need to convert from mlxsw_sp_port to net_device and back again. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 6 +++-- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c | 4 ++-- .../ethernet/mellanox/mlxsw/spectrum_acl_tcam.c| 2

[patch net-next v5 02/10] net: sched: avoid usage of tp->q in tcf_classify

2017-12-26 Thread Jiri Pirko
From: Jiri Pirko Use block index in the messages instead. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 9b1b4fa..b93eca8 100644 --- a/net/sched/cls_api.c +++ b/net/sched

[patch net-next v5 01/10] net: sched: introduce support for multiple filter chain pointers registration

2017-12-26 Thread Jiri Pirko
From: Jiri Pirko So far, there was possible only to register a single filter chain pointer to block->chain[0]. However, when the blocks will get shareable, we need to allow multiple filter chain pointers registration. Signed-off-by: Jiri Pirko --- v3->v4: - rebased on top of the current net-nex

[patch net-next v5 09/10] mlxsw: spectrum_acl: Implement TC block sharing

2017-12-26 Thread Jiri Pirko
From: Jiri Pirko Benefit from the prepared TC and in-driver ACL infrastructure and introduce block sharing offload. For that, a new struct "block" is introduced in spectrum_acl in order to hold a list of specific block-port bindings. Signed-off-by: Jiri Pirko --- v2->v3: - add tc offload featur

  1   2   >