Sun, Dec 24, 2017 at 03:20:45AM CET, kubak...@wp.pl wrote:
>On Sat, 23 Dec 2017 16:54:31 +0100, Jiri Pirko wrote:
>> -static void tcf_block_offload_bind(struct tcf_block *block, struct Qdisc *q,
>> - struct tcf_block_ext_info *ei)
>> +static int tcf_block_offload_bind(
Sun, Dec 24, 2017 at 02:54:47AM CET, dsah...@gmail.com wrote:
>On 12/23/17 9:54 AM, Jiri Pirko wrote:
>> So back to the example. First, we create 2 qdiscs. Both will share
>> block number 22. "22" is just an identification. If we don't pass any
>> block number, a new one will be generated by kernel
On 12/22/2017 12:31 PM, Cong Wang wrote:
> On Thu, Dec 21, 2017 at 7:06 PM, John Fastabend
> wrote:
>> On 12/21/2017 04:03 PM, Cong Wang wrote:
>>> __skb_array_empty() is only safe if array is never resized.
>>> pfifo_fast_dequeue() is called in TX BH context and without
>>> qdisc lock, so even af
b43_radio_2057_init_post is not called in an interrupt handler
nor holding a spinlock.
The function mdelay in it can be replaced with msleep, to reduce busy wait.
Signed-off-by: Jia-Ju Bai
---
drivers/net/wireless/broadcom/b43/phy_n.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
sky2_vpd_wait is not called in an interrupt handler nor holding a spinlock.
The function mdelay in it can be replaced with msleep, to reduce busy wait.
Signed-off-by: Jia-Ju Bai
---
drivers/net/ethernet/marvell/sky2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On Sat, 23 Dec 2017 16:54:31 +0100, Jiri Pirko wrote:
> -static void tcf_block_offload_bind(struct tcf_block *block, struct Qdisc *q,
> -struct tcf_block_ext_info *ei)
> +static int tcf_block_offload_bind(struct tcf_block *block, struct Qdisc *q,
> +
On 12/23/17 9:54 AM, Jiri Pirko wrote:
> So back to the example. First, we create 2 qdiscs. Both will share
> block number 22. "22" is just an identification. If we don't pass any
> block number, a new one will be generated by kernel:
>
> $ tc qdisc add dev ens7 ingress block 22
>
On Meson8b the only valid input clock is MPLL2. The bootloader
configures that to run at 52394Hz which cannot be divided evenly
down to 25MHz using the m250_div and m25_div clocks. Currently the
common clock framework chooses a m250_div of 2 and a m25_div of 10,
which results in a RGMII clock o
Neither the m25_div_clk nor the m250_div_clk or m250_mux_clk are used in
RMII mode. The m25_div_clk output is routed to the RGMII PHY's "RGMII
clock".
This means that we don't need to configure the clocks in RMII mode. The
driver however did this - with no effect since the clocks are not routed
to
Hi Dave,
please do not apply this series until it got a Tested-by from Emiliano.
Hi Emiliano,
you reported [0] that you couldn't get dwmac-meson8b to work on your
Odroid-C1. With your findings (register dumps, clk_summary output, etc.)
I think I was able to find a fix: it consists of two patche
Meson8b only supports MPLL2 as clock input. The rate of the MPLL2 clock
set by Odroid-C1's u-boot is close to 500MHz. The exact rate is
52394Hz, which is calculated in drivers/clk/meson/clk-mpll.c
using the following formula:
DIV_ROUND_UP_ULL((u64)parent_rate * SDM_DEN, (SDM_DEN * n2) + sdm)
Od
On Sat, Dec 23, 2017 at 11:41 PM, Jerome Brunet wrote:
> On Sat, 2017-12-23 at 22:49 +0100, Martin Blumenstingl wrote:
>> while calculating this with a target frequency of 500MHz manually
>> again I saw that there's a remainder of 10Mhz after the initial
>> division.
>> remainder * SDM_DEN = 16384
On Sat, 2017-12-23 at 22:49 +0100, Martin Blumenstingl wrote:
> while calculating this with a target frequency of 500MHz manually
> again I saw that there's a remainder of 10Mhz after the initial
> division.
> remainder * SDM_DEN = 16384000 - this value overflows 32-bit,
> things will go downhi
Le 22/12/2017 à 21:36, Craig Gallek a écrit :
> From: Craig Gallek
>
> netns ids were added in commit 0c7aecd4bde4 and defined as signed
> integers in both the kernel datastructures and the netlink interface.
> However, the semantics of the implementation assume that the ids
> are always greater
Hi Jerome,
On Sat, Dec 23, 2017 at 9:40 PM, Jerome Brunet wrote:
> On Sat, 2017-12-23 at 21:00 +0100, Martin Blumenstingl wrote:
>> Hi Jerome,
>>
>> On Sat, Dec 23, 2017 at 6:40 PM, Jerome Brunet wrote:
>> > On Sat, 2017-12-23 at 18:04 +0100, Martin Blumenstingl wrote:
>> > > Trying to set the r
On Sat, 2017-12-23 at 21:00 +0100, Martin Blumenstingl wrote:
> Hi Jerome,
>
> On Sat, Dec 23, 2017 at 6:40 PM, Jerome Brunet wrote:
> > On Sat, 2017-12-23 at 18:04 +0100, Martin Blumenstingl wrote:
> > > Trying to set the rate of m250_div's parent clock makes no sense since
> > > it's a mux whic
Hi Jerome,
On Sat, Dec 23, 2017 at 6:40 PM, Jerome Brunet wrote:
> On Sat, 2017-12-23 at 18:04 +0100, Martin Blumenstingl wrote:
>> Trying to set the rate of m250_div's parent clock makes no sense since
>> it's a mux which has neither CLK_MUX_ROUND_CLOSEST nor
>> CLK_SET_RATE_PARENT set.
>> It ev
On Sat, Dec 23, 2017 at 10:09:55AM +, Gianluca Borello wrote:
...
> Fixes: cc2b14d51053 ("bpf: teach verifier to recognize zero initialized
> stack")
> Signed-off-by: Gianluca Borello
> Acked-by: Alexei Starovoitov
> ---
> kernel/bpf/verifier.c | 2 +-
> tools/testin
> On 24/12/2017, at 5:09 AM, Steffen Klassert
> wrote:
>
>> On Sat, Dec 23, 2017 at 10:56:12AM -0500, David Miller wrote:
>> From: Steffen Klassert
>> Date: Sat, 23 Dec 2017 10:22:17 +0100
>>
On Thu, Nov 16, 2017 at 11:00:40AM +0100, Steffen Klassert wrote:
This reverts commit c9f3
On Sat, 2017-12-23 at 18:40 +0100, Jerome Brunet wrote:
> > Trying to set the rate of m250_div's parent clock makes no sense since
> > it's a mux which has neither CLK_MUX_ROUND_CLOSEST nor
> > CLK_SET_RATE_PARENT set.
> > It even does harm on Meson8b SoCs where the input clock for the mux
> > cann
On Sat, 2017-12-23 at 18:04 +0100, Martin Blumenstingl wrote:
> Trying to set the rate of m250_div's parent clock makes no sense since
> it's a mux which has neither CLK_MUX_ROUND_CLOSEST nor
> CLK_SET_RATE_PARENT set.
> It even does harm on Meson8b SoCs where the input clock for the mux
> cannot b
On Sat, 2017-12-23 at 18:04 +0100, Martin Blumenstingl wrote:
> Meson8b only supports MPLL2 as clock input. The rate of the MPLL2 clock
> set by Odroid-C1's u-boot is close to 500MHz. The exact rate is
> 52394Hz, which is calculated in drivers/clk/meson/clk-mpll.c
> using the following formula:
Commit cc2b14d51053 ("bpf: teach verifier to recognize zero initialized
stack") introduced a very relaxed check when comparing stacks of different
states, effectively returning a positive result in many cases where it
shouldn't.
This can create problems in cases such as this following C pseudocode
strparser wants to check socket ownership without producing any
warnings. As indicated by the comment in the code, it is permissible
for owned_by_user to return true.
Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages")
Reported-by: syzbot
Signed-off-by: Tom Herbert
---
net/strpars
One issue is lockdep warnings when sock_owned_by_user returns true
in strparser. Fix is to add and call sock_owned_by_user_nocheck since
the check for owned by user is not an error condition in this case.
The other issue is a potential deadlock between TX and RX paths
KCM socket lock and the psoc
This allows checking socket lock ownership with producing lockdep
warnings.
Signed-off-by: Tom Herbert
---
include/net/sock.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/net/sock.h b/include/net/sock.h
index 6c1db823f8b9..66fd3951e6f3 100644
--- a/include/net/sock.h
+++ b/in
Hi Dave,
please do not apply this series until it got a Tested-by from Emiliano.
Hi Emiliano,
you reported [0] that you couldn't get dwmac-meson8b to work on your
Odroid-C1. With your findings (register dumps, clk_summary output, etc.)
I think I was able to find a fix: it consists of two patche
Meson8b only supports MPLL2 as clock input. The rate of the MPLL2 clock
set by Odroid-C1's u-boot is close to 500MHz. The exact rate is
52394Hz, which is calculated in drivers/clk/meson/clk-mpll.c
using the following formula:
DIV_ROUND_UP_ULL((u64)parent_rate * SDM_DEN, (SDM_DEN * n2) + sdm)
Od
Trying to set the rate of m250_div's parent clock makes no sense since
it's a mux which has neither CLK_MUX_ROUND_CLOSEST nor
CLK_SET_RATE_PARENT set.
It even does harm on Meson8b SoCs where the input clock for the mux
cannot be divided down to 250MHz evenly (the parent rate is 52394Hz)
which i
On 23.12.2017 16:52, Greg KH wrote:
adding stable@ and netdev@
On Sat, Dec 23, 2017 at 10:49:27AM +, Mathias Tillman wrote:
Hi, I wanted to make you aware of a recent regression to the Linux kernel
introduced with commit 2417da3f4d6bc4fc6c77f613f0e2264090892aa5:
https://git.kernel.org/pub/s
On Sat, Dec 23, 2017 at 10:56:12AM -0500, David Miller wrote:
> From: Steffen Klassert
> Date: Sat, 23 Dec 2017 10:22:17 +0100
>
> > On Thu, Nov 16, 2017 at 11:00:40AM +0100, Steffen Klassert wrote:
> >> This reverts commit c9f3f813d462c72dbe412cee6a5cbacf13c4ad5e.
> >>
> >> This commit breaks t
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
include/uapi/linux/pkt_sched.h | 11 +
tc/q_clsact.c | 56 ++
tc/q_ingress.c | 32 +---
3 files changed, 91 insertions(+), 8 deletions(-)
diff --g
From: Alexei Starovoitov
Date: Fri, 22 Dec 2017 20:31:56 -0800
> Thoughts?
Even though you propose it as the opposite, it sounds like a crutch
for the verifier.
If we strictly control objects that the eBPF program can access,
verifier ensures this, and all other objects go through helpers,
then
On 12/23/2017 05:48 AM, Greg KH wrote:
On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote:
Hi all,
When I tried to use devm_ioremap function and review related code, I found
devm_ioremap and devm_ioremap_nocache is almost the same with each other,
except one use ioremap while the other
From: Jiri Pirko
Instead, pass netdev and ingress flag to ruleset unbind op.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 3 +-
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c | 9 --
.../ethernet/mellanox/mlxsw/spectrum_acl_tcam.c| 33 +++
From: Steffen Klassert
Date: Sat, 23 Dec 2017 10:22:17 +0100
> On Thu, Nov 16, 2017 at 11:00:40AM +0100, Steffen Klassert wrote:
>> This reverts commit c9f3f813d462c72dbe412cee6a5cbacf13c4ad5e.
>>
>> This commit breaks transport mode when the policy template
>> has widlcard addresses configured,
From: Jiri Pirko
Both are no longer used, so remove them.
Signed-off-by: Jiri Pirko
---
include/net/sch_generic.h | 2 --
net/sched/cls_api.c | 7 ++-
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h
index df97c3e..d
From: Jiri Pirko
During block bind, we need to check tc offload feature. If it is
disabled yet still the block contains offloaded filters, forbid the
bind. Also forbid to register callback for a block that already
containes offloaded filters, as the play back is not supported now.
For keeping tra
From: Jiri Pirko
In order to prepare for follow-up changes, make the bind/unbind helpers
very simple. That required move of ht insertion/removal and bind/unbind
calls into mlxsw_sp_acl_ruleset_create/destroy.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c | 10
From: Jiri Pirko
Benefit from the prepared TC and in-driver ACL infrastructure and
introduce block sharing offload. For that, a new struct "block" is
introduced in spectrum_acl in order to hold a list of specific
block-port bindings.
Signed-off-by: Jiri Pirko
---
v2->v3:
- add tc offload featur
From: Jiri Pirko
Currently the filters added to qdiscs are independent. So for example if you
have 2 netdevices and you create ingress qdisc on both and you want to add
identical filter rules both, you need to add them twice. This patchset
makes this easier and mainly saves resources allowing to
From: Jiri Pirko
No need to convert from mlxsw_sp_port to net_device and back again.
Signed-off-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 6 +++--
drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c | 4 ++--
.../ethernet/mellanox/mlxsw/spectrum_acl_tcam.c| 2
From: Jiri Pirko
So far, there was possible only to register a single filter chain
pointer to block->chain[0]. However, when the blocks will get shareable,
we need to allow multiple filter chain pointers registration.
Signed-off-by: Jiri Pirko
---
v3->v4:
- rebased on top of the current net-nex
From: Jiri Pirko
Benefit from the previously introduced shared filter blocks
infrastructure and allow ingress and clsact qdisc instances to share
filter blocks. The block index is coming from userspace as qdisc option.
Signed-off-by: Jiri Pirko
---
v3->v4:
- rebased on top of the current net-ne
From: Jiri Pirko
Use block index in the messages instead.
Signed-off-by: Jiri Pirko
---
net/sched/cls_api.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 9b1b4fa..b93eca8 100644
--- a/net/sched/cls_api.c
+++ b/net/sched
From: Jiri Pirko
Couple of classifiers call netif_keep_dst directly on q->dev. That is
not possible to do directly for shared blocke where multiple qdiscs are
owning the block. So introduce a infrastructure to keep track of the
block owners in list and use this list to implement block variant of
On 23 December 2017 at 15:01, Jassi Brar wrote:
> On Sat, Dec 23, 2017 at 4:09 PM, Ard Biesheuvel
> wrote:
>> On 23 December 2017 at 05:45, wrote:
>>> From: Jassi Brar
>>>
>>> This driver adds support for Socionext "netsec" IP Gigabit
>>> Ethernet + PHY IP used in the Synquacer SC2A11 SoC.
>>>
On Sat, Dec 23, 2017 at 4:09 PM, Ard Biesheuvel
wrote:
> On 23 December 2017 at 05:45, wrote:
>> From: Jassi Brar
>>
>> This driver adds support for Socionext "netsec" IP Gigabit
>> Ethernet + PHY IP used in the Synquacer SC2A11 SoC.
>>
>> Signed-off-by: Ard Biesheuvel
>> Signed-off-by: Jassi
adding stable@ and netdev@
On Sat, Dec 23, 2017 at 10:49:27AM +, Mathias Tillman wrote:
> Hi, I wanted to make you aware of a recent regression to the Linux kernel
> introduced with commit 2417da3f4d6bc4fc6c77f613f0e2264090892aa5:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-
On Sat, Dec 23, 2017 at 06:55:25PM +0800, Yisheng Xie wrote:
> Hi all,
>
> When I tried to use devm_ioremap function and review related code, I found
> devm_ioremap and devm_ioremap_nocache is almost the same with each other,
> except one use ioremap while the other use ioremap_nocache.
For all a
On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote:
> --- a/lib/devres.c
> +++ b/lib/devres.c
> @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev,
> resource_size_t offset,
> EXPORT_SYMBOL(devm_ioremap);
>
> /**
> - * devm_ioremap_nocache - Managed ioremap_nocache()
> -
On Fri, 22 Dec 2017 16:14:43 -0800
Jakub Kicinski wrote:
> On Fri, 22 Dec 2017 18:11:39 +0100, Jesper Dangaard Brouer wrote:
> > +struct xdp_rxq_info {
> > + struct net_device *dev;
> > + u32 queue_index;
> > + u32 reg_state;
> > +} cacheline_aligned; /* perf critical, avoid false-shari
On Sat, Dec 23, 2017 at 5:42 PM, Sergei Shtylyov
wrote:
> On 12/23/2017 4:10 AM, Yafang Shao wrote:
>
There's a space character missed in the printk messages.
This error should be prevented with checkscript.pl, but it couldn't
caught
>
>
>> It is checkpatch.pl.
>
>
>Yes, that to
Default ioremap is ioremap_nocache, so devm_ioremap has the same
function with devm_ioremap_nocache, which can just be killed to
save the size of devres.o
This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
which should not have any function change but prepare for killing
devm_i
Now, nobody use devm_ioremap_nocache anymore, can it can just be
removed. After this patch the size of devres.o will be reduced from
20304 bytes to 18992 bytes.
Suggested-by: Greg KH
Signed-off-by: Yisheng Xie
---
Documentation/driver-model/devres.txt | 1 -
include/linux/io.h
Default ioremap is ioremap_nocache, so devm_ioremap has the same
function with devm_ioremap_nocache, which can just be killed to
save the size of devres.o
This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
which should not have any function change but prepare for killing
devm_i
Default ioremap is ioremap_nocache, so devm_ioremap has the same
function with devm_ioremap_nocache, which can just be killed to
save the size of devres.o
This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
which should not have any function change but prepare for killing
devm_i
Hi all,
When I tried to use devm_ioremap function and review related code, I found
devm_ioremap and devm_ioremap_nocache is almost the same with each other,
except one use ioremap while the other use ioremap_nocache. While ioremap's
default function is ioremap_nocache, so devm_ioremap_nocache also
On 23 December 2017 at 05:45, wrote:
> From: Jassi Brar
>
> This driver adds support for Socionext "netsec" IP Gigabit
> Ethernet + PHY IP used in the Synquacer SC2A11 SoC.
>
> Signed-off-by: Ard Biesheuvel
> Signed-off-by: Jassi Brar
> ---
> drivers/net/ethernet/Kconfig|1 +
>
On 12/23/2017 4:10 AM, Yafang Shao wrote:
There's a space character missed in the printk messages.
This error should be prevented with checkscript.pl, but it couldn't caught
It is checkpatch.pl.
Yes, that too. But I actually meant you missed "be" between "couldn't" and
"caught"...
by
On Thu, Nov 16, 2017 at 11:00:40AM +0100, Steffen Klassert wrote:
> This reverts commit c9f3f813d462c72dbe412cee6a5cbacf13c4ad5e.
>
> This commit breaks transport mode when the policy template
> has widlcard addresses configured, so revert it.
>
> Signed-off-by: Steffen Klassert
David, can you
Hello,
I released a new version 0.2 of the igmpproxy project. Tarball is
available at:
https://github.com/pali/igmpproxy/releases/tag/0.2
The major change is license change from proprietary Stanford to free
compatible with GPLv2+ (mix of 3-clause BSD and GPLv2+).
IGMPproxy is a simple dynamic M
62 matches
Mail list logo
