Re: [PATCH] tg3: Fix rx hang on MTU change with 5717/5719

2017-12-16 Thread Siva Reddy Kallam
On Sat, Dec 16, 2017 at 2:51 AM, Brian King wrote: > This fixes a hang issue seen when changing the MTU size from 1500 MTU > to 9000 MTU on both 5717 and 5719 chips. In discussion with Broadcom, > they've indicated that these chipsets have the same phy as the 57766 > chipset, so the same workaroun

Re: [PATCH v2] vxlan: restore dev->mtu setting based on lower device

2017-12-16 Thread David Miller
From: Alexey Kodanev Date: Thu, 14 Dec 2017 20:20:00 +0300 > Stefano Brivio says: > Commit a985343ba906 ("vxlan: refactor verification and > application of configuration") introduced a change in the > behaviour of initial MTU setting: earlier, the MTU for a link > created on top o

Re: [PATCH net-next] net: tap: fix POLLOUT condition in tap_poll()

2017-12-16 Thread David Miller
From: yuan linyu Date: Thu, 14 Dec 2017 22:22:16 +0800 > From: yuan linyu > > from logical view, if sock_writeable(&q->sk) return false, > original second condition will return false too, > change it and make second condition can return true. > > Signed-off-by: yuan linyu ... > @@ -587,8 +58

Re: [PATCH] ipv6: icmp6: Allow icmp messages to be looped back

2017-12-16 Thread David Miller
From: Brendan McGrath Date: Wed, 13 Dec 2017 22:14:57 +1100 > One example of when an ICMPv6 packet is required to be looped back is > when a host acts as both a Multicast Listener and a Multicast Router. > > A Multicast Router will listen on address ff02::16 for MLDv2 messages. > > Currently, M

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 09:47 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:25 +0100 > Knut Omang wrote: > > > This patch series implements features to make it easier to run checkers on > > the > > entire kernel as part of automatic and developer testing. > > > > This is done by rep

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 10:24 -0800, Joe Perches wrote: > On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > > On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: > > > +# Code simplification: > > > +# > > > +except ALLOC_WITH_MULTIPLY ib.c > > > +except PREFER_PR_LEVEL ib_cm.c ib_recv.c

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 12:00 -0800, santosh.shilim...@oracle.com wrote: > On 12/16/17 10:24 AM, Joe Perches wrote: > > On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > >> On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang > >> wrote: > >>> +# Code simplification: > >>> +# > >>> +except ALL

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Knut Omang
On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:29 +0100 > Knut Omang wrote: > > > + > > +# Important to fix from a quality perspective: > > +# > > +except AVOID_BUG connection.c ib.c ib_cm.c ib_rdma.c ib_recv.c ib_ring.c > > ib_send.c > info.c loop.c mess

[RFC PATCH] ila: ila_notify() can be static

2017-12-16 Thread kbuild test robot
Fixes: bdefe11e33bb ("ila: Route notify") Signed-off-by: Fengguang Wu --- ila_lwt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/ila/ila_lwt.c b/net/ipv6/ila/ila_lwt.c index 303c91e..fbf6273 100644 --- a/net/ipv6/ila/ila_lwt.c +++ b/net/ipv6/ila/ila_lwt.c @@ -5

Re: [PATCH v4 net-next 6/6] ila: Route notify

2017-12-16 Thread kbuild test robot
Hi Tom, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/net-ILA-notification-mechanism-and-fixes/20171217-041013 reproduce: # apt-get install sparse make ARCH=x86_64

Re: [PATCH v4 net-next 6/6] ila: Route notify (fwd)

2017-12-16 Thread Julia Lawall
Hello, Another tab appears to be needed on line 358. julia -- Forwarded message -- Date: Sun, 17 Dec 2017 05:42:17 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH v4 net-next 6/6] ila: Route notify CC: kbuild-...@01.org In-Reply-To: <201712

Multicast MPLS is Linux

2017-12-16 Thread Алексей Болдырев
Tell me please, when in linux is planned the realization of multicast MPLS? Etnernet Tipe: 0c8848

Re: [PATCH iproute2] ip route: broken logic when using default word and family not specified

2017-12-16 Thread Stephen Hemminger
On Sat, 18 Nov 2017 14:12:48 +0100 Alexander Zubkov wrote: > Hello, > > I have found odd behaviour when using "ip route list" (and other bound > commands) with prefix "default". > > When family not specified, its value is completely ignored and "ip > route list default" shows all inet4 prefixes

Re: [PATCH v4 net-next 3/6] ila: Call library function alloc_bucket_locks

2017-12-16 Thread kbuild test robot
Hi Tom, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/net-ILA-notification-mechanism-and-fixes/20171217-041013 config: x86_64-randconfig-x019-201751 (attached as .config) compiler: gcc-7

Re: [PATCH v2 ipsec-next 3/3] xfrm: wrap xfrmdev_ops with offload config

2017-12-16 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/xfrm-check-for-xdo_dev_state_free/20171217-022754 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-ne

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/16/17 10:24 AM, Joe Perches wrote: On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: +# Code simplification: +# +except ALLOC_WITH_MULTIPLY ib.c +except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c rdma_transport.c threads.c

Re: [PATCHv2 net-next 04/15] net: sched: sch: add extack for init callback

2017-12-16 Thread kbuild test robot
Hi Alexander, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/net-sched-sch-introduce-extack-support/20171217-015839 config: x86_64-randconfig-x003-201751 (attached as .config) compiler: gcc

[PATCH] isdn: avm: Handle return value of skb_dequeue()

2017-12-16 Thread Arvind Yadav
skb_dequeue() will return NULL for an empty list or a pointer to the head element. Signed-off-by: Arvind Yadav --- drivers/isdn/hardware/avm/b1dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/isdn/hardware/avm/b1dma.c b/drivers/isdn/hardware/avm/b1dma.c index 9538a9e..10df578

[PATCH net-next 2/2 v9] net: ethernet: Add a driver for Gemini gigabit ethernet

2017-12-16 Thread Linus Walleij
The Gemini ethernet has been around for years as an out-of-tree patch used with the NAS boxen and routers built on StorLink SL3512 and SL3516, later Storm Semiconductor, later Cortina Systems. These ASICs are still being deployed and brand new off-the-shelf systems using it can easily be acquired.

[PATCH] NFC: Handle return value of skb_dequeue()

2017-12-16 Thread Arvind Yadav
skb_dequeue() will return NULL for an empty list or a pointer to the head element. Signed-off-by: Arvind Yadav --- net/nfc/rawsock.c | 4 1 file changed, 4 insertions(+) diff --git a/net/nfc/rawsock.c b/net/nfc/rawsock.c index e2188de..c6de1ac 100644 --- a/net/nfc/rawsock.c +++ b/net/nfc/r

[PATCH net-next 1/2 v9] net: ethernet: Add DT bindings for the Gemini ethernet

2017-12-16 Thread Linus Walleij
This adds the device tree bindings for the Gemini ethernet controller. It is pretty straight-forward, using standard bindings and modelling the two child ports as child devices under the parent ethernet controller device. Cc: devicet...@vger.kernel.org Cc: Tobias Waldvogel Cc: Michał Mirosław Re

Re: [PATCHv2 net-next 04/15] net: sched: sch: add extack for init callback

2017-12-16 Thread kbuild test robot
Hi Alexander, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/net-sched-sch-introduce-extack-support/20171217-015839 reproduce: # apt-get install sparse make ARCH=x86_6

Re: [PATCH v2 ipsec-next 3/3] xfrm: wrap xfrmdev_ops with offload config

2017-12-16 Thread kbuild test robot
Hi Shannon, Thank you for the patch! Yet something to improve: [auto build test ERROR on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/xfrm-check-for-xdo_dev_state_free/20171217-022754 base: https://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-ne

Re: [PATCHv2 net-next 04/15] net: sched: sch: add extack for init callback

2017-12-16 Thread kbuild test robot
Hi Alexander, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/net-sched-sch-introduce-extack-support/20171217-015839 config: i386-randconfig-a0-201750 (attached as .config) compiler: g

Re: [PATCHv2 net-next 12/15] net: sch: api: add extack support in qdisc_create_dflt

2017-12-16 Thread kbuild test robot
Hi Alexander, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/net-sched-sch-introduce-extack-support/20171217-015839 config: x86_64-randconfig-x003-201751 (attached as .config) compiler: gcc

Re: [PATCH net] net: bridge: fix early call to br_stp_change_bridge_id

2017-12-16 Thread Stephen Hemminger
On Sat, 16 Dec 2017 13:31:36 +0200 Nikolay Aleksandrov wrote: > The early call to br_stp_change_bridge_id in bridge's newlink can cause > a memory leak if an error occurs during the newlink because the fdb > entries are not cleaned up if a different lladdr was specified, also > another minor issu

Re: [PATCHv2 net-next 10/15] net: sch: api: add extack support in tcf_block_get

2017-12-16 Thread kbuild test robot
Hi Alexander, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Alexander-Aring/net-sched-sch-introduce-extack-support/20171217-015839 config: x86_64-randconfig-x003-201751 (attached as .config) compiler: gcc

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Joe Perches
On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: > > +# Code simplification: > > +# > > +except ALLOC_WITH_MULTIPLY ib.c > > +except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c rdma_transport.c > > threads.c transport.c > > +except

Re: [patch iproute2] tc: implement filter block sharing to ingress and clsact qdiscs

2017-12-16 Thread Stephen Hemminger
On Wed, 13 Dec 2017 16:13:57 +0100 Jiri Pirko wrote: > From: Jiri Pirko > > Signed-off-by: Jiri Pirko This needs to wait until block sharing makes it into net-next upstream.

Re: [PATCH iproute2 0/3] Improve tunnel local/remote endpoint params and gre link attribute handling

2017-12-16 Thread Stephen Hemminger
On Wed, 13 Dec 2017 21:35:59 +0200 Serhey Popovych wrote: > In this series following problems addressed: > > 1) Size of IFLA_GRE_LINK attribute is 32 bits long in , not 8 bit. > > 2) Use get_addr() instead of get_prefix() to parse local/remote > tunnel endpoints as IPADDR, not PREFIX a

Re: [PATCH] ip: add vxcan/veth to ip-link man page

2017-12-16 Thread Stephen Hemminger
On Sat, 16 Dec 2017 12:38:57 +0100 Oliver Hartkopp wrote: > veth and vxcan both create a vitual tunnel between a pair of virtual network > devices. This patch adds the content for the now supported vxcan netdevices > and the documentation to create peer devices for vxcan and veth. > > Additional

Re: [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings

2017-12-16 Thread Andrew Lunn
On Sat, Dec 16, 2017 at 06:11:01PM +0100, Heiner Kallweit wrote: > Am 21.11.2017 um 02:34 schrieb Andrew Lunn: > > Hi Heiner > > > > Do you have access to the data sheet? > > > > I had a quick look through the driver. It would be nice to refactor it > > to follow the usual Linux conventions: > >

Re: [PATCH v3 iproute2 1/1] ss: add missing path MTU parameter

2017-12-16 Thread Stephen Hemminger
On Fri, 15 Dec 2017 09:27:42 -0500 Roman Mashak wrote: > v3: >Rebase and use out() instead of printf(). > v2: >Print the path MTU immediately after the MSS, as it is easier to parse >for humans (suggested by Neal Cardwell). > > Signed-off-by: Roman Mashak > --- Applied, thanks for

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Joe Perches
On Sat, 2017-12-16 at 09:47 -0800, Stephen Hemminger wrote: > On Sat, 16 Dec 2017 15:42:25 +0100 > Knut Omang wrote: > > > This patch series implements features to make it easier to run checkers on > > the > > entire kernel as part of automatic and developer testing. > > > > This is done by rep

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Stephen Hemminger
On Sat, 16 Dec 2017 15:42:25 +0100 Knut Omang wrote: > This patch series implements features to make it easier to run checkers on the > entire kernel as part of automatic and developer testing. > > This is done by replacing the sparse specific setup for the C={1,2} variable > in the makefiles wi

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Stephen Hemminger
On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: > + > +# Important to fix from a quality perspective: > +# > +except AVOID_BUG connection.c ib.c ib_cm.c ib_rdma.c ib_recv.c ib_ring.c > ib_send.c info.c loop.c message.c > +except AVOID_BUG rdma.c recv.c send.c stats.c tcp_recv.c transport.c

Re: [PATCH v2 1/2] r8169: fix RTL8111EVL EEE and green settings

2017-12-16 Thread Heiner Kallweit
Am 21.11.2017 um 02:34 schrieb Andrew Lunn: > Hi Heiner > > Do you have access to the data sheet? > > I had a quick look through the driver. It would be nice to refactor it > to follow the usual Linux conventions: > > Turn the MDIO read/write functions into an MDIO bus driver. > > Move the PHY

Re: [PATCH net-next v5 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-16 Thread Alexander Duyck
On Sat, Dec 16, 2017 at 12:09 AM, Michael Chan wrote: > Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware > GRO. With this flag, we can now independently turn on or off hardware > GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to > control hardware GRO and so i

Re: Grant

2017-12-16 Thread The Mayrhofer's
My wife and I have awarded you with a donation of $ 1,000,000.00, respond with your details for claims. Best Regards, Friedrich And Annand Mayrhofer.

[PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread Knut Omang
Add a runchecks.cfg to net/rds to start "reining in" future checker errors, and making it easier to selectively clean up existing issues. This runchecks.cfg lets make C=2 M=net/rds pass with all errors/warnings suppressed See Documentation/dev-tools/runchecks.rst for motivation and details. Sign

[PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-16 Thread Knut Omang
This patch series implements features to make it easier to run checkers on the entire kernel as part of automatic and developer testing. This is done by replacing the sparse specific setup for the C={1,2} variable in the makefiles with setup for running scripts/runchecks, a new program that can ru

Re: [PATCH net] net: bridge: fix early call to br_stp_change_bridge_id

2017-12-16 Thread Nikolay Aleksandrov
On 16/12/17 13:31, Nikolay Aleksandrov wrote: > The early call to br_stp_change_bridge_id in bridge's newlink can cause > a memory leak if an error occurs during the newlink because the fdb > entries are not cleaned up if a different lladdr was specified, also > another minor issue is that it gener

Re: [PATCHv2] ipv6: ip6mr: Recalc UDP checksum before forwarding

2017-12-16 Thread Brendan McGrath
The network diagram is very simple. It is just: VM <--* MR > PH Where: MR = Multicast Router VM = Virtual Machine (connected by a Virtual Interface using the 'virtio_net' driver) PH = Physical Host (connected by a physical Ethernet connection) * = The interface where the packet orig

Re: Grant

2017-12-16 Thread The Mayrhofer's
My wife and I have awarded you with a donation of $ 1,000,000.00, respond with your details for claims. Best Regards, Friedrich And Annand Mayrhofer.

[PATCH] ip: add vxcan/veth to ip-link man page

2017-12-16 Thread Oliver Hartkopp
veth and vxcan both create a vitual tunnel between a pair of virtual network devices. This patch adds the content for the now supported vxcan netdevices and the documentation to create peer devices for vxcan and veth. Additional remove 'can' that accidently was on the list of link types which can

[PATCH net] net: bridge: fix early call to br_stp_change_bridge_id

2017-12-16 Thread Nikolay Aleksandrov
The early call to br_stp_change_bridge_id in bridge's newlink can cause a memory leak if an error occurs during the newlink because the fdb entries are not cleaned up if a different lladdr was specified, also another minor issue is that it generates fdb notifications with ifindex = 0. To remove thi

Re: BUG: unable to handle kernel NULL pointer dereference in fdb_find_rcu

2017-12-16 Thread Nikolay Aleksandrov
On 16/12/17 12:40, Nikolay Aleksandrov wrote: > On 16/12/17 11:29, Nikolay Aleksandrov wrote: >> On 16/12/17 11:17, Nikolay Aleksandrov wrote: >>> On 16/12/17 02:37, Andrei Vagin wrote: Hi, We run criu tests for linux-next and today we get this bug: The kernel version is 4.

Re: BUG: unable to handle kernel NULL pointer dereference in fdb_find_rcu

2017-12-16 Thread Nikolay Aleksandrov
On 16/12/17 11:29, Nikolay Aleksandrov wrote: > On 16/12/17 11:17, Nikolay Aleksandrov wrote: >> On 16/12/17 02:37, Andrei Vagin wrote: >>> Hi, >>> >>> We run criu tests for linux-next and today we get this bug: >>> >>> The kernel version is 4.15.0-rc3-next-20171215 >>> >>> [ 235.397328] BUG: unab

[PATCH net-next 0/2] net: speedup geneve/vxlan tunnels dismantle

2017-12-16 Thread Haishuang Yan
This patch series add batching to vxlan/geneve tunnels so that netns dismantles are less costly. Haishuang Yan (2): vxlan: speedup vxlan tunnels dismantle geneve: speedup geneve tunnels dismantle drivers/net/geneve.c | 24 drivers/net/vxlan.c | 26 +-

[PATCH net-next 2/2] geneve: speedup geneve tunnels dismantle

2017-12-16 Thread Haishuang Yan
Since we now hold RTNL lock in geneve_exit_net, it's better batch them to speedup geneve tunnel dismantle. Signed-off-by: Haishuang Yan --- drivers/net/geneve.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve

[PATCH net-next 1/2] vxlan: speedup vxlan tunnels dismantle

2017-12-16 Thread Haishuang Yan
Since we now hold RTNL lock in vxlan_exit_net, it's better to batch them to speedup vxlan tunnels dismantle. Signed-off-by: Haishuang Yan --- drivers/net/vxlan.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxla

Re: BUG: unable to handle kernel NULL pointer dereference in fdb_find_rcu

2017-12-16 Thread Nikolay Aleksandrov
On 16/12/17 11:17, Nikolay Aleksandrov wrote: > On 16/12/17 02:37, Andrei Vagin wrote: >> Hi, >> >> We run criu tests for linux-next and today we get this bug: >> >> The kernel version is 4.15.0-rc3-next-20171215 >> >> [ 235.397328] BUG: unable to handle kernel NULL pointer dereference >> at 0

[PATCH net-next 1/1] forcedeth: remove duplicate structure member in xmit

2017-12-16 Thread Zhu Yanjun
Since both first_tx_ctx and tx_skb are the head of tx ctx, it not necessary to use two structure members to statically indicate the head of tx ctx. So first_tx_ctx is removed. CC: Srinivas Eeda CC: Joe Jin CC: Junxiao Bi Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/nvidia/forcedeth.c |

Re: BUG: unable to handle kernel NULL pointer dereference in fdb_find_rcu

2017-12-16 Thread Nikolay Aleksandrov
On 16/12/17 02:37, Andrei Vagin wrote: > Hi, > > We run criu tests for linux-next and today we get this bug: > > The kernel version is 4.15.0-rc3-next-20171215 > > [ 235.397328] BUG: unable to handle kernel NULL pointer dereference > at 000c > [ 235.398624] IP: fdb_find_rcu+0x3c/0x

Re: [B.A.T.M.A.N.] [RFC v3 0/4] flow_dissector: Provide basic batman-adv unicast handling

2017-12-16 Thread Sven Eckelmann
On Freitag, 15. Dezember 2017 17:51:19 CET Willem de Bruijn wrote: [] > Thanks for making these changes. The flow dissection looks good to me. > > One possible issue is that this exposes kernel fixed width types u8/u16/.. > to userspace. For posix compatibility reasons, uapi headers use the >

[PATCH net-next v5 5/5] qede: Use NETIF_F_GRO_HW.

2017-12-16 Thread Michael Chan
Advertise NETIF_F_GRO_HW and set edev->gro_disable according to the feature flag. Add qede_fix_features() to drop NETIF_F_GRO_HW if XDP is running or MTU does not support GRO_HW or GRO is not set. qede_change_mtu() also checks and disables GRO_HW if MTU is not supported. Cc: Ariel Elior Cc: ever

[PATCH net-next v5 4/5] bnx2x: Use NETIF_F_GRO_HW.

2017-12-16 Thread Michael Chan
Advertise NETIF_F_GRO_HW and turn on TPA_MODE_GRO when NETIF_F_GRO_HW is set. Disable NETIF_F_GRO_HW in bnx2x_fix_features() if the MTU does not support TPA_MODE_GRO or GRO is not set. bnx2x_change_mtu() also needs to disable NETIF_F_GRO_HW if the MTU does not support it. Original parameter disa

[PATCH net-next v5 3/5] bnxt_en: Use NETIF_F_GRO_HW.

2017-12-16 Thread Michael Chan
Advertise NETIF_F_GRO_HW in hw_features if hardware GRO is supported. In bnxt_fix_features(), disable GRO_HW and LRO if current hardware configuration does not allow it. GRO_HW depends on GRO. GRO_HW is also mutually exclusive with LRO. XDP setup will now rely on bnxt_fix_features() to turn off

[PATCH net-next v5 0/5] Introduce NETIF_F_GRO_HW

2017-12-16 Thread Michael Chan
Introduce NETIF_F_GRO_HW feature flag and convert drivers that support hardware GRO to use the new flag. v5: - Documentation changes requested by Alexander Duyck. - bnx2x changes requested by Manish Chopra to enable LRO by default, and disable GRO_HW if disable_tpa module parameter is set. v4: -

[PATCH net-next v5 1/5] net: Introduce NETIF_F_GRO_HW.

2017-12-16 Thread Michael Chan
Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware GRO. With this flag, we can now independently turn on or off hardware GRO when GRO is on. Previously, drivers were using NETIF_F_GRO to control hardware GRO and so it cannot be independently turned on or off without affecting GR

[PATCH net-next v5 2/5] net: Disable GRO_HW when generic XDP is installed on a device.

2017-12-16 Thread Michael Chan
Hardware should not aggregate any packets when generic XDP is installed. Cc: Ariel Elior Cc: everest-linux...@cavium.com Signed-off-by: Michael Chan --- net/core/dev.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 4b43f5d..c7db399