On Tue, Nov 14, 2017 at 05:59:36PM -0700, David Ahern wrote:
> Can you wait until said firmware version has been pushed into
> linux-firmware *before* sending these patches.
OK.
> Considering the driver refuses to work without the right firmware
> version this has a negative impact on users.
I'm
* Josef Bacik wrote:
> > > Then 'not crashing kernel' requirement will be preserved.
> > > btrfs or whatever else we will be testing with override_return
> > > will be functioning in 'stress test' mode and if bpf program
> > > is not careful and returns error all the time then one particular
> >
Kirill Tkhai writes:
> Curently mutex is used to protect pernet operations list. It makes
> cleanup_net() to execute ->exit methods of the same operations set,
> which was used on the time of ->init, even after net namespace is
> unlinked from net_namespace_list.
>
> But the problem is it's need
Hallo Benötigen Sie einen Kredit, um Schulden zu bekommen oder Ihre Rechnungen
zu bezahlen? Benötigen Sie ein Home / Car oder ein Business-Darlehen? Werden
Sie von einer Bank, Freunden oder Partner abgelehnt? Wir bieten alle Arten von
Darlehen zum Zinssatz von 2%, wenn Sie an einem Darlehen inte
On Tue, Nov 14, 2017 at 03:46:30PM -0500, Stephen Smalley wrote:
> Hi,
>
> 4.14 is failing the selinux-testsuite labeled IPSEC tests despite
> having just been fixed in commit cf37966751747727 ("xfrm: do
> unconditional template resolution before pcpu cache check"). The
> breaking commit is the v
Thanks, I will provide a new patch
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of David Miller
> Sent: Wednesday, November 15, 2017 1:20 PM
> To: Yuan, Linyu (NSB - CN/Shanghai)
> Cc: cug...@163.com; netdev@vger.kernel.org
> S
From: "Yuan, Linyu (NSB - CN/Shanghai)"
Date: Wed, 15 Nov 2017 05:15:35 +
>
>
>> -Original Message-
>> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
>> On Behalf Of David Miller
>> Sent: Wednesday, November 15, 2017 1:08 PM
>> To: cug...@163.com
>> Cc: net
From: "Gustavo A. R. Silva"
Date: Tue, 14 Nov 2017 14:26:16 -0600
> It seems that the intention of the code is to null check the value
> returned by function genlmsg_put. But the current code is null
> checking the address of the pointer that holds the value returned
> by genlmsg_put.
>
> Fix th
From: Stephen Hemminger
Date: Tue, 14 Nov 2017 11:27:00 -0800
> A couple of places where 64 bit CPU was being assumed incorrectly.
Series applied, thanks.
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
> On Behalf Of David Miller
> Sent: Wednesday, November 15, 2017 1:08 PM
> To: cug...@163.com
> Cc: netdev@vger.kernel.org; Yuan, Linyu (NSB - CN/Shanghai)
> Subject: Re: [PATCH net-next] net:
From: Kirill Tkhai
Date: Tue, 14 Nov 2017 16:51:56 +0300
> There is at least unlocked deletion of net->ipv4.fib_notifier_ops
> from net::fib_notifier_ops:
>
> ip_fib_net_exit()
> rtnl_unlock()
> fib4_notifier_exit()
> fib_notifier_ops_unregister(net->ipv4.notifier_ops)
> list_del_r
From: Stephen Hemminger
Date: Tue, 14 Nov 2017 08:25:49 -0800
> Make default TCP default congestion control to a per namespace
> value. This changes default congestion control to a pointer to congestion ops
> (rather than implicit as first element of available lsit).
>
> The congestion control s
From: yuan linyu
Date: Tue, 14 Nov 2017 22:30:59 +0800
> From: yuan linyu
>
> each netlink attribute have proper process when error happen,
> when exit on attribute process, it implies that no error,
> so err = 0; is useless.
>
> assign err = 0; at beginning if all attributes not set.
>
> Sig
From: Eric Dumazet
syzbot easily found a regression added in our latest patches [1]
No longer set tp->highest_sack to the head of the send queue since
this is not logical and error prone.
Only sack processing should maintain the pointer to an skb from rtx queue.
We might in the future only rem
Hi all,
After merging the net-next tree, today's linux-next build (powerpc
allyesconfig) produced this warning:
In file included from drivers/net/ethernet/ibm/ibmvnic.c:52:0:
drivers/net/ethernet/ibm/ibmvnic.c: In function 'ibmvnic_open':
include/linux/dma-mapping.h:571:2: warning: 'dma_addr' may
On Wed, 2017-11-15 at 13:47 +1100, Daniel Axtens wrote:
> Hi Bryant,
>
> This looks a bit better, but...
>
> > The following patch ensures that the bounce_buffer is not null
> > prior to using it within skb_copy_from_linear_data.
>
> How would this occur?
>
> Looking at ibmveth.c, I see bounce_
On Tue, 14 Nov 2017 19:04:36 -0800, Alexander Duyck wrote:
> On Tue, Nov 14, 2017 at 3:36 PM, Jakub Kicinski
> wrote:
> > On Tue, 14 Nov 2017 15:05:08 -0800, Alexander Duyck wrote:
> >> >> We basically need to do some feasability research to see if we can
> >> >> actually meet all the requiremen
Hi Shannon,
> Now that I think about this a little more, why is this not already
> getting handled by the NETDEV_CHANGEMTU notifier? In what case are you
> running into this, and why is it not triggering the notifier?
My commit message was probably not super clear here - apologies for any
mang
Kirill Tkhai writes:
> On 14.11.2017 21:39, Cong Wang wrote:
>> On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote:
>>> @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags,
>>>
>>> get_user_ns(user_ns);
>>>
>>> - rv = mutex_lock_killable(&net_mutex);
>>> + rv = d
On Thu, Nov 9, 2017 at 7:08 AM, Jesper Dangaard Brouer
wrote:
> On Wed, 08 Nov 2017 10:40:24 +0900 (KST)
> David Miller wrote:
>
>> From: Christina Jacob
>> Date: Sun, 5 Nov 2017 08:52:30 +0530
>>
>> > From: Christina Jacob
>> >
>> > Implements port to port forwarding with route table and arp
On Tue, Nov 14, 2017 at 3:36 PM, Jakub Kicinski
wrote:
> On Tue, 14 Nov 2017 15:05:08 -0800, Alexander Duyck wrote:
>> >> We basically need to do some feasability research to see if we can
>> >> actually meet all the requirements for switchdev on i40e. We have been
>> >> getting mixed messages whe
Hi Bryant,
This looks a bit better, but...
> The following patch ensures that the bounce_buffer is not null
> prior to using it within skb_copy_from_linear_data.
How would this occur?
Looking at ibmveth.c, I see bounce_buffer being freed in ibmveth_close()
and allocated in ibmveth_open() only.
On Wed, Nov 1, 2017 at 5:48 AM, Eric W. Biederman wrote:
> Eric Dumazet writes:
>
>> On Tue, 2017-10-31 at 09:14 -0700, Kees Cook wrote:
>>> Some protocols do not correctly wipe the contents of the on-stack
>>> struct sockaddr_storage sent down into recvmsg() (e.g. SCTP), and leak
>>> kernel stac
>> -static inline int dev_requeue_skb(struct sk_buff *skb, struct Qdisc *q)
>> +static inline int __dev_requeue_skb(struct sk_buff *skb, struct Qdisc *q)
>> {
>
> Perhaps dev_requeue_skb_qdisc_locked is more descriptive. Or
> adding a lockdep_is_held(..) also documents that the __locked variant
>
On Tue, Nov 14, 2017 at 7:11 PM, Willem de Bruijn
wrote:
> On Mon, Nov 13, 2017 at 3:08 PM, John Fastabend
> wrote:
>> sch_direct_xmit() uses qdisc_qlen as a return value but all call sites
>> of the routine only check if it is zero or not. Simplify the logic so
>> that we don't need to return an
This patch adapts the tc command line interface to allow bandwidth limits
to be specified as a percentage of the interface's capacity.
For this purpose, we've modified and moved int read_prop() from
ip/iptuntap.c to lib.utils.c to make it accessible to tc.
Additionally, adding this functionality
geneve->sock4/6 were added with geneve_open and released with geneve_stop.
So when geneve link down, we will not able to show remote address and
checksum info after commit 11387fe4a98 ("geneve: fix fill_info when using
collect_metadata").
Fix this by avoid passing *_REMOTE{,6} for COLLECT_METADATA
> /**
> * gnet_stats_copy_queue - copy queue statistics into statistics TLV
> diff --git a/net/sched/sch_mq.c b/net/sched/sch_mq.c
> index 213b586..bc59f05 100644
> --- a/net/sched/sch_mq.c
> +++ b/net/sched/sch_mq.c
> @@ -17,6 +17,7 @@
> #include
> #include
> #include
> +#include
>
> st
On Mon, Nov 13, 2017 at 3:10 PM, John Fastabend
wrote:
> Add qdisc qlen helper routines for lockless qdiscs to use.
>
> The qdisc qlen is no longer used in the hotpath but it is reported
> via stats query on the qdisc so it still needs to be tracked. This
> adds the per cpu operations needed.
>
>
From: Eric Dumazet
pcpu_freelist_pop() needs the same lockdep awareness than
pcpu_freelist_populate() to avoid a false positive.
[ INFO: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected ]
switchto-defaul/12508 [HC0[0]:SC0[6]:HE0:SE0] is trying to acquire:
(&htab->buckets[i].lock){..},
From: Jeff Kirsher
Date: Tue, 14 Nov 2017 14:03:37 -0800
> On Tue, 2017-11-14 at 23:52 +0200, Or Gerlitz wrote:
>> On Tue, Nov 14, 2017 at 9:03 PM, Jeff Kirsher
>> wrote:
>> > This series contains updates to i40e and i40evf only.
>>
>> see http://vger.kernel.org/~davem/net-next.html
>
> Your r
On 11/14/17 5:17 AM, David Miller wrote:
> From: Jiri Pirko
> Date: Sun, 12 Nov 2017 09:01:23 +0100
>
>> From: Jiri Pirko
>>
>> Ido says:
>>
>> This set adjusts the driver to use a new firmware version. The new
>> version includes various enhancements and fixes detailed in the first
>> patch.
>>
From: Stephen Hemminger
Date: Tue, 14 Nov 2017 08:37:13 -0800
> These are both old decrepit protocols that need to be sent
> to pasture.
These need to go to gregkh and his staging/ tree, not net-next.
From: Ahmed Abdelsalam
Date: Tue, 14 Nov 2017 15:31:48 +0100
> Also it will not make sense to have the field name differnent from the draft.
That is the danger of defining user facing things against a draft which
is constantly changing.
Sorry, we are stuck with the current name.
From: Edward Cree
Date: Tue, 14 Nov 2017 14:14:01 +
> On 14/11/17 12:37, David Miller wrote:
>> From: Ahmed Abdelsalam
>> Date: Sun, 12 Nov 2017 21:37:01 +0100
>>
>>> diff --git a/include/uapi/linux/seg6.h b/include/uapi/linux/seg6.h
>>> index 2f6fb0d..3f4b3ab 100644
>>> --- a/include/uapi/
> /* use instead of qdisc->dequeue() for all qdiscs queried with ->peek() */
> static inline struct sk_buff *qdisc_dequeue_peeked(struct Qdisc *sch)
> {
> - struct sk_buff *skb = sch->gso_skb;
> + struct sk_buff *skb = skb_peek(&sch->gso_skb);
>
> if (skb) {
> -
On Wed, Nov 08, 2017 at 10:31:04AM +, David Laight wrote:
> From: Chris Leech
> > Sent: 07 November 2017 22:45
> >
> > I've posted these changes to allow iSCSI management within a container
> > using a network namespace to the SCSI and Open-iSCSI lists, but seeing
> > as it's not really SCSI/b
On Tue, 2017-07-11 at 17:21 +0200, Enrico Mioso wrote:
> From: Enrico Mioso
>
> commit 2b02c20ce0c28974b44e69a2e2f5ddc6a470ad6f upstream.
[...]
> --- a/drivers/net/usb/cdc_ncm.c
> +++ b/drivers/net/usb/cdc_ncm.c
> @@ -724,8 +724,10 @@ int cdc_ncm_bind_common(struct usbnet *d
> u8 *buf;
>
On 11/14/17 9:18 AM, Jiri Pirko wrote:
> +static int
> +mlxsw_sp_resource_kvd_size_validate(struct devlink *devlink, u64 size,
> + struct list_head *resource_list,
> + struct netlink_ext_ack *extack)
> +{
> + struct mlxsw_core *mlx
On Mon, Nov 13, 2017 at 3:08 PM, John Fastabend
wrote:
> sch_direct_xmit() uses qdisc_qlen as a return value but all call sites
> of the routine only check if it is zero or not. Simplify the logic so
> that we don't need to return an actual queue length value.
>
> This introduces a case now where
On Tue, 14 Nov 2017 15:05:08 -0800, Alexander Duyck wrote:
> >> We basically need to do some feasability research to see if we can
> >> actually meet all the requirements for switchdev on i40e. We have been
> >> getting mixed messages where we are given a great many "yes, but" type
> >> answers. Fo
> static struct sk_buff *pfifo_fast_peek(struct Qdisc *qdisc)
> {
> struct pfifo_fast_priv *priv = qdisc_priv(qdisc);
> - int band = bitmap2band[priv->bitmap];
> + struct sk_buff *skb = NULL;
> + int band;
>
> - if (band >= 0) {
> - struct qdisc_skb_h
On Tue, 14 Nov 2017 12:00:32 -0800, Alexander Duyck wrote:
> On Tue, Nov 14, 2017 at 8:44 AM, Or Gerlitz wrote:
> > On Mon, Nov 13, 2017 at 7:10 PM, Alexander Duyck wrote:
> >> On Sun, Nov 12, 2017 at 10:16 PM, Or Gerlitz wrote:
> > Lets focus on this point for a moment before discussing the ot
2017-11-13 20:53 GMT-08:00 Tom Herbert :
> On Mon, Nov 13, 2017 at 7:45 PM, John Fastabend
> wrote:
>> On 11/13/2017 06:18 PM, Michael Ma wrote:
>>> 2017-11-13 16:13 GMT-08:00 Alexander Duyck :
On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet
wrote:
> On Mon, 2017-11-13 at 14:47 -0800
2017-11-13 19:45 GMT-08:00 John Fastabend :
> On 11/13/2017 06:18 PM, Michael Ma wrote:
>> 2017-11-13 16:13 GMT-08:00 Alexander Duyck :
>>> On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet
>>> wrote:
On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote:
> On Mon, Nov 13, 2017 at 10:17 A
On Tue, Nov 14, 2017 at 1:50 PM, Or Gerlitz wrote:
> On Tue, Nov 14, 2017 at 10:00 PM, Alexander Duyck
> wrote:
>> On Tue, Nov 14, 2017 at 8:44 AM, Or Gerlitz wrote:
>>> On Mon, Nov 13, 2017 at 7:10 PM, Alexander Duyck
>>> wrote:
On Sun, Nov 12, 2017 at 10:16 PM, Or Gerlitz wrote:
> O
2017-11-13 18:18 GMT-08:00 Michael Ma :
> 2017-11-13 16:13 GMT-08:00 Alexander Duyck :
>> On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet wrote:
>>> On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote:
On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote:
> 2017-11-12 16:14 GMT-08:00 S
On 11/14/17 12:25 PM, Daniel Borkmann wrote:
On 11/14/2017 07:15 PM, Yonghong Song wrote:
On 11/14/17 6:19 AM, Daniel Borkmann wrote:
On 11/14/2017 02:42 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Nov 14, 2017 at 02:09:34PM +0100, Daniel Borkmann escreveu:
On 11/14/2017 01:58 PM, Arnaldo C
On Tue 2017-11-14 01:49:47, tristram...@microchip.com wrote:
> > Subject: Microchip KSZ* DSA drivers Re: [PATCH v1 RFC 1/1] Add Microchip
> > KSZ8795 DSA driver
> >
> > Hi!
> >
> > Are there any news here? Is there new release planned? Is there a git
> > tree somewhere? I probably should get it w
On Tue, 14 Nov 2017 21:11:13 +
James Hogan wrote:
> On Tue, Nov 07, 2017 at 12:59:34PM -0800, Dave Taht wrote:
> > diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
> > index db0228a..443a75d 100644
> > --- a/net/sched/sch_netem.c
> > +++ b/net/sched/sch_netem.c
>
> ...
>
> > @@
On 11/14/17 8:03 AM, Oleg Nesterov wrote:
On 11/14, Oleg Nesterov wrote:
+#ifdef CONFIG_X86_64
+ if (test_thread_flag(TIF_ADDR32))
+ return -ENOSYS;
+#endif
No, this doesn't look right, see my previous email. You should do this
check in the "if (insn->length == 2)" bran
On 11/14/17 7:51 AM, Oleg Nesterov wrote:
On 11/13, Yonghong Song wrote:
+static int push_setup_xol_ops(struct arch_uprobe *auprobe, struct insn *insn)
+{
+ u8 opc1 = OPCODE1(insn), reg_offset = 0;
+
+ if (opc1 < 0x50 || opc1 > 0x57)
+ return -ENOSYS;
+
+ if (i
On 11/14/17 7:34 AM, Oleg Nesterov wrote:
On 11/13, Yonghong Song wrote:
On 11/13/17 4:59 AM, Oleg Nesterov wrote:
+ switch (opc1) {
+ case 0x50:
+ reg_offset = offsetof(struct pt_regs, r8);
+ break;
+ case
On Tue, Nov 14, 2017 at 10:00:59AM -0800, Eric Dumazet wrote:
> On Tue, 2017-11-14 at 09:44 -0800, Andrei Vagin wrote:
> > On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote:
> > > Curently mutex is used to protect pernet operations list. It makes
> > > cleanup_net() to execute ->exit met
On Tue, 2017-11-14 at 23:52 +0200, Or Gerlitz wrote:
> On Tue, Nov 14, 2017 at 9:03 PM, Jeff Kirsher
> wrote:
> > This series contains updates to i40e and i40evf only.
>
> see http://vger.kernel.org/~davem/net-next.html
Your right Or, I failed to look at the URL for the status of net-next.
I m
On Tue, Nov 14, 2017 at 11:13:10AM -0800, Tom Herbert wrote:
> On Tue, Nov 14, 2017 at 10:24 AM, Shaohua Li wrote:
> > On Wed, Nov 08, 2017 at 09:44:51AM -0800, Tom Herbert wrote:
> >> On Fri, Aug 18, 2017 at 3:27 PM, David Miller wrote:
> >> > From: Martin KaFai Lau
> >> > Date: Fri, 18 Aug 201
On Mon, 2017-11-13 at 17:40 -0500, Paul Moore wrote:
> On Mon, Nov 13, 2017 at 5:05 PM, Richard Haines
> wrote:
> > On Mon, 2017-11-06 at 19:09 -0500, Paul Moore wrote:
> > > On Tue, Oct 17, 2017 at 9:59 AM, Richard Haines
> > > wrote:
> > > > The SELinux SCTP implementation is explained in:
> >
On Tue, Nov 14, 2017 at 9:03 PM, Jeff Kirsher
wrote:
> This series contains updates to i40e and i40evf only.
see http://vger.kernel.org/~davem/net-next.html
On Tue, Nov 14, 2017 at 10:00 PM, Alexander Duyck
wrote:
> On Tue, Nov 14, 2017 at 8:44 AM, Or Gerlitz wrote:
>> On Mon, Nov 13, 2017 at 7:10 PM, Alexander Duyck
>> wrote:
>>> On Sun, Nov 12, 2017 at 10:16 PM, Or Gerlitz wrote:
On Sun, Nov 12, 2017 at 10:38 PM, Alexander Duyck
>>
The
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head: 74d5d28b9903cd48c22c04f887354a3d49621c13
commit: 47349198d7a879febab785a00c39c2de379f35c2 [1/9] virtio_balloon: fix
deadlock on OOM
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, November 14, 2017 11:58 AM
> To: Stephen Hemminger
> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; KY Srinivasan ; Haiyang
> Zhang ; Stephen Hemminger
>
On Tue, Nov 14, 2017 at 09:11:12PM +, James Hogan wrote:
> On Tue, Nov 07, 2017 at 12:59:34PM -0800, Dave Taht wrote:
> > diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
> > index db0228a..443a75d 100644
> > --- a/net/sched/sch_netem.c
> > +++ b/net/sched/sch_netem.c
>
> ...
>
> >
On Tue, Nov 14, 2017 at 11:27:00AM -0800, Stephen Hemminger wrote:
> A couple of places where 64 bit CPU was being assumed incorrectly.
>
> Stephen Hemminger (2):
> netem: fix 64 bit divide
> netem: remove unnecessary 64 bit modulus
>
> net/sched/sch_netem.c | 17 +++--
> 1 file
On Tue, Nov 07, 2017 at 12:59:34PM -0800, Dave Taht wrote:
> diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
> index db0228a..443a75d 100644
> --- a/net/sched/sch_netem.c
> +++ b/net/sched/sch_netem.c
...
> @@ -305,11 +305,11 @@ static bool loss_event(struct netem_sched_data *q)
> *
On 11/14/17 11:10 AM, Stefano Brivio wrote:
On Tue, 14 Nov 2017 10:30:33 -0800
Girish Moodalbail wrote:
On 11/14/17 5:21 AM, Nicolas Dichtel wrote:
With commits 35e015e1f577 and a2d3f3e33853, the global 'accept_dad' flag
is also taken into account (default value is 1). If either global or
per
Hi,
4.14 is failing the selinux-testsuite labeled IPSEC tests despite
having just been fixed in commit cf37966751747727 ("xfrm: do
unconditional template resolution before pcpu cache check"). The
breaking commit is the very next one, commit c9f3f813d462c72d ("xfrm:
Fix stack-out-of-bounds read in
On 14.11.2017 21:38, Andrei Vagin wrote:
> On Tue, Nov 14, 2017 at 09:04:06PM +0300, Kirill Tkhai wrote:
>> On 14.11.2017 20:44, Andrei Vagin wrote:
>>> On Tue, Nov 14, 2017 at 04:53:33PM +0300, Kirill Tkhai wrote:
Curently mutex is used to protect pernet operations list. It makes
cleanup
It seems that the intention of the code is to null check the value
returned by function genlmsg_put. But the current code is null
checking the address of the pointer that holds the value returned
by genlmsg_put.
Fix this by properly null checking the value returned by function
genlmsg_put in order
On 11/14/2017 07:15 PM, Yonghong Song wrote:
> On 11/14/17 6:19 AM, Daniel Borkmann wrote:
>> On 11/14/2017 02:42 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Tue, Nov 14, 2017 at 02:09:34PM +0100, Daniel Borkmann escreveu:
On 11/14/2017 01:58 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, No
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of David Ahern
> Sent: Tuesday, November 14, 2017 15:18
> To: Jon Maloy ; netdev@vger.kernel.org; Jiri
> Pirko
> Cc: David Miller (da...@davemloft.net)
> Subject: Re: Broken netl
On Tue, Nov 14, 2017 at 11:40 AM, Randy Dunlap wrote:
> On 11/14/2017 11:27 AM, Stephen Hemminger wrote:
>> A couple of places where 64 bit CPU was being assumed incorrectly.
>>
>> Stephen Hemminger (2):
>> netem: fix 64 bit divide
>> netem: remove unnecessary 64 bit modulus
>>
>> net/sched/s
On 11/14/17 1:15 PM, David Ahern wrote:
> On 11/14/17 12:19 PM, Jon Maloy wrote:
>> When I give the command:
>> ~$ tipc node set addr 1.1.2
>>
>> I get the following response:
>>
>> error: Numerical result out of range
>> Unable to get TIPC nl family id (module loaded?)
>> error, message initialisa
On 11/14/17 12:19 PM, Jon Maloy wrote:
> When I give the command:
> ~$ tipc node set addr 1.1.2
>
> I get the following response:
>
> error: Numerical result out of range
> Unable to get TIPC nl family id (module loaded?)
> error, message initialisation failed
tipc is sending a u32 for the famil
On 11/12/2017 01:34 PM, Wei Xu wrote:
> On Sat, Nov 11, 2017 at 03:59:54PM -0500, Matthew Rosato wrote:
This case should be quite similar with pkgten, if you got improvement with
pktgen, usually it was also the same for UDP, could you please try to
disable
tso, gso, gro, ufo on
On Tue, Nov 14, 2017 at 8:44 AM, Or Gerlitz wrote:
> On Mon, Nov 13, 2017 at 7:10 PM, Alexander Duyck
> wrote:
>> On Sun, Nov 12, 2017 at 10:16 PM, Or Gerlitz wrote:
>>> On Sun, Nov 12, 2017 at 10:38 PM, Alexander Duyck
>
>>> The what we call slow path requirements are the following:
>>>
>>> 1.
On 14.11.2017 21:39, Cong Wang wrote:
> On Tue, Nov 14, 2017 at 5:53 AM, Kirill Tkhai wrote:
>> @@ -406,7 +406,7 @@ struct net *copy_net_ns(unsigned long flags,
>>
>> get_user_ns(user_ns);
>>
>> - rv = mutex_lock_killable(&net_mutex);
>> + rv = down_read_killable(&net_sem);
>>
On 11/14/2017 11:27 AM, Stephen Hemminger wrote:
> A couple of places where 64 bit CPU was being assumed incorrectly.
>
> Stephen Hemminger (2):
> netem: fix 64 bit divide
> netem: remove unnecessary 64 bit modulus
>
> net/sched/sch_netem.c | 17 +++--
> 1 file changed, 7 inserti
On Tue, 2017-11-14 at 18:41 +, Colin King wrote:
> From: Colin Ian King
>
> The non-null check on tskb is redundant as it is in an else
> section of a check on tskb where tskb is always null. Remove
> the redundant if statement and the label coalesce.
>
> Detected by CoverityScan, CID#145775
On 11/14/17 12:19 PM, Jon Maloy wrote:
> commit 28033ae4e0f ("net: netlink: Update attr validation to require exact
> length for some types") breaks the netlink ABI.
It's not breaking the ABI; it's enforcing expected attributes based on
policy.
>
> When I give the command:
> ~$ tipc node set ad
Fix compilation on 32 bit platforms (where doing modulus operation
with 64 bit requires extra glibc functions) by truncation.
The jitter for table distribution is limited to a 32 bit value
because random numbers are scaled as 32 bit value.
Also fix some whitespace.
Fixes: 99803171ef04 ("netem: ad
Since times are now expressed in nanosecond, need to now do
true 64 bit divide. Old code would truncate rate at 32 bits.
Rename function to better express current usage.
Signed-off-by: Stephen Hemminger
---
net/sched/sch_netem.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
A couple of places where 64 bit CPU was being assumed incorrectly.
Stephen Hemminger (2):
netem: fix 64 bit divide
netem: remove unnecessary 64 bit modulus
net/sched/sch_netem.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
--
2.11.0
commit 28033ae4e0f ("net: netlink: Update attr validation to require exact
length for some types") breaks the netlink ABI.
When I give the command:
~$ tipc node set addr 1.1.2
I get the following response:
error: Numerical result out of range
Unable to get TIPC nl family id (module loaded?)
err
On Tue, Nov 14, 2017 at 10:24 AM, Shaohua Li wrote:
> On Wed, Nov 08, 2017 at 09:44:51AM -0800, Tom Herbert wrote:
>> On Fri, Aug 18, 2017 at 3:27 PM, David Miller wrote:
>> > From: Martin KaFai Lau
>> > Date: Fri, 18 Aug 2017 13:51:36 -0700
>> >
>> >> It seems like that middle box specifically
On Tue, 14 Nov 2017 10:30:33 -0800
Girish Moodalbail wrote:
> On 11/14/17 5:21 AM, Nicolas Dichtel wrote:
> > With commits 35e015e1f577 and a2d3f3e33853, the global 'accept_dad' flag
> > is also taken into account (default value is 1). If either global or
> > per-interface flag is non-zero, DAD w
On Tue, 14 Nov 2017 09:57:11 -0800
Randy Dunlap wrote:
> On 11/14/2017 09:28 AM, Stephen Hemminger wrote:
> > Since times are now expressed in 64 bit nanosecond, need to now do
> > true 64 bit divide. Change the name of the function to bette express
> > the new units.
> >
> > Fixes: 99803171ef04
On Tue, 2017-11-14 at 10:11 -0800, Stephen Hemminger wrote:
> On Tue, 14 Nov 2017 16:53:33 +0300
> Kirill Tkhai wrote:
>
> > + /*
> > +* RCU-protected list, modifiable by pernet-init and -exit methods.
> > +* When net namespace is alive (net::count > 0), all the changes
> > +* are m
On Tue, Nov 14, 2017 at 04:27:41PM +0800, Xin Long wrote:
> On Tue, Nov 14, 2017 at 3:54 AM, Marcelo Ricardo Leitner
> wrote:
> > On Mon, Nov 13, 2017 at 11:15:40PM +0800, Xin Long wrote:
> >> On Mon, Nov 13, 2017 at 11:09 PM, Neil Horman
> >> wrote:
> >> > On Mon, Nov 13, 2017 at 01:39:27PM +08
On 11/14/2017 9:03 AM, Shannon Nelson wrote:
On 11/14/2017 2:32 AM, Daniel Axtens wrote:
If a macvlan device which is not in bridge mode receives a packet,
it is sent straight to the lowerdev without checking against the
device's MTU. This also happens for multicast traffic.
Add an is_skb_forwa
From: Jacob Keller
We introduced the virtchnl interface in order to have an interface for
talking to a virtual device driver which was host-driver agnostic. This
interface has its own definitions, including one for link speed.
The host driver has to talk to the virtchnl interface using these new
From: Alice Michael
Bump the i40e driver from 2.1.14 to 2.3.2.
Bump the i40evf driver from 3.0.1 to 3.2.2
Signed-off-by: Alice Michael
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
drivers/net/ethernet/intel/i40evf/i40evf_
From: Jacob Keller
Since commit 96a39aed25e6 ("i40e: Acquire NVM lock before
reads on all devices") we've used the NVM lock
to synchronize NVM reads even on devices which don't strictly
need the lock.
Doing so can cause a regression on older firmware prior to 1.5,
especially when downgrading the
From: Colin Ian King
Variable read_size is initialized and this value is never read, it is
instead set inside the do-loop, hence the initialization is redundant
and can be removed. Cleans up clang warning:
drivers/net/ethernet/intel/i40e/i40e_nvm.c:390:6: warning: Value stored
to 'read_size' dur
From: Jacob Keller
Although not strictly necessary, it is customary to reverse the order in
which we release locks that we acquire. This helps preserve lock
ordering during future refactors, which can help avoid potential
deadlock situations.
Signed-off-by: Jacob Keller
Tested-by: Andrew Bowers
From: Jacob Keller
Stop overloading the __I40EVF_IN_CRITICAL_TASK bit lock to protect the
mac_filter_list and vlan_filter_list. Instead, implement a spinlock to
protect these two lists, similar to how we protect the hash in the i40e
PF code.
Ensure that every place where we access the list uses
From: Jacob Keller
We currently notify a VF of the link state after ENABLE_QUEUES, which is
the last thing a VF does after being configured. Guests may not actually
ENABLE_QUEUES until they get configured, and thus between driver load
and device configuration the VF may show inaccurate link statu
From: Alice Michael
Display some more stats that were already being counted, to help users
understand when priority xon/xoff packets are being sent/received
Signed-off-by: Alice Michael
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c |
From: Jacob Keller
If i40evf_open() is called quickly at the same time as a reset occurs
(such as via ethtool) it is possible for the device to attempt to open
while a reset is in progress. This occurs because the driver was not
holding the critical task bit lock during i40evf_open, nor was it
ho
From: Jacob Keller
In i40evf_reset_task we use netif_running() to determine whether or not
the device is currently up. This allows us to properly free queue memory
and shut down things before we request the hardware reset.
It turns out that we cannot be guaranteed of netif_running() returning
fa
This series contains updates to i40e and i40evf only.
Alice simply adds the displaying of additional stats that were already
being counted.
Jake provides several fixes and updates starting with fix to i40evf
where we might free data structures about device queues and other memory
before they have
1 - 100 of 244 matches
Mail list logo
