Re: iproute2 compile and linking errors on Fedora 19

2017-10-31 Thread Stephen Hemminger
On Tue, 31 Oct 2017 16:28:20 -0700 Cong Wang wrote: > On Tue, Oct 31, 2017 at 2:10 PM, Stephen Hemminger > wrote: > > > > IPPROTO_MH comes from include/uapi/linux/in6.h > > Maybe it is trying to use old kernel headers from libc. > > So newer iproute2 is not supposed to work with older > kerne

Re: [PATCH] net: recvmsg: Unconditionally zero struct sockaddr_storage

2017-10-31 Thread Willy Tarreau
On Tue, Oct 31, 2017 at 09:14:45AM -0700, Kees Cook wrote: > diff --git a/net/socket.c b/net/socket.c > index c729625eb5d3..34183f4fbdf8 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -2188,6 +2188,7 @@ static int ___sys_recvmsg(struct socket *sock, struct > user_msghdr __user *msg, >

Oops with HTB on net-next

2017-10-31 Thread Dave Taht
I am using a fairly complex htb + three tiers of fq_codel and a couple tc filters (it's the sqm-scripts "simple.qos" model). I rebased on net-next head an hour ago, and [8.357963] IPv6: ADDRCONF(NETDEV_CHANGE): enp2s0: link becomes ready [9.759942] u32 classifier [9.759944] Act

Re: [RFC 02/12] bpf: offload: add infrastructure for loading programs for a specific netdev

2017-10-31 Thread Jakub Kicinski
On Tue, 31 Oct 2017 22:23:42 -0700, Alexei Starovoitov wrote: > On Tue, Oct 31, 2017 at 06:52:07PM -0700, Jakub Kicinski wrote: > > The fact that we don't know which device the program is going > > to be used on is quite limiting in current eBPF infrastructure. > > We have to reverse or limit the c

Re: [PATCH net] tcp: fix tcp_mtu_probe() vs highest_sack

2017-10-31 Thread Yuchung Cheng
On Mon, Oct 30, 2017 at 11:17 PM, Alexei Starovoitov wrote: > > On Mon, Oct 30, 2017 at 11:08:20PM -0700, Eric Dumazet wrote: > > From: Eric Dumazet > > > > Based on SNMP values provided by Roman, Yuchung made the observation > > that some crashes in tcp_sacktag_walk() might be caused by MTU prob

Re: [RFC 02/12] bpf: offload: add infrastructure for loading programs for a specific netdev

2017-10-31 Thread Alexei Starovoitov
On Tue, Oct 31, 2017 at 06:52:07PM -0700, Jakub Kicinski wrote: > The fact that we don't know which device the program is going > to be used on is quite limiting in current eBPF infrastructure. > We have to reverse or limit the changes which kernel makes to > the loaded bytecode if we want it to be

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-10-31 Thread Alexei Starovoitov
On 10/31/17 8:45 AM, Josef Bacik wrote: From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific situations. Acco

Re: linux-next: manual merge of the net-next tree with the net tree

2017-10-31 Thread Cong Wang
On Tue, Oct 31, 2017 at 5:58 PM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/sched/cls_api.c > > between commit: > > 822e86d997e4 ("net_sched: remove tcf_block_put_deferred()") > > from the net tree and commit: > > 8c4083b30e

Re: [PATCH net-next v14] openvswitch: enable NSH support

2017-10-31 Thread Yang, Yi
On Wed, Nov 01, 2017 at 04:08:22AM +0800, Jiri Benc wrote: > On Mon, 30 Oct 2017 09:29:34 +0800, Yi Yang wrote: > > +static int set_nsh(struct sk_buff *skb, struct sw_flow_key *flow_key, > > + const struct nlattr *a) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + int

Re: [PATCH net-next v14] openvswitch: enable NSH support

2017-10-31 Thread Yang, Yi
On Wed, Nov 01, 2017 at 03:57:41AM +0800, Eric Garver wrote: > On Mon, Oct 30, 2017 at 09:29:34AM +0800, Yi Yang wrote: > [...] > > +int nsh_pop(struct sk_buff *skb) > > +{ > > + struct nshhdr *nh; > > + size_t length; > > + __be16 inner_proto; > > + > > + if (!pskb_may_pull(skb, NSH_BASE_H

[PATCH net-next v15] openvswitch: enable NSH support

2017-10-31 Thread Yi Yang
v14->v15 - Check size in nsh_hdr_from_nlattr - Fixed four small issues pointed out By Jiri and Eric v13->v14 - Rename skb_push_nsh to nsh_push per Dave's comment - Rename skb_pop_nsh to nsh_pop per Dave's comment v12->v13 - Fix NSH header length check in set_nsh v11->v12 - Fix missing chan

Re: [PATCH net-next] net: sit: Update lookup to handle links set to L3 slave

2017-10-31 Thread David Miller
From: David Ahern Date: Mon, 30 Oct 2017 10:07:17 -0700 > Using SIT tunnels with VRFs works fine if the underlay device is in a > VRF and the link parameter is set to the VRF device. e.g., > > ip tunnel add jtun mode sit remote local dev myvrf > > Update the device check to allow the link

Re: [PATCH] atm: iphase: Fix space before '[' error.

2017-10-31 Thread David Miller
From: Arvind Yadav Date: Mon, 30 Oct 2017 21:22:03 +0530 > Fix checkpatch.pl error: > ERROR: space prohibited before open square bracket '['. > > Signed-off-by: Arvind Yadav Applied.

Re: [PATCH net-next] net: bridge: add neigh_suppress to bridge port policies

2017-10-31 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 30 Oct 2017 12:56:33 +0200 > Add an entry for IFLA_BRPORT_NEIGH_SUPPRESS to bridge port policies. > > Fixes: 821f1b21cabb ("bridge: add new BR_NEIGH_SUPPRESS port flag to suppress > arp and nd flood") > Signed-off-by: Nikolay Aleksandrov Applied, thanks.

Re: [PATCH net-next 0/6] net: ppv2: various improvements

2017-10-31 Thread David Miller
From: Antoine Tenart Date: Mon, 30 Oct 2017 11:23:27 +0100 > This series includes various patches improving the Marvell PPv2 driver. > I send them as a series to avoid any possible merge conflict. > > - Patches 1 and 2 improve the initializing of the Tx and Rx FIFO. > - Patch 3 initialize the RS

Re: [patch net] mlxsw: reg: Add high and low temperature thresholds

2017-10-31 Thread David Miller
From: Jiri Pirko Date: Mon, 30 Oct 2017 10:51:18 +0100 > From: Ido Schimmel > > The ASIC has the ability to generate events whenever a sensor indicates > the temperature goes above or below its high or low thresholds, > respectively. > > In new firmware versions the firmware enforces a minimum

[PATCH net-next 5/7] cxgb4: add support to retrieve stats for hash filters

2017-10-31 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add support to retrieve packet-count and byte-count for hash-filters by retrieving filter-entry appropriately based on whether the request is for hash-filter or not. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/

[PATCH net-next 4/7] cxgb4: add support to delete hash filter

2017-10-31 Thread Rahul Lakkireddy
From: Kumar Sanghvi Use a combined ulptx work-request to send hash filter deletion request to hw. Hash filter deletion reply is processed on getting cpl_abort_rpl_rss. Release any L2T/SMT/CLIP entries on filter deletion. Also, free up the corresponding filter entry. Signed-off-by: Kumar Sanghvi

[PATCH net-next 2/7] cxgb4: initialize hash-filter configuration

2017-10-31 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add support for hash-filter configuration on T6. Also, do basic checks for the related initialization. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 6 ++ drivers/net/

[PATCH net-next 6/7] cxgb4: convert flower table to use rhashtable

2017-10-31 Thread Rahul Lakkireddy
From: Kumar Sanghvi T6 supports ~500K hash filters and can theoretically climb up to ~1 million hash filters. Preallocated hash table is not efficient in terms of memory usage. So, use rhashtable instead which gives the flexibility to grow based on usage. Signed-off-by: Kumar Sanghvi Signed-off

[PATCH net-next 3/7] cxgb4: add support to create hash filters

2017-10-31 Thread Rahul Lakkireddy
From: Kumar Sanghvi Add support to create hash (exact-match) filters based on the value of 'hash' field in ch_filter_specification. Allocate SMT/L2T entries if DMAC-rewrite/SMAC-rewrite is requested. Allocate CLIP entry in case of IPv6 filter. Use cpl_act_open_req[6] to send hash filter create

[PATCH net-next 1/7] cxgb4: save additional filter tuple field shifts in tp_params

2017-10-31 Thread Rahul Lakkireddy
From: Kumar Sanghvi Save additional filter tuple field shifts in tp_params based on configured filter tuple fields. Also, save the combined filter tuple mask based on configured filter tuple fields. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar ---

[PATCH net-next 7/7] cxgb4: add support to create hash-filters via tc-flower offload

2017-10-31 Thread Rahul Lakkireddy
From: Kumar Sanghvi Determine whether the flow classifies as exact-match with respect to 4-tuple and configured tuple mask in hw. If successfully classified as exact-match, offload the flow as hash-filter in hw. Signed-off-by: Kumar Sanghvi Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh

[PATCH net-next 0/7] cxgb4: add hash-filter support to tc-flower offload

2017-10-31 Thread Rahul Lakkireddy
This series of patches add support to create hash-filters; a.k.a exact-match filters, to tc-flower offload. T6 supports creating ~500K hash-filters in hw and can theoretically be expanded up to ~1 million. Patch 1 fetches and saves the configured hw filter tuple field shifts and filter mask. Pat

Re: [PATCH net 2/2] MAINTAINERS: Remove Yotam from mlxfw

2017-10-31 Thread David Miller
From: Yuval Mintz Date: Mon, 30 Oct 2017 11:41:37 +0200 > Provide a mailing list for maintenance of the module instead. > > Signed-off-by: Yuval Mintz Applied.

Re: [PATCH net 1/2] MAINTAINERS: Update Yotam's E-mail

2017-10-31 Thread David Miller
From: Yuval Mintz Date: Mon, 30 Oct 2017 11:41:36 +0200 > From: Yotam Gigi > > For the time being I will be available in my private mail. Update both the > MAINTAINERS file and the individual modules MODULE_AUTHOR directive with > the new address. > > Signed-off-by: Yotam Gigi > Signed-off-by

Re: [PATCH] net: hns: set correct return value

2017-10-31 Thread David Miller
From: Pan Bian Date: Mon, 30 Oct 2017 16:50:01 +0800 > The function of_parse_phandle() returns a NULL pointer if it cannot > resolve a phandle property to a device_node pointer. In function > hns_nic_dev_probe(), its return value is passed to PTR_ERR to extract > the error code. However, in this

Re: pull request (net-next): ipsec-next 2017-10-30

2017-10-31 Thread David Miller
From: Steffen Klassert Date: Mon, 30 Oct 2017 09:39:27 +0100 > 1) Change some variables that can't be negative >from int to unsigned int. From Alexey Dobriyan. > > 2) Remove a redundant header initialization in esp6. >From Colin Ian King. > > 3) Some BUG to BUG_ON conversions. >From

Re: net: lapbether: fix double free

2017-10-31 Thread David Miller
From: Pan Bian Date: Sun, 29 Oct 2017 21:57:22 +0800 > The function netdev_priv() returns the private data of the device. The > memory to store the private data is allocated in alloc_netdev() and is > released in netdev_free(). Calling kfree() on the return value of > netdev_priv() after netdev_f

Re: [PATCH] mkiss: remove redundant assignment of len to ax->mtu

2017-10-31 Thread David Miller
From: Colin King Date: Sun, 29 Oct 2017 13:30:25 + > From: Colin Ian King > > Variable len is being assigned a value that is never read, > hence the assignment is redundant and can be removed. Cleans > up clang warning: > > drivers/net/hamradio/mkiss.c:443:3: warning: Value stored to > 'le

Re: [PATCH net-next] net: dpaa: remove init which already done in per-cpu allocation

2017-10-31 Thread David Miller
From: yuan linyu Date: Sun, 29 Oct 2017 09:48:44 +0800 > From: yuan linyu > > Signed-off-by: yuan linyu Please compile test your patches and watch for warnings: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function ‘dpaa_eth_probe’: drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:2671:2

Re: [PATCH] net: dccp: ccids: lib: packet_history: use swap macro in tfrc_rx_hist_swap

2017-10-31 Thread David Miller
From: "Gustavo A. R. Silva" Date: Sat, 28 Oct 2017 15:48:47 -0500 > Make use of the swap macro and remove unnecessary variable tmp. > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH net-next] selftests/bpf: remove useless bpf_trace_printk

2017-10-31 Thread David Miller
From: Alexei Starovoitov Date: Sat, 28 Oct 2017 17:17:13 -0700 > sockmap test is using two programs that use bpf_trace_printk() > which prints into trace_pipe, but nothing is reading it. > Remove it. > > Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests") > Signed-off-by: Alexei Starovoitov

Re: [PATCH] net: decnet: dn_nsp_out: use swap macro in dn_mk_ack_header

2017-10-31 Thread David Miller
From: "Gustavo A. R. Silva" Date: Sat, 28 Oct 2017 15:39:48 -0500 > Make use of the swap macro and remove unnecessary variable tmp. > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH] net: decnet: dn_nsp_in: use swap macro in dn_nsp_rx_packet

2017-10-31 Thread David Miller
From: "Gustavo A. R. Silva" Date: Sat, 28 Oct 2017 14:38:45 -0500 > Make use of the swap macro and remove unnecessary variable tmp. > This makes the code easier to read and maintain. > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH net-next 1/1] forcedeth: replace pci_alloc_consistent with dma_alloc_coherent

2017-10-31 Thread David Miller
From: Zhu Yanjun Date: Sat, 28 Oct 2017 08:25:30 -0400 > The functions pci_alloc_consistent is obsolete. So it is replaced > with dma_alloc_coherent > > Signed-off-by: Zhu Yanjun Applied, thanks.

Re: [PATCH net-next] ip_vti: remove the useless err_count check in vti_xmit

2017-10-31 Thread David Miller
From: Xin Long Date: Sat, 28 Oct 2017 19:46:21 +0800 > Unlike ipip and gre, ip_vti never uses err_count in vti4_err, > so no need to check err_count in vti_xmit, it's value always 0. > > Signed-off-by: Xin Long Applied.

Re: [PATCH net-next] net: bcmgenet: Avoid calling platform_device_put() twice in bcmgenet_mii_exit()

2017-10-31 Thread David Miller
From: Wei Yongjun Date: Sat, 28 Oct 2017 05:05:46 + > Remove platform_device_put() call after platform_device_unregister() > from function bcmgenet_mii_exit(), otherwise, we will call > platform_device_put() twice. > > Fixes: 9a4e79697009 ("net: bcmgenet: utilize generic Broadcom UniMAC > MD

Re: [PATCH net-next] net: qualcomm: rmnet: Support recycling frames to real device

2017-10-31 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Fri, 27 Oct 2017 14:30:08 -0600 > For deaggregation, the real device receives a large linear skb and > passes it on to rmnet. rmnet creates new skbs from this large frame. > > If the real device supports recycling, it does not need to allocate > the lar

Re: [PATCH v2 net-next 0/3] net: Allow non-fatal messages to be passed in extack

2017-10-31 Thread David Miller
From: David Ahern Date: Fri, 27 Oct 2017 17:37:11 -0700 > There are many cases where networking subsystems throw non-fatal warning > messages that end up in dmesg / kernel log to which a user making the > change is completely oblivious. This set makes the extack facility > usable for returning su

Re: [PATCH net-next 0/7] net: dsa: add port parsing functions

2017-10-31 Thread David Miller
From: Vivien Didelot Date: Fri, 27 Oct 2017 15:55:12 -0400 > This patchset adds port parsing functions called early in the new > bindings parsing stage, which regroup all the fetching of static data > available at the port level, including the port's type, name and CPU > master interface. > > Th

Re: [PATCH 0/2][v2] Add the ability to do BPF directed error injection

2017-10-31 Thread David Miller
From: Alexei Starovoitov Date: Tue, 31 Oct 2017 18:58:00 -0700 > i don't think it will apply to anything but net-next. If it goes any > other tree we will have major conflicts during merge window. > btw I haven't reviewed them for the second time. Ok, then I'll need to seem some ACKs from the tr

Re: [net PATCH] bpf: remove SK_REDIRECT from UAPI

2017-10-31 Thread David Miller
From: John Fastabend Date: Tue, 31 Oct 2017 19:17:31 -0700 > Now that SK_REDIRECT is no longer a valid return code. Remove it > from the UAPI completely. Then do a namespace remapping internal > to sockmap so SK_REDIRECT is no longer externally visible. > > Patchs primary change is to do a namec

RE: [PATCH net v4 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-10-31 Thread Andy Duan
From: Troy Kisky Sent: Wednesday, November 01, 2017 4:17 AM >This is better for code locality and should slightly speed up normal >interrupts. > >This also allows PPS clock output to start working for i.mx7. This is because >i.mx7 was already using the limit of 3 interrupts, and needed another.

Re: [PATCH] net: vrf: correct FRA_L3MDEV encode type

2017-10-31 Thread David Miller
From: Jeff Barnhill <0xeff...@gmail.com> Date: Wed, 1 Nov 2017 01:24:14 + > FRA_L3MDEV is defined as U8, but is being added as a U32 attribute. On > big endian architecture, this results in the l3mdev entry not being > added to the FIB rules. > > Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev r

Re: [PATCH v2 net-next] bpf: reduce verifier memory consumption

2017-10-31 Thread David Miller
From: Alexei Starovoitov Date: Tue, 31 Oct 2017 18:16:05 -0700 > the verifier got progressively smarter over time and size of its internal > state grew as well. Time to reduce the memory consumption. > > Before: > sizeof(struct bpf_verifier_state) = 6520 > After: > sizeof(struct bpf_verifier_sta

Re: [PATCH net-next] tc-testing: split config file

2017-10-31 Thread Brenda Butler
On Tue, Oct 31, 2017 at 10:06 PM, David Miller wrote: > From: "Brenda J. Butler" > Date: Tue, 31 Oct 2017 14:27:28 -0400 > >> Move the config customization into a site-local file >> tdc_config_local.py, so that updates of the tdc test ... >> Signed-off-by: Brenda J. Butler > > Please always remo

Re: [PATCH V3 net-next 0/2] liquidio: switchdev support for LiquidIO NIC

2017-10-31 Thread David Miller
From: Felix Manlunas Date: Tue, 31 Oct 2017 16:04:20 -0700 > From: Vijaya Mohan Guvva > > patch1 of this patch set adds switchdev support for SRIOV capable > LiquidIO NIC, so that for every SRIOV VF on LiquidIO, a representor > netdev is created on hypervisor. It also has changes to send repres

Re: [pull request][net-next 00/14] Mellanox, mlx5e stats groups

2017-10-31 Thread David Miller
From: Saeed Mahameed Date: Tue, 31 Oct 2017 15:06:33 -0700 > The following series from Kamal introduces a refactoring and redesign for mlx5 > ethtool counters handling, for more information please see tag log below. > > Please pull and let me know if there's any problem. Pulled, thanks.

Re: [PATCH net-next] tc-testing: "show" action shows all selected tests

2017-10-31 Thread Brenda Butler
On Tue, Oct 31, 2017 at 10:17 PM, Brenda Butler wrote: > Sorry, I will redo. > > bjb > > > On Tue, Oct 31, 2017 at 10:07 PM, David Miller wrote: >> >> From: "Brenda J. Butler" >> Date: Tue, 31 Oct 2017 14:30:16 -0400 >> >> > The -s "show" option takes an argument to specify which test >> > to sh

[RFC] net: dummy: add BPF offload callbacks for test purposes

2017-10-31 Thread Jakub Kicinski
Add callbacks for BPF offload, a handful of checks and DebugFS files to be able to test BPF offload without any offload- -capable HW. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- This was a little useful for testing, I'm not sure we want it upstream, though? drivers/net/dummy.

Re: [PATCH net] net: phy: marvell: Only configure RGMII delays when using RGMII

2017-10-31 Thread David Miller
From: Andrew Lunn Date: Tue, 31 Oct 2017 20:31:28 +0100 > The fix 5987feb38aa5 ("net: phy: marvell: logical vs bitwise OR typo") > uncovered another bug in the Marvell PHY driver, which broke the > Marvell OpenRD platform. It relies on the bootloader configuring the > RGMII delays and does not sp

[net PATCH] bpf: remove SK_REDIRECT from UAPI

2017-10-31 Thread John Fastabend
Now that SK_REDIRECT is no longer a valid return code. Remove it from the UAPI completely. Then do a namespace remapping internal to sockmap so SK_REDIRECT is no longer externally visible. Patchs primary change is to do a namechange from SK_REDIRECT to __SK_REDIRECT Reported-by: Alexei Starovoito

Re: [patch net-next v3 2/2] net: core: introduce mini_Qdisc and eliminate usage of tp->q for clsact fastpath

2017-10-31 Thread Alexei Starovoitov
On Tue, Oct 31, 2017 at 04:12:22PM +0100, Jiri Pirko wrote: > From: Jiri Pirko > > In sch_handle_egress and sch_handle_ingress tp->q is used only in order > to update stats. So stats and filter list are the only things that are > needed in clsact qdisc fastpath processing. Introduce new mini_Qdis

Re: [net-next 0/9][pull request] 40GbE Intel Wired LAN Driver Updates 2017-10-31

2017-10-31 Thread David Miller
From: Jeff Kirsher Date: Tue, 31 Oct 2017 11:40:03 -0700 > This series contains updates to i40e, i40evf and net/sched. Pulled, thanks Jeff.

Re: [RFC v2 PATCH 04/11] net: Create and use new helper xfrm_dst_child().

2017-10-31 Thread David Miller
From: Eric Dumazet Date: Tue, 31 Oct 2017 11:39:22 -0700 > On Tue, 2017-10-31 at 23:10 +0900, David S. Miller wrote: >> @@ -116,12 +116,14 @@ EXPORT_SYMBOL(dst_alloc); >> >> struct dst_entry *dst_destroy(struct dst_entry * dst) >> { >> -struct dst_entry *child; >> +struct dst_entry *c

Re: [PATCH net-next] tc-testing: "show" action shows all selected tests

2017-10-31 Thread David Miller
From: "Brenda J. Butler" Date: Tue, 31 Oct 2017 14:30:16 -0400 > The -s "show" option takes an argument to specify which test > to show. Change the option so it does not take an argument, > but outputs all the tests that were selected with the other > arguments. > > It is still possible to outp

Re: [PATCH net-next] tc-testing: better check if thing is list

2017-10-31 Thread David Miller
From: "Brenda J. Butler" Date: Tue, 31 Oct 2017 14:28:35 -0400 > Check if tcase[k] is an instance of a list (is or is derived from list) > instead of checking if it is a list. > > This will be useful if the data structures change to be something > that implements list, instead of being an actual

Re: [PATCH net-next] tc-testing: better test case file error reporting

2017-10-31 Thread David Miller
From: "Brenda J. Butler" Date: Tue, 31 Oct 2017 14:29:03 -0400 > tdc.py reads a bunch of test cases in json files. When a json file > cannot be parsed, tdc just exits and does not run any tests. > > This patch will cause tdc to print a message with the file name and > line number, then that fil

Re: [PATCH net-next] tc-testing: correction to docstring in get_unique_item

2017-10-31 Thread David Miller
From: "Brenda J. Butler" Date: Tue, 31 Oct 2017 14:28:02 -0400 > Signed-off-by: Brenda J. Butler Applied.

Re: [PATCH net-next] tc-testing: split config file

2017-10-31 Thread David Miller
From: "Brenda J. Butler" Date: Tue, 31 Oct 2017 14:27:28 -0400 > Move the config customization into a site-local file > tdc_config_local.py, so that updates of the tdc test > software does not require hand-editing of the config. > This patch includes a template for the site-local > customization

Re: [PATCH net-next] tc-testing: very simple example test cases

2017-10-31 Thread David Miller
From: "Brenda J. Butler" Date: Tue, 31 Oct 2017 14:25:46 -0400 > As part of documentation, supply some very simple test cases > to illustrate how test cases work. One test case shows > commands in the setup, command, verify and teardown stages. > Other test cases show how to have a working test

Re: [PATCH net-next] tc-testing: gitignore, ignore standard python artifacts

2017-10-31 Thread David Miller
From: "Brenda J. Butler" Date: Tue, 31 Oct 2017 14:26:54 -0400 > Ignore .pyc files, "python compiled" files, that get created > when a python script is run. They should never be committed. > > Signed-off-by: Brenda J. Butler Applied.

Re: [PATCH net-next v4 0/3] Completed requested changes

2017-10-31 Thread David Miller
From: Manish Kurup Date: Tue, 31 Oct 2017 14:14:28 -0400 > Modified the netronome drivers (flower action) to use the VLAN helper > functions > instead of dereferencing the structure directly. This is required for the VLAN > action patch. > > Could you please review? Please simplify the subsyst

Re: [PATCH 0/2][v2] Add the ability to do BPF directed error injection

2017-10-31 Thread Alexei Starovoitov
On 10/31/17 6:55 PM, David Miller wrote: From: Josef Bacik Date: Tue, 31 Oct 2017 11:45:55 -0400 v1->v2: - moved things around to make sure that bpf_override_return could really only be used for an ftrace kprobe. - killed the special return values from trace_call_bpf. - renamed pc_modified t

Re: [PATCH net-next 0/4] l2tp: remove unused code

2017-10-31 Thread David Miller
From: Guillaume Nault Date: Tue, 31 Oct 2017 17:36:41 +0100 > Patch #1 removes the ref/deref mechanism that was originally used to > prevent ppp pseudowires from dropping their sockets. This mechanism > was error prone and isn't used anymore. > > Patch #2 removes some module specific refcount de

[RFC 08/12] nfp: bpf: refactor offload logic

2017-10-31 Thread Jakub Kicinski
We currently create a fake cls_bpf offload object when we want to offload XDP. Simplify and clarify the code by moving the TC/XDP specific logic out of common offload code. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/bpf/main.c| 62 +

[RFC 10/12] nfp: bpf: remove the register renumbering leftovers

2017-10-31 Thread Jakub Kicinski
The register renumbering was removed and will not be coming back in its old, naive form, given that it would be fundamentally incompatible with calling functions. Remove the leftovers. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/bpf/jit.c

[RFC 07/12] nfp: bpf: drop support for cls_bpf with legacy actions

2017-10-31 Thread Jakub Kicinski
Only support BPF_PROG_TYPE_SCHED_CLS programs in direct action mode. This simplifies preparing the offload since there will now be only one mode of operation for that type of program. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/netronome/nfp/bpf/jit.c

[RFC 09/12] nfp: bpf: require seamless reload for program replace

2017-10-31 Thread Jakub Kicinski
Firmware supports live replacement of programs for quite some time now. Remove the software-fallback related logic and depend on it for program replace. Seamless reload is required anyway if maps are present. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- drivers/net/ethernet/n

[RFC 06/12] cls_bpf: allow attaching programs loaded for specific device

2017-10-31 Thread Jakub Kicinski
If TC program is loaded with skip_sw flag, we should allow the device-specific programs to be accepted. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet --- kernel/bpf/syscall.c | 1 + net/sched/cls_bpf.c | 10 +++--- 2 files changed, 8 insertions(+), 3

Re: [PATCH 0/2][v2] Add the ability to do BPF directed error injection

2017-10-31 Thread David Miller
From: Josef Bacik Date: Tue, 31 Oct 2017 11:45:55 -0400 > v1->v2: > - moved things around to make sure that bpf_override_return could really only > be > used for an ftrace kprobe. > - killed the special return values from trace_call_bpf. > - renamed pc_modified to bpf_kprobe_state so bpf_overr

[RFC 12/12] bpf: remove old offload/analyzer

2017-10-31 Thread Jakub Kicinski
Thanks to the ability to load a program for a specific device, running verifier twice is no longer needed. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- include/linux/bpf_verifier.h | 4 --- kernel/bpf/verifier.c| 69 net/cor

[RFC 02/12] bpf: offload: add infrastructure for loading programs for a specific netdev

2017-10-31 Thread Jakub Kicinski
The fact that we don't know which device the program is going to be used on is quite limiting in current eBPF infrastructure. We have to reverse or limit the changes which kernel makes to the loaded bytecode if we want it to be offloaded to a networking device. We also have to invent new APIs for

[RFC 11/12] nfp: bpf: move to new BPF program offload infrastructure

2017-10-31 Thread Jakub Kicinski
Following steps are taken in the driver to offload an XDP program: XDP_SETUP_PROG: * prepare: - allocate program state; - run verifier (bpf_analyzer()); - run translation; * load: - stop old program if needed; - load program; - enable BPF if not enabled; * clean up: - free

[RFC 03/12] bpf: report offload info to user space

2017-10-31 Thread Jakub Kicinski
Extend struct bpf_prog_info to contain information about program being bound to a device. Since the netdev may get destroyed while program still exists we need a flag to indicate the program is loaded for a device, even if the device is gone. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horm

[RFC 01/12] net: bpf: rename ndo_xdp to ndo_bpf

2017-10-31 Thread Jakub Kicinski
ndo_xdp is a control path callback for setting up XDP in the driver. We can reuse it for other forms of communication between the eBPF stack and the drivers. Rename the callback and associated structures and definitions. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quen

[RFC 04/12] bpftool: print program device bound info

2017-10-31 Thread Jakub Kicinski
If program is bound to a device, print the name of the relevant interface or unknown if the netdev has since been removed. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/prog.c | 31 +++ tools/include/

[RFC 00/12] bpf: add offload as a first class citizen

2017-10-31 Thread Jakub Kicinski
Hi! This series is my stab at what was discussed at a recent IOvisor bi-weekly call. The idea is to make the device translator run at the program load time. This makes the offload more explicit to the user space. It also makes it easy for the device translator to insert information into the ori

[RFC 05/12] xdp: allow attaching programs loaded for specific device

2017-10-31 Thread Jakub Kicinski
Pass the netdev pointer to bpf_prog_get_type(). This way BPF code can decide whether the device matches what the code was loaded/translated for. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Reviewed-by: Quentin Monnet --- include/linux/bpf.h | 10 ++ kernel/bpf/syscall.c |

Re: pull-request: wireless-drivers 2017-10-31

2017-10-31 Thread David Miller
From: Kalle Valo Date: Tue, 31 Oct 2017 17:19:24 +0200 > here's a pull request to net tree for 4.14. Due to the ath10k security > issue I would like to get this to 4.14 still. > > Please let me know if there are any problems. Pulled, thanks a lot.

[PATCH] net: vrf: correct FRA_L3MDEV encode type

2017-10-31 Thread Jeff Barnhill
FRA_L3MDEV is defined as U8, but is being added as a U32 attribute. On big endian architecture, this results in the l3mdev entry not being added to the FIB rules. Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create") --- drivers/net/vrf.c | 2 +- 1 file changed, 1 insertion(+

[PATCH v2 net-next] bpf: reduce verifier memory consumption

2017-10-31 Thread Alexei Starovoitov
the verifier got progressively smarter over time and size of its internal state grew as well. Time to reduce the memory consumption. Before: sizeof(struct bpf_verifier_state) = 6520 After: sizeof(struct bpf_verifier_state) = 896 It's done by observing that majority of BPF programs use little to n

Re: [PATCH net-next] bpf: reduce verifier memory consumption

2017-10-31 Thread Alexei Starovoitov
On 10/31/17 5:37 AM, Edward Cree wrote: On 30/10/17 21:51, Alexei Starovoitov wrote: the verifier got progressively smarter over time and size of its internal state grew as well. Time to reduce the memory consumption. Before: sizeof(struct bpf_verifier_state) = 6520 After: sizeof(struct bpf_ver

linux-next: manual merge of the net-next tree with the net tree

2017-10-31 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/sched/cls_api.c between commit: 822e86d997e4 ("net_sched: remove tcf_block_put_deferred()") from the net tree and commit: 8c4083b30e56 ("net: sched: add block bind/unbind notif. and extended block_get/put") f

Re: removing bridge in vlan_filtering mode requests delete of attached ports main MAC address

2017-10-31 Thread Toshiaki Makita
On 2017/11/01 9:10, Keller, Jacob E wrote: >> -Original Message- >> From: Keller, Jacob E >> Sent: Thursday, October 26, 2017 1:33 PM >> To: Keller, Jacob E ; vyase...@redhat.com; >> netdev@vger.kernel.org >> Cc: Malek, Patryk >> Subject: RE: removing bridge in vlan_filtering mode requests

Re: [PATCH net-next 1/1] net sched qdisc: pass netlink message flags in event notification

2017-10-31 Thread Cong Wang
On Mon, Oct 30, 2017 at 2:17 PM, Roman Mashak wrote: > Cong Wang writes: > >> On Mon, Oct 30, 2017 at 11:07 AM, Roman Mashak wrote: >>> Cong Wang writes: >>> On Sat, Oct 28, 2017 at 8:36 PM, Roman Mashak wrote: > Cong Wang writes: Hmm, I thought you use RTM_NEWQDISC+RTM_DEL

Re: [patch net-next v2 08/20] net: sched: cls_bpf: call block callbacks for offload

2017-10-31 Thread Jakub Kicinski
On Thu, 19 Oct 2017 15:50:36 +0200, Jiri Pirko wrote: > @@ -159,17 +162,38 @@ static int cls_bpf_offload_cmd(struct tcf_proto *tp, > struct cls_bpf_prog *prog, > cls_bpf.exts_integrated = prog->exts_integrated; > cls_bpf.gen_flags = prog->gen_flags; > > - err = dev->netdev_ops->n

RE: removing bridge in vlan_filtering mode requests delete of attached ports main MAC address

2017-10-31 Thread Keller, Jacob E
> -Original Message- > From: Keller, Jacob E > Sent: Thursday, October 26, 2017 1:33 PM > To: Keller, Jacob E ; vyase...@redhat.com; > netdev@vger.kernel.org > Cc: Malek, Patryk > Subject: RE: removing bridge in vlan_filtering mode requests delete of > attached > ports main MAC address >

Re: iproute2 compile and linking errors on Fedora 19

2017-10-31 Thread Cong Wang
On Tue, Oct 31, 2017 at 2:10 PM, Stephen Hemminger wrote: > > IPPROTO_MH comes from include/uapi/linux/in6.h > Maybe it is trying to use old kernel headers from libc. So newer iproute2 is not supposed to work with older kernel header??

Re: [PATCH V3 net-next 0/2] liquidio: switchdev support for LiquidIO NIC

2017-10-31 Thread Jakub Kicinski
On Tue, 31 Oct 2017 16:04:20 -0700, Felix Manlunas wrote: > From: Vijaya Mohan Guvva > > patch1 of this patch set adds switchdev support for SRIOV capable > LiquidIO NIC, so that for every SRIOV VF on LiquidIO, a representor > netdev is created on hypervisor. It also has changes to send represent

Re: [PATCH net] net: phy: marvell: Only configure RGMII delays when using RGMII

2017-10-31 Thread Florian Fainelli
On 10/31/2017 12:31 PM, Andrew Lunn wrote: > The fix 5987feb38aa5 ("net: phy: marvell: logical vs bitwise OR typo") > uncovered another bug in the Marvell PHY driver, which broke the > Marvell OpenRD platform. It relies on the bootloader configuring the > RGMII delays and does not specify a phy-mod

Re: [RFC PATCH] xfrm: fix regression introduced by xdst pcpu cache

2017-10-31 Thread Florian Westphal
Paul Moore wrote: > On Mon, Oct 30, 2017 at 10:58 AM, Stephen Smalley wrote: > > matching before (as in this patch) or after calling xfrm_bundle_ok()? > > I would probably make the LSM call the last check, as you've done; but > I have to say that is just so it is consistent with the "LSM last" >

[PATCH V3 net-next 2/2] liquidio: Configure switchdev with devlink

2017-10-31 Thread Felix Manlunas
From: Vijaya Mohan Guvva Enable and disable switchdev on SRIOV capable LiquidIO NIC with devlink. Create representor netdev for each SRIOV VF function on SRIOV enable and and do the cleanup on SRIOV disable. Signed-off-by: Vijaya Mohan Guvva Signed-off-by: Satanand Burla Signed-off-by: Raghu V

[PATCH V3 net-next 1/2] liquidio: switchdev support for LiquidIO NIC

2017-10-31 Thread Felix Manlunas
From: Vijaya Mohan Guvva Enable switchdev for SRIOV capable LiquidIO NIC. It registers a representor netdev (with switchdev_ops) for each SRIOV VF created. It also has changes to send representor interface configurations like admin state and MTU to LiquidIO firmware and to retrieve HW counted VF

[PATCH V3 net-next 0/2] liquidio: switchdev support for LiquidIO NIC

2017-10-31 Thread Felix Manlunas
From: Vijaya Mohan Guvva patch1 of this patch set adds switchdev support for SRIOV capable LiquidIO NIC, so that for every SRIOV VF on LiquidIO, a representor netdev is created on hypervisor. It also has changes to send representor interface configurations like admin state and MTU to LiquidIO fir

Re: [Patch net 00/16] net_sched: fix races with RCU callbacks

2017-10-31 Thread Cong Wang
On Tue, Oct 31, 2017 at 3:09 PM, Cong Wang wrote: > > This almost rules out the guilty of this patchset. > > I will provide a patch for you to test, since I can't reproduce it here. > Lucas, please test the attached patch, it applies to latest -net. Note, it is a combination of 3 patches which t

Wir bieten jedem ein GÜNSTIGES Darlehnen zu TOP Konditionen an

2017-10-31 Thread Martin Kelly
Sehr geehrte Damen und Herren, Sie brauchen Geld? Sie sind auf der suche nach einem Darlehnen? Seriös und unkompliziert? Dann sind Sie hier bei uns genau richtig. Durch unsere jahrelange Erfahrung und kompetente Beratung sind wir Europaweit tätig. Wir bieten jedem ein GÜNSTIGES Darlehnen zu TOP

Re: v6/sit tunnels and VRFs

2017-10-31 Thread David Ahern
On 10/31/17 4:20 PM, Jeff Barnhill wrote: > I was surprised that nlmsg_parse in fib_nl_newrule() didn't pick this > up, but I verified that the received value for this attribute was 0, > not 1 (w/o the patch). It only checks minimum length, not exact length.

Re: v6/sit tunnels and VRFs

2017-10-31 Thread David Ahern
On 10/31/17 4:20 PM, Jeff Barnhill wrote: > Thanks, David. Those slides are extremely helpful. > > Also, I ran into a bug that manifested on big endian architecture: > > diff --git i/drivers/net/vrf.c w/drivers/net/vrf.c > index b23bb2fae5f8..a5f984689aee 100644 > --- i/drivers/net/vrf.c > +++ w

  1   2   3   4   >