This patch fixes a few indentation for Kconfig file in the
hisilicon folder.
Signed-off-by: Yunsheng Lin
---
drivers/net/ethernet/hisilicon/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/Kconfig
b/drivers/net/ethernet/hisilicon/K
This patch fixes a lot of endian issues detected by sparse.
Signed-off-by: Yunsheng Lin
---
.../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 8 +-
.../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 10 +-
.../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 206 -
..
The hclge_tm module has already added _cmd to the end of struct
that used to send cmd to firmware. This will help us finding the
endian issues.
This patch adds the _cmd to the end of struct that used to send
cmd to firmware in hclge_main module.
Signed-off-by: Yunsheng Lin
---
.../net/ethernet/h
This patch uses GENMASK to generate bit mask whenever
possible in hns3 driver.
Signed-off-by: Yunsheng Lin
---
.../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 48 +++---
.../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 4 +-
2 files changed, 26 insertions(+), 26 deletio
Hi Tim,
[auto build test ERROR on net-next/master]
[also build test ERROR on v4.14-rc4 next-20170929]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Tim-Hansen/net-core-Fix-BUG-to-BUG_ON-conditi
A recent patch removed the dst_free() on the allocated
dst_entry in ipv4_blackhole_route(). The dst_free() marked the
dst_entry as dead and added it to the gc list. I.e. it was setup
for a one time usage. As a result we may now have a blackhole
route cached at a socket on some IPsec scenarios. This
A recent patch removed the dst_free() on the allocated
dst_entry in ipv6_blackhole_route(). The dst_free() marked
the dst_entry as dead and added it to the gc list. I.e. it
was setup for a one time usage. As a result we may now have
a blackhole route cached at a socket on some IPsec scenarios.
This
On Mon, Oct 09, 2017 at 02:56:56PM +0900, Masahiro Yamada wrote:
> 2017-10-09 3:55 GMT+09:00 Leon Romanovsky :
> > On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote:
> >> 2017-10-09 2:00 GMT+09:00 David Miller :
> >> > From: Masahiro Yamada
> >> > Date: Mon, 9 Oct 2017 01:10:11 +090
On Mon, Oct 09, 2017 at 02:58:58PM +0900, Masahiro Yamada wrote:
> 2017-10-09 3:52 GMT+09:00 Leon Romanovsky :
> > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote:
> >
> > <...>
> >>
> >> By splitting out the radix_tree_root definition,
> >> we can reduce the header file dependency.
2017-10-09 3:52 GMT+09:00 Leon Romanovsky :
> On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote:
>
> <...>
>>
>> By splitting out the radix_tree_root definition,
>> we can reduce the header file dependency.
>>
>> Reducing the header dependency will help for speeding the kernel
>> buil
2017-10-09 3:55 GMT+09:00 Leon Romanovsky :
> On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote:
>> 2017-10-09 2:00 GMT+09:00 David Miller :
>> > From: Masahiro Yamada
>> > Date: Mon, 9 Oct 2017 01:10:11 +0900
>> >
>> >> The headers
>> >> - include/linux/mlx4/device.h
>> >> - driv
2017-10-09 2:32 GMT+09:00 Joe Perches :
> On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote:
>> The idea is simple; include necessary headers explicitly.
>
> Try that for kernel.h
>
> There's a reason aggregation of #includes is useful.
>
We should use a common sense for the balance betwee
On Wed, Sep 06, 2017 at 10:28:00PM +0200, Helge Deller wrote:
> The debug and error printk functions in ipvs uses wrongly the %pF instead of
> the %pS printk format specifier for printing symbols for the address returned
> by _builtin_return_address(0). Fix it for the ia64, ppc64 and parisc64
> arc
Some C libraries, like uClibc and musl, provide BSD compatible
strlcpy(). Add check_strlcpy() to configure, and avoid defining strlcpy
and strlcat when the C library provides them.
This fixes the following static link error with uClibc-ng:
.../sysroot/usr/lib/libc.a(strlcpy.os): In function `strl
On Wed, Oct 4, 2017 at 5:03 PM, William Tu wrote:
> Add erspan netlink interface for OVS.
>
> Signed-off-by: William Tu
> Cc: Pravin B Shelar
> ---
> v1->v2: remove unnecessary compat code.
Looks good to me.
Instead of calling mem_cgroup_sk_alloc() from BH context,
it is better to call it from inet_csk_accept() in process context.
Not only this removes code in mem_cgroup_sk_alloc(), but it also
fixes a bug since listener might have been dismantled and css_get()
might cause a use-after-free.
Fixes: e9
On Sun, Oct 8, 2017 at 9:44 PM, Eric Dumazet wrote:
> After TCP 3WHS became lockless, we should not attempt cgroup games
> from sk_clone_lock() since listener/cgroup might be already gone.
>
> Move this business to inet_csk_accept() where we have
> the guarantee both parent and child exist.
>
> Ma
From: "Jason A. Donenfeld"
Date: Fri, 29 Sep 2017 12:22:42 +0200
> One handy aspect of Netlink is that it's backwards compatible. This
> means that you can run old userspace utilities on new kernels, even if
> the new kernel supports new features and netlink attributes. The wire
> format is stabl
From: "Kalderon, Michal"
Date: Tue, 3 Oct 2017 18:05:32 +
> From: David Miller
> Sent: Tuesday, October 3, 2017 8:17 PM
>>> @@ -423,6 +423,41 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn
>>> *p_hwfn,
>>> }
>>>
>>> static int
>>> +qed_ll2_handle_slowpath(struct qed_hwfn *p_hwfn,
>>
After TCP 3WHS became lockless, we should not attempt cgroup games
from sk_clone_lock() since listener/cgroup might be already gone.
Move this business to inet_csk_accept() where we have
the guarantee both parent and child exist.
Many thanks to John Sperbeck for spotting these issues
Eric Dumaze
sk_clone_lock() might run while TCP/DCCP listener already vanished.
In order to prevent use after free, it is better to defer cgroup_sk_alloc()
to the point we know both parent and child exist, and from process context.
Fixes: e994b2f0fb92 ("tcp: do not lock listener to process SYN packets")
Sign
From: Christos Gkekas
Date: Sun, 8 Oct 2017 23:46:47 +0100
> dcb_app priority is unsigned thus checking whether it is less than zero
> is redundant.
>
> Signed-off-by: Christos Gkekas
Applied to net-next.
From: Tim Hansen
Date: Sun, 8 Oct 2017 16:03:38 -0400
> Mistakenly sent the patch previously with a missing semicolon.
> Apologies.
>
> Fix BUG() calls to use BUG_ON(conditional) macros.
>
> This was found using make coccicheck M=net/core on linux next
> tag next-20170929
>
> Signed-off-by: Ti
From: Christos Gkekas
Date: Sun, 8 Oct 2017 20:13:49 +0100
> Many macros in dwmac-ipq806x are unused and should be removed.
> Moreover gmac->id is an unsigned variable and therefore checking
> whether it is less than zero is redundant.
>
> Signed-off-by: Christos Gkekas
Applied.
From: Eric Dumazet
Date: Sat, 7 Oct 2017 19:30:22 -0700
> Sending IPv6 udp packets on non connected sockets is quite slow,
> because ipv6_dev_get_saddr() is still using an rwlock and silly
> references games on ifa.
>
> Tested:
>
> $ ./super_netperf 16 -H ::555:0786 -l 2000 -t UDP_STREAM -
From: Jakub Kicinski
Date: Sun, 8 Oct 2017 18:25:45 -0700
> On Sun, 8 Oct 2017 01:19:17 +0300, Alexey Dobriyan wrote:
>> Buffer length passed into this hook is always IFNAMSIZ which is 16.
>>
>> Code savings on x86_64:
>>
>> add/remove: 0/0 grow/shrink: 1/9 up/down: 2/-45 (-43)
>> fun
From: Jon Maloy
Date: Sat, 7 Oct 2017 14:32:49 +0200
> We change the initialization of the skb transmit buffer queues
> in the functions tipc_bcast_xmit() and tipc_rcast_xmit() to also
> initialize their spinlocks. This is needed because we may, during
> error conditions, need to call skb_queue_p
From: Jon Maloy
Date: Sat, 7 Oct 2017 15:07:20 +0200
> When a bundling message is received, the function tipc_link_input()
> calls function tipc_msg_extract() to unbundle all inner messages of
> the bundling message before adding them to input queue.
>
> The function tipc_msg_extract() just clon
From: Roopa Prabhu
Date: Fri, 6 Oct 2017 22:12:36 -0700
> From: Roopa Prabhu
>
> This series implements arp and nd suppression in the bridge
> driver for ethernet vpns. It implements rfc7432, section 10
> https://tools.ietf.org/html/rfc7432#section-10
> for ethernet VPN deployments. It is simi
From: Eric Dumazet
Date: Sun, 08 Oct 2017 21:07:18 -0700
> From: Eric Dumazet
>
> Ido reported following splat and provided a patch.
>
> [ 122.221814] BUG: using smp_processor_id() in preemptible [] code:
> sshd/2672
> [ 122.221845] caller is debug_smp_processor_id+0x17/0x20
> [ 12
From: Saeed Mahameed
Date: Fri, 6 Oct 2017 16:37:40 -0700
> This series includes some shared code updates for kernel 4.15 to both
> net-next and rdma-next trees.
I've pulled this into net-next, thanks Saeed.
From: Eric Dumazet
Ido reported following splat and provided a patch.
[ 122.221814] BUG: using smp_processor_id() in preemptible [] code:
sshd/2672
[ 122.221845] caller is debug_smp_processor_id+0x17/0x20
[ 122.221866] CPU: 0 PID: 2672 Comm: sshd Not tainted
4.14.0-rc3-idosch-next-c
Move the software reg helpers and some static data to nfp_asm.c.
They are related to the previous patch, but move is done in a separate
commit for ease of review.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/Makefile | 1 +
drivers/net/ethern
Limiting the eBPF offload to a single port was a workaround
required for the PoC application FW which has not been
released externally. It's not necessary any more.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/bpf/main.c | 8
1 file ch
Add encodings of all 64bit shift operations.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 48 +---
1 file changed, 36 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c
We need to append up to 8 nops after last instruction to make
sure the CPU will not fetch garbage instructions with invalid
ECC if the code store was not initialized.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 12 +++-
driv
In the initial PoC firmware I simply disabled ECC on the instruction
store. Do the ECC calculation for generated instructions in the driver.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 20 +++
drivers/net/ethernet/netro
Use standard devlink trace point to allow tracing of control
messages.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_app.h | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_app.h
b/drivers/net
Remove the register renumbering optimization. To implement calling
map and other helpers we need more strict register layout. We can't
freely reassign register numbers.
This will have the effect of running in 4 context/thread mode, which
should be OK since we are moving towards integrating the B
Most instructions have special fields which allow switching
between base and extended Local Memory pointers. Introduce
those to register encoding, we will use the extra LM pointers
to access high addresses of the stack.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/et
Datapath ABI version 2 stores the packet information in LMEM
instead of NNRs. We also have strict restrictions on which
GPRs we can use. Only GPRs 0-23 are reserved for BPF.
Adjust the static register locations and "ABI" registers.
Note that packet length is packed with other info so we have
to
We need to add longer OP_* defines, move the values away.
Purely whitespace commit.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/nfp_asm.h | 156 +--
1 file changed, 78 insertions(+), 78 deletions(-)
diff --git a/drivers
Define a new __bitwise type for software representation of registers.
This will allow us to catch incorrect parameter types using sparse.
Accessors we define also allow us to return correct enum type and
therefore ensure all switches handle all register types.
Signed-off-by: Jakub Kicinski
Revie
NFP LMEM is a large, indirectly accessed register file. There
are two basic indirect access registers. Each access operation
may either use offset (up to 8 or 16 words) or perform post
decrement/increment.
Add encodings of LMEM indexes as instruction operands.
Signed-off-by: Jakub Kicinski
Rev
Temporarily drop support for skb->mark. We are primarily focusing
on XDP offload, and implementing skb->mark on the new datapath has
lower priority.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 13 -
drivers/net/etherne
ld_field instruction is a bit special because the encoding uses
two source registers and one of them becomes the output. We do
need to pass the dst register to our encoding helpers though,
otherwise the "write both banks" flag will not be observed.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simo
Device expects the instructions in little endian. Make sure we
byte swap on big endian hosts.
Signed-off-by: Jakub Kicinski
Reviewed-by: Simon Horman
---
drivers/net/ethernet/netronome/nfp/bpf/jit.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/
Hi!
This series migrates our eBPF offload from old PoC firmware to
a redesigned, faster and more feature rich FW. Marking support
is dropped for now. We have to teach the JIT about encoding
local memory accesses (one of NFP memory types). There is also
code to populate the ECC of instructions
Le 10/08/17 à 20:23, Greg Ungerer a écrit :
> Hi Florian,
>
> On 07/10/17 13:04, Florian Fainelli wrote:
>> Le 10/03/17 à 23:20, Greg Ungerer a écrit :
>>> On Wed, Mar 29, 2017 at 04:30:16PM -0400, Vivien Didelot wrote:
All ports -- internal and external, for chips featuring a PVT -- have a
>
On Sun, 8 Oct 2017 20:47:10 -0700, Eric Dumazet wrote:
> This was discussed/reported earlier today by Ido.
>
> https://patchwork.ozlabs.org/patch/823011/
>
> We will submit an official fix shortly.
Ah, sorry, I missed that!
On Sun, Oct 8, 2017 at 8:43 PM, Jakub Kicinski wrote:
> Hi!
>
> This appeared in net-next over the weekend - looks likely related to
> this set...
>
> [ 164.456668] BUG: using smp_processor_id() in preemptible [] code:
> sshd/1255
> [ 164.472259] caller is ip6_pol_route+0xe88/0x4a80
> [
Hi!
This appeared in net-next over the weekend - looks likely related to
this set...
[ 164.456668] BUG: using smp_processor_id() in preemptible [] code:
sshd/1255
[ 164.472259] caller is ip6_pol_route+0xe88/0x4a80
[ 164.477571] CPU: 10 PID: 1255 Comm: sshd Not tainted
4.14.0-rc3-debu
Hi Florian,
On 07/10/17 13:04, Florian Fainelli wrote:
> Le 10/03/17 à 23:20, Greg Ungerer a écrit :
>> On Wed, Mar 29, 2017 at 04:30:16PM -0400, Vivien Didelot wrote:
>>> All ports -- internal and external, for chips featuring a PVT -- have a
>>> mask restricting to which internal ports a frame i
From: Troy Kisky Sent: Tuesday, October 03,
2017 8:05 AM
>To: shawn@linaro.org; Andy Duan ;
>netdev@vger.kernel.org; da...@davemloft.net
>Cc: Fabio Estevam ; lzn...@gmail.com; Troy Kisky
>
>Subject: [PATCH net v1 2/2] net: fec: Let fec_ptp have its own interrupt
>routine
>
>This is better for
> dcb_app priority is unsigned thus checking whether it is less than zero
> is redundant.
>
> Signed-off-by: Christos Gkekas
Thanks
Acked-By: Tomer Tayar
On Sun, 8 Oct 2017 01:19:17 +0300, Alexey Dobriyan wrote:
> Buffer length passed into this hook is always IFNAMSIZ which is 16.
>
> Code savings on x86_64:
>
> add/remove: 0/0 grow/shrink: 1/9 up/down: 2/-45 (-43)
> function old new delta
>
On Sun, 2017-10-08 at 15:54 -0700, Alexander Duyck wrote:
> From: Alexander Duyck
>
> This patch intoduces a slight adjustment for macvlan to address the fact
> that in source mode I was seeing two copies of any packet addressed to the
> macvlan interface being delivered where there should have b
Hi Tim,
[auto build test ERROR on net-next/master]
[also build test ERROR on v4.14-rc3 next-20170929]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Tim-Hansen/net-core-Fix-BUG-to-BUG_ON-conditi
From: Alexander Duyck
This patch intoduces a slight adjustment for macvlan to address the fact
that in source mode I was seeing two copies of any packet addressed to the
macvlan interface being delivered where there should have been only one.
The issue appears to be that one copy was delivered b
dcb_app priority is unsigned thus checking whether it is less than zero
is redundant.
Signed-off-by: Christos Gkekas
---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
b/drivers/net/ethern
Variable val is unsigned so checking whether it is less than zero is
redundant.
Signed-off-by: Christos Gkekas
---
drivers/net/wireless/ath/ath9k/debug.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/debug.c
b/drivers/net/wireless/ath/ath
Jiri / Ido:
I am looking at adding user messages for spectrum failures related to
RIF and VRF overflow coming from the inetaddr and inet6addr notifier
paths. The key is that if the notifiers fail the address add needs to
fail and an error reported to the user as to what happened.
Earlier this yea
Mistakenly sent the patch previously with a missing semicolon.
Apologies.
Fix BUG() calls to use BUG_ON(conditional) macros.
This was found using make coccicheck M=net/core on linux next
tag next-20170929
Signed-off-by: Tim Hansen
---
net/core/skbuff.c | 15 ++-
1 file changed, 6 i
Variable val is unsigned so checking whether it is less than zero is
redundant.
Signed-off-by: Christos Gkekas
---
drivers/net/wireless/ath/ath10k/spectral.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/spectral.c
b/drivers/net/wireless
Fix BUG() calls to use BUG_ON(conditional) macros.
This was found using make coccicheck M=net/core on linux next
tag next-20170929.
Signed-off-by: Tim Hansen
---
net/core/skbuff.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/net/core/skbuff.c b/net/core/sk
Many macros in dwmac-ipq806x are unused and should be removed.
Moreover gmac->id is an unsigned variable and therefore checking
whether it is less than zero is redundant.
Signed-off-by: Christos Gkekas
---
drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c | 14 +-
1 file changed, 1
On Mon, Oct 09, 2017 at 02:29:15AM +0900, Masahiro Yamada wrote:
> 2017-10-09 2:00 GMT+09:00 David Miller :
> > From: Masahiro Yamada
> > Date: Mon, 9 Oct 2017 01:10:11 +0900
> >
> >> The headers
> >> - include/linux/mlx4/device.h
> >> - drivers/net/ethernet/mellanox/mlx4/mlx4.h
> >> require th
On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote:
<...>
>
> By splitting out the radix_tree_root definition,
> we can reduce the header file dependency.
>
> Reducing the header dependency will help for speeding the kernel
> build, suppressing unnecessary recompile of objects during
On Thu, Sep 28, 2017 at 09:37:08AM +0200, Corentin Labbe wrote:
> On Wed, Sep 27, 2017 at 04:02:10PM +0200, Andrew Lunn wrote:
> > Hi Corentin
> >
> > > +Required properties for the mdio-mux node:
> > > + - compatible = "mdio-mux"
> >
> > This is too generic. Please add a more specific compatibl
On Sun, 2017-10-08 at 19:54 +0300, Ido Schimmel wrote:
> Hi Eric,
> > prev = cmpxchg(p, NULL, pcpu_rt);
> > - if (prev) {
> > - /* If someone did it before us, return prev instead */
> > - /* release refcnt taken by ip6_rt_pcpu_alloc() */
> > - dst_release_immed
On Mon, 2017-10-09 at 02:29 +0900, Masahiro Yamada wrote:
> The idea is simple; include necessary headers explicitly.
Try that for kernel.h
There's a reason aggregation of #includes is useful.
2017-10-09 2:00 GMT+09:00 David Miller :
> From: Masahiro Yamada
> Date: Mon, 9 Oct 2017 01:10:11 +0900
>
>> The headers
>> - include/linux/mlx4/device.h
>> - drivers/net/ethernet/mellanox/mlx4/mlx4.h
>> require the definition of struct radix_tree_root, but do not need to
>> know anything about
From: Alexey Kodanev
Date: Fri, 6 Oct 2017 19:02:35 +0300
> When gso_size reset to zero for the tail segment in skb_segment(), later
> in ipv6_gso_segment(), __skb_udp_tunnel_segment() and gre_gso_segment()
> we will get incorrect results (payload length, pcsum) for that segment.
> inet_gso_segm
From: Haiyang Zhang
Date: Fri, 6 Oct 2017 08:33:56 -0700
> From: Haiyang Zhang
>
> The patch set simplifies the existing hash level switching code for
> UDP. It also adds the support for changing TCP hash level. So users
> can switch between L3 an L4 hash levels for TCP and UDP.
Series applie
From: Jiri Pirko
Date: Sun, 8 Oct 2017 11:57:54 +0200
> From: Jiri Pirko
>
> Ido says:
>
> Add error messages to VLAN and bridge enslavements to help users
> understand why the enslavement failed.
Series applied, thanks for the repost.
From: Jiri Pirko
Date: Sun, 8 Oct 2017 11:53:26 +0200
> From: Ido Schimmel
>
> In commit fc922bb0dd94 ("mlxsw: spectrum_router: Use one LPM tree for
> all virtual routers") I increased the scale of supported VRFs by having
> all of them share the same LPM tree.
>
> In order to avoid look-ups
From: Sven Eckelmann
Date: Sun, 08 Oct 2017 09:29:17 +0200
> Are you expected to apply this change:
> =
>
> I was hoping that Simon is picking the patch up and forwards it do you in a
> proper pull request. But I would doubt that he has a big problem with you
From: Masahiro Yamada
Date: Mon, 9 Oct 2017 01:10:12 +0900
> The header include/linux/mlx5/driver.h requires the definition of
> struct radix_tree_root, but does not need to know anything about
> other radix tree stuff.
>
> Include instead of to
> reduce the number of included header files.
>
From: Masahiro Yamada
Date: Mon, 9 Oct 2017 01:10:11 +0900
> The headers
> - include/linux/mlx4/device.h
> - drivers/net/ethernet/mellanox/mlx4/mlx4.h
> require the definition of struct radix_tree_root, but do not need to
> know anything about other radix tree stuff.
>
> Include instead of
Hi Eric,
On Sun, Oct 08, 2017 at 09:03:53AM -0700, Eric Dumazet wrote:
> Thanks Ido for this patch.
>
> IMO, we no longer play this read_lock() -> write_lock() game since
> ip6_dst_gc() could be called from rt6_make_pcpu_route()
Right, cause we can't deadlock anymore as with the rwlock.
>
> So
The header include/linux/mlx5/driver.h requires the definition of
struct radix_tree_root, but does not need to know anything about
other radix tree stuff.
Include instead of to
reduce the number of included header files.
Also, add to include/linux/mlx5/gp.h where radix
tree accessors are used.
The motivation of this series is to cut down unnecessary header
dependency in terms of radix tree.
Sub-systems or drivers that use radix-tree for data management
typically embed struct radix_tree_root in their data structures,
like this:
struct foo {
...
struct radix_tree_root f
The headers
- include/linux/mlx4/device.h
- drivers/net/ethernet/mellanox/mlx4/mlx4.h
require the definition of struct radix_tree_root, but do not need to
know anything about other radix tree stuff.
Include instead of to
reduce the header dependency.
While we are here, let's add missing wher
On Sun, 2017-10-08 at 18:18 +0300, Ido Schimmel wrote:
> Without the rwlock and with PREEMPT_RCU we're no longer guaranteed to be
> in non-preemptible context when performing a route lookup, so use
> raw_cpu_ptr() instead.
>
> Takes care of the following splat:
> [ 122.221814] BUG: using smp_proc
On Fri, Sep 29, 2017 at 05:43:23AM -0400, Richard Cochran wrote:
> I happy to see this series. I just finished porting an out-of-tree
> PHC driver for the Marvell mv88e635x, and I want to mainline it, but I
> also have a few uglies.
This series looks really good. I won't even post my mine, as th
On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote:
> +void mv88e6xxx_port_txtstamp(struct dsa_switch *ds, int port,
> + struct sk_buff *clone, unsigned int type)
> +{
> + struct mv88e6xxx_chip *chip = ds->priv;
> + struct mv88e6xxx_port_hwtstamp *ps =
Without the rwlock and with PREEMPT_RCU we're no longer guaranteed to be
in non-preemptible context when performing a route lookup, so use
raw_cpu_ptr() instead.
Takes care of the following splat:
[ 122.221814] BUG: using smp_processor_id() in preemptible [] code:
sshd/2672
[ 122.221845
According to stmmac_main.c, the driver may sleep under a spinlock,
and the function call path is:
stmmac_suspend (acquire the spinlock)
stmmac_disable_all_queues
napi_disable
might_sleep --> may sleep
msleep --> may sleep
This bug is found by my static analysis tool and my code
On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote:
> We also utilize a feature of the "generation 3" PTP hardware that lets
> us to embed the timestamp value into one of the reserved fields in the
> PTP header. This lets us extract the timestamp out of the header and
> avoid an SMI ac
On 04/09/2017 1:42 AM, Pablo Neira Ayuso wrote:
From: Aaron Conole
This converts the storage and layout of netfilter hook entries from a
linked list to an array. After this commit, hook entries will be
stored adjacent in memory. The next pointer is no longer required.
The ops pointers are
There are some issues here.
On Thu, Sep 28, 2017 at 10:25:36AM -0500, Brandon Streiff wrote:
> +static int mv88e6xxx_config_periodic_trig(struct mv88e6xxx_chip *chip,
> + u32 ns, u16 picos)
> +{
> + int err;
> + u16 global_config;
> +
> + if (pico
On 10/8/17 1:43 AM, Arkadi Sharshevsky wrote:
> Thanks, will check it out. How many nexthops groups & overall number of
> nexthops you configured?
8 ports with 62 VLANs on each (496 total vlan devices) and 62 VRFs. BGP
is exchanging routes with neighbors. No multipath routes.
On Thu, Sep 28, 2017 at 10:25:34AM -0500, Brandon Streiff wrote:
> +static int mv88e6xxx_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
> +{
> + if (scaled_ppm == 0)
> + return 0;
> +
> + return -EOPNOTSUPP;
> +}
We really want to have an adjustable clock here. More
Since kernel net-next commit c7c0bbeae950 ("net: ipmr: Add MFC offload
indication") the kernel indicates on an MFC entry whether it was offloaded
using the RTNH_F_OFFLOAD flag. Update the "ip mroute show" command to
indicate when a route is offloaded, similarly to the "ip route show"
command.
Exam
Signed-off-by: Petr Vorel
---
testsuite/tests/ip/link/new_link.t| 2 +-
testsuite/tests/ip/link/show_dev_wo_vf_rate.t | 2 +-
testsuite/tests/ip/netns/set_nsid.t | 2 +-
testsuite/tests/ip/netns/set_nsid_batch.t | 2 +-
testsuite/tests/ip/route/add_default_route.t | 4 +
This fixes two regressions:
Commit 959f1428 ("color: add new COLOR_NONE and disable_color function")
caused segfault, when running ip with --color switch, as 'attr + 8' in
color_fprintf() access array item out of bounds.
Changing latter value of ternar operator in attr_colors[] index is for
restor
On Thu, Sep 28, 2017 at 10:25:33AM -0500, Brandon Streiff wrote:
> This patch implements support for accessing PTP/TAI registers through
To avoid confusion, it would be helpful to mention what TAI stands for
here and also in the source code comments!
Thanks,
Richard
On Thu, Sep 28, 2017 at 10:25:40AM -0500, Brandon Streiff wrote:
> +static bool mv88e6xxx_should_tstamp(struct mv88e6xxx_chip *chip, int port,
> + struct sk_buff *skb, unsigned int type)
> +{
> + struct mv88e6xxx_port_hwtstamp *ps = &chip->port_hwtstamp[port];
>
Signed-off-by: Bernd Edlinger
---
drivers/net/phy/Kconfig| 5 +++
drivers/net/phy/Makefile | 1 +
drivers/net/phy/uPD60620.c | 109 +
3 files changed, 115 insertions(+)
create mode 100644 drivers/net/phy/uPD60620.c
diff --git a/drivers/net/p
Hi Andrew,
sorry for delayed reply.
Looks like I did not receive a copy of your e-mail.
>> Do you suggest that there are cases where auto negotiation does not
>> reach completion, and still provides a usable link status?
>
> My experience is that it often return 10/half, since everything shou
1 - 100 of 121 matches
Mail list logo
