commit cc71b7b07119 ("net/ipv6: remove unused err variable on
icmpv6_push_pending_frames") exposed icmpv6_push_pending_frames
return value not being used.
Remove now unnecessary int err declarations and uses.
Miscellanea:
o Remove unnecessary goto and out: labels
o Realign arguments
Signed-off-
Since the upcoming rtx rbtree will add some extra code,
it is time to not inline this fat function anymore.
Signed-off-by: Eric Dumazet
---
include/net/tcp.h | 15 +--
net/ipv4/tcp.c| 14 ++
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/include/net/
This patch series implement RB-tree based retransmit queue for TCP,
to better match modern BDP.
Tested:
On receiver :
netem on ingress : delay 150ms 200us loss 1
GRO disabled to force stress and SACK storms.
for f in `seq 1 10`
do
./netperf -H lpaa6 -l30 -- -K bbr -o THROUGHPUT|tail -1
done
With upcoming rb-tree implementation, the checks will trigger
more often, and this is expected.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_input.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index
abc3b1db81f85a7feebda40c
It will be a bit more expensive to get the head of rtx queue
once rtx queue is converted to an rb-tree.
We can avoid this extra cost in case tp->lost_skb_hint is set.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_input.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
Geeralize private netem_rb_to_skb()
TCP rtx queue will soon be converted to rb-tree,
so we will need skb_rbtree_walk() helpers.
Signed-off-by: Eric Dumazet
---
include/linux/skbuff.h | 18 ++
net/ipv4/tcp_fastopen.c | 8 +++-
net/ipv4/tcp_input.c| 33 --
Using a linear list to store all skbs in write queue has been okay
for quite a while : O(N) is not too bad when N < 500.
Things get messy when N is the order of 100,000 : Modern TCP stacks
want 10Gbit+ of throughput even with 200 ms RTT flows.
40 ns per cache line miss means a full scan can use 4
No need to recompute previous skb, as it will be a bit more
expensive when rtx queue is converted to RB tree.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_input.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index
be764
tcp_write_queue_tail() call can be factorized.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index
f8ebae62f834ce6059d5bcf7dcb84988187dfbce..b8d379c8093661ccc4ef7fb82fa92828ab5f6918
100
From: Tim Hansen
Date: Thu, 5 Oct 2017 15:45:32 -0400
> int err is unused by icmpv6_push_pending_frames(), this patch returns removes
> the variable and returns the function with 0.
>
> git bisect shows this variable has been around since linux has been in git in
> commit 1da177e4c3f41524e886b
From: Lin Zhang
Date: Fri, 6 Oct 2017 02:07:08 +0800
> Storing the left length of skb into 'len' actually has no effect
> so we can remove it.
>
> Signed-off-by: Lin Zhang
Applied.
From: linux-rdma-ow...@vger.kernel.org on
behalf of David Miller
>From: "Kalderon, Michal"
>Date: Thu, 5 Oct 2017 20:27:22 +
>
>> The spinlock is required for the case that rx buffers are posted
>> from a different thread, where it could be run simultaneously to the
>> rxq_completion.
>
>T
On Wed, Oct 04, 2017 at 05:51:54PM -0700, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: Tariq Toukan
> Cc: netdev@vger.kern
During get_info_by_fd, the prog/map name is memcpy-ed. It depends
on the prog->aux->name and map->name to be zero initialized.
bpf_prog_aux is easy to guarantee that aux->name is zero init.
The name in bpf_map may be harder to be guaranteed in the future when
new map type is added.
Hence, this
Instead of u8, use char for prog and map name. It can avoid the
userspace tool getting compiler's signess warning. The
bpf_prog_aux, bpf_map, bpf_attr, bpf_prog_info and
bpf_map_info are changed.
Signed-off-by: Martin KaFai Lau
Cc: Jakub Kicinski
Acked-by: Daniel Borkmann
Acked-by: Alexei Sta
This patch makes the bpf_prog's name available
in kallsyms.
The new format is bpf_prog_tag[_name].
Sample kallsyms from running selftests/bpf/test_progs:
[root@arch-fb-vm1 ~]# egrep ' bpf_prog_[0-9a-fA-F]{16}' /proc/kallsyms
a0048000 t bpf_prog_dabf0207d1992486_test_obj_id
a003800
The first two patches make improvements on the bpf obj name.
The last patch adds the prog name to kallsyms.
Martin KaFai Lau (3):
bpf: Change bpf_obj_name_cpy() to better ensure map's name is init by
0
bpf: Use char in prog and map name
bpf: Append prog->aux->name in bpf_get_prog_name()
2017-10-04 10:49 GMT+03:00 James Chapman :
> On 3 October 2017 at 08:27, James Chapman wrote:
>> For capturing complete oops messages, have you tried setting up
>> netconsole? You might also find the full text in the syslog on reboot.
Why, thank you! You've just told me that Santa Claus exists :)
From: Craig Gallek
Date: Thu, 5 Oct 2017 10:41:56 -0400
> The functional change to this series is the ability to use flags when
> creating maps from object files loaded by libbpf. In order to do this,
> the first patch updates the library to handle map definitions that
> differ in size from lib
From: Dan Carpenter
Date: Thu, 5 Oct 2017 15:53:47 +0300
> The > should be >= so that we don't write one element beyond the end of
> the array.
>
> Fixes: 16e781224198 ("selftests/net: Add a test to validate behavior of rx
> timestamps")
> Signed-off-by: Dan Carpenter
Applied.
From: Colin King
Date: Thu, 5 Oct 2017 10:10:23 +0100
> From: Colin Ian King
>
> The function emac_isr is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warnings:
> symbol 'emac_isr' was not declared. Should it be static?
>
> Signed-off
From: Yuchung Cheng
Date: Wed, 4 Oct 2017 12:59:57 -0700
> This patch set improves the CPU consumption of the RACK TCP loss
> recovery algorithm, in particular for high-speed networks. Currently,
> for every ACK in recovery RACK can potentially iterate over all sent
> packets in the write queue.
From: Avinash Repaka
Date: Wed, 4 Oct 2017 12:11:29 -0700
> Use max_1m_mrs/max_8k_mrs while setting max_items, as the former
> variables are set based on the underlying device attributes.
>
> Signed-off-by: Avinash Repaka
> Acked-by: Santosh Shilimkar
Applied to net-next.
From: Avinash Repaka
Date: Wed, 4 Oct 2017 12:10:43 -0700
> This patch fixes the scope of has_fr and has_fmr variables as they are
> needed only in rds_ib_add_one().
>
> Signed-off-by: Avinash Repaka
> Acked-by: Santosh Shilimkar
Applied to net-next.
From: Tim Hansen
Date: Wed, 4 Oct 2017 15:59:49 -0400
> int rc is unmodified after initalization in net/ipv4/route.c, this patch
> simply cleans up that variable and returns 0.
>
> This was found with coccicheck M=net/ipv4/ on linus' tree.
>
> Signed-off-by: Tim Hansen
Applied to net-next.
From: Wei Wang
Date: Wed, 4 Oct 2017 10:03:44 -0700
> From: Wei Wang
>
> Currently in the TCP code, the initialization sequence for cached
> metrics, congestion control, BPF, etc, after successful connection
> is very inconsistent. This introduces inconsistent bevhavior and is
> prone to bugs.
From: Wei Wang
Date: Wed, 4 Oct 2017 10:04:04 -0700
> From: Wei Wang
>
> This commit does a cleanup and moves tcp_rearm_rto() call in the TFO
> server case into a previous spot in tcp_rcv_state_process() to make
> it more compact.
> This is only a cosmetic change.
>
> Suggested-by: Yuchung Ch
From: Finn Thain
Date: Thu, 5 Oct 2017 21:11:05 -0400 (EDT)
> Fix misplaced newlines in conditional log messages.
Please don't do this, the way the author formatted the strings
was intentional, they intended to print out:
NAME: cs89%c0%s rev %c found at %#8lx IRQ %d ADDR %pM
But now y
From: Stefan Hajnoczi
Date: Thu, 5 Oct 2017 16:46:49 -0400
> v3:
> * Rebased onto net-next/master and resolved Hyper-V transport conflict
>
> v2:
> * Moved tests to tools/testing/vsock/. I was unable to put them in
> selftests/
>because they require manual setup of a VMware/KVM guest.
>
On Fri, Oct 6, 2017 at 9:24 AM, Rafael J. Wysocki wrote:
>> On the other hand, the RP05 (root port) _PRW says it will wake up the
>> system via GPE09, and the _L09 handler at least has one codepath which
>> could potentially do a Notify(PXSX, 2) to indicate an ethernet wakeup.
>
> Which can only h
On Fri, Oct 6, 2017 at 8:16 AM, Francois Romieu wrote:
> Daniel Drake :
> [...]
>> Also, is there a standard behaviour defined for ethernet drivers
>> regarding wake-on-LAN? r8169 appears to enable wake-on-LAN by default
>> if it believes the hardware is capable of it,
>
> If so it isn't its desi
On Thu, Oct 5, 2017 at 10:57 AM, Daniel Drake wrote:
> Hi,
>
> On the Acer laptop models Aspire ES1-533, Aspire ES1-732, PackardBell
> ENTE69AP and Gateway NE533, we are seeing a problem where the system
> immediately wakes up after being put into S3 suspend.
>
> This problem has been seen on all
Fix misplaced newlines in conditional log messages.
Add missing printk severity levels.
Log the MAC address after the interface gets a meaningful name.
Drop deprecated "out of memory" message as per checkpatch advice.
Signed-off-by: Finn Thain
---
drivers/net/ethernet/cirrus/mac89x0.c | 26 +
The only version of smc9194.c with Mac support is the one in the
linux-mac68k CVS repo. AFAIK that driver never made it to the mainline.
Despite that, as of v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194
under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55.
(See pre-git era
Signed-off-by: Finn Thain
---
drivers/net/ethernet/cirrus/mac89x0.c | 47 ---
1 file changed, 16 insertions(+), 31 deletions(-)
diff --git a/drivers/net/ethernet/cirrus/mac89x0.c
b/drivers/net/ethernet/cirrus/mac89x0.c
index fa4b6968afd5..d331c8344b96 100644
---
Add missing printk severity levels.
Don't print the valid silicon revision number (it's in the source).
Avoid KERN_CONT usage as per advice from checkpatch.
Avoid ifdef around printk calls.
Cc: Thomas Bogendoerfer
Cc: Chris Zankel
Signed-off-by: Finn Thain
---
Only the macsonic.c changes have b
Signed-off-by: Finn Thain
---
drivers/net/ethernet/cirrus/mac89x0.c | 31 ---
1 file changed, 31 deletions(-)
diff --git a/drivers/net/ethernet/cirrus/mac89x0.c
b/drivers/net/ethernet/cirrus/mac89x0.c
index f910f0f386d6..4fd72c1a69f5 100644
--- a/drivers/net/ethernet
The patch which introduced the 8390 core module parameter 'msg_enable'
failed to do anything useful with it: it merely causes an ancient
version string to be logged.
Remove the other code that logs the same string. Use the msg_enable
module parameter as the default value for ei_local->msg_enable.
Log the MAC address after the interface gets a meaningful name
and in doing so, make the registration error path more idiomatic.
Drop redundant debug messages for FIFO events recorded in the
interface statistics (consistent with mace.c).
Signed-off-by: Finn Thain
Tested-by: Stan Johnson
---
dri
Also eliminate duplicated debug code by moving it into the core driver.
Cc: Thomas Bogendoerfer
Cc: Chris Zankel
Signed-off-by: Finn Thain
---
Only the sonic.[ch] and macsonic.c changes have been tested. The other
changes are similar but untested.
---
drivers/net/ethernet/natsemi/jazzsonic.c |
Before expansion, dev->name is "eth%d", so log the slot number instead.
Log the MAC address after the interface gets a meaningful name.
Disambiguate the two identical "Card type %s is unsupported" messages.
Fix the duplicated driver name in the pr_warn() message.
Fixes: 3a3a7f3b7fbd ("net: mac8390
This patch series fixes some logging bugs and adds some missing message
severity levels.
There are also cleanup patches for dead code and some Kconfig cruft.
Custom debug message logging is converted to netif_* calls to reduce
code duplication.
All up, about 150 lines of code are eliminated.
Th
From: Bjorn Andersson
Date: Wed, 4 Oct 2017 20:51:05 -0700
> +/**
> + * struct qrtr_hdr_v2 - (I|R)PCrouter packet header later versions
> + * @version: protocol version
> + * @type: packet type; one of QRTR_TYPE_*
> + * @flags: bitmask of QRTR_FLAGS_*
> + * @optlen: length of optional header dat
From: "Kalderon, Michal"
Date: Thu, 5 Oct 2017 20:27:22 +
> The spinlock is required for the case that rx buffers are posted
> from a different thread, where it could be run simultaneously to the
> rxq_completion.
This only brings us back to my original argument, if the lock is
necessary in
Daniel Drake :
[...]
> Also, is there a standard behaviour defined for ethernet drivers
> regarding wake-on-LAN? r8169 appears to enable wake-on-LAN by default
> if it believes the hardware is capable of it,
If so it isn't its designed behavior.
The r8169 driver does not enable specific WoL even
Explicitly casting pci_power_t types to resolve sparse warnings (shown
below).
Also fixing a related logging bug where pci_power_t is cast to unsigned
(can be negative, i.e. PCI_POWER_ERROR).
Original sparse report:
drivers/staging/irda/drivers//vlsi_ir.c:170:51: warning: cast from
restricted pc
On Thu, 5 Oct 2017 19:03:05 +0200
Matteo Croce wrote:
> Commit 35e015e1f577 ("ipv6: fix net.ipv6.conf.all interface DAD handlers")
> was intended to affect accept_dad flag handling in such a way that
> DAD operation and mode on a given interface would be selected
> according to the maximum value
On Thu, Sep 28, 2017 at 11:07:38PM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 09/28/2017 06:53 PM, Geert Uytterhoeven wrote:
>
> > The optional "reset-gpios" property (part of the generic MDIO bus
> > properties) lets us describe the GPIO used for resetting the Ethernet
> > PHY.
> >
> > Signe
while processing Rx = Ry instruction the verifier does
regs[insn->dst_reg] = regs[insn->src_reg]
which often clears write mark (when Ry doesn't have it)
that was just set by check_reg_arg(Rx) prior to the assignment.
That causes mark_reg_read() to keep marking Rx in this block as
REG_LIVE_READ (sin
> Looking at this some more, why can't mdio-mux-mmio be used?
Hi Rob
That was my first thought. And then i dug into the details. The mux is
more than just a couple of bits in an address space. Clocks needs to
be enabled/disabled, and the MAC needs a reset, when the mux changes.
So the mux needs i
> > > +static int dp83822_suspend(struct phy_device *phydev)
> > > +{
> > > + int value;
> > > +
> > > + mutex_lock(&phydev->lock);
> > > + value = phy_read_mmd(phydev, DP83822_DEVADDR,
> > > MII_DP83822_WOL_CFG);
> > > + mutex_unlock(&phydev->lock);
>
> > Would we need mutex to access phy_read_mm
On Wed, Sep 27, 2017 at 09:50:46PM -0700, Florian Fainelli wrote:
>
>
> On 09/27/2017 07:12 AM, Andrew Lunn wrote:
> > On Wed, Sep 27, 2017 at 09:34:14AM +0200, Corentin Labbe wrote:
> >> Each child node of an MDIO node is scanned as a PHY when calling
> >> of_mdiobus_register() givint the follow
Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device
is the length of the whole ether packet. So skb->len should subtract
the dev->hard_header_len.
Fixes: 1a66a836da63 ("gre: add collect_md mode to ERSPAN tunnel")
Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPA
On 10/05/2017 12:07 PM, Himanshu Jha wrote:
In this case, the key is CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS. It
seems that asm-generic/unaligned.h is set up to include different
headers, based on the expected architecture behavior.
Yes, asm-generic/unaligned.h looks more appopriate and is most
On Thu, Oct 05, 2017 at 04:23:45PM -0400, Patrick Talbert wrote:
> Network performance can suffer when a load balancing bond uses slave
> interfaces which are in different NUMA domains.
>
> This compares the NUMA domain of a newly enslaved interface against any
> existing enslaved interfaces and p
On 10/05/2017 11:26 PM, Jakub Kicinski wrote:
On Thu, 05 Oct 2017 23:10:03 +0200, Daniel Borkmann wrote:
include/linux/bpf_verifier.h | 7 +++--
kernel/bpf/verifier.c| 64
+++-
2 files changed, 50 insertions(+), 21 deletions(-)
diff --git
From: Jiri Pirko
Ido says:
Add error messages to VLAN and bridge enslavements to help users
understand why the enslavement failed.
Ido Schimmel (2):
mlxsw: spectrum: Add extack for VLAN enslavements
mlxsw: spectrum: Propagate extack further for bridge enslavements
drivers/net/ethernet/mel
From: Ido Schimmel
Similar to physical ports, enslavement of VLAN devices can also fail.
Use extack to indicate why the enslavement failed.
$ ip link add link enp1s0np1 name enp1s0np1.10 type vlan id 10
$ ip link add name bond0 type bond mode 802.3ad
$ ip link set dev enp1s0np1.10 master bond0
E
From: Ido Schimmel
The code that actually takes care of bridge offload introduces a few
more non-trivial constraints with regards to bridge enslavements.
Propagate extack there to indicate the reason.
$ ip link add link enp1s0np1 name enp1s0np1.10 type vlan id 10
$ ip link add link enp1s0np1 nam
On Thu, Oct 5, 2017 at 2:07 PM, Bjorn Helgaas wrote:
> On Wed, Oct 04, 2017 at 04:29:14PM -0700, Alexander Duyck wrote:
>> On Wed, Oct 4, 2017 at 4:01 PM, Bjorn Helgaas wrote:
>> > On Wed, Oct 04, 2017 at 08:52:58AM -0700, Tony Nguyen wrote:
>> >> This fixes a bug that can occur if an AER error i
On Thu, 05 Oct 2017 23:10:03 +0200, Daniel Borkmann wrote:
> > include/linux/bpf_verifier.h | 7 +++--
> > kernel/bpf/verifier.c| 64
> > +++-
> > 2 files changed, 50 insertions(+), 21 deletions(-)
> >
> > diff --git a/include/linux/bpf_verifier
(apologies to davem for the repeat; I accidentally did a reply vs.
reply-all the first time)
On Thu, Oct 5, 2017 at 1:05 PM, David Miller wrote:
> From: Rodney Cummings
> Date: Thu, 5 Oct 2017 18:41:48 +
>
>> The IEEE Std 802.1Q specs for credit-based shaper require precise transmit
>> deci
On Thu, Oct 5, 2017 at 6:59 AM, David Laight wrote:
> From: William Tu
>> Sent: 05 October 2017 01:14
>> Similarly to early patch for erspan_xmit(), the ARPHDR_ETHER device
>> is the length of the whole ether packet. So skb->len should subtract
>> the dev->hard_header_len.
>>
>> Fixes: 1a66a836da
Thu, Oct 05, 2017 at 09:57:34PM CEST, vinicius.go...@intel.com wrote:
>Hi Jiri,
>
>Jiri Pirko writes:
>
>> Wed, Oct 04, 2017 at 02:28:30AM CEST, vinicius.go...@intel.com wrote:
>>>This queueing discipline implements the shaper algorithm defined by
>>>the 802.1Q-2014 Section 8.6.8.2 and detailed in
On 10/05/2017 05:34 PM, Jakub Kicinski wrote:
Verifier log buffer can be quite large (up to 16MB currently).
As Eric Dumazet points out if we allow multiple verification
requests to proceed simultaneously, malicious user may use the
verifier as a way of allocating large amounts of unswappable
mem
On Wed, Oct 04, 2017 at 04:29:14PM -0700, Alexander Duyck wrote:
> On Wed, Oct 4, 2017 at 4:01 PM, Bjorn Helgaas wrote:
> > On Wed, Oct 04, 2017 at 08:52:58AM -0700, Tony Nguyen wrote:
> >> This fixes a bug that can occur if an AER error is encountered while SRIOV
> >> devices are present.
> >>
>
On Wed, Sep 27, 2017 at 09:34:04AM +0200, Corentin Labbe wrote:
> This patch restore dt-bindings documentation about dwmac-sun8i
> This reverts commit 8aa33ec2f481 ("dt-bindings: net: Revert sun8i dwmac
> binding")
What's missing here is why you are reverting?
>
> Signed-off-by: Corentin Labbe
This patch adds tests for the vsock_diag.ko module.
These tests are not self-tests because they require manual set up of a
KVM or VMware guest. Please see tools/testing/vsock/README for
instructions.
The control.h and timeout.h infrastructure can be used for additional
AF_VSOCK tests in the futu
There are two state fields: socket->state and sock->sk_state. The
socket->state field uses SS_UNCONNECTED, SS_CONNECTED, etc while the
sock->sk_state typically uses values that match TCP state constants
(TCP_CLOSE, TCP_ESTABLISHED). AF_VSOCK does not follow this convention
and instead uses SS_* c
This patch adds the sock_diag interface for querying sockets from
userspace. Tools like ss(8) and netstat(8) can use this interface to
list open sockets.
The userspace ABI is defined in and includes
netlink request and response structs. The request can query sockets
based on their sk_state (e.g
v3:
* Rebased onto net-next/master and resolved Hyper-V transport conflict
v2:
* Moved tests to tools/testing/vsock/. I was unable to put them in selftests/
because they require manual setup of a VMware/KVM guest.
* Moved to __vsock_in_bound/connected_table() to af_vsock.h
* Fixed local va
The socket table symbols need to be exported from vsock.ko so that the
vsock_diag.ko module will be able to traverse sockets.
Signed-off-by: Stefan Hajnoczi
---
include/net/af_vsock.h | 5 +
net/vmw_vsock/af_vsock.c | 10 ++
2 files changed, 11 insertions(+), 4 deletions(-)
diff
The vsock_diag.ko module will need to check socket table membership.
Signed-off-by: Stefan Hajnoczi
---
include/net/af_vsock.h | 12
net/vmw_vsock/af_vsock.c | 10 --
2 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/include/net/af_vsock.h b/include/net/af_v
From: David Miller
Sent: Thursday, October 5, 2017 10:06 PM
>> From: Kalderon, Michal
>> Sent: Tuesday, October 3, 2017 9:05 PM
>> To: David Miller
>>>From: David Miller
>>>Sent: Tuesday, October 3, 2017 8:17 PM
> @@ -423,6 +423,41 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn
> *
Network performance can suffer when a load balancing bond uses slave
interfaces which are in different NUMA domains.
This compares the NUMA domain of a newly enslaved interface against any
existing enslaved interfaces and prints a warning if they do not match.
Signed-off-by: Patrick Talbert
---
On 09/25/2017 04:18 PM, Matthew Rosato wrote:
> On 09/22/2017 12:03 AM, Jason Wang wrote:
>>
>>
>> On 2017年09月21日 03:38, Matthew Rosato wrote:
Seems to make some progress on wakeup mitigation. Previous patch tries
to reduce the unnecessary traversal of waitqueue during rx. Attached
p
Andrew
On 10/04/2017 06:53 PM, Andrew Lunn wrote:
> On Wed, Oct 04, 2017 at 10:44:36PM +, woojung@microchip.com wrote:
>>> +static int dp83822_suspend(struct phy_device *phydev)
>>> +{
>>> + int value;
>>> +
>>> + mutex_lock(&phydev->lock);
>>> + value = phy_read_mmd(phydev, DP83822_
Should be "802.3ad" like everywhere else in the document.
Signed-off-by: Axel Beckert
---
Documentation/networking/bonding.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/networking/bonding.txt
b/Documentation/networking/bonding.txt
index 57f52cdce32e..9ba0
Hi Jiri,
Jiri Pirko writes:
> Wed, Oct 04, 2017 at 02:28:30AM CEST, vinicius.go...@intel.com wrote:
>>This queueing discipline implements the shaper algorithm defined by
>>the 802.1Q-2014 Section 8.6.8.2 and detailed in Annex L.
>>
>>It's primary usage is to apply some bandwidth reservation to u
int err is unused by icmpv6_push_pending_frames(), this patch returns removes
the variable and returns the function with 0.
git bisect shows this variable has been around since linux has been in git in
commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2.
This was found by running make coccicheck
On 10/05/2017 04:10 AM, Colin King wrote:
From: Colin Ian King
The function emac_isr is local to the source and does not need to
be in global scope, so make it static.
Cleans up sparse warnings:
symbol 'emac_isr' was not declared. Should it be static?
Signed-off-by: Colin Ian King
ACK
--
Qu
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Paul Bolle
Cc: Karsten Keil
Cc: "David S. Miller"
Cc: Johan Hovold
Cc: gigaset307x-com...@lists.sour
This replaces a kmalloc followed by a bunch of per-field zeroing with a
single kzalloc call, reducing the lines of code.
Cc: Paul Bolle
Cc: Karsten Keil
Cc: "David S. Miller"
Cc: Johan Hovold
Cc: gigaset307x-com...@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook
---
On 10/05/2017 04:41 PM, Craig Gallek wrote:
From: Craig Gallek
This is required to use BPF_MAP_TYPE_LPM_TRIE or any other map type
which requires flags.
Signed-off-by: Craig Gallek
Acked-by: Daniel Borkmann
On 10/05/2017 04:41 PM, Craig Gallek wrote:
From: Craig Gallek
This library previously assumed a fixed-size map options structure.
Any new options were ignored. In order to allow the options structure
to grow and to support parsing older programs, this patch updates
the maps section parsing to
On Thu, Oct 5, 2017 at 12:58 AM, Paul Bolle wrote:
> Hi Kees,
>
> On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote:
>> Also uses kzmalloc to replace open-coded field assignments to NULL and zero.
>
> If I'm allowed to whine (chances that I'm allowed to do that are not so great
> as Dave tends to
No excuse. If the software cannot meet the standard's requirements, it is
non-conformant,
which means it cannot be called a standard credit-based shaper.
But... I have no objection if someone wants to try software-only. I'm just
saying that it
is a waste of time for me.
> -Original Message-
On Thu, Oct 05, 2017 at 11:02:50AM -0700, Brian Norris wrote:
> On Thu, Oct 05, 2017 at 08:52:33PM +0530, Himanshu Jha wrote:
> > There are various instances where a function used in file say for eg
> > int func_align (void* a)
> > is used and it is defined in align.h
> > But many files don't *dire
On Thu, Oct 05, 2017 at 09:16:31PM +0800, Herbert Xu wrote:
> On Thu, Oct 05, 2017 at 06:16:20PM +0800, Herbert Xu wrote:
> >
> > That was my point. Functions like sctp_pack_cookie shouldn't be
> > setting the key in the first place. The setkey should happen at
> > the point when the key is gener
From: "Kalderon, Michal"
Date: Thu, 5 Oct 2017 18:59:04 +
> From: Kalderon, Michal
> Sent: Tuesday, October 3, 2017 9:05 PM
> To: David Miller
>>From: David Miller
>>Sent: Tuesday, October 3, 2017 8:17 PM
@@ -423,6 +423,41 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn
*p_hw
From: Rodney Cummings
Date: Thu, 5 Oct 2017 18:41:48 +
> The IEEE Std 802.1Q specs for credit-based shaper require precise transmit
> decisions
> within a 125 microsecond window of time.
>
> Even with the Preempt RT patch or similar enhancements, that isn't very
> practical
> as software-o
From: Kalderon, Michal
Sent: Tuesday, October 3, 2017 9:05 PM
To: David Miller
>From: David Miller
>Sent: Tuesday, October 3, 2017 8:17 PM
>>> @@ -423,6 +423,41 @@ static void qed_ll2_rxq_parse_reg(struct qed_hwfn
>>> *p_hwfn,
>>> }
>>>
>>> static int
>>> +qed_ll2_handle_slowpath(struct qed_hwf
On Thu, 2017-10-05 at 20:06 +0300, Alexey Kodanev wrote:
> When gso_size reset to zero for the tail segment in skb_segment(), later
> in ipv6_gso_segment(), we will get incorrect payload_len for that segment.
> inet_gso_segment() already has a check for gso_size before calculating
> payload so fixi
The IEEE Std 802.1Q specs for credit-based shaper require precise transmit
decisions
within a 125 microsecond window of time.
Even with the Preempt RT patch or similar enhancements, that isn't very
practical
as software-only. I doubt that software would conform to the standard's
requirements.
T
On Fri, 28 Jul 2017 23:28:26 -0700, Roopa Prabhu wrote:
> On Fri, Jul 28, 2017 at 9:46 AM, Jakub Kicinski wrote:
> > On Fri, 28 Jul 2017 07:53:01 -0700, Roopa Prabhu wrote:
> >> On Thu, Jul 27, 2017 at 7:33 PM, Jakub Kicinski wrote:
> >> > On Thu, 27 Jul 2017 16:47:25 -0700, Roopa Prabhu wrot
From: Levi Pearson
Date: Thu, 5 Oct 2017 12:09:32 -0600
> It would be a shame if this were blocked due to a missing software
> implementation.
Quite the contrary, I think a software implementation is a minimum
requirement for inclusion of this feature.
Without a software implementation, there i
On 10/5/17 10:06 AM, Alexey Kodanev wrote:
When gso_size reset to zero for the tail segment in skb_segment(), later
in ipv6_gso_segment(), we will get incorrect payload_len for that segment.
inet_gso_segment() already has a check for gso_size before calculating
payload so fixing only IPv6 part.
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly. This introduces a pointer back to the
struct ip_set, which is used instead of the struct timer_list .data fie
On Thu, 2017-10-05 at 09:37 -0400, Stephen Smalley wrote:
> On Wed, 2017-10-04 at 11:29 -0700, Chenbo Feng wrote:
> > From: Chenbo Feng
> >
> > Introduce a bpf object related check when sending and receiving
> > files
> > through unix domain socket as well as binder. It checks if the
> > receivin
On Thu, Oct 5, 2017 at 6:58 AM, Jozsef Kadlecsik
wrote:
> Hi,
>
> On Wed, 4 Oct 2017, Kees Cook wrote:
>
>> In preparation for unconditionally passing the struct timer_list pointer
>> to all timer callbacks, switch to using the new timer_setup() and
>> from_timer() to pass the timer pointer explic
1 - 100 of 196 matches
Mail list logo
