Hi Florian,
On Sun, Oct 01, 2017 at 12:46:34PM -0700, Florian Fainelli wrote:
> Hi all,
>
> This patch series is sent as RFC since I have only been able to test LAG
> with dsa-loop and not with real HW yet (that should be tomorrow). I also
> looked at how the Marvell DSDT API is defined for addin
From: Stephen Hemminger
Date: Sun, 1 Oct 2017 14:07:34 -0700
> Make local functions static to fix
>
> HOSTCC samples/bpf/xdp_monitor_user.o
> samples/bpf/xdp_monitor_user.c:64:7: warning: no previous prototype for
> ‘gettime’ [-Wmissing-prototypes]
> __u64 gettime(void)
>^~~
>
From: Colin King
Date: Sun, 1 Oct 2017 17:27:35 +0100
> From: Colin Ian King
>
> In the unlikely event that mfc->mfc_un.res.ttls[i] is 255 for all
> values of i from 0 to MAXIVS-1, the err is not set at all and hence
> has a garbage value on the error return at the end of the function,
> so in
From: Jonas Gorski
Date: Sun, 1 Oct 2017 13:02:14 +0200
> This patch set fixes a few theoretical issues and cleans up the code a
> bit. It also adds a bit more managed function usage to simplify clock
> and iomem usage.
>
> Based on net-next.
Series applied.
From: Christophe JAILLET
Date: Sat, 30 Sep 2017 07:34:34 +0200
> If this sanity check fails, we must free 'rss_indir'. Otherwise there is a
> memory leak.
> 'goto err' as done in the other error handling paths to fix it.
>
> Fixes: 46a3df9f9718 ("net: hns3: Fix for setting rss_size incorrectly")
From: David Miller
Date: Sun, 01 Oct 2017 22:54:19 -0700 (PDT)
> From: Avinash Repaka
> Date: Fri, 29 Sep 2017 18:13:50 -0700
>
>> This patch fixes the scope of has_fr and has_fmr variables as they are
>> needed only in rds_ib_add_one().
>>
>> Signed-off-by: Avinash Repaka
>
> Applied.
Actu
From: Avinash Repaka
Date: Fri, 29 Sep 2017 18:13:50 -0700
> This patch fixes the scope of has_fr and has_fmr variables as they are
> needed only in rds_ib_add_one().
>
> Signed-off-by: Avinash Repaka
Applied.
From: Gregory CLEMENT
Date: Fri, 29 Sep 2017 14:27:39 +0200
> On Armada 7K/8K we need to explicitly enable the bus clock. The bus clock
> is optional because not all the SoCs need them but at least for Armada
> 7K/8K it is actually mandatory.
>
> The binding documentation is updating accordingly
From: Florian Westphal
Date: Fri, 29 Sep 2017 13:21:50 +0200
> @@ -1488,7 +1484,7 @@ static void netdev_release(struct device *d)
>
> BUG_ON(dev->reg_state != NETREG_RELEASED);
>
> - kfree(dev->ifalias);
> + kfree(rcu_access_pointer(dev->ifalias));
> netdev_freemem(dev);
>
On Sun, 1 Oct 2017 14:07:34 -0700
Stephen Hemminger wrote:
> Make local functions static to fix
>
> HOSTCC samples/bpf/xdp_monitor_user.o
> samples/bpf/xdp_monitor_user.c:64:7: warning: no previous prototype for
> ‘gettime’ [-Wmissing-prototypes]
> __u64 gettime(void)
>^~~
> sa
From: Grant Grundler
Date: Thu, 28 Sep 2017 11:35:00 -0700
> This linksys dongle by default comes up in cdc_ether mode.
> This patch allows r8152 to claim the device:
>Bus 002 Device 002: ID 13b1:0041 Linksys
>
> Signed-off-by: Grant Grundler
Applied, thanks.
On Sun, Oct 01, 2017 at 08:52:20PM -0400, Jérémy Lefaure wrote:
> On Mon, 2 Oct 2017 09:01:31 +1100
> "Tobin C. Harding" wrote:
>
> > > In order to reduce the size of the To: and Cc: lines, each patch of the
> > > series is sent only to the maintainers and lists concerned by the patch.
> > > This
From: Guillaume Nault
Date: Thu, 28 Sep 2017 15:44:38 +0200
> The l2tp_eth module crashes if its netlink callbacks are run when the
> pernet data aren't initialised.
>
> We should normally register_pernet_device() before the genl callbacks.
> However, the pernet data only maintain a list of l2tp
From: Xin Long
Date: Sun, 1 Oct 2017 22:00:52 +0800
> This patchset is to fix some issues that could cause 0 or low
> performance, and even unexpected truncated packets on erspan.
Series applied, thanks.
On Sun, 1 Oct 2017 17:59:09 -0700, Stephen Hemminger wrote:
> On Sun, 01 Oct 2017 22:19:20 - Michael Witten wrote:
>
>> +spin_lock_irqsave(&q->lock, flags);
>> +skb = q->next;
>> +__skb_queue_head_init(q);
>> +spin_unlock_irqrestore(&q->lock, flags);
>
> Other code manipulating
From: Roopa Prabhu
This series implements arp and nd suppression in the bridge
driver for ethernet vpns. It implements rfc7432, section 10
https://tools.ietf.org/html/rfc7432#section-10
for ethernet VPN deployments. It is similar to the existing
BR_ARP_PROXY flag but has a few semantic difference
From: Roopa Prabhu
This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to
suppress arp and nd flood on bridge ports. It implements
rfc7432, section 10.
https://tools.ietf.org/html/rfc7432#section-10
for ethernet VPN deployments. It is similar to the existing
BR_ARP_PROXY flag but has a few s
From: Roopa Prabhu
This patch avoids flooding and proxies ndisc packets
for BR_NEIGH_SUPPRESS ports.
Signed-off-by: Roopa Prabhu
---
net/bridge/br_arp_nd_proxy.c | 246 +++
net/bridge/br_device.c | 10 ++
net/bridge/br_input.c| 10 ++
net
From: Roopa Prabhu
This patch avoids flooding and proxies arp packets
for BR_NEIGH_SUPPRESS ports.
Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp
to support both proxy arp and neigh suppress.
Signed-off-by: Roopa Prabhu
---
net/bridge/br_arp_nd_proxy.c | 186 ++
Hi AceLan,
On Thu, Sep 28, 2017 at 4:28 PM, AceLan Kao wrote:
> Hi Daniel,
>
> I've tried your patch, but it doesn't work for me.
> Wifi can scan AP, but can't get connected.
Can you please clarify which patch(es) you have tried?
This is the base patch which adds the infrastructure to request
s
On 2017-10-01 07:25, Sergey K. wrote:
Hi Corey.
I did it on your recommendation, replaced xtables.h file from my
version of iptables 1.6.0, and replaced the file netfilter.h.
Now it's works, but new construction doesn't:
# tc filter add dev eth0 parent : u32 match u32 0 0 action xt -j
SET
On Fri, Sep 29, 2017 at 09:25:27PM -0400, Willem de Bruijn wrote:
> On Fri, Sep 29, 2017 at 3:38 PM, Michael S. Tsirkin wrote:
> > On Wed, Sep 27, 2017 at 08:25:56PM -0400, Willem de Bruijn wrote:
> >> From: Willem de Bruijn
> >>
> >> Vhost-net has a hard limit on the number of zerocopy skbs in f
On Sun, Oct 01, 2017 at 12:46:35PM -0700, Florian Fainelli wrote:
> Add the necessary logic to support network device events targetting LAG
> events,
> this is loosely inspired from mlxsw/spectrum.c.
>
> In the process we change dsa_slave_changeupper() to be more generic and be
> called
> from b
On Sun, Oct 01, 2017 at 02:07:34PM -0700, Stephen Hemminger wrote:
> Make local functions static to fix
>
> HOSTCC samples/bpf/xdp_monitor_user.o
> samples/bpf/xdp_monitor_user.c:64:7: warning: no previous prototype for
> ‘gettime’ [-Wmissing-prototypes]
> __u64 gettime(void)
>^~~
On Sun, Oct 01, 2017 at 02:02:30PM -0700, Stephen Hemminger wrote:
> Recent regression in net-next building bpf.c in samples/bpf now broken.
>
> $ make samples/bpf/
>
>
> HOSTCC samples/bpf/../../tools/lib/bpf/bpf.o
> samples/bpf/../../tools/lib/bpf/bpf.c: In function ‘bpf_create_map_node’:
>
On Sun, 01 Oct 2017 22:19:20 -
Michael Witten wrote:
> + spin_lock_irqsave(&q->lock, flags);
> + skb = q->next;
> + __skb_queue_head_init(q);
> + spin_unlock_irqrestore(&q->lock, flags);
Other code manipulating lists uses splice operation and
a sk_buff_head temporary on the s
On Mon, 2 Oct 2017 09:01:31 +1100
"Tobin C. Harding" wrote:
> > In order to reduce the size of the To: and Cc: lines, each patch of the
> > series is sent only to the maintainers and lists concerned by the patch.
> > This cover letter is sent to every list concerned by this series.
>
> Why don
Date: Sat, 9 Sep 2017 05:50:23 +
Hitherto, the queue's lock has been locked/unlocked every time
an item is dequeued; this seems not only inefficient, but also
incorrect, as the whole point of `skb_queue_purge()' is to clear
the queue, presumably without giving any other thread a chance to
manip
Date: Fri, 8 Sep 2017 00:47:49 +
The flag `MSG_DONTWAIT' is handled by passing an argument through
the dedicated parameter `nonblock' of the function `tcp_recvmsg()'.
Presumably because `MSG_DONTWAIT' is handled so explicitly, it is
unset in the collection of flags that are passed to `tcp_recv
Date: Thu, 7 Sep 2017 03:21:38 +
Signed-off-by: Michael Witten
---
include/net/sock.h | 2 +-
net/core/sock.c| 4 ++--
net/ipv4/ip_sockglue.c | 2 +-
net/ipv6/datagram.c| 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/include/net/sock.h b/include/net/sock
The following patch series is an ad hoc "cleanup" that I made
while perusing the code (I'm not well versed in this code, so I
would not be surprised if there were objections to the changes):
[1] net: __sock_cmsg_send(): Remove unused parameter `msg'
[2] net: inet_recvmsg(): Remove unnecessary
Handling of SIOC{ADD,DEL}RT for 32bit is somewhat odd. AFAICS,
the rules for native ioctl look so:
AF_APPLETALK, AF_INET, AF_IPX, AF_PACKET: take struct rtentry. The last one
doesn't have ->compat_ioctl() and 32bit automatically hits routing_ioctl()
in net/socket.c, the rest have ->compa
On Sun, Oct 01, 2017 at 03:30:38PM -0400, Jérémy Lefaure wrote:
> Hi everyone,
> Using ARRAY_SIZE improves the code readability. I used coccinelle (I
> made a change to the array_size.cocci file [1]) to find several places
> where ARRAY_SIZE could be used instead of other macros or sizeof
> divisio
Make local functions static to fix
HOSTCC samples/bpf/xdp_monitor_user.o
samples/bpf/xdp_monitor_user.c:64:7: warning: no previous prototype for
‘gettime’ [-Wmissing-prototypes]
__u64 gettime(void)
^~~
samples/bpf/xdp_monitor_user.c:209:6: warning: no previous prototype for
‘print
Recent regression in net-next building bpf.c in samples/bpf now broken.
$ make samples/bpf/
HOSTCC samples/bpf/../../tools/lib/bpf/bpf.o
samples/bpf/../../tools/lib/bpf/bpf.c: In function ‘bpf_create_map_node’:
samples/bpf/../../tools/lib/bpf/bpf.c:76:13: error: ‘union bpf_attr’ has no
membe
On Fri, 29 Sep 2017 13:41:05 +0200 (CEST)
Michal Kubecek wrote:
> When SA is added manually using "ip xfrm state add", xfrm_state_modify()
> uses alg_key_len field of struct xfrm_algo for the length of key passed to
> kernel in the netlink message. However alg_key_len is bit length of the key
> w
On Sat, 30 Sep 2017 20:18:40 -0700
Yulia Kartseva wrote:
> Wrong TCA_U32_SEL attribute packing if prefixLen AND 0x1f equals 0x1f.
> These are /31, /63, /95 and /127 prefix lengths.
>
> Example:
> ip6 dst face:b00f::/31
> filter parent b: protocol ipv6 pref 2307 u32
> filter parent b: protocol i
From: Markus Elfring
Date: Sun, 1 Oct 2017 21:35:18 +0200
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was dete
From: Markus Elfring
Date: Sun, 1 Oct 2017 21:31:32 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/atm/adummy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a
From: Markus Elfring
Date: Sun, 1 Oct 2017 21:43:21 +0200
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/atm/adummy.c | 5 +
1 file changed,
Hi all,
This patch series is sent as RFC since I have only been able to test LAG
with dsa-loop and not with real HW yet (that should be tomorrow). I also
looked at how the Marvell DSDT API is defined for adding ports to "trunk"
groups and the API proposed here should work there too. Can't speak ab
Add the necessary logic to support network device events targetting LAG events,
this is loosely inspired from mlxsw/spectrum.c.
In the process we change dsa_slave_changeupper() to be more generic and be
called
from both LAG events as well as normal bridge enslaving events paths.
The DSA layer ta
Define the MAC trunking page offset and its register layout to implement
bonding in the next patches.
Signed-off-by: Florian Fainelli
---
drivers/net/dsa/b53/b53_regs.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/drivers/net/dsa/b53/b53_regs.h b/drivers/net/dsa/b53/b5
Utilize the recently introduced b53 LAG operations and use those as-is.
Signed-off-by: Florian Fainelli
---
drivers/net/dsa/bcm_sf2.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index 7aecc98d0a18..41a06fde7510 100644
--- a/drivers
Implement LAG operations for the DSA loopback/mock-up driver in order to
exercise the DSA core code. This just maintains a software bitmask of ports
belonging to a LAG group, we allow up to 2 LAG groups and up to 2 members per
LAG group.
Signed-off-by: Florian Fainelli
---
drivers/net/dsa/dsa_lo
Add support for LAG in the b53 driver by implementing the port_lag_join,
port_lag_leave and port_lag_member operations. port_lag_change is not supported
since the HW does not let us change anyting regarding tx_enabled or not.
Signed-off-by: Florian Fainelli
---
drivers/net/dsa/b53/b53_common.c |
Hi everyone,
Using ARRAY_SIZE improves the code readability. I used coccinelle (I
made a change to the array_size.cocci file [1]) to find several places
where ARRAY_SIZE could be used instead of other macros or sizeof
division.
I tried to divide the changes into a patch per subsystem (excepted for
Using the ARRAY_SIZE macro improves the readability of the code. Also,
it is not always useful to use a variable to store this constant
calculated at compile time.
Found with Coccinelle with the following semantic patch:
@r depends on (org || report)@
type T;
T[] E;
position p;
@@
(
(sizeof(E)@p
Begin forwarded message:
Date: Sun, 01 Oct 2017 16:22:33 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 197099] New: Kernel panic in interrupt [l2tp_ppp]
https://bugzilla.kernel.org/show_bug.cgi?id=197099
Bug ID: 197099
Summ
On 10/01/2017 07:27 PM, Colin King wrote:
> From: Colin Ian King
>
> In the unlikely event that mfc->mfc_un.res.ttls[i] is 255 for all
> values of i from 0 to MAXIVS-1, the err is not set at all and hence
> has a garbage value on the error return at the end of the function,
> so initialize it to 0
On 09/30/2017 01:23 PM, Sergei Shtylyov wrote:
> Hello!
>
> On 09/28/2017 10:21 PM, Florian Fainelli wrote:
>
> If the optional "reset-gpios" property is specified in DT, the generic
> MDIO bus code takes care of resetting the PHY during device probe.
> However, the PHY may still ha
From: Colin Ian King
In the unlikely event that mfc->mfc_un.res.ttls[i] is 255 for all
values of i from 0 to MAXIVS-1, the err is not set at all and hence
has a garbage value on the error return at the end of the function,
so initialize it to 0. Also, the error return check on err and goto
to er
> Funny, I just ran into this too and subscribed here to report it. The
> error occurs during parsing of any options to the jump target; if the
> target has no options, there is no error.
>
> The problem seems to be an outdated version of struct xtables_target in
> include/xtables.h. The version in
The patch 'ip_gre: ipgre_tap device should keep dst' fixed
the issue ipgre_tap dev mtu couldn't be updated in tx path.
The same fix is needed for erspan as well.
Fixes: 84e54fe0a5ea ("gre: introduce native tunnel support for ERSPAN")
Signed-off-by: Xin Long
---
net/ipv4/ip_gre.c | 1 +
1 file c
According to __gre_tunnel_init, tunnel->hlen should be set as the
headers' length between inner packet and outer iphdr.
It would be used especially to calculate a proper mtu when updating
mtu in tnl_update_pmtu. Now without setting it, a bigger mtu value
than expected would be updated, which hurts
As a ARPHRD_ETHER device, skb->len in erspan_xmit is the length
of the whole ether packet. So before checking if a packet size
exceeds the mtu, skb->len should subtract dev->hard_header_len.
Otherwise, all packets with max size according to mtu would be
trimmed to be truncated packet.
Fixes: 84e5
erspan only uses the first 10 bits of session_id as the key to look
up the tunnel. But in erspan_rcv, it missed 'session_id & ID_MASK'
when getting the key from session_id.
If any other flag is also set in session_id in a packet, it would
fail to find the tunnel due to incorrect key in erspan_rcv.
This patchset is to fix some issues that could cause 0 or low
performance, and even unexpected truncated packets on erspan.
Xin Long (4):
ip_gre: get key from session_id correctly in erspan_rcv
ip_gre: check packet length and mtu correctly in erspan_xmit
ip_gre: set tunnel hlen properly in e
The DMA controller regs actually point to DMA channel 0, so the write to
ENETDMA_CFG_REG will actually modify a random DMA channel.
Since DMA controller registers do not exist on BCM6345, guard the write
with the usual check for dma_has_sram.
Signed-off-by: Jonas Gorski
---
drivers/net/ethernet
Use managed functions where possible to reduce the amount of resource
handling on error and remove paths.
Signed-off-by: Jonas Gorski
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 54 +++-
1 file changed, 12 insertions(+), 42 deletions(-)
diff --git a/drivers/net/et
We don't use anyhing from that file, so drop it.
Signed-off-by: Jonas Gorski
---
drivers/net/ethernet/broadcom/bcm63xx_enet.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.h
b/drivers/net/ethernet/broadcom/bcm63xx_enet.h
index 0a1b7b2e55bd..dd6ae3
This patch set fixes a few theoretical issues and cleans up the code a
bit. It also adds a bit more managed function usage to simplify clock
and iomem usage.
Based on net-next.
Jonas Gorski (6):
bcm63xx_enet: correct clock usage
bcm63xx_enet: do not write to random DMA channel on BCM6345
bc
clk_disable and clk_unprepare are NULL-safe, so need to duplicate the
NULL check of the functions.
Signed-off-by: Jonas Gorski
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c
Check the return code of prepare_enable and change one last instance of
enable only to prepare_enable. Also properly disable and release the
clock in error paths and on remove for enetsw.
Signed-off-by: Jonas Gorski
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 31 +-
Do not rely on the shared device being probed before the enet(sw)
devices. This makes it easier to eventually move out the shared
device as a dma controller driver (what it should be).
Signed-off-by: Jonas Gorski
---
drivers/net/ethernet/broadcom/bcm63xx_enet.c | 9 ++---
1 file changed, 2 i
Hello!
On 9/28/2017 6:41 AM, David Ahern wrote:
fib_check_nh does not use the fib_info arg; remove t.
s/t/it/. :-)
Signed-off-by: David Ahern
[...]
MBR, Sergei
On 09/28/2017 08:56 PM, Florian Fainelli wrote:
> On 09/28/2017 10:34 AM, Jiri Pirko wrote:
>> From: Yotam Gigi
>>
>> Change the ipmr module to not forward packets if:
>> - The packet is marked with the offload_mr_fwd_mark, and
>> - Both input interface and output interface share the same parent
On Fri 2017-09-29 18:45:19, tristram...@microchip.com wrote:
> > > > > > Similar code will be needed by other drivers, right?
> > > > >
> > > > > Although KSZ8795 and KSZ8895 may use the same code, the other
> > > > > chips will have different code.
> > > >
> > > > Ok, please make sure code is shar
68 matches
Mail list logo
