Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

2017-09-25 Thread Arnd Bergmann
On Mon, Sep 25, 2017 at 11:32 PM, Arnd Bergmann wrote: > On Mon, Sep 25, 2017 at 7:41 AM, David Laight wrote: >> From: Arnd Bergmann >>> Sent: 22 September 2017 22:29 >> ... >>> It seems that this is triggered in part by using strlcpy(), which the >>> compiler doesn't recognize as copying at most

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-09-25 Thread Christoph Hellwig
On Tue, Sep 26, 2017 at 02:41:35PM +0800, AceLan Kao wrote: > Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI > for WLAN device. So adding a quirk to list those machines and set > use_msi automatically. > Adding Dell Inspiron 24-3460 to the quirk. Huh? Using MSI should be

[PATCH 1/6] ath9k: add MSI support and use_msi parameter

2017-09-25 Thread AceLan Kao
Adding MSI support for ath9k devices. This patch is originally from Qualcomm, but they have no intention of submitting and maintaining ath9k driver now. The credit should go to Qualcomm. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/hw.c | 33 ++-- drivers/ne

[PATCH 2/6] ath9k: add a quirk to set use_msi automatically

2017-09-25 Thread AceLan Kao
Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI for WLAN device. So adding a quirk to list those machines and set use_msi automatically. Adding Dell Inspiron 24-3460 to the quirk. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 21 ++

[PATCH 4/6] ath9k: set use_msi=1 on Dell Inspiron 3472

2017-09-25 Thread AceLan Kao
BIOS on Dell Inspiron 3472 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k

RE: [PATCH v2 net-next 10/10] net: hns3: Add mqprio support when interacting with network stack

2017-09-25 Thread Yuval Mintz
> When using tc qdisc to configure DCB parameter, dcb_ops->setup_tc > is used to tell hclge_dcb module to do the setup. While this might be a step in the right direction, this causes an inconsistency in user experience - Some [well, most] vendors didn't allow the mqprio priority mapping to affect

[PATCH 3/6] ath9k: set use_msi=1 on Dell Vostro 3262

2017-09-25 Thread AceLan Kao
BIOS on Dell Vostro 3262 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/i

[PATCH 6/6] ath9k: set use_msi=1 on Dell Inspiron 14-3473

2017-09-25 Thread AceLan Kao
BIOS on Dell Inspiron 14-3473 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/at

[PATCH 5/6] ath9k: set use_msi=1 on Dell Vostro 15-3572

2017-09-25 Thread AceLan Kao
BIOS on Dell Vostro 15-3572 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9

Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

2017-09-25 Thread Arnd Bergmann
On Mon, Sep 25, 2017 at 7:41 AM, David Laight wrote: > From: Arnd Bergmann >> Sent: 22 September 2017 22:29 > ... >> It seems that this is triggered in part by using strlcpy(), which the >> compiler doesn't recognize as copying at most 'len' bytes, since strlcpy >> is not part of the C standard. >

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Wei Wang
On Mon, Sep 25, 2017 at 7:23 PM, Eric Dumazet wrote: > On Mon, Sep 25, 2017 at 7:07 PM, Martin KaFai Lau wrote: > >> I am probably still missing something. >> >> Considering the del operation should be under the writer lock, >> if rt->rt6i_node should be NULL (for rt that has already been >> remo

[PATCH net-next v4] selftests: rtnetlink.sh: add rudimentary vrf test

2017-09-25 Thread Florian Westphal
Acked-by: David Ahern Signed-off-by: Florian Westphal --- Changes since v1: indent all lines with tabs, not spaces detaching this from the series, I want to avoid needless v5. tools/testing/selftests/net/rtnetlink.sh | 42 1 file changed, 42 insertions(+) di

Re: [Patch net-next v2] net_sched: use idr to allocate u32 filter handles

2017-09-25 Thread Jiri Pirko
Tue, Sep 26, 2017 at 01:13:46AM CEST, xiyou.wangc...@gmail.com wrote: >On Mon, Sep 25, 2017 at 12:00 PM, Jiri Pirko wrote: >> Interesting, any idea why this is not 0x7FFF as well? >> >> I wonder if we could have 0x7FFF magic defined somewhere. > >I have no idea, it just exists for a rather

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Yang, Yi
On Tue, Sep 26, 2017 at 03:28:42AM +0800, Eric Garver wrote: > On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > > + > > + length = nsh_hdr_len(nsh_hdr); > > + skb_pull(skb, length); > > Do you need to verify you can actually pull length bytes? I don't see > any guarantee. I have add

Re: [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Yang, Yi
On Tue, Sep 26, 2017 at 02:14:39AM +0800, Jiri Benc wrote: > On Mon, 25 Sep 2017 22:16:09 +0800, Yi Yang wrote: > > + return err; > > + > > + key->eth.type = htons(ETH_P_NSH); > > I wonder why you have this assignment here. The key is invalidated, > thus nothing should rely on key->eth

[PATCH net-next v10] openvswitch: enable NSH support

2017-09-25 Thread Yi Yang
v9->v10 - Change struct ovs_key_nsh to struct ovs_nsh_key_base base; __be32 context[NSH_MD1_CONTEXT_SIZE]; - Fix new comments for v9 v8->v9 - Fix build error reported by daily intel build because nsh module isn't selected by openvswitch v7->v8 - Rework nested value and mask f

Re: WARNING: kernel stack frame pointer at ffff880156a5fea0 in bash:2103 has bad value 00007ffec7d87e50

2017-09-25 Thread Alexei Starovoitov
On Mon, Sep 25, 2017 at 11:23:31PM +0200, Richard Weinberger wrote: > Hi! > > While playing with bcc's opensnoop tool on Linux 4.14-rc2 I managed to > trigger > this splat: > > [ 297.629773] WARNING: kernel stack frame pointer at 880156a5fea0 in > bash:2103 has bad value 7ffec7d87e50

Re: [PATCH v3 net-next 02/12] vxlan: Call common functions to get tunnel routes

2017-09-25 Thread kbuild test robot
Hi Tom, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/gtp-Additional-feature-support-Part-I/20170926-001629 config: x86_64-randconfig-s4-09261019 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # s

Re: [PATCH 1/2] neigh: make struct neigh_table::entry_size unsigned int

2017-09-25 Thread David Miller
From: Alexey Dobriyan Date: Sat, 23 Sep 2017 23:01:06 +0300 > Neigh entry size can't be negative. > > Space savings: > > add/remove: 0/0 grow/shrink: 0/5 up/down: 0/-7 (-7) > function old new delta > lowpan_neigh_construct

Re: [PATCH 2/2] neigh: make strucrt neigh_table::entry_size unsigned int

2017-09-25 Thread David Miller
From: Alexey Dobriyan Date: Sat, 23 Sep 2017 23:03:04 +0300 > Key length can't be negative. > > Leave comparisons against nla_len() signed just in case truncated attribute > can sneak in there. > > Space savings: > > add/remove: 0/0 grow/shrink: 0/7 up/down: 0/-7 (-7) > function

Re: [PATCH net-next] net: speed up skb_rbtree_purge()

2017-09-25 Thread David Miller
From: Eric Dumazet Date: Sat, 23 Sep 2017 12:39:12 -0700 > From: Eric Dumazet > > As measured in my prior patch ("sch_netem: faster rb tree removal"), > rbtree_postorder_for_each_entry_safe() is nice looking but much slower > than using rb_next() directly, except when tree is small enough > to

Re: [PATCH net-next v3 3/6] rtnetlink: add helper to dump ifalias

2017-09-25 Thread David Miller
From: Florian Westphal Date: Sat, 23 Sep 2017 21:26:33 +0200 > @@ -1332,6 +1332,14 @@ static int nla_put_iflink(struct sk_buff *skb, const > struct net_device *dev) > return nla_put_u32(skb, IFLA_LINK, ifindex); > } > > +static noinline int nla_put_ifalias(struct sk_buff *skb, struct ne

Re: [PATCH net-next] sch_netem: faster rb tree removal

2017-09-25 Thread David Miller
From: Eric Dumazet Date: Sat, 23 Sep 2017 11:07:28 -0700 > From: Eric Dumazet > > While running TCP tests involving netem storing millions of packets, > I had the idea to speed up tfifo_reset() and did experiments. > > I tried the rbtree_postorder_for_each_entry_safe() method that is > used in

Re: [PATCH net-next] tun: delete original tun_get() and rename __tun_get() to tun_get()

2017-09-25 Thread David Miller
From: yuan linyu Date: Sat, 23 Sep 2017 22:36:52 +0800 > From: yuan linyu > > it seems no need to keep tun_get() and __tun_get() at same time. > > Signed-off-by: yuan linyu Applied.

Re: [PATCH net-next] cxgb4: do DCB state reset in couple of places

2017-09-25 Thread David Miller
From: Ganesh Goudar Date: Sat, 23 Sep 2017 16:07:28 +0530 > reset the driver's DCB state in couple of places > where it was missing. > > Signed-off-by: Casey Leedom > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next] liquidio: pass date and time info to NIC firmware

2017-09-25 Thread David Miller
From: Andrew Lunn Date: Sat, 23 Sep 2017 17:16:54 +0200 > On Fri, Sep 22, 2017 at 05:35:18PM -0700, Felix Manlunas wrote: >> From: Veerasenareddy Burru > > This is kind of interesting. So you do this once. It could be before > the RTC driver has probed, so it is 1970. It could be before the NTP

Re: [PATCH net-next 0/3] liquidio: firmware loading

2017-09-25 Thread David Miller
From: Felix Manlunas Date: Fri, 22 Sep 2017 17:12:06 -0700 > From: Rick Farrington > > 1. Allow host driver parameter to override auto-loaded firmware (in flash). > 2. Verify version of firmware that is auto-loaded from flash. > 3. Change value of fw_type module parameter to reflect default fir

Re: [PATCH net-next v3 0/2] net: dsa: port enabling

2017-09-25 Thread David Miller
From: Vivien Didelot Date: Fri, 22 Sep 2017 19:01:54 -0400 > This patchset makes slave open and close symmetrical and provides > helpers for enabling or disabling a given DSA port. > > Changes in v3: > - save the phy_device change for a future patchset > > Changes in v2: > - do not remove t

Re: [PATCH net-next] hv_netvsc: Fix the real number of queues of non-vRSS cases

2017-09-25 Thread David Miller
From: Haiyang Zhang Date: Fri, 22 Sep 2017 15:31:38 -0700 > From: Haiyang Zhang > > For older hosts without multi-channel (vRSS) support, and some error > cases, we still need to set the real number of queues to one. > This patch adds this missing setting. > > Fixes: 8195b1396ec8 ("hv_netvsc:

Re: [PATCH v4 8/9] netlink: fix nla_put_{u8,u16,u32} for KASAN

2017-09-25 Thread David Miller
From: Arnd Bergmann Date: Fri, 22 Sep 2017 23:29:19 +0200 > When CONFIG_KASAN is enabled, the "--param asan-stack=1" causes rather large > stack frames in some functions. This goes unnoticed normally because > CONFIG_FRAME_WARN is disabled with CONFIG_KASAN by default as of commit > 3f181b4d8652

Re: [PATCH v4 7/9] rocker: fix rocker_tlv_put_* functions for KASAN

2017-09-25 Thread David Miller
From: Arnd Bergmann Date: Fri, 22 Sep 2017 23:29:18 +0200 > Inlining these functions creates lots of stack variables that each take > 64 bytes when KASAN is enabled, leading to this warning about potential > stack overflow: > > drivers/net/ethernet/rocker/rocker_ofdpa.c: In function > 'ofdpa_cm

Re: [PATCH,v3,net-next 0/2] Improve code coverage of syzkaller

2017-09-25 Thread David Miller
From: Petar Penkov Date: Fri, 22 Sep 2017 13:49:13 -0700 > This patch series is intended to improve code coverage of syzkaller on > the early receive path, specifically including flow dissector, GRO, > and GRO with frags parts of the networking stack. Syzkaller exercises > the stack through the T

[PATCH v2 net-next 00/10] Add support for DCB feature in hns3 driver

2017-09-25 Thread Yunsheng Lin
The patchset contains some enhancement related to DCB before adding support for DCB feature. This patchset depends on the following patchset: https://patchwork.ozlabs.org/cover/815646/ https://patchwork.ozlabs.org/cover/816145/ High Level Architecture: [ tc qdisc ][ lldpad ]

[PATCH v2 net-next 03/10] net: hns3: Add support for PFC setting in TM module

2017-09-25 Thread Yunsheng Lin
This patch add a pfc_pause_en cmd, and use it to configure PFC option according to fc_mode in hdev->tm_info. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 68 -- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.h | 5 ++ 2 files changed

[PATCH v2 net-next 06/10] net: hns3: Add some interface for the support of DCB feature

2017-09-25 Thread Yunsheng Lin
This patch add some interface and export some interface from hclge_tm and hclgc_main to support the upcoming DCB feature. Signed-off-by: Yunsheng Lin --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 3 +- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h| 3 ++ .../net/ethernet/hisil

[PATCH v2 net-next 04/10] net: hns3: Add support for port shaper setting in TM module

2017-09-25 Thread Yunsheng Lin
This patch add a tm_port_shaper cmd and set port shaper to HCLGE_ETHER_MAX_RATE on TM initialization process. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 32 ++ .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.h | 4 +++ 2 files chang

[PATCH v2 net-next 05/10] net: hns3: Add tc-based TM support for sriov enabled port

2017-09-25 Thread Yunsheng Lin
When sriov is enabled and TM is in tc-based mode, vf's TM parameters is not set in TM initialization process. This patch add the tc_based TM support for sriov enabled using the information in vport struct. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 49 ++

[PATCH v2 net-next 02/10] net: hns3: Add support for dynamically buffer reallocation

2017-09-25 Thread Yunsheng Lin
Current buffer allocation can only happen at init, when doing buffer reallocation after init, care must be taken care of memory which priv_buf points to. This patch fixes it by using a dynamic allocated temporary memory. Because we only do buffer reallocation at init or when setting up the DCB para

[PATCH v2 net-next 01/10] net: hns3: Support for dynamically assigning tx buffer to TC

2017-09-25 Thread Yunsheng Lin
This patch add support of dynamically assigning tx buffer to TC when the TC is enabled. It will save buffer for rx direction to avoid packet loss. Signed-off-by: Yunsheng Lin --- V2: Fix for not defining variables in local loop. V1: Initial submit. --- .../net/ethernet/hisilicon

[PATCH v2 net-next 07/10] net: hns3: Add hclge_dcb module for the support of DCB feature

2017-09-25 Thread Yunsheng Lin
The hclge_dcb module calls the interface from hclge_main/tm and provide interface for the dcb netlink interface. This patch also update Makefiles required to build the DCB supported code in HNS3 Ethernet driver and update the existing Kconfig file in the hisilicon folder. Signed-off-by: Yunsheng

[PATCH v2 net-next 09/10] net: hns3: Setting for fc_mode and dcb enable flag in TM module

2017-09-25 Thread Yunsheng Lin
After the DCB feature is supported, fc_mode and dcb enable flag must be set according to the DCB parameter. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 34 +++--- 1 file changed, 30 insertions(+), 4 deletions(-) diff --git a/drivers/net/e

[PATCH v2 net-next 10/10] net: hns3: Add mqprio support when interacting with network stack

2017-09-25 Thread Yunsheng Lin
When using tc qdisc to configure DCB parameter, dcb_ops->setup_tc is used to tell hclge_dcb module to do the setup. When using lldptool to configure DCB parameter, hclge_dcb module call the client_ops->setup_tc to tell network stack which queue and priority is using for specific tc. Signed-off-by:

[PATCH v2 net-next 08/10] net: hns3: Add dcb netlink interface for the support of DCB feature

2017-09-25 Thread Yunsheng Lin
This patch add dcb netlink interface by calling the interface from hclge_dcb module. This patch also update Makefile in order to build hns3_dcbnl module. Signed-off-by: Yunsheng Lin --- .../net/ethernet/hisilicon/hns3/hns3pf/Makefile| 2 + .../ethernet/hisilicon/hns3/hns3pf/hns3_dcbnl.c

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Eric Dumazet
On Mon, Sep 25, 2017 at 7:07 PM, Martin KaFai Lau wrote: > I am probably still missing something. > > Considering the del operation should be under the writer lock, > if rt->rt6i_node should be NULL (for rt that has already been > removed from fib6), why this WARN_ON() is triggered? > > An exampl

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Martin KaFai Lau
On Tue, Sep 26, 2017 at 01:16:05AM +, Wei Wang wrote: > On Mon, Sep 25, 2017 at 5:56 PM, Martin KaFai Lau wrote: > > On Mon, Sep 25, 2017 at 05:35:22PM +, Wei Wang wrote: > >> From: Wei Wang > >> > >> fib6_del() generates WARN_ON() when rt->dst.obsolete > 0. This does not > >> make sense

Re: [PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

2017-09-25 Thread Alexei Starovoitov
On Mon, Sep 25, 2017 at 11:44:02PM +0200, Daniel Borkmann wrote: > On 09/24/2017 07:50 AM, Alexei Starovoitov wrote: > > On Fri, Sep 22, 2017 at 09:49:10PM -0700, Y Song wrote: > > > On Fri, Sep 22, 2017 at 9:23 AM, Edward Cree wrote: > > > > On 22/09/17 16:16, Alexei Starovoitov wrote: > > > > >

Re: [PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-25 Thread 严海双
> On 2017年9月26日, at 上午7:24, David Miller wrote: > > From: Haishuang Yan > Date: Fri, 22 Sep 2017 21:48:43 +0800 > >> @@ -9,13 +9,18 @@ >> #include >> #include >> >> -struct tcp_fastopen_context __rcu *tcp_fastopen_ctx; >> - >> -static DEFINE_SPINLOCK(tcp_fastopen_ctx_lock); >> - >> -void t

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Wei Wang
On Mon, Sep 25, 2017 at 5:56 PM, Martin KaFai Lau wrote: > On Mon, Sep 25, 2017 at 05:35:22PM +, Wei Wang wrote: >> From: Wei Wang >> >> fib6_del() generates WARN_ON() when rt->dst.obsolete > 0. This does not >> make sense because it is possible that the route passed in is already >> deleted

Re: [PATCH] r8152: add Linksys USB3GIGV1 id

2017-09-25 Thread Grant Grundler
On Mon, Sep 25, 2017 at 1:17 PM, Grant Grundler wrote: ... > I didn't realize cdc_ether has a blacklist to make sure > RTL8152|RTL8153 devices are not picked up by cdc_ether. Would you > prefer I add this device to the blacklist in the same patch? I've sent a V2 which also updates the blacklist i

[PATCH V2] r8152: add Linksys USB3GIGV1 id

2017-09-25 Thread Grant Grundler
This linksys dongle by default comes up in cdc_ether mode. This patch allows r8152 to claim the device: Bus 002 Device 002: ID 13b1:0041 Linksys Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ether.c | 8 drivers/net/usb/r8152.c | 2 ++ 2 files changed, 10 insertions(+) V

Re: [PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Martin KaFai Lau
On Mon, Sep 25, 2017 at 05:35:22PM +, Wei Wang wrote: > From: Wei Wang > > fib6_del() generates WARN_ON() when rt->dst.obsolete > 0. This does not > make sense because it is possible that the route passed in is already > deleted by some other thread and rt->dst.obsolete is set to > DST_OBSOLE

Re: [Patch net-next v2] net_sched: use idr to allocate bpf filter handles

2017-09-25 Thread Daniel Borkmann
On 09/26/2017 01:11 AM, Cong Wang wrote: On Mon, Sep 25, 2017 at 2:16 PM, Daniel Borkmann wrote: On 09/25/2017 07:13 PM, Cong Wang wrote: [...] There's this condition in the code before above idr allocations, I think also in other classifiers: if (oldprog) { if (han

Re: [PATCH] [for 4.14] net: qcom/emac: specify the correct size when mapping a DMA buffer

2017-09-25 Thread David Miller
From: Timur Tabi Date: Fri, 22 Sep 2017 15:32:44 -0500 > When mapping the RX DMA buffers, the driver was accidentally specifying > zero for the buffer length. Under normal circumstances, SWIOTLB does not > need to allocate a bounce buffer, so the address is just mapped without > checking the siz

Re: [net-next] net: remove MTU limits for dummy and ifb device

2017-09-25 Thread David Miller
From: Zhang Shengju Date: Fri, 22 Sep 2017 23:57:49 +0800 > These two drivers (dummy and ifb) call ether_setup(), after commit > 61e84623ace3 ("net: centralize net_device min/max MTU checking"), the > range of mtu is [min_mtu, max_mtu], which is [68, 1500] by default. > > These two devices shoul

Re: [PATCH v4 2/3] ipv4: Namespaceify tcp_fastopen_key knob

2017-09-25 Thread David Miller
From: Haishuang Yan Date: Fri, 22 Sep 2017 21:48:43 +0800 > @@ -9,13 +9,18 @@ > #include > #include > > -struct tcp_fastopen_context __rcu *tcp_fastopen_ctx; > - > -static DEFINE_SPINLOCK(tcp_fastopen_ctx_lock); > - > -void tcp_fastopen_init_key_once(bool publish) > +void tcp_fastopen_init_

Re: [PATCH] hv_netvsc: make const array ver_list static, reduces object code size

2017-09-25 Thread David Miller
From: Colin King Date: Fri, 22 Sep 2017 16:50:23 +0100 > From: Colin Ian King > > Don't populate const array ver_list on the stack, instead make it > static. Makes the object code smaller by over 400 bytes: > > Before: >text data bss dec hex filename > 18444

Re: [Patch net-next v2] net_sched: use idr to allocate u32 filter handles

2017-09-25 Thread Cong Wang
On Mon, Sep 25, 2017 at 12:00 PM, Jiri Pirko wrote: > Interesting, any idea why this is not 0x7FFF as well? > > I wonder if we could have 0x7FFF magic defined somewhere. I have no idea, it just exists for a rather long time. Probably too late to change, or at least requires a separate pat

Re: [Patch net-next v2] net_sched: use idr to allocate bpf filter handles

2017-09-25 Thread Cong Wang
On Mon, Sep 25, 2017 at 2:16 PM, Daniel Borkmann wrote: > On 09/25/2017 07:13 PM, Cong Wang wrote: >> ret = cls_bpf_offload(tp, prog, oldprog); >> if (ret) { >> + if (!oldprog) >> + idr_remove_ext(&head->handle_idr, prog->handle); > > > Shouldn't

[PATCH net] net: dsa: Fix network device registration order

2017-09-25 Thread Florian Fainelli
We cannot be registering the network device first, then setting its carrier off and finally connecting it to a PHY, doing that leaves a window during which the carrier is at best inconsistent, and at worse the device is not usable without a down/up sequence since the network device is visible to us

[jkirsher/next-queue PATCH] ixgbe: Update adaptive ITR algorithm

2017-09-25 Thread Alexander Duyck
From: Alexander Duyck The following change is meant to update the adaptive ITR algorithm to better support the needs of the network. Specifically with this change what I have done is make it so that our ITR algorithm will try to prevent either starving a socket buffer for memory in the case of Tx

Re: [PATCH net-next] sch_netem: faster rb tree removal

2017-09-25 Thread David Ahern
On 9/25/17 2:11 PM, David Miller wrote: > From: David Ahern > Date: Mon, 25 Sep 2017 10:14:23 -0600 > >> I made a simple program this morning and ran it under perf. > > If possible please submit this for selftests. > It is more of a microbenchmark of options to flush an rbtree than a self-test

Re: [PATCH net 0/2] l2tp: fix some races in session deletion

2017-09-25 Thread David Miller
From: Guillaume Nault Date: Fri, 22 Sep 2017 15:39:22 +0200 > L2TP provides several interfaces for deleting sessions. Using two of > them concurrently can lead to use-after-free bugs. > > Patch #2 uses a flag to prevent double removal of L2TP sessions. > Patch #1 fixes a bug found in the way. Fi

Re: [PATCH net-next] bpf/verifier: improve disassembly of BPF_END instructions

2017-09-25 Thread Daniel Borkmann
On 09/24/2017 07:50 AM, Alexei Starovoitov wrote: On Fri, Sep 22, 2017 at 09:49:10PM -0700, Y Song wrote: On Fri, Sep 22, 2017 at 9:23 AM, Edward Cree wrote: On 22/09/17 16:16, Alexei Starovoitov wrote: looks like we're converging on "be16/be32/be64/le16/le32/le64 #register" for BPF_END. I gu

Re: [patch net] net: dsa: mv88e6xxx: Allow dsa and cpu ports in multiple vlans

2017-09-25 Thread Vivien Didelot
Andrew Lunn writes: > Ports with the same VLAN must all be in the same bridge. However the > CPU and DSA ports need to be in multiple VLANs spread over multiple > bridges. So exclude them when performing this test. > > Fixes: b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") > Sign

Re: [PATCH net-next v2] bpf: Optimize lpm trie delete

2017-09-25 Thread David Miller
From: Craig Gallek Date: Thu, 21 Sep 2017 18:43:29 -0400 > From: Craig Gallek > > Before the delete operator was added, this datastructure maintained > an invariant that intermediate nodes were only present when necessary > to build the tree. This patch updates the delete operation to reinstat

[patch net] net: dsa: mv88e6xxx: Allow dsa and cpu ports in multiple vlans

2017-09-25 Thread Andrew Lunn
Ports with the same VLAN must all be in the same bridge. However the CPU and DSA ports need to be in multiple VLANs spread over multiple bridges. So exclude them when performing this test. Fixes: b2f81d304cee ("net: dsa: add CPU and DSA ports as VLAN members") Signed-off-by: Andrew Lunn --- driv

WARNING: kernel stack frame pointer at ffff880156a5fea0 in bash:2103 has bad value 00007ffec7d87e50

2017-09-25 Thread Richard Weinberger
Hi! While playing with bcc's opensnoop tool on Linux 4.14-rc2 I managed to trigger this splat: [ 297.629773] WARNING: kernel stack frame pointer at 880156a5fea0 in bash:2103 has bad value 7ffec7d87e50 [ 297.629777] unwind stack type:0 next_sp: (null) mask:0x6 graph_idx:0 [

Re: [Patch net-next v2] net_sched: use idr to allocate bpf filter handles

2017-09-25 Thread Daniel Borkmann
On 09/25/2017 07:13 PM, Cong Wang wrote: Instead of calling cls_bpf_get() in a loop to find a unused handle, just switch to idr API to allocate new handles. Cc: Daniel Borkmann Cc: Chris Mi Cc: Jamal Hadi Salim Signed-off-by: Cong Wang [...] @@ -476,21 +462,30 @@ static int cls_bpf_change(

Re: Investment Consideration

2017-09-25 Thread John Hanan, MBA, CFA
mThank you for your time, We are looking for clients in your country with good business or project that requires financing to execute. Please get back to me if you are interested in this or you know anybody who has good business ideas but lack the necessary capital to fund his projects so we ca

[PATCH net-next] net: ipv6: send NS for DAD when link operationally up

2017-09-25 Thread Mike Manning
The NS for DAD are sent on admin up as long as a valid qdisc is found. A race condition exists by which these packets will not egress the interface if the operational state of the lower device is not yet up. The solution is to delay DAD until the link is operationally up according to RFC2863. Rathe

Re: [PATCH v2 0/2] enable hires timer to timeout datagram socket

2017-09-25 Thread Thomas Gleixner
On Wed, 20 Sep 2017, Vallish Vaidyeshwara wrote: > On Sat, Sep 16, 2017 at 11:47:56AM +0200, Thomas Gleixner wrote: > > > So if we need to replace all 'legacy' timers to high resolution timer, > > > because some application was _relying_ on jiffies being kind of precise, > > > maybe it is better to

Re: [RFC PATCH 00/11] udp: full early demux for unconnected sockets

2017-09-25 Thread Paolo Abeni
On Fri, 2017-09-22 at 14:58 -0700, Eric Dumazet wrote: > On Fri, 2017-09-22 at 23:06 +0200, Paolo Abeni wrote: > > This series refactor the UDP early demux code so that: > > > > * full socket lookup is performed for unicast packets > > * a sk is grabbed even for unconnected socket match > > * a ds

Re: [PATCH v2 1/4] net: af_packet: use setup_timer() helper.

2017-09-25 Thread David Miller
From: Allen Pais Date: Mon, 25 Sep 2017 13:00:02 +0530 > Use setup_timer function instead of initializing timer with the > function and data fields. > > Signed-off-by: Allen Pais > --- > v2: rebased to latest net-next. Applied.

Re: [PATCH v2 2/4] net: nfc: hci: use setup_timer() helper.

2017-09-25 Thread David Miller
From: Allen Pais Date: Mon, 25 Sep 2017 13:00:03 +0530 > Use setup_timer function instead of initializing timer with the >function and data fields. > > Signed-off-by: Allen Pais > --- > v2: rebased to latest net-next. Applied.

Re: [PATCH v2 3/4] net: nfc: hci: llc_shdlc: use setup_timer() helper.

2017-09-25 Thread David Miller
From: Allen Pais Date: Mon, 25 Sep 2017 13:00:04 +0530 > Use setup_timer function instead of initializing timer with the >function and data fields. > > Signed-off-by: Allen Pais > --- > v2: rebased to latest net-next. Applied.

Re: [PATCH v2 4/4] net: nfc: llcp_core: use setup_timer() helper.

2017-09-25 Thread David Miller
From: Allen Pais Date: Mon, 25 Sep 2017 13:00:05 +0530 > Use setup_timer function instead of initializing timer with the >function and data fields. > > Signed-off-by: Allen Pais > --- > v2: rebased to latest net-next. Applied.

Re: Regression in throughput between kvm guests over virtual bridge

2017-09-25 Thread Matthew Rosato
On 09/22/2017 12:03 AM, Jason Wang wrote: > > > On 2017年09月21日 03:38, Matthew Rosato wrote: >>> Seems to make some progress on wakeup mitigation. Previous patch tries >>> to reduce the unnecessary traversal of waitqueue during rx. Attached >>> patch goes even further which disables rx polling dur

Re: [PATCH] r8152: add Linksys USB3GIGV1 id

2017-09-25 Thread Grant Grundler
[grrhmail...sorry! resending as plain text] Hallo Oliver! On Mon, Sep 25, 2017 at 7:51 AM, Oliver Neukum wrote: > Am Freitag, den 22.09.2017, 12:06 -0700 schrieb Grant Grundler: > > This Linksys dongle by default comes up in cdc_ether mode. > > This patch allows r8152 to claim the device: > >

Re: [PATCH net-next] sch_netem: faster rb tree removal

2017-09-25 Thread David Miller
From: David Ahern Date: Mon, 25 Sep 2017 10:14:23 -0600 > I made a simple program this morning and ran it under perf. If possible please submit this for selftests. Thank you.

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-25 Thread John Fastabend
On 09/25/2017 11:50 AM, Daniel Borkmann wrote: > On 09/25/2017 08:10 PM, Andy Gospodarek wrote: > [...] >> First, thanks for this detailed description.  It was helpful to read >> along with the patches. >> >> My only concern about this area being generic is that you are now in a >> state where any

Re: [ovs-dev] [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Eric Garver
On Mon, Sep 25, 2017 at 10:16:09PM +0800, Yi Yang wrote: > v8->v9 > - Fix build error reported by daily intel build >because nsh module isn't selected by openvswitch > > v7->v8 > - Rework nested value and mask for OVS_KEY_ATTR_NSH > - Change pop_nsh to adapt to nsh kernel module > - Fix ma

Re: [Patch net-next v2] net_sched: use idr to allocate u32 filter handles

2017-09-25 Thread Jiri Pirko
Mon, Sep 25, 2017 at 07:13:51PM CEST, xiyou.wangc...@gmail.com wrote: >Instead of calling u32_lookup_ht() in a loop to find >a unused handle, just switch to idr API to allocate >new handles. u32 filters are special as the handle >could contain a hash table id and a key id, so we >need two IDR to al

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-25 Thread Daniel Borkmann
On 09/25/2017 08:10 PM, Andy Gospodarek wrote: [...] First, thanks for this detailed description. It was helpful to read along with the patches. My only concern about this area being generic is that you are now in a state where any bpf program must know about all the bpf programs in the receive

Re: [PATCH net-next 2/7] nfp: compile flower vxlan tunnel metadata match fields

2017-09-25 Thread Or Gerlitz
On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman wrote: > From: John Hurley > > Compile ovs-tc flower vxlan metadata match fields for offloading. Only anything in the npf kernel bits has direct relation to ovs? what? > +++ b/drivers/net/ethernet/netronome/nfp/flower/offload.c > @@ -52,8 +52,25 @@

Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive

2017-09-25 Thread Or Gerlitz
On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman wrote: > From: John Hurley > > Periodically receive messages containing the destination IPs of tunnels > that have recently forwarded traffic. Update the neighbour entries 'used' > value for these IPs next hop. Are you proactively sending keep alive

Re: [PATCH net-next v9] openvswitch: enable NSH support

2017-09-25 Thread Jiri Benc
On Mon, 25 Sep 2017 22:16:09 +0800, Yi Yang wrote: > + skb->protocol = htons(ETH_P_NSH); > + skb_reset_mac_header(skb); > + skb_reset_mac_len(skb); > + skb_reset_network_header(skb); The last two lines are swapped. Network header needs to be reset before mac_len. > + > + retur

[PATCH iproute2] tc: fix ipv6 filter selector attribute for some prefix lengths

2017-09-25 Thread Yulia Kartseva
Wrong TCA_U32_SEL attribute packing if prefixLen AND 0x1f equals 0x1f. These are /31, /63, /95 and /127 prefix lengths. Example: # tc filter add dev eth0 protocol ipv6 parent b: prio 2307 u32 match ip6 dst face:b00f::/31 # tc filter show dev eth0 filter parent b: protocol ipv6 pref 2307 u32 filte

Re: [PATCH net-next 2/6] bpf: add meta pointer for direct access

2017-09-25 Thread Andy Gospodarek
On Mon, Sep 25, 2017 at 02:25:51AM +0200, Daniel Borkmann wrote: > This work enables generic transfer of metadata from XDP into skb. The > basic idea is that we can make use of the fact that the resulting skb > must be linear and already comes with a larger headroom for supporting > bpf_xdp_adjust_

[PATCH net] ipv6: remove incorrect WARN_ON() in fib6_del()

2017-09-25 Thread Wei Wang
From: Wei Wang fib6_del() generates WARN_ON() when rt->dst.obsolete > 0. This does not make sense because it is possible that the route passed in is already deleted by some other thread and rt->dst.obsolete is set to DST_OBSOLETE_DEAD. So this commit deletes this WARN_ON() and also remove the "#i

[Patch net-next v2] net_sched: use idr to allocate basic filter handles

2017-09-25 Thread Cong Wang
Instead of calling basic_get() in a loop to find a unused handle, just switch to idr API to allocate new handles. Cc: Chris Mi Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/cls_basic.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-)

[Patch net-next v2] net_sched: use idr to allocate u32 filter handles

2017-09-25 Thread Cong Wang
Instead of calling u32_lookup_ht() in a loop to find a unused handle, just switch to idr API to allocate new handles. u32 filters are special as the handle could contain a hash table id and a key id, so we need two IDR to allocate each of them. Cc: Chris Mi Cc: Jamal Hadi Salim Signed-off-by: Co

[Patch net-next v2] net_sched: use idr to allocate bpf filter handles

2017-09-25 Thread Cong Wang
Instead of calling cls_bpf_get() in a loop to find a unused handle, just switch to idr API to allocate new handles. Cc: Daniel Borkmann Cc: Chris Mi Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/cls_bpf.c | 57 ++--- 1 file changed

Re: [PATCH net-next 0/7] nfp: flower vxlan tunnel offload

2017-09-25 Thread Simon Horman
On Mon, Sep 25, 2017 at 06:25:03PM +0300, Or Gerlitz wrote: > On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman > wrote: > > From: Simon Horman > > > > John says: > > > > This patch set allows offloading of TC flower match and set tunnel fields > > to the NFP. The initial focus is on VXLAN traffic. D

Re: [PATCH net-next] sch_netem: faster rb tree removal

2017-09-25 Thread Eric Dumazet
On Mon, 2017-09-25 at 10:14 -0600, David Ahern wrote: > Thanks for the test. > > I made a simple program this morning and ran it under perf. With the > above suggestion the rb_erase has a high cost because it always deletes > the root node. Your method 1 has a high cost on rb_first which is > exp

Re: [Patch net-next] net_sched: use idr to allocate bpf filter handles

2017-09-25 Thread Cong Wang
On Mon, Sep 25, 2017 at 9:46 AM, Cong Wang wrote: > On Sat, Sep 23, 2017 at 5:15 PM, David Miller wrote: >> If I read the code properly, the existing code allows IDs from '1' to >> and including '0x7ffe', whereas the new code allows up to and >> including '0x7'. >> >> Whether intentio

Re: [Patch net-next] net_sched: use idr to allocate bpf filter handles

2017-09-25 Thread Cong Wang
On Sat, Sep 23, 2017 at 5:15 PM, David Miller wrote: > If I read the code properly, the existing code allows IDs from '1' to > and including '0x7ffe', whereas the new code allows up to and > including '0x7'. > > Whether intentional or not this is a change in behavior. If it's OK, > it

Re: [PATCH,v3,net-next 2/2] tun: enable napi_gro_frags() for TUN/TAP driver

2017-09-25 Thread महेश बंडेवार
On Fri, Sep 22, 2017 at 1:49 PM, Petar Penkov wrote: > Add a TUN/TAP receive mode that exercises the napi_gro_frags() > interface. This mode is available only in TAP mode, as the interface > expects packets with Ethernet headers. > > Furthermore, packets follow the layout of the iovec_iter that wa

Re: [PATCH,v3,net-next 1/2] tun: enable NAPI for TUN/TAP driver

2017-09-25 Thread महेश बंडेवार
On Fri, Sep 22, 2017 at 1:49 PM, Petar Penkov wrote: > Changes TUN driver to use napi_gro_receive() upon receiving packets > rather than netif_rx_ni(). Adds flag IFF_NAPI that enables these > changes and operation is not affected if the flag is disabled. SKBs > are constructed upon packet arrival

Re: [PATCH net-next] sch_netem: faster rb tree removal

2017-09-25 Thread David Ahern
On 9/24/17 11:27 PM, Eric Dumazet wrote: > On Sun, 2017-09-24 at 20:05 -0600, David Ahern wrote: >> On 9/24/17 7:57 PM, David Ahern wrote: > >>> Hi Eric: >>> >>> I'm guessing the cost is in the rb_first and rb_next computations. Did >>> you consider something like this: >>> >>> struct rb_r

[PATCH net-next] inetpeer: speed up inetpeer_invalidate_tree()

2017-09-25 Thread Eric Dumazet
From: Eric Dumazet As measured in my prior patch ("sch_netem: faster rb tree removal"), rbtree_postorder_for_each_entry_safe() is nice looking but much slower than using rb_next() directly, except when tree is small enough to fit in CPU caches (then the cost is the same) From: Eric Dumazet ---

  1   2   3   >